Re: [git patches] net driver updates

2007-10-08 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Fri, 5 Oct 2007 14:20:08 -0400 Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem Pulled, and pushed back out to net-2.6.24, thanks Jeff. - To unsubscribe from this list:

Re: [NET] IPv6 oops bisected

2007-10-08 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Sun, 07 Oct 2007 10:56:07 -0400 /etc/sysconfig/network-scripts/network-functions-ipv6: line 246: 1760 Killed LC_ALL=C /sbin/ip $options NULL pointer dereference at 0x03f8 backtrace: :ipv6:ip6_route_add+0x1b1/0x543 'dev' can be NULL

Re: [NET] IPv6 oops bisected

2007-10-08 Thread Herbert Xu
On Sun, Oct 07, 2007 at 11:16:08PM -0700, David Miller wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index a7db84c..7109ad6 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1188,7 +1188,7 @@ int ip6_route_add(struct fib6_config *cfg) if ((cfg-fc_flags RTF_REJECT) ||

Re: [patch 0/2] [AF_IUCV] fixes for net-2.6.24

2007-10-08 Thread David Miller
From: Ursula Braun [EMAIL PROTECTED] Date: Thu, 04 Oct 2007 16:46:08 +0200 the following 2 patches are intended for 2.6.24 and contain: - removal of static declarations in af_iucv header file - postpone receival of inbound packets in af_iucv These patches don't apply, for one thing the first

Re: [NET] IPv6 oops bisected

2007-10-08 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Mon, 8 Oct 2007 14:19:42 +0800 On Sun, Oct 07, 2007 at 11:16:08PM -0700, David Miller wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index a7db84c..7109ad6 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1188,7 +1188,7 @@ int

Re: [PATCH 1/4][TG3]: Walk PCI capability lists.

2007-10-08 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Fri, 05 Oct 2007 20:37:02 -0700 [TG3]: Walk PCI capability lists. Newer tg3 devices shuffle around the registers in PCI configuration space. This patch changes the way the driver accesses the PCI capabilities registers. Hardcoded register

Re: [PATCH 2/4][TG3]: ASIC decoding and basic CPMU support.

2007-10-08 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Fri, 05 Oct 2007 20:37:38 -0700 [TG3]: ASIC decoding and basic CPMU support. Newer products change the way the ASIC revision is obtained. This patch implements how the driver will extract the revision number. This patch also adds preliminary

Re: [PATCH 3/4][TG3]: Add 5784 and 5764 support.

2007-10-08 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Fri, 05 Oct 2007 20:37:54 -0700 [TG3]: Add 5784 and 5764 support. This patch adds the support for 5784 and 5764 devices. Signed-off-by: Matt Carlson [EMAIL PROTECTED] Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied. - To unsubscribe from

Re: [PATCH 4/4][TG3]: Update version to 3.82.

2007-10-08 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Fri, 05 Oct 2007 20:38:13 -0700 [TG3]: Update version to 3.82. Signed-off-by: Michael Chan [EMAIL PROTECTED] Also applied, thanks Michael. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH][TG3]Some cleanups

2007-10-08 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Sun, 07 Oct 2007 11:12:21 -0400 Ok, attached patch against net-2.6.24 from this morning. I am setting up some equipment for testing as i type this - so i will test for any regressions. If you dont hear from me on the subject then all went ok. This cleanup

Re: [NET] IPv6 oops bisected

2007-10-08 Thread Denis V. Lunev
David Miller wrote: From: Herbert Xu [EMAIL PROTECTED] Date: Mon, 8 Oct 2007 14:19:42 +0800 On Sun, Oct 07, 2007 at 11:16:08PM -0700, David Miller wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index a7db84c..7109ad6 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@

Re: [PATCH 1/3] [TCP]: Fix two off-by-one errors in fackets_out adjusting logic

2007-10-08 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Wed, 3 Oct 2007 14:00:16 +0300 1) Passing wrong skb to tcp_adjust_fackets_out could corrupt fastpath_cnt_hint as tcp_skb_pcount(next_skb) is not included to it if hint points exactly to the next_skb (it's lagging behind, see sacktag). 2) When

Re: [PATCH 2/3] [TCP]: Comment fastpath_cnt_hint off-by-one trap

2007-10-08 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Wed, 3 Oct 2007 14:00:17 +0300 Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 3/3] [TCP]: Annotate another fackets_out state reset

2007-10-08 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Wed, 3 Oct 2007 14:00:18 +0300 This should no longer be necessary because fackets_out is accurate. It indicates bugs elsewhere, thus report it. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Applied, thanks. - To unsubscribe from this list: send

Re: [PATCH net-2.6.24] [TCP]: Fix fastpath_cnt_hint when GSO skb is partially ACKed

2007-10-08 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 4 Oct 2007 23:20:34 +0300 (EEST) Dave should apply both the three patch series fix and this one as well to net-2.6.24 (Dave, in case you want me to resubmit, just ask... :-)). I'll send one against .23-rc9 soon after this (sadly enough, it

Re: [PATCH] Fix rose.ko oops on unload

2007-10-08 Thread David Miller
From: Alexey Dobriyan [EMAIL PROTECTED] Date: Wed, 3 Oct 2007 22:54:13 +0400 Quick'n'dirty fix to 100% oops on rmmod rose. Do you want me to properly unwind everything before .24? Patch applied, thanks Alexey. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [NET] IPv6 oops bisected

2007-10-08 Thread David Miller
From: Denis V. Lunev [EMAIL PROTECTED] Date: Mon, 08 Oct 2007 10:34:23 +0400 OK. I am installing Fedora 7 right now... You don't need to install Fedora, just read the code! :-) The bug is obvious and it's been explained thoroughly in this thread. When 'dev' is NULL in ip6_route_add() we need

Re: [NET] IPv6 oops bisected

2007-10-08 Thread Denis V. Lunev
David Miller wrote: From: Denis V. Lunev [EMAIL PROTECTED] Date: Mon, 08 Oct 2007 10:34:23 +0400 OK. I am installing Fedora 7 right now... You don't need to install Fedora, just read the code! :-) The bug is obvious and it's been explained thoroughly in this thread. When 'dev' is

Re: [PATCH net-2.6.24] net: sparse warning fixes

2007-10-08 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 5 Oct 2007 17:14:07 -0700 Fix a bunch of sparse warnings. Mostly about 0 used as NULL pointer, and shadowed variable declarations. The two noteable changes are: * hash size should have been unsigned * cls_u32 had a case where error

Re: [RFC net-2.6.24] skbuff: change skb_frag_struct to scatterlist

2007-10-08 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 5 Oct 2007 17:43:22 -0700 Replace the skb frag list with the common scatterlist definition. This allows device drivers to use dma_scatter/gather operations which may be faster on some platforms. As a side benefit, it is easier to handle dma

Re: [PATCH] net/core: split dev_ifsioc() according to locking

2007-10-08 Thread David Miller
From: Arnd Bergmann [EMAIL PROTECTED] Date: Sun, 7 Oct 2007 02:17:08 +0200 On Saturday 06 October 2007, Jeff Garzik wrote: This always bugged me:  dev_ioctl() called dev_ifsioc() either inside read_lock(dev_base_lock) or rtnl_lock(), depending on the ioctl being executed. This

Re: [IPv6] Fix ICMPv6 redirect handling with target multicast address, try 3

2007-10-08 Thread David Miller
From: Brian Haley [EMAIL PROTECTED] Date: Wed, 03 Oct 2007 10:44:17 -0400 When the ICMPv6 Target address is multicast, Linux processes the redirect instead of dropping it. The problem is in this code in ndisc_redirect_rcv(): if (ipv6_addr_equal(dest, target)) {

Re: [Devel] [PATCH][NETNS] Move some code into __init section when CONFIG_NET_NS=n

2007-10-08 Thread David Miller
From: Alexey Dobriyan [EMAIL PROTECTED] Date: Thu, 4 Oct 2007 18:02:02 +0400 On Thu, Oct 04, 2007 at 05:54:11PM +0400, Pavel Emelyanov wrote: With the net namespaces many code leaved the __init section, thus making the kernel occupy more memory than it did before. Since we have a config

Re: [PATCH][NETNS] Move some code into __init section when CONFIG_NET_NS=n

2007-10-08 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Thu, 04 Oct 2007 17:54:11 +0400 With the net namespaces many code leaved the __init section, thus making the kernel occupy more memory than it did before. Since we have a config option that prohibits the namespace creation, the functions that

Re: [PATCH 2/4][TG3]: ASIC decoding and basic CPMU support.

2007-10-08 Thread Christoph Hellwig
On Fri, Oct 05, 2007 at 08:37:38PM -0700, Michael Chan wrote: [TG3]: ASIC decoding and basic CPMU support. Newer products change the way the ASIC revision is obtained. This patch implements how the driver will extract the revision number. Just curious: is there a diagram somewhere that

Re: [Devel] [PATCH][NETNS] Move some code into __init section when CONFIG_NET_NS=n

2007-10-08 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Mon, 08 Oct 2007 00:17:16 -0700 (PDT) I'm going to apply Pavel's patch, if you want to touch it up do so as a followon patch, thanks! Actually, I take that back, it doesn't even build, I'm therefore removing the patch: LD .tmp_vmlinux1

[PATCH] libertas link error due to gcc `smartness'

2007-10-08 Thread Geert Uytterhoeven
Some versions of gcc replace strstr() calls with a single-character `needle' parameter by strchr() behind our back. This causes a link error if strchr() is defined as an inline function in asm/string.h (e.g. on m68k): | drivers/built-in.o: In function `libertas_parse_chan': |

Re: [PATCH] IrDA: Oops fix for ksdazzle

2007-10-08 Thread David Miller
From: Samuel Ortiz [EMAIL PROTECTED] Date: Mon, 1 Oct 2007 02:21:38 +0300 Hi Dave, This is the last remaining patch for IrDA, against net-2.6.24. It fixes a kernel oops triggered by the ksdazzle SIR driver. We need more space for input frames, and 2048 should be plenty of it.

Re: [PATCH 2.6.24] tg3: fix ethtool autonegotiate flags

2007-10-08 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Tue, 02 Oct 2007 15:02:56 -0700 On Tue, 2007-10-02 at 16:16 -0400, Andy Gospodarek wrote: Adding that flag in tg3_set_settings seemed like the most logical place since the driver works fine on boot. This is just an issue when re-enabling

[patch 0/2] [AF_IUCV] fixes for net-2.6.24 - cleanup resend

2007-10-08 Thread Ursula Braun
-- Dave, this is the resend of my patches from last week built against net-2.6.24. the following 2 patches are intended for 2.6.24 and contain: - removal of static declarations in af_iucv header file - postpone receival of inbound packets in af_iucv Regards, Ursula - To unsubscribe from

[patch 1/2] af_iucv: remove static declarations from header file.

2007-10-08 Thread Ursula Braun
From: Heiko Carstens [EMAIL PROTECTED] Signed-off-by: Heiko Carstens [EMAIL PROTECTED] Signed-off-by: Ursula Braun [EMAIL PROTECTED] --- include/net/iucv/af_iucv.h | 20 net/iucv/af_iucv.c |3 +++ 2 files changed, 3 insertions(+), 20 deletions(-) Index:

[patch 2/2] af_iucv: postpone receival of iucv-packets

2007-10-08 Thread Ursula Braun
From: Ursula Braun [EMAIL PROTECTED] AF_IUCV socket programs may waste Linux storage, because af_iucv allocates an skb whenever posted by the receive callback routine and receives the message immediately. Message receival is now postponed if data from previous callbacks has not yet been

Re: [patch 0/2] [AF_IUCV] fixes for net-2.6.24 - cleanup resend

2007-10-08 Thread David Miller
From: Ursula Braun [EMAIL PROTECTED] Date: Mon, 08 Oct 2007 10:51:19 +0200 -- Dave, this is the resend of my patches from last week built against net-2.6.24. the following 2 patches are intended for 2.6.24 and contain: - removal of static declarations in af_iucv header file -

Re: [PATCH 1/3] [NET_BATCH] Introduce batching interface

2007-10-08 Thread Krishna Kumar2
Hi Jamal, If you don't mind, I am trying to run your approach vs mine to get some results for comparison. For starters, I am having issues with iperf when using your infrastructure code with my IPoIB driver - about 100MB is sent and then everything stops for some reason. The changes in the IPoIB

Re: [BNX2X][PATCH 0/8] New driver for Broadcom 10Gb Ethernet, take two.

2007-10-08 Thread Eliezer Tamir
Matti Aarnio wrote: Your patch-posting procedure is yet in a bit problem state.. +{ +static const u32 EVST_TSEM_FAST_MEMORY_COMMON_MEMORY_INIT_EMULATION_7[] = { +0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, +0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,

Re: [RFC][PATCH 1/2] TCP: fix lost retransmit detection

2007-10-08 Thread Ilpo Järvinen
On Sun, 7 Oct 2007, TAKANO Ryousei wrote: From: Ilpo Järvinen [EMAIL PROTECTED] Subject: Re: [RFC][PATCH 1/2] TCP: fix lost retransmit detection Date: Fri, 5 Oct 2007 13:02:07 +0300 (EEST) On Thu, 4 Oct 2007, TAKANO Ryousei wrote: In case sacktag uses fastpath, this code won't be

Re: [RFC][PATCH 2/2] TCP: skip processing cached SACK blocks

2007-10-08 Thread Ilpo Järvinen
On Sun, 7 Oct 2007, TAKANO Ryousei wrote: From: Ilpo Järvinen [EMAIL PROTECTED] On Thu, 4 Oct 2007, TAKANO Ryousei wrote: @@ -1083,6 +1104,9 @@ tcp_sacktag_write_queue(struct sock *sk, struct sk_buff *ack_skb, u32 prior_snd_ int fack_count; int dup_sack =

[0/7] IPsec: Preparatory patcheds for async crypto on output

2007-10-08 Thread Herbert Xu
Hi Dave: Here is a bunch of patches paving the way for removal of the state spin lock on the output path so that we can let the crypto complete asynchronously. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page:

[PATCH 1/7] [IPSEC] esp: Remove keys from esp_data structure

2007-10-08 Thread Herbert Xu
[IPSEC] esp: Remove keys from esp_data structure The keys are only used during initialisation so we don't need to carry them in esp_data. Since we don't have to allocate them again, there is no need to place a limit on the authentication key length anymore. This patch also kills the unused

[PATCH 2/7] [IPSEC] ah: Remove keys from ah_data structure

2007-10-08 Thread Herbert Xu
[IPSEC] ah: Remove keys from ah_data structure The keys are only used during initialisation so we don't need to carry them in esp_data. Since we don't have to allocate them again, there is no need to place a limit on the authentication key length anymore. Signed-off-by: Herbert Xu [EMAIL

[PATCH 4/7] [IPSEC]: Move xfrm_state_check into xfrm_output.c

2007-10-08 Thread Herbert Xu
[IPSEC]: Move xfrm_state_check into xfrm_output.c The functions xfrm_state_check and xfrm_state_check_space are only used by the output code in xfrm_output.c so we can move them over. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- include/net/xfrm.h |1 - net/xfrm/xfrm_output.c | 22

[PATCH 3/7] [IPSEC]: Move common output code to xfrm_output

2007-10-08 Thread Herbert Xu
[IPSEC]: Move common output code to xfrm_output Most of the code in xfrm4_output_one and xfrm6_output_one are identical so this patch moves them into a common xfrm_output function which will live in net/xfrm. In fact this would seem to fix a bug as on IPv4 we never reset the network header after

[PATCH 5/7] [IPSEC]: Move output replay code into xfrm_output

2007-10-08 Thread Herbert Xu
[IPSEC]: Move output replay code into xfrm_output The replay counter is one of only two remaining things in the output code that requires a lock on the xfrm state (the other being the crypto). This patch moves it into the generic xfrm_output so we can remove the lock from the transforms

[PATCH 6/7] [IPSEC]: Unexport xfrm_replay_notify

2007-10-08 Thread Herbert Xu
[IPSEC]: Unexport xfrm_replay_notify Now that the only callers of xfrm_replay_notify are in xfrm, we can remove the export. This patch also removes xfrm_aevent_doreplay since it's now called in just one spot. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- include/net/xfrm.h |6 --

[PATCH 7/7] [IPSEC]: Move RO-specific output code into xfrm6_mode_ro.c

2007-10-08 Thread Herbert Xu
[IPSEC]: Move RO-specific output code into xfrm6_mode_ro.c The lastused update check in xfrm_output can be done just as well in the mode output function which is specific to RO. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- net/ipv6/xfrm6_mode_ro.c |4 net/xfrm/xfrm_output.c |

[PATCH 1/3] [NET_BATCH] Introduce batching interface

2007-10-08 Thread jamal
This patch introduces the netdevice interface for batching. cheers, jamal [NET_BATCH] Introduce batching interface This patch introduces the netdevice interface for batching. BACKGROUND - A driver dev-hard_start_xmit() has 4 typical parts: a) packet formating (example vlan, mss,

Re: 2.6.23-rc8-mm2 BUG: register_netdevice() issue as (ab)used by ISDN

2007-10-08 Thread Karsten Keil
On Sun, Oct 07, 2007 at 02:06:53PM +0200, Andreas Mohr wrote: [not necessarily a very recent regression, used 2.6.19 kernels before...] Hi all, wondered why my main internet server (headless!) didn't come up properly on a new 2.6.23-rc8-mm2 ... as if it's the BUG_ON(!dev-nd_net);

Re: [0/7] IPsec: Preparatory patcheds for async crypto on output

2007-10-08 Thread Evgeniy Polyakov
On Mon, Oct 08, 2007 at 07:28:18PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: Here is a bunch of patches paving the way for removal of the state spin lock on the output path so that we can let the crypto complete asynchronously. Hi Herbert. This looks great. I especially like xfrm output

[BNX2X RESUBMIT][PATCH 0/8] New driver for Broadcom 10Gb Ethernet, take two.

2007-10-08 Thread Eliezer Tamir
[resubmitting, this time without line breaks, sorry] This is an initial version of the BNX2X, the Linux driver for the BCM5771X 10Gb Ethernet controller family. Although the chip is very different from the 5706-8 family we based the driver code on the BNX2 driver. Since the hardware is

[BNX2X RESUBMIT][PATCH 1/8] add bnx2x to Kconfig and Makefile

2007-10-08 Thread Eliezer Tamir
Add bnx2x to Kconfig and Makefile Signed-off-by: Eliezer Tamir [EMAIL PROTECTED] --- drivers/net/Kconfig |9 + drivers/net/Makefile |1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 9c635a2..1d44a5e 100644 ---

[BNX2X RESUBMIT][PATCH 3/8] bnx2x.h

2007-10-08 Thread Eliezer Tamir
bnx2x.h - main .h file Signed-off-by: Eliezer Tamir [EMAIL PROTECTED] --- drivers/net/bnx2x.h | 997 +++ 1 files changed, 997 insertions(+), 0 deletions(-) diff --git a/drivers/net/bnx2x.h b/drivers/net/bnx2x.h new file mode 100644 index

[BNX2X RESUBMIT][PATCH 5/8] bnx2x_init.h

2007-10-08 Thread Eliezer Tamir
bnx2x_init.h - code that does chip init Signed-off-by: Eliezer Tamir [EMAIL PROTECTED] --- drivers/net/bnx2x_init.h | 555 ++ 1 files changed, 555 insertions(+), 0 deletions(-) diff --git a/drivers/net/bnx2x_init.h b/drivers/net/bnx2x_init.h new

[BNX2X RESUBMIT][PATCH 7/8] bnx2x_self_test.h

2007-10-08 Thread Eliezer Tamir
bnx2x_self_test.h - machine generated self test, plus the code that reports HW/FW/BC asserts Signed-off-by: Eliezer Tamir [EMAIL PROTECTED] --- drivers/net/bnx2x_self_test.h | 1387 + 1 files changed, 1387 insertions(+), 0 deletions(-) diff --git

Re: [PATCHES] TX batching

2007-10-08 Thread Evgeniy Polyakov
Hi Jamal. On Sun, Oct 07, 2007 at 02:34:53PM -0400, jamal ([EMAIL PROTECTED]) wrote: Please provide feedback on the code and/or architecture. Last time i posted them i received little. They are now updated to work with the latest net-2.6.24 from a few hours ago. Patch 1: Introduces

Re: [PATCH] libertas link error due to gcc `smartness'

2007-10-08 Thread Dan Williams
On Mon, 2007-10-08 at 09:43 +0200, Geert Uytterhoeven wrote: Some versions of gcc replace strstr() calls with a single-character `needle' parameter by strchr() behind our back. This causes a link error if strchr() is defined as an inline function in asm/string.h (e.g. on m68k): |

Re: [BNX2X RESUBMIT][PATCH 0/8] New driver for Broadcom 10Gb Ethernet, take two.

2007-10-08 Thread Matti Aarnio
On Mon, Oct 08, 2007 at 02:34:45PM +0200, Eliezer Tamir wrote: Message-ID: [EMAIL PROTECTED] Date: Mon, 08 Oct 2007 14:34:45 +0200 From: Eliezer Tamir [EMAIL PROTECTED] User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: netdev@vger.kernel.org netdev@vger.kernel.org (...)

Re: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-08 Thread jamal
On Mon, 2007-08-10 at 10:33 +0530, Krishna Kumar2 wrote: As a side note: Any batching driver should _never_ have to requeue; if it does it is buggy. And the non-batching ones if they ever requeue will be a single packet, so not much reordering. On the contrary, batching LLTX drivers (if

[PATCH][NETNS] Move some code into __init section when CONFIG_NET_NS=n (v2)

2007-10-08 Thread Pavel Emelyanov
With the net namespaces many code leaved the __init section, thus making the kernel occupy more memory than it did before. Since we have a config option that prohibits the namespace creation, the functions that initialize/finalize some netns stuff are simply not needed and can be freed after the

Re: [PATCH 1/4] [NET_SCHED] explict hold dev tx lock

2007-10-08 Thread jamal
On Sun, 2007-07-10 at 21:51 -0700, David Miller wrote: For these high performance 10Gbit cards it's a load balancing function, really, as all of the transmit queues go out to the same physical port so you could: 1) Load balance on CPU number. 2) Load balance on flow 3) Load balance on

Re: [PATCH][TG3]Some cleanups

2007-10-08 Thread jamal
On Sun, 2007-07-10 at 23:32 -0700, David Miller wrote: This cleanup only makes sense if we go with your TX batching interfaces. They make the TX batching support patch for this driver nice and clean, but it makes zero sense in any other context. In fact, it adds more memory references in

Re: [PATCH 1/3] [NET_BATCH] Introduce batching interface

2007-10-08 Thread jamal
On Mon, 2007-08-10 at 15:29 +0530, Krishna Kumar2 wrote: Hi Jamal, If you don't mind, I am trying to run your approach vs mine to get some results for comparison. Please provide an analysis when you get the results. IOW, explain why one vs the other get different results. For starters, I

[PATCH] ehea: use kernel event queue

2007-10-08 Thread Jan-Bernd Themann
eHEA recovery and DLPAR functions are called seldomly. The eHEA workqueues are replaced by the kernel event queue. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- The patch has been built against upstream git drivers/net/ehea/ehea.h |3 +-- drivers/net/ehea/ehea_main.c | 28

Re: [PATCHES] TX batching

2007-10-08 Thread jamal
On Mon, 2007-08-10 at 16:51 +0400, Evgeniy Polyakov wrote: it looks like you and Krishna use the same requeueing methods - get one from qdisk, queue it into blist, get next from qdisk, queue it, eventually start transmit, where you dequeue it one-by-one and send (or prepare and commit). This

parallel networking (was Re: [PATCH 1/4] [NET_SCHED] explict hold dev tx lock)

2007-10-08 Thread Jeff Garzik
jamal wrote: On Sun, 2007-07-10 at 21:51 -0700, David Miller wrote: For these high performance 10Gbit cards it's a load balancing function, really, as all of the transmit queues go out to the same physical port so you could: 1) Load balance on CPU number. 2) Load balance on flow 3) Load

[patch 0/1] [8021q] qeth-related patch for net-2.6.24

2007-10-08 Thread Ursula Braun
-- Dave, the following patch is intended for 2.6.24. It adds the capability to create unique ipv6-addresses for vlan devices based on shared network cards (for example: s390/net/qeth devices). Regards, Ursula - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

[patch 1/1] 8021q: transfer dev_id from real device

2007-10-08 Thread Ursula Braun
From: Ursula Braun [EMAIL PROTECTED] A net_device struct provides field dev_id. It is used for unique ipv6 generation in case of shared network cards (as for the OSA network cards of IBM System z). If VLAN devices are built on top of such shared network cards, this dev_id information needs to be

Re: [PATCH net-2.6.24] net: sparse warning fixes

2007-10-08 Thread Stephen Hemminger
On Sun, 07 Oct 2007 23:59:56 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 5 Oct 2007 17:14:07 -0700 Fix a bunch of sparse warnings. Mostly about 0 used as NULL pointer, and shadowed variable declarations. The two noteable

Re: parallel networking (was Re: [PATCH 1/4] [NET_SCHED] explict hold dev tx lock)

2007-10-08 Thread jamal
On Mon, 2007-08-10 at 10:22 -0400, Jeff Garzik wrote: Any chance the NIC hardware could provide that guarantee? If you can get the scheduling/dequeuing to run on one CPU (as we do today) it should work; alternatively you can totaly bypass the qdisc subystem and go direct to the hardware for

Re: 2.6.23-rc8-mm2 BUG: register_netdevice() issue as (ab)used by ISDN

2007-10-08 Thread Karsten Keil
On Sun, Oct 07, 2007 at 07:20:37PM +0200, Andreas Mohr wrote: Hi, On Sun, Oct 07, 2007 at 03:17:24PM +0200, Andreas Mohr wrote: I thus decided to now try plain 2.6.23-rc8 whether it's corrupted, too. OK, after 3 hours of compilation the ONLY datapoint I can give right now is: 1 (one)

Re: [PATCH]: Third (final?) release of Sun Neptune driver

2007-10-08 Thread Oliver Hartkopp
David Miller wrote: + +static int link_status_1g(struct niu *np, int *link_up_p) +{ + u16 current_speed, bmsr; + unsigned long flags; + u8 current_duplex; + int err, link_up; + + if (np-link_config.loopback_mode != LOOPBACK_DISABLED) + return -EINVAL;

Re: [PATCH]: Third (final?) release of Sun Neptune driver

2007-10-08 Thread Oliver Hartkopp
David Miller wrote: if (err 0) - return err; + goto out_err; if (err != (PHYXS_XGXS_LANE_STAT_ALINGED | PHYXS_XGXS_LANE_STAT_MAGIC | @@ -1133,6 +1133,10 @@ out: *link_up_p = link_up; return 0; + +out_err: +

Re: [NET] IPv6 oops bisected

2007-10-08 Thread Eric W. Biederman
Denis V. Lunev [EMAIL PROTECTED] writes: David Miller wrote: From: Denis V. Lunev [EMAIL PROTECTED] Date: Mon, 08 Oct 2007 10:34:23 +0400 OK. I am installing Fedora 7 right now... You don't need to install Fedora, just read the code! :-) The bug is obvious and it's been explained

[PATCH 0/8][BNX2X] resubmit as attachments: New driver for Broadcom 10Gb Ethernet, take two.

2007-10-08 Thread Eliezer Tamir
[sorry for the mess. resubmitting, this time using attachments, if this does not work I'm going to go nuts.] This is an initial version of the BNX2X, the Linux driver for the BCM5771X 10Gb Ethernet controller family. Although the chip is very different from the 5706-8 family we based the

[PATCH 1/8][BNX2X] resubmit as attachments: add bnx2x to Kconfig and Makefile

2007-10-08 Thread Eliezer Tamir
Add bnx2x to Kconfig and Makefile From 94bf385550356534e6dd41ce61879608a63ed972 Mon Sep 17 00:00:00 2001 From: Eliezer Tamir [EMAIL PROTECTED] Date: Mon, 8 Oct 2007 11:48:10 +0200 Subject: [PATCH 1/8] add bnx2x to Kconfig and Makefile Signed-off-by: Eliezer Tamir [EMAIL PROTECTED] ---

[PATCH 3/8][BNX2X] resubmit as attachments: bnx2x.h

2007-10-08 Thread Eliezer Tamir
bnx2x.h - main .h file From c32bf79956add229de2e4b81a848fad0e503d3d0 Mon Sep 17 00:00:00 2001 From: Eliezer Tamir [EMAIL PROTECTED] Date: Mon, 8 Oct 2007 11:53:14 +0200 Subject: [PATCH 3/8] add bnx2x.h Signed-off-by: Eliezer Tamir [EMAIL PROTECTED] --- drivers/net/bnx2x.h | 997

[PATCH] [IPv6]: use container_of() macro in fib6_clean_node()

2007-10-08 Thread Benjamin Thery
In ip6_fib.c, fib6_clean_node() casts a fib6_walker_t pointer to a fib6_cleaner_t pointer assuming a struct fib6_walker_t (field 'w') is the first field in struct fib6_walker_t. To prevent any future problems that may occur if one day a field is inadvertently inserted before the 'w' field in

Re: [BNX2X RESUBMIT][PATCH 0/8] New driver for Broadcom 10Gb Ethernet, take two.

2007-10-08 Thread Randy Dunlap
On Mon, 8 Oct 2007 16:02:48 +0300 Matti Aarnio wrote: On Mon, Oct 08, 2007 at 02:34:45PM +0200, Eliezer Tamir wrote: Message-ID: [EMAIL PROTECTED] Date: Mon, 08 Oct 2007 14:34:45 +0200 From: Eliezer Tamir [EMAIL PROTECTED] User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version:

Re: [Bugme-new] [Bug 9132] New: fcntl GET_OWN reports 0 for sockets instead of PID

2007-10-08 Thread Andrew Morton
(please respond via emailed reply-to-all, not vie the bugzilla web interface) On Mon, 8 Oct 2007 09:18:02 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9132 Summary: fcntl GET_OWN reports 0 for sockets instead of PID Product:

Re: [PATCH 2/4][TG3]: ASIC decoding and basic CPMU support.

2007-10-08 Thread Michael Chan
On Mon, 2007-10-08 at 08:18 +0100, Christoph Hellwig wrote: Just curious: is there a diagram somewhere that shows the relation of the various tg3 chips to each other and what families exist? Some high level descriptions of some of the chips can be found here:

Re: [BNX2X RESUBMIT][PATCH 0/8] New driver for Broadcom 10Gb Ethernet, take two.

2007-10-08 Thread Stephen Hemminger
On Mon, 08 Oct 2007 14:34:45 +0200 Eliezer Tamir [EMAIL PROTECTED] wrote: [resubmitting, this time without line breaks, sorry] This is an initial version of the BNX2X, the Linux driver for the BCM5771X 10Gb Ethernet controller family. Although the chip is very different from the 5706-8

Re: 2.6.23-rc8-mm2 BUG: register_netdevice() issue as (ab)used by ISDN

2007-10-08 Thread Stephen Hemminger
On Mon, 8 Oct 2007 13:48:44 +0200 Karsten Keil [EMAIL PROTECTED] wrote: On Sun, Oct 07, 2007 at 02:06:53PM +0200, Andreas Mohr wrote: [not necessarily a very recent regression, used 2.6.19 kernels before...] Hi all, wondered why my main internet server (headless!) didn't come up

Re: [ofa-general] [PATCH v3] iw_cxgb3: Supportiwarp-onlyinterfacesto avoid 4-tuple conflicts.

2007-10-08 Thread Steve Wise
Kanevsky, Arkady wrote: Sean, IB aside, it looks like an ULP which is capable of being both RDMA aware and RDMA not-aware, like iSER and iSCSI, NFS-RDMA and NFS, SDP and sockets, will be treated as two separete ULPs. Each has its own IP address, since there is a different IP address for

[patch 02/12] sky2: reduce impact of watchdog timer

2007-10-08 Thread Greg KH
From: Stephen Hemminger [EMAIL PROTECTED] This is the 2.6.22 version of a regression fix that is already in 2.6.23. Change the watchdog timer form 10 per second all the time, to 1 per second and only if interface is up. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Signed-off-by: Greg

[DOC][NET_BATCH] Driver howto

2007-10-08 Thread jamal
This is an updated driver howto for batching that works with patches from yesterday and the revised ones i am going to post. cheers, jamal Here's the beginning of a howto for driver authors. The intended audience for this howto is people already familiar with netdevices. 1.0 Netdevice

[patch 03/12] sky2: fix VLAN receive processing

2007-10-08 Thread Greg KH
From: Stephen Hemminger [EMAIL PROTECTED] Already upstream. The length check for truncated frames was not correctly handling the case where VLAN acceleration had already read the tag. Also, the Yukon EX has some features that use high bit of status as security tag. Signed-off-by: Pierre-Yves

[patch 04/12] sky2: fix transmit state on resume

2007-10-08 Thread Greg KH
From: Stephen Hemminger [EMAIL PROTECTED] Already upstream. After resume, driver has reset the chip so the current state of transmit checksum offload state machine and DMA state machine will be undefined. The fix is to set the state so that first Tx will set MSS and offset values.

[PATCHES] TX batching rev2

2007-10-08 Thread jamal
Please provide feedback on the code and/or architecture. Last time i posted them i received little. They are now updated to work with the latest net-2.6.24 from a few hours ago. Patch 1: Introduces batching interface Patch 2: Core uses batching interface Patch 3: get rid of dev-gso_skb What

[PATCH 1/3] [NET_BATCH] Introduce batching interface

2007-10-08 Thread jamal
This patch introduces the netdevice interface for batching. cheers, jamal [NET_BATCH] Introduce batching interface This patch introduces the netdevice interface for batching. BACKGROUND - A driver dev-hard_start_xmit() has 4 typical parts: a) packet formating (example vlan, mss,

[PATCH 2/3][NET_BATCH] net core use batching

2007-10-08 Thread jamal
This patch adds the usage of batching within the core. cheers, jamal [NET_BATCH] net core use batching This patch adds the usage of batching within the core. Performance results demonstrating improvement are provided separately. I have #if-0ed some of the old functions so the patch is more

RE: [Bugme-new] [Bug 9132] New: fcntl GET_OWN reports 0 for sockets instead of PID

2007-10-08 Thread François-Frédéric Ozog
You are correct, I have tested back to 2.6.18 and the bug is still here. So I don't know when the problem did NOT occur. François-Frédéric -Message d'origine- De : Andrew Morton [mailto:[EMAIL PROTECTED] Envoyé : lundi 8 octobre 2007 19:11 À : François-Frédéric Ozog Cc : [EMAIL

[PATCH 3/3][NET_BATCH] kill dev-gso_skb

2007-10-08 Thread jamal
This patch removes dev-gso_skb as it is no longer necessary with batching code. cheers, jamal [NET_BATCH] kill dev-gso_skb The batching code does what gso used to batch at the drivers. There is no more need for gso_skb. If for whatever reason the requeueing is a bad idea we are going to leave

Re: [BNX2X RESUBMIT][PATCH 0/8] New driver for Broadcom 10Gb Ethernet, take two.

2007-10-08 Thread Eliezer
On Mon, 2007-10-08 at 10:29 -0700, Stephen Hemminger wrote: Looks good. Some minor stuff: * You can use network device stats in network device structure and no longer need the copy in bp We can't use net device stats in the bp because the elements are also used by HW and we can't

raw PF_PACKET protocol selection

2007-10-08 Thread Joakim Tjernlund
Hi List I trying to open my own raw PF_PACKET socket to receive pkgs sent to this socket. I can only make ETH_P_ALL protocol work, but then I receive all pkgs and I want pkgs with a specific protocol type. I have tried lots of ETH_P types and none of them work. Naturally I make sure the sender

Re: [PATCH 0/8][BNX2X] resubmit as attachments: New driver for Broadcom 10Gb Ethernet, take two.

2007-10-08 Thread Eliezer Tamir
Here are FTP links. All the parts in a zipped tar. ftp://[EMAIL PROTECTED]/bnx2x-0.40.10-net-2.6.24.tgz One big patch. ftp://[EMAIL PROTECTED]/bnx2x-0.40.10-net-2.6.24-one.patch.txt I noticed that the big microcode files did not seem to get through to netdev, so here they are: ftp://[EMAIL

Re: [BNX2X RESUBMIT][PATCH 0/8] New driver for Broadcom 10Gb Ethernet, take two.

2007-10-08 Thread Stephen Hemminger
On Mon, 08 Oct 2007 20:34:41 +0200 Eliezer [EMAIL PROTECTED] wrote: On Mon, 2007-10-08 at 10:29 -0700, Stephen Hemminger wrote: Looks good. Some minor stuff: * You can use network device stats in network device structure and no longer need the copy in bp We can't use net device

Re: [BNX2X RESUBMIT][PATCH 0/8] New driver for Broadcom 10Gb Ethernet, take two.

2007-10-08 Thread Eliezer Tamir
On Mon, 2007-10-08 at 12:08 -0700, Stephen Hemminger wrote: On Mon, 08 Oct 2007 20:34:41 +0200 Eliezer [EMAIL PROTECTED] wrote: On Mon, 2007-10-08 at 10:29 -0700, Stephen Hemminger wrote: Looks good. Some minor stuff: * You can use network device stats in network device

RE: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-08 Thread Waskiewicz Jr, Peter P
-Original Message- From: J Hadi Salim [mailto:[EMAIL PROTECTED] On Behalf Of jamal Sent: Monday, October 08, 2007 11:27 AM To: David Miller Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED];

[NET_BATCH] Some perf results

2007-10-08 Thread jamal
Ive attached a small pdf with results. This adds on top of results I posted yesterday (although i didnt see them reflected on netdev). 1) batch-ntlst is the patches posted today that remove the temporary list in qdisc restart and is derived from this AM net-2.6.24 2) batch-kern is result of

Re: [BNX2X RESUBMIT][PATCH 0/8] New driver for Broadcom 10Gb Ethernet, take two.

2007-10-08 Thread Michael Chan
On Mon, 2007-10-08 at 12:08 -0700, Stephen Hemminger wrote: On Mon, 08 Oct 2007 20:34:41 +0200 Eliezer [EMAIL PROTECTED] wrote: * The MACRO's for 64 bit stats look like they could be done with u64 and/or turned into inline's. The MACRO's modify some of their arguments, plus they

RE: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-08 Thread jamal
On Mon, 2007-08-10 at 12:46 -0700, Waskiewicz Jr, Peter P wrote: I still have concerns how this will work with Tx multiqueue. The way the batching code looks right now, you will probably send a batch of skb's from multiple bands from PRIO or RR to the driver. For non-Tx multiqueue

  1   2   >