[PATCH 13/17] netdrvr irq handler cleanups

2007-10-21 Thread Jeff Garzik
commit a9f06dc9fb3caea2c4e9b387974c9f4956434e28 Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Oct 19 19:33:31 2007 -0400 [netdrvr] driver irq handler cleanups * no need to use 'irq' function arg, its already stored in a data struct * whitespace cleanups * delete

Re: [ewg] [PATCH 0/14 v2] nes: NetEffect 10Gb RNIC Driver

2007-10-21 Thread Tziporet Koren
[EMAIL PROTECTED] wrote: This is the second posting for the series of patches containing the source code for the NetEffect 10Gb RNIC adapter. The driver is split into two components - a kernel driver module and a userspace library. The code can also be found in the following git trees.

Re: net: alignment problem in icmp code

2007-10-21 Thread Pierre Ossman
On Sat, 20 Oct 2007 22:12:57 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Pierre Ossman [EMAIL PROTECTED] Date: Sat, 20 Oct 2007 23:35:40 +0200 Structure assignment have to be aligned just like any assignment, and the skb could point to anything. So take the safe route and use

RE: [PATCH] Fix ethernet multicast for ucc_geth.

2007-10-21 Thread Joakim Tjernlund
-Original Message- From: Li Yang-r58472 [mailto:[EMAIL PROTECTED] Sent: den 18 oktober 2007 16:24 To: [EMAIL PROTECTED]; Netdev; [EMAIL PROTECTED] Subject: RE: [PATCH] Fix ethernet multicast for ucc_geth. -Original Message- From: Joakim Tjernlund [mailto:[EMAIL

Re: PROBLEM: oops, Linus tree: 2.6.23-g4fa4d23f, BUG: unable to handle kernel NULL pointer dereference at virtual address 00000004

2007-10-21 Thread Guillaume Chazarain
Le Sun, 21 Oct 2007 13:16:32 +0800, Coly Li [EMAIL PROTECTED] a écrit : This should be fixed in recent git by http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9b013e05e0289c190a53d78ca029e2f21c0e4485 Maybe we encounter same condition, at least the symbol name is

how to set pppoe source mac address?

2007-10-21 Thread Joakim Tjernlund
I have several pppoe i/f's over one eth i/f and I want to set the source mac address used by each pppoe i/f to a unique mac address from user space. Is this possible? If so, how do I do that? Jocke - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: iproute2: git pull request from debian repo.

2007-10-21 Thread Patrick McHardy
Andreas Henriksson wrote: - for (;;) { + while (round MAX_ROUNDS) { if (rtnl_wilddump_request(rth, filter.family, RTM_GETADDR) 0) { perror(Cannot send dump request); exit(1); @@

Re: how to set pppoe source mac address?

2007-10-21 Thread Patrick McHardy
Joakim Tjernlund wrote: I have several pppoe i/f's over one eth i/f and I want to set the source mac address used by each pppoe i/f to a unique mac address from user space. Is this possible? If so, how do I do that? Try the macvlan driver. - To unsubscribe from this list: send the line

Re: [patch] ipv6.7: IPV6_ROUTER_ALERT sockopt correction

2007-10-21 Thread Andrew McDonald
On Wed, Oct 17, 2007 at 09:19:15AM +0300, Pekka Savola wrote: Router alert option on a hop-by-hop header means that every router on the path should process the option. I think I understand what you mean by process the option, but it is a little ambiguous. The abstract of RFC2711 says:

RE: how to set pppoe source mac address?

2007-10-21 Thread Joakim Tjernlund
-Original Message- From: Patrick McHardy [mailto:[EMAIL PROTECTED] Sent: den 21 oktober 2007 19:51 To: Joakim Tjernlund Cc: netdev@vger.kernel.org Subject: Re: how to set pppoe source mac address? Joakim Tjernlund wrote: I have several pppoe i/f's over one eth i/f and I want to

[PATCHES] cleanup skb_clone

2007-10-21 Thread jamal
This a re-submission with the last patch fixed up. Three patches to follow: 1) Introduces skb_act_clone 2) Uses skb_act_clone 3) documents expected behavior of actions in case of cloning or copying skbs. cheers, jamal - To unsubscribe from this list: send the line unsubscribe netdev in the body

[PATCH 1/3] [NET_CLS_ACT] Introduce skb_act_clone

2007-10-21 Thread jamal
A resubmit against net-2.6 from about an hour ago. cheers, jamal 0001-NET_CLS_ACT-Introduce-skb_act_clone.txt Description: application/mbox

[PATCH 2/3] [NET_CLS_ACT] Use skb_act_clone

2007-10-21 Thread jamal
A resubmit against net-2.6 from about an hour ago. cheers, jamal 0002-NET_CLS_ACT-Use-skb_act_clone.txt Description: application/mbox

[PATCH 3/3] [NET_DOC] Document some simple rules for actions

2007-10-21 Thread jamal
Against net-2.6 cheers, jamal 0003-NET_DOC-Document-some-simple-rules-for-actions.txt Description: application/mbox

Re: net: alignment problem in icmp code

2007-10-21 Thread David Miller
From: Pierre Ossman [EMAIL PROTECTED] Date: Sun, 21 Oct 2007 11:34:05 +0200 Inlining isn't the problem, but the defined semantics of assignment versus memcpy(). memcpy() must work on any region of memory, whilst assignment must only work on a properly aligned object. You are missing a crucial

Fw: net: alignment problem in icmp code

2007-10-21 Thread Темерханов Сергей
Пересылаемое сообщение 21.10.07, 23:48, David Miller ([EMAIL PROTECTED]): From: Pierre Ossman [EMAIL PROTECTED] Date: Sun, 21 Oct 2007 11:34:05 +0200 Inlining isn't the problem, but the defined semantics of assignment versus memcpy(). memcpy() must work on any region of

Fw: net: alignment problem in icmp code

2007-10-21 Thread Темерханов Сергей
Пересылаемое сообщение 21.10.07, 23:48, David Miller ([EMAIL PROTECTED]): From: Pierre Ossman [EMAIL PROTECTED] Date: Sun, 21 Oct 2007 11:34:05 +0200 Inlining isn't the problem, but the defined semantics of assignment versus memcpy(). memcpy() must work on any region of

Re: [BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-21 Thread Benjamin Herrenschmidt
That's a pity, but AFAIK it shouldn't be a problem because we don't enable CONFIG_PM on those machines anyway. If we ever want to we'll need to sort out with firmware how that will work WRT restoring MSI state. I think the current generic code for pci_restore_msi_state() or whatever it's

Re: net: alignment problem in icmp code

2007-10-21 Thread Pierre Ossman
On Sun, 21 Oct 2007 12:48:14 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: You are missing a crucial point. The compiler may emit the same exact loads and stores when it inlines memcpy() if it knows the objects are aligned properly. And it very much will do this. Not sure that

Re: net: alignment problem in icmp code

2007-10-21 Thread David Miller
From: Pierre Ossman [EMAIL PROTECTED] Date: Sun, 21 Oct 2007 23:21:13 +0200 Not sure that would be valid. memcpy() is defined as having void* arguments, and the compiler cannot just ignore that if it chooses to inline it. Yes it can, there are C language rules about the alignment of types

Re: [PATCH 1/7] tg3: Add 5723 support

2007-10-21 Thread David Miller
From: Matt Carlson [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 14:36:37 -0700 This patch adds support for upcoming 5723 devices. Signed-off-by: Matt Carlson [EMAIL PROTECTED] Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/7] tg3: MII = TP

2007-10-21 Thread David Miller
From: Matt Carlson [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 14:36:42 -0700 This patch changes the PHY type reported through ethtool for copper devices from MII to TP. The latter is more accurate. Signed-off-by: Matt Carlson [EMAIL PROTECTED] Signed-off-by: Michael Chan [EMAIL PROTECTED]

Re: [PATCH 3/7] tg3: Add management FW version to ethtool report

2007-10-21 Thread David Miller
From: Matt Carlson [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 14:36:49 -0700 This patch appends the management firmware version to the bootcode firmware string reported through ethtool. Signed-off-by: Matt Carlson [EMAIL PROTECTED] Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied. - To

Re: [PATCH 4/7] tg3: PCI command adjustment

2007-10-21 Thread David Miller
From: Matt Carlson [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 14:36:53 -0700 This patch changes the way the driver works with the PCI command register. It adjusts the access size from dwords to words. This patch is done both as a PCI configuration space cleanup and as preparatory work for PCI

Re: [PATCH 7/7] tg3: Update version to 3.85

2007-10-21 Thread David Miller
From: Matt Carlson [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 14:37:00 -0700 This patch updates the version number to 3.85. Signed-off-by: Matt Carlson [EMAIL PROTECTED] Signed-off-by: Michael Chan [EMAIL PROTECTED] I'll apply this, and when we sort out the PCI error recovery with another

Re: atm: panic when loading clip 2nd time

2007-10-21 Thread David Miller
From: Randy Dunlap [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 18:02:36 -0700 From: Randy Dunlap [EMAIL PROTECTED] net/atm/clip.c crashes the kernel if it (module) is loaded, removed, and then loaded again. Its exit call to neigh_table_clear() should destroy the cache after freeing it.

Re: Bluetooth patches for 2.6.24

2007-10-21 Thread David Miller
From: Marcel Holtmann [EMAIL PROTECTED] Date: Sat, 20 Oct 2007 22:01:37 +0200 Hi Dave, these are the Bluetooth patches for the 2.6.24 kernel release. Please pull and send them to Linus. one of the cleanup patches slipped through the net. If you already pulled my tree, then please

Re: [Bug 9189] New: Oops in kernel 2.6.21-rc4 through 2.6.23, page allocation failure

2007-10-21 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Sun, 21 Oct 2007 12:56:01 +0800 [NET]: Fix SKB_WITH_OVERHEAD calculation The calculation in SKB_WITH_OVERHEAD is incorrect in that it can cause an overflow across a page boundary which is what it's meant to prevent. In particular, the header length

Re: [PATCH v2] niu: Cleanup PAGE_SIZE checks a bit

2007-10-21 Thread David Miller
From: Olof Johansson [EMAIL PROTECTED] Date: Sat, 20 Oct 2007 14:33:57 -0500 PAGE_SIZE in this case is 64KB, so I don't quite get why gcc can't tell that the line in question will never be reached. GCC does not do that kind of full flow analysis based upon constant expression simplification to

Re: [PATCH 1/4] Use the skb_set_queue_mapping where appropriate

2007-10-21 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 13:00:52 +0400 There's already such a helper to initialize this field. Use it. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Applied. /* reset queue_mapping to zero */ -

Re: [PATCH 2/4] Make and use skb_get_queue_mapping

2007-10-21 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 13:02:31 +0400 Make the helper for getting the field, symmetrical to the set one. Return 0 if CONFIG_NETDEVICES_MULTIQUEUE=n Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the

Re: [PATCH 3/4] Hide the queue_mapping field inside netif_subqueue_stopped

2007-10-21 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 13:04:13 +0400 Many places get the queue_mapping field from skb to pass it to the netif_subqueue_stopped() which will be 0 in any case. Make the helper that works with sk_buff Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]

Re: [PATCH 4/4] Cut off the queue_mapping field from sk_buff

2007-10-21 Thread David Miller
From: Pavel Emelyanov [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 13:05:40 +0400 Just hide it behind the #ifdef, because nobody wants it now. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Also applied, thanks! - To unsubscribe from this list: send the line unsubscribe netdev in the body of

CC2420 (802.15.4) Speed Issue

2007-10-21 Thread Michael Whyte
Hi Guys, I'm currently writing my first bit of Linux kernel code so be gentle. It's a driver for TI CC2420 802.15.4 radio and I'm observing strange behavior. I am currently testing just by transferring a ~300kb file over HTTP between two of these devices. The strange thing is, when ever you

Regression in current git - Network Manager fails (bisected)

2007-10-21 Thread Joseph Fannin
Network Manager (the freedesktop.org one) fails to work with Linus's current git on a couple of different boxes I have here. All the boxes have different NIC types, with different drivers. I've bisected it down to cd40b7d3983c708aabe3d3008ec64ffce56d33b0 , [NET]: make netlink user - kernel

Re: e100 problems in .23rc8 ?

2007-10-21 Thread Dave Jones
On Thu, Oct 18, 2007 at 10:59:59AM -0700, Kok, Auke wrote: David Mack wrote: It appears that the needed e100 fix made it into the Fedora 2.6.23.1-23.fc8 kernel. Boots reliably now. Huge thanks and great work, guys. DaveJ, I didn't push anything upstream. Can you verify this now

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-21 Thread Michael Ellerman
On Sun, 2007-10-21 at 16:21 -0700, David Miller wrote: From: Matt Carlson [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 14:36:56 -0700 This patch exports the pci_restore_msi_state() function. This function is needed to restore the MSI state during PCI error recovery. Signed-off-by: Linas

Re: about multiple network interface

2007-10-21 Thread wit
Thanks very much But this does work until I add a ifcfg-eth0 in sysconfig/network-script with the following content: DEVICE=eth0 ONBOOT=yes What is the relationship between these two files? And sometimes, I see this message: Bringing up interface eth0: e100 device does not seem to be present,

Re: [ofa-general] [PATCH 14/14 v2] nes: kernel build infrastructure

2007-10-21 Thread Roland Dreier
+ +EXTRA_CFLAGS += -DNES_MINICM I don't see anyplace NES_MINICM is used. Delete this line? + +obj-$(CONFIG_INFINIBAND_NES) += iw_nes.o + +iw_nes-objs := nes.o nes_hw.o nes_nic.o nes_utils.o nes_verbs.o nes_cm.o + Also the file has an extra blank line at the beginning and end.

Re: e100 problems in .23rc8 ?

2007-10-21 Thread Herbert Xu
On Sun, Oct 21, 2007 at 09:04:40PM -0400, Dave Jones wrote: I included the patch below in the latest build, but I've not had chance to try it on an e100 box yet.. Looks good to me. Thanks Dave! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home

Re: [PATCH 2/7] tg3: MII = TP

2007-10-21 Thread Michael Chan
David Miller wrote: From: Matt Carlson [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 14:36:42 -0700 This patch changes the PHY type reported through ethtool for copper devices from MII to TP. The latter is more accurate. Signed-off-by: Matt Carlson [EMAIL PROTECTED] Signed-off-by:

Re: [PATCH 2/7] tg3: MII = TP

2007-10-21 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Sun, 21 Oct 2007 20:49:25 -0700 MII in this ethtool context means an MII connector on the card that can connect to an external transceiver, right? Or does it mean internal MII interface to the PHY? Good question. Looking at drivers it's set

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-21 Thread Michael Chan
David Miller wrote: I'm not so sure about this. Perhaps, instead, you should do a pci_msi_disable() and pci_msi_enable() in the error detection and recovery sequence. If we just detected PCI errors on this slot, I don't think it's a good idea to continue writing to the config space to

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-21 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Sun, 21 Oct 2007 21:01:17 -0700 David Miller wrote: I'm not so sure about this. Perhaps, instead, you should do a pci_msi_disable() and pci_msi_enable() in the error detection and recovery sequence. If we just detected PCI errors on this

Re: net: alignment problem in icmp code

2007-10-21 Thread Pierre Ossman
On Sun, 21 Oct 2007 16:02:15 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Pierre Ossman [EMAIL PROTECTED] Date: Sun, 21 Oct 2007 23:21:13 +0200 Not sure that would be valid. memcpy() is defined as having void* arguments, and the compiler cannot just ignore that if it chooses to

Re: net: alignment problem in icmp code

2007-10-21 Thread David Miller
From: Pierre Ossman [EMAIL PROTECTED] Date: Mon, 22 Oct 2007 06:54:43 +0200 On Sun, 21 Oct 2007 16:02:15 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: You will get a 64-bit load and a 64-bit store emitted by the compiler. Here is what we get on sparc64: I assume those ops cause a