On Wed, Oct 17, 2007 at 09:10:02AM +0800, Herbert Xu wrote:
Any chance you could include the NAT patch for the next release?
[TC]: Add NAT action
This patch adds the parser for the nat action which is used
for stateless NAT.
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
Hi Stephen:
Is
On Mon, Oct 22, 2007 at 10:02:59PM +0400, Oleg Nesterov wrote:
On 10/22, Jarek Poplawski wrote:
...
OK, I know I'm dumber and dumber everyday,
You are not alone. I have the same feeling about myself!
Feeling is not the same, only true knowledge counts!
these all flushes are
rtnl
Monday 22 October 2007 21:28, jamal wrote:
On Mon, 2007-22-10 at 15:11 +0900, Masahide NAKAMURA wrote:
This patch introduces statistics about transformation error (or almost
error)
factor at packet processing for developer.
It is not a SNMP/MIB specification from IPsec/MIPv6 but a
On Mon, Oct 22, 2007 at 10:02:59PM +0400, Oleg Nesterov wrote:
...
If this work doesn't rearm itself - yes. (otherwise, the same -func
can run twice _at the same time_)
But again, in this case wait_on_work() after try_to_grab_pending() == 1
doesn't block, so we can just do
if
* Dan Williams [EMAIL PROTECTED] 2007-10-22 11:57
On Mon, 2007-10-22 at 13:22 +0400, Denis V. Lunev wrote:
We have spent some time with the problem with Alexey and there are no
guesses for now.
Is it possible to name exact version of Network Manager and all
libraries related +
gcc spits following warnings
net/sched/sch_prio.c:139: warning: passing argument 2 of
'netif_subqueue_stopped' makes pointer from integer without a cast
net/sched/sch_prio.c:169: warning: passing argument 2 of
'netif_subqueue_stopped' makes pointer from integer without a cast
and he is dead
CCed Pavel
Alexey Dobriyan wrote:
gcc spits following warnings
net/sched/sch_prio.c:139: warning: passing argument 2 of
'netif_subqueue_stopped' makes pointer from integer without a cast
net/sched/sch_prio.c:169: warning: passing argument 2 of
'netif_subqueue_stopped' makes pointer from
Try with this patch.
Log:
Fix more users of netiff_subqueue_stopped. To check for the
queue id one must use the __netiff_subqueue_stoped call.
These run out of my sight when I made the
668f895a85b0c3a62a690425145f13dabebebd7a commit :(
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
Thomas Graf wrote:
* Dan Williams [EMAIL PROTECTED] 2007-10-22 11:57
On Mon, 2007-10-22 at 13:22 +0400, Denis V. Lunev wrote:
We have spent some time with the problem with Alexey and there are no
guesses for now.
Is it possible to name exact version of Network Manager and all
libraries
* Denis V. Lunev [EMAIL PROTECTED] 2007-10-23 17:09
I have reproduced the problem with one-line test.
./nl-route-get 192.168.1.1
The problem is with this message:
-- Debug: Sent Message:
-- BEGIN NETLINK MESSAGE
---
[HEADER] 16
On Sun, Oct 21, 2007 at 07:48:21PM +0200, Patrick McHardy wrote:
Andreas Henriksson wrote:
-for (;;) {
+while (round MAX_ROUNDS) {
if (rtnl_wilddump_request(rth, filter.family,
RTM_GETADDR) 0) {
On Tue, 2007-10-23 at 15:38 +0200, Thomas Graf wrote:
* Denis V. Lunev [EMAIL PROTECTED] 2007-10-23 17:09
I have reproduced the problem with one-line test.
./nl-route-get 192.168.1.1
The problem is with this message:
-- Debug: Sent Message:
-- BEGIN
When GRE tunnel is in NBMA mode, this patch allows an application to use
a PF_PACKET socket to:
- send a packet to specific NBMA address with sendto()
- use recvfrom() to receive packet and check which NBMA address it came from
Signed-off-by: Timo Teras [EMAIL PROTECTED]
---
This is useful for
Timo Teräs wrote:
When GRE tunnel is in NBMA mode, this patch allows an application to use
a PF_PACKET socket to:
- send a packet to specific NBMA address with sendto()
- use recvfrom() to receive packet and check which NBMA address it came
from
Signed-off-by: Timo Teras [EMAIL PROTECTED]
Revert to original netlink behavior. Do not reply with ACK if the
netlink dump has bees successfully started.
libnl has been broken by the cd40b7d3983c708aabe3d3008ec64ffce56d33b0
The following command reproduce the problem:
/nl-route-get 192.168.1.1
Signed-off-by: Denis V. Lunev [EMAIL
Andreas Henriksson wrote:
On Sun, Oct 21, 2007 at 07:48:21PM +0200, Patrick McHardy wrote:
Andreas Henriksson wrote:
- for (;;) {
+ while (round MAX_ROUNDS) {
if (rtnl_wilddump_request(rth, filter.family,
RTM_GETADDR) 0) {
On Sun, Oct 21, 2007 at 07:48:21PM +0200, Patrick McHardy wrote:
Andreas Henriksson wrote:
-for (;;) {
+while (round MAX_ROUNDS) {
if (rtnl_wilddump_request(rth, filter.family,
RTM_GETADDR) 0) {
Andreas Henriksson wrote:
On Tue, Oct 23, 2007 at 04:38:06PM +0200, Patrick McHardy wrote:
Almost - the default behaviour shouldn't change IMO. Also please
send a complete patch, not one on top of your old one.
Which default behaviour? ip addr flush or ip neigh flush behaviour?
Both of those
Hi,
We recently did some performance comparisons between the new inet_lro
LRO support in the kernel, and our Myri10GE in-driver LRO.
For receive, we found they were nearly identical. However, for
transmit, we found that Myri10GE's LRO shows much lower CPU
utilization. We traced the CPU
Both are equal, except for the list to be traversed.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/net/sctp/ulpqueue.c b/net/sctp/ulpqueue.c
index b937095..4be92d0 100644
--- a/net/sctp/ulpqueue.c
+++ b/net/sctp/ulpqueue.c
@@ -908,8 +908,8 @@ void sctp_ulpq_skip(struct
On Mon, 15 Oct 2007 14:27:23 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Valentine Barshak wrote:
This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver.
These PHY chips are used on PowerPC 440EPx boards.
The PHY code is based on the previous work by Stefan Roese [EMAIL
On Tue, Oct 23, 2007 at 04:38:06PM +0200, Patrick McHardy wrote:
Almost - the default behaviour shouldn't change IMO. Also please
send a complete patch, not one on top of your old one.
Which default behaviour? ip addr flush or ip neigh flush behaviour?
Both of those should behave the same IMHO.
On Tue, Oct 23, 2007 at 05:08:10PM +0200, Patrick McHardy wrote:
Andreas Henriksson wrote:
On Tue, Oct 23, 2007 at 04:38:06PM +0200, Patrick McHardy wrote:
Almost - the default behaviour shouldn't change IMO. Also please
send a complete patch, not one on top of your old one.
Which default
On Tue, Oct 23, 2007 at 06:40:23PM +0400, Denis V. Lunev wrote:
Revert to original netlink behavior. Do not reply with ACK if the
netlink dump has bees successfully started.
libnl has been broken by the cd40b7d3983c708aabe3d3008ec64ffce56d33b0
The following command reproduce the problem:
On Tue, 23 Oct 2007 14:12:07 +0800
Herbert Xu [EMAIL PROTECTED] wrote:
On Wed, Oct 17, 2007 at 09:10:02AM +0800, Herbert Xu wrote:
Any chance you could include the NAT patch for the next release?
[TC]: Add NAT action
This patch adds the parser for the nat action which is used
When GRE tunnel is in NBMA mode, this patch allows an application to use
a PF_PACKET socket to:
- send a packet to specific NBMA address with sendto()
- use recvfrom() to receive packet and check which NBMA address it came from
This is required to implement properly NHRP over GRE tunnel.
When GRE tunnel is in NBMA mode, this patch allows an application to use
a PF_PACKET socket to:
- send a packet to specific NBMA address with sendto()
- use recvfrom() to receive packet and check which NBMA address it came from
This is required to implement properly NHRP over GRE tunnel.
On Tue, Oct 23, 2007 at 08:37:02AM -0700, Stephen Hemminger wrote:
I was just holding off for a few days to see if there were any bug fixes
to 2.6.23 version that needed to go in first. It is first in queue for 2.6.24
related stuff.
Promise to get it in before 2.6.24-rc1
Thanks Stephen!
--
Hi Dave:
This series of patches fixes the bug where the bundle creation
code treats IPv6 routes as IPv4 or vice versa.
I think this is suitable for 2.6.25.
They do fix bugs but I don't think any of them are serious enough
for inclusion in 2.6.24.
Cheers,
--
Visit Openswan at
[IPV6]: Only set nfheader_len for top xfrm dst
We only need to set nfheader_len in the top xfrm dst. This is because
we only ever read the nfheader_len from the top xfrm dst.
It is also easier to count nfheader_len as part of header_len which
then lets us remove the ugly wrapper functions for
[IPSEC]: Use dst-header_len when resizing on output
Currently we use x-props.header_len when resizing on output. However,
if we're resizing at all we might as well go the whole hog and do it
for the whole dst.
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
---
net/xfrm/xfrm_output.c |3 ++-
[IPV6]: Move nfheader_len into rt6_info
The dst member nfheader_len is only used by IPv6. It's also currently
creating a rather ugly alignment hole in struct dst. Therefore this patch
moves it from there into struct rt6_info.
It also reorders the fields in rt6_info to minimize holes.
Pavel Emelyanov wrote:
Both are equal, except for the list to be traversed.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
ACK. Good clean-up Pavel.
Thanks
-vlad
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
[NET]: Eliminate duplicate copies of dst_discard
We have a number of copies of dst_discard scattered around the place which
all do the same thing, namely free a packet on the input or output paths.
This patch deletes all of them except dst_discard and points all the users
to it.
The only
[NET]: Remove unnecessary inclusion of dst.h
The file net/netevent.h only refers to struct dst_entry * so it doesn't
need to include dst.h. I've replaced it with a forward declaration.
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
---
include/net/netevent.h |2 +-
1 files changed, 1
[IPSEC]: Only set neighbour on top xfrm dst
The neighbour field is only used by dst_confirm which only ever happens on
the top-most xfrm dst. So it's a waste to duplicate for every other xfrm
dst. This patch moves its setting out of the loop so that only the top one
gets set.
Signed-off-by:
[IPSEC]: Set dst-input to dst_discard
The input function should never be invoked on IPsec dst objects. This is
because we don't apply IPsec on input until after we've made the routing
decision.
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
---
net/ipv4/xfrm4_policy.c |3 ++-
[IPSEC]: Make sure idev is consistent with dev in xfrm_dst
Previously we took the device from the bottom route and idev from the top
route. This is bad because idev may well point to a different device.
This patch changes it so that we get the idev from the device directly.
It also makes it an
[IPSEC]: Replace x-type-{local,remote}_addr with flags
The functions local_addr and remote_addr are more than what they're needed
for. The same thing can be done easily with flags on the type object.
This patch does that and simplifies the wrapper functions in xfrm6_policy
accordingly.
[IPSEC]: Merge common code into xfrm_bundle_create
Half of the code in xfrm4_bundle_create and xfrm6_bundle_create are common.
This patch extracts that logic and puts it into xfrm_bundle_create. The
rest of it are then accessed through afinfo.
As a result this fixes the problem with
[IPSEC]: Move flow construction into xfrm_dst_lookup
This patch moves the flow construction from the callers of xfrm_dst_lookup
into that function. It also changes xfrm_dst_lookup so that it takes an
xfrm state as its argument instead of explicit addresses.
This removes any address-specific
Timo Teräs wrote:
When GRE tunnel is in NBMA mode, this patch allows an application to use
a PF_PACKET socket to:
- send a packet to specific NBMA address with sendto()
- use recvfrom() to receive packet and check which NBMA address it
came from
This is required to implement properly NHRP
On Oct 23, 2007, at 10:20 AM, Josh Boyer wrote:
On Mon, 15 Oct 2007 14:27:23 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Valentine Barshak wrote:
This patch adds BCM5248 and Marvell 88E PHY support to NEW
EMAC driver.
These PHY chips are used on PowerPC 440EPx boards.
The PHY code is
On Tue, 23 Oct 2007 11:13:48 -0500
Kumar Gala [EMAIL PROTECTED] wrote:
On Oct 23, 2007, at 10:20 AM, Josh Boyer wrote:
On Mon, 15 Oct 2007 14:27:23 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Valentine Barshak wrote:
This patch adds BCM5248 and Marvell 88E PHY support to NEW
* Denis V. Lunev [EMAIL PROTECTED] 2007-10-23 18:40
Revert to original netlink behavior. Do not reply with ACK if the
netlink dump has bees successfully started.
libnl has been broken by the cd40b7d3983c708aabe3d3008ec64ffce56d33b0
The following command reproduce the problem:
The /proc/net udp6, tcp6 and raw6 files print the IPs of
the connection ends. Make a NIP6Lxxx macros (L stands for
long) for making the printing code look nicer.
Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED]
---
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index
[VLAN]: MAINTAINERS update
Ben stepped down from VLAN maintainership due to a lack of time,
add myself as new maintainer.
Cc: Ben Greear [EMAIL PROTECTED]
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
diff --git a/MAINTAINERS b/MAINTAINERS
index 1fd6d02..0ad7447 100644
--- a/MAINTAINERS
+++
Valentine Barshak schrieb:
Oliver Neukum wrote:
Am Montag 22 Oktober 2007 schrieb Valentine Barshak:
static int asix_mdio_read(struct net_device *netdev, int phy_id, int loc)
{
struct usbnet *dev = netdev_priv(netdev);
+ void *buf;
u16 res;
On Mon, Oct 22, 2007 at 06:47:32AM -0700, Medve Emilian-EMMEDVE1 wrote:
Are you suggesting we leave those warnings there until somebody decides
to fix all the portability issues of this driver? My patch is a small
and insignificant improvement and not the revolution you're asking for,
but is
Il Monday 15 October 2007 20:24:21 Jeff Garzik ha scritto:
applied
Small update to the driver, please apply
Signed-off-by: Matteo Croce [EMAIL PROTECTED]
Signed-off-by: Eugene Konev [EMAIL PROTECTED]
Signed-off-by: Felix Fietkau [EMAIL PROTECTED]
diff --git a/drivers/net/cpmac.c
Ingo Oeser wrote:
Valentine Barshak schrieb:
Oliver Neukum wrote:
Am Montag 22 Oktober 2007 schrieb Valentine Barshak:
static int asix_mdio_read(struct net_device *netdev, int phy_id, int loc)
{
struct usbnet *dev = netdev_priv(netdev);
+ void *buf;
u16 res;
On systems with noncoherent cache, allocating dma buffers
on the stack for USB IN transfers causes kernel crash,
because usb map_urb_for_dma() code calls dma_map_single(),
that invalidates data cache for DMA_FROM_DEVICE transfer direction
and causes stack data loss if transfer size is less than
UDP currently uses skb-dev-ifindex which may provide the wrong
information when the socket bound to a specific interface.
This patch makes inet_iif() accessible to UDP and makes UDP use it.
The scenario we are trying to fix is when a client is running on
the same system and the server and both
Hello!
When GRE tunnel is in NBMA mode, this patch allows an application to use
a PF_PACKET socket to:
- send a packet to specific NBMA address with sendto()
- use recvfrom() to receive packet and check which NBMA address it came from
This is required to implement properly NHRP over GRE
Port alternate MAC address support from the sourceforge
e1000 driver to the upstream e1000 driver.
Signed-off-by: Bill Hayes [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_hw.c | 42 +++---
drivers/net/e1000/e1000_hw.h |2 ++
2 files changed, 41
Port alternate MAC address support from the sourceforge
e1000 driver to the upstream e1000e driver.
Signed-off-by: Bill Hayes [EMAIL PROTECTED]
---
drivers/net/e1000e/82571.c |4
drivers/net/e1000e/lib.c | 39 +--
drivers/net/e1000e/hw.h
On Tue, 2007-23-10 at 16:08 +0900, Masahide NAKAMURA wrote:
Thanks. I would like you to find too much item at my patch
for the statistics, too.
I am not anywhere close to a machine where i can give you precise
details to this; the one thing that sticks out in my brain cells is the
SPI
From [EMAIL PROTECTED] Tue Oct 23 10:51:00 2007
Date: Tue, 23 Oct 2007 21:40:18 +0400
From: Valentine Barshak [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Cc: netdev@vger.kernel.org
Subject: [linux-usb-devel] [PATCH] USB: net: Fix asix read transfer buffer
allocations.
On systems with
Hello!
Me wrote:
Ack. This is good idea.
Frankly, I was sure ip_gre worked in this way all these years.
I do not remember any reasons why it was crippled.
The only dubious case is when next hop is set using routing tables.
But code in ipgre_tunnel_xmit() is ready to accept this
Kok, Auke wrote:
Adam Jackson wrote:
On Tue, 2007-10-23 at 09:18 -0700, Kok, Auke wrote:
Adam Jackson wrote:
When the EEPROM gets corrupted, you can fix it with ethtool, but only if
the module loads and creates a network device. But, without this option,
if the EEPROM is corrupted, the
Jeff Garzik wrote:
Kok, Auke wrote:
Adam Jackson wrote:
On Tue, 2007-10-23 at 09:18 -0700, Kok, Auke wrote:
Adam Jackson wrote:
When the EEPROM gets corrupted, you can fix it with ethtool, but
only if
the module loads and creates a network device. But, without this
option,
if the EEPROM
The following changes since commit e8b8c977734193adedf2b0f607d6252c78e86394:
Linus Torvalds (1):
Revert kconfig: tristate choices with mixed tristate and boolean
values
are available in the git repository at:
git://farnsworth.org/dale/linux-2.6-mv643xx_eth.git bug-fixes
Dale
The following changes since commit e8b8c977734193adedf2b0f607d6252c78e86394:
Linus Torvalds (1):
Revert kconfig: tristate choices with mixed tristate and boolean
values
are available in the git repository at:
git://farnsworth.org/dale/linux-2.6-mv643xx_eth.git features
Dale
On Tue, Oct 23, 2007 at 04:40:01PM -0400, Jeff Garzik wrote:
In any case, this patch should not be merged. We often send it around to
users to
debug their issue in case it involves eeproms, but merging it will just
conceal
the real issue and all of a sudden a flood of people stop
People aren't going to report this as a bug. They aren't going to try out
patches,
they're going to do what I did and stick another network card in the box and
go on with life.
Our users deserve better than this.
Agreed. By all means warn people, or give them a 1-800 Intel number to
From: Kok, Auke [EMAIL PROTECTED]
Date: Tue, 23 Oct 2007 14:01:21 -0700
We help everyone out, and if you merge this patch you will prevent
users from getting to us for support in the first place.
If using the bad eeprom has to be explicitly enabled by the user, your
argument holds no water.
From: Dave Jones [EMAIL PROTECTED]
Date: Tue, 23 Oct 2007 17:20:26 -0400
Indeed. This is a common enough problem that not including it causes
more pain than its worth. I have two affected boxes myself that I
actually thought the hardware was dead before I tried ajax's patch.
People aren't
Patrick McHardy wrote:
[VLAN]: MAINTAINERS update
Ben stepped down from VLAN maintainership due to a lack of time,
add myself as new maintainer.
ACK. Thanks Patrick!
Ben
--
Ben Greear [EMAIL PROTECTED]
Candela
Al Boldi wrote:
[EMAIL PROTECTED] wrote:
On Sat, 20 Oct 2007 06:40:02 +0300, Al Boldi said:
Sure, the idea was to mark the filter table obsolete as to make people
start using the mangle table to do their filtering for new setups. The
filter table would then still be available for
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
diff --git a/drivers/net/eexpress.c b/drivers/net/eexpress.c
index 9c85e50..70509ed 100644
--- a/drivers/net/eexpress.c
+++ b/drivers/net/eexpress.c
@@ -651,9 +651,9 @@ static void eexp_timeout(struct net_device *dev)
*/
static int
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
diff --git a/drivers/net/ni5010.c b/drivers/net/ni5010.c
index 14a768f..a20005c 100644
--- a/drivers/net/ni5010.c
+++ b/drivers/net/ni5010.c
@@ -518,7 +518,6 @@ static void dump_packet(void *buf, int len)
/* We have a good packet, get it out of
net/sched/sch_prio.c: In function âprio_dequeueâ:
net/sched/sch_prio.c:139: warning: passing argument 2 of
ânetif_subqueue_stoppedâ makes pointer from integer without a cast
net/sched/sch_prio.c: In function ârr_dequeueâ:
net/sched/sch_prio.c:169: warning: passing argument 2 of
From: Jeff Garzik [EMAIL PROTECTED]
Date: Tue, 23 Oct 2007 18:36:46 -0400 (EDT)
net/sched/sch_prio.c: In function $,1rx(Bprio_dequeue$,1ry(B:
net/sched/sch_prio.c:139: warning: passing argument 2 of
$,1rx(Bnetif_subqueue_stopped$,1ry(B makes pointer from integer without a
cast
David Miller wrote:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Tue, 23 Oct 2007 18:36:46 -0400 (EDT)
net/sched/sch_prio.c: In function $,1rxprio_dequeue$,1ry:
net/sched/sch_prio.c:139: warning: passing argument 2 of
$,1rxnetif_subqueue_stopped$,1ry makes pointer from integer without a cast
Dave Jones wrote:
On Tue, Oct 23, 2007 at 04:40:01PM -0400, Jeff Garzik wrote:
In any case, this patch should not be merged. We often send it around to
users to
debug their issue in case it involves eeproms, but merging it will just
conceal
the real issue and all of a sudden a
David Miller wrote:
From: Dave Jones [EMAIL PROTECTED]
Date: Tue, 23 Oct 2007 17:20:26 -0400
Indeed. This is a common enough problem that not including it causes
more pain than its worth. I have two affected boxes myself that I
actually thought the hardware was dead before I tried ajax's
On Tue, 23 Oct 2007 16:03:38 -0700
Kok, Auke [EMAIL PROTECTED] wrote:
Dave Jones wrote:
On Tue, Oct 23, 2007 at 04:40:01PM -0400, Jeff Garzik wrote:
In any case, this patch should not be merged. We often send it around
to users to
debug their issue in case it involves eeproms,
Francois Romieu wrote:
Please pull from branch 'upstream-jeff' in repository
git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git
upstream-jeff
pulled, thanks.
and thanks for continuing to CC RealTek.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the
Dale Farnsworth wrote:
The following changes since commit e8b8c977734193adedf2b0f607d6252c78e86394:
Linus Torvalds (1):
Revert kconfig: tristate choices with mixed tristate and boolean
values
are available in the git repository at:
Dale Farnsworth wrote:
The following changes since commit e8b8c977734193adedf2b0f607d6252c78e86394:
Linus Torvalds (1):
Revert kconfig: tristate choices with mixed tristate and boolean
values
are available in the git repository at:
Ralf Baechle wrote:
Plus minor formatting fixes.
Signed-off-by: Ralf Baechle [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Stephen Hemminger wrote:
Fix off-by one in remove logic that just got introduced.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
This only occurs in new post 2.6.23 code.
applied
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
Matteo Croce wrote:
Il Monday 15 October 2007 20:24:21 Jeff Garzik ha scritto:
applied
Small update to the driver, please apply
Signed-off-by: Matteo Croce [EMAIL PROTECTED]
Signed-off-by: Eugene Konev [EMAIL PROTECTED]
Signed-off-by: Felix Fietkau [EMAIL PROTECTED]
applied
Please
applied 1-2
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Maciej W. Rozycki wrote:
The dfx_bus_uninit() call is called from dfx_unregister() which is
__devexit and which is ultimately the -remove call for the device.
Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED]
---
It should be obvious. Please apply.
Maciej
Olof Johansson wrote:
Add missing :
drivers/net/pasemi_mac.c: In function 'pasemi_mac_clean_rx':
drivers/net/pasemi_mac.c:553: warning: passing argument 1 of 'prefetch'
makes pointer from integer without a cast
Signed-off-by: Olof Johansson [EMAIL PROTECTED]
diff --git
Jay Vosburgh wrote:
Convert bonding timers to workqueues. This converts the various
monitor functions to run in periodic work queues instead of timers. This
patch introduces the framework and convers the calls, but does not resolve
various locking issues, and does not stand alone.
Actually, looking over the code I see obvious bugs in the logic:
An invalid ethernet address should not cause device loading to fail,
because the user is given the opportunity to supply a MAC address via
userspace (ifconfig or whatever) before the interface goes up.
I just created the
Jeff Garzik [EMAIL PROTECTED] wrote:
applied patches 1-6
Thanks.
However, two issues:
1) Credit. Did Andy write these, as the Signed-off-by lines indicate?
Andy did some of it and I did some of it, so I presume that dual
Signed-off-by is correct (vs. one Signed-off and one
Jeff Garzik wrote:
Actually, looking over the code I see obvious bugs in the logic:
An invalid ethernet address should not cause device loading to fail,
because the user is given the opportunity to supply a MAC address via
userspace (ifconfig or whatever) before the interface goes up.
I
I've been meaning to bring this up.
A lot of cards that support multiple MAC addresses
in hardware provide pre-cooked lists of alternate
MAC addresses. This is either done via EEPROM,
NVRAM, or OpenFirmware device properties.
For example, the Sun Neptune cards can provide an
array of up to 16
From: Jeff Garzik [EMAIL PROTECTED]
Date: Tue, 23 Oct 2007 21:03:36 -0400
I'm wondering if there is a way to avoid adding
if (!is_valid_ether_addr(dev-dev_addr))
return -EINVAL;
to every ethernet driver's -open() hook.
The first idea I get is:
1) Create
On Tue, Oct 23, 2007 at 08:55:29PM -0400, Jeff Garzik wrote:
Actually, looking over the code I see obvious bugs in the logic:
An invalid ethernet address should not cause device loading to fail,
because the user is given the opportunity to supply a MAC address via
userspace (ifconfig or
On Tue, Oct 23, 2007 at 06:00:01PM -0700, Jay Vosburgh wrote:
Jeff Garzik [EMAIL PROTECTED] wrote:
applied patches 1-6
Thanks.
However, two issues:
1) Credit. Did Andy write these, as the Signed-off-by lines indicate?
Andy did some of it and I did some of it, so I
Andy Gospodarek wrote:
On Tue, Oct 23, 2007 at 06:00:01PM -0700, Jay Vosburgh wrote:
Jeff Garzik [EMAIL PROTECTED] wrote:
applied patches 1-6
Thanks.
However, two issues:
1) Credit. Did Andy write these, as the Signed-off-by lines indicate?
Andy did some of it and I did
The cgroup change was ack'd by the maintainer. The drivers/net/ were of
course self-ack'd.
Please pull from 'warnings' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git warnings
to receive the following updates:
drivers/net/eexpress.c |2 +-
drivers/net/ni5010.c
David Miller wrote:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Tue, 23 Oct 2007 21:03:36 -0400
I'm wondering if there is a way to avoid adding
if (!is_valid_ether_addr(dev-dev_addr))
return -EINVAL;
to every ethernet driver's -open() hook.
The first idea I get is:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Tue, 23 Oct 2007 22:20:30 -0400
David Miller wrote:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Tue, 23 Oct 2007 21:03:36 -0400
I'm wondering if there is a way to avoid adding
if (!is_valid_ether_addr(dev-dev_addr))
return
David Miller wrote:
I've been meaning to bring this up.
A lot of cards that support multiple MAC addresses
in hardware provide pre-cooked lists of alternate
MAC addresses. This is either done via EEPROM,
NVRAM, or OpenFirmware device properties.
For example, the Sun Neptune cards can provide
Jeff Garzik wrote:
h. Using ethtool isn't a big deal, but IMO you probably want more
than just an exported list for the usage you described... it sounds
like some sort of reservation system should be used, to note which MAC
addresses are [not] in use?
Then a virt client -- or anyone
1 - 100 of 129 matches
Mail list logo
