SGI IP28 machines would need special treatment (enable adding addtional
wait states) when accessing memory uncached. To avoid this pain I changed
the driver to use only cached access to memory.
Signed-off-by: Thomas Bogendoerfer [EMAIL PROTECTED]
---
Changes to last version:
- Use inline
On Sun, 2 Dec 2007, Herbert Xu wrote:
On Sun, Dec 02, 2007 at 12:48:08AM +0200, Ilpo Järvinen wrote:
This work was mostly done by David S. Miller.
...
@@ -253,6 +254,8 @@ struct sk_buff {
struct sk_buff *next;
struct sk_buff *prev;
+ struct
On Sun, 2 Dec 2007, Herbert Xu wrote:
On Sun, Dec 02, 2007 at 12:48:07AM +0200, Ilpo Järvinen wrote:
@@ -1220,6 +1221,11 @@ static inline struct sk_buff
*tcp_write_queue_next(struct sock *sk, struct sk_bu
return skb-next;
}
+static inline struct sk_buff
On Sun, Dec 02, 2007 at 01:29:36PM +0200, Ilpo Järvinen wrote:
Hmm didn't crash for me, probably a silent corruption instead :-(.
It crashed during NIS start-up and I suppose I'm the only still
running NIS :)
Maybe I could add catch for invalid skb dereferences (those list heads) to
[SNIP]
^^ the correct solution is to implement arch_initcall function
which will create fixed PHYs, and then leave only
snprintf(fpi-bus_id, 16, PHY_ID_FMT, 0, *data); part in the
fs_enet's find_phy().
Try add something like this to the fsl_soc.c (compile untested):
- - - -
static int
On Sun, Dec 02, 2007 at 12:54:36PM +0100, Joakim Tjernlund wrote:
[SNIP]
^^ the correct solution is to implement arch_initcall function
which will create fixed PHYs, and then leave only
snprintf(fpi-bus_id, 16, PHY_ID_FMT, 0, *data); part in the
fs_enet's find_phy().
Try add
Em Sat, Dec 01, 2007 at 09:27:49PM +0100, Michael Buesch escreveu:
On Saturday 01 December 2007 20:00:23 Arnaldo Carvalho de Melo wrote:
Em Sat, Dec 01, 2007 at 12:45:32PM -0500, John W. Linville escreveu:
On Sat, Dec 01, 2007 at 03:17:44PM -0200, Arnaldo Carvalho de Melo wrote:
Sonics
Also remove trailing spaces from multivalued files.
This fixes output like for example:
$ od -c /sys/class/net/bond0/bonding/slaves
000 e t h - l e f t e t h - r i g
020 h t \n \0
025
It mostly entails deleting '+1'-s after sprintf()
The previous code returned '\n' (that is, a single empty line)
from most files, with one exception (xmit_hash_policy), where
it returned 'NA\n'. This patch consolidates each file to return
nothing at all if not applicable, not even a '\n'.
I find this behaviour more usual, more useful, more
Code for rendering multivalue sysfs files occurs three times
in this module. Rename 'buffer' to 'buf' in the first, for
the sake of consistency.
Signed-off-by: Ferenc Wagner [EMAIL PROTECTED]
---
drivers/net/bonding/bond_sysfs.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
Signed-off-by: Ferenc Wagner [EMAIL PROTECTED]
---
drivers/net/bonding/bond_sysfs.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
index 5c31f5c..9de2c52 100644
---
For consistency with the behaviour of the arp_ip_target option,
let /sys/class/net/bond0/bonding/xmit_hash_policy accept and report
current policy even if the bonding mode in effect does not use it.
Signed-off-by: Ferenc Wagner [EMAIL PROTECTED]
---
drivers/net/bonding/bond_sysfs.c | 21
On Sat, 1 Dec 2007 16:30:35 -0800
Stephen Hemminger [EMAIL PROTECTED] wrote:
On Sat, 1 Dec 2007 11:17:36 -0800
Stephen Hemminger [EMAIL PROTECTED] wrote:
Then init_net needs to be not GPL limited. Sorry, we need to allow
non GPL network drivers. There is a fine line between keeping the
On Fri, Nov 30, 2007 at 10:52:22PM +0100, Jiri Slaby wrote:
Hi,
this commit:
[NET]: Move sock_valbool_flag to socket.c
The sock_valbool_flag() helper is used in setsockopt to
set or reset some flag on the sock. This helper is required
in the net/socket.c only, so move it
On Fri, 30 Nov 2007 10:26:54 -0800, Rick Jones wrote:
Could the corruption be seen in a tcpdump trace prior to transmission (ie
taken on the sender) or was it only seen after the data passed out the
NIC?
I did the following:
1) turn on tso on the server's r8169: ethtool --offload eth0 tso
Should get the skb from the same queue. I had it first elsewhere
and missed this change while moving.
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
---
diff --git a/include/net/tcp.h b/include/net/tcp.h
index 7ae72c3..5929022 100644
--- a/include/net/tcp.h
+++ b/include/net/tcp.h
@@ -1524,7
Hi,
Many thanks for your patch for ~/net/ax25/ax25_subr.c
Introduction of local_bh_disable() ... local_bh_enable()
cured the inconsistent lock state related to AX25 connect timeout.
I have now a stable monoprocessor system running AX25 and ROSE network
packet switching application FPAC,
Stephen Hemminger wrote:
Naw, enterprise (or any other) distro vendors shouldn't have any issues here,
since they can just patch their kernels around any issues.
But it looks like Eric has this one thought out well enough.
So you are saying all this is not a problem, fine.
Any affected
On Sun, 02 Dec 2007 13:51:04 GMT, Alan Cox said:
On Sat, 1 Dec 2007 16:30:35 -0800
I spoke too soon earlier, ndiswrapper builds and loads against current
2.6.24-rc3. Vmware and proprietary VPN software probably do not. Once again
I don't
give a damn, but the enterprise distro vendors
Ben Greear wrote:
Stephen Hemminger wrote:
Naw, enterprise (or any other) distro vendors shouldn't have any
issues here,
since they can just patch their kernels around any issues.
But it looks like Eric has this one thought out well enough.
So you are saying all this is not a
On Sun, Dec 02, 2007 at 09:03:56PM +0100, Patrick McHardy wrote:
Ben Greear wrote:
Stephen Hemminger wrote:
Naw, enterprise (or any other) distro vendors shouldn't have any issues
here,
since they can just patch their kernels around any issues.
But it looks like Eric has this one thought
This is in preparation for merging the new rx history code written by Gerrit
Renker.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 35 ++---
net/dccp/ccids/lib/packet_history.c | 95 ++-
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/lib/packet_history.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/net/dccp/ccids/lib/packet_history.c
b/net/dccp/ccids/lib/packet_history.c
index 1d4d6ee..b628714 100644
WARNING: After reading some messages from Ingo Molnar on lkml I think we should
really
trim the number of lists we use for kernel development. And since I
moved
back to using mutt for reading e-mails, something I should have never,
ever
stopped doing, I guess we
From: Gerrit Renker [EMAIL PROTECTED]
This patch changes the tfrc_lib module in the following manner:
(1) a dedicated tfrc source file to call the packet history
loss interval init/exit functions.
(2) a dedicated tfrc_pr_debug macro with toggle switch `tfrc_debug'.
Commiter note:
From: Gerrit Renker [EMAIL PROTECTED]
Only the sender sets window counters [RFC 4342, sections 5 and 8.1].
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c |1 -
Bernard Pidoux wrote, On 12/02/2007 06:37 PM:
Hi,
Many thanks for your patch for ~/net/ax25/ax25_subr.c
Introduction of local_bh_disable() ... local_bh_enable()
cured the inconsistent lock state related to AX25 connect timeout.
I have now a stable monoprocessor system running AX25
Adrian Bunk wrote:
On Sun, Dec 02, 2007 at 09:03:56PM +0100, Patrick McHardy wrote:
For all I care binary modules can break, but frankly I don't see
how encapsulating a couple of structures and pointers in a new
structure and adding a new argument to existing functions shifts
the decision
From: Gerrit Renker [EMAIL PROTECTED]
as per RFC 4340, sec. 7.7.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/dccp.h | 12
1 files changed, 12 insertions(+), 0
This is in preparation for merging the new rx history code written by Gerrit
Renker.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 32 ++--
net/dccp/ccids/lib/loss_interval.c | 14 +++---
net/dccp/ccids/lib/packet_history.c |
Credit here goes to Gerrit Renker, that provided the initial implementation for
this new codebase.
I modified it just to try to make it closer to the existing API, hide details
from
the CCIDs and fix a couple bugs found in the initial implementation.
Original changeset comment from Gerrit:
Hello,
with kernel 2.6.23.8 we saw a
KERNEL: assertion ((int)tcp_packets_in_flight(tp) = 0) failed at
net/ipv4/tcp_input.c (1292)
Regards,
Wolfgang Walter
--
Wolfgang Walter
Studentenwerk München
Anstalt des öffentlichen Rechts
--
To unsubscribe from this list: send the line unsubscribe
Then init_net needs to be not GPL limited. Sorry, we need to allow
non GPL network drivers. There is a fine line between keeping the
Why - they aren't exactly likely to be permissible by law
Really? What law and/or what clause in the GPL says that derivative works
have to be licensed
Herbert Xu wrote:
On Fri, Nov 30, 2007 at 02:35:43PM -0500, Andrew Gallatin wrote:
Isn't the value of 2 ethernet-specific (to round the 14-byte header up
to 16)? Given that the rest of the lro code is fairly careful to
calculate mac_hdr_len etc it seems as if it would be cleaner to make
this
You license yours under the GPL, so they should respect the GPL.
It sounds like we're back to where we were years ago. Didn't we already
agree that EXPORT_SYMBOL_GPL was *NOT* a GPL-enforcement mechanism and had
nothing to do with respecting the GPL? After all, if it s a GPL-enforcement
No
On Sun, Dec 02, 2007 at 10:59:46PM +0100, Patrick McHardy wrote:
Adrian Bunk wrote:
On Sun, Dec 02, 2007 at 09:03:56PM +0100, Patrick McHardy wrote:
...
your statement has an interesting implication:
Stuff like e.g. the EXPORT_SYMBOL(sk_alloc) predates the EXPORT_SYMBOL_GPL
stuff.
Who is
The attached patch observes the stir4200 fifo size and will clear the fifo, if
the size is increasing, while it should be transmitting bytes
From: Olaf Hartmann [EMAIL PROTECTED]
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
---
drivers/net/irda/stir4200.c | 10 ++
1 file changed, 6
While testing the mcs7780 based IrDA USB dongle I've stumbled upon
memory leak in mcs_net_close(). Patch below fixes it.
Signed-off-by: Hinko Kocevar [EMAIL PROTECTED]
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
---
drivers/net/irda/mcs7780.c |2 ++
1 file changed, 2 insertions(+)
Index:
Hi Herbert,
Here goes a series of 5 IrDA patches against your latest net-2.6 tree.
Cheers,
Samuel.
--
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
This patch fixes:
CHECK /home/kernel/src/net/irda/parameters.c
/home/kernel/src/net/irda/parameters.c:466:2: warning: Using plain integer as
NULL pointer
/home/kernel/src/net/irda/parameters.c:520:2: warning: Using plain integer as
NULL pointer
/home/kernel/src/net/irda/parameters.c:573:2:
It seems to me that irda_usb_net_open() must set self-netopen
under spinlock or disconnect() may fail to kill all URBs, if it is called
while an interface is opened.
Signed-off-by: Oliver Neukum [EMAIL PROTECTED]
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
---
drivers/net/irda/irda-usb.c |
Signed-off-by: David Woodhouse [EMAIL PROTECTED]
diff --git a/drivers/net/pasemi_mac.c b/drivers/net/pasemi_mac.c
index 09b4fde..a8db5d7 100644
--- a/drivers/net/pasemi_mac.c
+++ b/drivers/net/pasemi_mac.c
@@ -1362,7 +1362,7 @@ pasemi_mac_probe(struct pci_dev *pdev, const struct
pci_device_id
On Thu, Nov 29, 2007 at 03:53:23PM +0300, Evgeniy Polyakov wrote:
Distributed storage documentation.
Algorithms used in the system, userspace interfaces
(sysfs dirs and files), design and implementation details
are described here.
Can you give us a summary of how this differs from using
On Thu, Nov 29, 2007 at 04:01:25PM +0300, Pavel Emelyanov wrote:
@@ -863,13 +861,13 @@ int inet_diag_register(const struct inet_diag_handler
*h)
if (type = INET_DIAG_GETSOCK_MAX)
goto out;
- spin_lock(inet_diag_register_lock);
+ mutex_lock(inet_diag_mutex);
On Mon, Dec 03, 2007 at 04:34:32AM +, David Woodhouse wrote:
Signed-off-by: David Woodhouse [EMAIL PROTECTED]
Acked-by: Olof Johansson [EMAIL PROTECTED]
Jeff,
I'd like to see this in 2.6.24, please.
Thanks,
-Olof
--
To unsubscribe from this list: send the line unsubscribe netdev in
the
On Saturday 01 December 2007 7:28:34 am Herbert Xu wrote:
On Fri, Nov 30, 2007 at 09:51:48AM -0500, Paul Moore wrote:
Steve and/or Joy, could we get a verdict on this issue? The lack of a
netmask in the SPD audit messages is pretty serious so I'd like to see
this fixed as soon as possible.
On Mon, Dec 03, 2007 at 10:28:31AM +0100, Samuel Ortiz wrote:
Hi Herbert,
Here goes a series of 5 IrDA patches against your latest net-2.6 tree.
I seem to be missing 3/5. Could you please resend?
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL
Herbert Xu said the following on 2007-12-1 9:54:
On Fri, Nov 30, 2007 at 11:19:49AM +, Gerrit Renker wrote:
| csum_copy_err:
| - UDP6_INC_STATS_USER(UDP_MIB_INERRORS, is_udplite);
| + UDP6_INC_STATS_BH(UDP_MIB_INERRORS, is_udplite);
|skb_kill_datagram(sk, skb, flags);
|
|if
James Morris wrote:
On Thu, 22 Nov 2007, Tetsuo Handa wrote:
This patch allows LSM modules filter incoming connections/datagrams
based on the process's security context who is attempting to pick up.
There are already hooks to filter incoming connections/datagrams
based on the socket's
Ariane Keller wrote:
Thanks for your comments!
I'd like to better understand your dislike of the current implementation
of the data transfer from user space to kernel space.
Is it the fact that we use configfs?
I think, we had already a discussion about this (and we changed from
procfs to
50 matches
Mail list logo
