From: Wagner Ferenc <[EMAIL PROTECTED]>
From: Wagner Ferenc <[EMAIL PROTECTED]>
For consistency with the behaviour of the arp_ip_target option,
let /sys/class/net/bond0/bonding/xmit_hash_policy accept and report
current policy even if the bonding mode in effect does not use it.
Signed-off-by: Fe
From: Wagner Ferenc <[EMAIL PROTECTED]>
From: Wagner Ferenc <[EMAIL PROTECTED]>
The previous code returned '\n' (that is, a single empty line)
from most files, with one exception (xmit_hash_policy), where
it returned 'NA\n'. This patch consolidates each file to return
nothing at all if not appli
From: Wagner Ferenc <[EMAIL PROTECTED]>
From: Wagner Ferenc <[EMAIL PROTECTED]>
Code for rendering multivalue sysfs files occurs three times
in this module. Rename 'buffer' to 'buf' in the first, for
the sake of consistency.
Signed-off-by: Ferenc Wagner <[EMAIL PROTECTED]>
Acked-by: Jay Vosburg
From: Wagner Ferenc <[EMAIL PROTECTED]>
From: Wagner Ferenc <[EMAIL PROTECTED]>
Adhere to coding style: break line after the if condition
Signed-off-by: Ferenc Wagner <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_sysfs.c |9 ++---
1 files ch
From: Wagner Ferenc <[EMAIL PROTECTED]>
From: Wagner Ferenc <[EMAIL PROTECTED]>
Also remove trailing spaces from multivalued files.
This fixes output like for example:
$ od -c /sys/class/net/bond0/bonding/slaves
000 e t h - l e f t e t h - r i g
020 h
Add new hash for balance-xor and 802.3ad modes. Originally
submitted by "Glenn Griffin" <[EMAIL PROTECTED]>; modified by
Jay Vosburgh to move setting of hash policy out of line, tweak the
documentation update and add version update to 3.2.2.
Glenn's original comment follows:
I
From: David Sterba <[EMAIL PROTECTED]>
From: David Sterba <[EMAIL PROTECTED]>
Use macros for comparing jiffies. Jiffies' wrap caused missed events and hangs.
Module reinsert was needed to make bonding work again.
Signed-off-by: David Sterba <[EMAIL PROTECTED]>
Acked-by: Jay Vosburgh <[EMAIL PROT
Fixes a race condition in module unload. Without this change,
workqueue events may fire while bonding data structures are partially
freed but before bond_close() is invoked by unregister_netdevice().
Update version to 3.2.3.
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
dr
Patch series to fix some bugs, fix coding style, and add a new
hash mode for balance-xor/802.3ad modes.
Jeff: please apply to upstream.
Patch 8 should arguably go in to 2.6.24, as it's a bug in the
locking fixes added there and can cause an oops; is it too late for that?
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu, 06 Dec 2007 14:59:24 +0100
> Pavel Emelyanov wrote:
> > The SET_VLAN_NAME_TYPE_CMD command w/o CAP_NET_ADMIN capability
> > doesn't release the rtnl lock.
>
>
> Thanks Pavel. I somehow recall that we already fixed this
> one, but can't find th
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Thu, 6 Dec 2007 09:23:12 -0800
> Tools and scripts for testing that generate graphs are at:
> git://git.kernel.org/pub/scm/tcptest/tcptest
I know about this, I'm just curious what exactly Ilpo is
using :-)
--
To unsubscribe from this list: s
From: Vlad Yasevich <[EMAIL PROTECTED]>
Date: Thu, 6 Dec 2007 12:48:22 -0500
> The following two patches fix some bugs in the SCTP accept code path.
> The first one fixes a slab corruption bug that we found during stress
> testing. The second one is just a clean-up and the right way to do things
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
Date: Thu, 6 Dec 2007 19:02:47 -0200
> Please consider pulling from:
>
> master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25
Pulled and pushed out to net-2.6.25, thanks!
--
To unsubscribe from this list: send the line "unsubscribe
From: Mitsuru Chinen <[EMAIL PROTECTED]>
Date: Fri, 7 Dec 2007 13:24:18 +0900
> The patch `Reply net unreachable ICMP message' had a bug.
> A route whose type is blockhole or prohibit type is treated as
> unreachable type. The case where err is set to ENETUNREACH should
> be that no route is found
On Mon, 2007-11-26 at 15:17 -0700, Eric W. Biederman wrote:
> Well I clearly goofed when I added the initial network namespace support
> for /proc/net. Currently things work but there are odd details visible
> to user space, even when we have a single network namespace.
>
> Since we do not cache
The patch `Reply net unreachable ICMP message' had a bug.
A route whose type is blockhole or prohibit type is treated as
unreachable type. The case where err is set to ENETUNREACH should
be that no route is found in the routing table only.
Signed-off-by: Mitsuru Chinen <[EMAIL PROTECTED]>
---
net
On Thu, 6 Dec 2007 09:47:33 +0100
Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> On 06-12-2007 09:14, Mitsuru Chinen wrote:
> > On Thu, 6 Dec 2007 08:49:47 +0100
> > Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> >
> >> On 06-12-2007 07:31, Mitsuru Chinen wrote:
> >>> IPv4 stack doesn't reply any ICM
Greetings Ilpo,
On 04/12/2007, Ilpo Järvinen <[EMAIL PROTECTED]> wrote:
> On Mon, 3 Dec 2007, Lachlan Andrew wrote:
> >
> > When SACK is active, the per-packet processing becomes more involved,
> > tracking the list of lost/SACKed packets. This causes a CPU spike
> > just after a loss, which incr
From: Richard Knutsson <[EMAIL PROTECTED]>
Date: Thu, 06 Dec 2007 15:37:46 +0100
> David Miller wrote:
> > But this time I'll just let you know up front that I
> > don't see much value in this patch. It is not a clear
> > improvement to replace int's with bool's in my mind and
> > the other chang
From: Stefan Rompf <[EMAIL PROTECTED]>
Date: Thu, 6 Dec 2007 15:31:53 +0100
> as far as I've understood Herbert's patch, at least TCP connect can be fixed
> so that non blocking connect() will neither fail nor block, but just use the
> first or second retransmission of the SYN packet to complete
Divy Le Ray wrote:
Jeff,
I'm submitting a patch series for inclusion in 2.6.25.
The patches are built against netdev#upstream.
Here is a brief description:
- Update GPIO pinning and MAC support for T3C adapters
- Enable parity error detection.
Jeff,
I posted a third patch to fix the EEH code
From: Divy Le Ray <[EMAIL PROTECTED]>
set_pci_drvdata() stores a pointer to the adapter,
not the net device.
Add missing softirq blocking in t3_mgmt_tx.
Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/cxgb3_main.c | 14 --
drivers/net/cxgb3/sge.c|7
...thus use fixed-link to register proper "Fixed PHY"
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc8349emitx.dts | 11 ++-
1 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/arch/powerpc/
fixed-link says: register new "Fixed/emulated PHY", i.e. PHY that
not connected to the real MDIO bus.
Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]>
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
Documentation/powerpc/booting-without-of.txt |4 +
arch/powerpc/sysdev/fsl_soc.c
With that patch fixed.c now fully emulates MDIO bus, thus no need
to duplicate PHY layer functionality. That, in turn, drastically
simplifies the code, and drops down line count.
As an additional bonus, now there is no need to register MDIO bus
for each PHY, all emulated PHYs placed on the platfo
On Wed, 2007-12-05 at 16:01 -0800, Andrew Morton wrote:
> No, I think print_hex_dump() is too low-level to be doing allocations.
> For example, one could easily choose to call print_hex_dump() at oops time,
> and then what happens if we oops in kmalloc() (as we often do...)?
>
> You could trim li
From: Gerrit Renker <[EMAIL PROTECTED]>
This patch changes the tfrc_lib module in the following manner:
(1) a dedicated tfrc source file to call the packet history &
loss interval init/exit functions.
(2) a dedicated tfrc_pr_debug macro with toggle switch `tfrc_debug'.
Commiter note: rena
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/ccids/lib/packet_history.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/net/dccp/ccids/lib/packet_history.c
b/net/dccp/ccids/l
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25
Best Regards,
- Arnaldo
b/net/dccp/ccids/Kconfig | 13
b/net/dccp/ccids/ccid3.c | 35 --
b/net/dccp/ccids/ccid3.h | 14
b/net/dccp/ccids/l
Credit here goes to Gerrit Renker, that provided the initial implementation for
this new codebase.
I modified it just to try to make it closer to the existing API, renaming some
functions, add namespacing and fix one bug where the tfrc_rx_hist_alloc was not
freeing the allocated ring entries on th
This is in preparation for merging the new rx history code written by Gerrit
Renker.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/ccids/ccid3.c | 32 ++--
net/dccp/ccids/lib/loss_interval.c | 1
This is in preparation for merging the new rx history code written by Gerrit
Renker.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/ccids/ccid3.c | 35 ++---
net/dccp/ccids/lib/packet_history.c |
From: Gerrit Renker <[EMAIL PROTECTED]>
Only the sender sets window counters [RFC 4342, sections 5 and 8.1].
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/ccids/ccid3.c |
From: Gerrit Renker <[EMAIL PROTECTED]>
as per RFC 4340, sec. 7.7.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/dccp.h | 12
1 files changed, 12 insertions
The s2io driver keeps a local variable around (vlan_strip_flag) to keep
track of the current state of the hardware and whether or not it will
strip VLAN tags on incoming packets. It seems as though the hardware
default is to strip them, but that variable is not set correctly during
initialization
On Tue, 4 Dec 2007 14:58:18 +0100
Andreas Henriksson <[EMAIL PROTECTED]> wrote:
> Suggested patch for allowing netmask to be specified in dotted quad format.
> See http://bugs.debian.org/357172
>
> (Known problem: this will not prevent some invalid syntaxes,
> ie. "255.0.255.0" will be treated as
Holger Hoffstaette <[EMAIL PROTECTED]> :
[...]
> Maybe turning off sendfile or NAPI just lead to random success - so far it
> really looks like tso on the r8169 is the common cause.
TSO on the r8169 is the magic switch but the regression makes imvho more
sense from a VM pov:
- the corrupted file
On Thu, Dec 06, 2007 at 03:37:46PM +0100, Richard Knutsson wrote:
>
> Is it not an improvement to distinct booleans from actual values? Do you
> use integers for ASCII characters too? It can also avoid some potential
> bugs like the 'if (i == TRUE)'...
> What is wrong with 'size_t' (since it is u
On Thu, Dec 06, 2007 at 03:31:14PM +0300, Pavel Emelyanov wrote:
>
> BTW, this is not 100% true. Look, in rtm_to_ifaddr()
> I see the following code flow:
>
> ipv4_devconf_setall(in_dev);
>
> ifa = inet_alloc_ifa();
> if (ifa == NULL) {
> /*
>
During accept/migrate the code attempts to copy the addresses from
the parent endpoint to the new endpoint. However, if the parent
was bound to a wildcard address, then we end up pointlessly copying
all of the current addresses on the system.
Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]>
---
SCTP accept code tries to add a newliy created socket
to a bind bucket without holding a lock. On a really
busy system, that can causes slab corruptions.
Add a lock around this code.
Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]>
---
net/sctp/socket.c |6 ++
1 files changed, 6 inserti
Hi Dave
The following two patches fix some bugs in the SCTP accept code path.
The first one fixes a slab corruption bug that we found during stress
testing. The second one is just a clean-up and the right way to do things.
You can also pull both from:
master.kernel.org:/pub/scm/linux/kernel/gi
On Thu, 06 Dec 2007 02:33:46 -0800 (PST)
David Miller <[EMAIL PROTECTED]> wrote:
> From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
> Date: Thu, 6 Dec 2007 01:18:28 +0200 (EET)
>
> > On Wed, 5 Dec 2007, David Miller wrote:
> >
> > > I assume you're using something like carefully crafted printk's,
> > >
Injecting a 10 MBit/s stream with 64 bytes pkgs locks up my
MPC832x CPU even though I got NAPI enabled. Kernel 2.6.23
Any ideas?
Jocke
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
> I have ways to generate errors, so I'll check
Thanks Stephen. We didn't spend a lot of time characterizing the issue,
but our test setup had two blades, each with an 88E8062. Our test
software pumped UDP and TCP traffic of varying packet sizes between the
blades in both directions (including
single list_head variable initialized with LIST_HEAD_INIT could almost
always can be replaced with LIST_HEAD declaration, this shrinks the code
and looks better.
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
---
net/ipv4/cipso_ipv4.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
d
single list_head variable initialized with LIST_HEAD_INIT could almost
always can be replaced with LIST_HEAD declaration, this shrinks the code
and looks better.
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
---
net/core/dev.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --g
The current virtio_net driver has a startup race, which prevents any
incoming traffic:
If try_fill_recv submits buffers to the host system data might be
filled in and an interrupt is sent, before napi_enable finishes.
In that case the interrupt will kick skb_recv_done which will then
call netif_rx
From: Eric W. Biederman <[EMAIL PROTECTED]>
We only use these variables when displaying the trie in proc so
place them into the iterator to make this explicit. We should
probably do something smarter to handle the CONFIG_IP_MULTIPLE_TABLES
case but at least this makes it clear that the silliness
From: Eric W. Biederman <[EMAIL PROTECTED]>
There are only 2 users and it doesn't hurt to call fib_get_table
instead, and it makes it easier to make the fib network namespace
aware.
Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
include
David Miller wrote:
From: WANG Cong <[EMAIL PROTECTED]>
Date: Thu, 6 Dec 2007 19:01:23 +0800
This patch contains the following changes.
- Use 'bool' instead of 'int' for booleans.
- Use 'size_t' instead of 'int' for 'sizeof' return value.
- Some style fixes.
Cc: Her
Am Donnerstag, 6. Dezember 2007 14:55 schrieb David Miller:
> You keep ignoring the fact that, as Herbert and I discussed, not
> blocking for IPSEC resolution will make some connect() cases fail that
> would otherwise not fail.
>
> There are two sides to this issue, and we need to consider them
>
David Miller wrote:
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu, 06 Dec 2007 14:59:24 +0100
Pavel Emelyanov wrote:
The SET_VLAN_NAME_TYPE_CMD command w/o CAP_NET_ADMIN capability
doesn't release the rtnl lock.
Thanks Pavel. I somehow recall that we already fixed this
one, but can't f
Em Thu, Dec 06, 2007 at 02:02:25PM +, Gerrit Renker escreveu:
> | The first six patches in this series are unmodified, so if you
> | are OK with them please send me your Signed-off-by.
> Patches [1/7], [2/7], and [6/7] already have a signed-off and there are
> no changes. Just acknowledged
The xfrm initialization function does not return any error code, so
if there is an error, the caller can not be advise of that.
This patch checks the return code of the different called functions
in order to return a successful or failed initialization.
Signed-off-by: Daniel Lezcano <[EMAIL PROTEC
If the kmem_cache_creation fails, the kernel will panic. It is acceptable
if the system is booting, but if the ipv6 protocol is compiled as a module
and it is loaded after the system has booted, do we want to panic instead
of just failing to initialize the protocol ?
The init function is now retur
If there is an error in the initialization function, nothing is followed up
to the caller. So I add a return value to be set for the init function.
Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]>
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
---
include/net/ip6_fib.h |2 +-
net/ipv6/ip6_fib.
This patchset provides modifications around the routes initialization
for ipv6. Actually the init functions does not return an error code
so the protocol can not be notified that there were an error while
initializing the routing subsystems.
The patchset make the init functions to return an error
The route initialization function does not return any value to notify if
the initialization is successful or not. This patch checks all calls made
for the initilization in order to return a value for the caller.
Unfortunatly, proc_net_fops_create will return a NULL pointer if CONFIG_PROC_FS
is off
When the fib_rules initialization finished, no return code is provided
so there is no way to know, for the caller, if the initialization has
been successful or has failed. This patch fix that.
Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]>
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
---
inclu
The af_inet6 initialization function does not check the return code
of the route initilization, so if something goes wrong, the protocol
initialization will continue anyway.
This patch takes into account the modification made in the different
route's initialization subroutines to check the return v
| The first six patches in this series are unmodified, so if you
| are OK with them please send me your Signed-off-by.
Patches [1/7], [2/7], and [6/7] already have a signed-off and there are
no changes. Just acknowledged [3..5/7], will look at [7/7] now.
Cheers
Gerrit
--
To unsubscribe from
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu, 06 Dec 2007 14:59:24 +0100
> Pavel Emelyanov wrote:
> > The SET_VLAN_NAME_TYPE_CMD command w/o CAP_NET_ADMIN capability
> > doesn't release the rtnl lock.
>
>
> Thanks Pavel. I somehow recall that we already fixed this
> one, but can't find th
| Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Pavel Emelyanov wrote:
The SET_VLAN_NAME_TYPE_CMD command w/o CAP_NET_ADMIN capability
doesn't release the rtnl lock.
Thanks Pavel. I somehow recall that we already fixed this
one, but can't find the patch :) Dave, please apply.
--
To unsubscribe from this list: send the line "unsubscribe net
| Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
| Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Stefan Rompf <[EMAIL PROTECTED]>
Date: Thu, 6 Dec 2007 13:30:20 +0100
> IMHO this is what developers expect, and is also consistent with the
> fact that POSIX does not define O_NONBLOCK behaviour for local
> files.
You keep ignoring the fact that, as Herbert and I discussed, not
blocking fo
The SET_VLAN_NAME_TYPE_CMD command w/o CAP_NET_ADMIN capability
doesn't release the rtnl lock.
Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
---
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index 6567213..5b18315 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -776,7 +776,7 @@ s
Em Thu, Dec 06, 2007 at 02:20:58AM -0800, David Miller escreveu:
> From: Stephen Hemminger <[EMAIL PROTECTED]>
> Date: Wed, 5 Dec 2007 16:33:38 -0500
>
> > On Wed, 05 Dec 2007 08:53:07 -0800
> > Joe Perches <[EMAIL PROTECTED]> wrote:
> >
> > > > it occurred to me that we might want to do somethin
Gerrit,
I think I got this right this time, please see if there is
anything left so that we can move on. I plan to go thru the following
patches restricting myself to namespacing and consistency issues,
leaving ideas I have for later, when we get more of your backlog merged.
The f
Herbert Xu wrote:
> David Miller <[EMAIL PROTECTED]> wrote:
>> The user is pretty much screwed in one way or the other.
>> For example:
>>
>> 1) If 'default' propagates to all devices, any specific
>> setting for a device is lost.
>>
>> 2) If 'default' does not propagate, there is no way to
>>
Am Donnerstag, 6. Dezember 2007 12:39 schrieb David Miller:
> > Because you just will put enough RAM modules into you server when
> > setting up a scalable system.
>
> This suggestion is avoiding the important semantic issue, and
> won't lead to a real discussion of the core problem.
When writing
Thanks. After applying this patch, the warning message is gone.
[PATCH] net: Fix running without sysfs
On Dec 6, 2007 2:00 PM, Eric W. Biederman <[EMAIL PROTECTED]> wrote:
>
> Stephen Hemminger <[EMAIL PROTECTED]> writes:
>
> > On Wed, 5 Dec 2007 10:44:17 +0800
> > "Chung-Chi Lo" <[EMAIL PROTECTE
move dst entries to a namespace loopback to catch refcounting leaks.
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
net/core/dst.c |4 ++--
net/ipv4/route.c|5 +++--
net/ipv4/xfrm4_policy.c |3 ++-
net/ipv6/route.c|7 +--
net/ipv6/xfrm6_policy.c
From: Stefan Rompf <[EMAIL PROTECTED]>
Date: Thu, 6 Dec 2007 12:35:05 +0100
> Because you just will put enough RAM modules into you server when
> setting up a scalable system.
This suggestion is avoiding the important semantic issue, and
won't lead to a real discussion of the core problem.
--
To
Am Donnerstag, 6. Dezember 2007 12:13 schrieb David Miller:
> And that's why this is a grey area. Why is waiting for memory
> allocation on a O_NONBLOCK socket OK but waiting for IPSEC route
> resolution is not?
Because you just will put enough RAM modules into you server when setting up a
scal
From: WANG Cong <[EMAIL PROTECTED]>
Date: Thu, 6 Dec 2007 19:01:23 +0800
>
> This patch contains the following changes.
>
> - Use 'bool' instead of 'int' for booleans.
> - Use 'size_t' instead of 'int' for 'sizeof' return value.
> - Some style fixes.
>
> Cc: Herbert Xu <[EMAIL
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 6 Dec 2007 22:06:01 +1100
> On Wed, Dec 05, 2007 at 09:39:33PM -0800, David Miller wrote:
> >
> > But we go back again to the question of how to get this "current
> > behavior" setting instantiated early enough. So much stuff happens
> > via initrd'
From: Stefan Rompf <[EMAIL PROTECTED]>
Date: Thu, 6 Dec 2007 11:56:48 +0100
> Am Donnerstag, 6. Dezember 2007 09:53 schrieb David Miller:
>
> > > I think the words "shall fail" and "immediately" are quite clear.
> >
> > They are, but the context in which they apply is vague.
>
> "socket is conne
On Wed, Dec 05, 2007 at 09:39:33PM -0800, David Miller wrote:
>
> But we go back again to the question of how to get this "current
> behavior" setting instantiated early enough. So much stuff happens
> via initrd's etc. before the real userland has a change to run things,
> read setting from the r
This patch contains the following changes.
- Use 'bool' instead of 'int' for booleans.
- Use 'size_t' instead of 'int' for 'sizeof' return value.
- Some style fixes.
Cc: Herbert Xu <[EMAIL PROTECTED]>
Cc: David Miller <[EMAIL PROTECTED]>
Signed-off-by: WANG Cong <[EMAIL P
Am Donnerstag, 6. Dezember 2007 09:53 schrieb David Miller:
> > I think the words "shall fail" and "immediately" are quite clear.
>
> They are, but the context in which they apply is vague.
"socket is connection-mode" => SOCK_STREAM
> I can equally generate examples where the non-blocking behavi
On Wed, Dec 05, 2007 at 09:03:43PM -0800, David Miller ([EMAIL PROTECTED])
wrote:
> I think this work is very different.
>
> When I say "state" I mean something more significant than
> CLOSE, ESTABLISHED, etc. which is what Samir's patches are
> tracking.
>
> I'm talking about all of the sequenc
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Thu, 6 Dec 2007 01:18:28 +0200 (EET)
> On Wed, 5 Dec 2007, David Miller wrote:
>
> > I assume you're using something like carefully crafted printk's,
> > kprobes, or even ad-hoc statistic counters. That's what I used to do
> > :-)
>
> No, that's n
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Wed, 5 Dec 2007 16:33:38 -0500
> On Wed, 05 Dec 2007 08:53:07 -0800
> Joe Perches <[EMAIL PROTECTED]> wrote:
>
> > > it occurred to me that we might want to do something
> > > like a state change event generator.
> >
> > This could be a basis for
From: "Denis V. Lunev" <[EMAIL PROTECTED]>
Date: Thu, 6 Dec 2007 13:17:43 +0300
> ip_rt_advice has been gone, so no need to keep prototype and debug message.
>
> Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
Applied to net-2.6, thanks.
--
To unsubscribe from this list: send the line "unsubsc
ip_rt_advice has been gone, so no need to keep prototype and debug message.
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
--
diff --git a/include/net/route.h b/include/net/route.h
index f7ce625..59b0b19 100644
--- a/include/net/route.h
+++ b/include/net/route.h
@@ -109,7 +109,6 @@ struct in_de
Jean Delvare <[EMAIL PROTECTED]> writes:
> On Mon, 26 Nov 2007 09:29:40 +0100, Wagner Ferenc wrote:
>
>> On the policy side: some files are not applicable to some types of
>> bonds, and return a single linefeed in that case. Except for one
>> single case, which returns 'NA\n'. The patch changes
(removing .kernel as it seems to concern netdev only)
On Thu, 06 Dec 2007 02:13:00 +0100, Francois Romieu wrote:
> Francois Romieu <[EMAIL PROTECTED]> :
>> Holger Hoffstaette <[EMAIL PROTECTED]> : [...]
>> > Should I file this in bugzilla?
>>
>> Yes.
>
> 5326 5585327 5585328 5585329 5585330 558
On Wed, 05 Dec 2007 23:54:29 +0100, Francois Romieu wrote:
> Holger Hoffstaette <[EMAIL PROTECTED]> : [...]
>> Should I file this in bugzilla?
>
> Yes.
Thanks for responding - will do. I verified with 2.6.24-rc4 (same bug) and
have some new information about this.
Despite my previous posting th
From: Stefan Rompf <[EMAIL PROTECTED]>
Date: Thu, 6 Dec 2007 09:49:01 +0100
> "If the connection cannot be established immediately and O_NONBLOCK is set
> for
> the file descriptor for the socket, connect() shall fail and set errno to
> [EINPROGRESS], but the connection request shall not be abo
Am Donnerstag, 6. Dezember 2007 03:25 schrieb David Miller:
> POSIX says nothing about the semantics of route resolution.
Of course not. Applications must not care about what happens at the transport
layer.
> Non-blocking doesn't mean "cannot sleep no matter what".
... and as O_CREAT on open()
On 06-12-2007 09:14, Mitsuru Chinen wrote:
> On Thu, 6 Dec 2007 08:49:47 +0100
> Jarek Poplawski <[EMAIL PROTECTED]> wrote:
>
>> On 06-12-2007 07:31, Mitsuru Chinen wrote:
>>> IPv4 stack doesn't reply any ICMP destination unreachable message
>>> with net unreachable code when IP detagrams are bein
On Thu, 6 Dec 2007 08:49:47 +0100
Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> On 06-12-2007 07:31, Mitsuru Chinen wrote:
> > IPv4 stack doesn't reply any ICMP destination unreachable message
> > with net unreachable code when IP detagrams are being discarded
> > because of no route could be found
Hello, Jarek,
I am sorry, but I think I am nor sure I underatand exactly what you mean when
you say:
"It overrides err codes from fib_lookup, where such decisions should be made."
What is incorrect here ?
There are two lines added in this patch;
IP_INC_STATS_BH(IPSTATS_MIB_INNOROUTES);
and err
96 matches
Mail list logo
