From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Sat, 5 Jan 2008 23:46:16 +0200
> This was missed when commit e2ac455a18806b31c2d0da0a51d8740af5010b7a
> fixed the compile errors in drivers/net/netx-eth.c caused by
> commit 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0.
>
> Signed-off-by: Adrian Bunk <[EMA
From: Amos Waterland <[EMAIL PROTECTED]>
Date: Sat, 5 Jan 2008 22:58:16 -0500
> ADDRESS ASSIGNED
>
> qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append "ip=on"
> qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append "ip=dhcp"
> qemu -kernel x86/arch/i386/boot/bzImage /dev/zero -append
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Sat, 5 Jan 2008 14:21:48 +0200 (EET)
> [PATCH] [NET]: Remove obsolete comment
>
> It seems that ip_build_xmit is no longer used in here and
> ip_append_data is used.
>
> Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
> ---
>
> Hi Dave,
>
> Whil
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Sun, 06 Jan 2008 11:29:35 +1100
> We should never use inline except when it's on the fast path and this
> is definitely not a fast path. If a function ends up being called
> just once the compiler will most likely inline it anyway, making the
> use of th
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Sun, 06 Jan 2008 11:22:04 +1100
> [IPV4] raw: Strengthen check on validity of iph->ihl
>
> We currently check that iph->ihl is bounded by the real length and that
> the real length is greater than the minimum IP header length. However,
> we did not che
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Sat, 5 Jan 2008 15:39:08 +0200
> From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
>
> Without a number of CONFIG.*DEBUG:
>
> net/dccp/ccids/ccid3.c:
> ccid3_hc_tx_update_x | -170
> ccid3_hc_tx_packet_sent | -175
> cc
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Sat, 5 Jan 2008 15:39:07 +0200
> From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
>
> net/xfrm/xfrm_state.c:
> xfrm_audit_state_delete | -589
> xfrm_replay_check| -542
> xfrm_audit_state_icvfail | -5
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Sat, 5 Jan 2008 15:39:06 +0200
> net/ipv4/ipvs/ip_vs_xmit.c:
> ip_vs_icmp_xmit | -638
> ip_vs_tunnel_xmit | -674
> ip_vs_nat_xmit| -716
> ip_vs_dr_xmit | -682
> 4 functions changed, 2710 bytes removed, diff: -2710
>
> net/ipv4/ip
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Sat, 5 Jan 2008 15:39:05 +0200
> 10 functions changed, 11017 bytes removed, diff: -11017
...
> 6 functions changed, 2122 bytes added, diff: +2122
Yikes, applied :-)
Thanks Ilpo.
--
To unsubscribe from this list: send the line "unsubscribe netde
From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Sun, 06 Jan 2008 00:16:04 +0100
> [NETNS]: Should build with CONFIG_SYSCTL=n
>
> Previous NETNS patches broke CONFIG_SYSCTL=n case
>
> Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]>
Applied, thanks Eric.
--
To unsubscribe from this list: send the li
From: Andi Kleen <[EMAIL PROTECTED]>
Date: Sat, 05 Jan 2008 14:29:05 +0100
> In 2.4 we used to have (haven't checked recently) performance regressions
> with NAPI vs non NAPI (or versus the old BCM vendor driver) on tg3 for
> some workloads that didn't fully fill the link. The theory was always
>
On Sun, Jan 06, 2008 at 02:02:14AM +, Al Viro wrote:
>
> E.g. what about ipt_REJECT.c::send_reset()? Or myri10ge_get_frag_header()?
Yes both look wrong.
Patrick, please have a look at the former. In fact it's not just
that ihl may be bogus (which might be harmless as long as the REJECT
hoo
The recent changes for ip command line processing fixed some problems
but unfortunately broke some common usage scenarios. In current
2.6.24-rc6 the following command line results in no IP address
assignment, which is surely a regression:
ip=10.0.2.15::10.0.2.2:255.255.255.0::eth0:off
Please fi
On Sat, Jan 05, 2008 at 07:31:29PM -0800, Arjan van de Ven wrote:
> Andi Kleen wrote:
> >Arjan van de Ven <[EMAIL PROTECTED]> writes:
> >>Rank 4: remove_proc_entry
> >>Was also ranked 4th last week
> >>Only in tainted oopses
> >>Reported 3 times (12 total reports)
> >>More info:
>
On Sat, 5 Jan 2008 17:25:24 -0800
Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Sat, 5 Jan 2008 23:10:17 +0100 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote:
>
> > On Jan 5, 2008 3:52 PM, Torsten Kaiser <[EMAIL PROTECTED]> wrote:
> > > On Jan 5, 2008 11:13 AM, Jarek Poplawski <[EMAIL PROTECTED]> wro
Andi Kleen wrote:
Arjan van de Ven <[EMAIL PROTECTED]> writes:
Rank 4: remove_proc_entry
Was also ranked 4th last week
Only in tainted oopses
Reported 3 times (12 total reports)
More info: http://www.kerneloops.org/search.php?search=remove_proc_entry
Likely a br
Arjan van de Ven <[EMAIL PROTECTED]> writes:
>
> Rank 4: remove_proc_entry
> Was also ranked 4th last week
> Only in tainted oopses
> Reported 3 times (12 total reports)
> More info: http://www.kerneloops.org/search.php?search=remove_proc_entry
Likely a broken module_exit()
On Saturday 05 January 2008 7:29:35 pm Herbert Xu wrote:
> Ilpo J??rvinen <[EMAIL PROTECTED]> wrote:
> > Signed-off-by: Ilpo J??rvinen <[EMAIL PROTECTED]>
>
> Acked-by: Herbert Xu <[EMAIL PROTECTED]>
>
> > #ifdef CONFIG_AUDITSYSCALL
> > -static inline void xfrm_audit_helper_sainfo(struct xfrm_state
On Jan 5, 2008 11:10 PM, Torsten Kaiser <[EMAIL PROTECTED]> wrote:
> 2.6.24-rc6 + mm-patches up to git.battery (includes git-net and
> git-netdev-all) worked for 110 packages, then I proclaimed it good.
> 2.6.24-rc6 + mm-patches up to (including) git.nfsd is currently
> getting testet (9 packages d
On Sun, Jan 06, 2008 at 11:22:04AM +1100, Herbert Xu wrote:
> Actually if you read the code for ip_fast_csum it's obvious what has
> happened. %o1 == iph->ihl contains the value 2 which is bogus.
>
> [IPV4] raw: Strengthen check on validity of iph->ihl
>
> We currently check that iph->ihl is bo
On Sun, 06 Jan 2008 08:54:28 +1100
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
>
> On Sat, 2008-01-05 at 15:48 -0600, Josh Boyer wrote:
> > No need for a defconfig update patch. Paul or I usually do a general
> > defconfig update for most boards before the next kernel version. This
> > wi
On Sat, 5 Jan 2008 23:10:17 +0100 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote:
> On Jan 5, 2008 3:52 PM, Torsten Kaiser <[EMAIL PROTECTED]> wrote:
> > On Jan 5, 2008 11:13 AM, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> > > On Sat, Jan 05, 2008 at 09:01:02AM +0100, Torsten Kaiser wrote:
> > > > On
On Sun, Jan 06, 2008 at 01:57:13AM +0100, Jan Engelhardt wrote:
>
> >@@ -304,7 +305,8 @@ static int raw_send_hdrinc(struct sock *sk, void *from,
> >size_t length,
> > goto error_fault;
> >
> > /* We don't modify invalid header */
> >-if (length >= sizeof(*iph) && iph->ihl * 4U
On Jan 6 2008 11:22, Herbert Xu wrote:
>@@ -271,6 +271,7 @@ static int raw_send_hdrinc(struct sock *sk, void *from,
>size_t length,
> int hh_len;
> struct iphdr *iph;
> struct sk_buff *skb;
>+ unsigned int iphlen;
> int err;
>
> if (length > rt->u.dst.dev->mtu)
Ilpo J??rvinen <[EMAIL PROTECTED]> wrote:
>
> Signed-off-by: Ilpo J??rvinen <[EMAIL PROTECTED]>
Acked-by: Herbert Xu <[EMAIL PROTECTED]>
> #ifdef CONFIG_AUDITSYSCALL
> -static inline void xfrm_audit_helper_sainfo(struct xfrm_state *x,
> - struct audit_buf
Al Viro <[EMAIL PROTECTED]> wrote:
>
> ip_fast_csum() called from raw_send_hdrinc() from raw_sendmsg() ran through
> the page boundary into unmapped page... Bloody odd, that, seeing that
> we have checked iph->ihl * 4U <= length and had done
>err = memcpy_fromiovecend((void *)iph, from, 0
Christoph,
> On Fri, Jan 04, 2008 at 11:02:53AM +0100, Manfred Schwarb wrote:
> > meanwhile the Agere et1310 chip has grown to a quite popular network
> > chip, in laptops as well as for PCI-E cards. The release date of this
> chip was
> > already in June 2004, and still no support in mainline lin
> The driver that is available is NOT open souce. It was released under the
> BSD license.
> I tried getting Agere to release under the GPL, but the main dev there
> (Victor) said that it wasn't happening and that we'd have to use it the
> way
> it is.
>
As far as I know (IANAL), a BSD Licence
Hi David
Current net-2.6.25 doesnt build if CONFIG_SYSCTL=n
(Was posted last wednesday, you missed it or I missed your reply :) )
Thank you
[NETNS]: Should build with CONFIG_SYSCTL=n
Previous NETNS patches broke CONFIG_SYSCTL=n case
Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]>
include/n
meth didn't set a valid mac address during probing, but later during
open. Newer kernel refuse to open device with 00:00:00:00:00:00 as
mac address -> dead ethernet. This patch sets the mac address in
the probe function and uses only the mac address from the netdevice
struct when setting up the har
On Jan 5, 2008 3:52 PM, Torsten Kaiser <[EMAIL PROTECTED]> wrote:
> On Jan 5, 2008 11:13 AM, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> > On Sat, Jan 05, 2008 at 09:01:02AM +0100, Torsten Kaiser wrote:
> > > On Jan 5, 2008 1:07 AM, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> > > > I think it wou
On Sat, 2008-01-05 at 15:48 -0600, Josh Boyer wrote:
> No need for a defconfig update patch. Paul or I usually do a general
> defconfig update for most boards before the next kernel version. This
> will get picked up then.
Will it ? I think the defconfigs will stick to the old value.
Ben.
--
On Sun, 06 Jan 2008 07:53:06 +1100
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
>
> On Sat, 2008-01-05 at 13:38 +0100, Stefan Roese wrote:
> > On Saturday 05 January 2008, Benjamin Herrenschmidt wrote:
> > > On Sat, 2008-01-05 at 10:50 +0100, Stefan Roese wrote:
> > > > Performance tests don
This was missed when commit e2ac455a18806b31c2d0da0a51d8740af5010b7a
fixed the compile errors in drivers/net/netx-eth.c caused by
commit 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
15e5efb728c61333ca10648334185efba86c4815
diff --git a/drivers/net
On Sat, Jan 05, 2008 at 01:06:17PM -0800, Arjan van de Ven wrote:
> The http://www.kerneloops.org website collects kernel oops and
> warning reports from various mailing lists and bugzillas as well as
> with a client users can install to auto-submit oopses.
> Below is a top 10 list of the oopses co
On Sat, Jan 05, 2008 at 01:06:17PM -0800, Arjan van de Ven wrote:
> Rank 3: d_splice_alias
> NULL pointer deref
> Reported 3 times
> Happens in the isofs code
> Only seen in 2.6.24-rc5-mm1
> More info: http://www.kerneloops.org/search.php?search=d_splice_alias
in -rc6
The http://www.kerneloops.org website collects kernel oops and
warning reports from various mailing lists and bugzillas as well as
with a client users can install to auto-submit oopses.
Below is a top 10 list of the oopses collected in the last 7 days.
(Reports prior to 2.6.23 have been omitted in
On Sat, 2008-01-05 at 13:38 +0100, Stefan Roese wrote:
> On Saturday 05 January 2008, Benjamin Herrenschmidt wrote:
> > On Sat, 2008-01-05 at 10:50 +0100, Stefan Roese wrote:
> > > Performance tests done by AMCC have shown that 256 buffer increase the
> > > performance of the Linux EMAC driver. So
Em Sat, Jan 05, 2008 at 03:39:04PM +0200, Ilpo Järvinen escreveu:
> Hi Dave,
>
> After Arnaldo got codiff's inline instrumentation bugs fixed
> (thanks! :-)), I got my .c-inline-bloat-o-meter to power up
> reliably after some tweaking and bug fixing on my behalf...
> It shows some very high readin
Em Sat, Jan 05, 2008 at 03:39:08PM +0200, Ilpo Järvinen escreveu:
> From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
>
> Without a number of CONFIG.*DEBUG:
>
> net/dccp/ccids/ccid3.c:
> ccid3_hc_tx_update_x | -170
> ccid3_hc_tx_packet_sent | -175
> ccid3_hc_tx_packe
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
Without a number of CONFIG.*DEBUG:
net/dccp/ccids/ccid3.c:
ccid3_hc_tx_update_x | -170
ccid3_hc_tx_packet_sent | -175
ccid3_hc_tx_packet_recv | -169
ccid3_hc_tx_no_feedback_timer | -192
ccid3_hc_tx_send_pack
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
/me awards the bloatiest-of-all-net/-.c-code award to
nf_conntrack_netlink.c, congratulations to all the authors :-/!
Hall of (unquestionable) fame (measured per inline, top 10 under
net/):
-4496 ctnetlink_parse_tuplenetfilter/n
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
net/xfrm/xfrm_state.c:
xfrm_audit_state_delete | -589
xfrm_replay_check| -542
xfrm_audit_state_icvfail | -520
xfrm_audit_state_add | -589
xfrm_audit_state_replay_overflow | -523
xfrm
Hi Dave,
After Arnaldo got codiff's inline instrumentation bugs fixed
(thanks! :-)), I got my .c-inline-bloat-o-meter to power up
reliably after some tweaking and bug fixing on my behalf...
It shows some very high readings every now and then in the
code under net/.
...Aand... we've a sovereign wi
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
net/ipv4/ipvs/ip_vs_xmit.c:
ip_vs_icmp_xmit | -638
ip_vs_tunnel_xmit | -674
ip_vs_nat_xmit| -716
ip_vs_dr_xmit | -682
4 functions changed, 2710 bytes removed, diff: -2710
net/ipv4/ipvs/ip_vs_xmit.c:
__ip_vs_get_out_rt
David Miller <[EMAIL PROTECTED]> writes:
> From: James Chapman <[EMAIL PROTECTED]>
> Date: Sat, 05 Jan 2008 00:18:31 +
>
>> David Miller wrote:
>> > From: James Chapman <[EMAIL PROTECTED]>
>> > Date: Fri, 04 Jan 2008 20:10:30 +
>> >
>> >> With the latest NAPI, this code has to change. But
On Saturday 05 January 2008, Benjamin Herrenschmidt wrote:
> On Sat, 2008-01-05 at 10:50 +0100, Stefan Roese wrote:
> > Performance tests done by AMCC have shown that 256 buffer increase the
> > performance of the Linux EMAC driver. So let's update the default
> > values to match this setup.
> >
>
[PATCH] [NET]: Remove obsolete comment
It seems that ip_build_xmit is no longer used in here and
ip_append_data is used.
Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
---
Hi Dave,
While reading some nearby code, I noticed this. I'm not 100%
sure if the removal is valid or not nor have intere
On Sat, 2008-01-05 at 10:50 +0100, Stefan Roese wrote:
> Performance tests done by AMCC have shown that 256 buffer increase the
> performance of the Linux EMAC driver. So let's update the default
> values to match this setup.
>
> Signed-off-by: Stefan Roese <[EMAIL PROTECTED]>
> ---
Do we have t
On Sat, Jan 05, 2008 at 09:01:02AM +0100, Torsten Kaiser wrote:
> On Jan 5, 2008 1:07 AM, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> > On Fri, Jan 04, 2008 at 04:21:26PM +0100, Torsten Kaiser wrote:
> > > On Jan 4, 2008 2:30 PM, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> > > The only thing that
Performance tests done by AMCC have shown that 256 buffer increase the
performance of the Linux EMAC driver. So let's update the default
values to match this setup.
Signed-off-by: Stefan Roese <[EMAIL PROTECTED]>
---
drivers/net/ibm_newemac/Kconfig |4 ++--
1 files changed, 2 insertions(+), 2
On Fri, Jan 04, 2008 at 06:37:36PM +0100, Mariusz Kozlowski wrote:
> Hello,
>
> This comes from the Linus latest linux-2.6 tree. Randomly happened.
> Can't reproduce that. More info below.
ip_fast_csum() called from raw_send_hdrinc() from raw_sendmsg() ran through
the page boundary into u
On Fri, Jan 04, 2008 at 11:02:53AM +0100, Manfred Schwarb wrote:
> meanwhile the Agere et1310 chip has grown to a quite popular network
> chip, in laptops as well as for PCI-E cards. The release date of this chip was
> already in June 2004, and still no support in mainline linux.
>
> There is appa
Hi,
In neigh_timer_handler( ), (core/neighbour.c), there is a comment which says:
# It is very thin place. report_unreachable is very complicated
# routine. Particularly, it can hit the same neighbour entry!
# So that, we try to be accurate and avoid dead loop. --ANK
I tried to figure exactly
On Jan 5, 2008 1:07 AM, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> On Fri, Jan 04, 2008 at 04:21:26PM +0100, Torsten Kaiser wrote:
> > On Jan 4, 2008 2:30 PM, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> > The only thing that is sadly not practical is bisecting the borkenout
> > mm-patches, as tr
55 matches
Mail list logo
