Re: [PATCH 12/14 v2] [rndis_host] Add RNDIS physical medium checking into generic_rndis_bind()

2008-01-27 Thread David Brownell
On Sunday 27 January 2008, Jussi Kivilinna wrote: > Add RNDIS physical medium checking into generic_rndis_bind() and also make > rndis_host to be only bind on every medium except wireless. > > Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> Acked-by: David Brownell <[EMAIL PROTECTED]> I think

[PATCH][INET_DIAG]: Fix inet_diag_lock_handler error path

2008-01-27 Thread Arnaldo Carvalho de Melo
Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=9825 The inet_diag_lock_handler function uses ERR_PTR to encode errors but its callers were testing against NULL. This only happens when the only inet_diag modular user, DCCP, is not built into the kernel or available as a module. Also there was

Re: [PATCH] TCP:Fix a bug in strategy_allowed_congestion_control

2008-01-27 Thread shanwei
Stephen Hemminger 写道: > On Fri, 25 Jan 2008 15:10:13 +0800 > shanwei <[EMAIL PROTECTED]> wrote: > >> hi all: >> >> In strategy_allowed_congestion_control of the 2.6.24 kernel, >> when sysctl_string return 1 on success,it should call >> tcp_set_allowed_congestion_control to set the allowed conges

[PATCH] Implement skb_partial_csum_set

2008-01-27 Thread Rusty Russell
Implement skb_partial_csum_set, for setting partial csums on untrusted packets. Use it in virtio_net (replacing buggy version there), it's also going to be used by TAP for partial csum support. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Acked-by: David S. Miller <[EMAIL PROTECTED]> --- dri

[PATCH] SCTP: Fix miss of report unrecognized HMAC Algorithm parameter

2008-01-27 Thread Wei Yongjun
This patch fix miss of check for report unrecognized HMAC Algorithm parameter. When AUTH is disabled, goto fall through path to report unrecognized parameter, else, just break. Wei Neil Horman wrote: On Wed, Jan 23, 2008 at 09:30:27AM +0900, Wei Yongjun wrote: This patch fix miss of check for

Re: [PATCHv2 2.6.24] fib: fix route replacement, fib_info is shared

2008-01-27 Thread Jarek Poplawski
Hi, I have a few questions below: Julian Anastasov wrote, On 01/26/2008 01:41 PM: > fib_info can be shared by many route prefixes but we don't > want duplicate alternative routes for a prefix+tos+priority. Last > change was not correct to check fib_treeref because it accounts usage > from

[PATCH 12/14 v2] [rndis_host] Add RNDIS physical medium checking into generic_rndis_bind()

2008-01-27 Thread Jussi Kivilinna
Add RNDIS physical medium checking into generic_rndis_bind() and also make rndis_host to be only bind on every medium except wireless. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 36 +--- drivers/net/usb/rndis_host.h |

Re: [PATCH 12/14] [rndis_host] Add RNDIS physical medium checking into generic_rndis_bind()

2008-01-27 Thread David Brownell
On Sunday 27 January 2008, Jussi Kivilinna wrote: > > I'm not very familiar with posting patches (as some might have noticed) > so I have some questions.. if you don't mind. Now that you have acked > most of the patches, is it ok for me to add your 'Acked-by' to those > patches? On those patches

Re: [PATCH 10/14] [rndis_host] Add early_init function pointer to 'struct rndis_data'.

2008-01-27 Thread Jussi Kivilinna
On Sun, 2008-01-27 at 08:14 -0800, David Brownell wrote: > On Friday 25 January 2008, Jussi Kivilinna wrote: > > Function pointer is for 'subminidrivers' that need to do work on device > > right after minidriver has initialized hardware. > > > > For example, rndis_wlan setting device specific con

Re: [PATCH 12/14] [rndis_host] Add RNDIS physical medium checking into generic_rndis_bind()

2008-01-27 Thread Jussi Kivilinna
On Sun, 2008-01-27 at 08:29 -0800, David Brownell wrote: > Well, other than the obvious checkpatch.pl warnings waiting to trigger > ("if" is not a function; put a space before the paren) and what I'd call > missing parens around the "flags & ...", those are *not* errors. No > wonder you thought th

Re: [PATCH 13/14] Move usbnet.h and rndis_host.h to include/linux/usb

2008-01-27 Thread David Brownell
On Friday 25 January 2008, Jussi Kivilinna wrote: > Move headers usbnet.h and rndis_host.h to include/linux/usb and fix includes > for drivers/net/usb modules. Headers are moved because rndis_wlan will be > outside drivers/net/usb in drivers/net/wireless and yet need these headers. > > Signed-off-

Re: [PATCH 11/14] [rndis_host] Add link_change function pointer to 'struct rndis_data'.

2008-01-27 Thread David Brownell
On Friday 25 January 2008, Jussi Kivilinna wrote: > Callback to signal link state changes from minidriver to > 'subminidrivers'. > > Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> Acked-by: David Brownell <[EMAIL PROTECTED]> > --- > > drivers/net/usb/rndis_host.c | 24 +

Re: [PATCH 12/14] [rndis_host] Add RNDIS physical medium checking into generic_rndis_bind()

2008-01-27 Thread David Brownell
On Friday 25 January 2008, Jussi Kivilinna wrote: > +   if(flags & FLAG_RNDIS_PHYM_WIRELESS && > +   *phym != RNDIS_PHYSICAL_MEDIUM_WIRELESS_LAN) { > +   dev_err(&intf->dev, "driver requires wireless physical " > +   "medium, b

Re: [PATCH 10/14] [rndis_host] Add early_init function pointer to 'struct rndis_data'.

2008-01-27 Thread David Brownell
On Friday 25 January 2008, Jussi Kivilinna wrote: > Function pointer is for 'subminidrivers' that need to do work on device > right after minidriver has initialized hardware. > > For example, rndis_wlan setting device specific configuration parameters > with OID_GEN_RNDIS_CONFIG_PARAMETER right a

[PATCH] natsemi: Update locking documentation

2008-01-27 Thread Mark Brown
The documentation regarding synchronisation at the head of the natsemi driver was badly bitrotted so replace it with a general statement about the techniques used which is less likely to bitrot. Also remove the note saying these chips are uncommon - it makes little difference but they were used in

Re: [Bugme-new] [Bug 9816] New: cannot replace route

2008-01-27 Thread Jarek Poplawski
On Sun, Jan 27, 2008 at 11:49:06AM +0200, Julian Anastasov wrote: ... > No, simply the last change in 2.6.24 is wrong to assume > duplication is evident in fib_info reference counter. And such check > is only on ip route replace/change. I'm appending brief FIB information > for your referenc

Re: [Bugme-new] [Bug 9816] New: cannot replace route

2008-01-27 Thread Julian Anastasov
Hello, On Sun, 27 Jan 2008, Jarek Poplawski wrote: > But comment#3 is "ambiguous"... It looks like you don't want to show > us too much... So, apparently you change the route, but it seems this > route exists; you have this: > 10.0.0.0/8 dev eth0 scope link > but probably also someth