[PATCH][INET]: Fix accidentally broken inet(6)_hash_connect's port offset calculations.

2008-02-04 Thread Pavel Emelyanov
The port offset calculations depend on the protocol family, but, as Adrian noticed, I broke this logic with the commit 5ee31fc1ecdcbc234c8c56dcacef87c8e09909d8 [INET]: Consolidate inet(6)_hash_connect. Return this logic back, by passing the port offset directly into the

Re: LRO ip_summed

2008-02-04 Thread Jan-Bernd Themann
On Sunday 03 February 2008 10:48, Kostya B wrote: Hi, The mail is related to the way LRO manipulates the ip_summed value. Could anybody (author) explain why to overwrite the original value of skb-ip_summed, when it's processing by __lro_proc_skb ? E.g. in out: label Why not to

Re: oops with ipcomp

2008-02-04 Thread Beschorner Daniel
Unable to handle kernel paging request at c20fb000 RIP: [8031b8f0] deflate_slow+0x40/0x400 I'm not able to get much information out of this crash dump. Nor can I reproduce this bug on my 32-bit machines and I'm currently away from my 64-bit machines. How long have you

include/linux/pcounter.h

2008-02-04 Thread Andrew Morton
e7d0362dd41e760f340c1b500646cc92522bd9d5 should have been folded into de4d1db369785c29d68915edfee0cb70e8199f4c prior to merging. We now and for ever have a window of breakage which screws up git bisection. Which I just hit. Which is the only reason I discovered the file's existence. Please

oops with ipcomp

2008-02-04 Thread Beschorner Daniel
Nope! Right now it happened again, something must have changed with 2.6.24. Unable to handle kernel paging request at c20fb000 RIP: [8031b8f0] deflate_slow+0x40/0x400 PGD 7f845067 PUD 7f846067 PMD 7f847067 PTE 0 Oops: [1] SMP CPU 0 Modules linked in: Pid: 11055, comm: httpd

Re: locking api self-test hanging

2008-02-04 Thread Andrew Morton
On Mon, 4 Feb 2008 04:43:04 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Sun, 3 Feb 2008 15:07:44 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Sun, 3 Feb 2008 15:02:46 -0800 Andrew Morton [EMAIL PROTECTED] wrote: With current mainline I'm getting intermittent hangs here:

Re: locking api self-test hanging

2008-02-04 Thread Peter Zijlstra
On Mon, 2008-02-04 at 05:04 -0800, Andrew Morton wrote: After disabling both CONFIG_DEBUG_LOCKING_API_SELFTESTS and netconsole (using current mainline) I get a login prompt, and also... [7.819146] WARNING: at kernel/lockdep.c:2033 trace_hardirqs_on+0x9b/0x10d() That warning in

[PATCH 2/2] ehea: add memory remove hotplug support

2008-02-04 Thread Jan-Bernd Themann
Add memory remove hotplug support Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- Comment: This patch depends on the following patch that exports the symbols register_memory_notifier() unregister_memory_notifier() http://lkml.org/lkml/2008/2/1/293 drivers/net/ehea/ehea_main.c |

No IPv6 addresses after resume (No buffer space available)

2008-02-04 Thread Adrian Knoth
Hi! I use suspend-to-RAM on my HP nx6325 laptop. I have three main locations: - place A: IPv4 + IPv6 - place B: IPv4 + IPv6 - place C: IPv4 only Suspending in place A and travelling to place B is no problem, I'm always getting the local RAs, the right addresses a.s.o. But once I've

Re: Slow OOM in netif_RX function

2008-02-04 Thread Ivan Dichev
Hi, Thanks again for your help... Here's more debug info (long email !): We installed crash, compiled a kernel with debug symbols, dumped all the allocated size-2048 slabs, waited some time, and re-dumped them. Then we compared both dumps: we assumed that slab dumps which were not modified

Re: [PATCH 2/2] ehea: add memory remove hotplug support

2008-02-04 Thread Michael Ellerman
On Mon, 2008-02-04 at 14:04 +0100, Jan-Bernd Themann wrote: Add memory remove hotplug support Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- Comment: This patch depends on the following patch that exports the symbols register_memory_notifier() unregister_memory_notifier()

Re: What were the reasons of having mandatory IP address at AX.25 interfaces ?

2008-02-04 Thread Andi Kleen
Matti Aarnio [EMAIL PROTECTED] writes: .. the original reason was apparently that _ifconfig_ blew up when it saw protocols that it didn't understand on network interfaces. Possibly when there was no IP protocol on an interface. It's not only ifconfig, a lot of programs use SIOCGIFCONF to

Re: Slow OOM in netif_RX function

2008-02-04 Thread Andi Kleen
Nothing that looks like a struct net_device. All the dumped leaked slab look the same until 45 20 05 d8 (the ascii 'E' on the 3rd line). 45 ... is often the start of an IP header (IPv4, 5*4=20 bytes length) You could dump them to a file (e.g. using a sial script) and then look at them with

Re: [PATCH 2/2] ehea: add memory remove hotplug support

2008-02-04 Thread Jan-Bernd Themann
On Monday 04 February 2008 15:46, Michael Ellerman wrote: On Mon, 2008-02-04 at 14:04 +0100, Jan-Bernd Themann wrote: Add memory remove hotplug support @@ -3559,6 +3578,10 @@ int __init ehea_module_init(void) if (ret) ehea_info(failed registering reboot notifier); +

Re: SCTP NAT module for netfilter

2008-02-04 Thread Vlad Yasevich
Sohan Shetty wrote: Is anyone aware if there an NAT module for netfilter being developed for SCTP protocol ? I don't believe there is one yet. You are always welcome to write it. I have searched the netfilter development tree source code and also mailing list and so far I have not

Re: [PATCH] 2.6.24-mm1 section type conflict cleanup

2008-02-04 Thread Kamalesh Babulal
Hi Andrew, The 2.6.24-mm1 kernel build fails at many places with section type conflict build error. drivers/net/typhoon.c:181: error: typhoon_card_info causes a section type conflict make[2]: *** [drivers/net/typhoon.o] Error 1 drivers/net/natsemi.c:245: error: natsemi_pci_info causes a

Re: [NET_SCHED 00/04]: External SFQ classifiers/flow classifier

2008-02-04 Thread Patrick McHardy
Corey Hickey wrote: Patrick McHardy wrote: These patches add support for external classifiers to SFQ and add a new flow classifier, which can do hashing based on user-specified keys or deterministic mapping of keys to classes. Additionally there is a patch to make the SFQ queues visisble as

Re: why does DCCP SO_REUSEADDR have to be SOL_DCCP?

2008-02-04 Thread Rick Jones
Arnaldo Carvalho de Melo wrote: Em Fri, Feb 01, 2008 at 05:42:23PM -0800, Rick Jones escreveu: Hi - I'm tweaking the netperf omni tests to be able to run over DCCP. I've run across a not-unorecedented problem with getaddrinfo() not groking either SOCK_DCCP or IPPROTO_DCCP in the hints, and

[Wireless, ath5k] 2.6.24-git13 9135f1901ee6449dfe338adf6e40e9c2025b8150

2008-02-04 Thread Oliver Pinter (Pintér Olivér)
git top: 9135f1901ee6449dfe338adf6e40e9c2025b8150 [ 399.582185] wpa_supplicant[4383]: segfault at 30 ip 080697ca sp bf87a690 error 4 in wpa_supplicant[8048000+4c000] [ 406.277199] wpa_supplicant[4384]: segfault at 30 ip 080697ca sp bfc13a30 error 4 in wpa_supplicant[8048000+4c000] [

[PATCH 1/2] ehea: kdump support

2008-02-04 Thread Jan-Bernd Themann
This patch adds kdump support to the ehea driver. As the firmware doesn't free resource handles automatically, the driver has to run an as simple as possible free resource function in case of a crash shutdown. The function iterates over two arrays freeing all resource handles which are stored

Re: locking api self-test hanging

2008-02-04 Thread Andrew Morton
On Sun, 3 Feb 2008 15:07:44 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Sun, 3 Feb 2008 15:02:46 -0800 Andrew Morton [EMAIL PROTECTED] wrote: With current mainline I'm getting intermittent hangs here: http://userweb.kernel.org/~akpm/p2033590.jpg with this config:

Re: [PATCH][NET_SCHED] sch_tree_lock in cbq_put, hfsc_put_class and htb_put

2008-02-04 Thread Jarek Poplawski
This patch is wrong - don't apply, please! Sorry, Jarek P. On 03-02-2008 15:52, Jarek Poplawski wrote: [NET_SCHED] sch_tree_lock in cbq_put, hfsc_put_class and htb_put Qdisc_class_ops -put() methods call xxx_destroy_class() functions without sch_tree_lock(), which is needed at least for

Re: [NET_SCHED 00/04]: External SFQ classifiers/flow classifier

2008-02-04 Thread Corey Hickey
Patrick McHardy wrote: You're missing protocol, handle etc. Try something like this: tc filter add dev eth0 protocol ip pref 1 parent 1: handle 1 \ flow hash keys dst divisor 1024 Thanks, the kernel accepts that. I guess I understand tc filter usage less than I thought I did

Re: [PATCH 4/5] ehea: fix phyp checkpatch complaints

2008-02-04 Thread Scott Wood
Doug Maxey wrote: On Fri, 01 Feb 2008 13:23:45 CST, Scott Wood wrote: On Thu, Jan 31, 2008 at 08:20:50PM -0600, Doug Maxey wrote: /* input param R5 */ -#define H_ALL_RES_QP_EQPO EHEA_BMASK_IBM(9, 11) ... +#define H_ALL_RES_QP_EQPOEHEA_BMASK_IBM(9, 11) ... This was better

[PATCH 0/2] ehea: kdump memory remove support

2008-02-04 Thread Jan-Bernd Themann
This patch set adds support for kdump and hotplug memory remove to the eHEA driver. The memory remove patch depends on the following patch that has been posted a few days ago. That patch exports the symbols  - register_memory_notifier()  - unregister_memory_notifier()

Re: What were the reasons of having mandatory IP address at AX.25 interfaces ?

2008-02-04 Thread Matti Aarnio
.. the original reason was apparently that _ifconfig_ blew up when it saw protocols that it didn't understand on network interfaces. Possibly when there was no IP protocol on an interface. This happened on DECNET, and apparently on others too. Thus the SIOCGIFCONF ioctl is not returning much

Re: What were the reasons of having mandatory IP address at AX.25 interfaces ?

2008-02-04 Thread Matti Aarnio
On Mon, Feb 04, 2008 at 03:38:35PM +0100, Andi Kleen wrote: Matti Aarnio [EMAIL PROTECTED] writes: .. the original reason was apparently that _ifconfig_ blew up when it saw protocols that it didn't understand on network interfaces. Possibly when there was no IP protocol on an

[PATCH][RFC] race in generic address resolution

2008-02-04 Thread Blaschka
I'm running a SMP maschine (2 CPUs) configured as a router. During heavy traffic kernel dies with following message: 2kernel BUG at /home/autobuild/BUILD/linux-2.6.23-20080125/net/core/skbuff.c:648! 4illegal operation: 0001 [#1] PREEMPT SMP 4Modules linked in: dm_multipath sunrpc

[PATCH 2.6.24-mm1] error compiling net driver NE2000/NE1000

2008-02-04 Thread Pierre Peiffer
Hi, When I compile the kernel 2.6.24-mm1 with: CONFIG_NET_ISA=y CONFIG_NE2000=y I have the following compile error: ... GEN .version CHK include/linux/compile.h UPD include/linux/compile.h CC init/version.o LD init/built-in.o LD .tmp_vmlinux1

[PATCH] xircom_cb should return NETDEV_TX_BUSY when there are no descriptors available

2008-02-04 Thread Erik Mouw
Hi, Changes in other networking paths uncovered a bug in the xircom_cb driver which made the kernel spew lots of the following error messages: BUG eth1 code -5 qlen 0 It turned out that the driver returned -EIO when there was no descriptor available for sending packets. It should return

Re: [PATCH] 2.6.24-mm1 section type conflict cleanup

2008-02-04 Thread Sam Ravnborg
On Mon, Feb 04, 2008 at 09:52:23PM +0530, Kamalesh Babulal wrote: Hi Andrew, The 2.6.24-mm1 kernel build fails at many places with section type conflict build error. What arch? We have troubles with powerpc as pointed out by Al in another thread. Sam -- To unsubscribe from this

Re: [PATCH] xircom_cb should return NETDEV_TX_BUSY when there are no descriptors available

2008-02-04 Thread Erik Mouw
On Mon, Feb 04, 2008 at 06:56:54PM +0100, Erik Mouw wrote: Changes in other networking paths uncovered a bug in the xircom_cb driver which made the kernel spew lots of the following error messages: BUG eth1 code -5 qlen 0 It turned out that the driver returned -EIO when there was no

Re: [Wireless, ath5k] 2.6.24-git13 9135f1901ee6449dfe338adf6e40e9c2025b8150

2008-02-04 Thread Dan Williams
On Mon, 2008-02-04 at 22:34 +0100, Oliver Pinter wrote: On 2/4/08, Jiri Slaby [EMAIL PROTECTED] wrote: On 02/04/2008 03:00 PM, Oliver Pinter (Pintér Olivér) wrote: git top: 9135f1901ee6449dfe338adf6e40e9c2025b8150 [ 399.582185] wpa_supplicant[4383]: segfault at 30 ip 080697ca sp

Re: [PATCH 2.6.24-mm1] error compiling net driver NE2000/NE1000

2008-02-04 Thread Andrew Morton
On Mon, 4 Feb 2008 16:29:21 +0100 Pierre Peiffer [EMAIL PROTECTED] wrote: Hi, When I compile the kernel 2.6.24-mm1 with: CONFIG_NET_ISA=y CONFIG_NE2000=y I have the following compile error: ... GEN .version CHK include/linux/compile.h UPD

Re: [Wireless, ath5k] 2.6.24-git13 9135f1901ee6449dfe338adf6e40e9c2025b8150

2008-02-04 Thread Jiri Slaby
On 02/04/2008 03:00 PM, Oliver Pinter (Pintér Olivér) wrote: git top: 9135f1901ee6449dfe338adf6e40e9c2025b8150 [ 399.582185] wpa_supplicant[4383]: segfault at 30 ip 080697ca sp bf87a690 error 4 in wpa_supplicant[8048000+4c000] [ 406.277199] wpa_supplicant[4384]: segfault at 30 ip 080697ca sp

Re: [PATCH 00/24 for-2.6.25] DM9000 updates for 2.6.25

2008-02-04 Thread Andrew Morton
On Tue, 05 Feb 2008 00:01:59 + Ben Dooks [EMAIL PROTECTED] wrote: Subject: [PATCH 00/24 for-2.6.25] DM9000 updates for 2.6.25 Holy cow. This patch set is a series of updates for the DM9000 driver, to tidy-up some of the source, stop the accesses to the PHY and EEPROM sitting and

Re: [PATCH 02/24 for-2.6.25] DM9000: Add platform data to specify external phy

2008-02-04 Thread Ben Dooks
This should have been: Patch from: Laurent Pinchart [EMAIL PROTECTED] This patch adds a flag to the DM9000 platform data which, when set, configures the device to use an external PHY. Signed-off-by: Laurent Pinchart [EMAIL PROTECTED] Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index:

[PATCH 19/24 for-2.6.25] DM9000: Remove cal_CRC() and use ether_crc_le instead

2008-02-04 Thread Ben Dooks
Remove the cal_CRC as this is basically wrappering the ether_crc_le function, and is only being used by the multicast hash table functions. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-quilt3/drivers/net/dm9000.c

[PATCH 07/24 for-2.6.25] DM9000: Add initial ethtool support

2008-02-04 Thread Ben Dooks
Add support for ethtool operations for the DM9000. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-quilt3/drivers/net/dm9000.c === --- linux-2.6.24-quilt3.orig/drivers/net/dm9000.c +++

[PATCH 08/24 for-2.6.25] DM9000: Do not sleep with spinlock and IRQs held

2008-02-04 Thread Ben Dooks
The phy read and write routines call udelay() with the board lock held, and with the posibility of IRQs being disabled. Since these delays can be up to 500usec, and are only required as we have to save the chip's address register. To improve the behaviour, hold the lock whilst we are writing and

[PATCH 04/24 for-2.6.25] DM9000 update debugging macros to use debug level

2008-02-04 Thread Ben Dooks
Change the debug macros to use the compiler to elide any unnecessary debug level, and to allow device configurable debug control. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-git5-dm9k/drivers/net/Kconfig === ---

[PATCH 00/24 for-2.6.25] DM9000 updates for 2.6.25

2008-02-04 Thread Ben Dooks
This patch set is a series of updates for the DM9000 driver, to tidy-up some of the source, stop the accesses to the PHY and EEPROM sitting and spinning with locks held, and to add ethtool support. This set includes a pair of patches from Laurent Pinchart for addition platform-data based

[PATCH 15/24 for-2.6.25] DM9000: Ensure spinlock held whilst accessing EEPROM registers

2008-02-04 Thread Ben Dooks
Ensure we hold the spinlock whilst the registers and being modified even though we hold the overall lock. This should protect against an interrupt happening whilst we are using the device. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-quilt3/drivers/net/dm9000.c

[PATCH 14/24 for-2.6.25] DM9000: Remove EEPROM initialisation code.

2008-02-04 Thread Ben Dooks
Remove the old hack to program an initial EEPROM setting into the DM9000 as we now have ethtool support for reading and writing the EEPROM. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-quilt3/drivers/net/dm9000.c

[PATCH 03/24 for-2.6.25] DM9000 use dev_xxx() instead of printk for output.

2008-02-04 Thread Ben Dooks
Move to using dev_dbg() and friends for the output of information to the user. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-git5-dm9k/drivers/net/dm9000.c === --- linux-2.6.24-git5-dm9k.orig/drivers/net/dm9000.c

[PATCH 01/24 for-2.6.25] DM9000: Fix endian-ness of data accesses. Patch from: Laurent Pinchart [EMAIL PROTECTED]

2008-02-04 Thread Ben Dooks
This patch splits the receive status in 8bit wide fields and convert the packet length from little endian to CPU byte order. Signed-off-by: Laurent Pinchart [EMAIL PROTECTED] Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-git5-dm9k/drivers/net/dm9000.c

[PATCH 12/24 for-2.6.25] DM9000: Add ethtool support for reading and writing EEPROM

2008-02-04 Thread Ben Dooks
Add ethtool support to access the configuration EEPROM connected to the DM9000. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-quilt3/drivers/net/dm9000.c === --- linux-2.6.24-quilt3.orig/drivers/net/dm9000.c +++

[PATCH 13/24 for-2.6.25] DM9000: Add ethtool control of msg_enable value

2008-02-04 Thread Ben Dooks
Allow the msg_enable value to be read and written by the ethtool interface. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-quilt3/drivers/net/dm9000.c === --- linux-2.6.24-quilt3.orig/drivers/net/dm9000.c +++

[PATCH 16/24 for-2.6.25] DM9000: Remove unnecessary changelog in header comment

2008-02-04 Thread Ben Dooks
We have a perfectly good version control system, so we do not need to duplicate change comments in the header for this code. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-quilt3/drivers/net/dm9000.c === ---

[PATCH 21/24 for-2.6.25] DM9000: Add platform flag for no attached EEPROM

2008-02-04 Thread Ben Dooks
Allow the platform data to specify to the DM9000 driver that there is no posibility of an attached EEPROM on the device, so default all reads to 0xff and ignore any write operations. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-quilt3/drivers/net/dm9000.c

[PATCH 17/24 for-2.6.25] DM9000: Use netif_msg to enable debugging options

2008-02-04 Thread Ben Dooks
Use the netif_msg_*() macros to enable the debugging based on the board's msg_enable field. The output still goes via the dev_dbg() macros, so will be tagged and output as appropriate. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-quilt3/drivers/net/dm9000.c

[PATCH 22/24 for-2.6.25] DM9000: Add support for MII ioctl() calls

2008-02-04 Thread Ben Dooks
Add entry to handle the MII ioctl() calls via the generic_mii_ioctl call. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-quilt3/drivers/net/dm9000.c === --- linux-2.6.24-quilt3.orig/drivers/net/dm9000.c +++

[PATCH 09/24 for-2.6.25] DM9000: Use msleep() instead of udelay()

2008-02-04 Thread Ben Dooks
We can use sleeping functions when reading and writing the PHY registers, so let us sleep instead of busy waiting for the PHY. Note, this also fixes a bug reading the PHY where only 100uS was being used instead of 150uS Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index:

[PATCH 11/24 for-2.6.25] DM9000: Add mutex to protect access

2008-02-04 Thread Ben Dooks
Add a mutex to serialise access to the chip functions from entries such as the ethtool and the MII code. This should reduce the amount of time the spinlock is held to protect the address register. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-quilt3/drivers/net/dm9000.c

[PATCH 05/24 for-2.6.25] DM9000: Pass IRQ flags via platform resources

2008-02-04 Thread Ben Dooks
Use the flags in the IRQ resource to specify the type of IRQ being requested, so that systems which do not have level-based interrupts, or change the interrupt in some other way can specify this without making an #ifdef mess in the driver. This is specifically designed to undo the change in

[PATCH 23/24 for-2.6.25] DM9000: Update retry count whilst identifying chip

2008-02-04 Thread Ben Dooks
Reading the ID register does not always return the correct ID from the device, so we retry several times to see if we get a correct value. These failures seem to be excaserbated by the speed of the access to the chip (possibly time between issuing the address and then the data cycle).

[PATCH 06/24 for-2.6.25] DM9000: Remove old timer based poll routines

2008-02-04 Thread Ben Dooks
Remove the timer based MII phy polling, as this is currently broken with the new EEPROM code that now uses mutexes to protect the phy access. This will need to be replaced in the future by some form of mutex safe mechanism for reading the MII phy status. The replacement has not been done here as

[PATCH 02/24 for-2.6.25] DM9000: Add platform data to specify external phy Patch from: Laurent Pinchart [EMAIL PROTECTED]

2008-02-04 Thread Ben Dooks
This patch adds a flag to the DM9000 platform data which, when set, configures the device to use an external PHY. Signed-off-by: Laurent Pinchart [EMAIL PROTECTED] Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-git5-dm9k/drivers/net/dm9000.c

[PATCH 20/24 for-2.6.25] DM9000: Remove redudant use of 0xff

2008-02-04 Thread Ben Dooks
The writing of the data should implicitly truncate the data to 8bits, so do not bother with the ands in the code. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-quilt3/drivers/net/dm9000.c === ---

[PATCH 18/24 for-2.6.25] DM9000: Fix delays used by EEPROM read and write

2008-02-04 Thread Ben Dooks
The code was using a delay of 8ms, when it should have been using the EEPROM status flag from the device to indicate the EEPROM transaction had finished. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-quilt3/drivers/net/dm9000.c

[PATCH 24/24 for-2.6.25] DM9000: Show the MAC address source after printing MAC

2008-02-04 Thread Ben Dooks
Show whether the MAC address was read from the EEPROM or the onboard PAR registers. Signed-off-by: Ben Dooks [EMAIL PROTECTED] Index: linux-2.6.24-quilt3/drivers/net/dm9000.c === --- linux-2.6.24-quilt3.orig/drivers/net/dm9000.c +++

[PATCH 10/24 for-2.6.25] DM9000: Remove barely used SROM array read.

2008-02-04 Thread Ben Dooks
The srom array in the board data is only being used in the device probe routines. The probe also only uses the first 6 bytes of an array we spend 512ms reading 128 bytes from. Change to reading the MAC area directly to the MAC address structure. As a side product, we rename the read_srom_word to

Re: [PATCH 01/24 for-2.6.25] DM9000: Fix endian-ness of data accesses.

2008-02-04 Thread Ben Dooks
On Tue, Feb 05, 2008 at 12:02:00AM +, Ben Dooks wrote: This should have been: Patch From: Laurent Pinchart [EMAIL PROTECTED] This patch splits the receive status in 8bit wide fields and convert the packet length from little endian to CPU byte order. Signed-off-by: Laurent Pinchart [EMAIL

Re: include/linux/pcounter.h

2008-02-04 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Mon, 4 Feb 2008 01:44:02 -0800 Please do not merge pieces of generic kernel infrastructure while keeping it all secret on the netdev list. Ever. It was so damn secret that it sat in your -mm tree for months. Don't be rediculious Andrew. -- To

Re: [PATCH] xircom_cb should return NETDEV_TX_BUSY when there are no descriptors available

2008-02-04 Thread Jeff Garzik
Erik Mouw wrote: On Mon, Feb 04, 2008 at 06:56:54PM +0100, Erik Mouw wrote: Changes in other networking paths uncovered a bug in the xircom_cb driver which made the kernel spew lots of the following error messages: BUG eth1 code -5 qlen 0 It turned out that the driver returned -EIO when

Re: [Wireless, ath5k] 2.6.24-git13 9135f1901ee6449dfe338adf6e40e9c2025b8150

2008-02-04 Thread Jiri Slaby
On 02/04/2008 10:52 PM, Dan Williams wrote: On Mon, 2008-02-04 at 22:34 +0100, Oliver Pinter wrote: On 2/4/08, Jiri Slaby [EMAIL PROTECTED] wrote: On 02/04/2008 03:00 PM, Oliver Pinter (Pintér Olivér) wrote: ioctl[SIOCSIWAUTH]: Operation not supported WEXT auth param 4 value 0x0 -

Re: [Wireless, ath5k] 2.6.24-git13 9135f1901ee6449dfe338adf6e40e9c2025b8150

2008-02-04 Thread Oliver Pinter
On 2/4/08, Oliver Pinter [EMAIL PROTECTED] wrote: On 2/4/08, Jiri Slaby [EMAIL PROTECTED] wrote: On 02/04/2008 03:00 PM, Oliver Pinter (Pintér Olivér) wrote: git top: 9135f1901ee6449dfe338adf6e40e9c2025b8150 [ 399.582185] wpa_supplicant[4383]: segfault at 30 ip 080697ca sp bf87a690

Re: [Bugme-new] [Bug 9888] New: tun device without protocol info header fails under IPv6

2008-02-04 Thread Andrew Morton
On Mon, 4 Feb 2008 13:46:13 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9888 Summary: tun device without protocol info header fails under IPv6 Product: Networking Version: 2.5 KernelVersion: =2.6.23

[PATCH] [RFC] 3c509: convert to isa_driver and pnp_driver v3

2008-02-04 Thread Ondrej Zary
Hello, this patch converts 3c509 driver to isa_driver and pnp_driver. The result is that autoloading using udev and hibernation works with ISA PnP cards. It also adds hibernation support for non-PnP ISA cards. xcvr module parameter was removed as its value was not used. Tested using 3 ISA

Re: [PATCH 2/2] ehea: add memory remove hotplug support

2008-02-04 Thread Michael Ellerman
On Mon, 2008-02-04 at 16:24 +0100, Jan-Bernd Themann wrote: On Monday 04 February 2008 15:46, Michael Ellerman wrote: On Mon, 2008-02-04 at 14:04 +0100, Jan-Bernd Themann wrote: Add memory remove hotplug support @@ -3559,6 +3578,10 @@ int __init ehea_module_init(void) if (ret)

[PATCH] Add IPv6 support to TCP SYN cookies

2008-02-04 Thread Glenn Griffin
Add IPv6 support to TCP SYN cookies. This is written and tested against 2.6.24, and applies cleanly to linus' current HEAD (d2fc0b). Unfortunately linus' HEAD breaks my sky2 card at the moment, so I'm unable to test against that. I see no reason why it would be affected though.

Re: 2.6.24-mm1 - Build failure at net/sched/cls_flow.c:598

2008-02-04 Thread Andrew Morton
On Mon, 04 Feb 2008 23:32:49 +0100 Tilman Schmidt [EMAIL PROTECTED] wrote: My attempt to build this failed with: CC [M] net/sched/cls_flow.o net/sched/cls_flow.c: In function ___flow_dump___: net/sched/cls_flow.c:598: error: ___struct tcf_ematch_tree___ has no member named ___hdr___

Re: include/linux/pcounter.h

2008-02-04 Thread Andrew Morton
On Mon, 04 Feb 2008 16:20:35 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Mon, 4 Feb 2008 01:44:02 -0800 Please do not merge pieces of generic kernel infrastructure while keeping it all secret on the netdev list. Ever. It was so damn

[2.6.24-mm1] TCP/IPv6 connect() oopses at twothirdsMD4Transform()

2008-02-04 Thread Tetsuo Handa
Hello. Kernel config is at http://I-love.SAKURA.ne.jp/tmp/config-2.6.24-mm1 2.6.24 works fine. Regards. -- BUG: unable to handle kernel paging request at 25476bec IP: [c0211c28] twothirdsMD4Transform+0x78/0x37c *pde = Oops: [#1] SMP DEBUG_PAGEALLOC last sysfs file:

Re: [2.6.24-mm1] TCP/IPv6 connect() oopses at twothirdsMD4Transform()

2008-02-04 Thread Andrew Morton
On Tue, 05 Feb 2008 10:28:43 +0900 Tetsuo Handa [EMAIL PROTECTED] wrote: Hello. Kernel config is at http://I-love.SAKURA.ne.jp/tmp/config-2.6.24-mm1 2.6.24 works fine. Thanks for testing and reporting. It really helps. Regards. -- BUG: unable to handle kernel paging request

Re: [PATCH 00/24 for-2.6.25] DM9000 updates for 2.6.25

2008-02-04 Thread Ben Dooks
On Mon, Feb 04, 2008 at 04:19:40PM -0800, Andrew Morton wrote: On Tue, 05 Feb 2008 00:01:59 + Ben Dooks [EMAIL PROTECTED] wrote: Subject: [PATCH 00/24 for-2.6.25] DM9000 updates for 2.6.25 Holy cow. This patch set is a series of updates for the DM9000 driver, to tidy-up some of

Re: [2.6.24-mm1] TCP/IPv6 connect() oopses at twothirdsMD4Transform()

2008-02-04 Thread Tetsuo Handa
Hello. random: revert braindamage that snuck into checkpatch cleanup Signed-off-by: Matt Mackall [EMAIL PROTECTED] Yes. It solved the oops. Thank you. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [2.6.24-mm1] TCP/IPv6 connect() oopses at twothirdsMD4Transform()

2008-02-04 Thread Matt Mackall
On Mon, 2008-02-04 at 17:36 -0800, Andrew Morton wrote: On Tue, 05 Feb 2008 10:28:43 +0900 Tetsuo Handa [EMAIL PROTECTED] wrote: Hello. Kernel config is at http://I-love.SAKURA.ne.jp/tmp/config-2.6.24-mm1 2.6.24 works fine. err, Matt? random: revert braindamage that snuck into

Re: [PATCH] 2.6.24-mm1 section type conflict cleanup

2008-02-04 Thread Kamalesh Babulal
Sam Ravnborg wrote: On Mon, Feb 04, 2008 at 09:52:23PM +0530, Kamalesh Babulal wrote: Hi Andrew, The 2.6.24-mm1 kernel build fails at many places with section type conflict build error. What arch? We have troubles with powerpc as pointed out by Al in another thread. Sam Hi Sam,

Re: 2.6.24-mm1 - Build failure at net/sched/cls_flow.c:598

2008-02-04 Thread Rami Rosen
Hello, I had sent a patch recently (which is currently pending) which solves this problem. see: http://www.spinics.net/lists/netdev/msg54455.html Regards, Rami Rosen On Feb 5, 2008 1:25 AM, Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 04 Feb 2008 23:32:49 +0100 Tilman Schmidt [EMAIL

[patch 1/2] hamradio: fix dmascc section mismatch

2008-02-04 Thread akpm
From: Randy Dunlap [EMAIL PROTECTED] hw[] is used in both init and exit functions so it cannot be initdata (section mismatch is when CONFIG_MODULES=n and CONFIG_DMASCC=y). WARNING: vmlinux.o(.exit.text+0xba7): Section mismatch: reference to .init.data: (between 'dmascc_exit' and

[patch 2/7] bluetooth: uninlining

2008-02-04 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] Remove all those inlines which were either a) unneeded or b) increased code size. textdata bss dec hex filename before: 6997 74 870791ba7 net/bluetooth/hidp/core.o after:6492 74 8657419ae

[patch 1/7] bluetooth: hidp_process_hid_control remove unnecessary parameter dealing

2008-02-04 Thread akpm
From: Dave Young [EMAIL PROTECTED] According to the bluetooth HID spec v1.0 chapter 7.4.2 This code requests a major state change in a BT-HID device. A HID_CONTROL request does not generate a HANDSHAKE response. A HID_CONTROL packet with a parameter of VIRTUAL_CABLE_UNPLUG is the only

[patch 7/7] rfcomm tty: destroy before tty_close()

2008-02-04 Thread akpm
From: Dave Young [EMAIL PROTECTED] rfcomm dev could be deleted in tty_hangup, so we must not call rfcomm_dev_del again to prevent from destroying rfcomm dev before tty close. Signed-off-by: Dave Young [EMAIL PROTECTED] Cc: Marcel Holtmann [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

[patch 3/7] drivers/bluetooth/bpa10x.c: fix memleak

2008-02-04 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] This patch fixea a memleak spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/bluetooth/bpa10x.c |1 + 1 file changed, 1 insertion(+) diff -puN

[patch 5/7] bluetooth: blacklist another Broadcom BCM2035 device

2008-02-04 Thread akpm
From: Andy Shevchenko [EMAIL PROTECTED] This device is recognized as bluetooth, but still not works. Signed-off-by: Andy Shevchenko [EMAIL PROTECTED] Cc: Marcel Holtmann [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/bluetooth/hci_usb.c |1 + 1 file changed, 1

[patch 4/7] drivers/bluetooth/btsdio.c: fix double-free

2008-02-04 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] This patch fixes a double-free spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/bluetooth/btsdio.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff -puN

[patch 3/4] mv643xx_eth: fix byte order when checksum offload is enabled

2008-02-04 Thread akpm
From: Byron Bradley [EMAIL PROTECTED] The Marvell Orion system on chips have an integrated mv643xx MAC. On these little endian ARM devices mv643xx will oops when checksum offload is enabled. Swapping the byte order of the protocol and checksum solves this problem. Signed-off-by: Byron Bradley

[patch 2/2] tun: impossible to deassert IFF_ONE_QUEUE or IFF_NO_PI

2008-02-04 Thread akpm
From: Nathaniel Filardo [EMAIL PROTECTED] Taken from http://bugzilla.kernel.org/show_bug.cgi?id=9806 The TUN/TAP driver only permits one-way transitions of IFF_NO_PI or IFF_ONE_QUEUE during the lifetime of a tap/tun interface. Note that tun_set_iff contains 541 if (ifr-ifr_flags

[patch 1/4] forcedeth: power down phy when interface is down

2008-02-04 Thread akpm
From: Ed Swierk [EMAIL PROTECTED] Bring the physical link down when the interface is down by placing the PHY in power-down state, unless WOL is enabled. This mirrors the behavior of other drivers including e1000 and tg3. Without the patch, ifconfig down leaves the physical link up, which

[patch 4/4] drivers/net/tlan.c: compilation warning fix

2008-02-04 Thread akpm
From: Leonardo Potenza [EMAIL PROTECTED] Add a check for the pci_register_driver() return value. Removed unused variable pad_allocated. The aim of this patch is to remove the following warning messages: drivers/net/tlan.c: In function 'tlan_probe': drivers/net/tlan.c:486: warning: ignoring

[patch 2/4] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2008-02-04 Thread akpm
From: Michael Pyne [EMAIL PROTECTED] Partially revert a change to mac address detection introduced to the forcedeth driver. The change was intended to correct mac address detection for newer nVidia chipsets where the mac address was stored in reverse order. One of those chipsets appears to

[patch 6/7] hci_ldisc: fix null pointer deref

2008-02-04 Thread akpm
From: David Newall [EMAIL PROTECTED] Arjan: With the help of kerneloops.org I've spotted a nice little interaction between the TTY layer and the bluetooth code, however the tty layer is not something I'm all too familiar with so I rather ask than brute-force fix the code incorrectly.