Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 07 Feb 2008 10:40:19 +0100), Eric Dumazet <[EMAIL PROTECTED]> says: > [NET] IPV4: lower stack usage in cookie_hash() function > > 400 bytes allocated on stack might be a litle bit too much. Using a > per_cpu var is more friendly. > > Signed-off-by: Eric

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-12 Thread Jarek Poplawski
On Tue, Feb 12, 2008 at 10:00:03PM -0800, David Miller wrote: > From: James Chapman <[EMAIL PROTECTED]> > Date: Tue, 12 Feb 2008 10:58:21 + > > > Here is a trace from when we had _bh locks. > > The problem is that the pppol2tp code calls sk_dst_get() in software > interrupt context and that i

Re: [PATCH net-2.6.25] net: Improve cache line coherency of ingress qdisc

2008-02-12 Thread David Miller
From: Neil Turton <[EMAIL PROTECTED]> Date: Thu, 17 Jan 2008 11:04:44 + > Move the ingress qdisc members of struct net_device from the transmit > cache line to the receive cache line to avoid cache line ping-pong. > These members are only used on the receive path. > > Signed-off-by: Neil Turt

Re: [Bug 9750] [patch 2.6.25 v2] dev: avoid a race that triggers assertion failure

2008-02-12 Thread David Miller
From: Matti Linnanvuori <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 23:06:41 -0800 (PST) > There is a race in Linux kernel file net/core/dev.c, function dev_close. > The function calls function dev_deactivate, which calls function > dev_watchdog_down that deletes the watchdog timer. However, after

Re: [PATCH] Reorder ACK/RST checking in LISTEN state

2008-02-12 Thread David Miller
From: Kris Katterjohn <[EMAIL PROTECTED]> Date: Wed, 13 Feb 2008 00:38:13 -0600 > I've attached a patch that changes the order of the ACK and RST checking > in the LISTEN state in tcp_rcv_state_process() in tcp_input.c > > Before: If an ACK/RST packet is received, then tcp_rcv_state_process()

[Bug 9750] [patch 2.6.25 v2] dev: avoid a race that triggers assertion failure

2008-02-12 Thread Matti Linnanvuori
From: Matti Linnanvuori <[EMAIL PROTECTED]> There is a race in Linux kernel file net/core/dev.c, function dev_close. The function calls function dev_deactivate, which calls function dev_watchdog_down that deletes the watchdog timer. However, after that, a driver can call netif_carrier_ok, which ca

Re: [PATCH RESEND] [XFRM]: Speed up xfrm_policy and xfrm_state walking

2008-02-12 Thread David Miller
From: Timo_Teräs <[EMAIL PROTECTED]> Date: Fri, 01 Feb 2008 16:58:04 +0200 > @@ -1780,6 +1786,7 @@ static int check_reqid(struct xfrm_policy *xp, int dir, > int count, void *ptr) > > static u32 gen_reqid(void) > { > + struct xfrm_policy_walk walk; > u32 start; > static u32 req

Re: xfrm_input() and ->seq oddities

2008-02-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 4 Feb 2008 09:00:27 +1100 > On Sun, Feb 03, 2008 at 11:04:44AM +, Al Viro wrote: > > IMO that at least deserves a comment near xfrm_input()... > > Sure. There is already a comment about encap_type < 0 in there, but > I think you'll probably be

Re: xfrm_input() and ->seq oddities

2008-02-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sun, 3 Feb 2008 11:20:19 +1100 > [IPSEC]: Fix bogus usage of u64 on input sequence number > > Al Viro spotted a bogus use of u64 on the input sequence number which > is big-endian. This patch fixes it by giving the input sequence number > its own member

Re: [PATCH] rtnetlink.c: send a single notification on device state changes

2008-02-12 Thread David Miller
From: Laszlo Attila Toth <[EMAIL PROTECTED]> Date: Thu, 7 Feb 2008 12:57:50 +0100 > In do_setlink() a single notification is sent at the end of the function > if any modification occured. If the address has been changed, another > notification is sent. > > Both of them is required because origin

[PATCH] Reorder ACK/RST checking in LISTEN state

2008-02-12 Thread Kris Katterjohn
Hey everyone, [I'm not subscribed, so please CC me on any replies] I've attached a patch that changes the order of the ACK and RST checking in the LISTEN state in tcp_rcv_state_process() in tcp_input.c Before: If an ACK/RST packet is received, then tcp_rcv_state_process() would return 1 bec

Re: [PATCH 3/3][NETLABLE]: Hide netlbl_unlabel_audit_addr6 under ifdef CONFIG_IPV6.

2008-02-12 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 07 Feb 2008 20:25:52 +0300 > This one is called from under this config only, so move > it in the same place. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [PATCH 2/3][NETLABEL]: Don't produce unused variables when IPv6 is off.

2008-02-12 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 07 Feb 2008 20:24:15 +0300 > Some code declares variables on the stack, but uses them > under #ifdef CONFIG_IPV6, so thay become unused when ipv6 > is off. Fortunately, they are used in a switch's case > branches, so the fix is rather simple. >

Re: [PATCH 1/3][NETLABEL]: Compilation for CONFIG_AUDIT=n case.

2008-02-12 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 07 Feb 2008 20:20:30 +0300 > The audit_log_start() will expand into an empty do { } while (0) > construction and the audit_ctx becomes unused. > > The solution: push current->audit_context into audit_log_start() > directly, since it is not requ

Re: [PATCH][GENETLINK]: Relax dances with genl_lock.

2008-02-12 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 20:16:13 +0300 > The genl_unregister_family() calls the genl_unregister_mc_groups(), > which takes and releases the genl_lock and then locks and releases > this lock itself. > > Relax this behavior, all the more so the genl_unregis

Re: [PATCH][NETLABEL]: Fix lookup logic of netlbl_domhsh_search_def.

2008-02-12 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 11:34:09 -0500 > On Tuesday 12 February 2008 11:27:16 am Pavel Emelyanov wrote: > > Currently, if the call to netlbl_domhsh_search succeeds the > > return result will still be NULL. > > > > Fix that, by returning the found entry (if any).

Re: [PATCH] [IPV6] Minor cleanup: remove unused method declaration (net/ndisc.h).

2008-02-12 Thread David Miller
From: "Rami Rosen" <[EMAIL PROTECTED]> Date: Sun, 10 Feb 2008 18:40:13 +0200 > This patch removes unused declaration of dflt_rt_lookup() method in > include/net/ndisc.h > > Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe

Re: [RFC, PATCH]: Pass link level header from/to PPP interface

2008-02-12 Thread David Miller
From: Urs Thuermann <[EMAIL PROTECTED]> Date: 10 Feb 2008 10:48:51 +0100 > So what is your opinion about this change? No general objections from me. But if libpcap and tcpdump can already identify PPP packets then, besides "consistency", what does this buy us other than potential breakage? -- To

Re: [PATCH] Fix comment for skb_pull_rcsum

2008-02-12 Thread David Miller
From: Urs Thuermann <[EMAIL PROTECTED]> Date: 10 Feb 2008 10:48:07 +0100 > Fix comment for skb_pull_rcsum > > Signed-off-by: Urs Thuermann <[EMAIL PROTECTED]> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

Re: An ioctl to delete an ipv6 tunnel leads to a kernel panic

2008-02-12 Thread Natalie Protasevich
On Feb 12, 2008 9:49 PM, David Miller <[EMAIL PROTECTED]> wrote: > From: "Natalie Protasevich" <[EMAIL PROTECTED]> > Date: Mon, 11 Feb 2008 12:49:12 -0800 > > > Possible reason for this failure was identified and tested by the > > submitter and several other reporters that ran into the same problem

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-12 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 10:58:21 + > Here is a trace from when we had _bh locks. The problem is that the pppol2tp code calls sk_dst_get() in software interrupt context and that is not allowed. sk_dst_get() grabs sk->sk_dst_lock without any BH enabling o

Re: An ioctl to delete an ipv6 tunnel leads to a kernel panic

2008-02-12 Thread David Miller
From: "Natalie Protasevich" <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 12:49:12 -0800 > Possible reason for this failure was identified and tested by the > submitter and several other reporters that ran into the same problem. > Can the patch be reviewed and pushed upstream if accepted (if the > pr

Re: [PATCH] [NET]: Add per-connection option to set max TSO frame size

2008-02-12 Thread Stephen Hemminger
On Tue, 12 Feb 2008 14:01:32 -0800 PJ Waskiewicz <[EMAIL PROTECTED]> wrote: > This patch adds the ability for device drivers to control the size of the > TSO frames being sent to them, per TCP connection. By setting the > netdevice's max_gso_frame_size value, the socket layer will set the GSO > f

[PATCH] [NET]: Add per-connection option to set max TSO frame size

2008-02-12 Thread PJ Waskiewicz
This patch adds the ability for device drivers to control the size of the TSO frames being sent to them, per TCP connection. By setting the netdevice's max_gso_frame_size value, the socket layer will set the GSO frame size based on that value. This will propogate into the TCP layer, and send TSO'

[PATCH] [IPROUTE2] Update various classifiers' help output for expected CLASSID syntax

2008-02-12 Thread PJ Waskiewicz
This updates the help output to specify that CLASSID should be hexidecimal. This makes sure that a user entering "flowid 1:10" gets his flow put into band 15 (0x10) and knows why. Signed-off-by: Peter P Waskiewicz Jr <[EMAIL PROTECTED]> --- doc/actions/actions-general |3 +++ tc/f_basic.c

RE: [PATCH] [TC U32] Fix input parsing to support more than 9 flow id'scorrectly

2008-02-12 Thread Waskiewicz Jr, Peter P
> Sorry, can't change the api, update the documentation instead. Yes, this is much more reasonable. I'll send a patch shortly to do that. Thanks -PJ Waskiewicz -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: [PATCH] [TC U32] Fix input parsing to support more than 9 flow id'scorrectly

2008-02-12 Thread Stephen Hemminger
Waskiewicz Jr, Peter P wrote: From: PJ Waskiewicz <[EMAIL PROTECTED]> Using strtoul with a base of 16 converts flowid 10 into 0x10, which makes it flowid 16. This is interpreted by the kernel incorrectly, and causes traffic flows above 9 to be classified into band 0 on multiband qdiscs. This

Re: [PATCH 2/4] fib_trie: improve output format for /proc/net/fib_trie

2008-02-12 Thread Stephen Hemminger
Andrew Morton wrote: On Tue, 12 Feb 2008 16:50:44 -0800 Stephen Hemminger <[EMAIL PROTECTED]> wrote: Make output format prettier (more tree like). : --- 0.0.0.0/0 |--- 10.111.111.0/24 | +-- 10.111.111.0/32 link broadcast | |--- 10.111.111.254/31 | | +-- 10.111.

RE: [PATCH] [TC U32] Fix input parsing to support more than 9 flow id'scorrectly

2008-02-12 Thread Waskiewicz Jr, Peter P
> From: PJ Waskiewicz <[EMAIL PROTECTED]> > > Using strtoul with a base of 16 converts flowid 10 into 0x10, > which makes it flowid 16. This is interpreted by the kernel > incorrectly, and causes traffic flows above 9 to be > classified into band 0 on multiband qdiscs. > This changes the base

Re: [PATCH] e1000e: Fix CRC stripping in hardware context bug

2008-02-12 Thread Andy Gospodarek
On Tue, Feb 12, 2008 at 03:20:24PM -0800, Auke Kok wrote: > CRC stripping was only correctly enabled for packet split recieves > which is used when receiving jumbo frames. Correctly enable SECRC > also for normal buffer packet receives. > > Tested by Andy Gospodarek and Johan Andersson, see bugzil

[PATCH] [TC U32] Fix input parsing to support more than 9 flow id's correctly

2008-02-12 Thread PJ Waskiewicz
From: PJ Waskiewicz <[EMAIL PROTECTED]> Using strtoul with a base of 16 converts flowid 10 into 0x10, which makes it flowid 16. This is interpreted by the kernel incorrectly, and causes traffic flows above 9 to be classified into band 0 on multiband qdiscs. This changes the base to 10, which will

Re: [PATCH 2/4] fib_trie: improve output format for /proc/net/fib_trie

2008-02-12 Thread Andrew Morton
On Tue, 12 Feb 2008 16:50:44 -0800 Stephen Hemminger <[EMAIL PROTECTED]> wrote: > Make output format prettier (more tree like). > >: >--- 0.0.0.0/0 > |--- 10.111.111.0/24 > | +-- 10.111.111.0/32 link broadcast > | |--- 10.111.111.254/31 > | | +-- 10.111.111.254/32

Re: [PATCH] [IRDA] irda_init() nuke useless debug printk

2008-02-12 Thread David Miller
From: maximilian attems <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 11:30:47 +0100 > irda_init() > dmesg line is not really informative, thus remove it. > There are better ways to know that a module is loaded. > > Seen on a debian config with IRDA_DEBUG enabled. > > Signed-off-by: maximilian atte

Re: [Bug 9750] [patch 2.6.25] dev: avoid a race that triggers assertion failure

2008-02-12 Thread David Miller
From: Matti Linnanvuori <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 02:45:22 -0800 (PST) > From: Matti Linnanvuori <[EMAIL PROTECTED]> > > There is a race in Linux kernel file net/core/dev.c, function dev_close. > The function calls function dev_deactivate, which calls function > dev_watchdog_down

Re: [IPV6]: Fix IPsec datagram fragmentation

2008-02-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 13 Feb 2008 11:04:37 +1100 > [IPV6]: Fix IPsec datagram fragmentation > > This is a long-standing bug in the IPsec IPv6 code that breaks > when we emit a IPsec tunnel-mode datagram packet. The problem > is that the code the emits the packet assumes

Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopback connections.

2008-02-12 Thread Steve Wise
Roland Dreier wrote: applied, although: > +static void is_loopback_dst(struct iw_cm_id *cm_id) > +{ > + struct net_device *dev; > + > + dev = ip_dev_find(&init_net, cm_id->remote_addr.sin_addr.s_addr); > + if (!dev) > + return 0; > + dev_put(dev); > + return 1; > +} is there

[PATCH BUGFIX 25-rc1] Smack: Don't fail against Nulled sk sockets

2008-02-12 Thread Ahmed S. Darwish
Hi!, Appropriately handle sockets with sk = NULL. This is usually the socket case when starting kernel nfsd. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> Acked-by: Casey Schaufler <[EMAIL PROTECTED]> Tested-by: Joerg Platte <[EMAIL PROTECTED]> -- diff --git a/security/smack/smack_lsm.c b/

Re: [PATCH 1/4] rcu_assign_pointer: null check fix

2008-02-12 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 16:50:43 -0800 > Goofed on last change, should avoid barrier only on rcu_assign_pointer(p, > NULL) > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Like the original change this needs to be merged upstream outside of the

Re: [PATCH 4/4] hlist_for_each_entry_continue simplification

2008-02-12 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 12 Feb 2008 16:50:46 -0800 > All the users of hlist_for_each_entry_continue had to intialize pos > before use; change API so pos is a pure temporary variable which matches > the usage of other _for_each_entry routines. > > Signed-off-by:

[PATCH 2/4] fib_trie: improve output format for /proc/net/fib_trie

2008-02-12 Thread Stephen Hemminger
Make output format prettier (more tree like). : --- 0.0.0.0/0 |--- 10.111.111.0/24 | +-- 10.111.111.0/32 link broadcast | |--- 10.111.111.254/31 | | +-- 10.111.111.254/32 host local | | +-- 10.111.111.255/32 link broadcast |--- 127.0.0.0/8 | |--- 127

[PATCH 4/4] hlist_for_each_entry_continue simplification

2008-02-12 Thread Stephen Hemminger
All the users of hlist_for_each_entry_continue had to intialize pos before use; change API so pos is a pure temporary variable which matches the usage of other _for_each_entry routines. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/include/linux/list.h 2008-02-12 15:09:17.00

[PATCH 1/4] rcu_assign_pointer: null check fix

2008-02-12 Thread Stephen Hemminger
Goofed on last change, should avoid barrier only on rcu_assign_pointer(p, NULL) Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/linux/rcupdate.h | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) --- a/include/linux/rcupdate.h 2008-02-12 14:46:49.0 -

[PATCH 0/4] fib_trie related patches for 2.6.25

2008-02-12 Thread Stephen Hemminger
More trie cleanups with some RCU related changes as well. Patches are against net-2.6 tree. -- Stephen Hemminger <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/ma

Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopback connections.

2008-02-12 Thread Roland Dreier
applied, although: > +static void is_loopback_dst(struct iw_cm_id *cm_id) > +{ > +struct net_device *dev; > + > +dev = ip_dev_find(&init_net, cm_id->remote_addr.sin_addr.s_addr); > +if (!dev) > +return 0; > +dev_put(dev); > +return 1; > +} is there an

Re: E1000 (PCI-E) doesn't work on nforce430, MSI issue.

2008-02-12 Thread Krzysztof Halasa
"Kok, Auke" <[EMAIL PROTECTED]> writes: >>> Don't work by default. "pci=nomsi" fixes the problem. > > actually does not fix anything - it just works around it by falling > back to legacy interrupts. Actually it does, fixes the problem by working around a bug :-) Thanks for info. -- Krzysztof Ha

[IPV6]: Fix IPsec datagram fragmentation

2008-02-12 Thread Herbert Xu
Hi Dave: [IPV6]: Fix IPsec datagram fragmentation This is a long-standing bug in the IPsec IPv6 code that breaks when we emit a IPsec tunnel-mode datagram packet. The problem is that the code the emits the packet assumes the IPv6 stack will fragment it later, but the IPv6 stack assumes that whoe

RE: [PATCH resend] qla3xxx: convert byte order of constant instead ofvariable

2008-02-12 Thread Ron Mercer
> -Original Message- > From: Marcin Slusarz [mailto:[EMAIL PROTECTED] > Sent: Sunday, February 10, 2008 2:06 AM > To: netdev@vger.kernel.org; Linux Driver > Cc: LKML > Subject: [PATCH resend] qla3xxx: convert byte order of > constant instead ofvariable > > convert byte order of consta

[PATCH] e1000e: Fix CRC stripping in hardware context bug

2008-02-12 Thread Auke Kok
CRC stripping was only correctly enabled for packet split recieves which is used when receiving jumbo frames. Correctly enable SECRC also for normal buffer packet receives. Tested by Andy Gospodarek and Johan Andersson, see bugzilla #9940. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers

[PATCH] ixgbe: Correctly obtain protocol information on transmit

2008-02-12 Thread Auke Kok
In reply to "RE: [Fwd: [PATCH 2.6.25] ixgbe/igb: correctly obtain protocol information on transmit]" from Andy Gospodarek: The driver was incorrectly looking at socket headers for protocol information, needed for checksumming offload. Fix this by not looking at the socket but frame headers instead

[PATCH] libertas: Remove unused exports

2008-02-12 Thread Roland Dreier
The libertas driver exports a number of symbols with no in-tree users; remove these unused exports. lbs_reset_device() is completely unused, with no callers at all, so remove the function completely. A couple of these unused exported symbols are static, which causes the following build error on i

Re: r8169 auto-negotiation problem

2008-02-12 Thread Francois Romieu
fgnijuhhu guduggurehug <[EMAIL PROTECTED]> : > > fgnijuhhu guduggurehug : > > [...] > >> I already posted my problem and what I did to solve it on > >> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=461429. > > > > Have you tried anything more recent than a 2.6.18 based kernel ? > > No, but if

Re: E1000 (PCI-E) doesn't work on nforce430, MSI issue.

2008-02-12 Thread Kok, Auke
Prakash Punnoor wrote: > On the day of Tuesday 12 February 2008 Krzysztof Halasa hast written: >> Hi, >> >> Is it a known problem? >> Linux 2.6.24.2, ASUS M2NPV-MX mobo, nforce 430 based, two PCI-E x1 >> E1000 cards, 32-bit kernel, default e1000 driver (PCI IDs disabled in >> e1000e). your card wi

[PATCH 2.6.25] RDMA/cxgb3: Fail loopback connections.

2008-02-12 Thread Steve Wise
RDMA/cxgb3: Fail loopback connections. The cxgb3 HW and driver don't support loopback RDMA connections. So fail any connection attempt where the destination address is local. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/iwch_cm.c | 16 1 fil

permisions for Ethetool vs rtnetlink

2008-02-12 Thread Rick Jones
I've been further enhancing the netperf omni tests to enable reporting stuff like uname for local/remote, the name of the probable egress interface (rtnetlink), and then driver information for that interface. I figure that such information being spat-out by netperf might be useful to have if on

Re: E1000 (PCI-E) doesn't work on nforce430, MSI issue.

2008-02-12 Thread Prakash Punnoor
On the day of Tuesday 12 February 2008 Krzysztof Halasa hast written: > Hi, > > Is it a known problem? > Linux 2.6.24.2, ASUS M2NPV-MX mobo, nforce 430 based, two PCI-E x1 > E1000 cards, 32-bit kernel, default e1000 driver (PCI IDs disabled in > e1000e). > > Don't work by default. "pci=nomsi" fixes

E1000 (PCI-E) doesn't work on nforce430, MSI issue.

2008-02-12 Thread Krzysztof Halasa
Hi, Is it a known problem? Linux 2.6.24.2, ASUS M2NPV-MX mobo, nforce 430 based, two PCI-E x1 E1000 cards, 32-bit kernel, default e1000 driver (PCI IDs disabled in e1000e). Don't work by default. "pci=nomsi" fixes the problem. 82572EI Gigabit Ethernet Controller (Copper) (rev 06) Subsystem: PRO/

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-12 Thread Ross Vandegrift
On Fri, Feb 08, 2008 at 01:07:46PM +0100, Andi Kleen wrote: > On Thu, Feb 07, 2008 at 02:44:46PM -0500, Ross Vandegrift wrote: > > On Wed, Feb 06, 2008 at 09:53:57AM +0100, Andi Kleen wrote: > > My initial test is end-to-end 1000Mbps, but I've got a few different > > packet rates. > > > > > If the

Re: e1000e hardware CRC stripping breaks bridging

2008-02-12 Thread Johan Andersson
Kok, Auke wrote: Jesse figured it out. I just send you a patch to test, can you guys give that a try and see if it fixes the situation? Johan? thanks, Auke Yes, I will test this patch right away. /Johan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a m

Re: [PATCH] [RFC] Smack: unlabeled outgoing ambient packets - v2

2008-02-12 Thread Paul Moore
On Monday 11 February 2008 7:00:33 pm Casey Schaufler wrote: > This patch differs significantly from the previous version. > I think that I am using the netlbl interfaces more appropriately, > Paul, please let me know if there's a better approach. Nope, this approach is what I was talking about.

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-12 Thread Jarek Poplawski
On Tue, Feb 12, 2008 at 08:32:18PM +0100, Jarek Poplawski wrote: ... > It seems the above version of this macro uses the barrier for 0, but > if I miss something, or for these other: documenting reasons, ...or __builtin_constants could be used for indexing (?!), > then of > course you are right.

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-12 Thread Jarek Poplawski
On Tue, Feb 12, 2008 at 08:07:29AM -0800, Paul E. McKenney wrote: ... > "All programmers are blind, especially me." Hmm... I got it my way: you - superheroes - sometimes seem to be just like us - common people... (Probably early in the morning, before dressing your funny costumes?) > You are rig

Re: Open bugs

2008-02-12 Thread Natalie Protasevich
On Feb 12, 2008 9:57 AM, James Bottomley <[EMAIL PROTECTED]> wrote: > Added linux-scsi for the SCSI ones > > On Tue, 2008-02-12 at 00:18 -0800, Natalie Protasevich wrote: > > Hello, > > > > The bugs listed are over a month old, and haven't been addressed yet. > > It would be appreciated if correspo

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-12 Thread Dave Hansen
On Mon, 2008-02-11 at 17:24 +0100, Jan-Bernd Themann wrote: > Drivers like eHEA need memory notifiers in order to > update their internal DMA memory map when memory is added > to or removed from the system. > > Patch for eHEA memory hotplug support that uses these functions: > http://www.spinics.

Re: Open bugs

2008-02-12 Thread James Bottomley
Added linux-scsi for the SCSI ones On Tue, 2008-02-12 at 00:18 -0800, Natalie Protasevich wrote: > Hello, > > The bugs listed are over a month old, and haven't been addressed yet. > It would be appreciated if corresponding maintainers identify whether > the bugs have been fixed, or need to be wor

Re: e1000e hardware CRC stripping breaks bridging

2008-02-12 Thread Kok, Auke
Daniel Drake wrote: > Johan Andersson reported on the Gentoo bugzilla that the hardware CRC > stripping enabled by e1000e breaks bridging because sometimes the CRC is > not stripped: > https://bugs.gentoo.org/show_bug.cgi?id=209235 > > Apparently "upstream" are aware but I couldn't find any mails

Re: e1000e hardware CRC stripping breaks bridging

2008-02-12 Thread Andy Gospodarek
On Tue, Feb 12, 2008 at 02:57:50PM +0100, Johan Andersson wrote: > Here is the bug report: > http://bugzilla.kernel.org/show_bug.cgi?id=9940 > > /Johan > > On Tue, 2008-02-12 at 13:27 +, Daniel Drake wrote: > > Hi, > > > > Johan Andersson reported on the Gentoo bugzilla that the hardware CRC

[PATCH][GENETLINK]: Relax dances with genl_lock.

2008-02-12 Thread Pavel Emelyanov
The genl_unregister_family() calls the genl_unregister_mc_groups(), which takes and releases the genl_lock and then locks and releases this lock itself. Relax this behavior, all the more so the genl_unregister_mc_groups() is called from genl_unregister_family() only. I'm not sure, whether this

RE: r8169 auto-negotiation problem

2008-02-12 Thread fgnijuhhu guduggurehug
> fgnijuhhu guduggurehug : > [...] >> I already posted my problem and what I did to solve it on >> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=461429. > > Have you tried anything more recent than a 2.6.18 based kernel ? No, but if changes were made to the iniatialization of the chipset in t

Re: [PATCH][NETLABEL]: Fix lookup logic of netlbl_domhsh_search_def.

2008-02-12 Thread Paul Moore
On Tuesday 12 February 2008 11:27:16 am Pavel Emelyanov wrote: > Currently, if the call to netlbl_domhsh_search succeeds the > return result will still be NULL. > > Fix that, by returning the found entry (if any). > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Good catch, thanks. Acked-by

[PATCH][NETLABEL]: Fix lookup logic of netlbl_domhsh_search_def.

2008-02-12 Thread Pavel Emelyanov
Currently, if the call to netlbl_domhsh_search succeeds the return result will still be NULL. Fix that, by returning the found entry (if any). Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/netlabel/netlabel_domainhash.c b/net/netlabel/netlabel_domainhash.c index 9a8ea

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-12 Thread Paul E. McKenney
On Tue, Feb 12, 2008 at 08:57:14AM +, Jarek Poplawski wrote: > On 12-02-2008 02:16, David Miller wrote: > > From: Stephen Hemminger <[EMAIL PROTECTED]> > > Date: Mon, 11 Feb 2008 16:59:54 -0800 > > > > linux-kernel added to CC:, any change to generic kernel infrastructure > > should be posted

Re: [git patches] net driver updates

2008-02-12 Thread Jeff Garzik
Ben Dooks wrote: These two where meant to be from Laurent Pinchart, they do have the correct signed-off lines in for him and start with "Patch from:". Is there any chance of fixing the authour attribution now? The first line of the changeset mentions it. Other than that, nope. Jeff

Re: [Bug 9750] [patch 2.6.25] dev: avoid a race that triggers assertion failure

2008-02-12 Thread Jeff Garzik
Matti Linnanvuori wrote: From: Matti Linnanvuori <[EMAIL PROTECTED]> There is a race in Linux kernel file net/core/dev.c, function dev_close. The function calls function dev_deactivate, which calls function dev_watchdog_down that deletes the watchdog timer. However, after that, a driver can call

Re: e1000e hardware CRC stripping breaks bridging

2008-02-12 Thread Johan Andersson
Here is the bug report: http://bugzilla.kernel.org/show_bug.cgi?id=9940 /Johan On Tue, 2008-02-12 at 13:27 +, Daniel Drake wrote: > Hi, > > Johan Andersson reported on the Gentoo bugzilla that the hardware CRC > stripping enabled by e1000e breaks bridging because sometimes the CRC is > not

e1000e hardware CRC stripping breaks bridging

2008-02-12 Thread Daniel Drake
Hi, Johan Andersson reported on the Gentoo bugzilla that the hardware CRC stripping enabled by e1000e breaks bridging because sometimes the CRC is not stripped: https://bugs.gentoo.org/show_bug.cgi?id=209235 Apparently "upstream" are aware but I couldn't find any mails or bug reports on this

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-12 Thread Jarek Poplawski
On Tue, Feb 12, 2008 at 10:58:21AM +, James Chapman wrote: ... > Here is a trace from when we had _bh locks. Very nice... ...But since it's quite long, and if you don't know all these paths this could take some time, maybe one question: so if lockdep got these locks right (sometimes it can be

Re: [git patches] net driver updates

2008-02-12 Thread Ben Dooks
On Mon, Feb 11, 2008 at 12:05:16PM -0500, Jeff Garzik wrote: > Mostly fixes, a few cleanups (generally assisting fixes), and an > exception for PS3 wireless because it had been posted, reviewed and > acked for a while, just not committed. Thanks, good to get the DM9000 changes moving. > Please p

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-12 Thread James Chapman
David Miller wrote: From: James Chapman <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 23:41:18 + Jarek Poplawski wrote: On Mon, Feb 11, 2008 at 10:19:35PM +, James Chapman wrote: ... Below is example output from lockdep. The oops is reproducible when creating/deleting lots of sessions w

[Bug 9750] [patch 2.6.25] dev: avoid a race that triggers assertion failure

2008-02-12 Thread Matti Linnanvuori
From: Matti Linnanvuori <[EMAIL PROTECTED]> There is a race in Linux kernel file net/core/dev.c, function dev_close. The function calls function dev_deactivate, which calls function dev_watchdog_down that deletes the watchdog timer. However, after that, a driver can call netif_carrier_ok, which ca

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-12 Thread Jarek Poplawski
On Mon, Feb 11, 2008 at 11:42:12PM +, James Chapman wrote: > Jarek Poplawski wrote: >> On Mon, Feb 11, 2008 at 11:49:24PM +0100, Jarek Poplawski wrote: >>> On Mon, Feb 11, 2008 at 10:19:35PM +, James Chapman wrote: >>> ... Below is example output from lockdep. The oops is reproducible

[PATCH] [IRDA] irda_init() nuke useless debug printk

2008-02-12 Thread maximilian attems
irda_init() dmesg line is not really informative, thus remove it. There are better ways to know that a module is loaded. Seen on a debian config with IRDA_DEBUG enabled. Signed-off-by: maximilian attems <[EMAIL PROTECTED]> --- net/irda/irmod.c |2 -- 1 files changed, 0 insertions(+), 2 delet

Re: [Bugme-new] [Bug 9940] New: e1000e driver with 82566DM-2 controller doesn't strip crc from frames

2008-02-12 Thread Andrew Morton
On Tue, 12 Feb 2008 01:50:49 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9940 > >Summary: e1000e driver with 82566DM-2 controller doesn't strip > crc from frames >Product: Drivers >Version: 2.5 > Ke

[PATCH] 2.6.25-rc1 ml4x network driver build failure

2008-02-12 Thread Kamalesh Babulal
The 2.6.25-rc1 kernel build fails on the powerpc with the error drivers/net/mlx4/alloc.c: In function ‘mlx4_buf_alloc’: drivers/net/mlx4/alloc.c:162: error: implicit declaration of function ‘vmap’ drivers/net/mlx4/alloc.c:162: error: ‘VM_MAP’ undeclared (first use in this function) drivers/net/ml

Re: [PATCH][AX25] ax25_route: make ax25_route_lock BH safe

2008-02-12 Thread Jarek Poplawski
On Tue, Feb 12, 2008 at 09:43:26AM +0100, Jann Traschewski wrote: > Applied on 2.6.24.2 and up without any problems/warnings since 12 hours. > Thanks, > Jann Thanks Jann, too! BTW, I hope maybe until tomorrow I'll figure out something about those earlier two AX25 testing patches. Regards, Jarek

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-12 Thread Jarek Poplawski
On 12-02-2008 02:16, David Miller wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Mon, 11 Feb 2008 16:59:54 -0800 > > linux-kernel added to CC:, any change to generic kernel infrastructure > should be posted there > >> Eliminate warnings when rcu_assign_pointer is used with unsigned

Re: [PATCH][AX25] ax25_route: make ax25_route_lock BH safe

2008-02-12 Thread Jann Traschewski
Applied on 2.6.24.2 and up without any problems/warnings since 12 hours. Thanks, Jann > -Ursprüngliche Nachricht- > Von: Jarek Poplawski [mailto:[EMAIL PROTECTED] > Gesendet: Montag, 11. Februar 2008 13:43 > An: David Miller > Cc: Jann Traschewski; Bernard Pidoux F6BVP; Ralf Baechle > DL

[PATCH] trivial: fix alignment of IP-Config output

2008-02-12 Thread Uwe Kleine-König
make the intended lines aligned in the output (not in the code) Signed-off-by: Uwe Kleine-König <[EMAIL PROTECTED]> --- net/ipv4/ipconfig.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c index a52b585..10013cc 100644 --- a/net/

Open bugs

2008-02-12 Thread Natalie Protasevich
Hello, The bugs listed are over a month old, and haven't been addressed yet. It would be appreciated if corresponding maintainers identify whether the bugs have been fixed, or need to be worked on, and take appropriate action. In most cases, reporters are standing by and ready to provide informat

Re: [PATCH] [IPV4]: Remove warning in node_set_parent.

2008-02-12 Thread Denis V. Lunev
ugly :), but Acked-by: Denis V. Lunev <[EMAIL PROTECTED]> On Mon, 2008-02-11 at 11:48 -0800, Stephen Hemminger wrote: > On Mon, 11 Feb 2008 11:47:17 +0300 > "Denis V. Lunev" <[EMAIL PROTECTED]> wrote: > > > net/ipv4/fib_trie.c: In function 'node_set_parent': > > net/ipv4/fib_trie.c:184: warning: