Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-22 Thread Jiri Pirko
Fri, May 22, 2015 at 02:11:40AM CEST, t...@herbertland.com wrote: This patch adds full IPv6 addresses into flow_keys and uses them as input to the flow hash function. The implementation supports either IPv4 or IPv6 addresses in a union, and selector is used to determine how may words to input to

Re: [PATCH v4 net-next 06/11] net: Add keys for TIPC address

2015-05-22 Thread Jiri Pirko
Fri, May 22, 2015 at 02:11:41AM CEST, t...@herbertland.com wrote: Add a new flow key for TIPC addresses. Signed-off-by: Tom Herbert t...@herbertland.com --- include/net/flow_dissector.h | 10 ++ net/core/flow_dissector.c| 20 ++-- 2 files changed, 24 insertions(+), 6

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
On Fri, May 22, 2015 at 09:43:28AM +0200, Johannes Berg wrote: Oops, sorry, of course - I was running in a VM :) Thanks! Does this patch on top help? diff --git a/net/mac80211/aes_gmac.c b/net/mac80211/aes_gmac.c index 7eee32b..133be53 100644 --- a/net/mac80211/aes_gmac.c +++

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
On Fri, May 22, 2015 at 10:18:03AM +0200, Johannes Berg wrote: Yep, that fixes things. Great I will respin the patches. Thanks, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To

[v2 PATCH 8/13] esp4: Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. The IV generation is also now carried out through normal AEAD methods. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- net/ipv4/esp4.c | 197

[v2 PATCH 9/13] esp6: Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. The IV generation is also now carried out through normal AEAD methods. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- net/ipv6/esp6.c | 197

[v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- crypto/algif_aead.c | 61 ++-- 1 file changed, 36

[v2 PATCH 12/13] crypto: tcrypt - Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- crypto/tcrypt.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git

[v2 PATCH 4/13] crypto: aead - Do not set cra_type for new style instances

2015-05-22 Thread Herbert Xu
The function aead_geniv_alloc currently sets cra_type even for new style instances. This is unnecessary and may hide bugs such as when our caller uses crypto_register_instance instead of the correct aead_register_instance. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- crypto/aead.c

[v2 PATCH 6/13] xfrm: Add IV generator information to xfrm_algo_desc

2015-05-22 Thread Herbert Xu
This patch adds IV generator information for each AEAD and block cipher to xfrm_algo_desc. This will be used to access the new AEAD interface. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- include/net/xfrm.h |2 ++ net/xfrm/xfrm_algo.c | 16 2 files

[v2 PATCH 11/13] mac80211: Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. Tested-by: Johannes Berg johan...@sipsolutions.net Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- net/mac80211/aes_ccm.c | 30

[v2 PATCH 5/13] crypto: testmgr - Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- crypto/testmgr.c | 84 +++ 1 file changed, 48

Re: [PATCH v4 net-next 03/11] net: Remove superfluous setting of key_basic

2015-05-22 Thread Jiri Pirko
Fri, May 22, 2015 at 02:11:38AM CEST, t...@herbertland.com wrote: key_basic is set twice in __skb_flow_dissect which seems unnecessary. Remove second one. Signed-off-by: Tom Herbert t...@herbertland.com I have the same patch in my queue :) Acked-by: Jiri Pirko j...@resnulli.us -- To unsubscribe

Re: [PATCH v4 net-next 02/11] mpls: Add definition for IPPROTO_MPLS

2015-05-22 Thread Jiri Pirko
Fri, May 22, 2015 at 02:11:37AM CEST, t...@herbertland.com wrote: Add uapi define for MPLS over IP. Signed-off-by: Tom Herbert t...@herbertland.com Acked-by: Jiri Pirko j...@resnulli.us -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH v4 net-next 01/11] net: Simplify GRE case in flow_dissector

2015-05-22 Thread Jiri Pirko
Fri, May 22, 2015 at 02:11:36AM CEST, t...@herbertland.com wrote: Do break when we see routing flag or a non-zero version number in GRE header. Signed-off-by: Tom Herbert t...@herbertland.com Acked-by: Jiri Pirko j...@resnulli.us -- To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH v4 net-next 04/11] net: Get skb hash over flow_keys structure

2015-05-22 Thread Jiri Pirko
Fri, May 22, 2015 at 02:11:39AM CEST, t...@herbertland.com wrote: This patch changes flow hashing to use jhash2 over the flow_keys structure instead just doing jhash_3words over src, dst, and ports. This method will allow us take more input into the hashing function so that we can include full

Re: [PATCH 5/7] esp6: Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
On Fri, May 22, 2015 at 09:16:08AM +0200, Stephan Mueller wrote: Thanks for the pointer, but there I do not really see the functionality I am looking for. I see patch 10/16 which seems to indicate that the geniv logic is now to be invoked as a normal AEAD cipher. I yet fail to see where

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-05-22 Thread Johannes Berg
On Fri, 2015-05-22 at 15:41 +0800, Herbert Xu wrote: Did this have a code section at the end? Without it it's difficult to pin-point the crash because your compiler produces different output than mine. Oops, sorry, of course - I was running in a VM :) [ 26.143579] BUG: unable to handle

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-22 Thread Arend van Spriel
On 05/22/15 09:37, Arend van Spriel wrote: On 05/22/15 02:21, Laura Abbott wrote: On 05/21/2015 08:26 AM, Alan Stern wrote: On Thu, 21 May 2015, Marcel Holtmann wrote: Hi Alan, Then avoiding the failed firmware is no solution, indeed. If it's a new probe, it should be never executed during

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
On Fri, May 22, 2015 at 09:32:28AM +0200, Johannes Berg wrote: The CCM and GCM part seems to work, but GMAC causes a kernel crash: Awesome :) [ 26.143579] BUG: unable to handle kernel NULL pointer dereference at (null) [ 26.144406] IP: [811d9e7d]

[v2 PATCH 1/13] crypto: aead - Add crypto_aead_alg_ivsize/maxauthsize

2015-05-22 Thread Herbert Xu
AEAD algorithm implementors need to figure out a given algorithm's IV size and maximum authentication size. During the transition this is difficult to do as an algorithm could be new style or old style. This patch creates two helpers to make this easier. Signed-off-by: Herbert Xu

[v2 PATCH 3/13] crypto: echainiv - Use aead_register_instance

2015-05-22 Thread Herbert Xu
New style AEAD instances must use aead_register_instance. This worked by chance because aead_geniv_alloc is still setting things the old way. This patch converts the template over to the create model where we are responsible for instance registration so that we can call the correct function.

Re: e1000e pci_disable_link_state_locked() issues

2015-05-22 Thread Yijing Wang
On 2015/5/21 3:47, Bjorn Helgaas wrote: I think we have some issues with the e1000e usage of pci_disable_link_state_locked(), which Yinghai added with 9f728f53dd70 (PCI/e1000e: Add and use pci_disable_link_state_locked()). That fixed an AER deadlock in the following path, where pci_bus_sem

Re: [PATCH 5/7] esp6: Switch to new AEAD interface

2015-05-22 Thread Stephan Mueller
Am Freitag, 22. Mai 2015, 14:45:54 schrieb Herbert Xu: Hi Herbert, On Fri, May 22, 2015 at 08:40:25AM +0200, Stephan Mueller wrote: If I may ask, where in your initial patch set is now decided that the IV generator is used (i.e. so that the givcrypt API is not needed any more)? Please see

[v2 PATCH 0/13] crypto: Convert all AEAD users to new interface

2015-05-22 Thread Herbert Xu
Hi: This is the second version of the series. The first four patches make the new IV generators use aead_register_instance instead of the obsolete crypto_register_instance. I've also added two more conversions for tcrypt and algif_aead. Original description: This series of patches convert all

[patch net-next] flow_dissector: do not break if ports are not needed in flowlabel

2015-05-22 Thread Jiri Pirko
This restored previous behaviour. If caller does not want ports to be filled, we should not break. Fixes: 06635a35d13d (flow_dissect: use programable dissector in skb_flow_dissect and friends) Signed-off-by: Jiri Pirko j...@resnulli.us --- net/core/flow_dissector.c | 14 +++--- 1 file

Re: [PATCH 5/7] esp6: Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
On Fri, May 22, 2015 at 08:40:25AM +0200, Stephan Mueller wrote: If I may ask, where in your initial patch set is now decided that the IV generator is used (i.e. so that the givcrypt API is not needed any more)? Please see

Re: e1000e pci_disable_link_state_locked() issues

2015-05-22 Thread Yijing Wang
On 2015/5/21 3:47, Bjorn Helgaas wrote: I think we have some issues with the e1000e usage of pci_disable_link_state_locked(), which Yinghai added with 9f728f53dd70 (PCI/e1000e: Add and use pci_disable_link_state_locked()). That fixed an AER deadlock in the following path, where pci_bus_sem

Re: [PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys

2015-05-22 Thread Jiri Pirko
Fri, May 22, 2015 at 02:11:44AM CEST, t...@herbertland.com wrote: In flow_dissector set the flow label in flow_keys for IPv6. This also removes the shortcircuiting of flow dissection when a non-zero label is present, the flow label can be considered to provide additional entropy for a hash.

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-05-22 Thread Johannes Berg
On Thu, 2015-05-21 at 18:44 +0800, Herbert Xu wrote: This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. The CCM and GCM part seems to work, but GMAC causes a kernel crash: [ 26.143579] BUG: unable to handle kernel

Re: [PATCH v4 net-next 07/11] net: Get rid of IPv6 hash addresses flow keys

2015-05-22 Thread Jiri Pirko
Fri, May 22, 2015 at 02:11:42AM CEST, t...@herbertland.com wrote: We don't need to return the IPv6 address hash as part of flow keys. In general, using the IPv6 address hash is risky in a hash value since the underlying use of xor provides no entropy. If someone really needs the hash value they

[v2 PATCH 10/13] mac802154: Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- net/mac802154/llsec.c | 41 ++--- 1 file changed, 14 insertions(+), 27

Re: [PATCH 5/7] esp6: Switch to new AEAD interface

2015-05-22 Thread Stephan Mueller
Am Donnerstag, 21. Mai 2015, 18:44:03 schrieb Herbert Xu: Hi Herbert, - aead_givcrypt_set_callback(req, 0, esp_output_done, skb); - aead_givcrypt_set_crypt(req, sg, sg, clen, iv); - aead_givcrypt_set_assoc(req, asg, assoclen); - aead_givcrypt_set_giv(req, esph-enc_data, -

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-22 Thread Arend van Spriel
On 05/22/15 02:21, Laura Abbott wrote: On 05/21/2015 08:26 AM, Alan Stern wrote: On Thu, 21 May 2015, Marcel Holtmann wrote: Hi Alan, Then avoiding the failed firmware is no solution, indeed. If it's a new probe, it should be never executed during resume. Can you expand this comment?

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-05-22 Thread Johannes Berg
On Fri, 2015-05-22 at 16:05 +0800, Herbert Xu wrote: On Fri, May 22, 2015 at 09:43:28AM +0200, Johannes Berg wrote: Oops, sorry, of course - I was running in a VM :) Thanks! Does this patch on top help? Yep, that fixes things. johannes -- To unsubscribe from this list: send the line

Re: [PATCH v4 net-next 11/11] mpls: Add MPLS entropy label in flow_keys

2015-05-22 Thread Jiri Pirko
Fri, May 22, 2015 at 02:11:46AM CEST, t...@herbertland.com wrote: In flow dissector if an MPLS header contains an entropy label this is saved in the new keyid field of flow_keys. The entropy label is then represented in the flow hash function input. Signed-off-by: Tom Herbert t...@herbertland.com

[v2 PATCH 7/13] ipsec: Add IV generator information to xfrm_state

2015-05-22 Thread Herbert Xu
This patch adds IV generator information to xfrm_state. This is currently obtained from our own list of algorithm descriptions. Signed-off-by: Herbert Xu herb...@gondor.apana.org.au --- include/net/xfrm.h |1 + net/key/af_key.c |1 + net/xfrm/xfrm_user.c | 40

[v2 PATCH 2/13] crypto: seqiv - Use aead_register_instance

2015-05-22 Thread Herbert Xu
New style AEAD instances must use aead_register_instance. This worked by chance because aead_geniv_alloc is still setting things the old way. This patch converts the template over to the create model where we are responsible for instance registration so that we can call the correct function.

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-22 Thread Alexander Holler
Am 08.05.2015 um 14:02 schrieb Eric W. Biederman: So I am dense. I have read through the patches and I don't see where you tag packets from other network namespaces with a network namespace id. Me too, I've recently written a little tool called snetmanmon (source is available at github) to

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-22 Thread Alexander Holler
Am 22.05.2015 um 23:19 schrieb Eric W. Biederman: Alexander Holler hol...@ahsoftware.de writes: Am 08.05.2015 um 14:02 schrieb Eric W. Biederman: So I am dense. I have read through the patches and I don't see where you tag packets from other network namespaces with a network namespace id.

[GIT] Networking

2015-05-22 Thread David Miller
1) Don't leak ipvs-sysctl_tbl, from Tommi Rentala. 2) Fix neighbour table entry leak in rocker driver, from Ying Xue. 3) Do not emit bonding notifications for unregistered interfaces, from Nicolas Dichtel. 4) Set ipv6 flow label properly when in TIME_WAIT state, from Florent Fourcot. 5)

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-22 Thread Eric W. Biederman
Alexander Holler hol...@ahsoftware.de writes: Am 08.05.2015 um 14:02 schrieb Eric W. Biederman: So I am dense. I have read through the patches and I don't see where you tag packets from other network namespaces with a network namespace id. Me too, You need to use recvmsg, and then parse

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-22 Thread Alexander Holler
Am 22.05.2015 um 23:29 schrieb Cong Wang: On Fri, May 22, 2015 at 2:12 PM, Alexander Holler hol...@ahsoftware.de wrote: Bridge doesn't have an underlying link, so no LINK_NETNSID. LINK_NETNSID is only added when its underlying link is in a different netns. I'm using link similiar as

[PATCH 0/2] crypto: Use tmpl-create when registering geniv

2015-05-22 Thread Herbert Xu
On Fri, May 22, 2015 at 11:04:39PM +0200, Stephan Mueller wrote: Am Freitag, 22. Mai 2015, 22:59:34 schrieb Stephan Mueller: Hi Stephan, Am Freitag, 22. Mai 2015, 16:31:04 schrieb Herbert Xu: Hi Herbert, This patch makes use of the new AEAD interface which uses a single SG

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
On Fri, May 22, 2015 at 11:04:39PM +0200, Stephan Mueller wrote: Note, gcm(aes) looks good. Only rfc4106(gcm(aes)) causes the crash. Actually it looks like the culprit hasn't been merged yet so I'll just respin the series. Anyway, this patch should fix your crash: diff --git

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Suravee Suthikulanit
Not sure if this went out earlier. So I am resending. On 5/22/15 16:56, Rafael J. Wysocki wrote: diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c index 39c485b..b9657af 100644 --- a/drivers/acpi/glue.c +++ b/drivers/acpi/glue.c @@ -13,6 +13,7 @@ #include linux/slab.h #include

[PATCH 1/2] ethtool: Clear the command data structure before sending requests

2015-05-22 Thread Arun Parameswaran
The 'ethtool' is not clearing the command data structure in the do_gset() do_sset() API's while sending commands to get/set parametres. This used to work since the Kernel clears the data structure (which was a bug and is being fixed). This patch adds a 'memset' to the do_gset() do_sset() to

[PATCH 0/2] Fix couple of issues with 'ethtool' get/set API's

2015-05-22 Thread Arun Parameswaran
Hi, The patch fixes 2 issues with 'ethtool' getting/setting parametres in the do_gset() do_sset() API's. I have pushed a patch to the Kernel to fix an issue in the handling of the 'ethtool' commands which got accepted. This Kernel patch was based on Linux v4.1-rc4 and is available in:

[PATCH 2/2] ethtool: Fix an issue with handling 'phyad' while updating settings

2015-05-22 Thread Arun Parameswaran
When using the 'ethtool' to set PHY1's settings, the 'ethtool' seems to do the 'get' settings with incorrect PHY ID and then apply the new settings on it. For example when using the command, to change PHY1's speed, 'ethtool -s eth0 phyad 1 speed 100', the 'ethtool' will end up querying PHY0's

Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Mark Salyzyn
On 05/22/2015 11:16 AM, Hannes Frederic Sowa wrote: On Fri, May 22, 2015, at 18:24, Mark Salyzyn wrote: On 05/22/2015 08:35 AM, Hannes Frederic Sowa wrote: I still wonder if we need to actually recheck the condition and not simply break out of unix_stream_data_wait: We return to the

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-22 Thread Stephan Mueller
Am Freitag, 22. Mai 2015, 16:31:04 schrieb Herbert Xu: Hi Herbert, This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. Using an up-to date tree with the full set of patches of this patch set, I get the following

[PATCH net-next v1 0/3] amd-xgbe: AMD XGBE driver updates 2015-05-22

2015-05-22 Thread Tom Lendacky
The following patches are included in this driver update series: - Retrieve and set an additional hardware feature setting - Fix the initial mode/speed determination when auto-negotiation is disabled - Add additional netif_dbg support to the driver This patch series is based on net-next. ---

[PATCH net-next v1 3/3] amd-xgbe: Add more netif_dbg output to the driver

2015-05-22 Thread Tom Lendacky
Change more netdev_dbg statements over to netif_dbg and add some new netif_dbg statements to the driver. Signed-off-by: Tom Lendacky thomas.lenda...@amd.com --- drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 68 ++--- 1 file changed, 62 insertions(+), 6 deletions(-) diff

[PATCH net-next v1 2/3] amd-xgbe: Fix initial mode when auto-negotiation is disabled

2015-05-22 Thread Tom Lendacky
When the ethtool command is used to set the speed of the device while the device is down, the check to set the initial mode may fail when the device is brought up, causing failure to bring the device up. Update the code to set the initial mode based on the desired speed if auto-negotiation is

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Rafael J. Wysocki
On Wednesday, May 20, 2015 05:09:14 PM Suravee Suthikulpanit wrote: This patch implements support for ACPI _CCA object, which is introduced in ACPIv5.1, can be used for specifying device DMA coherency attribute. The parsing logic traverses device namespace to parse coherency information, and

[PATCH net-next v1 1/3] amd-xgbe: Add setting of a missing hardware feature

2015-05-22 Thread Tom Lendacky
The device private data structure contains all the defined hardware features for the device. However one of the features is not set. Even though the feature is not currently used, set it to avoid future issues of the feature being checked thinking it has been properly set. Signed-off-by: Tom

[PATCH net-next] test_bpf: add more eBPF jump torture cases

2015-05-22 Thread Daniel Borkmann
Add two more eBPF test cases for JITs, i.e. the second one revealed a bug in the x86_64 JIT compiler, where only an int3 filled image from the allocator was emitted and later wrongly set by the compiler as the bpf_func program code since optimization pass boundary was surpassed w/o actually

Re: [PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys

2015-05-22 Thread Tom Herbert
On Fri, May 22, 2015 at 8:22 AM, Jiri Pirko j...@resnulli.us wrote: Fri, May 22, 2015 at 05:14:21PM CEST, t...@herbertland.com wrote: On Fri, May 22, 2015 at 1:14 AM, Jiri Pirko j...@resnulli.us wrote: Fri, May 22, 2015 at 02:11:44AM CEST, t...@herbertland.com wrote: In flow_dissector set the

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-22 Thread Alexander Holler
Am 22.05.2015 um 23:04 schrieb Cong Wang: On Fri, May 22, 2015 at 1:50 PM, Alexander Holler hol...@ahsoftware.de wrote: Am 08.05.2015 um 14:02 schrieb Eric W. Biederman: So I am dense. I have read through the patches and I don't see where you tag packets from other network namespaces with a

Re: [PATCH net] net: phy: bcm7xxx: Fix 7425 PHY ID and flags

2015-05-22 Thread Petri Gynther
On Fri, May 22, 2015 at 2:07 PM, Florian Fainelli f.faine...@gmail.com wrote: While adding support for 7425 PHY in the 7xxx PHY driver, the ID that was used was actually coming from an external PHY: a BCM5461x. Fix this by using the proper ID for the internal 7425 PHY and set the

[PATCH net] net: phy: bcm7xxx: Fix 7425 PHY ID and flags

2015-05-22 Thread Florian Fainelli
While adding support for 7425 PHY in the 7xxx PHY driver, the ID that was used was actually coming from an external PHY: a BCM5461x. Fix this by using the proper ID for the internal 7425 PHY and set the PHY_IS_INTERNAL flag, otherwise consumers of this PHY driver would not be able to properly

Re: [PATCH net] x86: bpf_jit: fix compilation of large bpf programs

2015-05-22 Thread Daniel Borkmann
On 05/23/2015 12:42 AM, Alexei Starovoitov wrote: x86 has variable length encoding. x86 JIT compiler is trying to pick the shortest encoding for given bpf instruction. While doing so the jump targets are changing, so JIT is doing multiple passes over the program. Typical program needs 3 passes.

Re: [PATCH -next, V3 0/2] net: force refragmentation for DF reassembed skbs

2015-05-22 Thread Hannes Frederic Sowa
On Fri, May 22, 2015, at 21:03, David Miller wrote: From: Florian Westphal f...@strlen.de Date: Fri, 22 May 2015 16:32:49 +0200 IP (ttl 64, id 12345, offset 0, flags [+, DF], proto UDP (17), length 1204) 192.168.7.1.42 10.23.42.2.42: UDP, length 1400 IP (ttl 64, id 12345, offset

Re: [PATCH 1/1] net: core: 'ethtool' issue with querying phy settings

2015-05-22 Thread David Miller
From: Arun Parameswaran apara...@broadcom.com Date: Wed, 20 May 2015 14:35:30 -0700 When trying to configure the settings for PHY1, using commands like 'ethtool -s eth0 phyad 1 speed 100', the 'ethtool' seems to modify other settings apart from the speed of the PHY1, in the above case. The

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-22 Thread Stephan Mueller
Am Freitag, 22. Mai 2015, 22:59:34 schrieb Stephan Mueller: Hi Stephan, Am Freitag, 22. Mai 2015, 16:31:04 schrieb Herbert Xu: Hi Herbert, This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. Using an up-to

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-22 Thread Cong Wang
On Fri, May 22, 2015 at 1:50 PM, Alexander Holler hol...@ahsoftware.de wrote: Am 08.05.2015 um 14:02 schrieb Eric W. Biederman: So I am dense. I have read through the patches and I don't see where you tag packets from other network namespaces with a network namespace id. Me too, I've

Re: [PATCH net-next v2 0/7] netns: ease netlink use with a lot of netns

2015-05-22 Thread Cong Wang
On Fri, May 22, 2015 at 2:12 PM, Alexander Holler hol...@ahsoftware.de wrote: Bridge doesn't have an underlying link, so no LINK_NETNSID. LINK_NETNSID is only added when its underlying link is in a different netns. I'm using link similiar as interface. Maybe I've no idea what the attribute

[PATCH net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

2015-05-22 Thread Neil McKee
If new optional attribute OVS_USERSPACE_ATTR_ACTIONS is added to an OVS_ACTION_ATTR_USERSPACE action, then include the datapath actions in the upcall. This Directly associates the sampled packet with the path it takes through the virtual switch. Path information currently includes mangling,

[PATCH net] x86: bpf_jit: fix compilation of large bpf programs

2015-05-22 Thread Alexei Starovoitov
x86 has variable length encoding. x86 JIT compiler is trying to pick the shortest encoding for given bpf instruction. While doing so the jump targets are changing, so JIT is doing multiple passes over the program. Typical program needs 3 passes. Some very short programs converge with 2 passes.

Re: [PATCH net-next] test_bpf: add more eBPF jump torture cases

2015-05-22 Thread Alexei Starovoitov
On 5/22/15 4:10 PM, Daniel Borkmann wrote: Add two more eBPF test cases for JITs, i.e. the second one revealed a bug in the x86_64 JIT compiler, where only an int3 filled image from the allocator was emitted and later wrongly set by the compiler as the bpf_func program code since optimization

[PATCH] net: stmmac: create one debugfs dir per net-device

2015-05-22 Thread Mathieu Olivari
stmmac DebugFS entries are currently global to the driver. As a result, having more than one stmmac device in the system creates the following error: * ERROR stmmaceth, debugfs create directory failed * stmmac_hw_setup: failed debugFS registration This also results in being able to access the

[PATCH net-next v5 0/2] Adding support for Cavium ThunderX network controller

2015-05-22 Thread Aleksey Makarov
This patchset adds support for the Cavium ThunderX network controller. changes in v5: * __packed were removed. now we rely on C language ABI * nic_dbg() - netdev_dbg() * fixes for a typo, constant spelling and using BIT_ULL * use print_hex_dump() * unnecessary conditions in a long if()

[PATCH v2 net-next] openvswitch: include datapath actions with sampled-packet upcall to userspace

2015-05-22 Thread Neil McKee
If new optional attribute OVS_USERSPACE_ATTR_ACTIONS is added to an OVS_ACTION_ATTR_USERSPACE action, then include the datapath actions in the upcall. This Directly associates the sampled packet with the path it takes through the virtual switch. Path information currently includes mangling,

Re: [PATCH net-next 1/3] cxgb4: Add support for loopback between VI of same port

2015-05-22 Thread Casey Leedom
Okay, really: I’m not arguing for module parameters. I’m agreeing with you 100%. I’m not trying to be snarky or back you into admitting that there are some times when a module parameter is needed. I’m not being sneaky, etc. I’m really just asking a mechanism question. It is, on the other

[PATCH net-next v5 05/11] ipv6: Only create RTF_CACHE routes after encountering pmtu exception

2015-05-22 Thread Martin KaFai Lau
This patch creates a RTF_CACHE routes only after encountering a pmtu exception. After ip6_rt_update_pmtu() has inserted the RTF_CACHE route to the fib6 tree, the rt-rt6i_node-fn_sernum is bumped which will fail the ip6_dst_check() and trigger a relookup. Signed-off-by: Martin KaFai Lau

[PATCH net-next v5 03/11] ipv6: Remove external dependency on rt6i_gateway and RTF_ANYCAST

2015-05-22 Thread Martin KaFai Lau
When creating a RTF_CACHE route, RTF_ANYCAST is set based on rt6i_dst. Also, rt6i_gateway is always set to the nexthop while the nexthop could be a gateway or the rt6i_dst.addr. After removing the rt6i_dst and rt6i_src dependency in the last patch, we also need to stop the caller from depending

[PATCH net-next v5 07/11] ipv6: Set FLOWI_FLAG_KNOWN_NH at flowi6_flags

2015-05-22 Thread Martin KaFai Lau
The neighbor look-up used to depend on the rt6i_gateway (if there is a gateway) or the rt6i_dst (if it is a RTF_CACHE clone) as the nexthop address. Note that rt6i_dst is set to fl6-daddr for the RTF_CACHE clone where fl6-daddr is the one used to do the route look-up. Now, we only create

[PATCH net-next v5 11/11] ipv6: Create percpu rt6_info

2015-05-22 Thread Martin KaFai Lau
After the patch 'ipv6: Only create RTF_CACHE routes after encountering pmtu exception', we need to compensate the performance hit (bouncing dst-__refcnt). Signed-off-by: Martin KaFai Lau ka...@fb.com Cc: Hannes Frederic Sowa han...@stressinduktion.org Cc: Steffen Klassert

[PATCH net-next v5 06/11] ipv6: Add rt6_get_cookie() function

2015-05-22 Thread Martin KaFai Lau
Instead of doing the rt6-rt6i_node check whenever we need to get the route's cookie. Refactor it into rt6_get_cookie(). It is a prep work to handle FLOWI_FLAG_KNOWN_NH and also percpu rt6_info later. Signed-off-by: Martin KaFai Lau ka...@fb.com Cc: Hannes Frederic Sowa han...@stressinduktion.org

[PATCH net-next v5 01/11] ipv6: Clean up ipv6_select_ident() and ip6_fragment()

2015-05-22 Thread Martin KaFai Lau
This patch changes the ipv6_select_ident() signature to return a fragment id instead of taking a whole frag_hdr as a param to only set the frag_hdr-identification. It also cleans up ip6_fragment() to obtain the fragment id at the beginning instead of using multiple if later to check fragment id

[PATCH net-next v5 09/11] ipv6: Keep track of DST_NOCACHE routes in case of iface down/unregister

2015-05-22 Thread Martin KaFai Lau
This patch keeps track of the DST_NOCACHE routes in a list and replaces its dev with loopback during the iface down/unregister event. Signed-off-by: Martin KaFai Lau ka...@fb.com Cc: Hannes Frederic Sowa han...@stressinduktion.org Cc: Steffen Klassert steffen.klass...@secunet.com Cc: Julian

[PATCH net-next v5 10/11] ipv6: Break up ip6_rt_copy()

2015-05-22 Thread Martin KaFai Lau
This patch breaks up ip6_rt_copy() into ip6_rt_copy_init() and ip6_rt_cache_alloc(). In the later patch, we need to create a percpu rt6_info copy. Hence, refactor the common rt6_info init codes to ip6_rt_copy_init(). Signed-off-by: Martin KaFai Lau ka...@fb.com Cc: Hannes Frederic Sowa

[PATCH net-next v5 02/11] ipv6: Remove external dependency on rt6i_dst and rt6i_src

2015-05-22 Thread Martin KaFai Lau
This patch removes the assumptions that the returned rt is always a RTF_CACHE entry with the rt6i_dst and rt6i_src containing the destination and source address. The dst and src can be recovered from the calling site. We may consider to rename (rt6i_dst, rt6i_src) to (rt6i_key_dst, rt6i_key_src)

[PATCH net-next v5 08/11] ipv6: Create RTF_CACHE clone when FLOWI_FLAG_KNOWN_NH is set

2015-05-22 Thread Martin KaFai Lau
This patch always creates RTF_CACHE clone with DST_NOCACHE when FLOWI_FLAG_KNOWN_NH is set so that the rt6i_dst is set to the fl6-daddr. Signed-off-by: Martin KaFai Lau ka...@fb.com Acked-by: Julian Anastasov j...@ssi.bg Tested-by: Julian Anastasov j...@ssi.bg Cc: Hannes Frederic Sowa

[PATCH net-next v5 00/11] ipv6: Only create RTF_CACHE route after encountering pmtu exception

2015-05-22 Thread Martin KaFai Lau
v4 - v5: - Patch 1 is new. Clean up the ipv6_select_ident() and ip6_fragment(). - Further simplify the newly added rt6_get_pcpu_route(). If there is a 'prev' after cmpxchg, return prev instead of the newly created percpu clone. v3 - v4: - Patch 8 is new. It keeps track of the DST_NOCACHE

[PATCH net-next v5 04/11] ipv6: Combine rt6_alloc_cow and rt6_alloc_clone

2015-05-22 Thread Martin KaFai Lau
A prep work for creating RTF_CACHE on exception only. After this patch, the same condition (rt-rt6i_flags (RTF_NONEXTHOP | RTF_GATEWAY)) is checked twice. This redundancy will be removed in the later patch. Signed-off-by: Martin KaFai Lau ka...@fb.com Cc: Hannes Frederic Sowa

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Suravee Suthikulanit
On 5/22/2015 8:25 PM, Rafael J. Wysocki wrote: On Friday, May 22, 2015 07:15:17 PM Suravee Suthikulanit wrote: On 5/22/2015 6:05 PM, Rafael J. Wysocki wrote: On Friday, May 22, 2015 05:24:15 PM Suravee Suthikulanit wrote: Not sure if this went out earlier. So I am resending. On 5/22/15

[PATCH] mlx4_core: Fix fallback from MSI-X to INTx

2015-05-22 Thread Benjamin Poirier
The test in mlx4_load_one() to remove MLX4_FLAG_MSI_X expects mlx4_NOP() to fail with -EBUSY. It is also necessary to avoid the reset since the device is not fully reinitialized before calling mlx4_start_hca() a second time. Note that this will also affect mlx4_test_interrupts(), the only other

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Suravee Suthikulanit
On 5/22/2015 6:05 PM, Rafael J. Wysocki wrote: On Friday, May 22, 2015 05:24:15 PM Suravee Suthikulanit wrote: Not sure if this went out earlier. So I am resending. On 5/22/15 16:56, Rafael J. Wysocki wrote: diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c index 39c485b..b9657af 100644

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Rafael J. Wysocki
On Friday, May 22, 2015 07:15:17 PM Suravee Suthikulanit wrote: On 5/22/2015 6:05 PM, Rafael J. Wysocki wrote: On Friday, May 22, 2015 05:24:15 PM Suravee Suthikulanit wrote: Not sure if this went out earlier. So I am resending. On 5/22/15 16:56, Rafael J. Wysocki wrote: diff --git

[PATCH net-next v5 1/2] pci: Add Cavium PCI vendor id

2015-05-22 Thread Aleksey Makarov
From: Sunil Goutham sgout...@cavium.com This vendor id will be used by network (vNIC), USB (xHCI), SATA (AHCI), GPIO, I2C, MMC and maybe other drivers for ThunderX SoC. Acked-by: Bjorn Helgaas bhelg...@google.com Signed-off-by: Sunil Goutham sgout...@cavium.com Signed-off-by: Aleksey Makarov

[PATCHv3 net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-22 Thread Linus Lüssing
Network managers like netifd (used in OpenWRT for instance) try to configure interface options after creation but before setting the interface up. Unfortunately the sysfs / bridge currently only allows to configure the hash_max and multicast_router options when the bridge interface is up. But

Re: [V5 PATCH 1/5] ACPI / scan: Parse _CCA and setup device coherency

2015-05-22 Thread Rafael J. Wysocki
On Friday, May 22, 2015 05:24:15 PM Suravee Suthikulanit wrote: Not sure if this went out earlier. So I am resending. On 5/22/15 16:56, Rafael J. Wysocki wrote: diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c index 39c485b..b9657af 100644 --- a/drivers/acpi/glue.c +++

Re: [RFC PATCH 03/13] xen-netback: implement TX persistent grants

2015-05-22 Thread Joao Martins
On 19 May 2015, at 17:23, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:27PM +0200, Joao Martins wrote: Introduces persistent grants for TX path which follows similar code path as the grant mapping. It starts by checking if there's a persistent grant available for header

Re: [RFC PATCH 02/13] xen-netback: xenbus feature persistent support

2015-05-22 Thread Joao Martins
On 19 May 2015, at 17:19, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:26PM +0200, Joao Martins wrote: Checks for feature-persistent that indicates persistent grants support. Adds max_persistent_grants module param that specifies the max number of persistent grants, which

Re: [RFC PATCH 04/13] xen-netback: implement RX persistent grants

2015-05-22 Thread Joao Martins
On 19 May 2015, at 17:32, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:28PM +0200, Joao Martins wrote: It starts by doing a lookup in the tree for a gref. If no persistent grant is found on the tree, it will do grant copy and prepare the grant maps. Finally valides the

Re: net/unix: sk_socket can disappear when state is unlocked

2015-05-22 Thread Hannes Frederic Sowa
On Do, 2015-05-21 at 09:25 -0700, Mark Salyzyn wrote: got a rare NULL pointer dereference in clear_bit Signed-off-by: Mark Salyzyn saly...@android.com --- net/unix/af_unix.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index

Re: [RFC PATCH 00/13] Persistent grant maps for xen net drivers

2015-05-22 Thread Joao Martins
On 19 May 2015, at 17:39, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:24PM +0200, Joao Martins wrote: There have been recently[3] some discussions and issues raised on persistent grants for the block layer, though the numbers above show some significant improvements

Re: [RFC PATCH 06/13] xen-netback: copy buffer on xenvif_start_xmit()

2015-05-22 Thread Joao Martins
On 19 May 2015, at 17:35, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:30PM +0200, Joao Martins wrote: By introducing persistent grants we speed up the RX thread with the decreased copy cost, that leads to a throughput decrease of 20%. It is observed that the rx_queue

[PATCH net] ipv4: fill in table id when replacing a route

2015-05-22 Thread Michal Kubecek
When replacing an IPv4 route, tb_id member of the new fib_alias structure is not set in the replace code path so that the new route is ignored. Fixes: 0ddcf43d5d4a (ipv4: FIB Local/MAIN table collapse) Signed-off-by: Michal Kubecek mkube...@suse.cz --- net/ipv4/fib_trie.c | 1 + 1 file changed,

  1   2   >