Re: [PATCH] fm10k: Fix missing braces after if statement

2015-06-03 Thread David Miller
From: Alexander Duyck Date: Wed, 03 Jun 2015 18:53:17 -0700 > While reviewing the code I noticed that one of the commits added an if > statement followed by a for loop, but the if statement was missing the > braces around the loop. This change corrects the coding style error. > > Signed-off-by:

Re: [PATCH net-next] tcp: double default TSQ output bytes limit

2015-06-03 Thread Eric Dumazet
On Wed, 2015-06-03 at 11:10 +0100, Wei Liu wrote: > Xen virtual network driver has higher latency than a physical NIC. > Having only 128K as limit for TSQ introduced 30% regression in guest > throughput. > > This patch raises the limit to 256K. This reduces the regression to 8%. > This buys us mor

[PATCH net-next] tcp: remove redundant checks

2015-06-03 Thread Eric Dumazet
From: Eric Dumazet tcp_v4_rcv() checks the following before calling tcp_v4_do_rcv(): if (th->doff < sizeof(struct tcphdr) / 4) goto bad_packet; if (!pskb_may_pull(skb, th->doff * 4)) goto discard_it; So following check in tcp_v4_do_rcv() is redundant and "goto csum_err;" is wrong anywa

Re: [PATCH net-next 0/4] switchdev: documentation updates

2015-06-03 Thread David Miller
From: sfel...@gmail.com Date: Wed, 3 Jun 2015 20:43:39 -0700 > Update the switchdev documentation to clarify that for IPV4 FIB object, the > add > op is used for both adding and modifying the FIB entry on the device. > > I found a few other white-space and grammer issues to fix, and to clarify

Re: pull-request: wireless-drivers-next 2015-06-03

2015-06-03 Thread David Miller
From: Kalle Valo Date: Wed, 03 Jun 2015 23:07:47 +0300 > here's a pull request for 4.2. Most notable change here is a new driver > mt7601u for a Mediatek USB Wi-Fi device, for other driver more > information in the signed tag. There's a trivial conflict in iwlwifi > Kconfig help text but otherwis

Re: [PATCH net-next] bpf: introduce bpf_clone_redirect() helper

2015-06-03 Thread Or Gerlitz
On Thu, Jun 4, 2015 at 6:17 AM, David Miller wrote: > From: Alexei Starovoitov > Date: Tue, 2 Jun 2015 16:03:14 -0700 > >> Allow eBPF programs attached to classifier/actions to call >> bpf_clone_redirect(skb, ifindex, flags) helper which will >> mirror or redirect the packet by dynamic ifindex s

Re: [PATCH net-next 0/4] cxgb4: Adds support for various ethtool stats

2015-06-03 Thread David Miller
From: Hariprasad Shenai Date: Wed, 3 Jun 2015 21:04:38 +0530 > This patch series adds the following: > Adds support to dump adapter specific stats in ethtool > Adds support to dump channel stats in ethtool > Adds support to dump loopback port stats in ethtool > Remove wake-on-lan get/set ethtool

Re: [PATCH net-next v2] rocker: move netevent neigh update to processes context

2015-06-03 Thread David Miller
From: sfel...@gmail.com Date: Tue, 2 Jun 2015 20:43:28 -0700 > From: Scott Feldman > > v2: > > Changes based on review: > > - David Miller raise problem with system_wq not > preserving queue order to execution order. To fix, use driver-private > ordered workqueue to preserve ordering of

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-06-03 Thread Haggai Eran
On 04/06/2015 02:48, Jason Gunthorpe wrote: > On Wed, Jun 03, 2015 at 11:07:37PM +0300, Or Gerlitz wrote: > >>> I'm mostly fine with it as an optional capability, similar to macvlan, >>> I just don't see how to cleanly integrate it with RDMA CM and >>> namespaces. And I don't see what RDMA CM is s

Re: [PATCH net-next 4/4] switchdev: documentation: use switchdev_port_obj_xxx for IPv4 FIB add/modify/delete ops

2015-06-03 Thread Jiri Pirko
Thu, Jun 04, 2015 at 05:43:43AM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Clarify in documentation and code that IPV4 FIB add operation is used for >both adding a new FIB entry to the device and for modifying an existing FIB >entry on the device. > >Also, remove left-over references t

Re: [PATCH net-next 1/4] switchdev: documentation: fix longer-than-80-char lines

2015-06-03 Thread Jiri Pirko
Thu, Jun 04, 2015 at 05:43:40AM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Signed-off-by: Scott Feldman Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: [PATCH net-next 2/4] switchdev: documentation: fix grammer error

2015-06-03 Thread Jiri Pirko
Thu, Jun 04, 2015 at 05:43:41AM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Signed-off-by: Scott Feldman Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: [PATCH net-next 3/4] switchdev: documentation: for static FDB ops, use switchdev_port_fdb_xxx ops

2015-06-03 Thread Jiri Pirko
Thu, Jun 04, 2015 at 05:43:42AM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Signed-off-by: Scott Feldman Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-03 Thread Scott Feldman
On Thu, 4 Jun 2015, Toshiaki Makita wrote: Bridge's vlan_filtering is handled in master->op->foo(), not in port->op->foo(). Can't we introduce another switchdev handler that performs MASTER operation instead of calling SELF operation? br_afspec() nbp_vlan_add() netdev_switch_port_vlan_add(

[PATCH net-next 1/2] bpf: make programs see skb->data == L2 for ingress and egress

2015-06-03 Thread Alexei Starovoitov
eBPF programs attached to ingress and egress qdiscs see inconsistent skb->data. For ingress L2 header is already pulled, whereas for egress it's present. This is known to program writers which are currently forced to use BPF_LL_OFF workaround. Since programs don't change skb internal pointers it is

[PATCH net-next 2/2] bpf: allow programs to write to certain skb fields

2015-06-03 Thread Alexei Starovoitov
allow programs read/write skb->mark, tc_index fields and ((struct qdisc_skb_cb *)cb)->data. mark and tc_index are generically useful in TC. cb[0]-cb[4] are primarily used to pass arguments from one program to another called via bpf_tail_call() which can be seen in sockex3_kern.c example. All fiel

[PATCH net-next 3/4] switchdev: documentation: for static FDB ops, use switchdev_port_fdb_xxx ops

2015-06-03 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman --- Documentation/networking/switchdev.txt |4 1 file changed, 4 insertions(+) diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt index 0554b68..00c703c 100644 --- a/Documentation/networking/sw

[PATCH net-next 0/4] switchdev: documentation updates

2015-06-03 Thread sfeldma
From: Scott Feldman Update the switchdev documentation to clarify that for IPV4 FIB object, the add op is used for both adding and modifying the FIB entry on the device. I found a few other white-space and grammer issues to fix, and to clarify the static FDB ops. Scott Feldman (4): switchdev:

[PATCH net-next 4/4] switchdev: documentation: use switchdev_port_obj_xxx for IPv4 FIB add/modify/delete ops

2015-06-03 Thread sfeldma
From: Scott Feldman Clarify in documentation and code that IPV4 FIB add operation is used for both adding a new FIB entry to the device and for modifying an existing FIB entry on the device. Also, remove left-over references to ipv4_fib ops and replace with details on SWITCHDEV_PORT_IPV4_FIB obj

[PATCH net-next 1/4] switchdev: documentation: fix longer-than-80-char lines

2015-06-03 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman --- Documentation/networking/switchdev.txt | 36 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt index 616f892..50

[PATCH net-next 2/4] switchdev: documentation: fix grammer error

2015-06-03 Thread sfeldma
From: Scott Feldman Signed-off-by: Scott Feldman --- Documentation/networking/switchdev.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt index 5061d6e..0554b68 100644 --- a/Documentation/n

Re: pull request: batman-adv 20150603

2015-06-03 Thread David Miller
From: Antonio Quartulli Date: Wed, 3 Jun 2015 16:13:56 +0200 > here you have our second batch of patches intended for net-next. > > In this patchset you won't find any new features, but quite some code > cleanup work, a bunch of code style fixes and also comments corrections > by Markus Pargman

Re: [PATCH] net: tulip: rearrange order of searching for substrings

2015-06-03 Thread David Miller
From: Rasmus Villemoes Date: Wed, 3 Jun 2015 13:44:03 +0200 > Currently, two of the branches are dead code, since an earlier smaller > substring would have been found ("TP" in the "TP_NW" case and either > of "BNC" and "AUI" in the "BNC_AUI" case). Rearrange the strstr() > calls so that the long

Re: [net-next 0/9][pull request] Intel Wired LAN Driver Updates 2015-06-03

2015-06-03 Thread David Miller
From: Jeff Kirsher Date: Wed, 3 Jun 2015 04:27:47 -0700 > This series contains updates to e1000e only. > > Yanir provides 8 fixes and 1 version bump for e1000e. First fix resolves > a possible unit hang if multiple descriptors are available in the rings > during reset or runtime suspend. Fixe

Re: [PATCH net-next] bpf: introduce bpf_clone_redirect() helper

2015-06-03 Thread David Miller
From: Alexei Starovoitov Date: Tue, 2 Jun 2015 16:03:14 -0700 > Allow eBPF programs attached to classifier/actions to call > bpf_clone_redirect(skb, ifindex, flags) helper which will > mirror or redirect the packet by dynamic ifindex selection > from within the program to a target device either

Re: [PATCH net-next 1/3] net/mlx4_core: double free of dev_vfs

2015-06-03 Thread David Miller
From: cls...@linux.vnet.ibm.com Date: Tue, 2 Jun 2015 16:07:23 -0500 > From: Carol L Soto > > If user loads mlx4_core with num_vfs greater than > supported then variable dev->dev_vfs is freed 2 times after unloading the > driver. > > Acked-by: Or Gerlitz > Signed-off-by: Carol L Soto Applie

Re: [PATCH net-next 3/3] net/mlx4_core: fix typo in mlx4_set_vf_mac

2015-06-03 Thread David Miller
From: cls...@linux.vnet.ibm.com Date: Tue, 2 Jun 2015 16:07:25 -0500 > From: Carol Soto > > fix typo in mlx4_set_vf_mac > > Acked-by: Or Gerlitz > Signed-off-by: Carol L Soto Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@

Re: [PATCH net-next 2/3] net/mlx4_core: need to call close fw if alloc icm is called twice

2015-06-03 Thread David Miller
From: cls...@linux.vnet.ibm.com Date: Tue, 2 Jun 2015 16:07:24 -0500 > From: Carol Soto > > If mlx4_enable_sriov is called by adapter without this > feature MLX4_DEV_CAP_FLAG2_SYS_EQS then during this path the function alloc > icm is called twice without freeing the structures from the first ti

Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-03 Thread David Miller
From: Sergei Shtylyov Date: Tue, 02 Jun 2015 23:44:10 +0300 > + /* Received network control queue */ > + if (ris0 & RIS0_FRF1) { > + ravb_write(ndev, ~RIS0_FRF1, RIS0); > + /* Timestamp of network control packets that is based > +

Re: [PATCH v2] net: phy: dp83867: Add TI dp83867 phy

2015-06-03 Thread Florian Fainelli
Le 06/02/15 07:34, Dan Murphy a écrit : > Add support for the TI dp83867 Gigabit ethernet phy > device. > > The DP83867 is a robust, low power, fully featured > Physical Layer transceiver with integrated PMD > sublayers to support 10BASE-T, 100BASE-TX and > 1000BASE-T Ethernet protocols. Sorry fo

Re: [PATCH] drivers/net/ethernet/dec/tulip/uli526x.c: fix misleading indentation in uli526x_timer

2015-06-03 Thread David Miller
From: David Malcolm Date: Tue, 2 Jun 2015 15:31:17 -0400 > This code in drivers/net/ethernet/dec/tulip/uli526x.c > function "uli526x_timer": > > 1086 } else > 1087 if ((tmp_cr12 & 0x3) && db->link_failed) { > [...snip...] > 1109 } > 1110

Re: [PATCH v2] net: phy: dp83867: Add TI dp83867 phy

2015-06-03 Thread David Miller
From: Dan Murphy Date: Tue, 2 Jun 2015 09:34:37 -0500 > Add support for the TI dp83867 Gigabit ethernet phy > device. > > The DP83867 is a robust, low power, fully featured > Physical Layer transceiver with integrated PMD > sublayers to support 10BASE-T, 100BASE-TX and > 1000BASE-T Ethernet prot

Re: [PATCH RESEND net] openvswitch: disable LRO

2015-06-03 Thread David Miller
From: Jiri Benc Date: Tue, 2 Jun 2015 14:36:34 +0200 > Currently, openvswitch tries to disable LRO from the user space. This does > not work correctly when the device added is a vlan interface, though. > Instead of dealing with possibly complex stacked cross name space relations > in the user sp

Re: [PATCH] ethernet: micrel: use time_after_eq

2015-06-03 Thread David Miller
From: Antonio Murdaca Date: Tue, 2 Jun 2015 14:35:52 +0200 > use the time_after_eq macro for jiffies comparison operation > > Signed-off-by: Antonio Murdaca Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@

Re: [PATCH] ipv4: inet_bind: check the addr_len first

2015-06-03 Thread David Miller
From: Denis Kirjanov Date: Tue, 2 Jun 2015 12:08:00 +0300 > Perform the address length check first, before calling > the the proto specific bind() function > > Signed-off-by: Denis Kirjanov This doesn't fix any actual bug, doesn't improve the code in preparation for another change that actual

Re: [PATCH net-next] net/mlx4_core: Fix build failure introduced by the EQ pool changes

2015-06-03 Thread David Miller
From: Or Gerlitz Date: Tue, 2 Jun 2015 10:29:48 +0300 > When CONFIG_RFS_ACCEL or SMP aren't set, we fail to build, fix it. > > Also, avoid build warning as of unused function on that setup. > > Fixes: c66fa19c405a ('net/mlx4: Add EQ pool') > Reported-by: Michael Ellerman > Signed-off-by: Mata

Re: virtio-net: why not always to set avail->flags to VRING_AVAIL_F_NO_INTERRUPT

2015-06-03 Thread Linhaifeng
On 2015/6/4 9:13, Rusty Russell wrote: > Linhaifeng writes: >> Hi, >> >> I'm a newbie and have a question about vring_new_virtqueue function. >> >> Why we set avail->flags to VRING_AVAIL_F_NO_INTERRUPT when no callbacks? >> I think we should set avail->flags to VRING_AVAIL_F_NO_INTERRUPT even if

Re: [PATCH net 2/2] s390/bpf: fix bpf frame pointer setup

2015-06-03 Thread David Miller
From: Alexei Starovoitov Date: Mon, 1 Jun 2015 22:48:35 -0700 > From: Michael Holzheu > > Currently the bpf frame pointer is set to the old r15. This is > wrong because of packed stack. Fix this and adjust the frame pointer > to respect packed stack. This now generates a prolog like the follow

Re: [PATCH net 1/2] s390/bpf: fix stack allocation

2015-06-03 Thread David Miller
From: Alexei Starovoitov Date: Mon, 1 Jun 2015 22:48:34 -0700 > From: Michael Holzheu > > On s390x we have to provide 160 bytes stack space before we can call > the next function. From the 160 bytes that we got from the previous > function we only use 11 * 8 bytes and have 160 - 11 * 8 bytes l

Re: virtio-net: why not always to set avail->flags to VRING_AVAIL_F_NO_INTERRUPT

2015-06-03 Thread Rusty Russell
Linhaifeng writes: > Hi, > > I'm a newbie and have a question about vring_new_virtqueue function. > > Why we set avail->flags to VRING_AVAIL_F_NO_INTERRUPT when no callbacks? > I think we should set avail->flags to VRING_AVAIL_F_NO_INTERRUPT even if no > callbacks. Hi Linhaifeng, Not su

[PATCH] fm10k: Fix missing braces after if statement

2015-06-03 Thread Alexander Duyck
While reviewing the code I noticed that one of the commits added an if statement followed by a for loop, but the if statement was missing the braces around the loop. This change corrects the coding style error. Signed-off-by: Alexander Duyck --- drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-06-03 Thread Jason Gunthorpe
On Wed, Jun 03, 2015 at 11:07:37PM +0300, Or Gerlitz wrote: > > I'm mostly fine with it as an optional capability, similar to macvlan, > > I just don't see how to cleanly integrate it with RDMA CM and > > namespaces. And I don't see what RDMA CM is supposed to do when > > it hits this case. > > >

[PATCH net-next] openvswitch: include actions with upcall if allocation allows

2015-06-03 Thread Neil McKee
Back out the OVS_USERSPACE_ATTR_ACTIONS attribute that was gating the inclusion of datapath actions in the upcall. Instead include the actions every time, provided there is no problem with the atomic allocation. If the atomic allocation fails then try it again with the actions omitted. Signed-off

Re: [net-next RFC 08/14] openvswitch: Allocate & attach ip_tunnel_info for tunnel set action

2015-06-03 Thread Thomas Graf
On 06/03/15 at 05:29pm, Jiri Benc wrote: > On Mon, 1 Jun 2015 16:27:32 +0200, Thomas Graf wrote: > > --- a/net/openvswitch/flow.h > > +++ b/net/openvswitch/flow.h > > @@ -45,6 +45,11 @@ struct sk_buff; > > #define TUN_METADATA_OPTS(flow_key, opt_len) \ > > ((void *)((flow_key)->tun_opts + TUN

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-06-03 Thread Jason Gunthorpe
On Wed, Jun 03, 2015 at 11:07:37PM +0300, Or Gerlitz wrote: > As Haggai wrote, if we let the using IP address thing to fly up, we have > support for RDMA in containers using the RDMA-CM at IPoIB environments. > This will let people test, use, experiment, fix, interact (and even > production-it when

[PATCH v2] ipv4/udp: Verify multicast group is ours in upd_v4_early_demux()

2015-06-03 Thread Shawn Bohrer
From: Shawn Bohrer 421b3885bf6d56391297844f43fb7154a6396e12 "udp: ipv4: Add udp early demux" introduced a regression that allowed sockets bound to INADDR_ANY to receive packets from multicast groups that the socket had not joined. For example a socket that had joined 224.168.2.9 could also receiv

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Alexander Duyck
On 06/03/2015 01:02 PM, Andy Gospodarek wrote: On Wed, Jun 03, 2015 at 11:25:09AM -0700, Alexander Duyck wrote: On 06/02/2015 08:07 PM, Andy Gospodarek wrote: [...] Though there were some that preferred not to have a configuration option and to make this behavior the default when it was discus

Re: [RFC 7/9] net: dsa: mv88e6352: lock CPU port from learning addresses

2015-06-03 Thread Andrew Lunn
On Tue, Jun 02, 2015 at 07:31:56PM -0700, Chris Healy wrote: > Guenter, > > That's a very valid concern. I have a configuration with a 6352 controlled > by a low end ARM core with a 100mbps connection on the CPU port. This > switch needs to support passing multicast streams that are more than >

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Hannes Frederic Sowa
On Wed, Jun 3, 2015, at 22:34, Andy Gospodarek wrote: > On Wed, Jun 03, 2015 at 10:04:06PM +0200, Hannes Frederic Sowa wrote: > > On Wed, Jun 3, 2015, at 20:27, Andy Gospodarek wrote: > > > On Wed, Jun 03, 2015 at 11:15:55AM -0700, Scott Feldman wrote: > > > > On Tue, Jun 2, 2015 at 8:07 PM, Andy G

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 10:04:06PM +0200, Hannes Frederic Sowa wrote: > On Wed, Jun 3, 2015, at 20:27, Andy Gospodarek wrote: > > On Wed, Jun 03, 2015 at 11:15:55AM -0700, Scott Feldman wrote: > > > On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek > > > wrote: > > > > This feature is only enabled w

pull-request: wireless-drivers-next 2015-06-03

2015-06-03 Thread Kalle Valo
Hi Dave, here's a pull request for 4.2. Most notable change here is a new driver mt7601u for a Mediatek USB Wi-Fi device, for other driver more information in the signed tag. There's a trivial conflict in iwlwifi Kconfig help text but otherwise I'm not expecting any issues. But please let me know

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 12:03:53PM -0700, Scott Feldman wrote: > On Wed, Jun 3, 2015 at 11:27 AM, Andy Gospodarek > wrote: > > On Wed, Jun 03, 2015 at 11:15:55AM -0700, Scott Feldman wrote: > >> On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek > >> wrote: > >> > This feature is only enabled with t

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-06-03 Thread Or Gerlitz
On Wed, Jun 3, 2015 at 10:53 PM, Jason Gunthorpe wrote: > On Wed, Jun 03, 2015 at 10:05:34PM +0300, Or Gerlitz wrote: > >> Indeed the DHCP story isn't working there and to get DHCP work >> something has to be done. But this issue can't serve for blocking the >> existing UAPI and introduce regressi

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Hannes Frederic Sowa
On Wed, Jun 3, 2015, at 20:27, Andy Gospodarek wrote: > On Wed, Jun 03, 2015 at 11:15:55AM -0700, Scott Feldman wrote: > > On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek > > wrote: > > > This feature is only enabled with the new sysctl set (default is off): > > > net.core.kill_routes_on_linkdown

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 11:25:09AM -0700, Alexander Duyck wrote: > On 06/02/2015 08:07 PM, Andy Gospodarek wrote: [...] > >Though there were some that preferred not to have a configuration option > >and to make this behavior the default when it was discussed in Ottawa > >earlier this year since "i

[RFC net-next 4/6] net: ILA use special route hook

2015-06-03 Thread Tom Herbert
Register hooks from ILA. Signed-off-by: Tom Herbert --- net/ipv6/ila.c | 13 + 1 file changed, 13 insertions(+) diff --git a/net/ipv6/ila.c b/net/ipv6/ila.c index 54a215d..d6fce77 100644 --- a/net/ipv6/ila.c +++ b/net/ipv6/ila.c @@ -11,11 +11,16 @@ #include #include #include +

[RFC net-next 3/6] net: Special routing hook

2015-06-03 Thread Tom Herbert
A hack to provide an ultra light weight hook to do translations. Signed-off-by: Tom Herbert --- include/net/ip6_route.h | 22 + net/ipv6/ip6_input.c| 3 +++ net/ipv6/ip6_output.c | 24 ++- net/ipv6/route.c| 51 +++

[RFC net-next 2/6] net: Identfier Locator Addressing module

2015-06-03 Thread Tom Herbert
Adding new module name ila. This implements ILA tanslation. A netlink interface is used to configure identifier to lacator mappings. Two functions are exported to attempt to perform a translation on input or output path. Signed-off-by: Tom Herbert --- include/net/ila.h | 7 + net/ipv6/Kconfig

[RFC net-next 0/6] net: Identifier Locator Addressing

2015-06-03 Thread Tom Herbert
This patch set provides rudimentary support for Identifier Locator Addresssing or ILA. The basic concept of ILA is that we split and IPv6 in to a 64 bit locator and 64 bit identifier. The identifier is the identity of an entity in communication ("who") and the locator expresses a the location of th

[RFC net-next 5/6] net: ILA iptables target

2015-06-03 Thread Tom Herbert
Add two target ILAIN and ILAOUT which hook into the ILA module. Signed-off-by: Tom Herbert --- net/netfilter/Kconfig | 11 +++ net/netfilter/Makefile | 1 + net/netfilter/xt_ILA.c | 82 ++ 3 files changed, 94 insertions(+) create mode 100644

[RFC net-next 1/6] net: Checksum functions to replace 8 bytes at a time

2015-06-03 Thread Tom Herbert
These are convenience functions for update a checksum in ILA where we are overwriting the locator (first eight bytes of an ILA IPv6 address). Signed-off-by: Tom Herbert --- include/net/checksum.h | 3 +++ net/core/utils.c | 19 +++ 2 files changed, 22 insertions(+) diff -

[RFC net-next 6/6] ipvlan: Call ILA in incoming and outgoing receive paths

2015-06-03 Thread Tom Herbert
Hacked IPVLAN to call ILA functions in send and receive paths. Signed-off-by: Tom Herbert --- drivers/net/ipvlan/ipvlan.h | 1 + drivers/net/ipvlan/ipvlan_core.c | 27 ++- drivers/net/ipvlan/ipvlan_main.c | 4 3 files changed, 23 insertions(+), 9 deletions(-)

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-06-03 Thread Jason Gunthorpe
On Wed, Jun 03, 2015 at 10:05:34PM +0300, Or Gerlitz wrote: > Indeed the DHCP story isn't working there and to get DHCP work > something has to be done. But this issue can't serve for blocking the > existing UAPI and introduce regression to working systems. It is not DHCP that concerns me, it is

Fw: [Bug 99411] New: Kernel panic after internet access goes down

2015-06-03 Thread Stephen Hemminger
Begin forwarded message: Date: Wed, 3 Jun 2015 14:31:53 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 99411] New: Kernel panic after internet access goes down https://bugzilla.kernel.org/show_bug.cgi?id=99411 Bug ID: 99411

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-06-03 Thread Or Gerlitz
On Wed, Jun 3, 2015 at 7:14 PM, Jason Gunthorpe wrote: > On Wed, Jun 03, 2015 at 01:03:01PM +0300, Haggai Eran wrote: >> > Then I'm inclined to say that we should map for namespaces using device, >> > port, guid/gid, pkey. And in this situation, since a unique guid/gid on >> > any given pkey maps

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Scott Feldman
On Wed, Jun 3, 2015 at 11:27 AM, Andy Gospodarek wrote: > On Wed, Jun 03, 2015 at 11:15:55AM -0700, Scott Feldman wrote: >> On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek >> wrote: >> > This feature is only enabled with the new sysctl set (default is off): >> > net.core.kill_routes_on_linkdown =

[PATCH V3 0/2] pci: Provide a flag to access VPD through function 0

2015-06-03 Thread Mark D Rustad
Many multi-function devices provide shared registers in extended config space for accessing VPD. The behavior of these registers means that the state must be tracked and access locked correctly for accesses not to hang or worse. One way to meet these needs is to always perform the accesses through

[PATCH V3 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-03 Thread Mark D Rustad
Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This solves concurrent access problems on many devices without changing the attributes exposed in sysfs. Never set this bit on function 0 or there will be an infinite recursion.

[PATCH V3 2/2] pci: Add VPD quirk for Intel Ethernet devices

2015-06-03 Thread Mark D Rustad
This quirk sets the PCI_DEV_FLAGS_VPD_REF_F0 flag on all Intel Ethernet device functions other than function 0. Signed-off-by: Mark Rustad --- Changes in V3: - Added a multifunction device check --- drivers/pci/quirks.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/pci/

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-03 Thread Florian Fainelli
On 02/06/15 23:53, Scott Feldman wrote: > On Tue, Jun 2, 2015 at 3:31 PM, nolan wrote: >> On 06/02/2015 12:44 AM, Scott Feldman wrote: >>> >>> That brings up an interesting point about having multiple bridges with >>> the same vlan configured. I struggled with that problem with rocker >>> also an

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-03 Thread Vivek Venkatraman
On Tue, Jun 2, 2015 at 2:06 PM, Robert Shearman wrote: > On 02/06/15 19:57, roopa wrote: >> >> On 6/2/15, 9:33 AM, Robert Shearman wrote: >>> >>> On 02/06/15 17:15, roopa wrote: On 6/1/15, 9:46 AM, Robert Shearman wrote: > > Allow creating an mpls device for the purposes of encap

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-03 Thread roopa
On 6/3/15, 8:43 AM, Toshiaki Makita wrote: On 15/06/03 (水) 4:01, Scott Feldman wrote: On Tue, Jun 2, 2015 at 9:58 AM, roopa wrote: On 6/2/15, 7:30 AM, Scott Feldman wrote: On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim wrote: On 06/02/15 03:10, Scott Feldman wrote: Actually, we're no

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 11:15:55AM -0700, Scott Feldman wrote: > On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek > wrote: > > This feature is only enabled with the new sysctl set (default is off): > > net.core.kill_routes_on_linkdown = 1 > > One more thing, sorry. This feature is typically imple

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Alexander Duyck
On 06/02/2015 08:07 PM, Andy Gospodarek wrote: This patch adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status of the interface associated with the next-hop. Before this patch any link-failure on an interface that was serving a

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 11:12:11AM -0700, Scott Feldman wrote: > On Wed, Jun 3, 2015 at 10:57 AM, Andy Gospodarek > wrote: > > On Wed, Jun 03, 2015 at 10:40:26AM -0700, Scott Feldman wrote: > >> On Wed, Jun 3, 2015 at 8:12 AM, Andy Gospodarek > >> wrote: > >> > On Tue, Jun 02, 2015 at 10:03:23PM

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Scott Feldman
On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek wrote: > This feature is only enabled with the new sysctl set (default is off): > net.core.kill_routes_on_linkdown = 1 One more thing, sorry. This feature is typically implemented today in user-space on a per-interface basis. The example I'm think

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Scott Feldman
On Wed, Jun 3, 2015 at 10:57 AM, Andy Gospodarek wrote: > On Wed, Jun 03, 2015 at 10:40:26AM -0700, Scott Feldman wrote: >> On Wed, Jun 3, 2015 at 8:12 AM, Andy Gospodarek >> wrote: >> > On Tue, Jun 02, 2015 at 10:03:23PM -0700, Scott Feldman wrote: >> >> On Tue, Jun 2, 2015 at 8:07 PM, Andy Gosp

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 10:40:26AM -0700, Scott Feldman wrote: > On Wed, Jun 3, 2015 at 8:12 AM, Andy Gospodarek > wrote: > > On Tue, Jun 02, 2015 at 10:03:23PM -0700, Scott Feldman wrote: > >> On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek > >> wrote: > >> > This patch adds the ability to have

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Neil Horman
On Wed, Jun 03, 2015 at 11:16:27AM -0400, Andy Gospodarek wrote: > On Wed, Jun 03, 2015 at 11:02:23AM -0400, Neil Horman wrote: > > On Wed, Jun 03, 2015 at 10:46:22AM -0400, Andy Gospodarek wrote: > > > On Wed, Jun 03, 2015 at 10:21:31AM -0400, Neil Horman wrote: > > > > On Wed, Jun 03, 2015 at 04:

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Scott Feldman
On Wed, Jun 3, 2015 at 8:12 AM, Andy Gospodarek wrote: > On Tue, Jun 02, 2015 at 10:03:23PM -0700, Scott Feldman wrote: >> On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek >> wrote: >> > This patch adds the ability to have the Linux kernel track whether or >> > not a particular route should be use

Re: [PATCH v2 1/2] sctp: rcu-ify addr_waitq

2015-06-03 Thread Marcelo Ricardo Leitner
On Wed, Jun 03, 2015 at 01:54:01PM -0300, mleit...@redhat.com wrote: > From: Marcelo Ricardo Leitner > > That's needed for the next patch, so we break the lock inversion between > netns_sctp->addr_wq_lock and socket lock on > sctp_addr_wq_timeout_handler(). With this, we can traverse addr_waitq >

Re: [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-03 Thread Joe Perches
On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote: > rx->status is an int16_t, print it using %d rather than %u in order to > have a meaningful value when the field is negative. [] > diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c [] > @@ -733,7 +733,7 @@ static int xennet_

Re: [RFC PATCH 03/13] xen-netback: implement TX persistent grants

2015-06-03 Thread Joao Martins
On 02 Jun 2015, at 16:53, Wei Liu wrote: > On Fri, May 22, 2015 at 10:24:39AM +, Joao Martins wrote: >> >> On 19 May 2015, at 17:23, Wei Liu wrote: >>> On Tue, May 12, 2015 at 07:18:27PM +0200, Joao Martins wrote: Introduces persistent grants for TX path which follows similar code pat

Re: [RFC PATCH 04/13] xen-netback: implement RX persistent grants

2015-06-03 Thread Joao Martins
On 02 Jun 2015, at 17:07, Wei Liu wrote: > On Fri, May 22, 2015 at 10:25:10AM +, Joao Martins wrote: >> >> On 19 May 2015, at 17:32, Wei Liu wrote: >> >>> On Tue, May 12, 2015 at 07:18:28PM +0200, Joao Martins wrote: It starts by doing a lookup in the tree for a gref. If no persisten

[PATCH v2 2/2] net/xen-netback: Remove unused code in xenvif_rx_action

2015-06-03 Thread Julien Grall
The variables old_req_cons and ring_slots_used are assigned but never used since commit 1650d5455bd2dc6b5ee134bd6fc1a3236c266b5b "xen-netback: always fully coalesce guest Rx packets". Signed-off-by: Julien Grall Acked-by: Wei Liu Cc: Ian Campbell Cc: netdev@vger.kernel.org --- Changes in v

[PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-03 Thread Julien Grall
rx->status is an int16_t, print it using %d rather than %u in order to have a meaningful value when the field is negative. Signed-off-by: Julien Grall Reviewed-by: David Vrabel Cc: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky Cc: netdev@vger.kernel.org --- Changes in v2: - Add David'

[PATCH v2 0/2] net/xen: Clean up

2015-06-03 Thread Julien Grall
Hi, Those 2 patches was originally part of the Xen 64KB series [1]. They are already acked/reviewed and can go in Linux via the net tree now without waiting the rest of the series. Sincerely yours, Cc: Wei Liu Cc: Ian Campbell Cc: David Vrabel Cc: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky

[PATCH v2 1/2] sctp: rcu-ify addr_waitq

2015-06-03 Thread mleitner
From: Marcelo Ricardo Leitner That's needed for the next patch, so we break the lock inversion between netns_sctp->addr_wq_lock and socket lock on sctp_addr_wq_timeout_handler(). With this, we can traverse addr_waitq without taking addr_wq_lock, taking it just for the write operations. Signed-of

Re: [PATCH] ethernet: micrel: use time_after_eq

2015-06-03 Thread Joe Perches
On Wed, 2015-06-03 at 15:40 +0200, Antonio Murdaca wrote: > Did I make some mistakes with this patch? Seeking help|info since this is > one my very first contribution to the kernel.. Please be patient and wait for the review process to take place. It can take weeks before you get a reply. -- To

Re: [PATCH 03/11] netfilter: don't use module_init/exit in core IPV4 code

2015-06-03 Thread Paul Gortmaker
On 15-06-03 12:04 PM, Pablo Neira Ayuso wrote: > On Sun, May 31, 2015 at 08:54:04PM -0400, Paul Gortmaker wrote: >> The file net/ipv4/netfilter.o is created based on whether >> CONFIG_NETFILTER is set. However that is defined as a bool, and >> hence this file with the core netfilter hooks will nev

Re: [Intel-wired-lan] [PATCH V2 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-03 Thread Rustad, Mark D
> On Jun 2, 2015, at 7:28 PM, Alexander Duyck wrote: > > You can probably combine the dev->multifunction check with the dev_flags > check. After all you don't need this workaround if the device is not > multifunction. It might even make more sense to move the multifunction check > to the qui

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-06-03 Thread Jason Gunthorpe
On Wed, Jun 03, 2015 at 01:03:01PM +0300, Haggai Eran wrote: > > Then I'm inclined to say that we should map for namespaces using device, > > port, guid/gid, pkey. And in this situation, since a unique guid/gid on > > any given pkey maps to a unique dhcp identifier and a unique ipv6 > > lladdr, th

Re: [PATCH 03/11] netfilter: don't use module_init/exit in core IPV4 code

2015-06-03 Thread Pablo Neira Ayuso
On Sun, May 31, 2015 at 08:54:04PM -0400, Paul Gortmaker wrote: > The file net/ipv4/netfilter.o is created based on whether > CONFIG_NETFILTER is set. However that is defined as a bool, and > hence this file with the core netfilter hooks will never be > modular. So using module_init as an alias f

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-03 Thread Guenter Roeck
On 06/03/2015 07:56 AM, Vivien Didelot wrote: Hi Guenter, On Jun 2, 2015, at 10:17 PM, Guenter Roeck li...@roeck-us.net wrote: On Tue, Jun 02, 2015 at 09:39:50PM -0400, Vivien Didelot wrote: Guenter, On Jun 2, 2015, at 2:50 AM, Guenter Roeck li...@roeck-us.net wrote: On 06/01/2015 06:27 PM,

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-03 Thread roopa
On 6/2/15, 12:01 PM, Scott Feldman wrote: On Tue, Jun 2, 2015 at 9:58 AM, roopa wrote: On 6/2/15, 7:30 AM, Scott Feldman wrote: On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim wrote: On 06/02/15 03:10, Scott Feldman wrote: Actually, we're now consistent with bridge man page which says ma

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-03 Thread Toshiaki Makita
On 15/06/03 (水) 4:01, Scott Feldman wrote: On Tue, Jun 2, 2015 at 9:58 AM, roopa wrote: On 6/2/15, 7:30 AM, Scott Feldman wrote: On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim wrote: On 06/02/15 03:10, Scott Feldman wrote: Actually, we're now consistent with bridge man page which says

Re: [net-next RFC 08/14] openvswitch: Allocate & attach ip_tunnel_info for tunnel set action

2015-06-03 Thread Jiri Benc
On Mon, 1 Jun 2015 16:27:32 +0200, Thomas Graf wrote: > --- a/net/openvswitch/flow.h > +++ b/net/openvswitch/flow.h > @@ -45,6 +45,11 @@ struct sk_buff; > #define TUN_METADATA_OPTS(flow_key, opt_len) \ > ((void *)((flow_key)->tun_opts + TUN_METADATA_OFFSET(opt_len))) > > +struct ovs_tunne

Re: [PATCH] ethtool: changes of emac_regs structure accordingly within driver emac_regs structure.

2015-06-03 Thread Ivan Mikhaylov
On Mon, 1 Jun 2015 22:11:00 +0400 Ben Hutchings wrote: >On Mon, 2015-06-01 at 16:30 +0400, Ivan Mikhaylov wrote: >> On Mon, 1 June 2015 12:57 +0400 >> Ben Hutchings wrote: >> >> >On Thu, 2015-05-21 at 19:09 +0400, Ivan Mikhaylov wrote: >> >> In ibm_emac.c in ethtool size of emac structure which

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Hannes Frederic Sowa
On Mi, 2015-06-03 at 11:02 -0400, Neil Horman wrote: > On Wed, Jun 03, 2015 at 10:46:22AM -0400, Andy Gospodarek wrote: > > On Wed, Jun 03, 2015 at 10:21:31AM -0400, Neil Horman wrote: > > > On Wed, Jun 03, 2015 at 04:13:08PM +0200, Hannes Frederic Sowa wrote: > > > > On Mi, 2015-06-03 at 09:53 -04

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 11:02:23AM -0400, Neil Horman wrote: > On Wed, Jun 03, 2015 at 10:46:22AM -0400, Andy Gospodarek wrote: > > On Wed, Jun 03, 2015 at 10:21:31AM -0400, Neil Horman wrote: > > > On Wed, Jun 03, 2015 at 04:13:08PM +0200, Hannes Frederic Sowa wrote: > > > > On Mi, 2015-06-03 at 0

  1   2   >