Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT

2015-07-14 Thread Bastien Nocera
On Tue, 2015-07-14 at 15:21 +0200, Johannes Berg wrote: > On Tue, 2015-07-14 at 08:20 -0500, Larry Finger wrote: > > On 07/13/2015 05:11 PM, Bastien Nocera wrote: > > > http://thread.gmane.org/gmane.linux.kernel.wireless.general/12770 > > > 6/ > > > focu > > > s=127896 > > > > > > Signed-off-by: B

Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-14 Thread Simon Horman
On Tue, Jul 14, 2015 at 10:32:54PM -0700, Scott Feldman wrote: > On Tue, Jul 14, 2015 at 9:45 PM, Simon Horman [snip] > > How about this? > > Looks good, some inline comments... [snip] > > @@ -321,9 +322,21 @@ static u16 rocker_port_vlan_to_vid(const struct > > rocker_port *rocker_port, > >

Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT

2015-07-14 Thread Bastien Nocera
On Tue, 2015-07-14 at 08:20 -0500, Larry Finger wrote: > On 07/13/2015 05:11 PM, Bastien Nocera wrote: > > http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/ > > focu > > s=127896 > > > > Signed-off-by: Bastien Nocera > > Bastien, > > The subject of this patch needs a bit more

Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT

2015-07-14 Thread Bastien Nocera
On Tue, 2015-07-14 at 17:29 +0200, Marcel Holtmann wrote: > Hi Bastien, > > > http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/ > > focu > > s=127896 > > > > Signed-off-by: Bastien Nocera > > > > --- > > net/rfkill/rfkill-gpio.c | 1 + > > 1 file changed, 1 insertion(+) > > >

Re: [Patch net] fq_codel: fix return value of fq_codel_drop()

2015-07-14 Thread Eric Dumazet
On Tue, 2015-07-14 at 11:21 -0700, Cong Wang wrote: > The ->drop() is supposed to return the number of bytes it dropped, > however fq_codel_drop() returns the index of the flow where it drops > a packet from. > > Fix this by introducing a helper to wrap fq_codel_drop(). > > Cc: Eric Dumazet > Si

next-20150714 - busted IPv6 source address selection...

2015-07-14 Thread Valdis Kletnieks
next-20150714 w/ one ethernet commit reverted. -0706 w/ same revert works. "ip addr show" for the wireless says: 5: wlp3s0b1: mtu 1500 qdisc fq_codel state UP group default qlen 1000 link/ether bc:85:56:1f:4f:6d brd ff:ff:ff:ff:ff:ff inet 172.30.42.75/27 brd 172.30.42.95 sc

Re: [PATCH v2 net-next 2/3] rhashtable: Add a function for in order insertion and lookup in buckets

2015-07-14 Thread Herbert Xu
On Tue, Jul 14, 2015 at 04:45:48PM -0700, Tom Herbert wrote: > The obj_orderfn function may be specified in the parameters for a > rhashtable. When inserting an element this function is used to order > objects in a bucket list (greatest to least ordering value).This > allows entries to have wild ca

Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-14 Thread Scott Feldman
On Tue, Jul 14, 2015 at 9:45 PM, Simon Horman wrote: > Hi Scott, > > On Mon, Jul 13, 2015 at 11:37:59PM -0700, Scott Feldman wrote: >> On Wed, Jul 8, 2015 at 9:25 PM, Simon Horman >> wrote: >> > This change allows the CPU to see all packets seen by a port when the >> > netdev associated with the

Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

2015-07-14 Thread Scott Feldman
On Tue, Jul 14, 2015 at 1:43 PM, wrote: > From: Anuradha Karuppiah > > User space daemons can detect errors in the network that need to be > notified to the switch device drivers. > > Drivers can react to this error state by doing a phy-down on the > switch-port which would result in a carrier-o

RE: [PATCH] bnx2x: Update to FW version 7.12.30

2015-07-14 Thread Yuval Mintz
> Subject: Re: [PATCH] bnx2x: Update to FW version 7.12.30 > > On Mon, Jul 13, 2015 at 10:17:24AM +, Yuval Mintz wrote: > > > > > The new FW will allow us to utilize some new features in our > > > > > driver, mainly adding vlan filtering offload and vxlan offload > > > > > support. > > > > >

Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-14 Thread Simon Horman
Hi Scott, On Mon, Jul 13, 2015 at 11:37:59PM -0700, Scott Feldman wrote: > On Wed, Jul 8, 2015 at 9:25 PM, Simon Horman > wrote: > > This change allows the CPU to see all packets seen by a port when the > > netdev associated with the port is in promiscuous mode. > > > > This change was previousl

[net-next v2 05/16] i40evf: Allow for an abundance of vectors

2015-07-14 Thread Jeff Kirsher
From: Mitch Williams The driver currently only maps TX and RX queues to a single MSI-X vector per queue pair if there are exactly enough vectors for this. Unfortunately, if we have too many vectors it will fail and allocate queues to vectors in a suboptimal manner. Change the condition check to a

[net-next v2 02/16] i40e/i40evf: Add stats to track FD ATR and SB dynamic enable state

2015-07-14 Thread Jeff Kirsher
From: Anjali Singhai Jain Since the driver can dynamically enable/disable FD ATR and SB features, these stats help keep track of the current state and along with fd_flush count provide a means to debug what could be going on with the flow director filters. This will take away the need for being v

[net-next v2 04/16] i40e/i40evf: improve Tx performance with a small tweak

2015-07-14 Thread Jeff Kirsher
From: Jesse Brandeburg Add a prefetch for the next Tx descriptor to be used when we know there are more coming. Change-ID: Ibb9acab11d508eec2db7da795df74debc16eeacb Signed-off-by: Jesse Brandeburg Tested-by: Jim Young Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_txrx.

[net-next v2 01/16] i40e: Implement ndo_features_check()

2015-07-14 Thread Jeff Kirsher
From: Joe Stringer i40e supports UDP tunnel headers up to 80 bytes in length, so this adds a check to ensure that it doesn't try to offload packets that exceed that. Signed-off-by: Joe Stringer Signed-off-by: Jesse Gross Acked-by: Jesse Brandeburg Signed-off-by: Jeff Kirsher --- drivers/net

[net-next v2 00/16][pull request] Intel Wired LAN Driver Updates 2015-07-14

2015-07-14 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Joe Stringer and Jesse Gross add a ndo_features_check function to ensure that the i40e driver does not try to offload packets that exceed 80 bytes in length. Anjali adds additional stats to track flow director ATR and SB current state and flow

[net-next v2 06/16] i40e: ignore duplicate port VLAN requests

2015-07-14 Thread Jeff Kirsher
From: Mitch Williams If user attempts to set a port VLAN on a VF that already has the same port VLAN configured, the driver will go through a completely unnecessary flurry of filter removals and filter adds. Just check for this condition and return success instead of doing a bunch of busywork. C

[net-next v2 12/16] i40evf: don't delete all the filters

2015-07-14 Thread Jeff Kirsher
From: Mitch Williams Due to an inverted conditional, the driver was marking all of its MAC filters for deletion every time set_rx_mode was called. Depending upon the timing of the calls to set_rx_mode and the processing of the admin queue, the driver would (accidentally) end up with a varying num

[net-next v2 09/16] i40e: correctly program filters for VFs

2015-07-14 Thread Jeff Kirsher
From: Mitch Williams MAC filters for VFs were being programmed with 0 for the VLAN value when there was no VLAN assigned. This is incorrect and actually assigns the VF to VLAN 0. Instead, we must use -1 to indicate that no VLAN is in use. This change programs the filters correctly and gets rid of

[net-next v2 08/16] i40e/i40evf: Update the admin queue command header

2015-07-14 Thread Jeff Kirsher
From: Greg Rose Make the necessary updates to i40e_adminq_cmd.h. Change-ID: Ib031c86cc6cab78e5aa44c64d8ce5474be8d7e42 Signed-off-by: Greg Rose Tested-by: Jim Young Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 24 -- .../net/ethernet

[net-next v2 03/16] i40e/i40evf: Update Flex-10 related device/function capabilities

2015-07-14 Thread Jeff Kirsher
From: Pawel Orlowski The Flex10 device/function capability has been upgraded to include information needed to support Flex-10 configurations. This patch adds new fields to the i40e_hw_capabilities structure and updates i40e_parse_discover_capabilities functions to extract them from the AQ respons

[net-next v2 07/16] i40e: Remove incorrect #ifdef's

2015-07-14 Thread Jeff Kirsher
From: Carolyn Wyborny This patch removes some #ifdef's that should not be there. They were stopping code that is needed from being compiled in. With these #ifdef's removed, changes are needed in the driver to fix some compile errors: adding missing parameters to the definition of ndo_bridge_setl

[net-next v2 11/16] i40e: un-disable VF after reset

2015-07-14 Thread Jeff Kirsher
From: Mitch Williams When a VF is disabled, there is no way for it to recover until either the PF driver is reloaded or SR-IOV is disabled and enabled. To correct this, enable the VF after a successful reset. Change-ID: I9e0788476c4d53d5407961b503febdfff2b8a7c6 Signed-off-by: Mitch Williams Tes

[net-next v2 10/16] i40e: do a proper reset when disabling a VF

2015-07-14 Thread Jeff Kirsher
From: Mitch Williams The VF disable code was just whanging on the reset bit without properly cleaning up the VF, which would leave the VF in an indeterminate state from which it could not recover. Fix this by notifying the VF and then by calling the normal VF reset routine. Change-ID: I862b9dfa9

[net-next v2 14/16] i40e/i40evf: Add support for pre-allocated pages for PD

2015-07-14 Thread Jeff Kirsher
From: Faisal Latif The i40e_add_pd_table_entry() routine is being modified to handle both cases where a backing page is passed and where backing page is allocated in i40e_add_pd_table_entry(). For PBLE resource management, it is more efficient for it to manage its backing pages. For VF, PBLE bac

[net-next v2 13/16] i40evf: add MAC address filter in open, not init

2015-07-14 Thread Jeff Kirsher
From: Mitch Williams During close, all of the MAC filters are cleared, so the driver would be unable to receive unicast packets after being closed and reopened. Add the adapter's "hardware" MAC address filter in open, not init. This ensures that the correct filter is present each time. Change-I

[net-next v2 15/16] i40e: Refine an error message to avoid confusion

2015-07-14 Thread Jeff Kirsher
From: Anjali Singhai Jain Change a warning message to indicate what may have really happened when the init_shared_code call fails. Change-ID: I616ace40fed120d0dec86dfc91ab2d7cde466904 Signed-off-by: Anjali Singhai Jain Tested-by: Jim Young Signed-off-by: Jeff Kirsher --- drivers/net/ethernet

[net-next v2 16/16] i40e/i40evf: Bump version to 1.3.6 for i40e and 1.3.2 for i40evf

2015-07-14 Thread Jeff Kirsher
From: Catherine Sullivan Bump. Change-ID: I84573d9fa51effc5b29bf5b8c74e3cc8b2673f48 Signed-off-by: Catherine Sullivan Tested-by: Jim Young Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 2 files c

Re: [PATCH net-next 1/3] rhashtable: Add a function for in order insertion in buckets

2015-07-14 Thread Herbert Xu
On Tue, Jul 14, 2015 at 05:59:53PM -0700, Tom Herbert wrote: > > Conceptually, I agree with you, but I would point out that we've had > this model of intentional collisions for a while in socket lookup. I > would assume that it's a goal to use rhashtable for socket tables, so > we'll need some solu

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

2015-07-14 Thread Alexei Starovoitov
On 7/14/15 5:58 PM, John Fastabend wrote: Right and we hit this issue when pktgen is run over any stacked device with clone_skb set. I've always put it in the don't do this category but a fix would be nice. hmm, are you sure that commit 52d6c8c6ca12 ("net: pktgen: disable xmit_clone on virtual

Re: [PATCH net-next 1/3] rhashtable: Add a function for in order insertion in buckets

2015-07-14 Thread Tom Herbert
On Tue, Jul 14, 2015 at 4:58 PM, Herbert Xu wrote: > On Tue, Jul 14, 2015 at 09:42:49AM -0700, Tom Herbert wrote: >> >> Scored lookups can provides the same functionality, but requires that >> we scan all the elements so I see some overhead compared to doing >> ordered insertion. One way to resolv

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

2015-07-14 Thread John Fastabend
On 15-07-14 04:08 PM, Alexei Starovoitov wrote: > On 7/14/15 3:34 PM, David Miller wrote: > 1 get rid of burst hack for both RX and TX in pktgen (kills > >>>performance) >> #1 is a serious consideration if you don't come up with better ideas, >> since an optimization is for nothing if it kn

Re: GRO: forwading ISATAP packets is very slow with kernel 4.1

2015-07-14 Thread Wolfgang Walter
Am Mittwoch, 15. Juli 2015, 08:08:49 schrieben Sie: > On Wed, Jul 15, 2015 at 12:16:30AM +0200, Wolfgang Walter wrote: > > Hello, > > > > I upgraded routers from 3.14.x to 4.1.2. Forwarding ISATAP-packets (IPv4 > > packets with IPv6 payload) is very slow with 4.1 if GRO is enabled > > (youtube > >

Re: [PATCH v2 net-next 3/3] rhashtable: Add scored lookups

2015-07-14 Thread Tom Herbert
On Tue, Jul 14, 2015 at 5:18 PM, Herbert Xu wrote: > On Tue, Jul 14, 2015 at 04:45:49PM -0700, Tom Herbert wrote: >> >> + } else if (score == best_score) { >> + matches++; >> + if (reciprocal_scale(khash, matches) == 0) >> +

Re: [PATCH v2 net-next 3/3] rhashtable: Add scored lookups

2015-07-14 Thread Herbert Xu
On Tue, Jul 14, 2015 at 04:45:49PM -0700, Tom Herbert wrote: > > + } else if (score == best_score) { > + matches++; > + if (reciprocal_scale(khash, matches) == 0) > + result = he; > + khash = next_ps

Re: GRO: forwading ISATAP packets is very slow with kernel 4.1

2015-07-14 Thread Herbert Xu
On Wed, Jul 15, 2015 at 12:16:30AM +0200, Wolfgang Walter wrote: > Hello, > > I upgraded routers from 3.14.x to 4.1.2. Forwarding ISATAP-packets (IPv4 > packets with IPv6 payload) is very slow with 4.1 if GRO is enabled (youtube > for example about 64kbit). Disabling GRO on the interfaces restor

Re: [PATCH net-next 1/3] rhashtable: Add a function for in order insertion in buckets

2015-07-14 Thread Herbert Xu
On Tue, Jul 14, 2015 at 09:42:49AM -0700, Tom Herbert wrote: > > Scored lookups can provides the same functionality, but requires that > we scan all the elements so I see some overhead compared to doing > ordered insertion. One way to resolve the rehash problem is search any > future table after we

[PATCH v2 net-next 3/3] rhashtable: Add scored lookups

2015-07-14 Thread Tom Herbert
This patch adds a mechanism to do scored lookups in an rhashtable. This mechanism is based on the UDP and TCP listener socket lookup functions. When a bucket is traversed, a matching score is computed for each entry and the input key. The entry with the greatest non-zero score is returned, and if

[PATCH v2 net-next 2/3] rhashtable: Add a function for in order insertion and lookup in buckets

2015-07-14 Thread Tom Herbert
The obj_orderfn function may be specified in the parameters for a rhashtable. When inserting an element this function is used to order objects in a bucket list (greatest to least ordering value).This allows entries to have wild card fields, where entries with more specific information match are pla

[PATCH v2 net-next 1/3] rhashtable: Allow lookup function to have compare function agument

2015-07-14 Thread Tom Herbert
Added rhashtable_lookup_fast_cmpfn which does a lookup in an rhash table with the compare function being taken from an argument. This allows different compare functions to be used on the same table. Signed-off-by: Tom Herbert --- include/linux/rhashtable.h | 20 +++- 1 file chang

[PATCH v2 net-next 0/3] rhashtable: Wildcard and scored lookups

2015-07-14 Thread Tom Herbert
This patch set implements: - A compare function can be passed in the lookup. This allows for comparison to include "wildcard fields" - Order insertion within a bucket, so that entries with more specific information can be matched first. - Scored lookups. This is like the socket lookup

Re: [PATCH net-next]r8169: Serialise some operations from open close

2015-07-14 Thread Francois Romieu
Corcodel Marian : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 410c1ee..be67873 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -7555,11 +7555,13 @@ static int rtl8169_close(struct

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

2015-07-14 Thread Alexei Starovoitov
On 7/14/15 3:34 PM, David Miller wrote: 1 get rid of burst hack for both RX and TX in pktgen (kills >>>performance) #1 is a serious consideration if you don't come up with better ideas, since an optimization is for nothing if it knowingly breaks things. I've dug up the pktgen source from 2002

Re: [patch] net/xen-netback: off by one in BUG_ON() condition

2015-07-14 Thread David Miller
From: Dan Carpenter Date: Sun, 12 Jul 2015 01:20:55 +0300 > The > should be >=. I also added spaces around the '-' operations so > the code is a little more consistent and matches the condition better. > > Fixes: f53c3fe8dad7 ('xen-netback: Introduce TX grant mapping') > Signed-off-by: Dan Carp

Re: [PATCH -next crap] net: icmp: work around bogus pmtu errors

2015-07-14 Thread David Miller
From: Florian Westphal Date: Sat, 11 Jul 2015 01:56:49 +0200 > sometimes tcp connections seem to hang. > tcpdump shows broken path mtu reports. This "fix" avoids hang and gives: > > [633.327834] icmp: 192.0.0.2 reports mtu 1474 for packet size 1474 to host > 204.236.132.12 > [635.586945] icmp:

Re: [PATCH] ravb: kill useless initializers

2015-07-14 Thread David Miller
From: Sergei Shtylyov Date: Fri, 10 Jul 2015 21:10:10 +0300 > Some of the local variable intializers in the driver turned out to be > pointless, > kill them. > > Signed-off-by: Sergei Shtylyov Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

2015-07-14 Thread David Miller
From: Alexei Starovoitov Date: Mon, 13 Jul 2015 15:26:46 -0700 > On 7/13/15 1:55 PM, Daniel Borkmann wrote: >> On 07/13/2015 10:17 PM, Alexei Starovoitov wrote: >> ... >>> We cannot check tc actions from pktgen, since they can be added >>> dynamically. >>> So I see three options: >>> 1 get rid of

Re: [PATCH] net: stop endless flood about dst entry refcount underflow or overflow

2015-07-14 Thread David Miller
From: Eric Dumazet Date: Tue, 14 Jul 2015 14:26:07 +0200 > On Tue, 2015-07-14 at 15:15 +0300, Konstantin Khlebnikov wrote: > >> Simple warn-once will hide a lot of information which could be useful. >> Also dst entry leak is better than freeing actually active entry. > > Then BUG_ON() . > > Re

[PATCH] x86: Wire up 32-bit direct socket calls

2015-07-14 Thread Andy Lutomirski
On x86_64, there's no socketcall syscall; instead all of the socket calls are real syscalls. For 32-bit programs, we're stuck offering the socketcall syscall, but it would be nice to expose the direct calls as well. This will enable seccomp to filter socket calls (for new userspace only, but that

GRO: forwading ISATAP packets is very slow with kernel 4.1

2015-07-14 Thread Wolfgang Walter
Hello, I upgraded routers from 3.14.x to 4.1.2. Forwarding ISATAP-packets (IPv4 packets with IPv6 payload) is very slow with 4.1 if GRO is enabled (youtube for example about 64kbit). Disabling GRO on the interfaces restores performance to values comparable to 3.14.x. The kernel is build with I

Re: [PATCH v2] rhashtable: fix for resize events during table walk

2015-07-14 Thread mroos
> If rhashtable_walk_next detects a resize operation in progress, it jumps > to the new table and continues walking that one. But it misses to drop > the reference to it's current item, leading it to continue traversing > the new table's bucket in which the current item is sorted into, and > after

[PATCH] ravb: do not invalidate cache for RX buffer twice

2015-07-14 Thread Sergei Shtylyov
First, dma_sync_single_for_cpu() shouldn't have been called in the first place (it's a streaming DMA API). dma_unmap_single() should have been called instead. Second, dma_unmap_single() call after handing the buffer to napi_gro_receive() makes little sense. Signed-off-by: Sergei Shtylyov --- The

Re: [PATCH v2] rhashtable: fix for resize events during table walk

2015-07-14 Thread Thomas Graf
On 07/15/15 at 12:35am, mr...@linux.ee wrote: > Yes, this fixes the error, thank you. > > The new problem with the test - soft lockup - CPU#0 stuck for 22s! is > still there on 360 MHz UltraSparc IIi. I understand it is harmless but > is there some easy way to make the test avoid NMI watchdog? >

Re: [PATCH net-next]r8169: Serialise some operations from open close

2015-07-14 Thread David Miller
Please do not post patches as attachments. Instead, inline them as unmolested ASCII text in the main message body along with your commit message. >From Documentation/email-clients.txt: General Preferences -

Re: [PATCH] bnx2x: Update to FW version 7.12.30

2015-07-14 Thread Kyle McMartin
On Mon, Jul 13, 2015 at 10:17:24AM +, Yuval Mintz wrote: > > > > The new FW will allow us to utilize some new features in our driver, > > > > mainly adding vlan filtering offload and vxlan offload support. > > > > > > > > In addition, this fixes several issues: > > > > 1. Packets from a VF with

[PATCH net-next v7 1/4] net core: Add protodown support.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah This patch introduces the proto_down flag that can be used by user space applications to notify switch drivers that errors have been detected on the device. The switch driver can react to protodown notification by doing a phys down on the associated switch port. Signed-

[PATCH net-next v7 3/4] rocker: Handle protodown notifications.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah protodown can be set by user space applications like MLAG on detecting errors on a switch port. This patch provides sample switch driver changes for handling protodown. Rocker PHYS disables the port in response to protodown. Signed-off-by: Anuradha Karuppiah Signed-off-

[PATCH net-next v7 0/4] net: Introduce protodown flag.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah User space daemons can detect errors in the network that need to be notified to the switch device drivers. Drivers can react to this error state by doing a phy-down on the switch-port which would result in a carrier-off locally and on the directly connected switch. Doing

[PATCH iproute2 v7 4/4] ip link: proto_down config and display.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah This patch adds support to set and display protodown on a switch port. The switch driver can handle this error state by doing a phys down on the port. One example user space application setting this flag is a multi-chassis LAG application to handle split-brain situation

[PATCH net-next v7 2/4] netlink: changes for setting and clearing protodown via netlink.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah Signed-off-by: Anuradha Karuppiah Signed-off-by: Andy Gospodarek Signed-off-by: Roopa Prabhu Signed-off-by: Wilson Kok --- include/uapi/linux/if_link.h |1 + net/core/rtnetlink.c | 16 ++-- 2 files changed, 15 insertions(+), 2 deletions(-)

Re: [PATCH v2] README: clarify redistribution requirements covering patents

2015-07-14 Thread Kyle McMartin
On Thu, Jun 11, 2015 at 06:02:56PM -0700, Luis R. Rodriguez wrote: > On Thu, May 28, 2015 at 5:48 PM, Luis R. Rodriguez wrote: > > On Tue, May 19, 2015 at 1:22 PM, Luis R. Rodriguez > > wrote: > >> This v2 just changes "licence" to "license" as requested by Arend. > > > > Please let me know if th

Re: [PATCH net-next v6 3/4] rocker: Handle protodown notifications.

2015-07-14 Thread Anuradha Karuppiah
On Tue, Jul 14, 2015 at 9:42 AM, Sergei Shtylyov wrote: > Hello. > > On 07/14/2015 06:32 PM, anurad...@cumulusnetworks.com wrote: > >> From: Anuradha Karuppiah > > >> protodown can be set by user space applications like MLAG on detecting >> errors on a switch port. This patch provides sample swit

Re: [PATCH 2/3] of_mdio: add new DT property 'managed' to specify the PHY management type

2015-07-14 Thread Stas Sergeev
14.07.2015 20:51, Florian Fainelli пишет: On 14/07/15 10:13, Stas Sergeev wrote: Currently the PHY management type is selected by the MAC driver arbitrary. The decision is based on the presence of the "fixed-link" node and on a will of the driver's authors. This caused a regression recently, whe

[PATCH net-next]r8169: Serialise some operations from open close

2015-07-14 Thread Corcodel Marian
This is a multi-part message in MIME format. --mine-boundary-string Content-Type: text/plain; charset=UTF-8; format=fixed Content-Transfer-Encoding: 8bit Serialize some operations from open close function especial when write read from main structure(struct rtl8169_private).Ensure that

[PATCH net] net: bcmgenet: Remove excessive PHY reset

2015-07-14 Thread Florian Fainelli
We are currently issuing multiple PHY resets during a suspend/resume, first during bcmgenet_power_up() which does a hardware reset, then a software reset by calling bcmgenet_mii_reset(). This is both unnecessary and can take as long as 10ms per MDIO transactions while we re-apply workarounds becaus

[PATCH net] tc: act_bpf: fix memory leak

2015-07-14 Thread Alexei Starovoitov
prog->bpf_ops is populated when act_bpf is used with classic BPF and prog->bpf_name is optionally used with extended BPF. Fix memory leak when act_bpf is released. Fixes: d23b8ad8ab23 ("tc: add BPF based action") Fixes: a8cb5f556b56 ("act_bpf: add initial eBPF support for actions") Acked-by: Danie

Re: Fighting out-of-order reception with RPS?

2015-07-14 Thread Oliver Hartkopp
On 14.07.2015 21:03, David Miller wrote: From: Tom Herbert Date: Tue, 14 Jul 2015 11:02:16 -0700 then implement NAPI for CAN drivers as has been suggested now by three very experienced developers. This solves the your OOO problem and moves drivers to NAPI which is the greatly preferred inter

Re: [PATCH 2/2] isdn/gigaset: drop unused ldisc methods

2015-07-14 Thread Paul Bolle
On di, 2015-07-14 at 00:37 +0200, Tilman Schmidt wrote: > The line discipline read and write methods are optional so the dummy > methods in ser_gigaset are unnecessary and can be removed. > > Signed-off-by: Tilman Schmidt Applied. I hope to forward this in a few weeks so that it might be in tim

Re: Fighting out-of-order reception with RPS?

2015-07-14 Thread David Miller
From: Tom Herbert Date: Tue, 14 Jul 2015 11:02:16 -0700 > then implement NAPI for CAN drivers as has been suggested now by > three very experienced developers. This solves the your OOO problem > and moves drivers to NAPI which is the greatly preferred interface. +1 +1 +1 -- To unsubscribe from

Re: [PATCH 1/2] isdn/gigaset: reset tty->receive_room when attaching ser_gigaset

2015-07-14 Thread Paul Bolle
On di, 2015-07-14 at 01:58 +0200, Tilman Schmidt wrote: > Am 14.07.2015 um 01:14 schrieb Peter Hurley: > > That commit didn't cause the problem; it was a bug all along. > > Sure. That's why it is correctly fixed in the Gigaset driver. > But before that commit the bug was never actually triggered.

Re: mmap()ed AF_NETLINK: lockdep and sleep-in-atomic warnings

2015-07-14 Thread Stephen Hemminger
On Tue, 14 Jul 2015 11:50:37 +0200 Florian Westphal wrote: > Thomas Graf wrote: > > On 07/13/15 at 10:11pm, Cong Wang wrote: > > > Caused by: > > > > > > commit 21e4902aea80ef35afc00ee8d2abdea4f519b7f7 > > > Author: Thomas Graf > > > Date: Fri Jan 2 23:00:22 2015 +0100 > > > > > > netli

Re: [PATCH 1/3] fixed_phy: handle link-down case

2015-07-14 Thread Florian Fainelli
On 14/07/15 10:11, Stas Sergeev wrote: > > Currently fixed_phy driver recognizes only the link-up state. > This simple patch adds an implementation of link-down state. > It fixes the status registers when link is down, and also allows > to register the fixed-phy with link down without specifying t

[Patch net] net_sched: fix a use-after-free in sfq

2015-07-14 Thread Cong Wang
Fixes: 25331d6ce42b ("net: sched: implement qstat helper routines") Cc: John Fastabend Signed-off-by: Cong Wang Signed-off-by: Cong Wang --- net/sched/sch_sfq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c index 7d14926..52f75a5 1

[Patch net] fq_codel: fix return value of fq_codel_drop()

2015-07-14 Thread Cong Wang
The ->drop() is supposed to return the number of bytes it dropped, however fq_codel_drop() returns the index of the flow where it drops a packet from. Fix this by introducing a helper to wrap fq_codel_drop(). Cc: Eric Dumazet Signed-off-by: Cong Wang Signed-off-by: Cong Wang --- net/sched/sch

Re: Fighting out-of-order reception with RPS?

2015-07-14 Thread Tom Herbert
On Tue, Jul 14, 2015 at 10:09 AM, Oliver Hartkopp wrote: > On 13.07.2015 06:57, Eric Dumazet wrote: >> >> On Sun, 2015-07-12 at 21:15 +0200, Oliver Hartkopp wrote: >> >>> E.g. with >>> >>> skb_set_hash(skb, dev->ifindex, PKT_HASH_TYPE_L2); >>> >>> and >>> >>> echo f > /sys/class/ne

Re: [PATCH 2/3] of_mdio: add new DT property 'managed' to specify the PHY management type

2015-07-14 Thread Florian Fainelli
On 14/07/15 10:13, Stas Sergeev wrote: > > Currently the PHY management type is selected by the MAC driver arbitrary. > The decision is based on the presence of the "fixed-link" node and on a > will of the driver's authors. > This caused a regression recently, when mvneta driver suddenly started >

Re: [PATCH v1 05/12] IB/cm: Share listening CM IDs

2015-07-14 Thread Jason Gunthorpe
On Tue, Jul 14, 2015 at 11:45:15AM +0300, Haggai Eran wrote: > > Reviewed-By: Jason Gunthorpe > Thanks. > Can I add it with the modifications above? Yep Jason -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordom

[PATCH 3/3] mvneta: use inband status only when explicitly enabled

2015-07-14 Thread Stas Sergeev
The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link state signaling") implemented the link parameters auto-negotiation unconditionally. Unfortunately it appears that some HW that implements SGMII protocol, doesn't generate the inband status, so it is not possible to auto-negotiate

[PATCH 2/3] of_mdio: add new DT property 'managed' to specify the PHY management type

2015-07-14 Thread Stas Sergeev
Currently the PHY management type is selected by the MAC driver arbitrary. The decision is based on the presence of the "fixed-link" node and on a will of the driver's authors. This caused a regression recently, when mvneta driver suddenly started to use the in-band status for auto-negotiation on

[PATCH v2 0/2] Avoid link dependency of dlm on sctp module

2015-07-14 Thread Marcelo Ricardo Leitner
Hi, I'm trying to remove a direct dependency of dlm module on sctp one. Currently dlm code is calling sctp_do_peeloff() directly and this call only is causing the load of sctp module together with dlm. For that, we have basically 3 options: - Doing a module split on dlm - which I'm avoiding beca

[PATCH v2 2/2] dlm: avoid using sctp_do_peeloff directly

2015-07-14 Thread Marcelo Ricardo Leitner
This patch reverts 2f2d76cc3e93 ("dlm: Do not allocate a fd for peeloff") but also makes use of a new sockopt: SCTP_SOCKOPT_PEELOFF_KERNEL, which avoids allocating file descriptors while doing this operation. By this we avoid creating a direct dependency from dlm to sctp module, which can then be

[PATCH v2 1/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

2015-07-14 Thread Marcelo Ricardo Leitner
SCTP has this operation to peel off associations from a given socket and create a new socket using this association. We currently have two ways to use this operation: - via getsockopt(), on which it will also create and return a file descriptor for this new socket - via sctp_do_peeloff(), which i

[PATCH v3 0/3] net: enable inband link state negotiation only when explicitly requested

2015-07-14 Thread Stas Sergeev
Hello. Currently the link status auto-negotiation is enabled for any SGMII link with fixed-link DT binding. The regression was reported: https://lkml.org/lkml/2015/7/8/865 Apparently not all HW that implements SGMII protocol, generates the inband status for the auto-negotiation to work. More detai

[PATCH 1/3] fixed_phy: handle link-down case

2015-07-14 Thread Stas Sergeev
Currently fixed_phy driver recognizes only the link-up state. This simple patch adds an implementation of link-down state. It fixes the status registers when link is down, and also allows to register the fixed-phy with link down without specifying the speed. Signed-off-by: Stas Sergeev CC: Flor

Re: Fighting out-of-order reception with RPS?

2015-07-14 Thread Oliver Hartkopp
On 13.07.2015 06:57, Eric Dumazet wrote: On Sun, 2015-07-12 at 21:15 +0200, Oliver Hartkopp wrote: E.g. with skb_set_hash(skb, dev->ifindex, PKT_HASH_TYPE_L2); and echo f > /sys/class/net/can0/queues/rx-0/rps_cpus I get properly ordered CAN frames - even with netif_rx() proc

Re: [PATCH net-next 1/3] rhashtable: Add a function for in order insertion in buckets

2015-07-14 Thread Tom Herbert
On Tue, Jul 14, 2015 at 2:57 AM, Herbert Xu wrote: > Tom Herbert wrote: >> The obj_orderfn function may be specified in the parameters for a >> rhashtable. When inserting an element this function is used to order >> objects in a bucket list (greatest to least ordering value).This >> allows entrie

Re: [PATCH net-next v6 3/4] rocker: Handle protodown notifications.

2015-07-14 Thread Sergei Shtylyov
Hello. On 07/14/2015 06:32 PM, anurad...@cumulusnetworks.com wrote: From: Anuradha Karuppiah protodown can be set by user space applications like MLAG on detecting errors on a switch port. This patch provides sample switch driver changes for handling protodown. Rocker PHYS disables the port

Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support

2015-07-14 Thread Michal Kubecek
On Tue, Jul 14, 2015 at 03:42:03PM +0200, Florian Westphal wrote: > Michal Kubecek wrote: > > + case SCTP_CID_HEARTBEAT: > > + pr_debug("SCTP_CID_HEARTBEAT"); > > + i = 9; > > + break; > > + case SCTP_CID_HEARTBEAT_ACK: > > + pr_debug("SCTP_CID_HEARTBEAT

Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support

2015-07-14 Thread Michal Kubecek
On Tue, Jul 14, 2015 at 05:38:47PM +0200, Pablo Neira Ayuso wrote: > On Tue, Jul 14, 2015 at 02:23:11PM +0200, Michal Kubecek wrote: > > @@ -658,6 +696,18 @@ static struct ctl_table sctp_sysctl_table[] = { > > .mode = 0644, > > .proc_handler = proc_dointvec_jiffi

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

2015-07-14 Thread Alexei Starovoitov
On 7/14/15 3:29 AM, Daniel Borkmann wrote: One other thing that comes to mind, not sure if it's worth it though, would be to split the skb->tc_verd's TC_NCLS itself into TC_NCLS/TC_NACT, so that you can go into the classifier, but skip the action part. Since in tcf_action_exec(), we already test

[PATCH net-next] ibmveth: add support for TSO6

2015-07-14 Thread Thomas Falcon
This patch adds support for a new method of signalling the firmware that TSO packets are being sent. The new method removes the need to alter the ip and tcp checksums and allows TSO6 support. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmveth.c | 145 +

Re: [PATCH net-next 2/3] rhashtable: allow lookup function to have compare function agument

2015-07-14 Thread Tom Herbert
On Tue, Jul 14, 2015 at 2:44 AM, Thomas Graf wrote: > On 07/13/15 at 05:39pm, Tom Herbert wrote: >> Added rhashtable_lookup_fast_cmpfn which does a lookup in an rhash table >> with the compare function being taken from an argument. This allows >> different compare functions to be used on the same

Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support

2015-07-14 Thread Pablo Neira Ayuso
On Tue, Jul 14, 2015 at 02:23:11PM +0200, Michal Kubecek wrote: > @@ -658,6 +696,18 @@ static struct ctl_table sctp_sysctl_table[] = { > .mode = 0644, > .proc_handler = proc_dointvec_jiffies, > }, > + { > + .procname = "nf_conntrac

[PATCH iproute2 v6 4/4] ip link: proto_down config and display.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah This patch adds support to set and display protodown on a switch port. The switch driver can handle this error state by doing a phys down on the port. One example user space application setting this flag is a multi-chassis LAG application to handle split-brain situation

[PATCH net-next v6 3/4] rocker: Handle protodown notifications.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah protodown can be set by user space applications like MLAG on detecting errors on a switch port. This patch provides sample switch driver changes for handling protodown. Rocker PHYS disables the port in response to protodown. Signed-off-by: Anuradha Karuppiah Signed-off-

[PATCH net-next v6 1/4] net core: Add protodown support.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah This patch introduces the proto_down flag that can be used by user space applications to notify switch drivers that errors have been detected on the device. The switch driver can react to protodown notification by doing a phys down on the associated switch port. Signed-

[PATCH net-next v6 0/4] net: Introduce protodown flag.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah User space daemons can detect errors in the network that need to be notified to the switch device drivers. Drivers can react to this error state by doing a phy-down on the switch-port which would result in a carrier-off locally and on the directly connected switch. Doing

[PATCH net-next v6 2/4] netlink: changes for setting and clearing protodown via netlink.

2015-07-14 Thread anuradhak
From: Anuradha Karuppiah Signed-off-by: Anuradha Karuppiah Signed-off-by: Andy Gospodarek Signed-off-by: Roopa Prabhu Signed-off-by: Wilson Kok --- include/uapi/linux/if_link.h |1 + net/core/rtnetlink.c | 16 ++-- 2 files changed, 15 insertions(+), 2 deletions(-)

Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

2015-07-14 Thread Tom Herbert
On Tue, Jul 14, 2015 at 5:44 AM, YOSHIFUJI Hideaki/吉藤英明 wrote: > Hi, > > Tom Herbert wrote: >> I am testing this patch which may be a little simpler. Also idev needs >> to be checked after __in6_dev_get > > We have to select source address on *given* interface for link-local/ > multicast destinati

Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT

2015-07-14 Thread Marcel Holtmann
Hi Bastien, > http://thread.gmane.org/gmane.linux.kernel.wireless.general/127706/focu > s=127896 > > Signed-off-by: Bastien Nocera > > --- > net/rfkill/rfkill-gpio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c > index d5d58d9..947

  1   2   >