[PATCH] br2684: Remove unnecessary formatting macros b1 and bs

2015-07-30 Thread Joe Perches
Use vsprintf extension %pI4 instead. Signed-off-by: Joe Perches --- net/atm/br2684.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/net/atm/br2684.c b/net/atm/br2684.c index cc78538..aa0047c 100644 --- a/net/atm/br2684.c +++ b/net/atm/br2684.c @@ -802,13 +802,10 @@

Re: [V4.2] rtlwifi: Fix NULL dereference when PCI driver used as an AP

2015-07-30 Thread Kalle Valo
> From: Luis Felipe Dominguez Vega > > In commit 33511b157bbcebaef853cc1811992b664a2e5862 ("rtlwifi: add support to > send beacon frame"), the mechanism for sending beacons was established. That > patch works correctly for rtl8192cu, but there is a possibility of getting > the following warnings

Re: [v2] rsi: Fix failure to load firmware after memory leak fix and fixthe leak

2015-07-30 Thread Kalle Valo
> Fixes commit eae79b4f3e82 ("rsi: fix memory leak in > rsi_load_ta_instructions()") > which stopped the driver from functioning. > > Firmware data has been allocated using vmalloc(), resulting in memory > that cannot be used for DMA. Hence the firmware was first copied to a > buffer allocated w

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-30 Thread Eric Dumazet
On Thu, 2015-07-30 at 18:51 -0700, Florian Fainelli wrote: > On 30/07/15 15:51, David Miller wrote: > > From: David Miller > > Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) > > > >> This looks fine, series applied, thanks. > > > > I think your control block is too large, you'll need to rework this

Re: [PATCH] MIPS: Remove all the uses of custom gpio.h

2015-07-30 Thread Manuel Lauss
On Thu, Jul 30, 2015 at 7:28 PM, Alban Bedel wrote: > Currently CONFIG_ARCH_HAVE_CUSTOM_GPIO_H is defined for all MIPS > machines, and each machine type provides its own gpio.h. However > only a handful really implement the GPIO API, most just forward > everythings to gpiolib. > > The Alchemy mach

[PATCH net-next 4/4] tuntap: Don't segment multiple tagged packets on tap device

2015-07-30 Thread Toshiaki Makita
Tap devices don't need to segment multiple tagged packets. Signed-off-by: Toshiaki Makita --- drivers/net/tun.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 06a0394..976aa97 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -961,6 +961,7

[PATCH net-next 3/4] bridge: Don't segment multiple tagged packets on bridge device

2015-07-30 Thread Toshiaki Makita
Bridge devices don't need to segment multiple tagged packets since thier ports can segment them. Signed-off-by: Toshiaki Makita --- net/bridge/br_device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index 4ff77a1..0aa8f5c 100644 --- a/net/b

[PATCH net-next 2/4] veth: Don't segment multiple tagged packets on veth device

2015-07-30 Thread Toshiaki Makita
Veth devices don't need to segment multiple tagged packets. Signed-off-by: Toshiaki Makita --- drivers/net/veth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index c8186ff..343592c 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -290,6

[PATCH net-next 0/4] Stacked vlan TSO for virtual devices

2015-07-30 Thread Toshiaki Makita
Basically virtual devices do not need to segment double tagged packets. This patch set adds TSO feature for double tagged packets to several virtual devices, which can be realized by simply setting .ndo_features_check to passthru_features_check. Toshiaki Makita (4): macvlan: Don't segment multip

[PATCH net-next 1/4] macvlan: Don't segment multiple tagged packets on macvlan device

2015-07-30 Thread Toshiaki Makita
Macvlan/macvtap devices don't need to segment multiple tagged packets since the lower devices can segment them. Signed-off-by: Toshiaki Makita --- drivers/net/macvlan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 9f59f17..47da435 100644

Re: iproute2: ip batch processing problem

2015-07-30 Thread Eric Dumazet
On Fri, 2015-07-31 at 08:34 +0300, Antti Paila wrote: > Should the batch mode support mixed IPv4 and IPv6 addresses and if so, > would it make sense to clear the 'preferred_family' variable > before processing each line of the batch file? This makes sense, please send a patch. Thanks ! -- To un

iproute2: ip batch processing problem

2015-07-30 Thread Antti Paila
Hello, I am facing an issue when configuring network interfaces with "ip -force -batch" command. The problem occurs when the batch file contains commands with both IPv4 and IPv6 addresses. If I run the following commands in batch mode: tunnel add tunnel1 mode gre tos 1 local 192.168.0.1 remot

RE: how to access PHY's registers from user space

2015-07-30 Thread Shaohui Xie
Sorry! I have to re-send the email since previous one was rejected due to HTML format. Best Regards, Shaohui Xie From: Xie Shaohui-B21989 Sent: Friday, July 31, 2015 12:09 PM To: netdev@vger.kernel.org; 'David Miller' Subject: how to access PHY's registers from user space Hello All, Is there a

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-30 Thread Chris Packham
Hi Florian, On 07/31/2015 01:51 PM, Florian Fainelli wrote: > On 30/07/15 15:51, David Miller wrote: >> From: David Miller >> Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) >> >>> This looks fine, series applied, thanks. >> >> I think your control block is too large, you'll need to rework this >> so

Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-07-30 Thread Pravin Shelar
On Thu, Jul 30, 2015 at 11:12 AM, Joe Stringer wrote: > Signed-off-by: Joe Stringer > --- > net/openvswitch/vport.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c > index d14f594..baa018f 100644 > --- a/net/openvswitch/vport.c > +++

[PATCH net-next] r8152: disable the capability of zero length

2015-07-30 Thread Hayes Wang
The UEFI driver would enable zero length, and the Linux driver doesn't need it. Zero length let the hw complete the transfer with length 0, when there is no received packet. It would add the load of USB host controller and reduce the performance. Signed-off-by: Hayes Wang --- drivers/net/usb/r81

[PATCH net-next] vxlan: expose COLLECT_METADATA flag to user space

2015-07-30 Thread Alexei Starovoitov
Two vxlan driver flags FLOWBASED and COLLECT_METADATA need to be set to make use of its new flow mode. The former already exposed. Expose the latter. Signed-off-by: Alexei Starovoitov --- drivers/net/vxlan.c |5 + include/uapi/linux/if_link.h |1 + 2 files changed, 6 inserti

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-30 Thread Florian Fainelli
On 30/07/15 15:51, David Miller wrote: > From: David Miller > Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) > >> This looks fine, series applied, thanks. > > I think your control block is too large, you'll need to rework this > somehow. So napi_gro_cb really is 48 bytes on 64-bits architectures (

RE: [PATCH][v2] net: phy: add driver for aquantia phy

2015-07-30 Thread Shaohui Xie
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, July 31, 2015 6:55 AM > To: shh@gmail.com > Cc: netdev@vger.kernel.org; f.faine...@gmail.com; Xie Shaohui-B21989 > Subject: Re: [PATCH][v2] net: phy: add driver for aquantia phy > > From: > Date: Th

linux-next: manual merge of the net-next tree with the net tree

2015-07-30 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/ti/netcp_ethss.c between commit: 31a184b7acbc ("net: netcp: ethss: cleanup gbe_probe() and gbe_remove() functions") from the net tree and commit: 489e8a2f09d7 ("net: netcp: Fixes to CPSW stati

[Patch net] act_mirred: avoid calling tcf_hash_release() when binding

2015-07-30 Thread Cong Wang
When we share an action within a filter, the bind refcnt should increase, therefore we should not call tcf_hash_release(). Cc: Jamal Hadi Salim Cc: Daniel Borkmann Signed-off-by: Cong Wang Signed-off-by: Cong Wang --- net/sched/act_mirred.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH net-next 00/12] tipc: separate link aggregation from link layer

2015-07-30 Thread David Miller
From: Jon Maloy Date: Thu, 30 Jul 2015 18:24:14 -0400 > We continue the work on separating the roles of the link aggregation and > link layers, as well as making code cleanups in general. > > This second commit batch focuses on moving the orchestration of link > failover and synchronization to t

[Patch net] act_pedit: check binding before calling tcf_hash_release()

2015-07-30 Thread Cong Wang
When we share an action within a filter, the bind refcnt should increase, therefore we should not call tcf_hash_release(). Cc: Jamal Hadi Salim Cc: Daniel Borkmann Signed-off-by: Cong Wang Signed-off-by: Cong Wang --- net/sched/act_pedit.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletio

Re: [PATCH] ipsec:Fix error handling in the function xfrm6_get_addr

2015-07-30 Thread Herbert Xu
On Thu, Jul 30, 2015 at 12:20:40PM -0400, Nicholas Krause wrote: > > diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c > index ed0583c..f60c670 100644 > --- a/net/ipv6/xfrm6_policy.c > +++ b/net/ipv6/xfrm6_policy.c > @@ -61,7 +61,9 @@ static int xfrm6_get_saddr(struct net *net, >

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-30 Thread Florian Fainelli
On 30/07/15 15:51, David Miller wrote: > From: David Miller > Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) > >> This looks fine, series applied, thanks. > > I think your control block is too large, you'll need to rework this > somehow. Interesting, this only seems to show up with 64-bits build,

Re: pull request: bluetooth-next 2015-07-30

2015-07-30 Thread David Miller
From: Johan Hedberg Date: Thu, 30 Jul 2015 20:34:48 +0300 > Here's a set of Bluetooth & 802.15.4 patches intended for the 4.3 kernel. > > - Cleanups & fixes to mac802154 > - Refactoring of Intel Bluetooth HCI driver > - Various coding style fixes to Bluetooth HCI drivers > - Support for Inte

Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-07-30 Thread Joe Stringer
On 30 July 2015 at 11:40, Thomas Graf wrote: > On 07/30/15 at 11:12am, Joe Stringer wrote: >> Signed-off-by: Joe Stringer > > Can you write a few lines on why this is needed? I have flows which > use the mark to communicate with netfilter through internal ports. The problem I was seeing is when

Re: ipv4/udp: Verify multicast group is ours in upd_v4_early_demux()

2015-07-30 Thread Kenneth Klette Jonassen
On Thu, Jul 30, 2015 at 11:32 PM, Shawn Bohrer wrote: > On Thu, Jul 30, 2015 at 10:26:08PM +0200, Kenneth Klette Jonassen wrote: >> Commit 6e54030 breaks the IP_MULTICAST_ALL socket option. There is >> already a check in ip_mc_sf_allow() that should do the filtering you >> claim to fix. Was it con

Re: [PATCH net-next 0/3] ipv6: Turn on auto IPv6 flow labels by default

2015-07-30 Thread David Miller
From: Tom Herbert Date: Thu, 30 Jul 2015 09:54:19 -0700 > BSD (MacOS) has already turned on flow labels by default and this does > not seem to be causing any problems in the Internet. Let's go ahead > and turn them on by default. We'll continue to monitor for any devices > start choking on them.

Re: [PATCH v2] net/phy: micrel: Reenable interrupts during resume

2015-07-30 Thread Nathan Sullivan
On Thu, Jul 30, 2015 at 10:00:34AM -0700, David Miller wrote: > From: Nathan Sullivan > Date: Thu, 30 Jul 2015 10:15:48 -0500 > > > Changes for V2: Actually make sure it compiles this time. > > If V1 didn't compile, even for you, then I have a big problem. > > And that problem is that you didn'

[REGRESSION] stmmac_platform: Unknown symbol devm_kmalloc (err 0)

2015-07-30 Thread Igor Gnatenko
Hi all, stmmac driver doesn't work on cubietruck (and some more devices like PcDuino3 Nano[0]). This error comes from converting dwmac-sunxi to platform driver. stmmac_platform: module license 'unspecified' taints kernel. Disabling lock debugging due to kernel taint stmmac_platform: Unknown symbo

Re: [PATCH v2 net] net: sk_clone_lock() should only do get_net() if the parent is not a kernel socket

2015-07-30 Thread David Miller
From: Sowmini Varadhan Date: Thu, 30 Jul 2015 15:50:36 +0200 > > > The newsk returned by sk_clone_lock should hold a get_net() > reference if, and only if, the parent is not a kernel socket > (making this similar to sk_alloc()). > > E.g,. for the SYN_RECV path, tcp_v4_syn_recv_sock->..inet_csk

Re: [[PATCH net-next v5] net/ipv6: add sysctl option accept_ra_min_hop_limit

2015-07-30 Thread David Miller
From: YOSHIFUJI Hideaki Date: Thu, 30 Jul 2015 15:34:21 +0900 > Hangbin Liu wrote: >> Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") >> disabled accept hop limit from RA if it is smaller than the current hop >> limit for security stuff. But this behavior kind of break the R

Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-30 Thread David Miller
From: Tom Herbert Date: Wed, 29 Jul 2015 13:49:03 -0700 > The intent of this function was to produce a consistent hash for both > directions of a flow. However, since we added more inputs to the flow > hashing (IPv6 flow labels for instance) in a lot of cases we won't get > the same hash computed

Re: [PATCH][v2] net: phy: add driver for aquantia phy

2015-07-30 Thread David Miller
From: Date: Thu, 30 Jul 2015 12:17:15 +0800 > +static int aquantia_soft_reset(struct phy_device *phydev) > +{ > + return 0; > +} > + > +static int aquantia_config_init(struct phy_device *phydev) > +{ > + return 0; > +} You shouldn't need to implement these methods at all, just leave them

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-30 Thread David Miller
From: David Miller Date: Thu, 30 Jul 2015 14:19:35 -0700 (PDT) > This looks fine, series applied, thanks. I think your control block is too large, you'll need to rework this somehow. In function ‘dsa_copy_brcm_tag’, inlined from ‘bcm_sysport_desc_rx’ at drivers/net/ethernet/broadcom/bcmsys

Re: [PATCH net-next 1/4] net: bcmgenet: Add netconsole support

2015-07-30 Thread Petri Gynther
On Thu, Jul 30, 2015 at 2:04 PM, Petri Gynther wrote: > On Thu, Jul 30, 2015 at 12:35 PM, Florian Fainelli > wrote: >> >> Implement a poll controller for netconsole which invokes the RX >> interrupt handler to poll for incoming packets, and cleans up all TX >> queues. >> >> Signed-off-by: Florian

[PATCH net-next] bpf: add helpers to access tunnel metadata

2015-07-30 Thread Alexei Starovoitov
Introduce helpers to let eBPF programs attached to TC manipulate tunnel metadata: bpf_skb_[gs]et_tunnel_key(skb, key, size, flags) skb: pointer to skb key: pointer to 'struct bpf_tunnel_key' size: size of 'struct bpf_tunnel_key' flags: room for future extensions First eBPF program that uses these

[PATCH net-next 01/12] tipc: eliminate function tipc_link_activate()

2015-07-30 Thread Jon Maloy
The function tipc_link_activate() is redundant, since it mostly performs settings that have already been done in a preceding tipc_link_reset(). There are three exceptions to this: - The actual state change to TIPC_LINK_WORKING. This should anyway be done in the FSM, and not in a separate functio

[PATCH net-next 11/12] tipc: use temporary, non-protected skb queue for bundle reception

2015-07-30 Thread Jon Maloy
Currently, when we extract small messages from a message bundle, or when many messages have accumulated in the link arrival queue, those messages are added one by one to the lock protected link input queue. This may increase contention with the reader of that queue, in the function tipc_sk_rcv().

[PATCH net-next 06/12] tipc: move protocol message sending away from link FSM

2015-07-30 Thread Jon Maloy
The implementation of the link FSM currently takes decisions about and sends out link protocol messages. This is unnecessary, since such actions are not the result of any link state change, and are even decided based on non-FSM state information ("silent_intv_cnt"). We now move the sending of unic

[PATCH net-next 10/12] tipc: remove implicit message delivery in node_unlock()

2015-07-30 Thread Jon Maloy
After the most recent changes, all access calls to a link which may entail addition of messages to the link's input queue are postpended by an explicit call to tipc_sk_rcv(), using a reference to the correct queue. This means that the potentially hazardous implicit delivery, using tipc_node_unlock

[PATCH net-next 07/12] tipc: merge link->exec_mode and link->state into one FSM

2015-07-30 Thread Jon Maloy
Until now, we have been handling link failover and synchronization by using an additional link state variable, "exec_mode". This variable is not independent of the link FSM state, something causing a risk of inconsistencies, apart from the fact that it clutters the code. The conditions are now in

[PATCH net-next 12/12] tipc: clean up link creation

2015-07-30 Thread Jon Maloy
We simplify the link creation function tipc_link_create() and the way the link struct it is connected to the node struct. In particular, we remove the duplicate initialization of some fields which are anyway set in tipc_link_reset(). Tested-by: Ying Xue Signed-off-by: Jon Maloy --- net/tipc/cor

[PATCH net-next 09/12] tipc: make resetting of links non-atomic

2015-07-30 Thread Jon Maloy
In order to facilitate future improvements to the locking structure, we want to make resetting and establishing of links non-atomic. I.e., the functions tipc_node_link_up() and tipc_node_link_down() should be called from outside the node lock context, and grab/release the node lock themselves. This

[PATCH net-next 05/12] tipc: move link synch and failover to link aggregation level

2015-07-30 Thread Jon Maloy
Link failover and synchronization have until now been handled by the links themselves, forcing them to have knowledge about and to access parallel links in order to make the two algorithms work correctly. In this commit, we move the control part of this functionality to the link aggregation level

[PATCH net-next 08/12] tipc: move received discovery data evaluation inside node.c

2015-07-30 Thread Jon Maloy
The node lock is currently grabbed and and released in the function tipc_disc_rcv() in the file discover.c. As a preparation for the next commits, we need to move this node lock handling, along with the code area it is covering, to node.c. This commit introduces this change. Tested-by: Ying Xue

[PATCH net-next 03/12] tipc: reverse call order for link_reset()->node_link_down()

2015-07-30 Thread Jon Maloy
In many cases the call order when a link is reset goes as follows: tipc_node_xx()->tipc_link_reset()->tipc_node_link_down() This is not the right order if we want the node to be in control, so in this commit we change the order to: tipc_node_xx()->tipc_node_link_down()->tipc_link_reset() The fact

[PATCH net-next 02/12] tipc: move all link_reset() calls to link aggregation level

2015-07-30 Thread Jon Maloy
In line with our effort to let the node level have full control over its links, we want to move all link reset calls from link.c to node.c. Some of the calls can be moved by simply moving the calling function, when this is the right thing to do. For the remaining calls we use the now established te

[PATCH net-next 00/12] tipc: separate link aggregation from link layer

2015-07-30 Thread Jon Maloy
We continue the work on separating the roles of the link aggregation and link layers, as well as making code cleanups in general. This second commit batch focuses on moving the orchestration of link failover and synchronization to the node level, as well as preparing the node lock structure for fu

[PATCH net-next 04/12] tipc: extend node FSM

2015-07-30 Thread Jon Maloy
In the next commit, we will move link synch/failover orchestration to the link aggregation level. In order to do this, we first need to extend the node FSM with two more states, NODE_SYNCHING and NODE_FAILINGOVER, plus four new events to enter and leave those states. This commit introduces this ch

RE: Panic with demuxed ipv4 multicast udp sockets on 4.0.4

2015-07-30 Thread Gregory Hoggarth
Hi Eric, Thanks for the patch. I have put this into our code and we'll run our test over tonight and the weekend and report back on Monday. Thanks, Greg From: Eric Dumazet Sent: Thursday, 30 July 2015 5:45 p.m. To: Gregory Hoggarth Cc: Shawn Bohrer; net

[PATCH] ixgbe: Limit lowest interrupt rate for adaptive interrupt moderation to 12K

2015-07-30 Thread Alexander Duyck
This patch updates the lowest limit for adaptive interrupt interrupt moderation to roughly 12K interrupts per second. The way I came about reaching 12K as the desired interrupt rate is by testing with UDP flows. Specifically I had a simple test that ran a netperf UDP_STREAM test at varying sizes.

Re: [PATCH] packet: Allow packets with only a header (but no payload)

2015-07-30 Thread Martin Blumenstingl
On Wed, Jul 29, 2015 at 8:05 AM, Willem de Bruijn wrote: > Martin, to return to your initial statement that PPPoE PADI packets can > have a zero payload: the PPPoE RFC states that PADI packets "MUST > contain exactly one TAG of TAG_TYPE Service-Name, indicating the > service the Host is requesting

[PATCH iproute2 v2] bridge fdb: add 'use' option to set NTF_USE flag in fdb add requests

2015-07-30 Thread Roopa Prabhu
From: Roopa Prabhu This is similar to command options corresponding to other NTF_* flags already exposed to the user space (examples self/master). Also updates bridge man page (The man page patch also includes a fix to the 'self' entry and documents 'master' for fdb entries) Signed-off-by: Roop

Re: [PATCH RFC net-next 3/3] net/core/sock.c: sk_clone_lock() should only do get_net() if the parent is not a kernel socket

2015-07-30 Thread Eric Dumazet
On Thu, 2015-07-30 at 11:29 -0700, Cong Wang wrote: > On Thu, Jul 30, 2015 at 6:06 AM, Eric Dumazet wrote: > > CC Eric Biederman > > > > It looks this should be submitted for 'net' tree, not 'net-next' > > > > It only affects TCP kernel sockets, and we only have few use cases in tree, > and it l

Re: ipv4/udp: Verify multicast group is ours in upd_v4_early_demux()

2015-07-30 Thread Shawn Bohrer
On Thu, Jul 30, 2015 at 10:26:08PM +0200, Kenneth Klette Jonassen wrote: > Commit 6e54030 breaks the IP_MULTICAST_ALL socket option. There is > already a check in ip_mc_sf_allow() that should do the filtering you > claim to fix. Was it considered? > > Commit message: > 421b3885bf6d56391297844f43fb7

Re: [PATCH net] net: sched: fix refcount imbalance in actions

2015-07-30 Thread David Miller
From: Daniel Borkmann Date: Wed, 29 Jul 2015 23:35:25 +0200 > Since commit 55334a5db5cd ("net_sched: act: refuse to remove bound action > outside"), we end up with a wrong reference count for a tc action. ... > What happens is that in tcf_hash_check(), we check tcf_common for a given > index and

Re: [PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-30 Thread David Miller
From: Florian Fainelli Date: Wed, 29 Jul 2015 15:32:37 -0700 > This patch series adds two new feature flags to allow Ethernet controllers > capable of doing Ethernet switch proprietary tag insertion/extraction to > benefit from that. > > The last two patches modify the Broadcom tag parsing code

Re: [PATCH] net: phy: spi_ks8995: clean up ks8995_registers_read/write

2015-07-30 Thread David Miller
From: Vladimir Zapolskiy Date: Thu, 30 Jul 2015 00:44:20 +0300 > The change removes redundant sysfs binary file boundary checks, > since this task is already done on caller side in fs/sysfs/file.c > > Signed-off-by: Vladimir Zapolskiy Applied to net-next, thanks. -- To unsubscribe from this li

Re: [PATCH net v3 0/2] r8152: device reset

2015-07-30 Thread David Miller
From: Hayes Wang Date: Wed, 29 Jul 2015 20:39:07 +0800 > v3: > For patch #2, remove cancel_delayed_work(). > > v2: > For patch #1, remove usb_autopm_get_interface(), usb_autopm_put_interface(), > and > the checking of intf->condition. > > For patch #2, replace the original method with usb_queu

Re: [PATCH net-next v5 0/2] af_mpls: fix undefined reference to ip6_route_output with CONFIG_IPV6=n

2015-07-30 Thread David Miller
From: roopa Date: Thu, 30 Jul 2015 13:38:14 -0700 > but was only concerned about ipv6 module unload. It is not possible to unload the ipv6 module. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [PATCH net-next] r8169:Place dma_alloc_coherent on interrupt context

2015-07-30 Thread Francois Romieu
Corcodel Marian : >According to this doc > https://www.kernel.org/doc/Documentation/DMA-API.txt dma_alloc_coherent > must run on interrupt context, and flush the chip before use. You have misunderstood what an irq context is. -- Ueimor -- To unsubscribe from this list: send the line "un

Re: [PATCH net-next] r8169:Place dma_alloc_coherent on interrupt context

2015-07-30 Thread David Miller
From: Corcodel Marian Date: Thu, 30 Jul 2015 22:33:21 +0300 >According to this doc > https://www.kernel.org/doc/Documentation/DMA-API.txt dma_alloc_coherent > must run on interrupt context, and flush the chip before use. > > Signed-off-by: Corcodel Marian > > diff --git a/drivers/net/e

Re: [PATCH net-next v5 0/2] af_mpls: fix undefined reference to ip6_route_output with CONFIG_IPV6=n

2015-07-30 Thread roopa
On 7/30/15, 7:57 AM, Hannes Frederic Sowa wrote: On Thu, 2015-07-30 at 06:22 -0700, roopa wrote: On 7/29/15, 10:42 PM, David Miller wrote: From: Roopa Prabhu Date: Tue, 28 Jul 2015 15:27:39 -0700 v4 - v5: Use ipv6_stub_impl.ipv6_dst_lookup as suggested by Hannes I think this might not work.

[PATCH net-next v6 2/2] af_mpls: fix undefined reference to ip6_route_output

2015-07-30 Thread Roopa Prabhu
From: Roopa Prabhu Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch uses ipv6_stub_impl.ipv6_dst_lookup instead of ip6_route_output. And wraps affected code under IS_ENABLED(CONFIG_INET) and IS_ENABLED(CONFIG_IPV6). Report

[PATCH net-next v6 0/2] af_mpls: fix undefined reference to ip6_route_output with CONFIG_IPV6=n

2015-07-30 Thread Roopa Prabhu
From: Roopa Prabhu This patch series uses ipv6_stub_impl.ipv6_dst_lookup instead of ip6_route_output. Follows the vxlan drivers usage of ipv6_stub_impl.ipv6_dst_lookup. There is no sk in the af_mpls context from where ipv6_stub_impl.ipv6_dst_lookup is used. sk appears to be needed to get the na

[PATCH net-next v6 1/2] ipv6: change ipv6_stub_impl.ipv6_dst_lookup to take net argument

2015-07-30 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds net argument to ipv6_stub_impl.ipv6_dst_lookup for use cases where sk is not available (like mpls). sk appears to be needed to get the namespace 'net' and is optional otherwise. This patch series changes ipv6_stub_impl.ipv6_dst_lookup to take net argument. sk re

Re: ipv4/udp: Verify multicast group is ours in upd_v4_early_demux()

2015-07-30 Thread Kenneth Klette Jonassen
Commit 6e54030 breaks the IP_MULTICAST_ALL socket option. There is already a check in ip_mc_sf_allow() that should do the filtering you claim to fix. Was it considered? Commit message: 421b3885bf6d56391297844f43fb7154a6396e12 "udp: ipv4: Add udp early demux" introduced a regression that allowed so

Re: [PATCH] MAINTAINERS: add arcnet and take maintainership

2015-07-30 Thread Joe Perches
On Thu, 2015-07-30 at 15:30 +0200, Michael Grzeschik wrote: > Add entry for arcnet to MAINTAINERS file and add myself as the > maintainer of the subsystem. [] > As I have a test coverage of com20020 based arcnet systems > I would like to take the responsibility of maintaining the subsystem. Best o

Re: [PATCH] MIPS: Remove all the uses of custom gpio.h

2015-07-30 Thread Jonas Gorski
Hi, On Thu, Jul 30, 2015 at 7:28 PM, Alban Bedel wrote: > Currently CONFIG_ARCH_HAVE_CUSTOM_GPIO_H is defined for all MIPS > machines, and each machine type provides its own gpio.h. However > only a handful really implement the GPIO API, most just forward > everythings to gpiolib. > > The Alchemy

Re: [PATCH net] net: sched: fix refcount imbalance in actions

2015-07-30 Thread Daniel Borkmann
On 07/30/2015 08:48 PM, Cong Wang wrote: ... Right, I think your patch should be fine for net. The code is kinda messy, but we can always clean up the logic for net-next. I agree with you. I.e. there could just be a single refcount taking care of the cleanup/destruction, etc. Reviewed-by: Con

[PATCH net-next 1/1] Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver

2015-07-30 Thread Woojung.Huh
Repost patch of driver for LAN7800 family of USB 2.0 & USB 3.0 to Gigabit Ethernet. - remove module param which can be configurable by standard mechanism. - remove other module parms except msg_level per review comment. - update to handle byte swap for statistics structure correctly. Signed-off-b

Re: [PATCH] netcp:Fix error checking in the function gbe_open

2015-07-30 Thread Murali Karicheri
On 07/30/2015 02:27 PM, Nicholas Krause wrote: This fixes error checking in the function gbe_open by checking if the function netcp_register_txhook has failed by returning a error code and if so jump to the goto label fail for handling internal failures in this function. Signed-off-by: Nicholas

Re: [PATCH net-next 3/4] net: dsa: Refactor transmit path

2015-07-30 Thread Florian Fainelli
On 30/07/15 12:35, Florian Fainelli wrote: > All tagging protocols do the same thing: increment device statistics, > make room for the tag to be inserted, create the tag, invoke the parent > network device transmit function. > > In order to prepare for adding netpoll support, which requires the ta

[PATCH net-next 2/4] net: systemport: Add netconsole support

2015-07-30 Thread Florian Fainelli
Implement a poll controller for netconsole which invokes the RX interrupt handler to poll for incoming packets, and cleans up all TX queues. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/n

[PATCH net-next 1/4] net: bcmgenet: Add netconsole support

2015-07-30 Thread Florian Fainelli
Implement a poll controller for netconsole which invokes the RX interrupt handler to poll for incoming packets, and cleans up all TX queues. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drive

[PATCH net-next 3/4] net: dsa: Refactor transmit path

2015-07-30 Thread Florian Fainelli
All tagging protocols do the same thing: increment device statistics, make room for the tag to be inserted, create the tag, invoke the parent network device transmit function. In order to prepare for adding netpoll support, which requires the tag creation, but not using the parent network device t

[PATCH net-next 4/4] net: dsa: Add netconsole support

2015-07-30 Thread Florian Fainelli
Add support for using DSA slave network devices with netconsole, which requires us to allocate and free custom netpoll instances and invoke the parent network device poll controller callback. In order for netconsole to work, we need to construct the DSA tag, but not queue the skb for transmission

[PATCH net-next 0/4] net: GENET, SYSTEMPORT and DSA netconsole

2015-07-30 Thread Florian Fainelli
Hi all, This patch series adds support for netconsole in the GENET, SYSTEMPORT and DSA drivers. A small refactoring to the DSA transmit path is required to avoid duplicating the dsa_netpoll_send_skb() into each and every tagging protocol supported. Testing on e.g: mv643xx_eth and/or e1000e would

Re: [PATCH net-next 3/9] openvswitch: Move MASKED* macros to datapath.h

2015-07-30 Thread Thomas Graf
On 07/30/15 at 11:12am, Joe Stringer wrote: > This will allow the ovs-conntrack code to reuse these macros. > > Signed-off-by: Joe Stringer Acked-by: Thomas Graf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More major

Re: [PATCH net-next 4/9] ipv6: Export nf_ct_frag6_gather()

2015-07-30 Thread Thomas Graf
On 07/30/15 at 11:12am, Joe Stringer wrote: > Signed-off-by: Joe Stringer Acked-by: Thomas Graf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next 2/9] openvswitch: Serialize acts with original netlink len

2015-07-30 Thread Thomas Graf
On 07/30/15 at 11:12am, Joe Stringer wrote: > Previously, we used the kernel-internal netlink actions length to > calculate the size of messages to serialize back to userspace. > However,the sw_flow_actions may not be formatted exactly the same as the > actions on the wire, so store the original ac

[PATCH net-next] r8169:Place dma_alloc_coherent on interrupt context

2015-07-30 Thread Corcodel Marian
According to this doc https://www.kernel.org/doc/Documentation/DMA-API.txt dma_alloc_coherent must run on interrupt context, and flush the chip before use. Signed-off-by: Corcodel Marian diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 3df51f

Re: [PATCH net] net: sched: fix refcount imbalance in actions

2015-07-30 Thread Cong Wang
On Wed, Jul 29, 2015 at 5:55 PM, Daniel Borkmann wrote: > Hm, so this seems not correct: if we only ever increase tcfc_refcnt > when there's bind=1, and only ever decrease when bind=1, then we > will never free the action as we do start out from ref=1 in case > it has been added without initial bi

Re: [PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-07-30 Thread Thomas Graf
On 07/30/15 at 11:12am, Joe Stringer wrote: > Signed-off-by: Joe Stringer Can you write a few lines on why this is needed? I have flows which use the mark to communicate with netfilter through internal ports. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: [PATCH RFC net-next 3/3] net/core/sock.c: sk_clone_lock() should only do get_net() if the parent is not a kernel socket

2015-07-30 Thread Cong Wang
On Thu, Jul 30, 2015 at 6:06 AM, Eric Dumazet wrote: > On Thu, 2015-07-30 at 04:55 -0400, Sowmini Varadhan wrote: >> The newsk returned by sk_clone_lock should hold a get_net() >> reference if, and only if, the parent is not a kernel socket >> (making this similar to sk_alloc()). >> >> E.g,. for t

[PATCH net-next 1/9] openvswitch: Scrub packet in ovs_vport_receive()

2015-07-30 Thread Joe Stringer
Signed-off-by: Joe Stringer --- net/openvswitch/vport.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c index d14f594..baa018f 100644 --- a/net/openvswitch/vport.c +++ b/net/openvswitch/vport.c @@ -475,6 +475,9 @@ void ovs_vport_receive(str

Re: [PATCH] ARCNET: fix hard_header_len limit

2015-07-30 Thread David Miller
From: Michael Grzeschik Date: Thu, 30 Jul 2015 15:34:36 +0200 > The commit <9c7077622dd9> ("packet: make packet_snd fail on len smaller > than l2 header") adds the check for minimum packet length of the used l2. > For arcnet the hardware header length is not the complete archdr which > includes h

[PATCH net-next 3/9] openvswitch: Move MASKED* macros to datapath.h

2015-07-30 Thread Joe Stringer
This will allow the ovs-conntrack code to reuse these macros. Signed-off-by: Joe Stringer --- net/openvswitch/actions.c | 52 ++ net/openvswitch/datapath.h | 4 2 files changed, 29 insertions(+), 27 deletions(-) diff --git a/net/openvswitch/act

[PATCH net-next 0/9] OVS conntrack support

2015-07-30 Thread Joe Stringer
The goal of this series is to allow OVS to send packets through the Linux kernel connection tracker, and subsequently match on fields populated by conntrack. This version includes new handling of IPv4 and IPv6 fragments, support for conntrack labels, and tracking connections via helpers. The kerne

[PATCH net-next 4/9] ipv6: Export nf_ct_frag6_gather()

2015-07-30 Thread Joe Stringer
Signed-off-by: Joe Stringer --- net/ipv6/netfilter/nf_conntrack_reasm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c index 6f187c8..ce3d5d8 100644 --- a/net/ipv6/netfilter/nf_conntrack_reasm.c +++ b/net/ipv6

[PATCH net-next 2/9] openvswitch: Serialize acts with original netlink len

2015-07-30 Thread Joe Stringer
Previously, we used the kernel-internal netlink actions length to calculate the size of messages to serialize back to userspace. However,the sw_flow_actions may not be formatted exactly the same as the actions on the wire, so store the original actions length when de-serializing and re-use the orig

[PATCH net-next 7/9] netfilter: Always export nf_connlabels_replace()

2015-07-30 Thread Joe Stringer
The following patches will reuse this code from OVS. Signed-off-by: Joe Stringer --- net/netfilter/nf_conntrack_labels.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/netfilter/nf_conntrack_labels.c b/net/netfilter/nf_conntrack_labels.c index bb53f12..daa7c13 100644 --- a/net/netfilt

[PATCH net-next 9/9] openvswitch: Allow attaching helpers to ct action

2015-07-30 Thread Joe Stringer
Add support for using conntrack helpers to assist protocol detection. The new OVS_CT_ATTR_HELPER attribute of the ct action specifies a helper to be used for this connection. Example ODP flows allowing FTP connections from ports 1->2: in_port=1,tcp,action=ct(helper=ftp,commit),2 in_port=2,tcp,ct_s

[PATCH net-next 6/9] openvswitch: Allow matching on conntrack mark

2015-07-30 Thread Joe Stringer
From: Justin Pettit Allow matching and setting the conntrack mark field. As with conntrack state and zone, these are populated by executing the ct() action. Unlike these, the ct_mark is also a writable field. The set_field() action may be used to modify the mark, which will take effect on the mos

[PATCH net-next 8/9] openvswitch: Allow matching on conntrack label

2015-07-30 Thread Joe Stringer
Allow matching and setting the conntrack label field. As with ct_mark, this is populated by executing the ct() action, and is a writable field. The set_field() action may be used to modify the label, which will take effect on the most recent conntrack entry. E.g.: actions:ct(zone=1),set_field(1->c

[PATCH net-next 5/9] openvswitch: Add conntrack action

2015-07-30 Thread Joe Stringer
Expose the kernel connection tracker via OVS. Userspace components can make use of the "ct()" action, followed by "recirculate", to populate the conntracking state in the OVS flow key, and subsequently match on that state. Example ODP flows allowing traffic from 1->2, only replies from 2->1: in_po

Re: [PATCH net-next 0/4] Minor BPF updates

2015-07-30 Thread David Miller
From: Daniel Borkmann Date: Thu, 30 Jul 2015 12:42:45 +0200 > Various minor misc updates. Series applied, thanks Daniel. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/major

Re: [PATCH v2] net/phy: micrel: Reenable interrupts during resume

2015-07-30 Thread Sergei Shtylyov
Hello. On 07/30/2015 06:15 PM, Nathan Sullivan wrote: The ksz9031 has a behavior where it will clear the interrupt enable bits when leaving power down. To work around this, make sure the interrupt bits are in the state they are expected to be when resuming. Signed-off-by: Nathan Sullivan -

  1   2   >