On Wed, Aug 05, 2015 at 10:34:04AM +0800, Jason Wang wrote:
> virtio declares support for NETIF_F_FRAGLIST, but assumes
> that there are at most MAX_SKB_FRAGS + 2 fragments which isn't
> always true with a fraglist.
>
> A longer fraglist in the skb will make the call to skb_to_sgvec overflow
> the
IFLA_VXLAN_FLOWBASED is useless without IFLA_VXLAN_COLLECT_METADATA,
so combine them into single IFLA_VXLAN_COLLECT_METADATA flag.
'flowbased' doesn't convey real meaning of the vxlan tunnel mode.
This mode can be used by routing, tc+bpf and ovs.
Only ovs is strictly flow based, so 'collect metadat
Open the sockets calling sock_create_kern() with the correct struct net
pointer, and use that struct net pointer when verifying the
address passed to rds_bind().
Signed-off-by: Sowmini Varadhan
---
v2: David Ahern comments.
net/rds/bind.c|3 ++-
net/rds/connection.c | 16
This patch series contains the set of changes to correctly set up
the infra for PF_RDS sockets that use TCP as the transport in multiple
network namespaces.
Patch 1 in the series is the minimal set of changes to allow
a single instance of RDS-TCP to run in any (i.e init_net or other) net
namespac
Register pernet subsys init/stop functions that will set up
and tear down per-net RDS-TCP listen endpoints. Unregister
pernet subusys functions on 'modprobe -r' to clean up these
end points.
Enable keepalive on both accept and connect socket endpoints.
The keepalive timer expiration will ensure th
On Tue, Aug 4, 2015 at 8:48 AM, Linus Torvalds
wrote:
> Sorry for the spamming of random rtnetlink people, but I just resumed
> my laptop at PDX, and networking was dead.
>
> It looks like a deadlock on rtnl_mutex, possibly due to some error
> path not releasing the lock. No network op was making
Signed-off-by: Joe Stringer
Acked-by: Thomas Graf
---
net/ipv6/netfilter/nf_conntrack_reasm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c
b/net/ipv6/netfilter/nf_conntrack_reasm.c
index 6d02498..701cd2b 100644
--- a/net/ipv6/netfilter/nf_conntrack
The goal of this series is to allow OVS to send packets through the Linux
kernel connection tracker, and subsequently match on fields populated by
conntrack.
This version addresses the feedback from v2, mostly minor tidyups and a few
corner cases that were missed in v1. The biggest change is rathe
Add functions to change connlabel length into nf_conntrack_labels.c so
they may be reused by other modules like OVS and nftables without
needing to jump through xt_match_check() hoops.
Suggested-by: Florian Westphal
Signed-off-by: Joe Stringer
---
v2: Protect connlabel modification with spinlock
Previously, we used the kernel-internal netlink actions length to
calculate the size of messages to serialize back to userspace.
However,the sw_flow_actions may not be formatted exactly the same as the
actions on the wire, so store the original actions length when
de-serializing and re-use the orig
Add support for using conntrack helpers to assist protocol detection.
The new OVS_CT_ATTR_HELPER attribute of the ct action specifies a helper
to be used for this connection.
Example ODP flows allowing FTP connections from ports 1->2:
in_port=1,tcp,action=ct(helper=ftp,commit),2
in_port=2,tcp,ct_s
From: Justin Pettit
Allow matching and setting the conntrack mark field. As with conntrack
state and zone, these are populated by executing the ct() action. Unlike
these, the ct_mark is also a writable field. The set_field() action may
be used to modify the mark, which will take effect on the mos
Allow matching and setting the conntrack label field. As with ct_mark,
this is populated by executing the ct() action, and is a writable field.
The set_field() action may be used to modify the label, which will take
effect on the most recent conntrack entry.
E.g.: actions:ct(zone=1),set_field(1->c
The following patches will reuse this code from OVS.
Signed-off-by: Joe Stringer
---
net/netfilter/nf_conntrack_labels.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/netfilter/nf_conntrack_labels.c
b/net/netfilter/nf_conntrack_labels.c
index 06e71a0..3ce5c31 100644
--- a/net/netfilt
This will allow the ovs-conntrack code to reuse these macros.
Signed-off-by: Joe Stringer
Acked-by: Thomas Graf
---
net/openvswitch/actions.c | 52 ++
net/openvswitch/datapath.h | 4
2 files changed, 29 insertions(+), 27 deletions(-)
diff --gi
Expose the kernel connection tracker via OVS. Userspace components can
make use of the "ct()" action, followed by "recirculate", to populate
the conntracking state in the OVS flow key, and subsequently match on
that state.
Example ODP flows allowing traffic from 1->2, only replies from 2->1:
in_po
On 1 August 2015 at 12:17, Thomas Graf wrote:
> On 07/31/15 at 10:51am, Joe Stringer wrote:
>> On 31 July 2015 at 07:34, Hannes Frederic Sowa wrote:
>> > In general, this shouldn't be necessary as the packet should already be
>> > scrubbed before they arrive here.
>> >
>> > Could you maybe add a
On Mon, Aug 3, 2015 at 10:29 PM, Sowmini Varadhan
wrote:
> +static struct pernet_operations rds_tcp_net_ops = {
> + .init = rds_tcp_init_net,
> + .exit = rds_tcp_exit_net,
> + .id = &rds_tcp_netid,
> + .size = sizeof(struct rds_tcp_net),
> +};
> +
> +static void rds_tcp_kil
On Tue, Aug 04, 2015 at 07:50:40PM -0700, Pravin Shelar wrote:
>
> I am planning on adding the ip_gre netlink interface later on. OVS
> userspace needs same interface to directly create the GRE device
> without vport-gre module. vport-gre module is compatibility code. If
> you want I can do it in
On Tue, Aug 4, 2015 at 7:39 PM, Nicholas Krause wrote:
> From: Nicholas Krause
>
> This fixes the issue with conncurrent access when calling the function
> inte6_addr_del due to this function using non locked wrapper versions
> of certain functions by locking the routing mutex before and after th
(Cc'ing netdev for network issues)
On Tue, Aug 4, 2015 at 6:42 AM, Shaun Crampton
wrote:
> Please CC me on any responses, thanks.
>
> Setting both ends of a veth to be oper UP completes very quickly but I
> find that pings only start flowing over the veth after about a second.
> This seems to cor
On Tue, Aug 4, 2015 at 7:27 PM, Alexei Starovoitov
wrote:
> On Tue, Aug 04, 2015 at 04:22:35PM -0700, Pravin B Shelar wrote:
>> Following patch adds support for flow based tunnel to GRE
>> tap deivces. Using flow based tunneling, we can implement
>> OVS GRE vport. This patch removes all of the OVS
From: Nicholas Krause
This fixes the issue with conncurrent access when calling the function
inte6_addr_del due to this function using non locked wrapper versions
of certain functions by locking the routing mutex before and after this
call with rtnl_lock/unlock. After the unlocking just return th
virtio declares support for NETIF_F_FRAGLIST, but assumes
that there are at most MAX_SKB_FRAGS + 2 fragments which isn't
always true with a fraglist.
A longer fraglist in the skb will make the call to skb_to_sgvec overflow
the sg array, leading to memory corruption.
Drop NETIF_F_FRAGLIST so we on
On 08/04/2015 07:11 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 8/4/2015 12:55 PM, Jason Wang wrote:
>
>> virtio declares support for NETIF_F_FRAGLIST, but assumes
>> that there are at most MAX_SKB_FRAGS + 2 fragments which isn't
>> always true with a fraglist.
>
>> A longer fraglist in the skb wi
On Tue, Aug 04, 2015 at 04:22:35PM -0700, Pravin B Shelar wrote:
> Following patch adds support for flow based tunnel to GRE
> tap deivces. Using flow based tunneling, we can implement
> OVS GRE vport. This patch removes all of the OVS
> specific GRE code and make OVS use a ip_gre net_device.
> Min
于 2015/8/5 1:55, Alexei Starovoitov 写道:
> On 8/4/15 1:58 AM, Kaixu Xia wrote:
>> +static int check_func_limit(struct bpf_map **mapp, int func_id)
>
> how about 'check_map_func_compatibility' or 'check_map_func_affinity' ?
>
>> +{
>> +struct bpf_map *map = *mapp;
>
> why pass pointer to a poi
This patchset adds support for NV congestion control.
Changes from v4: passing structure as constant in pkts_acked()
Consists of the following patches:
[RFC PATCH v5 net-next 1/4] tcp: replace cnt & rtt with struct in
[RFC PATCH v5 net-next 2/4] tcp: refactor struct tcp_skb_cb
[RFC PATCH v5 net
This is a request for comments.
TCP-NV (New Vegas) is a major update to TCP-Vegas.
An earlier version of NV was presented at 2010's LPC.
It is a delayed based congestion avoidance for the
data center. This version has been tested within a
10G rack where the HW RTTs are 20-50us.
A description of T
Refactor tcp_skb_cb to create two overlaping areas to store
state for incoming or outgoing skbs based on comments by
Neal Cardwell to tcp_nv patch:
AFAICT this patch would not require an increase in the size of
sk_buff cb[] if it were to take advantage of the fact that the
tcp_skb_cb head
Add in_flight (bytes in flight when packet was sent) field
to tx component of tcp_skb_cb and make it available to
congestion modules' pkts_acked() function through the
ack_sample function argument.
Signed-off-by: Lawrence Brakmo
---
include/net/tcp.h | 2 ++
net/ipv4/tcp_input.c | 5 -
Replace 2 arguments (cnt and rtt) in the congestion control modules'
pkts_acked() function with a struct. This will allow adding more
information without having to modify existing congestion control
modules (tcp_nv in particular needs bytes in flight when packet
was sent).
As proposed by Neal Card
The patch b1c17215d718: "stmmac: add ipq806x glue layer", leads to the
following static checker warning:
.../stmmac/dwmac-ipq806x.c:314 ipq806x_gmac_probe()
warn: double left shift '1 << (1 << gmac->id)'
The NSS_COMMON_CLK_SRC_CTRL_OFFSET macro is used once as an offset, and
once as a mask, which
On Tue, Aug 04, 2015 at 08:30:23AM -0700, Brenden Blanco wrote:
>
> This patch holds good in my testing. Thanks!
Thanks for testing. Let's add a tag for patchwork:
Tested-by: Brenden Blanco
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.a
On Tue, 4 Aug 2015 19:06:31 +0200
Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov
>
> Hi,
> When IFLA_BRPORT_PROXYARP and PROXYARP_WIFI were introduced they weren't
> accounted for in the get_slave_size() callback and didn't get a policy
> entry, so fix it now. Sending as two separate p
Support for sharing GREPROTO_CISCO port was added so that
OVS gre port and kernel GRE devices can co-exist. After
flow-based tunneling patches OVS GRE protocol processing
is completely moved to ip_gre module. so there is no need
for GRE protocol hook. Following patch consolidates
GRE protocol relat
This function will be used in gre and geneve vport implementations.
Signed-off-by: Pravin B Shelar
---
net/openvswitch/vport-netdev.c | 16
net/openvswitch/vport-netdev.h | 1 +
net/openvswitch/vport-vxlan.c | 17 +
3 files changed, 18 insertions(+), 16 deletio
Following patches make use of new flow based tunneling
API from kernel. This allows us to directly use netdev
based GRE tunnel implementation. While doing so I have
removed GRE demux API which were targeted for OVS. Most
of GRE protocol code is now consolidated in ip_gre module.
v2-v3:
Add API to
Following patch adds support for flow based tunnel to GRE
tap deivces. Using flow based tunneling, we can implement
OVS GRE vport. This patch removes all of the OVS
specific GRE code and make OVS use a ip_gre net_device.
Minimal GRE vport is kept to handle compatibility with
current userspace appli
On 08/04/2015 02:12 PM, Julien Grall wrote:
/*
* We detect special mappings in one of two ways:
@@ -217,9 +232,13 @@ static inline unsigned long bfn_to_local_pfn(unsigned long
mfn)
/* VIRT <-> MACHINE conversion */
#define virt_to_machine(v)(phys_to_machine(XPADDR(__pa(v
Hey David,
Sorry for the premature response on my phone earlier. Real reply follows.
>> rcu_read_lock, when using Xen PV. Relevant excerpts of the
> ^^ PV guest?
Yes. The lockup occurs on a PV guest. Nothing special at all about the
configuration. Vanilla upstream
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
> On Behalf Of Vasily Averin
> Sent: Tuesday, July 07, 2015 8:54 AM
> To: David S. Miller; netdev@vger.kernel.org
> Cc: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T; Fujinaka, Todd
> Subject: [PATCH 2/3] missing rtnl
On Tue, Aug 4, 2015 at 12:37 AM, Oleg A Arkhangelsky wrote:
>
>
> 04.08.2015, 04:29, "Richard Laing" :
>> Enable flow-based ECMP.
>
> Looks like your approach is only restricted to the case when sockets are
> involved. What about forwarded traffic (IP routing case)?
>
skb_get_hash_flowi4 can be ca
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
> On Behalf Of Stefan Assmann
> Sent: Friday, July 10, 2015 6:01 AM
> To: intel-wired-...@lists.osuosl.org
> Cc: netdev@vger.kernel.org; Kirsher, Jeffrey T; sassm...@kpanic.de
> Subject: [PATCH] igb: do not re-init SR-IOV du
Hi Oleg,
I hadn't seen that patch, thanks, it looks like a pretty thorough solution.
Best Regards,
Richard
On 08/04/2015 07:37 PM, Oleg A Arkhangelsky wrote:
>
> 04.08.2015, 04:29, "Richard Laing" :
>> Enable flow-based ECMP.
> Looks like your approach is only restricted to the case when sockets
Hi Stephen,
Given that fib_nhs is currently an int I would rather keep live_nexthops
also as an int to match, probably fib_nhs could at least be set as
unsigned or changed to u16 or even u8 perhaps.
Best Regards,
Richard
On 08/04/2015 05:31 PM, Stephen Hemminger wrote:
> On Tue, 4 Aug 2015 13
On Mon, Aug 3, 2015 at 9:07 PM, Wenyu Zhang wrote:
> When sampling rate is 1, the sampling probability is UINT32_MAX. The packet
> should be sampled even the prandom_u32() generate the number of UINT32_MAX.
> And none packet need be sampled when the probability is 0.
>
> Signed-off-by: Wenyu Zhang
Prior to this patch, rx buffer size for each rx queue
of an interface is configurable through dts bindings.
But for an interface, the first rx queue's rx buffer
size is always the usual MTU size (plus usual overhead)
and page size for the remaining rx queues (if they are
enabled by specifying a non
Ivan Vecera :
> Enforcing this flag in RxConfig for the mentioned chips fixes netdev
> watchdog issues prepended with AMD IOMMU message(s) like:
> AMD-Vi: Event logged [IO_PAGE_FAULT device=01:00.0 domain=0x001d
> address=0x3000 flags=0x0050]
FWIW:
Acked-by: Francois Romieu
Adding
Some of my colleagues have been doing a bit of scale testing in the
likes of OpenStack. They get to a certain number of instances launched
and then they start seeing messages of the form:
Sep 25 08:17:37 overcloud-novacompute7-hqauwkkp6cnb kernel:
[176969.125887] net_ratelimit: 62 callbacks s
Enforcing this flag in RxConfig for the mentioned chips fixes netdev
watchdog issues prepended with AMD IOMMU message(s) like:
AMD-Vi: Event logged [IO_PAGE_FAULT device=01:00.0 domain=0x001d
address=0x3000 flags=0x0050]
Note that this flag is also set in Realtek's own driver for thes
On 04/08/15 21:40, David Miller wrote:
> From: Antonio Quartulli
> Date: Tue, 4 Aug 2015 18:35:20 +0200
>
>> here you have our batch of fixes intended for net/linux-4.2.
>
> Sorry, you can't come to me this late in the -RC series with such
> a huge collection of bug fixes.
>
> Break out the
From: Antonio Quartulli
Date: Tue, 4 Aug 2015 18:35:20 +0200
> here you have our batch of fixes intended for net/linux-4.2.
Sorry, you can't come to me this late in the -RC series with such
a huge collection of bug fixes.
Break out the most important critical ones, and only submit those.
The r
As well as for kernels built only for ThunderX ARCH_THUNDERX is also enabled
for kernels which support multiple platforms (such as distro kernels). Thus
"default ARCH_THUNDER" is inappropriate.
I believe default m is equally frowned upon, so remove the line completely
rather than "default m if ARC
On Mon, Jul 27, 2015 at 08:34:32PM +0200, Oliver Hartkopp wrote:
> Hello Greg,
>
> On 12.07.2015 21:18, Marc Kleine-Budde wrote:
> >From: Oliver Hartkopp
> >
> >Commit 514ac99c64b "can: fix multiple delivery of a single CAN frame for
> >overlapping CAN filters" requires the skb->tstamp to be set
Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN
is meant, I suspect this is because the first support for Xen was for
PV. This resulted in some misimplementation of helpers on ARM and
confused developers about the expected behavior.
For instance, with pfn_to_mfn, we expect to
Hi all,
This patch series aims to use the memory terminologies described in
include/xen/mm.h [1] for Linux xen code.
Linux is using mistakenly MFN when GFN is meant, I suspect this is because the
first support of Xen was for PV. This has brought some misimplementation
of memory helpers on ARM and
On 8/4/15 1:58 AM, Kaixu Xia wrote:
+static int check_func_limit(struct bpf_map **mapp, int func_id)
how about 'check_map_func_compatibility' or 'check_map_func_affinity' ?
+{
+ struct bpf_map *map = *mapp;
why pass pointer to a pointer? single pointer would be be fine.
+ bool
On Tue, Jul 28, 2015 at 12:53:26AM +0200, Phil Sutter wrote:
> Upon receipt of SYNACK from the server, ipt_SYNPROXY first sends back an ACK
> to
> finish the server handshake, then calls nf_ct_seqadj_init() to initiate
> sequence number adjustment of forwarded packets to the client and finally
>
On 8/4/15 1:58 AM, Kaixu Xia wrote:
diff --git a/kernel/bpf/arraymap.c b/kernel/bpf/arraymap.c
index 45df657..b1e98ff 100644
--- a/kernel/bpf/arraymap.c
+++ b/kernel/bpf/arraymap.c
@@ -273,3 +273,60 @@ static int __init register_prog_array_map(void)
return 0;
}
late_initcall(register_
On Tue, Aug 04, 2015 at 07:08:27PM +0200, Oleg Nesterov wrote:
> On 08/04, Marcelo Ricardo Leitner wrote:
> >
> > On Tue, Aug 04, 2015 at 06:33:34PM +0200, Oleg Nesterov wrote:
> > > Commit 1fbe4b46caca "net: pktgen: kill the Wait for kthread_stop
> > > code in pktgen_thread_worker()" removed (in p
On 04/08/15 17:41, Jason A. Donenfeld wrote:
> Hi folks,
>
> Paul McKenney and I had an offline discussion about some rcu questions
> that eventually lead into me investigating a strange full lock-up I'm
> experiencing as a consequence of a printk in softirq inside of an
> rcu_read_lock, when usin
On 08/04, Marcelo Ricardo Leitner wrote:
>
> On Tue, Aug 04, 2015 at 06:33:34PM +0200, Oleg Nesterov wrote:
> > Commit 1fbe4b46caca "net: pktgen: kill the Wait for kthread_stop
> > code in pktgen_thread_worker()" removed (in particular) the final
> > __set_current_state(TASK_RUNNING) and I didn't n
From: Nikolay Aleksandrov
Hi,
When IFLA_BRPORT_PROXYARP and PROXYARP_WIFI were introduced they weren't
accounted for in the get_slave_size() callback and didn't get a policy
entry, so fix it now. Sending as two separate patches because the first
one goes further back than the second and thus we g
From: Nikolay Aleksandrov
The attribute size wasn't accounted for in the get_slave_size() callback
(br_port_get_slave_size) when it was introduced, so fix it now. Also add
a policy entry for it in br_port_policy.
Signed-off-by: Nikolay Aleksandrov
Fixes: 958501163ddd ("bridge: Add support for I
From: Nikolay Aleksandrov
The attribute size wasn't accounted for in the get_slave_size() callback
(br_port_get_slave_size) when it was introduced, so fix it now. Also add
a policy entry for it in br_port_policy.
Signed-off-by: Nikolay Aleksandrov
Fixes: 842a9ae08a25 ("bridge: Extend Proxy ARP
From: Linus Lüssing
Bitwise OR/AND assignments in C aren't guaranteed to be atomic. One
OGM handler might undo the set/clear of a specific bit from another
handler run in between.
Fix this by using the atomic set_bit()/clear_bit()/test_bit() functions.
Fixes: 17cf0ea455f1 ("batman-adv: tvlv - a
From: Linus Lüssing
Bitwise OR/AND assignments in C aren't guaranteed to be atomic. One
OGM handler might undo the set/clear of a specific bit from another
handler run in between.
Fix this by using the atomic set_bit()/clear_bit()/test_bit() functions.
Fixes: 60432d756cf0 ("batman-adv: Announce
From: Marek Lindner
batadv_softif_vlan_get() may return NULL which has to be verified
by the caller.
Fixes: 35df3b298fc8 ("batman-adv: fix TT VLAN inconsistency on VLAN re-add")
Reported-by: Ryan Thompson
Signed-off-by: Marek Lindner
Signed-off-by: Antonio Quartulli
---
net/batman-adv/soft-i
From: Ruben Wisniewski
The gateway selection based on fast connections is using a single value
calculated from the average tq (0-255) and the download bandwidth (in
100Kibit). The formula for the first step (tq ** 2 * 1 * bandwidth)
tends to overflow a u32 with low bandwidth settings like 50
From: Sven Eckelmann
The gw_factor is divided by BATADV_TQ_LOCAL_WINDOW_SIZE ** 2 * 64. But the
rest of the calculation has nothing to do with the tq window size and
therefore the calculation is just (tmp_gw_factor / (64 ** 3)).
Replace it with a simple shift to avoid a costly 64-bit divide when
From: Linus Lüssing
So far the mcast tvlv handler did not anticipate the processing of
multiple incoming OGMs from the same originator at the same time. This
can lead to various issues:
* Broken refcounting: For instance two mcast handlers might both assume
that an originator just got multicas
From: Simon Wunderlich
When an interface is purged, the broadcast packets scheduled for this
interface should get purged as well.
Signed-off-by: Simon Wunderlich
Signed-off-by: Marek Lindner
Signed-off-by: Antonio Quartulli
---
net/batman-adv/send.c | 3 ++-
1 file changed, 2 insertions(+),
Hello David,
here you have our batch of fixes intended for net/linux-4.2.
Patch 1 by Sven Eckelmann is changing the way the GW metric is
computed so that the resulting operation does not make use of
divisions and also does not lead to any data type promotion. This is
a requirement for patch 2.
P
From: Linus Lüssing
Bitwise OR/AND assignments in C aren't guaranteed to be atomic. One
OGM handler might undo the set/clear of a specific bit from another
handler run in between.
Fix this by using the atomic set_bit()/clear_bit()/test_bit() functions.
Fixes: 3f4841ffb336 ("batman-adv: tvlv - a
From: Marek Lindner
The list_del() calls were changed to list_del_init() to prevent
an accidental double deletion in batadv_tt_req_node_new().
Signed-off-by: Marek Lindner
Signed-off-by: Antonio Quartulli
---
net/batman-adv/translation-table.c | 9 +
1 file changed, 5 insertions(+), 4
Hi Dave,
here are few small fixes I would like to get to 4.2. Please let me know
if there are any problems.
Kalle
The following changes since commit df2cd4586f177acf9493dee079fc7d18268c5f54:
Merge tag 'iwlwifi-for-kalle-2015-06-12' of
https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/i
From: Simon Wunderlich
Without this initialization, gateways which actually announce up/down
bandwidth of 0/0 could be added. If these nodes get purged via
_batadv_purge_orig() later, the gw_node structure does not get removed
since batadv_gw_node_delete() updates the gw_node with up/down
bandwid
From: Linus Lüssing
Bitwise OR/AND assignments in C aren't guaranteed to be atomic. One
OGM handler might undo the set/clear of a specific bit from another
handler run in between.
Fix this by using the atomic set_bit()/clear_bit()/test_bit() functions.
Fixes: e17931d1a61d ("batman-adv: introduc
From: Marek Lindner
The tt_local_entry deletion performed in batadv_tt_local_remove() was neither
protecting against simultaneous deletes nor checking whether the element was
still part of the list before calling hlist_del_rcu().
Replacing the hlist_del_rcu() call with batadv_hash_remove() provi
When a node running DAT receives an ARP request from the LAN for the
first time, it is likely that this node will request the ARP entry
through the distributed ARP table (DAT) in the mesh.
Once a DAT reply is received the asking node must check if the MAC
address for which the IP address has been
Hi folks,
Paul McKenney and I had an offline discussion about some rcu questions
that eventually lead into me investigating a strange full lock-up I'm
experiencing as a consequence of a printk in softirq inside of an
rcu_read_lock, when using Xen PV. Relevant excerpts of the
conversation follow:
From: Linus Lüssing
The two commits noted below added calls to ip_hdr() and ipv6_hdr(). They
need a correctly set skb network header.
Unfortunately we cannot rely on the device drivers to set it for us.
Therefore setting it in the beginning of the according ndo_start_xmit
handler.
Fixes: 1d8ab8
On Tue, Aug 04, 2015 at 06:33:34PM +0200, Oleg Nesterov wrote:
> Commit 1fbe4b46caca "net: pktgen: kill the Wait for kthread_stop
> code in pktgen_thread_worker()" removed (in particular) the final
> __set_current_state(TASK_RUNNING) and I didn't notice the previous
> set_current_state(TASK_INTERRU
Commit 1fbe4b46caca "net: pktgen: kill the Wait for kthread_stop
code in pktgen_thread_worker()" removed (in particular) the final
__set_current_state(TASK_RUNNING) and I didn't notice the previous
set_current_state(TASK_INTERRUPTIBLE). This triggers the warning
in __might_sleep() after return.
Af
On 8/4/15 1:55 AM, Daniel Borkmann wrote:
Okay, what happens however, when we have an action attached to a
classifier and do a replace on that action, meaning one CPU is still
executing the filter inside tcf_bpf(), while another one is already
running tcf_bpf_cfg_cleanup() on that prog? Afaik, th
The pr_debug family of functions turns into a no-op when -DDEBUG is not
specified, opting instead to call "no_printk", which gets compiled to a
no-op (but retains gcc's nice warnings about printf-style arguments).
The problem with net_dbg_ratelimited is that it is defined to be a
variant of net_ra
On 8/4/15, 5:39 AM, "Yuval Mintz" wrote:
>> After implementing a new monitoring tool I've noticed that several of
>>our
>> physical servers have increasing RX errors, all seem to be classified
>>as overruns.
>
>Just to be sure we're looking at the same thing - are you referring to
>the errors
On Tue, Aug 04, 2015 at 02:33:38AM -0400, Vivien Didelot wrote:
> Refactor mv88e6xxx_port_fdb_{add,del,getnext} to respect the new DSA
> switch driver FDB access routines.
>
> The Marvell 88E6xxx switches support up to 4094 FIDs (from 1 to 0xfff;
> FID 0 means that multiple address databases are n
On Tue, 4 Aug 2015, Uwe [iso-8859-1] Kleine-K�nig wrote:
> Hello,
>
> On Tue, Aug 04, 2015 at 10:20:55AM -0400, Alan Stern wrote:
> > In that case, adding a call pm_runtime_get_noresume() is the right
> > thing to do.
> Is this an ack for Lucas' patch?
Yes:
Acked-by: Alan Stern
Alan Stern
-
On Tue, 2015-08-04 at 17:07 +0200, Jason A. Donenfeld wrote:
> The pr_debug family of functions turns into a no-op when -DDEBUG is not
> specified, opting instead to call "no_printk", which gets compiled to a
> no-op (but retains gcc's nice warnings about printf-style arguments).
[]
> diff --git a/
Sorry for the spamming of random rtnetlink people, but I just resumed
my laptop at PDX, and networking was dead.
It looks like a deadlock on rtnl_mutex, possibly due to some error
path not releasing the lock. No network op was making any progress,
and as you can see from the attached sysrq-w, it a
On 8/4/15 6:19 AM, Nicolas Schichan wrote:
When developping on the interpreter or a particular JIT, it can be
interesting to restrict the tests list to a specific test or a
particular range of tests.
This patch adds the following module parameters to the test_bpf module:
* test_name=: only the
Hi Scott,
On Aug 4, 2015, at 8:18 AM, Scott Feldman sfel...@gmail.com wrote:
> On Mon, Aug 3, 2015 at 11:30 PM, Vivien Didelot
> wrote:
>> Remove the fdb_{add,del,getnext} function pointer in favor of new
>> port_fdb_{add,del,getnext}.
>>
>> Implement the switchdev_port_obj_{add,del,dump} functi
> The commit 738ac1ebb96d02e0d23bc320302a6ea94c612dec ("net: Clone
> skb before setting peeked flag") introduced a use-after-free bug
> in skb_recv_datagram. This is because skb_set_peeked may create
> a new skb and free the existing one. As it stands the caller will
> continue to use the old fre
Sorry, I forgot to 'v2' the subject, but here's the respin suggested
by Joe and asked for by David.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The pr_debug family of functions turns into a no-op when -DDEBUG is not
specified, opting instead to call "no_printk", which gets compiled to a
no-op (but retains gcc's nice warnings about printf-style arguments).
The problem with net_dbg_ratelimited is that it is defined to be a
variant of net_ra
Waking the dealloc thread before decrementing inflight_packets is racy
because it means the thread may go to sleep before inflight_packets is
decremented. If kthread_stop() has already been called, the dealloc
thread may wait forever with nothing to wake it. Instead, wake the
thread only after decr
On Tue, Aug 04, 2015 at 03:40:59PM +0100, Ross Lagerwall wrote:
> Waking the dealloc thread before decrementing inflight_packets is racy
> because it means the thread may go to sleep before inflight_packets is
> decremented. If kthread_stop() has already been called, the dealloc
> thread may wait f
Hello,
On Tue, Aug 04, 2015 at 10:20:55AM -0400, Alan Stern wrote:
> In that case, adding a call pm_runtime_get_noresume() is the right
> thing to do.
Is this an ack for Lucas' patch?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linu
1 - 100 of 177 matches
Mail list logo
