Re: [PATCH net-next v2 2/7] net: switchdev: support static FDB addresses

2015-08-05 Thread Scott Feldman
On Wed, Aug 5, 2015 at 10:44 PM, Vivien Didelot wrote: > This patch adds a is_static boolean to the switchdev_obj_fdb structure, > in order to set the ndm_state to either NUD_NOARP or NUD_REACHABLE. > > Signed-off-by: Vivien Didelot > --- > include/net/switchdev.h | 1 + > net/switchdev/switch

[PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects

2015-08-05 Thread Vivien Didelot
This patchset refactors the DSA and mv88e6xxx code to use the switchdev FDB objects. The first two patches add minor but necessary changes to switchdev, the third one implements the switchdev glue in DSA for FDB routines, and the remaining ones refactor the FDB access functions in the mv88e6xxx co

[PATCH net-next v2 1/7] net: switchdev: change fdb addr for a byte array

2015-08-05 Thread Vivien Didelot
The address in the switchdev_obj_fdb structure is currently represented as a pointer. Replacing it for a 6-byte array allows switchdev to carry addresses directly read from hardware registers, not stored by the switch chip driver (as in Rocker). Signed-off-by: Vivien Didelot --- drivers/net/ethe

[PATCH net-next v2 4/7] net: dsa: mv88e6xxx: extend fid mask

2015-08-05 Thread Vivien Didelot
The driver currently manages one FID per port (or bridge group), with a mask of DSA_MAX_PORTS bits, where 0 means that the FID is in use. The Marvell 88E6xxx switches support up to 4094 FIDs (from 1 to 0xfff; FID 0 means that multiple address databases are not being used). This patch changes the

[PATCH net-next v2 3/7] net: dsa: add support for switchdev FDB objects

2015-08-05 Thread Vivien Didelot
Remove the fdb_{add,del,getnext} function pointer in favor of new port_fdb_{add,del,getnext}. Implement the switchdev_port_obj_{add,del,dump} functions in DSA to support the SWITCHDEV_OBJ_PORT_FDB objects. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6171.c | 3 - drivers/net/dsa/mv

[PATCH net-next v2 2/7] net: switchdev: support static FDB addresses

2015-08-05 Thread Vivien Didelot
This patch adds a is_static boolean to the switchdev_obj_fdb structure, in order to set the ndm_state to either NUD_NOARP or NUD_REACHABLE. Signed-off-by: Vivien Didelot --- include/net/switchdev.h | 1 + net/switchdev/switchdev.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff -

[PATCH net-next v2 5/7] net: dsa: mv88e6xxx: rename ATU MAC accessors

2015-08-05 Thread Vivien Didelot
Rename the __mv88e6xxx_{read,write}_addr functions to more explicit _mv88e6xxx_atu_mac_{read,write} functions, which also respect the single underscore convention used in the file (meaning SMI lock must be held). In the meantime, define their MAC address parameters as an array of ETH_ALEN bytes in

[PATCH net-next v2 7/7] net: dsa: mv88e6xxx: rework FDB add/del operations

2015-08-05 Thread Vivien Didelot
Add a low level function for the ATU Load operation, and provide FDB add and delete wrappers functions. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6171.c | 2 + drivers/net/dsa/mv88e6352.c | 2 + drivers/net/dsa/mv88e6xxx.c | 110 +--- driv

[PATCH net-next v2 6/7] net: dsa: mv88e6xxx: rework FDB getnext operation

2015-08-05 Thread Vivien Didelot
This commit adds a low level _mv88e6xxx_atu_getnext function and helpers to rewrite the mv88e6xxx_port_fdb_getnext operation. A mv88e6xxx_atu_entry structure is added for convenient access to the hardware, and GLOBAL_ATU_FID is defined instead of the raw 0x01 value. The previous implementation di

Re: rtnl_mutex deadlock?

2015-08-05 Thread Herbert Xu
On Wed, Aug 05, 2015 at 08:59:07PM +0200, Daniel Borkmann wrote: > > Here's a theory and patch below. Herbert, Thomas, does this make any > sense to you resp. sound plausible? ;) Another possibility is the following bug: https://patchwork.ozlabs.org/patch/503374/ It can cause a use-after-free w

RE: [PATCH V4 4/7] Drivers: hv: vmbus: add APIs to register callbacks to process hvsock connection

2015-08-05 Thread Dexuan Cui
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf > Of Dexuan Cui > Sent: Thursday, July 30, 2015 18:20 > To: David Miller ; KY Srinivasan > Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com; > driverdev-de...@linuxdriverproject.org; linux-ker...@vge

Re: [PATCH for-next V7 00/10] Move RoCE GID management to IB/Core

2015-08-05 Thread Jason Gunthorpe
On Sun, Aug 02, 2015 at 10:56:38AM +0300, Matan Barak wrote: > Indeed this design flaw was introduced when the first legacy verb was > extended. I think that falling back from extended code to legacy code > should be in the uverbs code. ib_uverbs_write will return -ENOSYS only > if both extended a

RE: [PATCH V4 7/7] Drivers: hv: vmbus: disable local interrupt when hvsock's callback is running

2015-08-05 Thread Dexuan Cui
> -Original Message- > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf > Of Dexuan Cui > Sent: Thursday, July 30, 2015 18:18 > To: David Miller ; KY Srinivasan > Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com; > driverdev-de...@linuxdriver

[PATCH net-next v4 2/4] ip_gre: Add support to collect tunnel metadata.

2015-08-05 Thread Pravin B Shelar
Following patch create new tunnel flag which enable tunnel metadata collection on given device. Signed-off-by: Pravin B Shelar --- include/net/ip_tunnels.h | 7 +- include/uapi/linux/if_tunnel.h | 1 + net/ipv4/ip_gre.c | 195 + net/

[PATCH net-next v4 4/4] gre: Remove support for sharing GRE protocol hook.

2015-08-05 Thread Pravin B Shelar
Support for sharing GREPROTO_CISCO port was added so that OVS gre port and kernel GRE devices can co-exist. After flow-based tunneling patches OVS GRE protocol processing is completely moved to ip_gre module. so there is no need for GRE protocol hook. Following patch consolidates GRE protocol relat

[PATCH net-next v4 1/4] openvswitch: Move tunnel destroy function to oppenvswitch module.

2015-08-05 Thread Pravin B Shelar
This function will be used in gre and geneve vport implementations. Signed-off-by: Pravin B Shelar --- net/openvswitch/vport-netdev.c | 21 ++--- net/openvswitch/vport-netdev.h | 2 +- net/openvswitch/vport-vxlan.c | 17 + 3 files changed, 20 insertions(+), 20 d

[PATCH net-next v4 3/4] openvswitch: Use regular GRE net_device instead of vport

2015-08-05 Thread Pravin B Shelar
Using flow based tunneling, we can implement OVS GRE vport. This patch removes all of the OVS specific GRE code and make OVS use a ip_gre net_device. Minimal GRE vport is kept to handle compatibility with current userspace application. Signed-off-by: Pravin B Shelar --- include/net/gre.h

[PATCH net-next v4 0/4] GRE: Use flow based tunneling for OVS GRE vport.

2015-08-05 Thread Pravin B Shelar
Following patches make use of new flow based tunneling API from kernel. This allows us to directly use netdev based GRE tunnel implementation. While doing so I have removed GRE demux API which were targeted for OVS. Most of GRE protocol code is now consolidated in ip_gre module. v3-v4: Added inter

[PATCH] [trivial] net:wimax: Fix doucble word "the the" in networking.xml

2015-08-05 Thread Masanari Iida
This patch fix a double word "the the" in Documentation/DocBook/networking.xml and Documentation/DocBook/networking/API-Wimax-report-rfkill-sw.html. These files are generated from comment in source, so I had to fix the typo in net/wimax/io-rfkill.c Signed-off-by: Masanari Iida --- net/wimax/op-

Re: [PATCH v6 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter

2015-08-05 Thread xiakaixu
于 2015/8/5 21:53, Peter Zijlstra 写道: > On Wed, Aug 05, 2015 at 12:04:25PM +0200, Peter Zijlstra wrote: >> Also, you probably want a WARN_ON(in_nmi()) there, this function is >> _NOT_ NMI safe. > > I had a wee think about that, and I think the below is safe. > > (with the obvious problem that WARN

Re: [RFC PATCH v5 net-next 4/4] tcp: add NV congestion control

2015-08-05 Thread Kenneth Klette Jonassen
On Wed, Aug 5, 2015 at 3:39 AM, Lawrence Brakmo wrote: > This is a request for comments. Nice to see more development on delay-based congestion control. It would be good to see how NV stacks up against CDG. Any chance of adding cdg as a congestion control parameter to your experiments? Experimen

Re: [net-next 07/15] i40e/i40evf: Add TX/RX outer UDP checksum support for X722

2015-08-05 Thread Jesse Brandeburg
On Wed, 5 Aug 2015 17:13:21 -0700 Tom Herbert wrote: > On Wed, Aug 5, 2015 at 4:52 PM, Jeff Kirsher > wrote: > > From: Anjali Singhai Jain > > if (vsi->back->flags & I40E_FLAG_WB_ON_ITR_CAPABLE) > > tx_ring->flags = I40E_TXR_FLAGS_WB_ON_ITR; > > +

Re: [PATCH] sky2: Add module parameter for passing the MAC address

2015-08-05 Thread Florian Fainelli
On 05/08/15 16:16, Stephen Hemminger wrote: > Something like this: > > Subject: [PATCH net-next] sky2: use random address if EEPROM is bad > > On some embedded systems the EEPROM does not contain a valid MAC address. > In that case it is better to fallback to a generated mac address and > let ini

Re: rtnl_mutex deadlock?

2015-08-05 Thread Herbert Xu
On Wed, Aug 05, 2015 at 08:59:07PM +0200, Daniel Borkmann wrote: > > Here's a theory and patch below. Herbert, Thomas, does this make any > sense to you resp. sound plausible? ;) It's certainly possible. Whether it's plausible I'm not so sure. The netlink hashtable is unlimited in size. So it sh

Re: [PATCH] sky2: Add module parameter for passing the MAC address

2015-08-05 Thread David Miller
From: Liviu Dudau Date: Wed, 5 Aug 2015 16:50:54 +0100 > For designs where EEPROMs are not connected to PCI Yukon2 > chips we need to get the MAC address from the firmware. > Add a module parameter called 'mac_address' for this. It > will be used if no DT node can be found and the B2_MAC > regis

Re: [net-next 07/15] i40e/i40evf: Add TX/RX outer UDP checksum support for X722

2015-08-05 Thread Tom Herbert
On Wed, Aug 5, 2015 at 4:52 PM, Jeff Kirsher wrote: > From: Anjali Singhai Jain > > X722 supports offloading of outer UDP TX and RX checksum for tunneled > packets. This patch exposes the support and leaves it enabled by > default. > > Signed-off-by: Anjali Singhai Jain > Signed-off-by: Catherin

[net-next 11/15] e1000e: Fix EEE in Sx implementation

2015-08-05 Thread Jeff Kirsher
From: Raanan Avargil This patch implements the EEE in Sx code so that it only applies to parts that support EEE in Sx (as opposed to all parts that support EEE). It also uses the existing eee_advert and eee_lp_abiliity to set just the bits (100/1000) that should be set. Signed-off-by: Raanan Ava

[net-next 03/15] i40e/i40evf: Update FW API with X722 support

2015-08-05 Thread Jeff Kirsher
From: Anjali Singhai Jain This patch does the firmware API update to support the new X722 device. Signed-off-by: Anjali Singhai Jain Signed-off-by: Catherine Sullivan Tested-by: Jim Young Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 48 ++ driver

[net-next 09/15] i40e/i40evf: Add ATR HW eviction support for X722

2015-08-05 Thread Jeff Kirsher
From: Anjali Singhai Jain X722 supports evicting ATR filters in the HW. With this patch, we enable the feature in the driver and avoid filter deletion by the driver. Signed-off-by: Anjali Singhai Jain Signed-off-by: Catherine Sullivan Tested-by: Jim Young Signed-off-by: Jeff Kirsher --- dri

[net-next 05/15] i40e/i40evf: RSS changes for X722

2015-08-05 Thread Jeff Kirsher
From: Anjali Singhai Jain X722 uses the admin queue to configure RSS. This patch adds the necessary flow changes to configure RSS through AQ. It also adds the separate VMDQ2 lookup tables and hash key programming for X722. X722 also exposes a different set of PCTYPES for RSS, this patch accommod

[net-next 07/15] i40e/i40evf: Add TX/RX outer UDP checksum support for X722

2015-08-05 Thread Jeff Kirsher
From: Anjali Singhai Jain X722 supports offloading of outer UDP TX and RX checksum for tunneled packets. This patch exposes the support and leaves it enabled by default. Signed-off-by: Anjali Singhai Jain Signed-off-by: Catherine Sullivan Tested-by: Jim Young Signed-off-by: Jeff Kirsher ---

[net-next 14/15] e1000e: Fix tight loop implementation of systime read algorithm

2015-08-05 Thread Jeff Kirsher
From: Raanan Avargil Change the algorithm. Read systimel twice and check for overflow. If there was no overflow, use the first value. If there was an overflow, read systimeh again and use the second systimel value. Signed-off-by: Raanan Avargil Tested-by: Aaron Brown Signed-off-by: Jeff Kirshe

[net-next 08/15] i40e: Add IWARP support for X722

2015-08-05 Thread Jeff Kirsher
From: Anjali Singhai Jain X722 supports IWARP, this patch handles checking for PE critical errors. Since the driver doesn't support the IWARP interface for now, this patch just does bare minimum to log a message oif a PE critical error happens. Signed-off-by: Anjali Singhai Jain Signed-off-by:

[net-next 15/15] e1000e: Increase driver version number

2015-08-05 Thread Jeff Kirsher
From: Raanan Avargil Signed-off-by: Raanan Avargil Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e10

[net-next 13/15] e1000e: Fix incorrect ASPM locking

2015-08-05 Thread Jeff Kirsher
From: Raanan Avargil This patch fixes wrong locking usage. In the context of slot reset, we should use lock. And during resume, there is no need of lock. Reported-by: Bjorn Helgaas Signed-off-by: Raanan Avargil Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/inte

[net-next 02/15] i40e/i40evf: Add flags for X722 capabilities

2015-08-05 Thread Jeff Kirsher
From: Anjali Singhai Jain Add capabilities flags specific to X722. Signed-off-by: Anjali Singhai Jain Signed-off-by: Catherine Sullivan Tested-by: Jim Young Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e.h | 7 +++ drivers/net/ethernet/intel/i40e/i40e_main.c |

[net-next 10/15] i40e: Add AQ commands for NVM Update for X722

2015-08-05 Thread Jeff Kirsher
From: Shannon Nelson X722 does NVM update via the adminq queue, so we need to add support for that. Signed-off-by: Shannon Nelson Signed-off-by: Catherine Sullivan Tested-by: Jim Young Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_nvm.c | 129 +

[net-next 12/15] e1000e: Cosmetic changes

2015-08-05 Thread Jeff Kirsher
From: Raanan Avargil 1) Replace spaces with tab. 2) Move ich8lan related define to the proper context. Signed-off-by: Raanan Avargil Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/e1000e/ich8lan.h | 4 ++-- drivers/net/ethernet/intel/e1000e/regs.h| 5 ++

[net-next 06/15] i40e/i40evf: Add support for writeback on ITR feature for X722

2015-08-05 Thread Jeff Kirsher
From: Anjali Singhai Jain X722 fixes an issue from X710 where TX descriptor WB would not happen if the interrupts were disabled. In order for the write backs to happen a bit needs to be set in the dynamic interrupt control register called WB_ON_ITR. With this feature, the SW driver need not arm S

[net-next 01/15] i40e/i40evf: Add device ids for X722

2015-08-05 Thread Jeff Kirsher
From: Anjali Singhai Jain Adding device ids for new hardware X722 Signed-off-by: Anjali Singhai Jain Signed-off-by: Catherine Sullivan Tested-by: Jim Young Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_common.c | 10 ++ drivers/net/ethernet/intel/i40e/i40e_m

[net-next 00/15][pull request] Intel Wired LAN Driver Updates 2015-08-05

2015-08-05 Thread Jeff Kirsher
This series contains updates to i40e, i40evf and e1000e. Anjali adds support for x772 devices to i40e and i40evf. With the added support, x772 supports offloading of the outer UDP transmit and receive checksum for tunneled packets. Also supports evicting ATR filters in the hardware, so update th

Re: [PATCH] sky2: Add module parameter for passing the MAC address

2015-08-05 Thread Stephen Hemminger
Something like this: Subject: [PATCH net-next] sky2: use random address if EEPROM is bad On some embedded systems the EEPROM does not contain a valid MAC address. In that case it is better to fallback to a generated mac address and let init scripts fix the value later. Reported-by: Liviu Dudau

Re: [PATCHv2 net-next 5/9] openvswitch: Add conntrack action

2015-08-05 Thread Pravin Shelar
On Tue, Aug 4, 2015 at 9:49 PM, Joe Stringer wrote: > Expose the kernel connection tracker via OVS. Userspace components can > make use of the "ct()" action, followed by "recirculate", to populate > the conntracking state in the OVS flow key, and subsequently match on > that state. > > Example ODP

Re: [PATCHv2 net-next 2/9] openvswitch: Move MASKED* macros to datapath.h

2015-08-05 Thread Pravin Shelar
On Tue, Aug 4, 2015 at 9:49 PM, Joe Stringer wrote: > This will allow the ovs-conntrack code to reuse these macros. > > Signed-off-by: Joe Stringer > Acked-by: Thomas Graf Acked-by: Pravin B Shelar -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCHv2 net-next 1/9] openvswitch: Serialize acts with original netlink len

2015-08-05 Thread Pravin Shelar
On Tue, Aug 4, 2015 at 9:49 PM, Joe Stringer wrote: > Previously, we used the kernel-internal netlink actions length to > calculate the size of messages to serialize back to userspace. > However,the sw_flow_actions may not be formatted exactly the same as the > actions on the wire, so store the or

Re: [PATCHv2 net-next 3/9] ipv6: Export nf_ct_frag6_gather()

2015-08-05 Thread Pravin Shelar
On Tue, Aug 4, 2015 at 9:49 PM, Joe Stringer wrote: > Signed-off-by: Joe Stringer > Acked-by: Thomas Graf > --- Acked-by: Pravin B Shelar -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

[PATCH net-next 1/1] lan78xx: Fix Smatch warnings

2015-08-05 Thread Woojung.Huh
Fix Smatch warnings. - lan78xx.c:2282 tx_complete() warn: variable dereferenced before check 'skb' (see line 2249) - lan78xx.c:2885 lan78xx_bh() info: ignoring unreachable code. - lan78xx.c:3159 lan78xx_probe() info: ignoring unreachable code. Reported-by: Dan Carpenter Signed-off-by: Woojung H

Re: [PATCH] sky2: Add module parameter for passing the MAC address

2015-08-05 Thread Francois Romieu
Liviu Dudau : > On Wed, Aug 05, 2015 at 05:40:57PM +0100, Stephen Hemminger wrote: [...] > > Yes, I can see that this can be a real problem, and other drivers > > solve the problem. The standard method is to assign a random mac address > > (and then let scripts overwrite) rather than introducing m

[PATCH] net: Unbreak resetting default values for tcp_wmem/udp_wmem_min

2015-08-05 Thread Calvin Owens
Commit 8133534c760d4083 ("net: limit tcp/udp rmem/wmem to SOCK_{RCV,SND}BUF_MIN") modified four sysctls to enforce that the values written to them are not less than SOCK_MIN_{RCV,SND}BUF. This change is fine for tcp_rmem and udp_rmem_min, since SOCK_MIN_RCVBUF is equal to equal to TCP_SKB_MIN_TRUE

[PATCH RFC] ipvlan: Problems with ipvlan and IPv6

2015-08-05 Thread Tom Herbert
Just doing: ip link add name ipvl0 link eth0 type ipvlan ip -6 addr add :0:0:1::0:1:1/128 dev ipvl0 ip addr add 192.168.1.1/32 dev iplv0 Before patch: ping :0:0:1::0:1:1 - No response, tcpdump on ipvl0 shows two copies of each ICMP echo request. ping 192.168.1.1

Re: [PATCH 09/10] net: Use VRF device index for socket lookups

2015-08-05 Thread David Ahern
Hi Tom: On 8/5/15 12:32 PM, Tom Herbert wrote: On Wed, Aug 5, 2015 at 10:14 AM, David Ahern wrote: >The intent of the VRF device is to leverage the existing SO_BINDTODEVICE >as a means of creating L3 domains. Since sockets are expected to be bound >to the VRF device the index of the master dev

Re: rtnl_mutex deadlock?

2015-08-05 Thread Daniel Borkmann
On 08/05/2015 10:44 AM, Linus Torvalds wrote: On Wed, Aug 5, 2015 at 9:43 AM, Jiri Pirko wrote: Indeed. Most probably, NETLINK_CB(skb).portid got zeroed. Linus, are you able to reproduce this or is it a one-time issue? I don't think I'm able to reproduce this, it's happened only once so far

Re: [PATCH 09/10] net: Use VRF device index for socket lookups

2015-08-05 Thread Tom Herbert
On Wed, Aug 5, 2015 at 10:14 AM, David Ahern wrote: > The intent of the VRF device is to leverage the existing SO_BINDTODEVICE > as a means of creating L3 domains. Since sockets are expected to be bound > to the VRF device the index of the master device needs to be used for > socket lookups. > Thi

Re: [ovs-dev] [PATCH net-next v3] openvswitch: Make 100 percents packets sampled when sampling rate is 1.

2015-08-05 Thread Pravin Shelar
On Wed, Aug 5, 2015 at 12:30 AM, Wenyu Zhang wrote: > When sampling rate is 1, the sampling probability is UINT32_MAX. The packet > should be sampled even the prandom32() generate the number of UINT32_MAX. > And none packet need be sampled when the probability is 0. > > Signed-off-by: Wenyu Zhang

Re: [BUG] net/ipv4: inconsistent routing table

2015-08-05 Thread Alexander Duyck
On 08/05/2015 02:06 AM, Daniel Borkmann wrote: [ please cc netdev ] On 08/05/2015 10:56 AM, Zang MingJie wrote: Hi: I found a bug when remove an ip address which is referenced by a routing entry. step to reproduce: ip li add type dummy ip li set dummy0 up ip ad add 10.0.0.1/24 dev dummy0 i

Re: [PATCH] sky2: Add module parameter for passing the MAC address

2015-08-05 Thread Liviu Dudau
On Wed, Aug 05, 2015 at 06:15:37PM +0100, Ryan Harkin wrote: >On 5 August 2015 at 16:50, Liviu Dudau <[1]liviu.du...@arm.com> wrote: > > For designs where EEPROMs are not connected to PCI Yukon2 > chips we need to get the MAC address from the firmware. > Add a module parameter c

Re: [PATCH] sky2: Add module parameter for passing the MAC address

2015-08-05 Thread Liviu Dudau
On Wed, Aug 05, 2015 at 05:40:57PM +0100, Stephen Hemminger wrote: > On Wed, 5 Aug 2015 16:50:54 +0100 > Liviu Dudau wrote: > > > For designs where EEPROMs are not connected to PCI Yukon2 > > chips we need to get the MAC address from the firmware. > > Add a module parameter called 'mac_address'

[PATCH 06/10] net: Fix up inet_addr_type checks

2015-08-05 Thread David Ahern
Currently inet_addr_type and inet_dev_addr_type expect local addresses to be in the local table. With the VRF device local routes for devices associated with a VRF will be in the table associated with the VRF. Provide an alternate inet_addr lookup to use a specific table rather than defaulting to t

[PATCH 07/10] net: Add routes to the table associated with the device

2015-08-05 Thread David Ahern
When a device associated with a VRF is brought up or down routes should be added to/removed from the table associated with the VRF. fib_magic defaults to using the main or local tables. Have it use the table with the device if there is one. A part of this is directing prefsrc validations to the co

[PATCH 04/10] udp: Handle VRF device

2015-08-05 Thread David Ahern
For unconnected UDP sockets using a VRF device lookup source address based on VRF table. This allows the UDP header to be properly setup before showing up at the VRF device via the dst. Signed-off-by: Shrijeet Mukherjee Signed-off-by: David Ahern --- net/ipv4/udp.c | 25 +++-

[PATCH 09/10] net: Use VRF device index for socket lookups

2015-08-05 Thread David Ahern
The intent of the VRF device is to leverage the existing SO_BINDTODEVICE as a means of creating L3 domains. Since sockets are expected to be bound to the VRF device the index of the master device needs to be used for socket lookups. Signed-off-by: Shrijeet Mukherjee Signed-off-by: David Ahern --

[PATCH 10/10] net: Introduce VRF device driver

2015-08-05 Thread David Ahern
This driver borrows heavily from IPvlan and teaming drivers. Routing domains (VRF-lite) are created by instantiating a VRF master device with an associated table and enslaving all routed interfaces that participate in the domain. As part of the enslavement, all connected routes for the enslaved de

[PATCH 02/10] net: Use VRF device index for lookups on RX

2015-08-05 Thread David Ahern
On ingress use index of VRF master device for route lookups if real device is enslaved. Rules are expected to be installed for the VRF device to direct lookups to a specific table. Signed-off-by: Shrijeet Mukherjee Signed-off-by: David Ahern --- net/ipv4/fib_frontend.c | 8 +++- net/ipv4/ro

[PATCH 05/10] net: Add inet_addr lookup by table

2015-08-05 Thread David Ahern
Currently inet_addr_type and inet_dev_addr_type expect local addresses to be in the local table. With the VRF device local routes for devices associated with a VRF will be in the table associated with the VRF. Provide an alternate inet_addr lookup to use a specific table rather than defaulting to t

[PATCH 03/10] net: Use VRF device index for lookups on TX

2015-08-05 Thread David Ahern
As with ingress use the index of VRF master device for route lookups on egress. However, the oif should only be used to direct the lookups to a specific table. Routes in the table are not based on the VRF device but rather interfaces that are part of the VRF so do not consider the oif for lookups w

[PATCH 01/10] net: Introduce VRF related flags and helpers

2015-08-05 Thread David Ahern
Add a VRF_MASTER flag for interfaces and helper functions for determining if a device is a VRF_MASTER. Add link attribute for passing VRF_TABLE id. Add vrf_ptr to netdevice. Add various macros for determining if a device is a VRF device, the index of the master VRF device and table associated wi

[PATCH net-next 00/10] VRF-lite - v4

2015-08-05 Thread David Ahern
In the context of internet scale routing a requirement that always comes up is the need to partition the available routing tables into disjoint routing planes. A specific use case is the multi-tenancy problem where each tenant has their own unique routing tables and in the very least need different

[PATCH] iproute2: Add support for VRF device

2015-08-05 Thread David Ahern
Allow user to create a vrf device and specify its table binding. Based on the iplink_vlan implementation. Signed-off-by: Shrijeet Mukherjee Signed-off-by: David Ahern --- include/linux/if_link.h | 8 + ip/Makefile | 2 +- ip/iplink.c | 2 +- ip/iplink_vrf.c

[PATCH 08/10] net: Use passed in table for nexthop lookups

2015-08-05 Thread David Ahern
If a user passes in a table for new routes use that table for nexthop lookups. Specifically, this solves the case where a connected route does not exist in the main table, but only another table and then a subsequent route is added with a next hop using the connected route. ie., $ ip route ls defa

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Wei Liu
On Tue, Aug 04, 2015 at 07:12:48PM +0100, Julien Grall wrote: [...] > diff --git a/drivers/net/xen-netback/netback.c > b/drivers/net/xen-netback/netback.c > index 7d50711..3b7b7c3 100644 > --- a/drivers/net/xen-netback/netback.c > +++ b/drivers/net/xen-netback/netback.c > @@ -314,7 +314,7 @@ stati

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

2015-08-05 Thread Dmitry Torokhov
On Wed, Aug 05, 2015 at 11:08:55AM +0100, Stefano Stabellini wrote: > On Tue, 4 Aug 2015, Julien Grall wrote: > > Based on include/xen/mm.h [1], Linux is mistakenly using MFN when GFN > > is meant, I suspect this is because the first support for Xen was for > > PV. This resulted in some misimplemen

Re: [PATCH] sky2: Add module parameter for passing the MAC address

2015-08-05 Thread Stephen Hemminger
On Wed, 5 Aug 2015 16:50:54 +0100 Liviu Dudau wrote: > For designs where EEPROMs are not connected to PCI Yukon2 > chips we need to get the MAC address from the firmware. > Add a module parameter called 'mac_address' for this. It > will be used if no DT node can be found and the B2_MAC > registe

[PATCH net-next] net: Fix race condition in store_rps_map

2015-08-05 Thread Tom Herbert
There is a race condition in store_rps_map that allows jump label count in rps_needed to go below zero. This can happen when concurrently attempting to set and a clear map. Scenario: 1. rps_needed count is zero 2. New map is assigned by setting thread, but rps_needed count _not_ yet incremente

Re: [Xen-devel] printk from softirq on xen: hard lockup

2015-08-05 Thread Jason A. Donenfeld
Hi folks, I have written an extremely simple reproducer. Xen 4.5.1. Linux 4.1.3. Config attached. Reproducer attached. Makefile attached. It results in the COMPLETE lockup of the system when it receives a network packet over the Xen PV network interface. The lockup is 100% reliable. As in the me

Re: [PATCH v6 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter

2015-08-05 Thread Peter Zijlstra
On Wed, Aug 05, 2015 at 09:08:32AM -0700, Alexei Starovoitov wrote: > On 8/5/15 6:53 AM, Peter Zijlstra wrote: > >+/* > >+ * If the event is currently on this CPU, its either a per-task event, > >+ * or local to this CPU. Furthermore it means its ACTIVE (otherwise > >+ * oncpu == -1

Re: [PATCH net-next] vxlan: combine VXLAN_FLOWBASED into VXLAN_COLLECT_METADATA

2015-08-05 Thread Alexei Starovoitov
On 8/5/15 7:42 AM, Thomas Graf wrote: I have no objection since a flag to enable tx only can be added again if needed. As stated in the other thread, the tx only mode which is what VXLAN was capable of doing so far is what motivated the split of flags. I see the intent. A bit confusing though,

[PATCH net-next] net/mlx5_core: Set log_uar_page_sz for non 4K page size architecture

2015-08-05 Thread clsoto
From: Carol L Soto failed to configure the page size for architectures with page size different than 4K. Signed-off-by: Carol L Soto --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/driver

Re: [PATCH v6 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter

2015-08-05 Thread Alexei Starovoitov
On 8/5/15 6:53 AM, Peter Zijlstra wrote: + /* +* If the event is currently on this CPU, its either a per-task event, +* or local to this CPU. Furthermore it means its ACTIVE (otherwise +* oncpu == -1). +*/ + if (event->oncpu == smp_processor_id()) +

Re: [PATCH v6 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter

2015-08-05 Thread Alexei Starovoitov
On 8/5/15 3:15 AM, Peter Zijlstra wrote: On Wed, Aug 05, 2015 at 12:04:25PM +0200, Peter Zijlstra wrote: On Tue, Aug 04, 2015 at 08:58:15AM +, Kaixu Xia wrote: + event->ctx->task != current) Strictly speaking we should hold rcu_read_lock around dereferencing event->ctx (or hav

Re: [PATCH v6 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter

2015-08-05 Thread Alexei Starovoitov
On 8/5/15 3:04 AM, Peter Zijlstra wrote: >+ __perf_event_read(event); >+ return perf_event_count(event); >+} Also, you probably want a WARN_ON(in_nmi()) there, this function is _NOT_ NMI safe. we check that very early on: unsigned int trace_call_bpf(struct bpf_prog *prog, void *ctx) {

[PATCH] sky2: Add module parameter for passing the MAC address

2015-08-05 Thread Liviu Dudau
For designs where EEPROMs are not connected to PCI Yukon2 chips we need to get the MAC address from the firmware. Add a module parameter called 'mac_address' for this. It will be used if no DT node can be found and the B2_MAC register holds an invalid value. Signed-off-by: Liviu Dudau --- driver

[v2 1/9] devres: add devm_alloc_percpu()

2015-08-05 Thread Madalin Bucur
Introduce managed counterparts for alloc_percpu() and free_percpu(). Add devm_alloc_percpu() and devm_free_percpu() into the managed interfaces list. Signed-off-by: Madalin Bucur --- Documentation/driver-model/devres.txt | 4 +++ drivers/base/devres.c | 64 ++

[v2 4/9] dpaa_eth: add driver's Tx queue selection mechanism

2015-08-05 Thread Madalin Bucur
Allow the selection of the transmission queue based on the CPU id. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/Kconfig | 10 ++ drivers/net/ethernet/freescale/dpaa/dpaa_eth.c| 3 +++ drivers/net/ethernet/freescale/dpaa/dpaa_eth.h| 6 ++

[v2 3/9] dpaa_eth: add support for S/G frames

2015-08-05 Thread Madalin Bucur
Add support for Scater/Gather (S/G) frames. The FMan can place the frame content into multiple buffers and provide a S/G Table (SGT) into one first buffer with references to the others. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 6 + .../net/ethernet/

[v2 0/9] dpaa_eth: Add the Freescale DPAA Ethernet driver

2015-08-05 Thread Madalin Bucur
This patch series adds the Ethernet driver for the Freescale QorIQ Data Path Acceleration Architecture (DPAA). This version includes changes following the feedback received on previous versions from Eric Dumazet, Bob Cochran, Joe Perches, Paul Bolle, Joakim Tjernlund, Scott Wood, David Miller - th

[v2 8/9] dpaa_eth: add debugfs entries

2015-08-05 Thread Madalin Bucur
Export per CPU counters through debugfs. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/Kconfig| 7 + drivers/net/ethernet/freescale/dpaa/Makefile | 3 + drivers/net/ethernet/freescale/dpaa/dpaa_debugfs.c | 272 + drivers/net/ethernet/f

[v2 6/9] dpaa_eth: add sysfs exports

2015-08-05 Thread Madalin Bucur
Export Frame Queue and Buffer Pool IDs through sysfs. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/Makefile | 2 +- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 + drivers/net/ethernet/freescale/dpaa/dpaa_eth.h | 3 + .../net/ethernet/freescale/d

[v2 7/9] dpaa_eth: add debugfs counters

2015-08-05 Thread Madalin Bucur
Add a series of counters to be exported through debugfs: - add detailed counters for reception errors; - add detailed counters for QMan enqueue reject events; - count the number of fragmented skbs received from the stack; - count all frames received on the Tx confirmation path; - add congestion gro

[v2 5/9] dpaa_eth: add ethtool functionality

2015-08-05 Thread Madalin Bucur
Add support for basic ethtool operations. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/Makefile | 2 +- .../net/ethernet/freescale/dpaa/dpaa_eth_common.c | 2 + .../net/ethernet/freescale/dpaa/dpaa_eth_common.h | 3 + drivers/net/ethernet/freescale/dpaa/dpaa

[v2 2/9] dpaa_eth: add support for DPAA Ethernet

2015-08-05 Thread Madalin Bucur
This introduces the Freescale Data Path Acceleration Architecture (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan, BMan, PAMU and FMan drivers to deliver Ethernet connectivity on the Freescale DPAA QorIQ platforms. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/

[v2 9/9] dpaa_eth: add trace points

2015-08-05 Thread Madalin Bucur
Add trace points on the hot processing path. Signed-off-by: Ruxandra Ioana Radulescu --- drivers/net/ethernet/freescale/dpaa/Makefile | 1 + drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 12 ++ drivers/net/ethernet/freescale/dpaa/dpaa_eth.h | 4 + .../net/ethernet/freescale

[PATCH net-next] r8169:Issues on alloc memory

2015-08-05 Thread Corcodel Marian
Many, many issues DESC_ARRAY represent number of descriptor on array on Tx and Rx and is fit with TxDesc and RxDesc structure, MAX_DESCRIPTORS is 1024 on Rx and Tx wich is included 256 Descriptors from chip on Rx and Tx. DESC_ARRAY * NUM_ARRAYS_MAX must fit with MAX_DESCRIPTORS 256 from

Re: [PATCH] ARCNET: fix hard_header_len limit

2015-08-05 Thread Michael Grzeschik
On Thu, Jul 30, 2015 at 11:16:36AM -0700, David Miller wrote: > From: Michael Grzeschik > Date: Thu, 30 Jul 2015 15:34:36 +0200 > > > The commit <9c7077622dd9> ("packet: make packet_snd fail on len smaller > > than l2 header") adds the check for minimum packet length of the used l2. > > For arcne

Re: veths often slow to come up

2015-08-05 Thread Thadeu Lima de Souza Cascardo
On Tue, Aug 04, 2015 at 08:26:28PM -0700, Cong Wang wrote: > (Cc'ing netdev for network issues) > > On Tue, Aug 4, 2015 at 6:42 AM, Shaun Crampton > wrote: > > Please CC me on any responses, thanks. > > > > Setting both ends of a veth to be oper UP completes very quickly but I > > find that pings

[PATCH 0/2] of: fsl/fman: reuse the fixed node parsing code

2015-08-05 Thread Madalin Bucur
The FMan MAC configuration code needs the speed and duplex information for fixed-link interfaces that is parsed now by the of function of_phy_register_fixed_link(). This parses the fixed-link parameters but does not expose to the caller neither the phy_device pointer nor the status struct where it

[PATCH RFC 2/2] fsl_fman: use fixed_phy_status for MEMAC

2015-08-05 Thread Madalin Bucur
Use the speed and duplex information from the device tree fixed link node accessing the status structure parsed by of_phy_parse_fixed_link(). Signed-off-by: Madalin Bucur --- .../ethernet/freescale/fman/flib/fsl_fman_memac.h | 6 ++-- drivers/net/ethernet/freescale/fman/inc/mac.h | 2 +-

[PATCH RFC 1/2] of: separate fixed link parsing from registration

2015-08-05 Thread Madalin Bucur
Some drivers may need to parse the fixed link values before registering the fixed link phy or access the status values. Separate the parsing from the actual registration and provide an export for the added parsing function. Signed-off-by: Madalin Bucur --- drivers/of/of_mdio.c| 52 ++

Re: [PATCH net-next] vxlan: combine VXLAN_FLOWBASED into VXLAN_COLLECT_METADATA

2015-08-05 Thread Thomas Graf
On 08/04/15 at 10:51pm, Alexei Starovoitov wrote: > IFLA_VXLAN_FLOWBASED is useless without IFLA_VXLAN_COLLECT_METADATA, > so combine them into single IFLA_VXLAN_COLLECT_METADATA flag. > 'flowbased' doesn't convey real meaning of the vxlan tunnel mode. > This mode can be used by routing, tc+bpf and

Re: [PATCH net-next] vxlan: expose COLLECT_METADATA flag to user space

2015-08-05 Thread Thomas Graf
On 08/03/15 at 02:14pm, Jesse Gross wrote: > On Fri, Jul 31, 2015 at 8:41 AM, Alexei Starovoitov wrote: > > thanks. I think exposing collect_metadata for vxlan and in the future > > for other tunnel types is the clean enough way, though the other > > alternative would be to get rid of collect_meta

Re: [PATCH 5/5] net: rfkill: gpio: remove rfkill_gpio_platform_data

2015-08-05 Thread Andy Shevchenko
On Wed, 2015-08-05 at 16:39 +0300, Heikki Krogerus wrote: > No more users for it. > > Signed-off-by: Heikki Krogerus > --- > include/linux/rfkill-gpio.h | 37 --- > -- > net/rfkill/Kconfig | 3 +-- > net/rfkill/rfkill-gpio.c| 8 > 3 files c

  1   2   >