Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

On Tue, Aug 18, 2015 at 09:08:42AM +, Premkumar Jonnala wrote: -Original Message- From: Rosen, Rami [mailto:rami.ro...@intel.com] Sent: Tuesday, August 18, 2015 10:25 AM To: Premkumar Jonnala; roopa Cc: netdev@vger.kernel.org Subject: RE: [PATCH] bridge: Enable

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

On Mon, Aug 17, 2015 at 10:55 PM, Jiri Pirko j...@resnulli.us wrote: Tue, Aug 18, 2015 at 12:36:17AM CEST, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com tree /sys/kernel/debug/rocker /sys/kernel/debug/rocker └── 525400123501 ├── fdb_tbl ├── internal_vlan_tbl ├──

[PATCH 05/21] net: nlmon: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Daniel Borkmann dbork...@redhat.com --- drivers/net/nlmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nlmon.c b/drivers/net/nlmon.c index 34924df..7b7c70e 100644 --- a/drivers/net/nlmon.c +++ b/drivers/net/nlmon.c @@

[PATCH 00/21] net: Convert drivers to IFF_NO_QUEUE and cleanup afterwards

This series converts in-tree users away from the old and deprecated 'tx_queue_len = 0' idiom, adds a warning to notify out-of-tree driver maintainers that there is need for action on their behalf and finally drops any workarounds in scheduling algorithm implementations. Phil Sutter (21): net:

[PATCH 20/21] net: warn if drivers set tx_queue_len = 0

Due to the introduction of IFF_NO_QUEUE, there is a better way for drivers to indicate that no qdisc should be attached by default. Though, the old convention can't be dropped since ignoring that setting would break drivers still using it. Instead, add a warning so out-of-tree driver maintainers

[PATCH 09/21] net: bridge: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Stephen Hemminger step...@networkplumber.org --- net/bridge/br_device.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index 0aa8f5c..6ed2feb 100644 --- a/net/bridge/br_device.c +++

[PATCH 12/21] net: ipvlan: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Mahesh Bandewar mahe...@google.com --- drivers/net/ipvlan/ipvlan_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index 20b58bd..a9268db 100644 ---

[PATCH 11/21] net: bonding: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Jay Vosburgh j.vosbu...@gmail.com Cc: Veaceslav Falico vfal...@gmail.com Cc: Andy Gospodarek go...@cumulusnetworks.com --- drivers/net/bonding/bond_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 14/21] net: hostap: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Jouni Malinen j...@w1.fi --- drivers/net/wireless/hostap/hostap_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/hostap/hostap_main.c b/drivers/net/wireless/hostap/hostap_main.c index 01de1a3..80d4228

[PATCH 06/21] net: team: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Jiri Pirko j...@resnulli.us --- drivers/net/team/team.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index daa054b..651d35e 100644 --- a/drivers/net/team/team.c +++

[PATCH 04/21] net: loopback: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc --- drivers/net/loopback.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c index c76283c..dc7d970 100644 --- a/drivers/net/loopback.c +++ b/drivers/net/loopback.c @@ -165,10 +165,9 @@

[PATCH 15/21] net: mac80211_hwsim: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Johannes Berg johan...@sipsolutions.net --- drivers/net/wireless/mac80211_hwsim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index 99e873d..a1dbcb2

[PATCH 03/21] net: geneve: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: John W. Linville linvi...@tuxdriver.com --- drivers/net/geneve.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 78d49d1..897e1a3 100644 --- a/drivers/net/geneve.c +++

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

-Original Message- From: Rosen, Rami [mailto:rami.ro...@intel.com] Sent: Tuesday, August 18, 2015 10:25 AM To: Premkumar Jonnala; roopa Cc: netdev@vger.kernel.org Subject: RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices. Hi,

[patch] cxgb4: memory corruption in debugfs

You can't use kstrtoul() with an int or it causes memory corruption. Also j should be unsigned or we have underflow bugs. I considered changing j to unsigned long but everything fits in a u32. Fixes: 8e3d04fd7d70 ('cxgb4: Add MPS tracing support') Signed-off-by: Dan Carpenter

Re: Project Funding

Sir, Kindly be informed that i am still waiting for your correspondence to enable us proceed. Thank you. David -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [patch] cxgb4: memory corruption in debugfs

On Tue, Aug 18, 2015 at 07:28:53PM +0900, Tetsuo Handa wrote: Dan Carpenter wrote: You can't use kstrtoul() with an int or it causes memory corruption. Also j should be unsigned or we have underflow bugs. I considered changing j to unsigned long but everything fits in a u32. Excuse

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

Tue, Aug 18, 2015 at 08:14:48AM CEST, sfel...@gmail.com wrote: On Mon, Aug 17, 2015 at 10:55 PM, Jiri Pirko j...@resnulli.us wrote: Tue, Aug 18, 2015 at 12:36:17AM CEST, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com tree /sys/kernel/debug/rocker /sys/kernel/debug/rocker └──

[PATCH 16/21] net: batman-adv: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Marek Lindner mareklind...@neomailbox.ch Cc: Simon Wunderlich s...@simonwunderlich.de Cc: Antonio Quartulli anto...@meshcoding.com --- net/batman-adv/soft-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 18/21] net: caif: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Dmitry Tarnyagin dmitry.tarnya...@lockless.no --- drivers/net/caif/caif_hsi.c| 2 +- drivers/net/caif/caif_serial.c | 2 +- drivers/net/caif/caif_spi.c| 2 +- drivers/net/wan/hdlc_fr.c | 2 +- net/caif/caif_dev.c| 2 +- 5 files

[PATCH 01/21] net: veth: enable noqueue operation by default

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Pavel Emelyanov xe...@openvz.org --- drivers/net/veth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index 343592c..0ef4a5a 100644 --- a/drivers/net/veth.c +++ b/drivers/net/veth.c @@ -306,6 +306,7 @@ static

Re: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

On Fri, 14 Aug 2015, Premkumar Jonnala wrote: Bridge devices have ageing interval used to age out MAC addresses from FDB. This ageing interval was not configuratble. Enable netlink based configuration of ageing interval for bridges and switch devices. The ageing interval changes the timer

Re: [PATCH 1/6] net/bonding: enable LRO if one device supports it

On Mon, Aug 17, 2015 at 05:07:06PM -0400, Jarod Wilson wrote: On 2015-08-14 7:41 PM, Jarod Wilson wrote: Yeah, my thinking was that it should mean there's at least one lro capable slave. If we just leave things the way they are though, I think its confusing on the user side -- it was one of

linux-next: build failure after merge of the net-next tree

Hi all, After merging the net-next tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/net/built-in.o: In function `.vnic_wq_devcmd2_alloc': (.text+0x49fe40): multiple definition of `.vnic_wq_devcmd2_alloc' drivers/scsi/built-in.o:(.text+0xb4318): first defined here

[PATCH net-next] bnx2x: Add vxlan RSS support

From: Rajesh Borundia rajesh.borun...@qlogic.com Latest FW submission added some vxlan offload capabilities to our device. This patch adds the ability to connect to the vxlan NDOs and configure the UDP port associated with it in the HW. The device would now be capable of performing RSS according

[PATCH 02/21] net: dummy: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc --- drivers/net/dummy.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c index 49adbf1..815eb94 100644 --- a/drivers/net/dummy.c +++ b/drivers/net/dummy.c @@ -144,10 +144,9 @@ static void

[PATCH 08/21] net: 8021q: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Patrick McHardy ka...@trash.net --- net/8021q/vlan_dev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index 01d7ba8..fded865 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c

Re: rt2x00: adjust EEPROM_SIZE for rt2500usb

rt2500usb_validate_eeprom() read data up to 0x6e (EEPROM_CALIBRATE_OFFSET) but only 0x6a bytes has been allocated and read from the eeprom. This lead to out-of-bound accesses and invalid values for EEPROM_BBPTUNE_R17 and EEPROM_CALIBRATE_OFFSET. Change the EEPROM_SIZE to 0x6e in order to

RE: Should driver set CHECKSUM_COMPLETE for TCP pakcets

Consider a device that doesn't provide the complete checksum for entire Rx packets, but does verify the checksums for several protocols. Now, assuming the HW is capable of verifying TCP checksums - Should the driver calculate the pseudo TCP checksum for such packets and pass those as COMPLETE? Or

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

On Mon, Aug 17, 2015 at 11:48 PM, Jiri Pirko j...@resnulli.us wrote: Tue, Aug 18, 2015 at 08:14:48AM CEST, sfel...@gmail.com wrote: On Mon, Aug 17, 2015 at 10:55 PM, Jiri Pirko j...@resnulli.us wrote: Tue, Aug 18, 2015 at 12:36:17AM CEST, sfel...@gmail.com wrote: From: Scott Feldman

Re: [PATCH 15/21] net: mac80211_hwsim: convert to using IFF_NO_QUEUE

On Tue, 2015-08-18 at 10:30 +0200, Phil Sutter wrote: Signed-off-by: Phil Sutter p...@nwl.cc Cc: Johannes Berg johan...@sipsolutions.net --- drivers/net/wireless/mac80211_hwsim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mac80211_hwsim.c

Should driver set CHECKSUM_COMPLETE for TCP pakcets

Consider a device that doesn't provide the complete checksum for entire Rx packets, but does verify the checksums for several protocols. Now, assuming the HW is capable of verifying TCP checksums - Should the driver calculate the pseudo TCP checksum for such packets and pass those as COMPLETE? Or

[PATCH 13/21] net: dsa: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Lennert Buytenhek buyt...@wantstofly.org --- net/dsa/slave.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 373ff31..cce9738 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -1147,7

[PATCH 19/21] staging: wilc1000: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Johnny Kim johnny@atmel.com Cc: Rachel Kim rachel@atmel.com Cc: Dean Lee dean@atmel.com Cc: Chris Park chris.p...@atmel.com --- drivers/staging/wilc1000/linux_mon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 21/21] net: sched: drop all special handling of tx_queue_len == 0

Those were all workarounds for the formerly double meaning of tx_queue_len, which broke scheduling algorithms if untreated. Now that all in-tree drivers have been converted away from setting tx_queue_len = 0, it should be safe to drop these workarounds for categorically broken setups.

[PATCH 17/21] net: hsr: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Arvid Brodin arvid.bro...@alten.se --- net/hsr/hsr_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c index 44d2746..35a9788 100644 --- a/net/hsr/hsr_device.c +++

[PATCH 10/21] net: 6lowpan: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Alexander Aring alex.ar...@gmail.com --- net/ieee802154/6lowpan/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c index f20a387..d7fb995 100644 ---

[PATCH 07/21] net: vxlan: convert to using IFF_NO_QUEUE

Signed-off-by: Phil Sutter p...@nwl.cc Cc: Stephen Hemminger step...@networkplumber.org --- drivers/net/vxlan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 06c0731..ad51dac 100644 --- a/drivers/net/vxlan.c +++

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

Tue, Aug 18, 2015 at 09:21:15AM CEST, sfel...@gmail.com wrote: On Mon, Aug 17, 2015 at 11:48 PM, Jiri Pirko j...@resnulli.us wrote: Tue, Aug 18, 2015 at 08:14:48AM CEST, sfel...@gmail.com wrote: On Mon, Aug 17, 2015 at 10:55 PM, Jiri Pirko j...@resnulli.us wrote: Tue, Aug 18, 2015 at 12:36:17AM

RE: [PATCH net] inet: fix potential deadlock in reqsk_queue_unlink()

From: Eric Dumazet Sent: 13 August 2015 23:45 When replacing del_timer() with del_timer_sync(), I introduced a deadlock condition : reqsk_queue_unlink() is called from inet_csk_reqsk_queue_drop() inet_csk_reqsk_queue_drop() can be called from many contexts, one being the timer handler

Re: [patch] cxgb4: memory corruption in debugfs

Dan Carpenter wrote: You can't use kstrtoul() with an int or it causes memory corruption. Also j should be unsigned or we have underflow bugs. I considered changing j to unsigned long but everything fits in a u32. Excuse me, but kstrtouint()'s last argument is not u32 * but unsigned int *.

[PATCH net] batman-adv: Fix memory leak on tt add with invalid vlan

The object tt_local is allocated with kmalloc and not initialized when the function batadv_tt_local_add checks for the vlan. But this function can only cleanup the object when the (not yet initialized) reference counter of the object is 1. This is unlikely and thus the object would leak when the

[PATCH] net: ipv4: inlining ip_send_check()

ip_send_check() is a function that does nothing but calling ip_fast_csum() after having zeroed iph-check We get (on PPC) a quite long function for just that, as it requires setting the stack frame, saving volatile regs, restoring them after the call, etc ... c02d3e3c ip_send_check: c02d3e3c:

RE: [PATCH] bridge: Enable configuration of ageing interval for bridges and switch devices.

Hi, Prem, I recall that there was a patch proposed to prevent ageing of fdb entried by bridge in kernel, when the fdb entry was added due to notification by switch device. Please see: http://www.spinics.net/lists/netdev/msg314770.html Somehow the patch is not visible in the net-next pull.

Re: [PATCH 00/21] net: Convert drivers to IFF_NO_QUEUE and cleanup afterwards

From: Phil Sutter p...@nwl.cc Date: Tue, 18 Aug 2015 10:30:28 +0200 This series converts in-tree users away from the old and deprecated 'tx_queue_len = 0' idiom, adds a warning to notify out-of-tree driver maintainers that there is need for action on their behalf and finally drops any

Re: [net-next]: unable to add routes to tables

On 8/18/15 10:57 AM, Andreas Schultz wrote: Hi, It seems that the policy for adding routes to tables has changed between Linux 4.2-rc6 and net-next. In Linux main line (tested up to 4.2-rc6), with this main routing table: # ip route show table main ... 172.28.0.0/24 dev vnf-xe1p0 proto kernel

[PATCH, net-next] r8169:Correct value on RxMaxSize register

On here want to be original value, period. Signed-off-by: Corcodel Marian corcodel.mar...@gmail.com diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index aff5437..6d16de3 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

On Tue, Aug 18, 2015 at 7:01 AM, Andrew Lunn and...@lunn.ch wrote: On Mon, Aug 17, 2015 at 03:36:17PM -0700, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com tree /sys/kernel/debug/rocker /sys/kernel/debug/rocker ? 525400123501 ? fdb_tbl ?

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

On Tue, Aug 18, 2015 at 10:18:51AM -0700, Scott Feldman wrote: On Tue, Aug 18, 2015 at 7:01 AM, Andrew Lunn and...@lunn.ch wrote: On Mon, Aug 17, 2015 at 03:36:17PM -0700, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com tree /sys/kernel/debug/rocker

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

From: Jiri Pirko j...@resnulli.us Date: Tue, 18 Aug 2015 07:55:55 +0200 Tue, Aug 18, 2015 at 12:36:17AM CEST, sfel...@gmail.com wrote: +static int rocker_probe_debugfs_init(struct rocker *rocker) +{ + char dbg_dir_name[sizeof(rocker-hw.id) * 2 + 1]; + + sprintf(dbg_dir_name, %*phN,

Re: [PATCH 15/21] net: mac80211_hwsim: convert to using IFF_NO_QUEUE

From: Johannes Berg johan...@sipsolutions.net Date: Tue, 18 Aug 2015 10:43:55 +0200 On Tue, 2015-08-18 at 10:30 +0200, Phil Sutter wrote: Signed-off-by: Phil Sutter p...@nwl.cc Cc: Johannes Berg johan...@sipsolutions.net --- drivers/net/wireless/mac80211_hwsim.c | 2 +- 1 file changed, 1

Re: [net-next RFC] net: ipv4: Send IGMP messages from highest scoped address

From: Andrew Lunn and...@lunn.ch Date: Tue, 18 Aug 2015 15:36:41 +0200 We currently take the first address from the interface which is scope link or higher. Historically, the global scope address would of been used, but my previous fix, which stopped it taking a global scope address from a

[net-next]: unable to add routes to tables

Hi, It seems that the policy for adding routes to tables has changed between Linux 4.2-rc6 and net-next. In Linux main line (tested up to 4.2-rc6), with this main routing table: # ip route show table main ... 172.28.0.0/24 dev vnf-xe1p0 proto kernel scope link src 172.28.0.16 and an empty

[PATCH net-next 0/4] vrf: a few simplifications and cleanups

From: Nikolay Aleksandrov niko...@cumulusnetworks.com Hi, These patches remove some unnecessary checks (patches 3, 4), unnecessary num_slaves member and refcnt manipulations which are already done by the upper functions. Cheers, Nik Nikolay Aleksandrov (4): vrf: drop unnecessary dev refcnt

[PATCH net-next 1/4] vrf: drop unnecessary dev refcnt changes

From: Nikolay Aleksandrov niko...@cumulusnetworks.com netdev_master_upper_dev_link/unlink already do a dev_hold/put on the devices being linked, so no need to take another reference. Signed-off-by: Nikolay Aleksandrov niko...@cumulusnetworks.com --- drivers/net/vrf.c | 2 -- 1 file changed, 2

[PATCH net-next 3/4] vrf: don't check for dstats and rth in uninit path

From: Nikolay Aleksandrov niko...@cumulusnetworks.com dstats and rth are always present because we fail the device registration if they can't be allocated in vrf_init() (ndo_init) so drop the unnecessary checks. Signed-off-by: Nikolay Aleksandrov niko...@cumulusnetworks.com ---

[PATCH net-next 2/4] vrf: drop unused num_slaves member

From: Nikolay Aleksandrov niko...@cumulusnetworks.com slave_queue has a num_slaves member which is unused, drop it. Signed-off-by: Nikolay Aleksandrov niko...@cumulusnetworks.com --- drivers/net/vrf.c | 2 -- include/net/vrf.h | 1 - 2 files changed, 3 deletions(-) diff --git

[PATCH net-next 4/4] vrf: simplify the netdev notifier function

From: Nikolay Aleksandrov niko...@cumulusnetworks.com We can drop the check because if vrf_ptr is present then we must have the vrf device as a master and since we're running with rtnl it can't go away. Signed-off-by: Nikolay Aleksandrov niko...@cumulusnetworks.com --- drivers/net/vrf.c | 5

Re: [net-next]: unable to add routes to tables

On 8/18/15 10:57 AM, Andreas Schultz wrote: Hi, It seems that the policy for adding routes to tables has changed between Linux 4.2-rc6 and net-next. In Linux main line (tested up to 4.2-rc6), with this main routing table: # ip route show table main ... 172.28.0.0/24 dev vnf-xe1p0 proto kernel

Re: [PATCH] bluetooth:Fix variable assignment for switch case in the function a2mp_chan_recv_cb

Hi Nicholas, This fixes the issue with not assigning the variable err to the return value of the call to the function a2mp_command_rej for the switch case A2MP_COMMAND_REJ as this function call can fail and thus callers of a2mp_chan_recv_cb should be signaled when this internal function call

[PATCH net-next] r8169:Set RxConfig on same func. with TxConfig

Add set DMA burst size and Rx FIFO threshold on RxConfig register to function rtl_set_rx_tx_config_register. Signed-off-by: Corcodel Marian corcodel.mar...@gmail.com diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 6d16de3..c3c908c 100644 ---

[PATCH net-next] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock

From: Nikolay Aleksandrov niko...@cumulusnetworks.com While running net-next I hit this: [ 634.073119] === [ 634.073150] [ INFO: suspicious RCU usage. ] [ 634.073182] 4.2.0-rc6+ #45 Not tainted [ 634.073213] --- [ 634.073244]

Re: [PATCH net-next] lwtunnel: fix memory leak

On 8/18/15, 9:41 AM, Jiri Benc wrote: The built lwtunnel_state struct has to be freed after comparison. Fixes: 571e722676fe3 (ipv4: support for fib route lwtunnel encap attributes) Signed-off-by: Jiri Benc jb...@redhat.com --- Acked-by: Roopa Prabhu ro...@cumulusnetworks.com looks like this

Re: [PATCH net-next] r8169:Set RxConfig on same func. with TxConfig

From: Corcodel Marian corcodel.mar...@gmail.com Date: Tue, 18 Aug 2015 22:10:21 +0300 Add set DMA burst size and Rx FIFO threshold on RxConfig register to function rtl_set_rx_tx_config_register. Signed-off-by: Corcodel Marian corcodel.mar...@gmail.com I would like to politely ask

Re: [PATCH net-next v2] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock

On Aug 18, 2015, at 11:10 PM, David Ahern d...@cumulusnetworks.com wrote: On 8/18/15 12:15 PM, Nikolay Aleksandrov wrote: diff --git a/include/net/vrf.h b/include/net/vrf.h index 3bb4af462ed6..b039850a94a3 100644 --- a/include/net/vrf.h +++ b/include/net/vrf.h @@ -34,7 +34,6 @@ struct

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

On Tue, Aug 18, 2015 at 11:19 AM, Andrew Lunn and...@lunn.ch wrote: On Tue, Aug 18, 2015 at 10:18:51AM -0700, Scott Feldman wrote: On Tue, Aug 18, 2015 at 7:01 AM, Andrew Lunn and...@lunn.ch wrote: On Mon, Aug 17, 2015 at 03:36:17PM -0700, sfel...@gmail.com wrote: From: Scott Feldman

Re: [net-next RFC] net: ipv4: Send IGMP messages from highest scoped address

On Tue, Aug 18, 2015 at 12:01:10PM -0700, David Miller wrote: From: Andrew Lunn and...@lunn.ch Date: Tue, 18 Aug 2015 15:36:41 +0200 We currently take the first address from the interface which is scope link or higher. Historically, the global scope address would of been used, but my

[net-next 06/15] igb: Teardown SR-IOV before unregister_netdev()

From: Alex Williamson alex.william...@redhat.com When the .remove() callback for a PF is called, SR-IOV support for the device is disabled, which requires unbinding and removing the VFs. The VFs may be in-use either by the host kernel or userspace, such as assigned to a VM through vfio-pci. In

[net-next 09/15] igb: Fix a deadlock in igb_sriov_reinit

From: Jia-Ju Bai baijiaju1...@163.com When igb_init_interrupt_scheme in igb_sriov_reinit is failed, the lock acquired by rtnl_lock() is not released, which causes a deadlock. This patch adds rtnl_unlock() in error handling to fix it. Signed-off-by: Jia-Ju Bai baijiaju1...@163.com Tested-by:

[net-next 03/15] igb: do not re-init SR-IOV during probe

From: Stefan Assmann sassm...@kpanic.de During driver probing the following code path is triggered. igb_probe -igb_sw_init -igb_probe_vfs -igb_pci_enable_sriov -igb_sriov_reinit Doing the SR-IOV re-init is not necessary during probing since we're starting from scratch. Here we can

[net-next 11/15] igb: Fix a memory leak in igb_probe

From: Jia-Ju Bai baijiaju1...@163.com In error handling code of igb_probe, the memory adapter-shadow_vfta allocated by kcalloc in igb_sw_init is not freed. So when register_netdev or igb_init_i2c is failed, a memory leak will occur. This patch adds kfree to fix it. Signed-off-by: Jia-Ju Bai

[net-next 15/15] ixgbe: TRIVIAL fix up double 'the' and comment style

From: Jacob Keller jacob.e.kel...@intel.com Signed-off-by: Jacob Keller jacob.e.kel...@intel.com Tested-by: Phil Schmitt phillip.j.schm...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +-- 1 file changed, 1 insertion(+),

[net-next 13/15] igb: make sure SR-IOV init uses the right number of queues

From: Todd Fujinaka todd.fujin...@intel.com Recent changes to igb_probe_vfs() could lead to the PF holding onto all of the queues. Reorder igb_probe_vfs() to be before gb_init_queue_configuration() and add some more error checking. Signed-off-by: Todd Fujinaka todd.fujin...@intel.com Tested-by:

[net-next 14/15] ixgbe: Simplify port-specific macros

From: Mark Rustad mark.d.rus...@intel.com Simplify port-specific macros by eliminating explicit comparison with 0. More importantly, enclose formal parameter in parens to eliminate the risk of an operator precedence surprise. Signed-off-by: Mark Rustad mark.d.rus...@intel.com Tested-by: Phil

[PATCH net-next 09/13] vxlan: provide access function for vxlan socket address family

Signed-off-by: Jiri Benc jb...@redhat.com --- drivers/net/vxlan.c | 8 include/net/vxlan.h | 5 + 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index e4b8ab63d0fa..d5ca1d7e0b81 100644 --- a/drivers/net/vxlan.c +++

[PATCH net-next 01/13] ip_tunnels: remove custom alignment and packing

The custom alignment of struct ip_tunnel_key is unnecessary. In struct sw_flow_key, it starts at offset 256, in struct ip_tunnel_info it's the first field. The structure is also packed even without the __packed keyword. Signed-off-by: Jiri Benc jb...@redhat.com --- include/net/ip_tunnels.h | 2

[PATCH net-next 11/13] vxlan: metadata based tunneling for IPv6

Support metadata based (formerly flow based) tunneling also for IPv6. This complements commit ee122c79d422 (vxlan: Flow based tunneling). Signed-off-by: Jiri Benc jb...@redhat.com --- drivers/net/vxlan.c | 69 +++-- 1 file changed, 40

[PATCH net-next 13/13] ipv6: route: per route IP tunnel metadata via lightweight tunnel

Allow specification of per route IP tunnel instructions also for IPv6. This complements commit 3093fbe7ff4b (route: Per route IP tunnel metadata via lightweight tunnel). Signed-off-by: Jiri Benc jb...@redhat.com --- include/uapi/linux/lwtunnel.h | 16 +++ net/ipv4/ip_tunnel_core.c | 102

[PATCH net-next 05/13] ip_tunnels: use tos and ttl fields also for IPv6

Rename the ipv4_tos and ipv4_ttl fields to just 'tos' and 'ttl', as they'll be used with IPv6 tunnels, too. Signed-off-by: Jiri Benc jb...@redhat.com --- drivers/net/vxlan.c| 8 include/net/ip_tunnels.h | 8 net/ipv4/ip_gre.c | 8

[PATCH net-next 02/13] ip_tunnels: use u8/u16/u32

The ip_tunnels.h include file uses mixture of __u16 and u16 (etc.) types. Unify it to the non-underscore variants. Signed-off-by: Jiri Benc jb...@redhat.com --- include/net/ip_tunnels.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/net/ip_tunnels.h

[net-next 04/15] igb: implement high frequency periodic output signals

From: Richard Cochran richardcoch...@gmail.com In addition to interrupt driven target time output events, the i210 also has two programmable clock outputs. These clocks support periods between 16 nanoseconds and 140 milliseconds. This patch implements the periodic output function using the

[net-next 02/15] igb: missing rtnl_unlock in igb_sriov_reinit()

From: Vasily Averin v...@virtuozzo.com Signed-off-by: Vasily Averin v...@virtuozzo.com Tested-by: Aaron Brown aaron.f.br...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git

[net-next 00/15][pull request] Intel Wired LAN Driver Updates 2015-08-18

This series contains updates to igb, e100, e1000e and ixgbe. Shota Suzuki provides a fix for a possible overflow in igb_set_interrupt_capability() which leads to an oops. When changing the number of queues by ethtool -L, set IGB_FLAG_QUEUE_PAIRS in the same manner as when initializing the igb

[net-next 10/15] e1000e: Modify Tx/Rx configurations to avoid null pointer dereferences in e1000_open

From: Jia-Ju Bai baijiaju1...@163.com When e1000e_setup_rx_resources is failed in e1000_open, e1000e_free_tx_resources in err_setup_rx segment is executed. writel(0, tx_ring-head) statement in e1000_clean_tx_ring in e1000e_free_tx_resources will cause a null poonter dereference(crash), because

[net-next 05/15] igb: add support for 1512 PHY

From: Todd Fujinaka todd.fujin...@intel.com This patch adds support for Marvell PHY 1512 (required for I354). Submitted by: Maciej Szwed maciej.sz...@intel.com Signed-off-by: Todd Fujinaka todd.fujin...@intel.com Tested-by: Aaron Brown aaron.f.br...@intel.com Signed-off-by: Jeff Kirsher

[net-next 01/15] igb: Fix oops caused by missing queue pairing

From: Shota Suzuki suzuki_shota...@lab.ntt.co.jp When initializing igb driver (e.g. 82576, I350), IGB_FLAG_QUEUE_PAIRS is set if adapter-rss_queues exceeds half of max_rss_queues in igb_init_queue_configuration(). On the other hand, IGB_FLAG_QUEUE_PAIRS is not set even if the number of queues

[net-next 12/15] igbvf: clear buffer_info-dma after dma_unmap_single()

From: Stefan Assmann sassm...@kpanic.de The driver doesn't clear buffer_info-dma after calling dma_unmap_single() in all cases. This has been discovered by changing the mtu twice, which caused the following backtrace. [ 68.569280] WARNING: CPU: 2 PID: 1860 at drivers/iommu/intel-iommu.c:3517

Re: [PATCH net-next 0/4] vrf: a few simplifications and cleanups

On 8/18/15 11:28 AM, Nikolay Aleksandrov wrote: From: Nikolay Aleksandrov niko...@cumulusnetworks.com Hi, These patches remove some unnecessary checks (patches 3, 4), unnecessary num_slaves member and refcnt manipulations which are already done by the upper functions. Cheers, Nik Nikolay

[PATCH net-next v2] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock

From: Nikolay Aleksandrov niko...@cumulusnetworks.com While running net-next I hit this: [ 634.073119] === [ 634.073150] [ INFO: suspicious RCU usage. ] [ 634.073182] 4.2.0-rc6+ #45 Not tainted [ 634.073213] --- [ 634.073244]

[PATCH net-next 04/13] ip_tunnels: add IPv6 addresses to ip_tunnel_key

Signed-off-by: Jiri Benc jb...@redhat.com --- drivers/net/vxlan.c| 6 +++--- include/net/ip_tunnels.h | 23 +++ net/core/filter.c | 4 ++-- net/ipv4/ip_gre.c | 10 +- net/ipv4/ip_tunnel_core.c | 8

[PATCH net-next 07/13] ipv6: drop metadata dst in ip6_route_input

The fix in commit 48fb6b554501 is incomplete, as now ip6_route_input can be called with non-NULL dst if it's a metadata dst and the reference is leaked. Drop the reference. Fixes: 48fb6b554501 (ipv6: fix crash over flow-based vxlan device) Fixes: ee122c79d422 (vxlan: Flow based tunneling) CC:

[PATCH net-next 08/13] ipv6: ndisc: inherit metadata dst when creating ndisc requests

If output device wants to see the dst, inherit the dst of the original skb in the ndisc request. This is an IPv6 counterpart of commit 0accfc268f4d (arp: Inherit metadata dst when creating ARP requests). Signed-off-by: Jiri Benc jb...@redhat.com --- include/net/ndisc.h | 3 ++-

[PATCH net-next 03/13] ip_tunnels: use offsetofend

Signed-off-by: Jiri Benc jb...@redhat.com --- include/net/ip_tunnels.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/net/ip_tunnels.h b/include/net/ip_tunnels.h index ca173f22f07f..cc3b39e9010b 100644 --- a/include/net/ip_tunnels.h +++ b/include/net/ip_tunnels.h

[PATCH net-next 12/13] ipv6: route: extend flow representation with tunnel key

Use flowi_tunnel in flowi6 similarly to what is done with IPv4. This complements commit 1b7179d3adff (route: Extend flow representation with tunnel key). Signed-off-by: Jiri Benc jb...@redhat.com --- include/net/flow.h | 1 + net/ipv6/route.c | 6 ++ 2 files changed, 7 insertions(+) diff

Re: [PATCH net-next v3] rocker: add debugfs support to dump internal tables

From: Scott Feldman sfel...@gmail.com Date: Tue, 18 Aug 2015 13:37:56 -0700 On Tue, Aug 18, 2015 at 11:19 AM, Andrew Lunn and...@lunn.ch wrote: On Tue, Aug 18, 2015 at 10:18:51AM -0700, Scott Feldman wrote: On Tue, Aug 18, 2015 at 7:01 AM, Andrew Lunn and...@lunn.ch wrote: On Mon, Aug 17,

Re: [PATCH net-next] r8169:Set RxConfig on same func. with TxConfig

On Tue, 2015-08-18 at 22:10 +0300, Corcodel Marian wrote: Add set DMA burst size and Rx FIFO threshold on RxConfig register to function rtl_set_rx_tx_config_register. Signed-off-by: Corcodel Marian corcodel.mar...@gmail.com diff --git a/drivers/net/ethernet/realtek/r8169.c

[PATCH net-next 06/13] route: move lwtunnel state to dst_entry

Currently, the lwtunnel state resides in per-protocol data. This is a problem if we encapsulate ipv6 traffic in an ipv4 tunnel (or vice versa). The xmit function of the tunnel does not know whether the packet has been routed to it by ipv4 or ipv6, yet it needs the lwtstate data. Moving the

[PATCH net-next 10/13] vxlan: do not shadow flags variable

The 'flags' variable is already defined in the outer scope. Signed-off-by: Jiri Benc jb...@redhat.com --- drivers/net/vxlan.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index d5ca1d7e0b81..d0caac63231c 100644 ---

[PATCH net-next 00/13] lwtunnel: per route ipv6 support for vxlan

This series enables IPv6 tunnels based on lwtunnel infrastructure. Only vxlan is supported for now. Tested in all combinations of IPv4 over IPv6, IPv6 over IPv4 and IPv6 over IPv6. Applies on top of the two generic/IPv4 fixes I posted earlier today. Jiri Benc (13): ip_tunnels: remove custom

[net-next 08/15] e100: Release skb when DMA mapping is failed in e100_xmit_prepare

From: Jia-Ju Bai baijiaju1...@163.com When pci_dma_mapping_error in e100_xmit_prepare is failed, the skb buffer allocated by netdev_alloc_skb_ip_align in e100_rx_alloc_skb is not released, which causes a possible resource leak. This patch adds error handling code to fix it. Signed-off-by: Jia-Ju

  1   2   >