Re: [PATCH net-next 1/4] net: qdisc: add op to run filters/actions before enqueue

2015-09-01 Thread Eric Dumazet
On Tue, 2015-09-01 at 18:34 +0200, Daniel Borkmann wrote: > From: John Fastabend > > Add a new ->preclassify() op to allow multiqueue queuing disciplines > to call tc_classify() or perform other work before dev_pick_tx(). > > This helps, for example, with mqprio

[PATCH] net: Make table id type u32

2015-09-01 Thread David Ahern
A number of VRF patches used 'int' for table id. It should be u32 to be consistent with the rest of the stack. Fixes: 4e3c89920cd3a ("net: Introduce VRF related flags and helpers") 15be405eb2ea9 ("net: Add inet_addr lookup by table") 30bbaa1950055 ("net: Fix up inet_addr_type checks")

Re: [PATCH RFC v2 09/21] net: rbridge: add elected dtroot

2015-09-01 Thread Sergei Shtylyov
Hello. On 09/01/2015 06:43 PM, Ahmed Amamou wrote: Signed-off-by: Ahmed Amamou --- net/bridge/rbr.c | 14 ++ net/bridge/rbr_private.h | 2 ++ net/bridge/rbr_rtnetlink.c | 6 ++ 3 files changed, 22 insertions(+) diff --git a/net/bridge/rbr.c

Re: [PATCH RFC v2 10/21] net: rbridge: add rbr_node management function

2015-09-01 Thread Sergei Shtylyov
On 09/01/2015 06:43 PM, Ahmed Amamou wrote: rbr_node are used to save distant Rbridges information they are use by local Rbridge to take routing decision this patch add get/put/free/find/del function to rbr_node to avoid freeing a rbr_node that is still in use for routing Signed-off-by: Ahmed

Re: [PATCH] net: Fix behavior of unreachable, blackhole and prohibit routes

2015-09-01 Thread Alexander Duyck
On 09/01/2015 03:13 AM, Nikola Forró wrote: Man page of ip-route(8) says the following about route types: unreachable - these destinations are unreachable. Packets are dis‐ carded and the ICMP message host unreachable is generated. The local senders get an EHOSTUNREACH error.

[PATCH v5 09/10] ss: fixed free on local array for valid json output

2015-09-01 Thread Matthias Tafelmeier
Minor fix to enable json output. Freeing of automatic char array name which will get freed after function stack cleanup. Another one after tcp_stats_fmt for freeing automatic tcpstats struct instance. Signed-off-by: Matthias Tafelmeier --- misc/ss.c | 6 -- 1

Please help us fight spam

2015-09-01 Thread Zarafa webaccess
-- Dear Valued Subscriber, Due to spam complaints of email users in our web-mail system, our investigation shows that your email address is compromised in our web-mail system. As a result, your User name will be disabled if you do not send us the required information immediately for

[PATCH v5 02/10] ss: created formatters for json and hr

2015-09-01 Thread Matthias Tafelmeier
This patch creates a central formatter module that acts as a kind of switch. From there, more specific handler modules for the certain output formats are called. Up to now, humand readable and json do exist. That prepares ss for potential output format extensions in the future. With the help of

[PATCH v5 07/10] ss: symmetrical subhandler output extension example

2015-09-01 Thread Matthias Tafelmeier
This small sized patch shall convey the locations which have to be changed for a symmetrical output extension. Symmetrical means in this context all existing semantically related handlers in the diverse formatters (for hr and json up to now). Suggested-by: Hagen Paul Pfeifer

iproute2 v5: full ss json support and general output simplification

2015-09-01 Thread Matthias Tafelmeier
TLDR: - add full JSON support for ss - Patchset provides a general and easy to use abstraction to extend ss later - Patchset size is large to minimize daily use ("user" should not deal with formation (json, human readble) later on) - Patches 7/10 and 8/10 illustrate how to extend ss for

[PATCH v5 05/10] ss: replaced old output with new generic output mechanisms

2015-09-01 Thread Matthias Tafelmeier
This patch just adds the -j and --json flag to ss. Also it ensures proper stats components bracketization – that goes for ex. TCP, UDP, NETLINK etc. Moreover, this patch prevents human readable headers to be printed. Most importantly, with this patch, the new prepared interface to the generic

[PATCH v5 08/10] ss: symmetrical formatter extension example

2015-09-01 Thread Matthias Tafelmeier
This commit shall show shortly where to place changes when one wants to extend an ss output formatter with a new handler (format print procedure). The extension is done symmetrically. That means, every up to now existing formatter is extended with a semantically equivalent handler (hr and json

[PATCH v5 10/10] ss: activate json_writer excluded logic

2015-09-01 Thread Matthias Tafelmeier
This small patch extends the lib json_writer module for formerly deactivated functionality. Signed-off-by: Matthias Tafelmeier --- include/json_writer.h | 1 + lib/json_writer.c | 7 --- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git

[PATCH v5 01/10] ss: rooted out ss type declarations for output formatters

2015-09-01 Thread Matthias Tafelmeier
The prospected output formatters and ss do share type declarations like slabstat or tcpstat so that the decision has been made to centralize those declarations in ss_types.h. Potential future declarations shall be placed there. The latter should help amend the extent of ss.c as well.

[PATCH v5 03/10] ss: removed obsolet fmt functions

2015-09-01 Thread Matthias Tafelmeier
Those functions are obsoleted since the new fmt handler mechanism subsumes their tasks. Rendundancy would be contradictory to the new mechanism. Signed-off-by: Matthias Tafelmeier Suggested-by: Hagen Paul Pfeifer --- misc/ss.c | 190

[PATCH v5 04/10] ss: prepare timer for output handler usage

2015-09-01 Thread Matthias Tafelmeier
Minor preparation Patch Renamed, and exported timer to not have to pass it as a function local parameter argument. Signed-off-by: Matthias Tafelmeier Suggested-by: Hagen Paul Pfeifer --- misc/ss.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH net-next] net: Make table id type u32

2015-09-01 Thread Nikolay Aleksandrov
> On Sep 1, 2015, at 11:25 AM, David Ahern wrote: > > for net-next. Forgot to add to subject line. (Thanks, Roopa, for the > reminder.) > > On 9/1/15 12:18 PM, David Ahern wrote: >> A number of VRF patches used 'int' for table id. It should be u32 to be >> consistent

Re: [PATCH RFC 0/5] net: L2 only interfaces

2015-09-01 Thread Vivien Didelot
Hi Florian, All, On Aug. Tuesday 25 (35) 04:20 PM, Alexei Starovoitov wrote: > On Tue, Aug 25, 2015 at 03:50:10PM -0700, Florian Fainelli wrote: > > Hi all, > > > > This patch series implements a L2 only interface concept which basically > > denies > > any kind of IP address configuration on

[PATCH net-next v2] net: Make table id type u32

2015-09-01 Thread David Ahern
A number of VRF patches used 'int' for table id. It should be u32 to be consistent with the rest of the stack. Fixes: 4e3c89920cd3a ("net: Introduce VRF related flags and helpers") 15be405eb2ea9 ("net: Add inet_addr lookup by table") 30bbaa1950055 ("net: Fix up inet_addr_type checks")

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-09-01 Thread Tom Herbert
On Tue, Sep 1, 2015 at 12:20 PM, Pravin Shelar wrote: > On Tue, Sep 1, 2015 at 7:19 AM, Tom Herbert wrote: >> On Mon, Aug 31, 2015 at 10:15 PM, Pravin Shelar wrote: >>> On Mon, Aug 31, 2015 at 9:12 PM, Tom Herbert

Re: [PATCH net-next] net: Make table id type u32

2015-09-01 Thread David Ahern
for net-next. Forgot to add to subject line. (Thanks, Roopa, for the reminder.) On 9/1/15 12:18 PM, David Ahern wrote: A number of VRF patches used 'int' for table id. It should be u32 to be consistent with the rest of the stack. Fixes: 4e3c89920cd3a ("net: Introduce VRF related flags and

Re: [PATCH RFC v2 09/21] net: rbridge: add elected dtroot

2015-09-01 Thread ahmed amamou
On September 1, 2015 8:18:29 PM GMT+02:00, Sergei Shtylyov wrote: >Hello. > >On 09/01/2015 06:43 PM, Ahmed Amamou wrote: > >> Signed-off-by: Ahmed Amamou >> --- >> net/bridge/rbr.c | 14 ++ >>

Re: [PATCH net-next v2] net: Make table id type u32

2015-09-01 Thread Nikolay Aleksandrov
> On Sep 1, 2015, at 11:50 AM, David Ahern wrote: > > A number of VRF patches used 'int' for table id. It should be u32 to be > consistent with the rest of the stack. > > Fixes: > 4e3c89920cd3a ("net: Introduce VRF related flags and helpers") > 15be405eb2ea9 ("net:

Re: [PATCH net-next 1/4] net: qdisc: add op to run filters/actions before enqueue

2015-09-01 Thread Daniel Borkmann
On 09/01/2015 07:21 PM, Eric Dumazet wrote: On Tue, 2015-09-01 at 18:34 +0200, Daniel Borkmann wrote: From: John Fastabend Add a new ->preclassify() op to allow multiqueue queuing disciplines to call tc_classify() or perform other work before dev_pick_tx(). This

[PATCH v5 06/10] ss: renaming and export of current_filter

2015-09-01 Thread Matthias Tafelmeier
Exported current_filter as ss_current_filter, because in the fmt handlers, I need that piece of info to resolve out issues of json. Signed-off-by: Matthias Tafelmeier --- misc/ss.c | 154 +++--- 1 file changed,

Re: [PATCH net-next] net: Make table id type u32

2015-09-01 Thread David Ahern
On 9/1/15 12:39 PM, Nikolay Aleksandrov wrote: On Sep 1, 2015, at 11:25 AM, David Ahern wrote: for net-next. Forgot to add to subject line. (Thanks, Roopa, for the reminder.) On 9/1/15 12:18 PM, David Ahern wrote: A number of VRF patches used 'int' for table id.

[PATCH net 2/3] ipv6: Rename the dst_cache helper functions in ip6_tunnel

2015-09-01 Thread Martin KaFai Lau
It is a prep work to fix the dst_entry refcnt bugs in ip6_tunnel. This patch rename: 1. ip6_tnl_dst_check() to ip6_tnl_dst_get() to better reflect that it will take a dst refcnt in the next patch. 2. ip6_tnl_dst_store() to ip6_tnl_dst_set() to have a more conventional name matching with

[PATCH net 3/3] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-01 Thread Martin KaFai Lau
Problems in the current dst_entry cache in the ip6_tunnel: 1. ip6_tnl_dst_set is racy. There is no lock to protect it: - One major problem is that the dst refcnt gets messed up. F.e. the same dst_cache can be released multiple times and then triggering the infamous dst refcnt < 0

[PATCH net 0/3] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-01 Thread Martin KaFai Lau
This patch series is to fix the dst refcnt bugs in ip6_tunnel. Patch 1 and 2 are the prep works. Patch 3 is the fix. I can reproduce the bug by adding and removing the ip6gre tunnel while running a super_netperf TCP_CRR test. I get the following trace by adding WARN_ON_ONCE(newrefcnt < 0) to

[PATCH net 1/3] ipv6: Refactor common ip6gre_tunnel_init codes

2015-09-01 Thread Martin KaFai Lau
It is a prep work to fix the dst_entry refcnt bugs in ip6_tunnel. This patch refactors some common init codes used by both ip6gre_tunnel_init and ip6gre_tap_init. Signed-off-by: Martin KaFai Lau --- net/ipv6/ip6_gre.c | 37 - 1 file changed, 24

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-09-01 Thread Pravin Shelar
On Tue, Sep 1, 2015 at 7:19 AM, Tom Herbert wrote: > On Mon, Aug 31, 2015 at 10:15 PM, Pravin Shelar wrote: >> On Mon, Aug 31, 2015 at 9:12 PM, Tom Herbert wrote: >>> On Mon, Aug 31, 2015 at 3:55 PM, Pravin B Shelar

Re: [PATCH 1/2] net: Remove ndo_xmit_flush netdev operation, use signalling instead.

2015-09-01 Thread yzhu1
On 08/26/2014 07:35 AM, David Miller wrote: As reported by Jesper Dangaard Brouer, for high packet rates the overhead of having another indirect call in the TX path is non-trivial. There is the indirect call itself, and then there is all of the reloading of the state to refetch the tail pointer

Re: [PATCH 1/2] net: Remove ndo_xmit_flush netdev operation, use signalling instead.

2015-09-01 Thread David Miller
From: yzhu1 Date: Tue, 1 Sep 2015 14:46:38 +0800 > After I applied this patch, the skb->xmit_more is not always zero. There have been thousands upon thousands of commits since that change. You should be testing the tree as it currently stands, to see if xmit_more

Re: [PATCH 1/2] net: Remove ndo_xmit_flush netdev operation, use signalling instead.

2015-09-01 Thread yzhu1
On 09/01/2015 03:00 PM, David Miller wrote: From: yzhu1 Date: Tue, 1 Sep 2015 14:46:38 +0800 After I applied this patch, the skb->xmit_more is not always zero. There have been thousands upon thousands of commits since that change. You should be testing the tree as

Re: [PATCH 1/2] net: Remove ndo_xmit_flush netdev operation, use signalling instead.

2015-09-01 Thread David Miller
From: yzhu1 Date: Tue, 1 Sep 2015 15:10:23 +0800 > After running for several days, the following messages will > appear. Then you need to figure out why the value is being set. It is initialized to zero by every SKB allocation, and only very specific controlled code

[net-next:master 1560/1566] include/linux/compiler.h:447:38: error: call to '__compiletime_assert_459' declared with attribute error: BUILD_BUG_ON failed: FLOW_KEYS_HASH_OFFSET % sizeof(u32)

2015-09-01 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 41ecc3d390266acc1aa911d2ec477928a5248f75 commit: 807e165dc44fd93f9d378f861f0540a158d7343a [1560/1566] flow_dissector: Add control/reporting of fragmentation config: m68k-sun3_defconfig (attached as .config)

Re: [PATCH net 3/3] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-01 Thread Martin KaFai Lau
On Tue, Sep 01, 2015 at 03:38:36PM -0700, Eric Dumazet wrote: > On Tue, 2015-09-01 at 15:25 -0700, Martin KaFai Lau wrote: > > On Tue, Sep 01, 2015 at 02:26:58PM -0700, Eric Dumazet wrote: > > > On Tue, 2015-09-01 at 13:55 -0700, Martin KaFai Lau wrote: > > > > On Tue, Sep 01, 2015 at 01:14:20PM

Re: [net-next 06/19] ixgbe: Add support for VXLAN RX offloads

2015-09-01 Thread Tom Herbert
On Tue, Sep 1, 2015 at 6:13 PM, Jeff Kirsher wrote: > From: Mark Rustad > > Add support for VXLAN RX offloads for the X55x devices that support > them. > > Signed-off-by: Mark Rustad > Tested-by: Phil Schmitt

Re: [PATCH] net/bonding: send arp in interval if no active slave

2015-09-01 Thread Uwe Koziolek
On Tue, 01.09.2015 at 00:21 +0200 Jarod Wilson wrote: On 2015-08-17 4:51 PM, Uwe Koziolek wrote: On Mon, Aug 17, 2015 at 09:14PM +0200, Jay Vosburgh wrote: Uwe Koziolek wrote: On2015-08-17 07:12 PM,Jarod Wilson wrote: ... Uwe, can you perhaps further enlighten us

[net-next:master 1557/1566] :undefined reference to `__get_hash_from_flowi6'

2015-09-01 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 41ecc3d390266acc1aa911d2ec477928a5248f75 commit: c6cc1ca7f4d70cbb3ea3a5ca163c5dabaf155cdb [1557/1566] flowi: Abstract out functions to get flow hash based on flowi config: arm-at91_dt_defconfig (attached as

[net-next 18/19] ixgbe: Remove bimodal SR-IOV disabling

2015-09-01 Thread Jeff Kirsher
From: Alex Williamson When unbinding an SR-IOV device with VFs configured from ixgbe, the driver behaves in one of two ways. If max_vfs was specified, the SR-IOV state is disabled, removing the VFs. The occurs regardless of whether the VF count was later modified

[net-next 12/19] ixgbe: Remove second instance of lan_id variable

2015-09-01 Thread Jeff Kirsher
From: Don Skidmore This patch removes the redundant lan_id in the phy struct and uses the bus version. Both variables exist and intend to represent the STATUS register LAN_ID field. However, phy.lan_id is not bit shifted so the phy.lan_id = 0x0 for LAN Id 0 and

[net-next 15/19] ixgbe: support for ethtool set_rxfh

2015-09-01 Thread Jeff Kirsher
From: Tom Barbette Allows to change the rxfh indirection table and/or key using ethtool interface. Signed-off-by: Tom Barbette Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 +

[net-next 05/19] ixgbe: Add support for UDP-encapsulated tx checksum offload

2015-09-01 Thread Jeff Kirsher
From: Mark Rustad By using GSO for UDP-encapsulated packets, all ixgbe devices can be directed to generate checksums for the inner headers because the outer UDP checksum can be zero. So point the machinery at the inner headers and have the hardware generate the checksum.

[net-next 16/19] ixgbe: fix bounds checking in ixgbe_setup_tc for 82598

2015-09-01 Thread Jeff Kirsher
From: Emil Tantilov This patch resolves an issue where users were not able to dynamically set number of queues for 82598 via ethtool -L Reported-by: Tal Abudi Signed-off-by: Emil Tantilov Signed-off-by: Jeff Kirsher

[net-next 19/19] ixgbe: Resolve "initialized field overwritten" warnings

2015-09-01 Thread Jeff Kirsher
From: Mark Rustad Resolve warnings resulting from redundant initialization of the get_bus_info field in the mac_ops_X550* structures. Signed-off-by: Mark Rustad Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher

[net-next 11/19] ixgbe: use kzalloc for allocating one thing

2015-09-01 Thread Jeff Kirsher
From: Maninder Singh Use kzalloc rather than kcalloc(1.. The semantic patch that makes this change is as follows: // @@ @@ - kcalloc(1, + kzalloc( ...) // and removing checkpatch below CHECK: CHECK: Prefer kzalloc(sizeof(*fwd_adapter)...) over

[net-next 13/19] ixgbe: cleanup to use cached mask value

2015-09-01 Thread Jeff Kirsher
From: Don Skidmore We already cache this FW/SW semaphore mask so might as well use it for consistency. Signed-off-by: Don Skidmore Signed-off-by: Jeff Kirsher ---

[net-next 17/19] ixgbe: Add support for reporting 2.5G link speed

2015-09-01 Thread Jeff Kirsher
From: Mark Rustad Now that we can do 2.5G link speed, we need to be able to report it. Also change the nested triadic involved in creating the log message to instead use a simpler switch statement to set a string pointer. Signed-off-by: Mark Rustad

[net-next 14/19] ixgbe: Avoid needless PHY access on copper phys

2015-09-01 Thread Jeff Kirsher
From: Mark Rustad Avoid a needless PHY access on copper phys to save the 10ms wait time for each PHY access. A helper function is introduced to actually do the register access and process the contents. Signed-off-by: Mark Rustad Signed-off-by:

[net-next 00/19][pull request] Intel Wired LAN Driver Updates 2015-09-01

2015-09-01 Thread Jeff Kirsher
This series contains updates to i40e, ixgbe and ixgbevf. Anjali fixes a bug in i40e where the port is not receiving multicast or VLAN tagged packets in promiscuous mode. Which can occur when a software bridge is created on top of the device. Don adds support in ixgbe that indicates the presence

Re: [Intel-wired-lan] [PATCH] ixgbe: Limit lowest interrupt rate for adaptive interrupt moderation to 12K

2015-09-01 Thread Alexander Duyck
On 07/30/2015 03:19 PM, Alexander Duyck wrote: This patch updates the lowest limit for adaptive interrupt interrupt moderation to roughly 12K interrupts per second. The way I came about reaching 12K as the desired interrupt rate is by testing with UDP flows. Specifically I had a simple test

Re: [PATCH net 3/3] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-01 Thread Martin KaFai Lau
On Tue, Sep 01, 2015 at 01:14:20PM -0700, Eric Dumazet wrote: > On Tue, 2015-09-01 at 11:55 -0700, Martin KaFai Lau wrote: > > Problems in the current dst_entry cache in the ip6_tunnel: > > > > 1. ip6_tnl_dst_set is racy. There is no lock to protect it: > >- One major problem is that the dst

Re: [PATCH net 3/3] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-01 Thread Martin KaFai Lau
On Tue, Sep 01, 2015 at 01:14:20PM -0700, Eric Dumazet wrote: > It should not be a problem. refcnt is taken when/if necessary (skb > queued on a qdisc for example) > > We have other uses of skb_dst_set_noref() > > Please describe the problem ? The current ip6_tnl_dst_get() does not take the dst

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-09-01 Thread Tom Herbert
On Tue, Sep 1, 2015 at 2:10 PM, Pravin Shelar wrote: > On Tue, Sep 1, 2015 at 12:55 PM, Tom Herbert wrote: >> On Tue, Sep 1, 2015 at 12:20 PM, Pravin Shelar wrote: >>> On Tue, Sep 1, 2015 at 7:19 AM, Tom Herbert

Issue with /etc/netns/${nsname}/hosts

2015-09-01 Thread James Loosli
I seem to have an issue with using namespace-specific hosts files. Here's an example. I have different entries for foo.com in my hosts file for the namespace and the system-wide hosts file; root@server-01 Tue Sep 01 04:15:02pm > cat /etc/netns/nsXX-XXX-240-3/hosts | grep foo 1.2.3.4 foo.com

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-09-01 Thread Pravin Shelar
On Tue, Sep 1, 2015 at 2:25 PM, Tom Herbert wrote: > On Tue, Sep 1, 2015 at 2:10 PM, Pravin Shelar wrote: >> On Tue, Sep 1, 2015 at 12:55 PM, Tom Herbert wrote: >>> On Tue, Sep 1, 2015 at 12:20 PM, Pravin Shelar

Re: [PATCHv1 net-next 0/5] netlink: mmap: kernel panic and some issues

2015-09-01 Thread Ken-ichirou MATSUZAWA
On Wed, Aug 19, 2015 at 04:29:32PM +0200, Daniel Borkmann wrote: > On 08/17/2015 11:02 PM, David Miller wrote: > >From: Daniel Borkmann > >Date: Fri, 14 Aug 2015 12:38:21 +0200 > > > >>diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c > >>index

Re: [PATCH net 3/3] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-01 Thread Martin KaFai Lau
On Tue, Sep 01, 2015 at 05:31:44PM -0700, Martin KaFai Lau wrote: > On Tue, Sep 01, 2015 at 03:38:36PM -0700, Eric Dumazet wrote: > > On Tue, 2015-09-01 at 15:25 -0700, Martin KaFai Lau wrote: > > > On Tue, Sep 01, 2015 at 02:26:58PM -0700, Eric Dumazet wrote: > > > > On Tue, 2015-09-01 at 13:55

Re: [PATCH 2/3] rhashtable-test: retry insert operations in threads

2015-09-01 Thread Herbert Xu
On Tue, Sep 01, 2015 at 04:51:24PM +0200, Thomas Graf wrote: > > 1. The current in-kernel self-test > 2. bind_netlink.c: https://github.com/tgraf/rhashtable Thanks, I will try to reproduce this. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/

RE: [Intel-wired-lan] [PATCH] fm10k: Don't assume page fragments are page size

2015-09-01 Thread Singh, Krishneil K
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Alexander Duyck Sent: Tuesday, June 16, 2015 11:47 AM To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T Subject:

parsing ethtool output in programs/scripts

2015-09-01 Thread Robert Urban
Hello, I wish you would consider adding a switch to ethtool (and the corresponding functionality) to produce output in machine-readable format. This would be *extremely* useful. Why not add the "--machine-readable" switch mentioned here:

Re: [net-next 05/19] ixgbe: Add support for UDP-encapsulated tx checksum offload

2015-09-01 Thread Tom Herbert
On Tue, Sep 1, 2015 at 6:13 PM, Jeff Kirsher wrote: > From: Mark Rustad > > By using GSO for UDP-encapsulated packets, all ixgbe devices can > be directed to generate checksums for the inner headers because > the outer UDP checksum can be

Re: [net-next 00/19][pull request] Intel Wired LAN Driver Updates 2015-09-01

2015-09-01 Thread David Miller
From: Jeff Kirsher Date: Tue, 1 Sep 2015 18:13:44 -0700 > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue master Pulled, thanks Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [net-next:master 1560/1566] include/linux/compiler.h:447:38: error: call to '__compiletime_assert_459' declared with attribute error: BUILD_BUG_ON failed: FLOW_KEYS_HASH_OFFSET % sizeof(u32)

2015-09-01 Thread David Miller
From: kbuild test robot Date: Wed, 2 Sep 2015 07:19:48 +0800 >In function 'flow_keys_hash_start', >inlined from 'flow_hash_from_keys' at net/core/flow_dissector.c:553:34: >>> include/linux/compiler.h:447:38: error: call to '__compiletime_assert_459' >>>

Re: [PATCH net 3/3] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-01 Thread Martin KaFai Lau
On Tue, Sep 01, 2015 at 05:42:00PM -0700, Martin KaFai Lau wrote: > I look a closer look at dst_rcu_free() and your commit pointers. I can see > your point > for DST_NOCACHE. > > However, dst_free() for not DST_NOCACHE is still an issue, I think. oops. Ignore this email and continue the

[net-next 09/19] ixgbe: add new bus type for intergrated I/O interface (IOSF)

2015-09-01 Thread Jeff Kirsher
From: Don Skidmore With this patch we add support for a new bus type ixgbe_bus_type_internal. X550em devices use IOSF and not PCIe bus so this new type is to accommodate them. Signed-off-by: Donald C Skidmore Tested-by: Phil Schmitt

[net-next 03/19] ixgbe: Assign set_phy_power dynamically where needed

2015-09-01 Thread Jeff Kirsher
From: Don Skidmore There are various reasons why this method may or may not need to be defined and some of these we don't know until runtime. So we will set the value in get_invariants. Signed-off-by: Donald C Skidmore Signed-off-by:

[net-next 02/19] ixgbe: add new function to check for management presence

2015-09-01 Thread Jeff Kirsher
From: Don Skidmore This patch adds a support function that will indicate for the existence of management FW. Signed-off-by: Donald C Skidmore Signed-off-by: Jeff Kirsher ---

[net-next 10/19] ixgbe: Remove unused PCI bus types

2015-09-01 Thread Jeff Kirsher
From: Don Skidmore The ixgbe never has as very doubtfully ever will support either PCI or PCI-X devices. So remove the unused types from the ixgbe_bus_type. Thanks to Alex Duyck for suggesting this. Signed-off-by: Donald C Skidmore

[net-next 07/19] ixgbe: Add support for entering low power link up state

2015-09-01 Thread Jeff Kirsher
From: Don Skidmore When the device is closing or suspending, call ixgbe_enter_lplu to enter low power link up state on devices that support it. When this is done, prevent the phy from being reset in the ixgbe_down path so that link is present when calling

[net-next 04/19] ixgbe: Check whether FDIRCMD writes actually complete

2015-09-01 Thread Jeff Kirsher
From: Mark Rustad Wait up to about 100 us for FDIRCMD writes to complete and return failure indications. Signed-off-by: Mark Rustad Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher

[net-next 08/19] ixgbe: add get_bus_info method for X550

2015-09-01 Thread Jeff Kirsher
From: Don Skidmore Added ixgbe_get_bus_info_X550em to X550 code. ixgbe_get_bus_info_X550em sets bus.width to ixgbe_bus_width_unknown and bus.speed to ixgbe_bus_speed_unknown, because IOSF does not report a PCIe bus width or speed. Signed-off-by: Don Skidmore

[net-next 01/19] i40e: Set defport behavior for the Main VSI when in promiscuous mode

2015-09-01 Thread Jeff Kirsher
From: Anjali Singhai Jain This fixes bugs where the port is not receiving multicast or VLAN tagged packets when in promiscuous mode. This can occur when a SW bridge is created on top of the device. This also fixes issues where the promiscuous behavior setting was not

[net-next 06/19] ixgbe: Add support for VXLAN RX offloads

2015-09-01 Thread Jeff Kirsher
From: Mark Rustad Add support for VXLAN RX offloads for the X55x devices that support them. Signed-off-by: Mark Rustad Tested-by: Phil Schmitt Signed-off-by: Jeff Kirsher ---

RE: [Intel-wired-lan] [PATCH v2] fm10k: Report MAC address on driver load

2015-09-01 Thread Singh, Krishneil K
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Alexander Duyck Sent: Thursday, June 18, 2015 7:41 PM To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T Subject:

RE: [Intel-wired-lan] [PATCH 1/1] ixgbe: use kzalloc for allocating one thing

2015-09-01 Thread Singh, Krishneil K
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Maninder Singh Sent: Thursday, June 18, 2015 9:08 PM To: Kirsher, Jeffrey T ; Brandeburg, Jesse ; Nelson, Shannon

Re: [PATCH net-next] flow_dissector: Fix function argument ordering dependency

2015-09-01 Thread David Miller
From: Tom Herbert Date: Tue, 1 Sep 2015 18:11:04 -0700 > Commit c6cc1ca7f4d70c ("flowi: Abstract out functions to get flow hash > based on flowi") introduced a bug in __skb_set_sw_hash where we > require a dependency on evaluating arguments in a function in order. > There

Re: [PATCH] net/bonding: send arp in interval if no active slave

2015-09-01 Thread Uwe Koziolek
On Tue, Sep 01, 2015 at 05:41 PM +0200, Andy Gospodarek wrote: On Mon, Aug 17, 2015 at 10:51:27PM +0200, Uwe Koziolek wrote: On Mon, Aug 17, 2015 at 09:14PM +0200, Jay Vosburgh wrote: Uwe Koziolek wrote: On2015-08-17 07:12 PM,Jarod Wilson wrote: On 2015-08-17

Re: [net-next:master 1557/1566] :undefined reference to `__get_hash_from_flowi6'

2015-09-01 Thread David Miller
From: kbuild test robot Date: Wed, 2 Sep 2015 07:50:55 +0800 > tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > master > head: 41ecc3d390266acc1aa911d2ec477928a5248f75 > commit: c6cc1ca7f4d70cbb3ea3a5ca163c5dabaf155cdb [1557/1566] flowi:

Re: parsing ethtool output in programs/scripts

2015-09-01 Thread Stephen Hemminger
On Wed, 2 Sep 2015 02:22:18 +0200 Robert Urban wrote: > Hello, > > I wish you would consider adding a switch to ethtool (and the corresponding > functionality) to produce output in machine-readable format. > > This would be *extremely* useful. > > Why not add the

[PATCH net-next] flow_dissector: Fix function argument ordering dependency

2015-09-01 Thread Tom Herbert
Commit c6cc1ca7f4d70c ("flowi: Abstract out functions to get flow hash based on flowi") introduced a bug in __skb_set_sw_hash where we require a dependency on evaluating arguments in a function in order. There is no such ordering enforced in C, so this incorrect. This patch fixes that by splitting

Re: [PATCH net-next] flow_dissector: Fix function argument ordering dependency

2015-09-01 Thread Joe Perches
On Tue, 2015-09-01 at 18:11 -0700, Tom Herbert wrote: > Commit c6cc1ca7f4d70c ("flowi: Abstract out functions to get flow hash > based on flowi") introduced a bug in __skb_set_sw_hash where we > require a dependency on evaluating arguments in a function in order. > There is no such ordering

Re: [PATCH net-next v3] net: Make table id type u32

2015-09-01 Thread Nikolay Aleksandrov
> On Sep 1, 2015, at 1:26 PM, David Ahern wrote: > > A number of VRF patches used 'int' for table id. It should be u32 to be > consistent with the rest of the stack. > > Fixes: > 4e3c89920cd3a ("net: Introduce VRF related flags and helpers") > 15be405eb2ea9 ("net: Add

Re: [PATCH net] vxlan: re-ignore EADDRINUSE from igmp_join

2015-09-01 Thread John Nielsen
On Aug 25, 2015, at 5:22 PM, Marcelo Ricardo Leitner wrote: > Before 56ef9c909b40[1] it used to ignore all errors from igmp_join(). > That commit enhanced that and made it error out whatever error happened > with igmp_join(), but that's not good because when using

Re: [PATCH net 3/3] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-01 Thread Eric Dumazet
On Tue, 2015-09-01 at 15:25 -0700, Martin KaFai Lau wrote: > On Tue, Sep 01, 2015 at 02:26:58PM -0700, Eric Dumazet wrote: > > On Tue, 2015-09-01 at 13:55 -0700, Martin KaFai Lau wrote: > > > On Tue, Sep 01, 2015 at 01:14:20PM -0700, Eric Dumazet wrote: > > > > It should not be a problem. refcnt

[PATCH net-next v3] net: Make table id type u32

2015-09-01 Thread David Ahern
A number of VRF patches used 'int' for table id. It should be u32 to be consistent with the rest of the stack. Fixes: 4e3c89920cd3a ("net: Introduce VRF related flags and helpers") 15be405eb2ea9 ("net: Add inet_addr lookup by table") 30bbaa1950055 ("net: Fix up inet_addr_type checks")

Prioritize a vlan on another

2015-09-01 Thread footplus
Hello, I'm not sure if this is the right place to ask this, but i'm stuck on a trafic priority problem since some time. I have 2 10Gb interfaces (bnx2x) bonded in a 802.3ad aggregate. On this aggregate, 2 vlans are configured (let's INT and EXT) I need to ensure that, when sending traffic at

Re: [PATCH net 3/3] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-01 Thread Eric Dumazet
On Tue, 2015-09-01 at 13:55 -0700, Martin KaFai Lau wrote: > On Tue, Sep 01, 2015 at 01:14:20PM -0700, Eric Dumazet wrote: > > It should not be a problem. refcnt is taken when/if necessary (skb > > queued on a qdisc for example) > > > > We have other uses of skb_dst_set_noref() > > > > Please

Re: [PATCH net 3/3] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-01 Thread Martin KaFai Lau
On Tue, Sep 01, 2015 at 02:26:58PM -0700, Eric Dumazet wrote: > On Tue, 2015-09-01 at 13:55 -0700, Martin KaFai Lau wrote: > > On Tue, Sep 01, 2015 at 01:14:20PM -0700, Eric Dumazet wrote: > > > It should not be a problem. refcnt is taken when/if necessary (skb > > > queued on a qdisc for example)

Re: [PATCH net] sctp: support global vtag assochash and per endpoint s(d)port assochash table

2015-09-01 Thread lucien xin
> > In addition to what David said and looking at it from a different angle... > 256 buckets > may not be enough for someone with a single endpoint and alot of > associations. You > will still hit a long chain on INIT and COOKIE-ECHO chunks. > > Switching to using rhashtable for association

Re: [PATCH net-next v3] net: Make table id type u32

2015-09-01 Thread David Miller
From: David Ahern Date: Tue, 1 Sep 2015 14:26:35 -0600 > A number of VRF patches used 'int' for table id. It should be u32 to be > consistent with the rest of the stack. > > Fixes: > 4e3c89920cd3a ("net: Introduce VRF related flags and helpers") > 15be405eb2ea9 ("net:

Re: [PATCH] tg3: Fix temperature reporting

2015-09-01 Thread David Miller
From: Jean Delvare Date: Tue, 1 Sep 2015 18:07:41 +0200 > The temperature registers appear to report values in degrees Celsius > while the hwmon API mandates values to be exposed in millidegrees > Celsius. Do the conversion so that the values reported by "sensors" > are

Re: [PATCH net] sctp: support global vtag assochash and per endpoint s(d)port assochash table

2015-09-01 Thread lucien xin
On Tue, Sep 1, 2015 at 6:16 AM, David Miller wrote: > From: Xin Long > Date: Tue, 1 Sep 2015 01:44:28 +0800 > >> @@ -524,18 +524,16 @@ static inline int sctp_assoc_hashfn(struct net *net, >> __u16 lport, __u16 rport) >> { >> int h = (lport <<

Re: [PATCH net] skbuff: Fix skb checksum flag on skb pull

2015-09-01 Thread Pravin Shelar
On Tue, Sep 1, 2015 at 12:55 PM, Tom Herbert wrote: > On Tue, Sep 1, 2015 at 12:20 PM, Pravin Shelar wrote: >> On Tue, Sep 1, 2015 at 7:19 AM, Tom Herbert wrote: >>> On Mon, Aug 31, 2015 at 10:15 PM, Pravin Shelar

Re: [PATCH net 3/3] ipv6: Fix dst_entry refcnt bugs in ip6_tunnel

2015-09-01 Thread Eric Dumazet
On Tue, 2015-09-01 at 11:55 -0700, Martin KaFai Lau wrote: > Problems in the current dst_entry cache in the ip6_tunnel: > > 1. ip6_tnl_dst_set is racy. There is no lock to protect it: >- One major problem is that the dst refcnt gets messed up. F.e. > the same dst_cache can be released

Re: [PATCH] phylib: fix device deletion order in mdiobus_unregister()

2015-09-01 Thread David Miller
From: Mark Salter Date: Tue, 1 Sep 2015 09:36:05 -0400 > commit 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not > the bus' parent.") uncovered a problem in mdiobus_unregister() which > leads to this warning when I reboot an APM Mustang (arm64) platform: ...

Re: [PATCH net-next 00/11] flow_dissector: Paramterize dissection and other features

2015-09-01 Thread David Miller
From: Tom Herbert Date: Tue, 1 Sep 2015 09:24:22 -0700 > This patch set adds some new capabilities to flow_dissector: > > - Add flags to flow dissector functions to control dissection > - Flag to stop dissection when L3 header is seen (don't > dissect L4) > - Flag

Re: [PATCH 1/2] airo: fix IW_AUTH_ALG_OPEN_SYSTEM

2015-09-01 Thread Ondrej Zary
On Tuesday 01 September 2015 02:04:43 Dan Williams wrote: > On Tue, 2015-09-01 at 00:12 +0200, Ondrej Zary wrote: > > On Monday 31 August 2015 22:44:54 Dan Williams wrote: > > > On Mon, 2015-08-31 at 21:19 +0200, Ondrej Zary wrote: > > > > Handle IW_AUTH_ALG_OPEN_SYSTEM in set_auth. > > > > This

Re: kernel warning in tcp_fragment

2015-09-01 Thread Grant Zhang
Hi Martin, I did try out your v2 patch on our production server and can confirm that the patch gets rid of the WARN_ON trace. I would really like to see the issue been fixed by upstream(and backported to kernel longterm tree 3.14)--either by this patch or something else. Is there a plan for

  1   2   >