Re: [PATCH net] af_unix: return data from multiple SKBs on recv() with MSG_PEEK flag

Sergei Shtylyov writes: > Hello. > ... >Your patch doesn't comply to the Linux CodingStyle. > ... I'll fix and post v2 - apologies for messing up with that check. -Aaron -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [patch net-next RFC 3/6] rocker: switch to local transaction phase enum

Hi Jiri, On Sep. Saturday 19 (38) 02:29 PM, Jiri Pirko wrote: > Since switchdev_trans_ph anum is going to be removed, and rocker code is > way too complicated in this matter to be converted, just introduce local > enum for transaction phase. Pass it around in local transaction > structure. I

Re: PATCH: netdev: add a cast NLMSG_OK to avoid a GCC warning in users' code

Fixes have been proposed for this problem at least twice before. (These messages are not presented as a thread so I've put links to each of them) Problem report: Patch proposal: Reply suggesting

Re: [PATCH net-next 7/7] switchdev: update documentation on FDB ageing_time

On Sat, Sep 19, 2015 at 6:21 PM, roopa wrote: > On 9/18/15, 12:55 PM, sfel...@gmail.com wrote: >> >> From: Scott Feldman >> >> Signed-off-by: Scott Feldman >> --- >> Documentation/networking/switchdev.txt | 24

[PATCH 03/15] RDS: fix rds_sock reference bug while doing bind

One need to take rds socket reference while using it and release it once done with it. rds_add_bind() code path does not do that so lets fix it. Signed-off-by: Santosh Shilimkar Signed-off-by: Santosh Shilimkar --- net/rds/bind.c | 16

Re: [PATCH net-next 7/7] switchdev: update documentation on FDB ageing_time

On 9/18/15, 12:55 PM, sfel...@gmail.com wrote: From: Scott Feldman Signed-off-by: Scott Feldman --- Documentation/networking/switchdev.txt | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [PATCH 0/7] Phy and mdiobus fixes

Le 09/18/15 02:46, Russell King - ARM Linux a écrit : > Hi, > > While looking at the phy code, I identified a number of weaknesses > where refcounting on device structures was being leaked, where > modules could be removed while in-use, and where the fixed-phy could > end up having unintended

[PATCH 13/15] RDS: mark rds_ib_fmr_wq static

Fix below warning by marking rds_ib_fmr_wq static net/rds/ib_rdma.c:87:25: warning: symbol 'rds_ib_fmr_wq' was not declared. Should it be static? Signed-off-by: Santosh Shilimkar Signed-off-by: Santosh Shilimkar --- net/rds/ib_rdma.c | 2 +-

[PATCH 08/15] RDS: ack more receive completions to improve performance

For better performance, we split the receive completion IRQ handler. That lets us acknowledge several WCE events in one call. We also limit the WC to max 32 to avoid latency. Acknowledging several completions in one call instead of several calls each time will provide better performance since less

[PATCH 11/15] RDS: fix the rds_ib_fmr_wq kick call

RDS IB mr pool has its own workqueue 'rds_ib_fmr_wq', so we need to use queue_delayed_work() to kick the work. This was hurting the performance since pool maintenance was less often triggered from other path. Signed-off-by: Santosh Shilimkar Signed-off-by: Santosh Shilimkar

[PATCH 00/15] RDS: connection scalability and performance improvements

This series addresses RDS connection bottlenecks on massive workloads and improve the RDMA performance almost by 3X. RDS TCP also gets a small gain of about 12%. RDS is being used in massive systems with high scalability where several hundred thousand end points and tens of thousands of local

[PATCH 10/15] RDS: handle rds_ibdev release case instead of crashing the kernel

From: Santosh Shilimkar Just in case we are still handling the QP receive completion while the rds_ibdev is released, drop the connection instead of crashing the kernel. Signed-off-by: Santosh Shilimkar --- net/rds/ib_cm.c | 3 ++- 1 file changed, 2

[PATCH 01/15] RDS: use kfree_rcu in rds_ib_remove_ipaddr

synchronize_rcu() slowing down un-necessarily the socket shutdown path. It is used just kfree() the ip addresses in rds_ib_remove_ipaddr() which is perfect usecase for kfree_rcu(); So lets use that to gain some speedup. Signed-off-by: Santosh Shilimkar Signed-off-by:

[PATCH 12/15] RDS: use already available pool handle from ibmr

rds_ib_mr already keeps the pool handle which it associates with. Lets use that instead of round about way of fetching it from rds_ib_device. No functional change. Signed-off-by: Santosh Shilimkar Signed-off-by: Santosh Shilimkar ---

Re: [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

Hi Jiri, On Sep. Saturday 19 (38) 06:23 PM, Jiri Pirko wrote: > Sat, Sep 19, 2015 at 03:35:51PM CEST, rami.ro...@intel.com wrote: > >Hi, > > > >>introduce tranction enfra and for pre-commit split > > > >Typo: > >Instead "tranction enfra" should be "transaction infrastructure". > > Will fix.

Re: rfi: stmmac: creating an of mdio bus for attached dsa

+Andrew, Le 09/18/15 00:26, Phil Reid a écrit : > G'day All, > > Prior to submitting a patch I'd just like to get an idea on what the > correct way is to create and register an mdio bus for use by the marvell > dsa driver. > On our system the cpu ethernet port is connected directly to a switch >

[PATCH 15/15] RDS: split mr pool to improve 8K messages performance

8K message sizes are pretty important usecase for RDS current workloads so we make provison to have 8K mrs available from the pool. Based on number of SG's in the RDS message, we pick a pool to use. Also to make sure that we don't under utlise mrs when say 8k messages are dominating which could

[PATCH 05/15] RDS: increase size of hash-table to 8K

Even with per bucket locking scheme, in a massive parallel system with active rds sockets which could be in excess of multiple of 10K, rds_bin_lookup() workload is siginificant because of smaller hashtable size. With some tests, it was found that we get modest but still nice reduction in

[PATCH 06/15] RDS: defer the over_batch work to send worker

Current process gives up if its send work over the batch limit. The work queue will get kicked to finish off any other requests. This fixes remainder condition from commit 443be0e5affe ("RDS: make sure not to loop forever inside rds_send_xmit"). The restart condition is only for the case where

[PATCH 04/15] RDS: Use per-bucket rw lock for bind hash-table

One global lock protecting hash-tables with 1024 buckets isn't efficient and it shows up in a massive systems with truck loads of RDS sockets serving multiple databases. The perf data clearly highlights the contention on the rw lock in these massive workloads. When the contention gets worse, the

[PATCH 02/15] RDS: make socket bind/release locking scheme simple and more efficient

RDS bind and release locking scheme is very inefficient. It uses RCU for maintaining the bind hash-table which is great but it also needs to hold spinlock for [add/remove]_bound(). So overall usecase, the hash-table concurrent speedup doesn't pay off. In fact blocking nature of synchronize_rcu()

[PATCH 14/15] RDS: use max_mr from HCA caps than max_fmr

From: Santosh Shilimkar All HCA drivers seems to popullate max_mr caps and few of them do both max_mr and max_fmr. Hence update RDS code to make use of max_mr. Signed-off-by: Santosh Shilimkar Signed-off-by: Santosh Shilimkar

[PATCH 09/15] RDS: split send completion handling and do batch ack

Similar to what we did with receive CQ completion handling, we split the transmit completion handler so that it lets us implement batched work completion handling. We re-use the cq_poll routine and makes use of RDS_IB_SEND_OP to identify the send vs receive completion event handler invocation.

[PATCH 07/15] RDS: use rds_send_xmit() state instead of RDS_LL_SEND_FULL

In Transport indepedent rds_sendmsg(), we shouldn't make decisions based on RDS_LL_SEND_FULL which is used to manage the ring for RDMA based transports. We can safely issue rds_send_xmit() and the using its return value take decision on deferred work. This will also fix the scenario where at times

sr-iov and bridges (mlx4)

Hello. I have a Mellanox ConnectX-3 Pro EN (MCX314A-BCCT). I'm only using a single port so it must provide IP for my host as well as connectivity for VMs. SR-IOV VFs are working great, my KVM VMs have Ethernet and RDMA. However, I also want to support virtio VMs. Assuming eth0 is the first port

197b:0250 JMicron JMC250 Gigabit ethernet doesn't work

[1.] One line summary of the problem: 197b:0250 JMicron JMC250 Gigabit ethernet doesn't work [2.] Full description of the problem/report: Laptop ASUS X52JU can't connect to the router ASUS RT-AC68U via ethernet. NetworkManager shows that cable is unplugged. Router has Gigabit ethernet ports and

Re: [PATCH net-next 1/7] rocker: track when FDB entry is touched.

Fri, Sep 18, 2015 at 09:55:45PM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >The entry is touched once when created, and touched again for each update. >The touched time is used to calculate FDB entry age. > >Signed-off-by: Scott Feldman Acked-by:

Re: [PATCH net-next 3/7] rocker: adding port ageing_time for ageing out FDB entries

Fri, Sep 18, 2015 at 09:55:47PM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Follow-up patcheset will allow user to change ageing_time, but for now >just hard-code it to a fixed value (the same value used as the default >for the bridge driver). > >Signed-off-by: Scott

Re: [PATCH net-next 2/7] rocker: store rocker_port in fdb key rather than pport

Fri, Sep 18, 2015 at 09:55:46PM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >We'll need more info from rocker_port than just pport when we age out fdb >entries, so store rocker_port rather than pport in each fdb entry. > >Signed-off-by: Scott Feldman

Re: [PATCH net-next 4/7] bridge: define some min/max ageing time constants we'll use next

Fri, Sep 18, 2015 at 09:55:48PM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Signed-off-by: Scott Feldman >--- > include/linux/if_bridge.h |4 > 1 file changed, 4 insertions(+) > >diff --git a/include/linux/if_bridge.h

Re: [PATCH net-next 7/7] switchdev: update documentation on FDB ageing_time

Fri, Sep 18, 2015 at 09:55:51PM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Signed-off-by: Scott Feldman Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH net-next 6/7] bridge: don't age externally added FDB entries

Fri, Sep 18, 2015 at 09:55:50PM CEST, sfel...@gmail.com wrote: >From: Siva Mannem > >Signed-off-by: Siva Mannem >Signed-off-by: Scott Feldman Acked-by: Jiri Pirko -- To unsubscribe from this list: send

Re: [PATCH net-next 5/7] rocker: add FDB cleanup timer

Fri, Sep 18, 2015 at 09:55:49PM CEST, sfel...@gmail.com wrote: >From: Scott Feldman > >Add a timer to each rocker switch to do FDB entry cleanup by ageing out >expired entries. The timer scheduling algo is copied from the bridge >driver, for the most part, to keep the firing

Re: [PATCH] Revert "net/phy: Add Vitesse 8641 phy ID"

On Fri, Sep 18, 2015 at 09:36:42AM +, Shaohui Xie wrote: > > -Original Message- > > From: Kevin Hao [mailto:haoke...@gmail.com] > > Sent: Friday, September 18, 2015 3:43 PM > > To: netdev@vger.kernel.org > > Cc: Florian Fainelli; Xie Shaohui-B21989 > > Subject: [PATCH] Revert "net/phy:

Re: [PATCH net-next] tcp: Fix CWV being too strict on thin streams

On Fri, Sep 18, 2015 at 7:38 PM, Bendik Rønning Opstad wrote: > > Application limited streams such as thin streams, that transmit small > amounts of payload in relatively few packets per RTT, are prevented from > growing the CWND after experiencing loss. This leads to

[patch net-next RFC 4/6] switchdev: move transaction phase enum under transaction structure

Before it disappears completely, move transaction phase enum under transaction structure and make attr/obj structures a bit cleaner. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker.c | 4 ++-- include/net/switchdev.h | 3 +-- net/dsa/slave.c

[patch net-next RFC 1/6] switchdev: rename "trans" to "trans_ph".

This is temporary, name "trans" will be used for something else and "trans_ph" will eventually disappear. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker.c | 382 +-- include/net/switchdev.h | 6 +-

[patch net-next RFC 5/6] rocker: use switchdev transaction queue for allocated memory

Benefit from previously introduced infra and remove rocker specific transaction memory management. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker.c | 64 1 file changed, 13 insertions(+), 51 deletions(-) diff --git

[patch net-next RFC 3/6] rocker: switch to local transaction phase enum

Since switchdev_trans_ph anum is going to be removed, and rocker code is way too complicated in this matter to be converted, just introduce local enum for transaction phase. Pass it around in local transaction structure. Signed-off-by: Jiri Pirko ---

[patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

Jiri Pirko (6): switchdev: rename "trans" to "trans_ph". switchdev: introduce transaction infrastructure for attr_set and obj_add rocker: switch to local transaction phase enum switchdev: move transaction phase enum under transaction structure rocker: use switchdev transaction queue

[patch net-next RFC 2/6] switchdev: introduce transaction infrastructure for attr_set and obj_add

Now, the memory allocation in prepare/commit state is done separatelly in each driver (rocker). Introduce the similar mechanism in generic switchdev code, in form of queue. That can be used not only for memory allocations, but also for different items. Commit/abort item destruction is handled as

[patch net-next RFC 6/6] switchdev: split commit and prepare phase into two callbacks

It is nore convenient to have prepare and commit phase for attr_set and obj_add as separete callbacks. If a driver needs to do it differently, it can easily do in inside its code. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker.c | 88

Re: epoll, missed opportunity?

On Fri, 2015-09-18 at 22:51 -0600, Jonathan Marler wrote: > I'm curious why there wasn't another field added to the epoll_event > struct for the application to store the descriptor's context. Any > useful multi-plexing application will have a context that will need to > be retrieved every time a

Re: epoll, missed opportunity?

The data field holds the file descriptor you are waiting on, it has to be the file descriptor, otherwise, how would the kernel know which file descriptor you are trying to wait on? On Sat, Sep 19, 2015 at 9:21 AM, Eric Dumazet wrote: > On Fri, 2015-09-18 at 22:51 -0600,

RE: [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

Hi, >introduce tranction enfra and for pre-commit split Typo: Instead "tranction enfra" should be "transaction infrastructure". Regards, Rami Rosen Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More

Re: [linux-next] oops in ip_route_input_noref

On 9/18/15 5:06 PM, Andrew Morton wrote: I've been hitting this as well. An oops on boot in ip_route_input_slow(), here: Fixed in net-next. bde6f9ded1bd37ff27a042dcb968e104d92b02c1 David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH net-next 3/7] rocker: adding port ageing_time for ageing out FDB entries

On Fri, Sep 18, 2015 at 11:30 PM, Jiri Pirko wrote: > Fri, Sep 18, 2015 at 09:55:47PM CEST, sfel...@gmail.com wrote: >>From: Scott Feldman >> >>Follow-up patcheset will allow user to change ageing_time, but for now >>just hard-code it to a fixed value (the

Re: [PATCH net] af_unix: return data from multiple SKBs on recv() with MSG_PEEK flag

Hello. On 9/18/2015 7:04 PM, Aaron Conole wrote: AF_UNIX sockets now return multiple skbs from recv() when MSG_PEEK flag is set. This is referenced in kernel bugzilla #12323 @ https://bugzilla.kernel.org/show_bug.cgi?id=12323 As described both in the BZ and lkml thread @

Re: [PATCH net-next 4/7] bridge: define some min/max ageing time constants we'll use next

On Fri, Sep 18, 2015 at 11:45 PM, Jiri Pirko wrote: > Fri, Sep 18, 2015 at 09:55:48PM CEST, sfel...@gmail.com wrote: >>From: Scott Feldman >> >>Signed-off-by: Scott Feldman >>--- >> include/linux/if_bridge.h |4 >> 1 file changed,

Apply Loan!

ALLIANCE & LEICESTER LOANS Do you need a loan? Arrangements to borrow up to £ 100,000,000.00, choose between 1 to 25 years repayment period, choose between monthly and annual repayment plan, flexible loan terms and conditions. All this plan and more by contacting us Dr. Richard Jose Head of

Re: [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

On Sat, Sep 19, 2015 at 5:29 AM, Jiri Pirko wrote: > Jiri Pirko (6): > switchdev: rename "trans" to "trans_ph". > switchdev: introduce transaction infrastructure for attr_set and > obj_add > rocker: switch to local transaction phase enum > switchdev: move transaction

Re: epoll, missed opportunity?

Wow how did I miss that?! This is perfect though, there is a context pointer! Finally my dream of a perfect polling interface exists in linux. Thanks so much for the quick response. On Sat, Sep 19, 2015 at 9:46 AM, Tom Herbert wrote: > On Sat, Sep 19, 2015 at 8:30 AM,

[PATCH net] tcp/dccp: fix timewait races in timer handling

From: Eric Dumazet When creating a timewait socket, we need to arm the timer before allowing other cpus to find it. The signal allowing cpus to find the socket is setting tw_refcnt to non zero value. As we set tw_refcnt in __inet_twsk_hashdance(), we therefore need to call

Re: [patch net-next RFC 0/6] switchdev: introduce tranction enfra and for pre-commit split

Sat, Sep 19, 2015 at 03:35:51PM CEST, rami.ro...@intel.com wrote: >Hi, > >>introduce tranction enfra and for pre-commit split > >Typo: >Instead "tranction enfra" should be "transaction infrastructure". Will fix. Thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: epoll, missed opportunity?

On Sat, Sep 19, 2015 at 8:30 AM, Jonathan Marler wrote: > The data field holds the file descriptor you are waiting on, it has to > be the file descriptor, otherwise, how would the kernel know which > file descriptor you are trying to wait on? > fd is the third argument in

DO YOU NEED A LOAN AT 3% RATE ANNUALLY.

DO YOU NEED A LOAN AT 3% RATE ANNUALLY,IF YES CONTACT US FOR MORE INFO -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH net] inet: fix races in reqsk_queue_hash_req()

From: Eric Dumazet Before allowing lockless LISTEN processing, we need to make sure to arm the SYN_RECV timer before the req socket is visible in hash tables. Also, req->rsk_hash should be written before we set rsk_refcnt to a non zero value. Fixes: fa76ce7328b2 ("inet: