[PATCH v2 17/19] tools: bpf_jit_disasm: make get_last_jit_image return unsigned

2015-09-24 Thread Andrzej Hajda
The function returns always non-negative values. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- v2: fixed indentation --- tools

[PATCH iproute2 v2] ip: allow using a device "help" (or a prefix thereof)

2015-09-24 Thread Christoph Schulz
Device names that match "help" or a prefix thereof should be allowed anywhere a device name can be used. Note that a suitable keyword ("dev" or "name", the latter for "ip tunnel") has to be used in these cases to resolve ambiguities. Signed-off-by: Christoph Schulz Reported-by: Leonhard Preis Re

[PATCH v2 18/19] mac80211: make ieee80211_new_mesh_header return unsigned

2015-09-24 Thread Andrzej Hajda
The function returns always non-negative values. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- v2: added missing declaration ch

[PATCH v2] net: Fix Hisilicon Network Subsystem Support Compilation

2015-09-24 Thread huangdaode
This patch fixes the compilation error with arm allmodconfig, this error generated due to unavailability of readq() on 32-bit platform which was found during net-next daily compilation. In the same time, fix all the hns drivers compilation warnings. Signed-off-by: huangdaode Signed-off-by: zhaung

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread David Miller
From: Florian Fainelli Date: Thu, 24 Sep 2015 18:39:56 -0700 > On 24/09/15 12:17, Russell King - ARM Linux wrote: >> Hi, >> >> The third version of this series fixes the build error which David >> identified, and drops the broken changes for the Cavium Thunger BGX >> ethernet driver as this driv

Re: [patch net-next v3 00/10] switchdev: transaction item queue and cleanup

2015-09-24 Thread Jiri Pirko
Fri, Sep 25, 2015 at 08:00:13AM CEST, da...@davemloft.net wrote: >From: Scott Feldman >Date: Thu, 24 Sep 2015 20:05:39 -0700 > >> On Thu, Sep 24, 2015 at 1:02 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Jiri Pirko (10): >>> switchdev: rename "trans" to "trans_ph". >>> switchdev: intro

Re: [Linux 4.2-rc8+...v4.3-rc2] REGRESSION: ppp: circular locking dependency detected: [pppd] ppp_dev_uninit() | rtnl_lock()

2015-09-24 Thread Sedat Dilek
On Thu, Sep 24, 2015 at 8:00 PM, David Miller wrote: > From: Sedat Dilek > Date: Thu, 24 Sep 2015 18:19:16 +0200 > >> OK, I guess DaveM will take your patch into net.git#master first... >> and tag it there with CC-stable? > > I do not tag anything with stable. > > I queue it up into a patchwork b

RE: [RFC v2 net-next 05/10] qede: Add basic network device support

2015-09-24 Thread Yuval Mintz
> >> > +struct qede_rx_queue { > >> > +__le16 *hw_cons_ptr; > >> > >> The __ variants of constants should be reserved for use in user > >> visible API's > > > > Really? If so, this needs to be fixed not only here but in lots of > > places in the series [e.g., entire HW HSI

Re: [PATCH v7 02/10] ss: created formatters for json and hr

2015-09-24 Thread Matthias Tafelmeier
-BEGIN PGP SIGNED MESSAGE- Hash: SHA384 On 09/25/2015 12:16 AM, Stephen Hemminger wrote: > On Thu, 24 Sep 2015 17:43:46 + Matthias Tafelmeier > wrote: > >>> Maybe it is time to rewrite it in a better language ;-) >> >> I did not get that. Do you mean iproute2? > > I meant that the

Re: [patch net-next v3 00/10] switchdev: transaction item queue and cleanup

2015-09-24 Thread David Miller
From: Scott Feldman Date: Thu, 24 Sep 2015 20:05:39 -0700 > On Thu, Sep 24, 2015 at 1:02 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Jiri Pirko (10): >> switchdev: rename "trans" to "trans_ph". >> switchdev: introduce transaction item queue for attr_set and obj_add >> switchdev: move

Re: [RFC v2 net-next 05/10] qede: Add basic network device support

2015-09-24 Thread David Miller
From: Yuval Mintz Date: Fri, 25 Sep 2015 05:43:06 + >> > +struct qede_rx_queue { >> > + __le16 *hw_cons_ptr; >> >> The __ variants of constants should be reserved for use in user visible API's > > Really? If so, this needs to be fixed not only here but in lots of places >

Re: [patch net-next v3 02/10] switchdev: introduce transaction item queue for attr_set and obj_add

2015-09-24 Thread David Miller
From: Scott Feldman Date: Thu, 24 Sep 2015 22:29:43 -0700 > I'd rather keep 2-phase not optional, or at least make it some what of > a pain for drivers to opt-out of 2-phase. Forcing the driver to see > both phases means the driver needs to put some code to skip phase 1 > (and hopefully has some

Re: [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool

2015-09-24 Thread David Miller
From: Ivan Mikhaylov Date: Fri, 25 Sep 2015 08:07:52 +0400 > Ben proposed one, is it eligible? > Need I resubmit patch with sign and detailed description? If I genuinely need to answer that question, maybe you should sit back for a little while and think about it yourself, ok? -- To unsubscribe

Re: [PATCH net-next 1/4] switchdev: add bridge attributes

2015-09-24 Thread David Miller
From: Premkumar Jonnala Date: Fri, 25 Sep 2015 04:32:16 + > Acked-by: Premkumar Jonnala This is not the correct way to ACK a patch. First of all, you should provide your full email address after your name in the Acked-by:, as I do, like this: "Acked-by: David S. Miller " Second of all, ne

Re:Hallo

2015-09-24 Thread fcaveylel
Hallo Gute Nachrichten für Sie dj, Motorrad, gultar, Laptop, Kamera, TV ... Versand ist kostenlos iphone 6plus,280euro si te: poazzlo. com

RE: [RFC v2 net-next 05/10] qede: Add basic network device support

2015-09-24 Thread Yuval Mintz
> > > +#define QEDE_NAPI_WEIGHT (NAPI_POLL_WEIGHT) > > Why not just use existing constant rather than walpapering? No reason; We'll remove it. > > > +#define U64_LO(x)((u32)(((u64)(x)) & 0x)) > > > +#define U64_HI(x)((u32)(((u64)(x)) >> 32))

Re: Glibc recvmsg from kernel netlink socket hangs forever

2015-09-24 Thread Guenter Roeck
Herbert, On 09/24/2015 09:58 PM, Herbert Xu wrote: On Thu, Sep 24, 2015 at 09:36:53PM -0700, Guenter Roeck wrote: http://comments.gmane.org/gmane.linux.network/363085 might explain your problem. I thought this was resolved in 4.1, but it looks like the problem still persists there. At least

Re: [patch net-next v3 02/10] switchdev: introduce transaction item queue for attr_set and obj_add

2015-09-24 Thread Scott Feldman
On Thu, Sep 24, 2015 at 9:36 PM, Vivien Didelot wrote: > Hi Jiri, > > On Sep. Thursday 24 (39) 10:02 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Now, the memory allocation in prepare/commit state is done separatelly >> in each driver (rocker). Introduce the similar mechanism in generic >> swi

Re: [PATCH] ethtool: add new emac_regs struct from driver, add new chip types.

2015-09-24 Thread Ivan Mikhaylov
* add new version of emac_regs struct from driver structure perspective and passing size from actual struct size, not from memory area variable which set in dts file. * add three types of network chips for new struct : emac, emac4, emac4sync. * add emac4sync processing in print_emac_regs. * thi

Re: [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool

2015-09-24 Thread Ivan Mikhaylov
On Wed, 23 Sep 2015 11:05:49 -0700 (PDT) "David Miller" wrote: > From: Ivan Mikhaylov > Date: Wed, 23 Sep 2015 14:42:22 +0400 > > > Register dump out work preventing with > > old ethtool + new driver and new ethtool + old driver. > > First of all you didn't provide a proper Signoff. > > Seco

Re: Glibc recvmsg from kernel netlink socket hangs forever

2015-09-24 Thread Herbert Xu
On Thu, Sep 24, 2015 at 09:36:53PM -0700, Guenter Roeck wrote: > > http://comments.gmane.org/gmane.linux.network/363085 > > might explain your problem. > > I thought this was resolved in 4.1, but it looks like the problem still > persists > there. At least I have reports from my workplace that 4

Re: [patch net-next v3 02/10] switchdev: introduce transaction item queue for attr_set and obj_add

2015-09-24 Thread Vivien Didelot
Hi Jiri, On Sep. Thursday 24 (39) 10:02 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Now, the memory allocation in prepare/commit state is done separatelly > in each driver (rocker). Introduce the similar mechanism in generic > switchdev code, in form of queue. That can be used not only for memo

RE: [PATCH net-next 2/4] switchdev: skip over ports returning -EOPNOTSUPP when recursing ports

2015-09-24 Thread Premkumar Jonnala
Acked-by: Premkumar Jonnala > -Original Message- > From: sfel...@gmail.com [mailto:sfel...@gmail.com] > Sent: Friday, September 25, 2015 2:29 AM > To: netdev@vger.kernel.org > Cc: j...@resnulli.us; siva.mannem@gmail.com; Premkumar Jonnala; > step...@networkplumber.org; ro...@cumulusnet

RE: [PATCH net-next 1/4] switchdev: add bridge attributes

2015-09-24 Thread Premkumar Jonnala
Acked-by: Premkumar Jonnala > -Original Message- > From: sfel...@gmail.com [mailto:sfel...@gmail.com] > Sent: Friday, September 25, 2015 2:29 AM > To: netdev@vger.kernel.org > Cc: j...@resnulli.us; siva.mannem@gmail.com; Premkumar Jonnala; > step...@networkplumber.org; ro...@cumulusnet

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-24 Thread Scott Feldman
On Thu, Sep 24, 2015 at 6:23 PM, Florian Fainelli wrote: > On 24/09/15 13:59, sfel...@gmail.com wrote: >> From: Scott Feldman >> >> Push bridge-level attributes down to switchdev drivers. This patchset >> adds the infrastructure and then pushes, as an example, ageing_time attribute >> down from

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-24 Thread Stephen Hemminger
On Thu, 24 Sep 2015 20:25:01 -0700 Scott Feldman wrote: > On Thu, Sep 24, 2015 at 2:05 PM, Stephen Hemminger > wrote: > > On Thu, 24 Sep 2015 13:59:26 -0700 > > sfel...@gmail.com wrote: > > > >> From: Scott Feldman > >> > >> Push bridge-level attributes down to switchdev drivers. This patchset

Re: netlink: Add barrier to netlink_connect for theoretical case

2015-09-24 Thread Herbert Xu
On Thu, Sep 24, 2015 at 08:24:56PM -0700, Linus Torvalds wrote: > > The above looks very suspicious. You're right Linus. I've added the READ_ONCE there. The reason I kept the conditional is because the helper is always called in a context where the result is used as part of an if statement. Th

Re: [PATCH net-next] net: dsa: Set a "dsa" device_type

2015-09-24 Thread Vivien Didelot
On Sep. Thursday 24 (39) 05:28 PM, Florian Fainelli wrote: > On 24/09/15 15:37, Vivien Didelot wrote: > > Hi Florian, > > > > On Sep. Wednesday 23 (39) 06:19 PM, Florian Fainelli wrote: > >> Provide a device_type information for slave network devices created by > >> DSA, this is useful for user-sp

Re: netlink: Add barrier to netlink_connect for theoretical case

2015-09-24 Thread Linus Torvalds
On Thu, Sep 24, 2015 at 6:43 PM, Herbert Xu wrote: > On Thu, Sep 24, 2015 at 04:05:10PM -0400, Tejun Heo wrote: > > +static inline bool netlink_bound(struct netlink_sock *nlk) > +{ > + /* Ensure nlk is hashed and visible. */ > + if (nlk->bound) > + smp_rmb(); > + > +

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-24 Thread Scott Feldman
On Thu, Sep 24, 2015 at 2:05 PM, Stephen Hemminger wrote: > On Thu, 24 Sep 2015 13:59:26 -0700 > sfel...@gmail.com wrote: > >> From: Scott Feldman >> >> Push bridge-level attributes down to switchdev drivers. This patchset >> adds the infrastructure and then pushes, as an example, ageing_time at

Re: [patch net-next v3 00/10] switchdev: transaction item queue and cleanup

2015-09-24 Thread Scott Feldman
On Thu, Sep 24, 2015 at 1:02 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Jiri Pirko (10): > switchdev: rename "trans" to "trans_ph". > switchdev: introduce transaction item queue for attr_set and obj_add > switchdev: move transaction phase enum under transaction structure > switchdev: ad

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-24 Thread Andrew Lunn
> So, without a better device to hold that kind of information (in the > future it could be a global, switch-specific device holding that > information), I agree with your decision to take the bridge device to > hold that attribute, it still feels a bit uncomfortable to have > switchdev_attr_port()

[PATCH] ip: find correct route for socket which is not bound (v2)

2015-09-24 Thread Wengang Wang
This is the v2, comparing the v1, the changes is: * for loopback outbound device, it continue skipping cached route; for others, it goes through the cached route. For multicast, we should find valid route(thus get the meaniful pmtu) for the packet on the socket which is not bound to a device(s

netlink: Add barrier to netlink_connect for theoretical case

2015-09-24 Thread Herbert Xu
On Thu, Sep 24, 2015 at 04:05:10PM -0400, Tejun Heo wrote: > > > I've decided to apply this and queue it up for -stable. Thanks Dave! > This is mostly correct; however, if there are or can be in-kernel > users which create the client side of netlink socket, it isn't. Let's > say such in-kernel u

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread Florian Fainelli
On 24/09/15 12:17, Russell King - ARM Linux wrote: > Hi, > > The third version of this series fixes the build error which David > identified, and drops the broken changes for the Cavium Thunger BGX > ethernet driver as this driver requires some complex changes to > resolve the leakage - and this i

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-24 Thread Florian Fainelli
On 24/09/15 13:59, sfel...@gmail.com wrote: > From: Scott Feldman > > Push bridge-level attributes down to switchdev drivers. This patchset > adds the infrastructure and then pushes, as an example, ageing_time attribute > down from bridge to switchdev (rocker) driver. Add some range-checking >

Re: [PATCH] ip: find correct route for socket which is not bound (v2)

2015-09-24 Thread Wengang Wang
Hi David, 在 2015年09月25日 05:22, David Miller 写道: From: Wengang Wang Date: Mon, 21 Sep 2015 16:00:09 +0800 This is the v2, comparing the v1, the changes is: * for loopback outbound device, it continue skipping cached route; for others, it goes through the cached route. There are many thi

linux-next: manual merge of the net-next tree with the net tree

2015-09-24 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/ipv4/arp.c between commit: 63d008a4e9ee ("ipv4: send arp replies to the correct tunnel") from the net tree and commit: 0c4b51f0054c ("netfilter: Pass net into okfn") from the net-next tree. I fixed it up (see

Re: [PATCH net-next] net: dsa: Set a "dsa" device_type

2015-09-24 Thread Florian Fainelli
On 24/09/15 15:37, Vivien Didelot wrote: > Hi Florian, > > On Sep. Wednesday 23 (39) 06:19 PM, Florian Fainelli wrote: >> Provide a device_type information for slave network devices created by >> DSA, this is useful for user-space application to easily locate/search >> for devices of a specific ki

[PATCH net-next 10/11] net: Rename FLOWI_FLAG_VRFSRC to FLOWI_FLAG_L3MDEV_SRC

2015-09-24 Thread David Ahern
Signed-off-by: David Ahern --- drivers/net/vrf.c | 4 ++-- include/net/flow.h | 2 +- include/net/route.h | 2 +- net/ipv4/fib_trie.c | 2 +- net/ipv4/udp.c | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 388517fc6e15..f0a

[PATCH net-next 09/11] net: Move netif_index_is_l3_master to l3mdev.h

2015-09-24 Thread David Ahern
Change CONFIG dependency to CONFIG_NET_L3_MASTER_DEV as well. Signed-off-by: David Ahern --- include/linux/netdevice.h | 21 - include/net/l3mdev.h | 24 include/net/route.h | 1 + 3 files changed, 25 insertions(+), 21 deletions(-) diff -

[PATCH net-next 11/11] net: Add netif_is_l3_slave

2015-09-24 Thread David Ahern
Because IPv6 addrconf keys off of IFF_SLAVE can not use it for slave detection. Add a new private flag and add netif_is_l3_slave function for checking it. Signed-off-by: David Ahern --- drivers/net/vrf.c | 8 +++- include/linux/netdevice.h | 7 +++ net/l3mdev/l3mdev.c | 1

[PATCH net-next 05/11] net: Replace vrf_dev_table and friends

2015-09-24 Thread David Ahern
Replace calls to vrf_dev_table and friends with l3mdev_fib_table and kin. Signed-off-by: David Ahern --- include/net/vrf.h | 80 - net/ipv4/af_inet.c | 4 +-- net/ipv4/fib_frontend.c | 7 ++--- 3 files changed, 5 insertions(+), 86 dele

[PATCH net-next 01/11] net: Introduce L3 Master device abstraction

2015-09-24 Thread David Ahern
L3 master devices allow users of the abstraction to influence FIB lookups for enslaved devices. Current API provides a means for the master device to return a specific FIB table for an enslaved device, to return an rtable/custom dst and influence the OIF used for fib lookups. Signed-off-by: David

[PATCH net-next 03/11] net: Add support for l3mdev ops to VRF driver

2015-09-24 Thread David Ahern
Signed-off-by: David Ahern --- drivers/net/Kconfig | 1 + drivers/net/vrf.c | 29 + 2 files changed, 30 insertions(+) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index d18eb607bee6..b9ebd0d18a52 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig

[PATCH net-next 06/11] net: Replace calls to vrf_dev_get_rth

2015-09-24 Thread David Ahern
Replace calls to vrf_dev_get_rth with l3mdev_get_rtable. The check on the flow flags is handled in the l3mdev operation. Signed-off-by: David Ahern --- include/net/vrf.h | 22 -- net/ipv4/route.c | 8 +++- 2 files changed, 3 insertions(+), 27 deletions(-) diff --git a/

[PATCH net-next 07/11] net: Remove the now unused vrf_ptr

2015-09-24 Thread David Ahern
Signed-off-by: David Ahern --- drivers/net/vrf.c | 32 ++-- include/linux/netdevice.h | 2 -- include/net/vrf.h | 6 -- 3 files changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index 80403c0630f1..fcf5f

[PATCH net-next 04/11] net: Replace vrf_master_ifindex{,_rcu} with l3mdev equivalents

2015-09-24 Thread David Ahern
Replace calls to vrf_master_ifindex_rcu and vrf_master_ifindex with either l3mdev_master_ifindex_rcu or l3mdev_master_ifindex. The pattern: oif = vrf_master_ifindex(dev) ? : dev->ifindex; is replaced with oif = l3mdev_fib_oif(dev); And remove the now unused vrf macros. Signed-off-by: Dav

[PATCH net-next 00/11] net: L3 master device

2015-09-24 Thread David Ahern
The VRF device is essentially a Layer 3 master device used to associate netdevices with a specific routing table and to influence FIB lookups via 'ip rules' and controlling the oif/iif used for the lookup. This series generalizes the VRF into L3 master device, l3mdev. Similar to switchdev it has a

[PATCH net-next 08/11] net: Remove vrf header file

2015-09-24 Thread David Ahern
Move remaining structs to VRF driver and delete the vrf header file. Signed-off-by: David Ahern --- MAINTAINERS | 1 - drivers/net/vrf.c | 16 +++- include/net/vrf.h | 29 - 3 files changed, 15 insertions(+), 31 deletions(-) delete mode 100644 incl

[PATCH net-next 02/11] net: Rename IFF_VRF_MASTER to IFF_L3MDEV_MASTER

2015-09-24 Thread David Ahern
Rename IFF_VRF_MASTER to IFF_L3MDEV_MASTER and update the name of the netif_is_vrf and netif_index_is_vrf macros. Signed-off-by: David Ahern --- drivers/net/vrf.c | 6 +++--- include/linux/netdevice.h | 14 +++--- include/net/route.h | 2 +- include/net/vrf.h | 4

[PATCH net-next] tcp: avoid reorders for TFO passive connections

2015-09-24 Thread Eric Dumazet
From: Eric Dumazet We found that a TCP Fast Open passive connection was vulnerable to reorders, as the exchange might look like [1] C -> S S [2] S -> C S. ack request [3] S -> C . packets [2] and [3] can be generated at almost the same time. If C receives the 3rd packet before the 2nd, it

Re: [GIT PULL nf-next 00/84] Second Round of IPVS Updates for v4.4

2015-09-24 Thread Pablo Neira Ayuso
On Thu, Sep 24, 2015 at 09:51:45AM +0900, Simon Horman wrote: > Hi Pablo, > > please consider these bug fixes and extensive clean-ups of IPVS > from Eric Biederman for v4.4. Pulled, thanks Simon. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majo

Re: [PATCH 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-09-24 Thread Pravin Shelar
On Thu, Sep 24, 2015 at 10:58 AM, Thomas F Herbert wrote: > Add support for 802.1ad including the ability to push and pop double > tagged vlans. Add support for 802.1ad to netlink parsing and flow > conversion. Uses double nested encap attributes to represent double > tagged vlan. Inner TPID encod

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread Russell King - ARM Linux
On Fri, Sep 25, 2015 at 12:50:33AM +0200, Andrew Lunn wrote: > > Thanks for testing. Please could you confirm whether the same behaviour > > is observed without the patches, just to make absolutely sure that isn't > > a regression. > > So i tested this now. > > I have two FEC interfaces. One i m

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread Russell King - ARM Linux
On Thu, Sep 24, 2015 at 03:51:37PM -0700, David Miller wrote: > From: Andrew Lunn > Date: Fri, 25 Sep 2015 00:26:54 +0200 > > > On Thu, Sep 24, 2015 at 03:15:54PM -0700, David Miller wrote: > >> From: Andrew Lunn > >> Date: Thu, 24 Sep 2015 23:57:31 +0200 > >> > >> > I built the FEC driver as a

Re: [PATCH] ip6_tunnel: Reduce log level in ip6_tnl_err() to debug

2015-09-24 Thread David Miller
From: Matt Bennett Date: Fri, 25 Sep 2015 11:01:47 +1200 > Currently error log messages in ip6_tnl_err are printed at 'warn' > level. This is different to other tunnel types which don't print > any messages. These log messages don't provide any information that > couldn't be deduced with networki

Re: [PATCH] net: mdio-octeon: Add PCI driver binding.

2015-09-24 Thread David Miller
From: David Daney Date: Thu, 24 Sep 2015 15:54:30 -0700 > On 09/24/2015 03:50 PM, David Miller wrote: >> From: David Daney >> Date: Thu, 24 Sep 2015 15:45:41 -0700 >> >>> 2) The OF device tree nodes for PCI devices do not result in the >>> creation of a platform device. >> >> But they are create

[PATCH] ip6_tunnel: Reduce log level in ip6_tnl_err() to debug

2015-09-24 Thread Matt Bennett
Currently error log messages in ip6_tnl_err are printed at 'warn' level. This is different to other tunnel types which don't print any messages. These log messages don't provide any information that couldn't be deduced with networking tools. Also it can be annoying to have one end of the tunnel go

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread Andrew Lunn
> Thanks for testing. Please could you confirm whether the same behaviour > is observed without the patches, just to make absolutely sure that isn't > a regression. So i tested this now. I have two FEC interfaces. One i my main access interface, and the second is used by DSA to access switches.

Re: [PATCH] net: mdio-octeon: Add PCI driver binding.

2015-09-24 Thread David Daney
On 09/24/2015 03:50 PM, David Miller wrote: From: David Daney Date: Thu, 24 Sep 2015 15:45:41 -0700 2) The OF device tree nodes for PCI devices do not result in the creation of a platform device. But they are created for the children right? And that's the one you need them for probing. I'm

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread David Miller
From: Andrew Lunn Date: Fri, 25 Sep 2015 00:26:54 +0200 > On Thu, Sep 24, 2015 at 03:15:54PM -0700, David Miller wrote: >> From: Andrew Lunn >> Date: Thu, 24 Sep 2015 23:57:31 +0200 >> >> > I built the FEC driver as a module, and it won't unload: >> > >> > kernel:unregister_netdevice: waiting

Re: [PATCH] net: mdio-octeon: Add PCI driver binding.

2015-09-24 Thread David Miller
From: David Daney Date: Thu, 24 Sep 2015 15:45:41 -0700 > 2) The OF device tree nodes for PCI devices do not result in the > creation of a platform device. But they are created for the children right? And that's the one you need them for probing. I'm still not convinced, sorry. -- To unsubscri

Re: [PATCH] net: mdio-octeon: Add PCI driver binding.

2015-09-24 Thread David Daney
On 09/24/2015 03:14 PM, David Miller wrote: From: David Daney Date: Thu, 24 Sep 2015 15:04:23 -0700 On 09/24/2015 02:52 PM, David Miller wrote: From: David Daney Date: Tue, 22 Sep 2015 17:41:36 -0700 From: David Daney When the Cavium mdio-octeon devices appear in the Thunder family of ar

Re: [PATCH net-next] net: dsa: Set a "dsa" device_type

2015-09-24 Thread Vivien Didelot
Hi Florian, On Sep. Wednesday 23 (39) 06:19 PM, Florian Fainelli wrote: > Provide a device_type information for slave network devices created by > DSA, this is useful for user-space application to easily locate/search > for devices of a specific kind. > > Signed-off-by: Florian Fainelli Noob qu

Re: pull-request: mac80211 2015-09-23

2015-09-24 Thread David Miller
From: Johannes Berg Date: Wed, 23 Sep 2015 10:44:14 +0200 > It's been pretty quiet for this cycle since the sizeof() mess, but I > have two more fixes now I'd like to get in. > > Let me know if there's any problem. Pulled, thanks a lot. -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread Andrew Lunn
On Thu, Sep 24, 2015 at 03:15:54PM -0700, David Miller wrote: > From: Andrew Lunn > Date: Thu, 24 Sep 2015 23:57:31 +0200 > > > I built the FEC driver as a module, and it won't unload: > > > > kernel:unregister_netdevice: waiting for eth1 to become free. Usage count > > = 1 > > unregister_netd

Re: [PATCH] ip6_gre: Reduce log level in ip6gre_err() to debug

2015-09-24 Thread David Miller
From: Matt Bennett Date: Wed, 23 Sep 2015 16:58:31 +1200 > Currently error log messages in ip6gre_err are printed at 'warn' > level. This is different to most other tunnel types which don't > print any messages. These log messages don't provide any information > that couldn't be deduced with netw

Re: [PATCH] net: mdio-octeon: Add PCI driver binding.

2015-09-24 Thread David Daney
On 09/24/2015 03:04 PM, David Daney wrote: On 09/24/2015 02:52 PM, David Miller wrote: From: David Daney Date: Tue, 22 Sep 2015 17:41:36 -0700 From: David Daney When the Cavium mdio-octeon devices appear in the Thunder family of arm64 based SoCs, they show up as PCI devices. Add PCI driver

Re: [PATCH net] fib_rules: fix fib rule dumps across multiple skbs

2015-09-24 Thread David Miller
From: Roopa Prabhu Date: Tue, 22 Sep 2015 21:40:22 -0700 > From: Wilson Kok > > dump_rules returns skb length and not error. > But when family == AF_UNSPEC, the caller of dump_rules > assumes that it returns an error. Hence, when family == AF_UNSPEC, > we continue trying to dump on -EMSGSIZE er

Re: [PATCH RESEND v3 5/9] of_mdio: fix MDIO phy device refcounting

2015-09-24 Thread Rob Herring
On Thu, Sep 24, 2015 at 2:36 PM, Russell King wrote: > bus_find_device() is defined as: > > * This is similar to the bus_for_each_dev() function above, but it > * returns a reference to a device that is 'found' for later use, as > * determined by the @match callback. > > and it does indeed retu

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread David Miller
From: Andrew Lunn Date: Thu, 24 Sep 2015 23:57:31 +0200 > I built the FEC driver as a module, and it won't unload: > > kernel:unregister_netdevice: waiting for eth1 to become free. Usage count = 1 > unregister_netdevice: waiting for eth1 to become free. Usage count = 1 > > i assume because DSA

Re: [PATCH v7 02/10] ss: created formatters for json and hr

2015-09-24 Thread Stephen Hemminger
On Thu, 24 Sep 2015 17:43:46 + Matthias Tafelmeier wrote: > > Maybe it is time to rewrite it in a better language ;-) > > I did not get that. Do you mean iproute2? I meant that the amount of formatting and string processing in ss is getting to be a significant fraction of the code. Langua

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread Russell King - ARM Linux
On Thu, Sep 24, 2015 at 11:57:31PM +0200, Andrew Lunn wrote: > Hi Russell > > I tested both of these with my board. It is a Freescale Vybrid, using > the FEC ethernet driver, and i have three switches attached, using > mdio-mux to give three mdio busses. > > No obvious regressions, my board boots

Re: [PATCH] net: mdio-octeon: Add PCI driver binding.

2015-09-24 Thread David Miller
From: David Daney Date: Thu, 24 Sep 2015 15:12:03 -0700 > Sorry for the breakage, I will fix it and resubmit. Don't bother, I told you that using PCI probing is unacceptable. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.or

Re: [PATCH] net: mdio-octeon: Add PCI driver binding.

2015-09-24 Thread David Miller
From: David Daney Date: Thu, 24 Sep 2015 15:04:23 -0700 > On 09/24/2015 02:52 PM, David Miller wrote: >> From: David Daney >> Date: Tue, 22 Sep 2015 17:41:36 -0700 >> >>> From: David Daney >>> >>> When the Cavium mdio-octeon devices appear in the Thunder family of >>> arm64 based SoCs, they sho

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread Andrew Lunn
... > While looking at the DSA code, I noticed we have a > of_find_net_device_by_node(), and it looks like users of that are > similarly buggy - it looks like net/dsa/dsa.c is the only user. Fix > that too. ... > The mdiobus code also suffered from the same kind of leak, but thankfully > this

Re: [PATCH] net: mdio-octeon: Add PCI driver binding.

2015-09-24 Thread David Daney
On 09/24/2015 02:52 PM, David Miller wrote: From: David Daney Date: Tue, 22 Sep 2015 17:41:36 -0700 From: David Daney When the Cavium mdio-octeon devices appear in the Thunder family of arm64 based SoCs, they show up as PCI devices. Add PCI driver wrapping so the driver is bound in the stan

[PATCH net-next] net: Add support for filtering neigh dump by master device

2015-09-24 Thread David Ahern
Add support for filtering neighbor dumps by master device by adding the NDA_MASTER attribute to the dump request. Signed-off-by: David Ahern --- This method works for other filters as well and other dump commands as well. Works fine for all combinations of new and old kernel and ip: 1. new ip com

Re: [PATCH v2 net-next] tcp: factorize sk_txhash init

2015-09-24 Thread David Miller
From: Eric Dumazet Date: Tue, 22 Sep 2015 20:44:17 -0700 > From: Eric Dumazet > > Neal suggested to move sk_txhash init into tcp_create_openreq_child(), > called both from IPv4 and IPv6. > > This opportunity was missed in commit 58d607d3e52f ("tcp: provide > skb->hash to synack packets") > >

Re: [PATCH] net: mdio-octeon: Add PCI driver binding.

2015-09-24 Thread David Miller
From: David Daney Date: Tue, 22 Sep 2015 17:41:36 -0700 > From: David Daney > > When the Cavium mdio-octeon devices appear in the Thunder family of > arm64 based SoCs, they show up as PCI devices. Add PCI driver > wrapping so the driver is bound in the standard PCI device scan. > > When in th

Re: [Patch net] net: revert "net_sched: move tp->root allocation into fw_init()"

2015-09-24 Thread David Miller
From: Cong Wang Date: Tue, 22 Sep 2015 17:01:11 -0700 > fw filter uses tp->root==NULL to check if it is the old method, > so it doesn't need allocation at all in this case. This patch > reverts the offending commit and adds some comments for old > method to make it obvious. > > Fixes: 33f8b9ecdb

Re: [PATCH net] bnx2x: byte swap rss_key to comply to Toeplitz specs

2015-09-24 Thread David Miller
From: Eric Dumazet Date: Tue, 22 Sep 2015 17:04:58 -0700 > From: Eric Dumazet > > After a good amount of debugging, I found bnx2x was byte swaping > the 40 bytes of rss_key. > > If we byte swap the key, then bnx2x generates hashes matching > MSDN specs as documented in (Verifying the RSS Hash

Re: [PATCH net 0/2] lwtunnel: make it really work, for IPv4

2015-09-24 Thread David Miller
From: Jiri Benc Date: Tue, 22 Sep 2015 18:12:10 +0200 > One of the selling points of lwtunnel was the ability to specify the tunnel > destination using routes. However, this doesn't really work currently, as > ARP and ndisc replies are not handled correctly. ARP and ndisc replies won't > have tun

[PATCH] net: Fix panic in icmp_route_lookup

2015-09-24 Thread David Ahern
Andrey reported a panic: [ 7249.865507] BUG: unable to handle kernel pointer dereference at 00b4 [ 7249.865559] IP: [] icmp_route_lookup+0xaa/0x320 [ 7249.865598] *pdpt = 30f7f001 *pde = [ 7249.865637] Oops: [#1] ... [ 7249.866811] CPU: 0 PID: 0 Comm: swapper/0 No

Re: [RFC v2 net-next 05/10] qede: Add basic network device support

2015-09-24 Thread Stephen Hemminger
On Thu, 17 Sep 2015 17:23:54 +0300 Yuval Mintz wrote: > +#define QEDE_NAPI_WEIGHT (NAPI_POLL_WEIGHT) > + Why not just use existing constant rather than walpapering? > + > +#define U64_LO(x)((u32)(((u64)(x)) & 0x)) > +#define U64_HI(x)((u32)(((u

Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-24 Thread David Miller
From: Sudeep Holla Date: Mon, 21 Sep 2015 16:47:09 +0100 > The device is set as wakeup capable using proper wakeup API but the > driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source > which is incorrect. > > This patch removes the use of IRQF_NO_SUSPEND flags replacing it with >

Re: [PATCH] ip: find correct route for socket which is not bound (v2)

2015-09-24 Thread David Miller
From: Wengang Wang Date: Mon, 21 Sep 2015 16:00:09 +0800 > This is the v2, comparing the v1, the changes is: > * for loopback outbound device, it continue skipping cached route; >for others, it goes through the cached route. There are many things I want you to clean up in your commit messag

Re: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag

2015-09-24 Thread Li Yang
On Wed, Sep 23, 2015 at 5:03 PM, Thomas Gleixner wrote: > On Wed, 23 Sep 2015, Li Yang wrote: >> On Mon, Sep 21, 2015 at 11:51 AM, Thomas Gleixner wrote: >> > On Mon, 21 Sep 2015, Manoil Claudiu wrote: >> >> >The device is set as wakeup capable using proper wakeup API but the >> >> >driver misuse

Re: [PATCH net v2] skbuff: Fix skb checksum flag on skb pull

2015-09-24 Thread David Miller
From: Pravin B Shelar Date: Tue, 22 Sep 2015 12:57:53 -0700 > VXLAN device can receive skb with checksum partial. But the checksum > offset could be in outer header which is pulled on receive. This results > in negative checksum offset for the skb. Such skb can cause the assert > failure in skb_c

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-24 Thread Stephen Hemminger
On Thu, 24 Sep 2015 13:59:26 -0700 sfel...@gmail.com wrote: > From: Scott Feldman > > Push bridge-level attributes down to switchdev drivers. This patchset > adds the infrastructure and then pushes, as an example, ageing_time attribute > down from bridge to switchdev (rocker) driver. Add some

[PATCH net-next 4/4] rocker: handle setting bridge ageing_time

2015-09-24 Thread sfeldma
From: Scott Feldman The FDB cleanup timer will get rescheduled to re-evaluate FDB entries based on new ageing_time. Signed-off-by: Scott Feldman --- drivers/net/ethernet/rocker/rocker.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/ethernet/rocker/ro

[PATCH net-next 2/4] switchdev: skip over ports returning -EOPNOTSUPP when recursing ports

2015-09-24 Thread sfeldma
From: Scott Feldman This allows us to recurse over all the ports, skipping over unsupporting ports. Without the change, the recursion would stop at first unsupported port. Signed-off-by: Scott Feldman --- include/net/switchdev.h |1 + net/switchdev/switchdev.c |9 - 2 files

[PATCH net-next 1/4] switchdev: add bridge attributes

2015-09-24 Thread sfeldma
From: Scott Feldman Setting the stage to push bridge-level attributes down to port driver so hardware can be programmed accordingly. Bridge-level attribute example is ageing_time. This is a per-bridge attribute, not a per-bridge-port attr. Signed-off-by: Scott Feldman --- include/net/switchd

[PATCH net-next 3/4] bridge: push bridge setting ageing_time down to switchdev

2015-09-24 Thread sfeldma
From: Scott Feldman Use SWITCHDEV_F_SKIP_EOPNOTSUPP to skip over ports in bridge that don't support setting ageing_time (or setting bridge attrs in general). If push fails, don't update ageing_time in bridge and return err to user. If push succeeds, update ageing_time in bridge and run gc_timer

[PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-24 Thread sfeldma
From: Scott Feldman Push bridge-level attributes down to switchdev drivers. This patchset adds the infrastructure and then pushes, as an example, ageing_time attribute down from bridge to switchdev (rocker) driver. Add some range-checking for ageing_time. # ip link set dev br0 type bridge agei

Re: [PATCH v2] netlink: Replace rhash_portid with bound

2015-09-24 Thread Tejun Heo
Hello, David. On Thu, Sep 24, 2015 at 12:11:42PM -0700, David Miller wrote: > From: Herbert Xu > Date: Tue, 22 Sep 2015 11:38:56 +0800 > > > The commit 1f770c0a09da855a2b51af6d19de97fb955eca85 ("netlink: > > Fix autobind race condition that leads to zero port ID") created > > some new races that

[PATCH RESEND v3 9/9] net: fix net_device refcounting

2015-09-24 Thread Russell King
of_find_net_device_by_node() uses class_find_device() internally to lookup the corresponding network device. class_find_device() returns a reference to the embedded struct device, with its refcount incremented. Add a comment to the definition in net/core/net-sysfs.c indicating the need to drop th

[PATCH RESEND v3 3/9] phy: fix mdiobus module safety

2015-09-24 Thread Russell King
Re-implement the mdiobus module refcounting to ensure that we actually ensure that the mdiobus module code does not go away while we might call into it. The old scheme using bus->dev.driver was buggy, because bus->dev is a class device which never has a struct device_driver associated with it, and

[PATCH RESEND v3 2/9] net: dsa: fix of_mdio_find_bus() device refcount leak

2015-09-24 Thread Russell King
Current users of of_mdio_find_bus() leak a struct device refcount, as they fail to clean up the reference obtained inside class_find_device(). Fix the DSA code to properly refcount the returned MDIO bus by: 1. taking a reference on the struct device whenever we assign it to pd->chip[x].host_dev

  1   2   3   >