Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-28 Thread David Miller
From: sfel...@gmail.com Date: Thu, 24 Sep 2015 13:59:26 -0700 > From: Scott Feldman > > Push bridge-level attributes down to switchdev drivers. This patchset > adds the infrastructure and then pushes, as an example, ageing_time attribute > down from bridge to switchdev

Re: [PATCH net v2] skbuff: Fix skb checksum flag on skb pull

2015-09-28 Thread David Miller
From: Pravin Shelar Date: Fri, 25 Sep 2015 19:48:57 -0700 > On Thu, Sep 24, 2015 at 2:09 PM, David Miller wrote: >> From: Pravin B Shelar >> Date: Tue, 22 Sep 2015 12:57:53 -0700 >> >>> VXLAN device can receive skb with checksum

Re: [PATCH] net: fec: Remove unneeded FEATURES_NEED_QUIESCE definition

2015-09-28 Thread David Miller
From: Fabio Estevam Date: Fri, 25 Sep 2015 18:31:32 -0300 > From: Fabio Estevam > > There is no need to have FEATURES_NEED_QUIESCE defined as we > can simply use NETIF_F_RXCSUM instead as done in other parts > of the driver. > > Signed-off-by:

Re: [PATCH net-next v4] net: Fix Hisilicon Network Subsystem Support Compilation

2015-09-28 Thread David Miller
From: huangdaode Date: Sun, 27 Sep 2015 15:22:44 +0800 > This patch fixes the compilation error with arm allmodconfig, this error > generated due to unavailability of readq() on 32-bit platform which was > found during net-next daily compilation. In the same time, fix

Re: [PATCH net-next] cxgb4: Add HW timesptamp support for RX

2015-09-28 Thread David Miller
From: Hariprasad Shenai Date: Mon, 28 Sep 2015 10:26:53 +0530 > Adds support for ethtool get time stamp ioctl, which is used by > tcpdump to get the supported time stamp types > > eg: tcpdump -i eth5 -J > Time stamp types for eth5 (use option -j to set): > host (Host)

Re: [PATCH] net/mlx4: Handle return codes in mlx4_qp_attach_common

2015-09-28 Thread David Miller
From: Robb Manes Date: Fri, 25 Sep 2015 10:39:21 -0400 > @@ -1184,10 +1184,11 @@ out: > if (prot == MLX4_PROT_ETH) { > /* manage the steering entry for promisc mode */ > if (new_entry) > -new_steering_entry(dev, port, steer, index, qp->qpn);

Re: [PATCH net-next] lan78xx: Return 0 when lan78xx_suspend() has no error.

2015-09-28 Thread David Miller
From: Date: Fri, 25 Sep 2015 21:13:48 + > lan78xx_suspend() may return non-zero from lan78xx_write_reg() in some > scenario. > Fix to return 0 when lan78xx_suspend() has no error. > > Signed-off-by: Woojung Huh Applied, thanks. -- To

Re: [PATCH net-next] net: Remove redundant oif checks in rt6_device_match

2015-09-28 Thread David Miller
From: David Ahern Date: Fri, 25 Sep 2015 15:22:54 -0600 > The oif has already been checked that it is non-zero; the 2 additional > checks on oif within that if (oif) {...} block are redundant. > > CC: YOSHIFUJI Hideaki > Signed-off-by: David

Re: [PATCH v3 3/3] net: irda: pxaficp_ir: dmaengine conversion

2015-09-28 Thread David Miller
From: Robert Jarzmik Date: Sat, 26 Sep 2015 20:49:20 +0200 > Convert pxaficp_ir to dmaengine. As pxa architecture is shifting from > raw DMA registers access to pxa_dma dmaengine driver, convert this > driver to dmaengine. > > Signed-off-by: Robert Jarzmik

Re: [PATCH v3 2/3] net: irda: pxaficp_ir: convert to readl and writel

2015-09-28 Thread David Miller
From: Robert Jarzmik Date: Sat, 26 Sep 2015 20:49:19 +0200 > Convert the pxa IRDA driver to readl and writel primitives, and remove > another set of direct registers access. This leaves only the DMA > registers access, which will be dealt with dmaengine conversion. > >

Re: [PATCH v3 1/3] net: irda: pxaficp_ir: use sched_clock() for time management

2015-09-28 Thread David Miller
From: Robert Jarzmik Date: Sat, 26 Sep 2015 20:49:18 +0200 > Instead of using directly the OS timer through direct register access, > use the standard sched_clock(), which will end up in OSCR reading > anyway. > > This is a first step for direct access register removal

Re: [net-next PATCH] net: help compiler generate better code in eth_get_headlen

2015-09-28 Thread David Miller
From: Jesper Dangaard Brouer Date: Mon, 28 Sep 2015 12:47:14 +0200 > Noticed that the compiler (gcc version 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC)) > generated suboptimal assembler code in eth_get_headlen(). > > This early return coding style is usually not an issue, on

Re: [PATCH net-next] tcp: avoid reorders for TFO passive connections

2015-09-28 Thread David Miller
From: Eric Dumazet Date: Thu, 24 Sep 2015 17:16:05 -0700 > From: Eric Dumazet > > We found that a TCP Fast Open passive connection was vulnerable > to reorders, as the exchange might look like > > [1] C -> S S > [2] S -> C S. ack request > [3] S

Re: [PATCH] net ipv4 ipconfig: use preferred log methods

2015-09-28 Thread David Miller
From: Bastian Stender Date: Fri, 25 Sep 2015 11:58:30 +0200 > @@ -69,7 +69,7 @@ > #undef IPCONFIG_DEBUG > > #ifdef IPCONFIG_DEBUG > -#define DBG(x) printk x > +#define DBG(x) pr_debug(x) > #else > #define DBG(x) do { } while(0) > #endif I agree with Stephen, just get

Re: [PATCH] l2tp: protect tunnel->del_work by ref_count

2015-09-28 Thread David Miller
From: Alexander Couzens Date: Mon, 28 Sep 2015 11:32:42 +0200 > There is a small chance that tunnel_free() is called before tunnel->del_work > scheduled > resulting in a zero pointer dereference. > > Signed-off-by: Alexander Couzens Applied and queued up for

Re: [PATCH net-next 0/8] Mellanox mlx5 driver update

2015-09-28 Thread David Miller
From: Or Gerlitz Date: Fri, 25 Sep 2015 10:49:08 +0300 > Bunch of changes from the team, while warming engines for the > upcoming SRIOV support. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH v2 17/19] tools: bpf_jit_disasm: make get_last_jit_image return unsigned

2015-09-28 Thread David Miller
From: Andrzej Hajda Date: Fri, 25 Sep 2015 08:45:43 +0200 > The function returns always non-negative values. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]:

Re: [PATCH v2] net: sctp: Don't use 64 kilobyte lookup table for four elements

2015-09-28 Thread David Miller
From: Denys Vlasenko Date: Mon, 28 Sep 2015 14:34:04 +0200 > Seemingly innocuous sctp_trans_state_to_prio_map[] array > is way bigger than it looks, since > "[SCTP_UNKNOWN] = 2" expands into "[0x] = 2" ! > > This patch replaces it with switch() statement. > >

Re: [net-next v2 0/6][pull request] Intel Wired LAN Driver Updates 2015-09-28

2015-09-28 Thread David Miller
From: Jeff Kirsher Date: Mon, 28 Sep 2015 17:55:28 -0700 > This series contains updates to i40e, i40evf and igb to resolve issues > seen and reported by Red Hat. Pulled, thanks Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [net] i40e/i40evf: check for stopped admin queue

2015-09-28 Thread David Miller
From: Jeff Kirsher Date: Mon, 28 Sep 2015 17:31:26 -0700 > From: Mitch Williams > > It's possible that while we are waiting for the spinlock, another > entity (that owns the spinlock) has shut down the admin queue. > If we then attempt

Re: [net] i40e: fix VLAN inside VXLAN

2015-09-28 Thread David Miller
From: Jeff Kirsher Date: Mon, 28 Sep 2015 11:21:48 -0700 > From: Jesse Brandeburg > > Previously to this patch, the hardware was removing > VLAN tags from the inner header of VXLAN packets. The > hardware configuration can be changed to

Re: [PATCH net 0/2] sctp: Fix SCTP deadlock

2015-09-28 Thread David Miller
From: Karl Heiss Date: Thu, 24 Sep 2015 12:15:05 -0400 > These patches fix a deadlock during accept() of an SCTP connection. > > The first patch fixes whitespace issues. > > The second patch actually fixes the deadlock race. Seems reasonable, series applied, thanks. -- To

Re: [PATCH net-next 0/4] switchdev: push bridge attributes down

2015-09-28 Thread Florian Fainelli
2015-09-24 21:26 GMT-07:00 Scott Feldman : > On Thu, Sep 24, 2015 at 6:23 PM, Florian Fainelli > wrote: >> On 24/09/15 13:59, sfel...@gmail.com wrote: >>> From: Scott Feldman >>> >>> Push bridge-level attributes down to switchdev

Re: [PATCH v2] net/ibm/emac: bump version numbers for correct work with ethtool

2015-09-28 Thread David Miller
From: Ivan Mikhaylov Date: Fri, 25 Sep 2015 11:52:27 +0400 > The size of the MAC register dump used to be the size specified by the > reg property in the device tree. Userland has no good way of finding > out that size, and it was not specified consistently for each MAC type, >

Re: [PATCH v2 net-next] tcp: Fix CWV being too strict on thin streams

2015-09-28 Thread David Miller
From: Eric Dumazet Date: Sun, 27 Sep 2015 09:33:00 -0700 > David, any idea of what happened to Bendik patch ? > > https://patchwork.ozlabs.org/patch/521765 > > Do we need to re-submit or something ? Sorry, applied and build testing, I don't know how this disappeared

Re: [RFT] geneve: implement support for IPv6-based tunnels

2015-09-28 Thread John W. Linville
On Fri, Sep 25, 2015 at 02:08:44PM +0200, Jiri Benc wrote: > On Thu, 24 Sep 2015 14:34:42 -0400, John W. Linville wrote: > > +#if IS_ENABLED(CONFIG_IPV6) > > +static netdev_tx_t geneve6_xmit_skb(struct sk_buff *skb, struct net_device > > *dev) > > +{ > > + struct geneve_dev *geneve =

Re: [RFC PATCH] Fix false positives in can_checksum_protocol()

2015-09-28 Thread Tom Herbert
On Mon, Sep 28, 2015 at 12:26 PM, David Woodhouse wrote: > On Mon, 2015-09-28 at 12:13 -0700, Tom Herbert wrote: >> >> > Perhaps a better solution would be a bit in the skbuff which indicates >> > that it *is* a TCP or UDP checksum. That would be set by our UDP and >> > TCP

[PATCH 1/6] net/core: make sock_diag.c explicitly non-modular

2015-09-28 Thread Paul Gortmaker
The Makefile currently controlling compilation of this code lists it under "obj-y" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. Since

[PATCH net-next 0/6] make non-modular code explicitly non-modular

2015-09-28 Thread Paul Gortmaker
In a previous merge window, we made changes to allow better delineation between modular and non-modular code in commit 0fd972a7d91d6e15393c449492a04d94c0b89351 ("module: relocate module_init from init.h to module.h"). This allows us to now ensure module code looks modular and non-modular code

[PATCH] net: ipv6: Add RT6_LOOKUP_F_IFACE flag if oif is set

2015-09-28 Thread David Ahern
Wolfgang reported that IPv6 stack is ignoring oif in output route lookups: With ipv6, ip -6 route get always returns the specific route. $ ip -6 r 2001:db8:e2::1 dev enp2s0 proto kernel metric 256 2001:db8:e2::/64 dev enp2s0 metric 1024 2001:db8:e3::1 dev enp3s0 proto

Re: 4.3-rc3 Regression: NFS access stall by commit 6ae459bdaaee

2015-09-28 Thread Pravin Shelar
On Mon, Sep 28, 2015 at 6:12 AM, Takashi Iwai wrote: > [I resent this since the previous mail didn't go out properly, as it > seems; apologies if you already read it, please disregard] > > Hi, > > I noticed that NFS access from my workstation slowed down drastically, > almost

RESEND: [PATCH v3 net-next] sky2: use random address if EEPROM is bad

2015-09-28 Thread Liviu Dudau
On some embedded systems the EEPROM does not contain a valid MAC address. In that case it is better to fallback to a generated mac address and let init scripts fix the value later. Reported-by: Liviu Dudau Signed-off-by: Stephen Hemminger

[PATCH net-next 10/11] net: Rename FLOWI_FLAG_VRFSRC to FLOWI_FLAG_L3MDEV_SRC

2015-09-28 Thread David Ahern
Signed-off-by: David Ahern --- drivers/net/vrf.c | 4 ++-- include/net/flow.h | 2 +- include/net/route.h | 2 +- net/ipv4/udp.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c index

[PATCH net-next 07/11] net: Remove the now unused vrf_ptr

2015-09-28 Thread David Ahern
Signed-off-by: David Ahern --- drivers/net/vrf.c | 32 ++-- include/linux/netdevice.h | 2 -- include/net/vrf.h | 6 -- 3 files changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/net/vrf.c

[PATCH net-next 03/11] net: Add support for l3mdev ops to VRF driver

2015-09-28 Thread David Ahern
Signed-off-by: David Ahern --- drivers/net/Kconfig | 1 + drivers/net/vrf.c | 29 + 2 files changed, 30 insertions(+) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index d18eb607bee6..b9ebd0d18a52 100644 --- a/drivers/net/Kconfig

[PATCH net-next 02/11] net: Introduce L3 Master device abstraction

2015-09-28 Thread David Ahern
L3 master devices allow users of the abstraction to influence FIB lookups for enslaved devices. Current API provides a means for the master device to return a specific FIB table for an enslaved device, to return an rtable/custom dst and influence the OIF used for fib lookups. Signed-off-by: David

[PATCH net-next 05/11] net: Replace vrf_dev_table and friends

2015-09-28 Thread David Ahern
Replace calls to vrf_dev_table and friends with l3mdev_fib_table and kin. Signed-off-by: David Ahern --- include/net/vrf.h | 80 - net/ipv4/af_inet.c | 4 +-- net/ipv4/fib_frontend.c | 7 ++--- 3 files

[PATCH net-next 08/11] net: Remove vrf header file

2015-09-28 Thread David Ahern
Move remaining structs to VRF driver and delete the vrf header file. Signed-off-by: David Ahern --- MAINTAINERS | 1 - drivers/net/vrf.c | 16 +++- include/net/vrf.h | 29 - 3 files changed, 15 insertions(+), 31

[PATCH net-next 11/11] net: Add netif_is_l3_slave

2015-09-28 Thread David Ahern
IPv6 addrconf keys off of IFF_SLAVE so can not use it for L3 slave. Add a new private flag and add netif_is_l3_slave function for checking it. Signed-off-by: David Ahern --- drivers/net/vrf.c | 8 +++- include/linux/netdevice.h | 7 +++

Re: unregister_netdevice warnings when deleting netns

2015-09-28 Thread Julian Anastasov
Hello, On Mon, 28 Sep 2015, Anand Gurram wrote: > I am currently using kernel version 3.16.7 on a linux switch. > While creating and destroying network namespaces I am observing below logs > on the console > "unregister_netdevice: waiting for lo to become free. Usage count = 1" > > Can

Re: [RFC PATCH] Fix false positives in can_checksum_protocol()

2015-09-28 Thread Tom Herbert
>> Also, this doesn't help those drivers that that can offload TCP and >> UDP for IPv6 but only if there are no extension headers, in those >> case the driver needs to look at the packet to see if it is a >> "simple" UDP/TCP packet. > > Hm, are such devices even permitted to set

Re: [RFC PATCH] Fix false positives in can_checksum_protocol()

2015-09-28 Thread David Woodhouse
On Mon, 2015-09-28 at 12:13 -0700, Tom Herbert wrote: > > > Perhaps a better solution would be a bit in the skbuff which indicates > > that it *is* a TCP or UDP checksum. That would be set by our UDP and > > TCP sockets, cleared by encapsulation, also set if appropriate by > >

[net-next 4/5] i40e: Fix RS bit update in Tx path and disable force WB workaround

2015-09-28 Thread Jeff Kirsher
From: Anjali Singhai This patch fixes the issue of forcing WB too often causing us to not benefit from NAPI. Without this patch we were forcing WB/arming interrupt too often taking away the benefits of NAPI and causing a performance impact. With this patch we disable

[net-next 2/5] i40e/i40evf: refactor tx timeout logic

2015-09-28 Thread Jeff Kirsher
From: Kiran Patil This patch modifies the driver timeout logic by issuing a writeback request via a software interrupt to the hardware the first time the driver detects a hang. The driver was too aggressive in resetting a hung queue, so back that off by removing logic to

[net-next 1/5] i40e: Move i40e_get_head into header file

2015-09-28 Thread Jeff Kirsher
From: Kiran Patil i40e_get_head needs to be called in multiple files in a further patch, prepare by moving the function into a header file. Signed-off-by: Kiran Patil Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 5/5] igb: assume MSI-X interrupts during initialization

2015-09-28 Thread Jeff Kirsher
From: Stefan Assmann In igb_sw_init() the sequence of calls was changed from igb_init_queue_configuration() igb_init_interrupt_scheme() igb_probe_vfs() to igb_probe_vfs() igb_init_queue_configuration() igb_init_interrupt_scheme() This results in adapter->flags not having the

[net-next 0/5][pull request] Intel Wired LAN Driver Updates 2015-09-28

2015-09-28 Thread Jeff Kirsher
This series contains updates to i40e, i40evf and igb to resolve issues seen and reported by Red Hat. Kiran moves i40e_get_head() in preparation for the refactor of the Tx timeout logic, so that it can be used in other areas of the driver. Refactored the driver timeout logic by issuing a writeback

[net-next 3/5] i40e: add GRE tunnel type to csum encoding

2015-09-28 Thread Jeff Kirsher
From: Shannon Nelson Make sure the Tx checksum encoder knows about GRE protocol and sets the descriptor flag appropriately. Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[PATCH 3/6] net/sched: make sch_blackhole.c explicitly non-modular

2015-09-28 Thread Paul Gortmaker
The Kconfig currently controlling compilation of this code is: net/sched/Kconfig:menuconfig NET_SCHED net/sched/Kconfig: bool "QoS and/or fair queueing" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that

Re

2015-09-28 Thread David Thomas
I have a proposal for you Kindly E-mail me at mrshus...@gmail.com yours Faithfully Mrs Huian Shao [http://www.cranbrook.nsw.edu.au/images/email_sig.gif] David Thomas | Hone Housemaster / History Teacher 5 Victoria Road, Bellevue Hill NSW 2023 Australia

Re: [RFC PATCH] Fix false positives in can_checksum_protocol()

2015-09-28 Thread Tom Herbert
On Fri, Sep 25, 2015 at 5:55 AM, David Woodhouse wrote: > The check in harmonize_features() is supposed to match the skb against > the features of the device in question, and prevent us from handing a > skb to a device which can't handle it. > > It doesn't work correctly. A

[PATCH net-next 09/11] net: Move netif_index_is_l3_master to l3mdev.h

2015-09-28 Thread David Ahern
Change CONFIG dependency to CONFIG_NET_L3_MASTER_DEV as well. Signed-off-by: David Ahern --- include/linux/netdevice.h | 21 - include/net/l3mdev.h | 24 include/net/route.h | 1 + 3 files changed, 25

[PATCH net-next 01/11] net: Rename IFF_VRF_MASTER to IFF_L3MDEV_MASTER

2015-09-28 Thread David Ahern
Rename IFF_VRF_MASTER to IFF_L3MDEV_MASTER and update the name of the netif_is_vrf and netif_index_is_vrf macros. Signed-off-by: David Ahern --- drivers/net/vrf.c | 6 +++--- include/linux/netdevice.h | 14 +++--- include/net/route.h | 2 +-

Re: [PATCH v2] net: sctp: Don't use 64 kilobyte lookup table for four elements

2015-09-28 Thread Denys Vlasenko
On 09/28/2015 05:32 PM, David Laight wrote: > From: Eric Dumazet >> Sent: 28 September 2015 15:27 >> On Mon, 2015-09-28 at 14:12 +, David Laight wrote: >>> From: Neil Horman Sent: 28 September 2015 14:51 On Mon, Sep 28, 2015 at 02:34:04PM +0200, Denys Vlasenko wrote: > Seemingly

[PATCH net-next 06/11] net: Replace calls to vrf_dev_get_rth

2015-09-28 Thread David Ahern
Replace calls to vrf_dev_get_rth with l3mdev_get_rtable. The check on the flow flags is handled in the l3mdev operation. Signed-off-by: David Ahern --- include/net/vrf.h | 22 -- net/ipv4/route.c | 8 +++- 2 files changed, 3 insertions(+), 27

[PATCH net-next v2 00/11] net: L3 master device

2015-09-28 Thread David Ahern
The VRF device is essentially a Layer 3 master device used to associate netdevices with a specific routing table and to influence FIB lookups via 'ip rules' and controlling the oif/iif used for the lookup. This series generalizes the VRF into L3 master device, l3mdev. Similar to switchdev it has

[PATCH net-next 04/11] net: Replace vrf_master_ifindex{,_rcu} with l3mdev equivalents

2015-09-28 Thread David Ahern
Replace calls to vrf_master_ifindex_rcu and vrf_master_ifindex with either l3mdev_master_ifindex_rcu or l3mdev_master_ifindex. The pattern: oif = vrf_master_ifindex(dev) ? : dev->ifindex; is replaced with oif = l3mdev_fib_oif(dev); And remove the now unused vrf macros. Signed-off-by:

[net-next PATCH 1/3] net/ipv4: Pass proto as u8 instead of u16 in ip_check_mc_rcu

2015-09-28 Thread Alexander Duyck
This patch updates ip_check_mc_rcu so that protocol is passed as a u8 instead of a u16. The motivation is just to avoid any unneeded type transitions since some systems will require an instruction to zero extend a u8 field to a u16. Also it makes it a bit more readable as to the fact that

[net-next PATCH 2/3] net: Swap ordering of tests in ip_route_input_mc

2015-09-28 Thread Alexander Duyck
This patch just swaps the ordering of one of the conditional tests in ip_route_input_mc. Specifically it swaps the testing for the source address to see if it is loopback, and the test to see if we allow a loopback source address. The reason for swapping these two tests is because it is much

[net-next PATCH 3/3] net: Remove martian_source_keep_err goto label

2015-09-28 Thread Alexander Duyck
From: David Ahern err is initialized to -EINVAL when it is declared. It is not reset until fib_lookup which is well after the 3 users of the martian_source jump. So resetting err to -EINVAL at martian_source label is not needed. Removing that line obviates the need for

[net-next PATCH 0/3] Minor IPv4 routing cleanups

2015-09-28 Thread Alexander Duyck
These patches just contain some minor cleanups to address a few minor issues. The first and the third mostly just improve readability. The second patch should improve the performance for multicast destination addresses that do not have a localhost source IP address by avoiding some unnecessary

Re: [RFC PATCH] Fix false positives in can_checksum_protocol()

2015-09-28 Thread David Woodhouse
On Mon, 2015-09-28 at 10:03 -0700, Tom Herbert wrote: > > + if features & NETIF_F_V4_CSUM) && protocol == htons(ETH_P_IP)) > > || > > +((features & NETIF_F_V6_CSUM) && protocol == > > htons(ETH_P_IPV6))) && > > + (sk_protocol == IPPROTO_TCP || sk_protocol ==

Re: [PATCH] ipvs: Don't protect ip_vs_addr_is_unicast with CONFIG_SYSCTL

2015-09-28 Thread Julian Anastasov
Hello, On Mon, 28 Sep 2015, Eric W. Biederman wrote: > I arranged the code so that the compiler can remove the unecessary bits > in ip_vs_leave when CONFIG_SYSCTL is unset, and removed an explicit > CONFIG_SYSCTL. > > Unfortunately when rebasing my work on top of that of Alex Gartrell

[net] i40e: fix VLAN inside VXLAN

2015-09-28 Thread Jeff Kirsher
From: Jesse Brandeburg Previously to this patch, the hardware was removing VLAN tags from the inner header of VXLAN packets. The hardware configuration can be changed to leave the packet alone since that is what the linux stack expects for this type of VLAN in VXLAN

[PATCH 2/5] ntp/pps: replace getnstime_raw_and_real with 64-bit version

2015-09-28 Thread Arnd Bergmann
There is exactly one caller of getnstime_raw_and_real in the kernel, which is the pps_get_ts function. This changes the caller and the implementation to work on timespec64 types rather than timespec, to avoid the time_t overflow on 32-bit architectures. For consistency with the other new

[PATCH 5/5] net: sfc: avoid using timespec

2015-09-28 Thread Arnd Bergmann
The sfc driver internally uses a time format based on 32-bit (unsigned) seconds and 32-bit nanoseconds. This means it will overflow in 2106, but the value we pass into it is a signed 32-bit tv_sec that already overflows in 2038 to a negative value. This patch changes the logic to use the lower 32

Re: [PATCH net-next 0/6] make non-modular code explicitly non-modular

2015-09-28 Thread Geert Uytterhoeven
Hi Paul, On Mon, Sep 28, 2015 at 9:51 PM, Paul Gortmaker wrote: > In a previous merge window, we made changes to allow better > delineation between modular and non-modular code in commit > 0fd972a7d91d6e15393c449492a04d94c0b89351 ("module: relocate module_init >

[PATCH 4/5] ntp/pps: use y2038 safe types in pps_event_time

2015-09-28 Thread Arnd Bergmann
The pps_event_time uses two 'timespec' structures internally, which suffer from the y2038 problem. The uses of this structure are fairly self-contained in the pps code, so this replaces them all at once. Unfortunately, this includes the sfc ethernet driver aside from the pps subsystem, so we

[PATCH 1/5] ntp/pps: use timespec64 for hardpps()

2015-09-28 Thread Arnd Bergmann
There is only one user of the hardpps function in the kernel, so it makes sense to atomically change it over to using 64-bit timestamps for y2038 safety. In the hardpps implementation, we also need to change the pps_normtime structure, which is similar to struct timespec and also requires a 64-bit

Re: [PATCH net-next 0/6] make non-modular code explicitly non-modular

2015-09-28 Thread Paul Gortmaker
[Re: [PATCH net-next 0/6] make non-modular code explicitly non-modular] On 28/09/2015 (Mon 23:09) Geert Uytterhoeven wrote: > Hi Paul, > > On Mon, Sep 28, 2015 at 9:51 PM, Paul Gortmaker > wrote: > > In a previous merge window, we made changes to allow better > >

Re: unregister_netdevice warnings when deleting netns

2015-09-28 Thread Eric W. Biederman
Julian Anastasov writes: > Hello, > > On Mon, 28 Sep 2015, Anand Gurram wrote: > >> I am currently using kernel version 3.16.7 on a linux switch. >> While creating and destroying network namespaces I am observing below logs >> on the console >> "unregister_netdevice: waiting

[PATCH 3/5] ntp: use timespec64 in sync_cmos_clock

2015-09-28 Thread Arnd Bergmann
The sync_cmos_clock has one use of struct timespec, which we want to eventually replace with timespec64 or similar in the kernel. There is no way this one can overflow, but the conversion to timespec64 is trivial and has no other dependencies. Signed-off-by: Arnd Bergmann ---

[PATCH 0/5] y2038 conversion for ntp/pps and sfc driver

2015-09-28 Thread Arnd Bergmann
When trying to build a kernel with time_t commented out, I found that the ntp subsystem still relies on timespec for its pps handling. This series addresses this and converts all the code to use timespec64 instead, step by step. There is one device driver that interacts with this code directly

Re: [Cluster-devel] [PATCH 17/23] dlm: use per-attribute show and store methods

2015-09-28 Thread David Teigland
On Fri, Sep 25, 2015 at 06:49:54AM -0700, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > fs/dlm/config.c | 288 > +++- > 1 file changed, 74 insertions(+), 214 deletions(-) Looks good to me. Dave -- To

[PATCH] ipvs: Don't protect ip_vs_addr_is_unicast with CONFIG_SYSCTL

2015-09-28 Thread Eric W. Biederman
I arranged the code so that the compiler can remove the unecessary bits in ip_vs_leave when CONFIG_SYSCTL is unset, and removed an explicit CONFIG_SYSCTL. Unfortunately when rebasing my work on top of that of Alex Gartrell I missed the fact that the newly added function ip_vs_addr_is_unicast was

Re: [PATCH 7/7] slub: do prefetching in kmem_cache_alloc_bulk()

2015-09-28 Thread Alexander Duyck
On 09/28/2015 05:26 AM, Jesper Dangaard Brouer wrote: For practical use-cases it is beneficial to prefetch the next freelist object in bulk allocation loop. Micro benchmarking show approx 1 cycle change: bulk - prev-patch - this patch 1 - 49 cycles(tsc) - 49 cycles(tsc) - increase

Re: [PATCH 4/7] slab: implement bulking for SLAB allocator

2015-09-28 Thread Christoph Lameter
On Mon, 28 Sep 2015, Jesper Dangaard Brouer wrote: > +/* Note that interrupts must be enabled when calling this function. */ > bool kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t size, > - void **p) > +

Re: [PATCH 5/7] slub: support for bulk free with SLUB freelists

2015-09-28 Thread Christoph Lameter
On Mon, 28 Sep 2015, Jesper Dangaard Brouer wrote: > Not knowing SLUB as well as you, it took me several hours to realize > init_object() didn't overwrite the freepointer in the object. Thus, I > think these comments make the reader aware of not-so-obvious > side-effects of SLAB_POISON and

Re: [PATCH 5/7] slub: support for bulk free with SLUB freelists

2015-09-28 Thread Christoph Lameter
On Mon, 28 Sep 2015, Jesper Dangaard Brouer wrote: > diff --git a/mm/slub.c b/mm/slub.c > index 1cf98d89546d..13b5f53e4840 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -675,11 +675,18 @@ static void init_object(struct kmem_cache *s, void > *object, u8 val) > { > u8 *p = object; > > +

RE: [PATCH v2] net: sctp: Don't use 64 kilobyte lookup table for four elements

2015-09-28 Thread David Laight
From: Eric Dumazet > Sent: 28 September 2015 15:27 > On Mon, 2015-09-28 at 14:12 +, David Laight wrote: > > From: Neil Horman > > > Sent: 28 September 2015 14:51 > > > On Mon, Sep 28, 2015 at 02:34:04PM +0200, Denys Vlasenko wrote: > > > > Seemingly innocuous sctp_trans_state_to_prio_map[]

Re: [PATCH 5/7] slub: support for bulk free with SLUB freelists

2015-09-28 Thread Jesper Dangaard Brouer
On Mon, 28 Sep 2015 10:16:49 -0500 (CDT) Christoph Lameter wrote: > On Mon, 28 Sep 2015, Jesper Dangaard Brouer wrote: > > > diff --git a/mm/slub.c b/mm/slub.c > > index 1cf98d89546d..13b5f53e4840 100644 > > --- a/mm/slub.c > > +++ b/mm/slub.c > > @@ -675,11 +675,18 @@ static

Re: [PATCH 7/7] slub: do prefetching in kmem_cache_alloc_bulk()

2015-09-28 Thread Jesper Dangaard Brouer
On Mon, 28 Sep 2015 07:53:16 -0700 Alexander Duyck wrote: > On 09/28/2015 05:26 AM, Jesper Dangaard Brouer wrote: > > For practical use-cases it is beneficial to prefetch the next freelist > > object in bulk allocation loop. > > > > Micro benchmarking show approx 1

Re: [PATCH] e1000: fix e1000e_disable_aspm_locked() warning

2015-09-28 Thread Dave Hansen
On 08/31/2015 02:26 PM, Dave Hansen wrote: > From: Dave Hansen > > I have a .config with CONFIG_PM disabled. I get the following whenever > compiling the e1000 driver: > > ...net/ethernet/intel/e1000e/netdev.c:6450:13: warning: > 'e1000e_disable_aspm_locked'

[net-next PATCH v2] netpoll: Drop budget parameter from NAPI polling call hierarchy

2015-09-28 Thread Alexander Duyck
For some reason we were carrying the budget value around between the various calls to napi->poll. If for example one of the drivers called had a bug in which it returned a non-zero value for work this could result in the budget value becoming negative. Rather than carry around a value of budget

RE: [PATCH v2] net: sctp: Don't use 64 kilobyte lookup table for four elements

2015-09-28 Thread David Laight
From: Neil Horman > Sent: 28 September 2015 14:51 > On Mon, Sep 28, 2015 at 02:34:04PM +0200, Denys Vlasenko wrote: > > Seemingly innocuous sctp_trans_state_to_prio_map[] array > > is way bigger than it looks, since > > "[SCTP_UNKNOWN] = 2" expands into "[0x] = 2" ! > > > > This patch replaces

Re: [PATCH v2] net: sctp: Don't use 64 kilobyte lookup table for four elements

2015-09-28 Thread Eric Dumazet
On Mon, 2015-09-28 at 14:12 +, David Laight wrote: > From: Neil Horman > > Sent: 28 September 2015 14:51 > > On Mon, Sep 28, 2015 at 02:34:04PM +0200, Denys Vlasenko wrote: > > > Seemingly innocuous sctp_trans_state_to_prio_map[] array > > > is way bigger than it looks, since > > >

RE: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread David Laight
From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: 28 September 2015 15:27 > On Mon, 2015-09-28 at 08:58 +, David Laight wrote: > > From: Rafael J. Wysocki > > > Sent: 27 September 2015 15:09 > > ... > > > > > Say you have three adjacent fields in a structure, x, y,

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread James Bottomley
On Mon, 2015-09-28 at 14:50 +, David Laight wrote: > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > > Sent: 28 September 2015 15:27 > > On Mon, 2015-09-28 at 08:58 +, David Laight wrote: > > > From: Rafael J. Wysocki > > > > Sent: 27 September 2015 15:09 > > > ... >

Re: [PATCH 6/7] slub: optimize bulk slowpath free by detached freelist

2015-09-28 Thread Christoph Lameter
Acked-by: Christoph Lameter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread David Laight
From: James Bottomley > Sent: 28 September 2015 16:12 > > > > The x86 cpus will also do 32bit wide rmw cycles for the 'bit' > > > > operations. > > > > > > That's different: it's an atomic RMW operation. The problem with the > > > alpha was that the operation wasn't atomic (meaning that it

Re: [PATCH 5/7] slub: support for bulk free with SLUB freelists

2015-09-28 Thread Christoph Lameter
On Mon, 28 Sep 2015, Jesper Dangaard Brouer wrote: > > Do you really need separate parameters for freelist_head? If you just want > > to deal with one object pass it as freelist_head and set cnt = 1? > > Yes, I need it. We need to know both the head and tail of the list to > splice it. Ok so

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread James Bottomley
On Mon, 2015-09-28 at 08:58 +, David Laight wrote: > From: Rafael J. Wysocki > > Sent: 27 September 2015 15:09 > ... > > > > Say you have three adjacent fields in a structure, x, y, z, each one > > > > byte long. > > > > Initially, all of them are equal to 0. > > > > > > > > CPU A writes 1 to

Re: [PATCH v2 RFC] 8139cp: Fix GSO MSS handling

2015-09-28 Thread David Woodhouse
On Sun, 2015-09-27 at 22:37 -0700, Tom Herbert wrote: > > Which drivers are doing this? It is up to the driver to determine > whether a particular packet being sent can have checksum offloaded to > the device. If it cannot offload the checksum it must call > skb_checksum_help. Not so. A driver

unregister_netdevice warnings when deleting netns

2015-09-28 Thread Anand Gurram
Hi, I am currently using kernel version 3.16.7 on a linux switch. While creating and destroying network namespaces I am observing below logs on the console "unregister_netdevice: waiting for lo to become free. Usage count = 1" Can you please suggest and provide instructions on how to debug this

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread Arnd Bergmann
On Sunday 27 September 2015 16:10:48 Rafael J. Wysocki wrote: > On Saturday, September 26, 2015 09:33:56 PM Arnd Bergmann wrote: > > On Saturday 26 September 2015 11:40:00 Viresh Kumar wrote: > > > On 25 September 2015 at 15:19, Rafael J. Wysocki > > > wrote: > > > > So if you

[PATCH bluetooth-next 4/4] mac802154: add comments for llsec issues

2015-09-28 Thread Alexander Aring
While doing a little test with the llsec implementation I saw these issues. We should move decryption and encruption somewhere else, otherwise while capturing with wireshark the mac header shows secuirty fields but the payload is plaintext. A complete other issue is what doing with HardMAC

[PATCH bluetooth-next 3/4] nl802154: add support for security layer

2015-09-28 Thread Alexander Aring
This patch adds support for accessing mac802154 llsec implementation over nl802154. I added for a new Kconfig entry to provide this functionality CONFIG_IEEE802154_NL802154_EXPERIMENTAL. This interface is still in development. It provides to change security parameters and add/del/dump entries of

[PATCH bluetooth-next 2/4] nl802154: use nla_get_le64 for get extended addr

2015-09-28 Thread Alexander Aring
This patch uses the nla_get_le64 function instead of doing a force converting to le64. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c

[PATCH bluetooth-next 1/4] netlink: add nla_get for le32 and le64

2015-09-28 Thread Alexander Aring
This patch adds missing inline wrappers for nla_get_le32 and nla_get_le64. The 802.15.4 MAC byteorder is little endian and we keep the byteorder for fields like address configuration in the same byteorder as it comes from the MAC layer. To provide these fields for nl802154 userspace applications,

[PATCH bluetooth-next 0/4] ieee802154: add llsec support over nl802154

2015-09-28 Thread Alexander Aring
Hi, this patch series will add llsec support for nl802154. What is "llsec"? The llsec (I suppose it stands for linklayer security) is part of the SoftMAC implementation of 802.15.4 "net/mac802154/llsec.c". The 802.15.4 standard describes an security mechanism over ACL's. The

  1   2   >