[PATCH v4 60/79] include/uapi/linux/atm_zatm.h: include linux/time.h

2015-10-14 Thread Mikko Rapeli
Fixes userspace compile error: error: field ‘real’ has incomplete type struct timeval real; /* real (wall-clock) time */ Signed-off-by: Mikko Rapeli --- include/uapi/linux/atm_zatm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/atm_zatm.h b/include/uapi/linux/atm_zat

[PATCH v4 57/79] include/uapi/linux/openvswitch.h: use __u32 from linux/types.h

2015-10-14 Thread Mikko Rapeli
Fixes userspace compiler error: error: unknown type name ‘uint32_t’ Signed-off-by: Mikko Rapeli --- include/uapi/linux/openvswitch.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h index 32e07d8..80c39a1

RE: [PATCH] netlink: trim skb to exact size to avoid MSG_TRUNC

2015-10-14 Thread Arad, Ronen
>-Original Message- >From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On >Behalf Of Thomas Graf >Sent: Wednesday, October 14, 2015 12:45 AM >To: Arad, Ronen >Cc: netdev@vger.kernel.org >Subject: Re: [PATCH] netlink: trim skb to exact size to avoid MSG_TRUNC > >On 1

[Question]: iproute2 extension for supporting lightweight tunnel

2015-10-14 Thread Liu, Mengke
Hi, I am trying to use the "lightweight tunnels" after building the Linux kernel from source with "Lightweight & flow based encapsulation" support. Can you tell me how to get iproute2 extension for supporting the following  command in commit log(commit ID e69724f32e62502a6e686eae36b7aadfeea60dc

[patch net] mlxsw: core: Fix race condition in __mlxsw_emad_transmit

2015-10-14 Thread Jiri Pirko
From: Ido Schimmel Under certain conditions EMAD responses can be returned from the device even before setting trans_active. This will cause the EMAD Rx listener to drop the EMAD response - as there are no active transactions - and timeouts will be generated. Fix this by setting trans_active bef

[PATCH v4 39/79] include/uapi/linux/if_pppox.h: include linux/if.h

2015-10-14 Thread Mikko Rapeli
Fixes userspace compilation error: error: ‘IFNAMSIZ’ undeclared here (not in a function) Signed-off-by: Mikko Rapeli --- include/uapi/linux/if_pppox.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/if_pppox.h b/include/uapi/linux/if_pppox.h index e128769..473c3c4 100644

[PATCH v4 44/79] include/uapi/linux/if_pppox.h: include linux/in.h and linux/in6.h

2015-10-14 Thread Mikko Rapeli
Fixes userspace compilation errors: error: field ‘addr’ has incomplete type struct sockaddr_in addr; /* IP address and port to send to */ error: field ‘addr’ has incomplete type struct sockaddr_in6 addr; /* IP address and port to send to */ Signed-off-by: Mikko Rapeli --- include/uapi/linux/

[PATCH v4 43/79] include/uapi/linux/if_pppol2tp.h: include linux/in.h and linux/in6.h

2015-10-14 Thread Mikko Rapeli
Fixes userspace compilation errors like: error: field ‘addr’ has incomplete type struct sockaddr_in addr; /* IP address and port to send to */ ^ error: field ‘addr’ has incomplete type struct sockaddr_in6 addr; /* IP address and port to send to */ Signed-off-by: Mikko Rapeli

[PATCH v4 40/79] include/uapi/linux/if_tunnel.h: include linux/if.h, linux/ip.h and linux/in6.h

2015-10-14 Thread Mikko Rapeli
Fixes userspace compilation errors like: error: field ‘iph’ has incomplete type error: field ‘prefix’ has incomplete type Signed-off-by: Mikko Rapeli --- include/uapi/linux/if_tunnel.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux/if_tunnel.h b/include/uapi/linux/if_

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-14 Thread Richard Cochran
On Wed, Oct 14, 2015 at 06:57:33PM -0700, Christopher Hall wrote: > >>+#define SHADOW_HISTORY_DEPTH 7 > > > >And that number is 7 because? > > Due to power of 2 it will be 8 instead. As above the useful history is 8-2*1 > ms (1 ms is the minimum jiffy length). Array size 4 would not be enough > h

Re: [patch net-next v5 3/8] switchdev: allow caller to explicitly request attr_set as deferred

2015-10-14 Thread Jiri Pirko
Thu, Oct 15, 2015 at 06:34:01AM CEST, sfel...@gmail.com wrote: >On Wed, Oct 14, 2015 at 10:40 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Caller should know if he can call attr_set directly (when holding RTNL) >> or if he has to defer the att_set processing for later. >> >> This also allows d

RE: [PATCH net-next v2] netlink: Rightsize IFLA_AF_SPEC size calculation

2015-10-14 Thread Arad, Ronen
>-Original Message- >From: David Miller [mailto:da...@davemloft.net] >Sent: Wednesday, October 14, 2015 7:24 PM >To: Arad, Ronen >Cc: netdev@vger.kernel.org >Subject: Re: [PATCH net-next v2] netlink: Rightsize IFLA_AF_SPEC size >calculation > >From: Ronen Arad >Date: Wed, 14 Oct 2015 08:

[PATCH net-next v3] netlink: Rightsize IFLA_AF_SPEC size calculation

2015-10-14 Thread Ronen Arad
if_nlmsg_size() overestimates the minimum allocation size of netlink dump request (when called from rtnl_calcit()) or the size of the message (when called from rtnl_getlink()). This is because ext_filter_mask is not supported by rtnl_link_get_af_size() and rtnl_link_get_size(). The over-estimation

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-14 Thread Richard Cochran
On Wed, Oct 14, 2015 at 07:34:03PM -0700, Christopher Hall wrote: > I hope this is helpful. Thanks. So the DSP does not produce or consume system time stamps. Fine. Still I fail to understand why you need the system time. Thomas seems to say that there are *other* applications that will want to t

Re: [patch net-next v5 3/8] switchdev: allow caller to explicitly request attr_set as deferred

2015-10-14 Thread Scott Feldman
On Wed, Oct 14, 2015 at 10:40 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Caller should know if he can call attr_set directly (when holding RTNL) > or if he has to defer the att_set processing for later. > > This also allows drivers to sleep inside attr_set and report operation > status back to

Re: [Patch net-next 2/4] net_sched: update hierarchical backlog too

2015-10-14 Thread Cong Wang
On Wed, Oct 14, 2015 at 5:11 AM, Jamal Hadi Salim wrote: > On 10/12/15 14:38, Cong Wang wrote: >> >> When the bottom qdisc decides to, for example, drop some packet, >> it calls qdisc_tree_decrease_qlen() to update the queue length >> for all its ancestors, we need to update the backlog too to >>

[PATCH net-next] net: hisilicon: fixes a bug when using ethtool -S

2015-10-14 Thread yankejian
From: lipeng this patch fixes a bug in hns driver. when we want to get statistic info by using ethtool -S, it shows us there are 3 wrong counters info. because the strings related to the registers are wrong. it needs to modify the strings which give us wrong info. Signed-off-by: lipeng Signed-o

Re: [Patch net-next 3/4] sch_htb: update backlog as well

2015-10-14 Thread Cong Wang
On Wed, Oct 14, 2015 at 5:25 AM, Jamal Hadi Salim wrote: > On 10/12/15 14:38, Cong Wang wrote: >> >> It is odd to see qlen!=0 but backlog==0, for a real example: >> > > Backlog is a transient stat so a lot of times it should be 0. Only when > the CPU is sending faster than the link can handle shou

Re: [Patch net-next 1/4] net_sched: introduce qdisc_replace() helper

2015-10-14 Thread Cong Wang
On Wed, Oct 14, 2015 at 4:56 AM, Jamal Hadi Salim wrote: > On 10/12/15 14:38, Cong Wang wrote: >> >> Remove nearly duplicated code and prepare for the following patch. >> > > > Cong - like Dave, I dont see equivalence in some of these > changes. > Example not sure how the qfq grafting invocation o

Re: [Patch net-next 1/4] net_sched: introduce qdisc_replace() helper

2015-10-14 Thread Cong Wang
On Tue, Oct 13, 2015 at 6:54 PM, David Miller wrote: > From: Cong Wang > Date: Mon, 12 Oct 2015 11:38:00 -0700 > >> Remove nearly duplicated code and prepare for the following patch. >> >> Cc: Jamal Hadi Salim >> Signed-off-by: Cong Wang > > This isn't an equivalent transformation: > >> +static

Re: [PATCH] ipconfig: send Client-identifier in DHCP requests

2015-10-14 Thread Li RongQing
On Thu, Oct 15, 2015 at 11:27 AM, kbuild test robot wrote: > Hi Li, > > [auto build test WARNING on net/master -- if it's inappropriate base, please > suggest rules for selecting the more suitable base] > > url: > https://github.com/0day-ci/linux/commits/roy-qing-li-gmail-com/ipconfig-send-Cl

Re: [PATCH] ipconfig: send Client-identifier in DHCP requests

2015-10-14 Thread kbuild test robot
Hi Li, [auto build test WARNING on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/roy-qing-li-gmail-com/ipconfig-send-Client-identifier-in-DHCP-requests/20151015-105553 config: parisc-c3000_de

Re: [PATCH] ipconfig: send Client-identifier in DHCP requests

2015-10-14 Thread kbuild test robot
Hi Li, [auto build test WARNING on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/roy-qing-li-gmail-com/ipconfig-send-Client-identifier-in-DHCP-requests/20151015-105553 config: parisc-defconfi

Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging

2015-10-14 Thread Guenter Roeck
On 10/14/2015 07:52 PM, Andrew Lunn wrote: On Wed, Oct 14, 2015 at 09:28:55PM -0400, Vivien Didelot wrote: On Oct. Thursday 15 (42) 12:46 AM, Andrew Lunn wrote: On Sun, Oct 11, 2015 at 06:08:34PM -0400, Vivien Didelot wrote: DSA and its drivers currently hook the NETDEV_CHANGEUPPER net_device

Re: [PATCH net-next] switchdev: enforce no pvid flag in vlan ranges

2015-10-14 Thread Scott Feldman
On Wed, Oct 14, 2015 at 10:42 AM, Ido Schimmel wrote: > Wed, Oct 14, 2015 at 08:14:24PM IDT, sfel...@gmail.com wrote: >>On Wed, Oct 14, 2015 at 8:25 AM, Vivien Didelot >> wrote: >>> On Oct. Wednesday 14 (42) 09:14 AM, Ido Schimmel wrote: Tue, Oct 13, 2015 at 05:32:26PM IDT, vivien.dide...@sav

Re: [PATCH v2 1/3] unix: fix use-after-free in unix_dgram_poll()

2015-10-14 Thread Jason Baron
> > X-Signed-Off-By: Rainer Weikusat > Hi, So the patches I've posted and yours both use the idea of a relaying the remote peer wakeup via callbacks that are internal to the net/unix, such that we avoid exposing the remote peer wakeup to the external poll()/select()/epoll(). They differ i

[PATCH] ipconfig: send Client-identifier in DHCP requests

2015-10-14 Thread roy . qing . li
From: Li RongQing A dhcp server may provide parameters to a client from a pool of IP addresses and using a shared rootfs, or provide a specific set of parameters for a specific client, usually using the MAC address to identify each client individually. The dhcp protocol also specifies a client-id

Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging

2015-10-14 Thread Andrew Lunn
On Wed, Oct 14, 2015 at 09:28:55PM -0400, Vivien Didelot wrote: > On Oct. Thursday 15 (42) 12:46 AM, Andrew Lunn wrote: > > On Sun, Oct 11, 2015 at 06:08:34PM -0400, Vivien Didelot wrote: > > > DSA and its drivers currently hook the NETDEV_CHANGEUPPER net_device > > > event in > > > order to confi

Re: [PATCH v4 3/4] Add PTP_SYS_OFFSET_PRECISE for driver crosstimestamping

2015-10-14 Thread Christopher Hall
On Tue, 13 Oct 2015 06:59:26 -0700, Richard Cochran wrote: On Mon, Oct 12, 2015 at 11:45:21AM -0700, Christopher S. Hall wrote: +struct ptp_sys_offset_precise { + unsigned int rsv[4];/* Reserved for future use. */ + struct ptp_clock_time dev; + struct ptp_clock_time sy

Re: [PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

2015-10-14 Thread David Ahern
On 10/14/15 7:06 PM, David Miller wrote: From: David Ahern Date: Wed, 14 Oct 2015 10:09:59 -0600 This latest patch makes IPv6 static addresses on par with IPv4, including error paths. I don't agree with ipv4's behavior... and just because ipv4 does something poorly doesn't mean we get a free

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-14 Thread Christopher Hall
Richard, On Tue, 13 Oct 2015 14:12:24 -0700, Richard Cochran wrote: On Tue, Oct 13, 2015 at 09:15:51PM +0200, Thomas Gleixner wrote: Can we at least have a explanation of how the firmware operates? How are (ART,sys) pairs are generated, and how they are supposed to get into the DSP? I'l

[PATCH 1/1] xen-netfront: update num_queues to real created

2015-10-14 Thread Joe Jin
Sometimes xennet_create_queues() may failed to created all requested queues, we need to update num_queues to real created to avoid NULL pointer dereference. Signed-off-by: Joe Jin Cc: Wei Liu Cc: Ian Campbell Cc: David S. Miller --- drivers/net/xen-netfront.c |9 ++--- 1 files changed

Re: [PATCH V2 2/2] bpf: control a set of perf events by creating a new ioctl PERF_EVENT_IOC_SET_ENABLER

2015-10-14 Thread xiakaixu
于 2015/10/15 5:28, Alexei Starovoitov 写道: > On 10/14/15 5:37 AM, Kaixu Xia wrote: >> +event->p_sample_disable = &enabler_event->sample_disable; > > I don't like it as a concept and it's buggy implementation. > What happens here when enabler is alive, but other event is destroyed? > >> --- a/k

Re: [PATCH net-next v2] netlink: Rightsize IFLA_AF_SPEC size calculation

2015-10-14 Thread David Miller
From: Ronen Arad Date: Wed, 14 Oct 2015 08:51:28 -0700 > @@ -900,7 +901,7 @@ static noinline size_t if_nlmsg_size(const struct > net_device *dev, > + rtnl_vfinfo_size(dev, ext_filter_mask) /* IFLA_VFINFO_LIST */ > + rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS

Re: [PATCH net-next] drivers/net: get rid of unnecessary initializations in .get_drvinfo()

2015-10-14 Thread David Miller
From: Ivan Vecera Date: Wed, 14 Oct 2015 18:27:52 +0200 > Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len, > eedump_len & regdump_len fields in their .get_drvinfo() ethtool op. > It's not necessary as these fields is filled in ethtool_get_drvinfo(). > > Signed-off-by: Ivan

Re: [PATCH net-next V1 0/4] Mellanox driver update, Oct 14 2015

2015-10-14 Thread David Miller
From: Or Gerlitz Date: Wed, 14 Oct 2015 17:43:44 +0300 > Hi Dave, > > This series contains two more patches from Eli, patch from Majd > to support PCI error handlers and a fix from Jack to mlx4 VFs > when probed without a provisioned mac address. > > The patch set applied on top of net-next com

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-14 Thread Christopher Hall
Thomas, On Tue, 13 Oct 2015 12:42:52 -0700, Thomas Gleixner wrote: On Mon, 12 Oct 2015, Christopher S. Hall wrote: audio. This wants to be a seperate patch, really. OK. This makes sense, I'll do this the next time. +/* This needs to be 3 or greater for backtracking to be useful */ Wh

Re: [PATCH net v2 1/1] tipc: move fragment importance field to new header position

2015-10-14 Thread David Miller
From: Jon Maloy Date: Wed, 14 Oct 2015 09:23:18 -0400 > In commit e3eea1eb47a ("tipc: clean up handling of message priorities") > we introduced a field in the packet header for keeping track of the > priority of fragments, since this value is not present in the specified > protocol header. Since

Re: [PATCH net-next] tcp/dccp: fix potential NULL deref in __inet_inherit_port()

2015-10-14 Thread David Miller
From: Eric Dumazet Date: Wed, 14 Oct 2015 05:58:38 -0700 > From: Eric Dumazet > > As we no longer hold listener lock in fast path, it is possible that a > child is created right after listener freed its bound port, if a close() > is done while incoming packets are processed. > > __inet_inherit

Re: [PATCH net-next] tcp: avoid spurious SYN flood detection at listen() time

2015-10-14 Thread David Miller
From: Eric Dumazet Date: Wed, 14 Oct 2015 06:16:49 -0700 > From: Eric Dumazet > > At listen() time, there is a small window where listener is visible with > a zero backlog, triggering a spurious "Possible SYN flooding on port" > message. > > Nothing prevents us from setting the correct backlog

Captain Kelvin Ken Miller

2015-10-14 Thread
Am Captain Kelvin Ken Miller i am with the us army in Camp Abu Naji / FOB Garry Owen (Al Amarah)I need you assistant to move some funds out of Iraq. Kindly respond for more details. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.ker

Re: [PATCH] net: phy: aquantia/teranetics: Convert to use module_phy_driver macro

2015-10-14 Thread David Miller
From: Axel Lin Date: Wed, 14 Oct 2015 18:30:48 +0800 > Use module_phy_driver macro to simplify the code a bit. > > Signed-off-by: Axel Lin Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org Mor

[PATCH v3 1/1] eventfd: implementation of EFD_MASK flag

2015-10-14 Thread Damian Hobson-Garcia
From: Martin Sustrik When implementing network protocols in user space, one has to implement fake file descriptors to represent the sockets for the protocol. Polling on such fake file descriptors is a problem (poll/select/epoll accept only true file descriptors) and forces protocol implementers

Re: [PATCH] ethtool: Use kcalloc instead of kmalloc for ethtool_get_strings

2015-10-14 Thread David Miller
From: Joe Perches Date: Wed, 14 Oct 2015 01:09:40 -0700 > It seems that kernel memory can leak into userspace by a > kmalloc, ethtool_get_strings, then copy_to_user sequence. > > Avoid this by using kcalloc to zero fill the copied buffer. > > Signed-off-by: Joe Perches Applied and queued up f

[PATCH v3 0/1] Generalize poll events from eventfd

2015-10-14 Thread Damian Hobson-Garcia
Using eventfd user space can generate POLLIN/POLLOUT events but some applications may want to generate POLLPRI/POLLERR events as well. This patch submission aims to generalize the events generated by an eventfd. This is a resubmission of a patch from Feb 2013[1]. The original discussion trailed off

Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging

2015-10-14 Thread Florian Fainelli
On 14/10/15 18:28, Vivien Didelot wrote: > On Oct. Thursday 15 (42) 12:46 AM, Andrew Lunn wrote: >> On Sun, Oct 11, 2015 at 06:08:34PM -0400, Vivien Didelot wrote: >>> DSA and its drivers currently hook the NETDEV_CHANGEUPPER net_device event >>> in >>> order to configure the VLAN map of every por

Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging

2015-10-14 Thread Vivien Didelot
On Oct. Thursday 15 (42) 12:46 AM, Andrew Lunn wrote: > On Sun, Oct 11, 2015 at 06:08:34PM -0400, Vivien Didelot wrote: > > DSA and its drivers currently hook the NETDEV_CHANGEUPPER net_device event > > in > > order to configure the VLAN map of every port. > > > > This VLAN map is a feature of th

Re: [PATCH net-next v6 01/10] qed: Add module with basic common support

2015-10-14 Thread David Miller
From: Yuval Mintz Date: Wed, 14 Oct 2015 09:24:05 +0300 > +int qed_qm_pf_rt_init(struct qed_hwfn*p_hwfn, > + struct qed_ptt*p_ptt, > + u8port_id, > + u8

RE: [PATCH net-next 0/4] Rightsize IFLA_AF_SPEC size calculation

2015-10-14 Thread Arad, Ronen
>-Original Message- >From: David Miller [mailto:da...@davemloft.net] >Sent: Wednesday, October 14, 2015 6:44 PM >To: Arad, Ronen >Cc: netdev@vger.kernel.org >Subject: Re: [PATCH net-next 0/4] Rightsize IFLA_AF_SPEC size calculation > >From: Ronen Arad >Date: Tue, 13 Oct 2015 22:58:30 -07

Re: [PATCH net-next 0/4] Rightsize IFLA_AF_SPEC size calculation

2015-10-14 Thread David Miller
From: Ronen Arad Date: Tue, 13 Oct 2015 22:58:30 -0700 > if_nlmsg_size() overestimates the minimum allocation size of netlink dump > request (when called from rtnl_calcit()) or the size of the message (when > called > from rtnl_getlink()). This is because ext_filter_mask is not supported by > rt

Re: [PATCH net-next] net: hisilicon net: fix a bug about led

2015-10-14 Thread David Miller
From: yankejian Date: Wed, 14 Oct 2015 10:28:57 +0800 > From: lipeng > > this patch fixes a bug in hns driver. the link led is on at the beginning, > but at this time the ethernet port is on down status. it needs to reset > the led status on init sequence. > > Signed-off-by: lipeng > Signed-o

Re: [PATCH net-next] cxgb4i: Increased the value of MAX_IMM_TX_PKT_LEN from 128 to 256 bytes

2015-10-14 Thread David Miller
From: Karen Xie Date: Tue, 13 Oct 2015 17:13:59 -0700 > This helps improving the latency of small packets. > > Signed-off-by: Rakesh Ranjan > Signed-off-by: Karen Xie Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vg

Re: [PATCH 1/1] net: phy: bcm-phy-lib: Fix module license issue

2015-10-14 Thread David Miller
From: Arun Parameswaran Date: Tue, 13 Oct 2015 13:40:12 -0700 > The 'bcm-phy-lib.c', added as a part of the commit > "net: phy: Add Broadcom phy library for common interfaces" > was missing the module license. This was causing an issue > when the library is built as a module; "module license > 'u

Re: [PATCH RESEND 1/2] ixgb:Remove reducant error path after call to ixgb_sw_init in the function ixgb_probe

2015-10-14 Thread Jeff Kirsher
On Wed, 2015-10-14 at 18:57 -0400, Nicholas Krause wrote: > This removes the reducant error path and now no longer used goto > label err_sw_init after the call to ixgb_probe in the function > ixgb_sw_init after calling this function due to it always returning > zero as it is guarantee to run succe

Re: pull-request: can-next 2015-09-17

2015-10-14 Thread David Miller
From: Marc Kleine-Budde Date: Tue, 13 Oct 2015 18:08:01 +0200 > this is a pull request of 4 patches for net-next/master. > > Two patches are by Gerhard Bertelsmann, fixing some problems in the > sun4i driver. The patch by Arnd Bergmann stops using timeval for the > CAN broadcast manager. The las

Re: pull-request: mac80211 2015-10-13

2015-10-14 Thread David Miller
From: Johannes Berg Date: Tue, 13 Oct 2015 10:59:47 +0200 > There are just two small fixes, but I didn't really want to wait since > I have nothing else pending. > > Let me know if there's any problem. Pulled, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the b

linux-next: manual merge of the net-next tree with the net tree

2015-10-14 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/switchdev/switchdev.c between commit: 87aaf2caed84 ("switchdev: check if the vlan id is in the proper vlan range") from the net tree and commits: 7ea6eb3f56f4 ("switchdev: introduce transaction item queue for a

Exporting some of sysctls from net/ipv4 and net/core to a net namespace

2015-10-14 Thread Thomas Tanaka
Hi, It seems due to the following patch set in Linux v3.5 [PATCH net-next 00/19] net: Sysctl simplications and enhancements http://comments.gmane.org/gmane.linux.network/227965 some of the previously visible sysctls variables in net/core and net/ipv4 has become invisible. Is there a possibility t

Re: [PATCH net-next v5] net: ipv6: Make address flushing on ifdown optional

2015-10-14 Thread David Miller
From: David Ahern Date: Wed, 14 Oct 2015 10:09:59 -0600 > This latest patch makes IPv6 static addresses on par with IPv4, > including error paths. I don't agree with ipv4's behavior... and just because ipv4 does something poorly doesn't mean we get a free pass to replicate that lazyness in ipv6.

Re: [PATCH net] openvswitch: Scrub skb between namespaces

2015-10-14 Thread Pravin Shelar
On Wed, Oct 14, 2015 at 11:10 AM, Joe Stringer wrote: > If OVS receives a packet from another namespace, then the packet should > be scrubbed. However, people have already begun to rely on the behaviour > that skb->mark is preserved across namespaces, so retain this one field. > > This is mainly t

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-14 Thread Kosuke Tatsukawa
J. Bruce Fields wrote: > On Wed, Oct 14, 2015 at 03:57:13AM +, Kosuke Tatsukawa wrote: >> J. Bruce Fields wrote: >> > On Mon, Oct 12, 2015 at 10:41:06AM +, Kosuke Tatsukawa wrote: >> >> J. Bruce Fields wrote: >> >> > On Fri, Oct 09, 2015 at 06:29:44AM +, Kosuke Tatsukawa wrote: >> >> >>

Re: [PATCH net-next] switchdev: enforce no pvid flag in vlan ranges

2015-10-14 Thread Vivien Didelot
On Oct. Wednesday 14 (42) 03:08 PM, Florian Fainelli wrote: > On 14/10/15 11:51, Vivien Didelot wrote: > > On Oct. Wednesday 14 (42) 08:42 PM, Ido Schimmel wrote: > >> Wed, Oct 14, 2015 at 08:14:24PM IDT, sfel...@gmail.com wrote: > >>> On Wed, Oct 14, 2015 at 8:25 AM, Vivien Didelot > >>> wrote: >

[PATCH net-next] net: Fix suspicious RCU usage in fib_rebalance

2015-10-14 Thread David Ahern
This command: ip route add 192.168.1.0/24 nexthop via 10.2.1.5 dev eth1 nexthop via 10.2.2.5 dev eth2 generated this suspicious RCU usage message: [ 63.249262] [ 63.249939] === [ 63.251571] [ INFO: suspicious RCU usage. ] [ 63.253250] 4.3.0-rc3+ #298 Not tainted [ 6

Re: NULL pointer dereference in rt6_get_cookie()

2015-10-14 Thread Martin KaFai Lau
On Thu, Oct 15, 2015 at 12:34:13AM +0200, Phil Sutter wrote: > Hi Martin, > > On Tue, Oct 13, 2015 at 11:14:21PM -0700, Martin KaFai Lau wrote: > > On Tue, Oct 13, 2015 at 09:26:41PM +0200, Phil Sutter wrote: > > > I have backed up the rt pointer at top of the function and restored it > > > before

Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging

2015-10-14 Thread Andrew Lunn
On Sun, Oct 11, 2015 at 06:08:34PM -0400, Vivien Didelot wrote: > DSA and its drivers currently hook the NETDEV_CHANGEUPPER net_device event in > order to configure the VLAN map of every port. > > This VLAN map is a feature of these switch chips to hardcode and restrict > which > output ports a g

Re: NULL pointer dereference in rt6_get_cookie()

2015-10-14 Thread Phil Sutter
Hi Martin, On Tue, Oct 13, 2015 at 11:14:21PM -0700, Martin KaFai Lau wrote: > On Tue, Oct 13, 2015 at 09:26:41PM +0200, Phil Sutter wrote: > > I have backed up the rt pointer at top of the function and restored it > > before pr_err, this is the output: > > > > | rt6i_dst:2001:4dd0:ff3b:13::/64 rt

[PATCH nf-next 5/6] netfilter-ipv4: code indentation

2015-10-14 Thread Ian Morris
Use tabs instead of spaces to indent code. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv4/netfilter/ip_tables.c| 6 +++--- net/ipv4/netfilter/ipt_SYNPROXY.c | 2 +- net/ipv4/netfilter/iptable_security.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)

[PATCH nf-next 4/6] netfilter-ipv4: function definition layout

2015-10-14 Thread Ian Morris
Use tabs instead of spaces to indent second line of parameters in function definitions. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv4/netfilter/arp_tables.c | 6 +++--- net/ipv4/netfilter/ip_tables.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --

[PATCH nf-next 6/6] netfilter-ipv4: whitespace around operators

2015-10-14 Thread Ian Morris
This patch cleanses whitespace around arithmetical operators. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv4/netfilter/ipt_CLUSTERIP.c | 8 net/ipv4/netfilter/ipt_ah.c| 2 +- net/ipv4/netfilter/nf_nat_snmp_basic.c | 2 +- 3 files changed, 6 inser

[PATCH nf-next 0/6] coding style improvements: netfilter-ipv4

2015-10-14 Thread Ian Morris
This series of patches improves the coding style of the netfilter-ipv4 code by addressing some issues detected by checkpatch. The changes were previously submitted as part of a larger monolithic patch but on advice from Pablo, these are being re-sent in smaller, more structured batches. Ian Mo

[PATCH nf-next 2/6] netfilter-ipv4: label placement

2015-10-14 Thread Ian Morris
Whitespace cleansing: Labels should not be indented. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv4/netfilter/arp_tables.c | 2 +- net/ipv4/netfilter/ip_tables.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/netfilter/arp_tables.c b/net

[PATCH nf-next 1/6] netfilter-ipv4: Line layout whitespace fixes

2015-10-14 Thread Ian Morris
Cleanses some whitespace issues by removing a leading space before a tab. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv4/netfilter/ipt_ECN.c | 2 +- net/ipv4/netfilter/nf_nat_pptp.c | 2 +- net/ipv4/netfilter/nf_nat_snmp_basic.c | 2 +- 3 files changed, 3

[PATCH nf-next 3/6] netfilter-ipv4: ternary operator layout

2015-10-14 Thread Ian Morris
Correct whitespace layout of ternary operators in the netfilter-ipv4 code. No changes detected by objdiff. Signed-off-by: Ian Morris --- net/ipv4/netfilter/arp_tables.c | 4 ++-- net/ipv4/netfilter/ip_tables.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/net/ipv4/

[PATCH net 1/1] via-rhine: fix VLAN receive handling regression.

2015-10-14 Thread Francois Romieu
From: Andrej Ota Because eth_type_trans() consumes ethernet header worth of bytes, a call to read TCI from end of packet using rhine_rx_vlan_tag() no longer works as it's reading from an invalid offset. Tested to be working on PCEngines Alix board. Fixes: 810f19bcb862 ("via-rhine: add consisten

Re: [PATCH net-next] switchdev: enforce no pvid flag in vlan ranges

2015-10-14 Thread Florian Fainelli
On 14/10/15 11:51, Vivien Didelot wrote: > On Oct. Wednesday 14 (42) 08:42 PM, Ido Schimmel wrote: >> Wed, Oct 14, 2015 at 08:14:24PM IDT, sfel...@gmail.com wrote: >>> On Wed, Oct 14, 2015 at 8:25 AM, Vivien Didelot >>> wrote: On Oct. Wednesday 14 (42) 09:14 AM, Ido Schimmel wrote: > Tue,

Re: [PATCH net-next] bpf: Need to call bpf_prog_uncharge_memlock from bpf_prog_put

2015-10-14 Thread Alexei Starovoitov
On 10/14/15 2:40 PM, Tom Herbert wrote: Currently, is only called from __prog_put_rcu in the bpf_prog_release path. Need this to call this from bpf_prog_put also to get correct accounting. Fixes: commit aaac3ba95e4c8b49 ("bpf: charge user for creation of BPF maps and programs") Signed-off-by: T

[PATCH net-next] bpf: Need to call bpf_prog_uncharge_memlock from bpf_prog_put

2015-10-14 Thread Tom Herbert
Currently, is only called from __prog_put_rcu in the bpf_prog_release path. Need this to call this from bpf_prog_put also to get correct accounting. Fixes: commit aaac3ba95e4c8b49 ("bpf: charge user for creation of BPF maps and programs") Signed-off-by: Tom Herbert --- kernel/bpf/syscall.c | 1

Re: [PATCH V2 2/2] bpf: control a set of perf events by creating a new ioctl PERF_EVENT_IOC_SET_ENABLER

2015-10-14 Thread Alexei Starovoitov
On 10/14/15 5:37 AM, Kaixu Xia wrote: + event->p_sample_disable = &enabler_event->sample_disable; I don't like it as a concept and it's buggy implementation. What happens here when enabler is alive, but other event is destroyed? --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trac

Re: [RFC PATCH] RDS: convert bind hash table to re-sizable hashtable

2015-10-14 Thread santosh.shilim...@oracle.com
On 10/14/15 2:15 PM, Santosh Shilimkar wrote: From: Santosh Shilimkar To further improve the RDS connection scalabilty on massive systems where number of sockets grows into tens of thousands of sockets, there is a need of larger bind hashtable. Pre-allocated 8K or 16K table is not very flexibl

Re: [PATCH V2 1/2] bpf: control the trace data output on current cpu when perf sampling

2015-10-14 Thread Alexei Starovoitov
On 10/14/15 5:37 AM, Kaixu Xia wrote: This patch adds the flag sample_disable to control the trace data output process when perf sampling. By setting this flag and integrating with ebpf, we can control the data output process and get the samples we are most interested in. The bpf helper bpf_perf

[RFC PATCH] RDS: convert bind hash table to re-sizable hashtable

2015-10-14 Thread Santosh Shilimkar
From: Santosh Shilimkar To further improve the RDS connection scalabilty on massive systems where number of sockets grows into tens of thousands of sockets, there is a need of larger bind hashtable. Pre-allocated 8K or 16K table is not very flexible in terms of memory utilisation. The rhashtable

Re: [PATCH] ethtool: Use kcalloc instead of kmalloc for ethtool_get_strings

2015-10-14 Thread Ben Hutchings
On Wed, 2015-10-14 at 01:09 -0700, Joe Perches wrote: > It seems that kernel memory can leak into userspace by a > kmalloc, ethtool_get_strings, then copy_to_user sequence. > > Avoid this by using kcalloc to zero fill the copied buffer. > > Signed-off-by: Joe Perches > --- > > stable too... >

Re: [PATCH net-next 3/3] tcp/dccp: fix race at listener dismantle phase

2015-10-14 Thread kbuild test robot
Hi Eric, [auto build test WARNING on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/tcp-dccp-make-our-listener-code-more-robust/20151015-020006 reproduce: # apt-get i

Re: [PATCH net-next] route: fib_validate_source remove the <= RT_SCOPE_HOST test

2015-10-14 Thread Julian Anastasov
Hello, On Thu, 15 Oct 2015, lucien xin wrote: > yeah, I don't understand why err > 0 is necessary to set IPSKB_DOREDIRECT > to send redirects. > FIB_RES_NH(res).nh_scope >= RT_SCOPE_HOST, what's that mean? It tells us that packet comes from remote address that we can reach direc

Re: [patch net-next v5 2/8] switchdev: make struct switchdev_attr parameter const for attr_set calls

2015-10-14 Thread Vivien Didelot
On Oct. Wednesday 14 (42) 07:40 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Signed-off-by: Jiri Pirko Reviewed-by: Vivien Didelot -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kern

Re: [PATCH net-next] switchdev: enforce no pvid flag in vlan ranges

2015-10-14 Thread Vivien Didelot
On Oct. Wednesday 14 (42) 08:42 PM, Ido Schimmel wrote: > Wed, Oct 14, 2015 at 08:14:24PM IDT, sfel...@gmail.com wrote: > >On Wed, Oct 14, 2015 at 8:25 AM, Vivien Didelot > > wrote: > >> On Oct. Wednesday 14 (42) 09:14 AM, Ido Schimmel wrote: > >>> Tue, Oct 13, 2015 at 05:32:26PM IDT, vivien.dide..

Re: [PATCH net-next v2 6/6] net: dsa: remove port_fdb_getnext

2015-10-14 Thread Florian Fainelli
On 13/10/15 09:46, Vivien Didelot wrote: > No driver implements port_fdb_getnext anymore, and port_fdb_dump is > preferred anyway, so remove this function from DSA. > > Signed-off-by: Vivien Didelot Acked-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH net-next v2 1/6] net: dsa: add port_fdb_dump function

2015-10-14 Thread Florian Fainelli
On 13/10/15 09:46, Vivien Didelot wrote: > Not all switch chips support a Get Next operation to iterate on its FDB. > So add a more simple port_fdb_dump function for them. > > Signed-off-by: Vivien Didelot Acked-by: Florian Fainelli -- Florian -- To unsubscribe from this list: send the line "u

[PATCH v2 net-next 2/3] tcp/dccp: add inet_csk_reqsk_queue_drop_and_put() helper

2015-10-14 Thread Eric Dumazet
Let's reduce the confusion about inet_csk_reqsk_queue_drop() : In many cases we also need to release reference on request socket, so add a helper to do this, reducing code size and complexity. Fixes: 4bdc3d66147b ("tcp/dccp: fix behavior of stale SYN_RECV request sockets") Signed-off-by: Eric Duma

[PATCH v2 net-next 3/3] tcp/dccp: fix race at listener dismantle phase

2015-10-14 Thread Eric Dumazet
Under stress, a close() on a listener can trigger the WARN_ON(sk->sk_ack_backlog) in inet_csk_listen_stop() We need to test if listener is still active before queueing a child in inet_csk_reqsk_queue_add() Create a common inet_child_forget() helper, and use it from inet_csk_reqsk_queue_add() and

[PATCH v2 net-next 1/3] Revert "inet: fix double request socket freeing"

2015-10-14 Thread Eric Dumazet
This reverts commit c69736696cf3742b37d850289dc0d7ead177bb14. At the time of above commit, tcp_req_err() and dccp_req_err() were dead code, as SYN_RECV request sockets were not yet in ehash table. Real bug was fixed later in a different commit. We need to revert to not leak a refcount on request

[PATCH v2 net-next 0/3] tcp/dccp: make our listener code more robust

2015-10-14 Thread Eric Dumazet
This patch series addresses request sockets leaks and listener dismantle phase. This survives a stress test with listeners being added/removed quite randomly. Eric Dumazet (3): Revert "inet: fix double request socket freeing" tcp/dccp: add inet_csk_reqsk_queue_drop_and_put() helper tcp/dccp:

Re: [PATCH net-next 3/3] tcp/dccp: fix race at listener dismantle phase

2015-10-14 Thread Eric Dumazet
On Wed, 2015-10-14 at 10:58 -0700, Eric Dumazet wrote: ... > diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c > index a5a1b54915e5..38b7ef8b0b78 100644 > --- a/net/ipv4/inet_connection_sock.c > +++ b/net/ipv4/inet_connection_sock.c > @@ -740,7 +740,7 @@ int inet_cs

[PATCH net 1/3] openvswitch: Reject ct_state masks for unknown bits

2015-10-14 Thread Joe Stringer
Currently, 0-bits are generated in ct_state where the bit position is undefined, and matches are accepted on these bit-positions. If userspace requests to match the 0-value for this bit then it may expect only a subset of traffic to match this value, whereas currently all packets will have this bit

[PATCH net 3/3] openvswitch: Serialize nested ct actions if provided

2015-10-14 Thread Joe Stringer
If userspace provides a ct action with no nested mark or label, then the storage for these fields is zeroed. Later when actions are requested, such zeroed fields are serialized even though userspace didn't originally specify them. Fix the behaviour by ensuring that no action is serialized in this c

[PATCH net] openvswitch: Scrub skb between namespaces

2015-10-14 Thread Joe Stringer
If OVS receives a packet from another namespace, then the packet should be scrubbed. However, people have already begun to rely on the behaviour that skb->mark is preserved across namespaces, so retain this one field. This is mainly to address information leakage between namespaces when using OVS

[PATCH net 2/3] openvswitch: Treat IP_CT_RELATED as new

2015-10-14 Thread Joe Stringer
New, related connections are marked as such as part of ovs_ct_lookup(), but they are not marked as "new" if the commit flag is used. Make this consistent by treating IP_CT_RELATED as new as well. Reported-by: Jarno Rajahalme Signed-off-by: Joe Stringer --- net/openvswitch/conntrack.c | 2 ++ 1

Re: [PATCH net-next] drivers/net: get rid of unnecessary initializations in .get_drvinfo()

2015-10-14 Thread Ben Hutchings
On Wed, 2015-10-14 at 18:27 +0200, Ivan Vecera wrote: > Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len, > eedump_len & regdump_len fields in their .get_drvinfo() ethtool op. > It's not necessary as these fields is filled in ethtool_get_drvinfo(). > > Signed-off-by: Ivan Vece

Re: [PATCH v3 3/5] net: phy: Add Broadcom phy library for common interfaces

2015-10-14 Thread Robert E Cochran
On 10/06/2015 03:25 PM, Arun Parameswaran wrote: This patch adds the Broadcom phy library to consolidate common interfaces shared by Broadcom phy's. The BCM54612E is included in the Broadcom Community part portfolio (https://community.broadcom.com). However, I don't see this part explicitl

[PATCH net-next 2/3] tcp/dccp: add inet_csk_reqsk_queue_drop_and_put() helper

2015-10-14 Thread Eric Dumazet
Let's reduce the confusion about inet_csk_reqsk_queue_drop() : In many cases we also need to release reference on request socket, so add a helper to do this, reducing code size and complexity. Fixes: 4bdc3d66147b ("tcp/dccp: fix behavior of stale SYN_RECV request sockets") Signed-off-by: Eric Duma

  1   2   >