Re: [PATCH net-next 2/2] xfrm: Fix unaligned access in xfrm_notify_sa() for DELSA

2015-10-20 Thread Steffen Klassert
On Mon, Oct 19, 2015 at 05:23:29PM -0400, Sowmini Varadhan wrote: > On sparc, deleting established SAs (e.g., by restarting ipsec > at the peer) results in unaligned access messages via > xfrm_del_sa -> km_state_notify -> xfrm_send_state_notify(). > Use an aligned pointer to xfrm_usersa_info for th

Re: [PATCH net-next v3] netlink: Rightsize IFLA_AF_SPEC size calculation

2015-10-20 Thread Samudrala, Sridhar
On 10/19/2015 9:23 AM, Ronen Arad wrote: if_nlmsg_size() overestimates the minimum allocation size of netlink dump request (when called from rtnl_calcit()) or the size of the message (when called from rtnl_getlink()). This is because ext_filter_mask is not supported by rtnl_link_get_af_size() and

[PATCH net-next] openvswitch: Use dev_queue_xmit for vport send.

2015-10-20 Thread Pravin B Shelar
With use of lwtunnel, we can directly call dev_queue_xmit() rather than calling netdev vport send operation. Following change make tunnel vport code bit cleaner. Signed-off-by: Pravin B Shelar --- net/openvswitch/vport-geneve.c |2 +- net/openvswitch/vport-gre.c |2 +- net

Re: [PATCH 2/2] geneve: handle ipv6 priority like ipv4 tos

2015-10-20 Thread Jesse Gross
On Tue, Oct 20, 2015 at 11:11 PM, John W. Linville wrote: > Other callers of udp_tunnel6_xmit_skb just pass 0 for the prio > argument. Jesse Gross suggested that prio is really > the same as IPv4's tos and should be handled the same, so this is my > interpretation of that suggestion. > > Signed-

Re: [PATCH v4 1/2] geneve: implement support for IPv6-based tunnels

2015-10-20 Thread Jesse Gross
All of this looks pretty good to me, I just have a few last things that I noticed: On Tue, Oct 20, 2015 at 11:11 PM, John W. Linville wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index 8f5c02eed47d..217b472ab9e7 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-20 Thread Al Viro
On Mon, Oct 19, 2015 at 06:45:32PM -0700, Eric Dumazet wrote: > On Tue, 2015-10-20 at 02:12 +0100, Alan Burlison wrote: > > > Another problem is that if I call close() on a Linux socket that's in > > accept() the accept call just sits there until there's an incoming > > connection, which succeed

[PATCH net-next] openvswitch: Fix incorrect type use.

2015-10-20 Thread Pravin B Shelar
Patch fixes following sparse warning. net/openvswitch/flow_netlink.c:583:30: warning: incorrect type in assignment (different base types) net/openvswitch/flow_netlink.c:583:30:expected restricted __be16 [usertype] ipv4 net/openvswitch/flow_netlink.c:583:30:got int Fixes: 6b26ba3a7d ("ope

[PATCH net-next 3/3] samples: bpf: add bpf_perf_event_output example

2015-10-20 Thread Alexei Starovoitov
Performance test and example of bpf_perf_event_output(). kprobe is attached to sys_write() and trivial bpf program streams pid+cookie into userspace via PERF_COUNT_SW_BPF_OUTPUT event. Usage: $ sudo ./bld_x64/samples/bpf/trace_output recv 2968913 events per sec Signed-off-by: Alexei Starovoitov

[PATCH net-next 0/3] bpf_perf_event_output helper

2015-10-20 Thread Alexei Starovoitov
Over the last year there were multiple attempts to let eBPF programs output data into perf events by He Kuang and Wangnan. The last one was: https://lkml.org/lkml/2015/7/20/736 It was almost perfect with exception that all bpf programs would sent data into one global perf_event. This patch set take

[PATCH net-next 1/3] perf: pad raw data samples automatically

2015-10-20 Thread Alexei Starovoitov
Instead of WARN_ON in perf_event_output() on unpaded raw samples, pad them automatically. Signed-off-by: Alexei Starovoitov --- kernel/events/core.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index b11756f9b6

[PATCH net-next 2/3] bpf: introduce bpf_perf_event_output() helper

2015-10-20 Thread Alexei Starovoitov
This helper is used to send raw data from eBPF program into special PERF_TYPE_SOFTWARE/PERF_COUNT_SW_BPF_OUTPUT perf_event. User space needs to perf_event_open() it (either for one or all cpus) and store FD into perf_event_array (similar to bpf_perf_event_read() helper) before eBPF program can send

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

2015-10-20 Thread Hajime Tazaki
At Tue, 20 Oct 2015 11:48:48 -0600, David Ahern wrote: > > the conditions are > > > > - sendmsg () with INET6/RAW socket (with IPPROTO_MH) > > - ip6_pktinfo.ipi6_addr (fl6.saddr) and ipi6_oif > >(fl6.flowi6_oif) are non-NULL. > > => ipi6_addr (fl6.saddr) is not the IP address of oif, but > >

Re: [PATCH v4 1/2] geneve: implement support for IPv6-based tunnels

2015-10-20 Thread YOSHIFUJI Hideaki/吉藤英明
Hi, John W. Linville wrote: > Signed-off-by: John W. Linville > --- > v4: > - treat mode field of ip_tunnel_info as flags > - add a missing IS_ENABLED(CONFIG_IPV6) to geneve_rx > - remove unneeded flags field in geneve_dev > - NULL-check parameter for __geneve_sock_release > - check remote socket

Re: [PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY

2015-10-20 Thread Dan Murphy
On 10/20/2015 04:28 PM, Andrew F. Davis wrote: > Add support for the TI DP83848 Ethernet PHY device. > > The DP83848 is a highly reliable, feature rich, IEEE 802.3 compliant > single port 10/100 Mb/s Ethernet Physical Layer Transceiver supporting > the MII and RMII interfaces. > > Signed-off-by: An

Re: [PATCH nf-next 0/4] netfilter: rework netfilter ipv6 defrag

2015-10-20 Thread Joe Stringer
On 20 October 2015 at 13:53, Florian Westphal wrote: > Feel free to submit this to -net, there is no dependency on any of the > other changes. OK, I'll follow up on that patch. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.o

[PATCH net-next] ipvlan: read direct ifindex instead of iflink

2015-10-20 Thread Brenden Blanco
In the ipv4 outbound path of an ipvlan device in l3 mode, the ifindex is being grabbed from dev_get_iflink. This works for the physical device case, since as the documentation of that function notes: "Physical interfaces have the same 'ifindex' and 'iflink' values.". However, if the master device

Re: [Intel-wired-lan] [PATCH] fm10k:Fix error handling in the function fm10k_setup_tc

2015-10-20 Thread Rustad, Mark D
Nicholas Krause wrote: > This fixes error handling in the function fm10k_setup_tc to properly > check if the call to the function fm10k_open has failed by returning > a error and if so return immediately to the caller of the function > fm10k_setup_tc to properly signal this non recoverable failur

Re: [PATCH] fm10k:Fix error handling in the function fm10k_setup_tc

2015-10-20 Thread Jeff Kirsher
On Tue, 2015-10-20 at 17:05 -0400, Nicholas Krause wrote: > This fixes error handling in the function fm10k_setup_tc to properly > check if the call to the function fm10k_open has failed by returning > a error and if so return immediately to the caller of the function > fm10k_setup_tc to properly s

Re: [PATCH v4 1/2] geneve: implement support for IPv6-based tunnels

2015-10-20 Thread kbuild test robot
Hi John, [auto build test WARNING on v4.3-rc6 -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/John-W-Linville/geneve-implement-support-for-IPv6-based-tunnels/20151020-232128 config: x86_64-randconf

Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

2015-10-20 Thread Alexei Starovoitov
On 10/20/15 12:22 AM, Kaixu Xia wrote: diff --git a/kernel/events/core.c b/kernel/events/core.c index b11756f..5219635 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -6337,6 +6337,9 @@ static int __perf_event_overflow(struct perf_event *event, irq_work_queue(&even

Re: [PATCH v2 1/3] unix: fix use-after-free in unix_dgram_poll()

2015-10-20 Thread Rainer Weikusat
Jason Baron writes: > On 10/18/2015 04:58 PM, Rainer Weikusat wrote: > > [...] > >> >> The idea behind 'the wait queue' (insofar I'm aware of it) is that it >> will be used as list of threads who need to be notified when the >> associated event occurs. Since you seem to argue that the run-of-the-

Re: [RFC PATCH 1/3] odp-util: Fix CT action formating.

2015-10-20 Thread Jarno Rajahalme
This 3-part RFC patch series applies to OVS master repo, the 5-part RFC series applies to net-next. Jarno > On Oct 20, 2015, at 3:23 PM, Jarno Rajahalme wrote: > > Comma was missing after "label" attribute. > > Signed-off-by: Jarno Rajahalme > --- > lib/odp-util.c | 1 + > 1 file changed, 1

Re: [RFC PATCH 1/5] netfilter: Remove IP_CT_NEW_REPLY definition.

2015-10-20 Thread Jarno Rajahalme
I missed the “net-next” label from the title, sorry for that. Jarno > On Oct 20, 2015, at 3:20 PM, Jarno Rajahalme wrote: > > Remove the definition of IP_CT_NEW_REPLY as it does not make sense. > This allows the definition of IP_CT_NUMBER to be simplified as well. > > Signed-off-by: Jarno Ra

[RFC PATCH 3/3] conntrack action: Add support for NAT.

2015-10-20 Thread Jarno Rajahalme
Extend OVS conntrack interface to cover NAT. New nested nat action may be included with a CT action. A bare nat action only mangles existing connections. If a nat action with src or dst range attribute is included, new (non-committed) connections are mangled according to the nat attributes. Thi

Re: [net PATCH] ixgbe: Reset interface after enabling SR-IOV

2015-10-20 Thread kbuild test robot
Hi Alexander, [auto build test WARNING on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Alexander-Duyck/ixgbe-Reset-interface-after-enabling-SR-IOV/20151021-040132 reproduce: # apt-ge

[RFC PATCH 1/3] odp-util: Fix CT action formating.

2015-10-20 Thread Jarno Rajahalme
Comma was missing after "label" attribute. Signed-off-by: Jarno Rajahalme --- lib/odp-util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/odp-util.c b/lib/odp-util.c index e131e36..8f0f39a 100644 --- a/lib/odp-util.c +++ b/lib/odp-util.c @@ -590,6 +590,7 @@ format_odp_conntrack_action

[RFC PATCH 2/3] tests: Enable debugging in pyftpdlib.

2015-10-20 Thread Jarno Rajahalme
Helps diagnosing problems. Signed-off-by: Jarno Rajahalme --- tests/test-l7.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/test-l7.py b/tests/test-l7.py index 65c6c2a..faec2bc 100755 --- a/tests/test-l7.py +++ b/tests/test-l7.py @@ -30,6 +30,10 @@ def get_ftpd(): from

[RFC PATCH 3/5] netfilter: Allow calling into nat helper without skb_dst.

2015-10-20 Thread Jarno Rajahalme
NAT checksum recalculation code assumed existence of skb_dst, which becomes a problem for a later patch in the series. Simplify this by removing the checks, as the checksum will be dealt with later in the stack. Suggested-by: Pravin Shelar Signed-off-by: Jarno Rajahalme --- net/ipv4/netfilter/

[RFC PATCH 4/5] openvswitch: conntrack netlink API updates.

2015-10-20 Thread Jarno Rajahalme
This patch makes changes already done in the net repo, so that the rest of the code compiles on top of the current net-next. Eventually, this patch will not be needed and should be removed before merging. Signed-off-by: Jarno Rajahalme --- include/uapi/linux/openvswitch.h | 18 +

[RFC PATCH 1/5] netfilter: Remove IP_CT_NEW_REPLY definition.

2015-10-20 Thread Jarno Rajahalme
Remove the definition of IP_CT_NEW_REPLY as it does not make sense. This allows the definition of IP_CT_NUMBER to be simplified as well. Signed-off-by: Jarno Rajahalme --- include/uapi/linux/netfilter/nf_conntrack_common.h | 7 --- net/openvswitch/conntrack.c| 2 -- 2

[RFC PATCH 2/5] netfilter: Factor out nf_ct_get_info().

2015-10-20 Thread Jarno Rajahalme
Define a new inline function to map conntrack status to enum ip_conntrack_info. This removes the need to otherwise duplicate this code in a later patch. Signed-off-by: Jarno Rajahalme --- include/net/netfilter/nf_conntrack.h | 15 +++ net/netfilter/nf_conntrack_core.c| 22 +++---

[RFC PATCH 5/5] openvswitch: Interface with NAT.

2015-10-20 Thread Jarno Rajahalme
Extend OVS conntrack interface to cover NAT. New nested OVS_CT_ATTR_NAT may be used to include NAT with a CT action. A bare OVS_CT_ATTR_NAT only mangles existing connections. If OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST is included within the nested attributes, new (non-committed/non-confirmed) conne

Re: [PATCHv3 net 3/4] openvswitch: Mark connections new when not confirmed.

2015-10-20 Thread Pravin Shelar
On Mon, Oct 19, 2015 at 7:18 PM, Joe Stringer wrote: > New, related connections are marked as such as part of ovs_ct_lookup(), > but they are not marked as "new" if the commit flag is used. Make this > consistent by setting the "new" flag whenever !nf_ct_is_confirmed(ct). > > Reported-by: Jarno Ra

Re: [PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY

2015-10-20 Thread Florian Fainelli
On 20/10/15 14:51, Andrew F. Davis wrote: > On 10/20/2015 04:37 PM, Florian Fainelli wrote: >> On 20/10/15 14:28, Andrew F. Davis wrote: >>> Add support for the TI DP83848 Ethernet PHY device. >>> >>> The DP83848 is a highly reliable, feature rich, IEEE 802.3 compliant >>> single port 10/100 Mb/s E

Re: [PATCHv3 net 2/4] openvswitch: Clarify conntrack COMMIT behaviour

2015-10-20 Thread Pravin Shelar
On Mon, Oct 19, 2015 at 7:18 PM, Joe Stringer wrote: > The presence of this attribute does not modify the ct_state for the > current packet, only future packets. Make this more clear in the header > definition. > > Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar -- To unsubscribe from this

Re: [PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY

2015-10-20 Thread Andrew F. Davis
On 10/20/2015 04:37 PM, Florian Fainelli wrote: On 20/10/15 14:28, Andrew F. Davis wrote: Add support for the TI DP83848 Ethernet PHY device. The DP83848 is a highly reliable, feature rich, IEEE 802.3 compliant single port 10/100 Mb/s Ethernet Physical Layer Transceiver supporting the MII and R

Re: [PATCH net] ipv6: don't use CHECKSUM_PARTIAL on MSG_MORE/UDP_CORK sockets

2015-10-20 Thread Vlad Yasevich
On 10/20/2015 10:38 AM, Hannes Frederic Sowa wrote: > MSG_MORE might cause the packet to get fragmented in the end when > passed down to the flush function and the transhdrlen check alone is > not sufficient to protect against fragmentation. Instead check if the > socket user intends to add more da

Re: [PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY

2015-10-20 Thread Florian Fainelli
On 20/10/15 14:28, Andrew F. Davis wrote: > Add support for the TI DP83848 Ethernet PHY device. > > The DP83848 is a highly reliable, feature rich, IEEE 802.3 compliant > single port 10/100 Mb/s Ethernet Physical Layer Transceiver supporting > the MII and RMII interfaces. > > Signed-off-by: Andre

Re: [PATCH] allow dctcp alpha to drop to zero

2015-10-20 Thread Andrew Shewmaker
On Mon, Oct 19, 2015 at 8:01 AM, Florian Westphal wrote: > Andrew Shewmaker wrote: >> If alpha is strictly reduced by alpha >> dctcp_shift_g and if alpha is less >> than 1 << dctcp_shift_g, then alpha may never reach zero. For example, >> given shift_g=4 and alpha=15, alpha >> dctcp_shift_g yield

[PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY

2015-10-20 Thread Andrew F. Davis
Add support for the TI DP83848 Ethernet PHY device. The DP83848 is a highly reliable, feature rich, IEEE 802.3 compliant single port 10/100 Mb/s Ethernet Physical Layer Transceiver supporting the MII and RMII interfaces. Signed-off-by: Andrew F. Davis Signed-off-by: Dan Murphy --- drivers/net/

RE: [net-next 11/17] i40e: Add promiscuous on VLAN support

2015-10-20 Thread Rose, Gregory V
> -Original Message- > From: Or Gerlitz [mailto:gerlitz...@gmail.com] > Sent: Tuesday, October 20, 2015 8:47 AM > To: Rose, Gregory V > Cc: David Miller; Kirsher, Jeffrey T; Singhai, Anjali; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; > jogre...@redhat.com > Subject:

Re: [PATCH nf-next 0/4] netfilter: rework netfilter ipv6 defrag

2015-10-20 Thread Florian Westphal
Joe Stringer wrote: > > Good point. No, I don't. Any suggestions? > > I can try to just re-target -nf tree (sans patch #2). Pablo? > > The smallest change seems to be adding the nf_ct_frag6_consume_orig() > call to OVS, plus the morph logic from patch 3. Alternatively if Pablo > is fine with h

Re: sh_eth.c::sh_eth_rx(): mdp->rx_skbuff[entry] can be NULL

2015-10-20 Thread Sergei Shtylyov
Hello. On 10/19/2015 06:01 PM, Yasushi SHOJI wrote: In a low memory situation with netdev_alloc_skb() failure, mdp->rx_skbuff[entry] can be left NULL, however, sh_eth_rx() seems to access it without checking NULL or not in the following code: skb = mdp->rx_skbuff[entry]

Re: [PATCH nf-next 3/4] netfilter: ipv6: in-place replacement of last skb

2015-10-20 Thread Florian Westphal
Joe Stringer wrote: > This hunk looks very similar to the logic in ip_frag_reasm(). Did you > consider refactoring to share it? Could be done but I did not plan to do that. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org M

Re: [PATCH net-next V17 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-20 Thread Pravin Shelar
On Tue, Oct 20, 2015 at 7:26 AM, Thomas F Herbert wrote: > On 10/19/15 2:28 PM, Pravin Shelar wrote: >> >> On Sat, Oct 17, 2015 at 6:12 PM, Thomas F Herbert >> wrote: >>> >>> Add support for 802.1ad including the ability to push and pop double >>> tagged vlans. Add support for 802.1ad to netlink

[net PATCH v2] ixgbe: Reset interface after enabling SR-IOV

2015-10-20 Thread Alexander Duyck
Enabling SR-IOV and then bringing the interface up was resulting in the PF MAC addresses getting into a bad state. Specifically the MAC address was enabled for both VF 0 and the PF. This resulted in some odd behaviors such as VF 0 receiving a copy of the PFs traffic, which in turn enables the abi

[PATCH net-next] tcp: fastopen: limit max_qlen

2015-10-20 Thread Eric Dumazet
From: Eric Dumazet Allowing an application to set whatever limit for the list of recently RST fastopen sessions [1] is not wise, as it open ways to deplete kernel memory. Cap the user provided limit by somaxconn sysctl, like listen() backlog. [1] https://tools.ietf.org/html/rfc7413#section-5.1

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-20 Thread John Stultz
On Tue, Oct 20, 2015 at 12:11 PM, Thomas Gleixner wrote: > On Tue, 20 Oct 2015, Richard Cochran wrote: >> On Tue, Oct 20, 2015 at 01:51:13PM +0200, Richard Cochran wrote: >> > You can, in fact, achieve "proper" correlation by sampling. As John >> > said, the question is whether the method in the

Re: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.

2015-10-20 Thread John W. Linville
On Sat, Oct 17, 2015 at 12:21:44AM -0400, Michael Chan wrote: > Broadcom ethernet driver for the new family of NetXtreme-C/E > ethernet devices. > > v3: > - Fixed 2 more sparse warnings. > - Removed some unused structures in .h files. > > v2: > - Fixed all kbuild test robot reported warning

Re: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.

2015-10-20 Thread John W. Linville
On Sat, Oct 17, 2015 at 12:21:44AM -0400, Michael Chan wrote: > Broadcom ethernet driver for the new family of NetXtreme-C/E > ethernet devices. > > v3: > - Fixed 2 more sparse warnings. > - Removed some unused structures in .h files. > > v2: > - Fixed all kbuild test robot reported warning

Re: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.

2015-10-20 Thread John W. Linville
On Sat, Oct 17, 2015 at 12:21:44AM -0400, Michael Chan wrote: > Broadcom ethernet driver for the new family of NetXtreme-C/E > ethernet devices. > > v3: > - Fixed 2 more sparse warnings. > - Removed some unused structures in .h files. > > v2: > - Fixed all kbuild test robot reported warning

Re: [net PATCH] ixgbe: Reset interface after enabling SR-IOV

2015-10-20 Thread kbuild test robot
Hi Alexander, [auto build test WARNING on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Alexander-Duyck/ixgbe-Reset-interface-after-enabling-SR-IOV/20151021-040132 config: x86_64-randconfig-x

Re: [Bug] Linux 4.1.9, NULL pointer dereference in pppoe_release+0x120/0x150

2015-10-20 Thread Matt Bennett
On Tue, 2015-10-20 at 14:00 +0300, Andrew wrote: > Hi. > > After BRAS software upgrading (PPPoE daemon + kernel from 3.2.x to > 4.1.x) I have different kernel bugs/crashes - some of them don't hurt > system, other crashes - cause network subsystem lockup (commands like > 'ip a' just hungs; and

[net PATCH] ixgbe: Reset interface after enabling SR-IOV

2015-10-20 Thread Alexander Duyck
Enabling SR-IOV and then bringing the interface up was resulting in the PF MAC addresses getting into a bad state. Specifically the MAC address was enabled for both VF 0 and the PF. This resulted in some odd behaviors such as VF 0 receiving a copy of the PFs traffic, which in turn enables the abi

We have a parcel right here in our office to be delivered to you.

2015-10-20 Thread ''COURIER''
Kindly Reply Back For More Details. FedEx Express Courier. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-20 Thread Richard Cochran
On Tue, Oct 20, 2015 at 09:11:21PM +0200, Thomas Gleixner wrote: > Darn, we don't want to have that kind of sampling in every driver > which has this kind of problem even if it looks like the simpler > choice for this particular use case. This is going to be something > which next generation chips

[PATCH net-next 2/3] switchdev: fix: pass correct obj size when deferring obj add

2015-10-20 Thread sfeldma
From: Scott Feldman Fixes: 0bc05d585d ("switchdev: allow caller to explicitly request attr_set as deferred") Signed-off-by: Scott Feldman --- net/switchdev/switchdev.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/net/switchdev/switchdev.c b/net/swit

[PATCH net-next 3/3] switchdev: split switchdev_attr into individual structs

2015-10-20 Thread sfeldma
From: Scott Feldman This was already done for switchdev_objs. Changing switchdev_attrs to new style makes switchdev API consistent for both attrs and objs. No functional changes here. Signed-off-by: Scott Feldman --- .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 24 -- drivers/

[PATCH net-next 1/3] switchdev: fix: erasing too much of vlan obj when handling multiple vlan specs

2015-10-20 Thread sfeldma
From: Scott Feldman When adding vlans with multiple IFLA_BRIDGE_VLAN_INFO attrs set in AFSPEC, we would wipe the vlan obj struct after the first IFLA_BRIDGE_VLAN_INFO. Fix this by only clearing what's necessary on each IFLA_BRIDGE_VLAN_INFO iteration. Fixes: 9e8f4a54 ("switchdev: push object ID

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-20 Thread Thomas Gleixner
On Tue, 20 Oct 2015, Richard Cochran wrote: > On Tue, Oct 20, 2015 at 01:51:13PM +0200, Richard Cochran wrote: > > You can, in fact, achieve "proper" correlation by sampling. As John > > said, the question is whether the method in the patch set "measurably > > improves the error" over using anothe

Re: [PATCH v2] net, can, ti_hecc: fix a run time warn_on.

2015-10-20 Thread Marc Kleine-Budde
On 10/20/2015 06:30 PM, Anton.Glukhov wrote: >>> + clk_disable_unprepare(priv->clk); >>> + priv->clk = NULL; >>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>> iounmap(priv->base); >>> release_mem_region(res->start, resource_size(res)); >>> @@ -1009,7 +1010,7 @@ static in

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-20 Thread Eric W. Biederman
Alexei Starovoitov writes: > On 10/20/15 1:46 AM, Daniel Borkmann wrote: >>> as we discussed in this thread and earlier during plumbers I think >>> it would be good to expose key/values somehow in this fs. >>> 'how' is a big question. >> >> Yes, it is a big question, and probably best left to the

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-20 Thread Alexei Starovoitov
On 10/20/15 3:07 AM, Hannes Frederic Sowa wrote: Just a pretty obvious idea is accurate sampling of flows. ok, so you want to time out flows. Makes sense, but it should be done by user space with little or none help from the kernel. fdinfo tells me where my position in a file is and which l

Re: [PATCH nf-next 0/4] netfilter: rework netfilter ipv6 defrag

2015-10-20 Thread Joe Stringer
On 20 October 2015 at 01:17, Florian Westphal wrote: > Joe Stringer wrote: >> On 17 October 2015 at 13:14, Florian Westphal wrote: >> > [ CC netdev since patch #2 isn't nf-specific. Dave, if you want >> > I can resubmit that one after the next nf-pull request; let me know if >> > you would

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-20 Thread Eric Dumazet
On Tue, 2015-10-20 at 19:31 +0100, Alan Burlison wrote: > No, the race issue with file descriptor reuse and the close() behaviour > are not the same thing. The manpage comment is correct, but not relevant. Ok, it seems you know better than me, I will be stop the discussion and wait for your patc

Re: [PATCH nf-next 3/4] netfilter: ipv6: in-place replacement of last skb

2015-10-20 Thread Joe Stringer
On 17 October 2015 at 13:14, Florian Westphal wrote: > @@ -425,6 +425,35 @@ nf_ct_frag6_reasm(struct frag_queue *fq, struct > net_device *dev) > add_frag_mem_limit(fq->q.net, clone->truesize); > } > > + /* morph head into last received skb: prev. > +* > +

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-20 Thread Alan Burlison
On 20/10/2015 16:30, Eric Dumazet wrote: A close() does _not_ wakeup an accept() or a poll() (this is exactly the same problem), or any blocking system call using the same 'file' Not waking up the accept() is one thing, allowing the accept() to successfully complete some indeterminate time af

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-20 Thread Alexei Starovoitov
On 10/20/15 1:46 AM, Daniel Borkmann wrote: as we discussed in this thread and earlier during plumbers I think it would be good to expose key/values somehow in this fs. 'how' is a big question. Yes, it is a big question, and probably best left to the domain-specific application itself, which ca

Re: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6

2015-10-20 Thread David Ahern
On 10/20/15 6:31 AM, Hajime Tazaki wrote: yes, this sendmsg uses non-zero flowi6_oif. the conditions are - sendmsg () with INET6/RAW socket (with IPPROTO_MH) - ip6_pktinfo.ipi6_addr (fl6.saddr) and ipi6_oif (fl6.flowi6_oif) are non-NULL. => ipi6_addr (fl6.saddr) is not the IP address of oif

Re: [PATCH-v2 1/2] mac80211: Take bitrates into account when building IEs.

2015-10-20 Thread Ben Greear
On 10/20/2015 10:22 AM, gree...@candelatech.com wrote: From: Ben Greear If a user restricts the rateset for some reason, then the probe requests should not advertise rates that are not selected by the user. I meant to send these to linux-wireless. Plz ignore. Thanks, Ben -- Ben Greear Can

[PATCH-v2 2/2] mac80211: ensure association req uses configured ratemask.

2015-10-20 Thread greearb
From: Ben Greear When sending the association request, pay attention to the legacy rates configured by the user, and do not advertise support for any that are not configured. This makes the assoc request packet look more correct when making modern hardware act like a /b mode station, for instanc

[PATCH-v2 1/2] mac80211: Take bitrates into account when building IEs.

2015-10-20 Thread greearb
From: Ben Greear If a user restricts the rateset for some reason, then the probe requests should not advertise rates that are not selected by the user. To implement this, we save the requested bitrates at the mac80211 level and take it into account when building the IEs. This allows one to crea

[PATCH net-next v3 0/6] net: dsa: implement port_fdb_dump in drivers

2015-10-20 Thread Vivien Didelot
Not all switch chips provide a Get Next kind of operation to dump FDB entries. It is preferred to let the driver handle the dump operation the way it works best for the chip. Thus, drop port_fdb_getnext and implement the port_fdb_dump operation in DSA, which pushes the switchdev FDB dump callback d

Re: [PATCH v2] net, can, ti_hecc: fix a run time warn_on.

2015-10-20 Thread Anton.Glukhov
Thank you for review Marc! On 20.10.2015 17:46, Marc Kleine-Budde wrote: > On 10/20/2015 04:39 PM, Anton Glukhov wrote: >> This patch fixes a warning in clk_enable by calling >> clk_prepare_enable instead. >> >> Signed-off-by: Heiko Schocher >> Signed-off-by: Anton Glukhov >> --- >> drivers/net

[PATCH net-next v3 1/6] net: dsa: add port_fdb_dump function

2015-10-20 Thread Vivien Didelot
Not all switch chips support a Get Next operation to iterate on its FDB. So add a more simple port_fdb_dump function for them. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 4 net/dsa/slave.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/include/net/dsa.h b/include/net/d

[PATCH net-next v3 3/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code

2015-10-20 Thread Vivien Didelot
There is no need to write the MAC address before every Get Next operation, since ATU MAC registers are not cleared between calls. Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext so future code could call ATU Get Next multiple times and save a few register access. --- driv

[PATCH net-next v3 6/6] net: dsa: remove port_fdb_getnext

2015-10-20 Thread Vivien Didelot
No driver implements port_fdb_getnext anymore, and port_fdb_dump is preferred anyway, so remove this function from DSA. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 3 --- net/dsa/slave.c | 25 + 2 files changed, 1 insertion(+), 27 deletions(-) diff --git a/i

[PATCH net-next v3 2/6] net: dsa: mv88e6xxx: write VID outside of VTU Get Next code

2015-10-20 Thread Vivien Didelot
There is no need to write the VLAN ID before every Get Next operation, since the VTU VID register is not cleared between calls. Move the VID write call in a _mv88e6xxx_vtu_vid_write function outside of _mv88e6xxx_vtu_getnext so future code could call VTU Get Next multiple times and save a few regi

[PATCH net-next v3 5/6] net: dsa: mv88e6xxx: remove port_fdb_getnext

2015-10-20 Thread Vivien Didelot
Now that port_fdb_dump is implemented and even simpler, get rid of port_fdb_getnext. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6171.c | 1 - drivers/net/dsa/mv88e6352.c | 1 - drivers/net/dsa/mv88e6xxx.c | 73 - drivers/net/dsa/mv88e6xxx

[PATCH net-next v3 4/6] net: dsa: mv88e6xxx: implement port_fdb_dump

2015-10-20 Thread Vivien Didelot
Implement the port_fdb_dump DSA operation. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6171.c | 1 + drivers/net/dsa/mv88e6352.c | 1 + drivers/net/dsa/mv88e6xxx.c | 65 + drivers/net/dsa/mv88e6xxx.h | 3 +++ 4 files changed, 70 insertion

[RFC PATCH] net:hns: hns_aev2_toggle_ring_irq() can be static

2015-10-20 Thread kbuild test robot
Signed-off-by: Fengguang Wu --- hns_ae_adapt.c |2 +- hns_enet.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c index c3d64ce..bf277c7 100644 --- a/drivers/ne

Re: [PATCH net-next 1/4] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-10-20 Thread kbuild test robot
Hi Salil, [auto build test WARNING on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Salil/net-hns-Add-support-of-Hip06-SoC-to-the-Hislicon-Network-Subsystem/20151020-225151 repr

RE: [PATCH net-next v3] bnxt_en: New Broadcom ethernet driver.

2015-10-20 Thread David Laight
From: Stephen Hemminger ... > On Sat, 17 Oct 2015 00:21:44 -0400 > Michael Chan wrote: > > > +static bool bnxt_vf_pciid(int idx) > > +{ > > + if (idx == BCM57304_VF || idx == BCM57404_VF) > > + return true; > > + return false; > > +} > > + > > I prefer just returning result of logi

RE: [PATCH] intel: i40e: fix confused code

2015-10-20 Thread Nelson, Shannon
> -Original Message- > From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] > Sent: Saturday, October 17, 2015 1:58 PM > Subject: [PATCH] intel: i40e: fix confused code > > This code is pretty confused. The variable name 'bytes_not_copied' > clearly indicates that the programmer knew t

Re: [net-next 11/17] i40e: Add promiscuous on VLAN support

2015-10-20 Thread Or Gerlitz
On Tue, Oct 20, 2015 at 6:31 PM, Rose, Gregory V wrote: >> > NFV use cases require the ability to steer packets to VSIs by VLAN tag >> > alone while being in promiscuous mode for multicast and unicast MAC >> > addresses. These two new functions support that ability. >> > >> > Change-ID: Ifef704b

RE: [PATCH] intel: i40e: fix confused code

2015-10-20 Thread Nelson, Shannon
> From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] > Sent: Tuesday, October 20, 2015 12:22 AM > > On Mon, Oct 19 2015, "Nelson, Shannon" wrote: > > >> From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] > >> Sent: Saturday, October 17, 2015 1:58 PM > >> Subject: [PATCH] intel: i40e:

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-20 Thread Anton.Glukhov
On 20.10.2015 18:20, Marc Kleine-Budde wrote: > On 10/20/2015 05:18 PM, Marc Kleine-Budde wrote: >> On 10/20/2015 05:09 PM, Anton.Glukhov wrote: > It's OMAP3 based arch, but HECC is implemented only in AM3505 and AM3517 > SoCs. > So, I'm confused about what's "name" should I use. >>>

RE: [net-next 11/17] i40e: Add promiscuous on VLAN support

2015-10-20 Thread Rose, Gregory V
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, October 13, 2015 4:14 AM > To: Kirsher, Jeffrey T > Cc: Rose, Gregory V; netdev@vger.kernel.org; nhor...@redhat.com; > sassm...@redhat.com; jogre...@redhat.com > Subject: Re: [net-next 11/17] i40e: Add

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-20 Thread Eric Dumazet
On Tue, 2015-10-20 at 14:45 +0100, Alan Burlison wrote: > And I still haven't seen any reasoning behind the Linux close() and > poll() behaviour on sockets that are in the listen state. Same answer. A close() does _not_ wakeup an accept() or a poll() (this is exactly the same problem), or any b

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-20 Thread Marc Kleine-Budde
On 10/20/2015 05:18 PM, Marc Kleine-Budde wrote: > On 10/20/2015 05:09 PM, Anton.Glukhov wrote: It's OMAP3 based arch, but HECC is implemented only in AM3505 and AM3517 SoCs. So, I'm confused about what's "name" should I use. >>> >>> Which SoC was available first? Pick that. > >> W

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-20 Thread Marc Kleine-Budde
On 10/20/2015 05:09 PM, Anton.Glukhov wrote: >>> It's OMAP3 based arch, but HECC is implemented only in AM3505 and AM3517 >>> SoCs. >>> So, I'm confused about what's "name" should I use. >> >> Which SoC was available first? Pick that. > What do you mean available? I know only that HECC appear in

[PATCH v4 1/2] geneve: implement support for IPv6-based tunnels

2015-10-20 Thread John W. Linville
Signed-off-by: John W. Linville --- v4: - treat mode field of ip_tunnel_info as flags - add a missing IS_ENABLED(CONFIG_IPV6) to geneve_rx - remove unneeded flags field in geneve_dev - NULL-check parameter for __geneve_sock_release - check remote socket family for AF_UNSPEC in geneve_configure - r

[PATCH 2/2] geneve: handle ipv6 priority like ipv4 tos

2015-10-20 Thread John W. Linville
Other callers of udp_tunnel6_xmit_skb just pass 0 for the prio argument. Jesse Gross suggested that prio is really the same as IPv4's tos and should be handled the same, so this is my interpretation of that suggestion. Signed-off-by: John W. Linville Reported-by: Jesse Gross --- drivers/net/g

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-20 Thread Anton.Glukhov
Hello Marc, Heiko! I'm sorry for the delay! On 19.10.2015 10:31, Marc Kleine-Budde wrote: > On 10/19/2015 09:27 AM, Heiko Schocher wrote: .../devicetree/bindings/net/can/ti_hecc-can.txt| 20 ++ arch/arm/boot/dts/am3517.dtsi | 13 +++ drivers/

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-20 Thread Anton.Glukhov
On 20.10.2015 18:05, Marc Kleine-Budde wrote: > On 10/20/2015 04:57 PM, Anton.Glukhov wrote: >> Hello Marc, Heiko! >> I'm sorry for the delay! >> >> On 19.10.2015 10:31, Marc Kleine-Budde wrote: >>> On 10/19/2015 09:27 AM, Heiko Schocher wrote: >> .../devicetree/bindings/net/can/ti_hecc-can

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-20 Thread Marc Kleine-Budde
On 10/20/2015 04:57 PM, Anton.Glukhov wrote: > Hello Marc, Heiko! > I'm sorry for the delay! > > On 19.10.2015 10:31, Marc Kleine-Budde wrote: >> On 10/19/2015 09:27 AM, Heiko Schocher wrote: > .../devicetree/bindings/net/can/ti_hecc-can.txt| 20 ++ > arch/arm/boot/dts/am351

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-10-20 Thread Richard Cochran
On Tue, Oct 20, 2015 at 01:51:13PM +0200, Richard Cochran wrote: > You can, in fact, achieve "proper" correlation by sampling. As John > said, the question is whether the method in the patch set "measurably > improves the error" over using another, simpler method. Here is a short example to put s

Re: [PATCH net] ipv6: don't use CHECKSUM_PARTIAL on MSG_MORE/UDP_CORK sockets

2015-10-20 Thread Vlad Yasevich
On 10/20/2015 10:38 AM, Hannes Frederic Sowa wrote: > MSG_MORE might cause the packet to get fragmented in the end when > passed down to the flush function and the transhdrlen check alone is > not sufficient to protect against fragmentation. Instead check if the > socket user intends to add more da

[PATCH net-next 0/4] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-10-20 Thread Salil
From: Salil Mehta This patch-set adds support of new Hisilicon Hip06 SoC to the existing (already part of net-next) HNS ethernet driver for Hip05 SoC. Hip06 is a multi-core SoC and is a derivative of Hip05 SoC with lots of new hardware featres supported like RSS, TSO, hardware VLAN assist etc.

[PATCH net-next 2/4] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver

2015-10-20 Thread Salil
From: Salil Mehta This patch adds the support of "RSS (Receive Side Scaling)" feature provided by the Hip06 ethernet hardware to the HNS ethernet driver. This feature helps in distributing the different flows (mapped as hash by hardware using Toeplitz Hash) to different Queues asssociated with t

  1   2   >