Re: [Intel-wired-lan] [PATCH] fm10k:Fix error handling in the function fm10k_probe

2015-10-23 Thread Alexander Duyck
On 10/16/2015 12:42 PM, Nicholas Krause wrote: This fixes error handling in the function fm10k_probe to properly if the call to the function fm10k_iov_configure has failed by returning a error code before jumping to a new goto label, fm10k_iov_configure to clean up previously allocated resources

Re: [PATCH RFC net-next 0/2] tcp: Redundant Data Bundling (RDB)

2015-10-23 Thread Yuchung Cheng
On Fri, Oct 23, 2015 at 1:50 PM, Bendik Rønning Opstad wrote: > > This is a request for comments. > > Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing > the latency for applications sending time-dependent data. > Latency-sensitive applications or services, such as online game

Re: [Intel-wired-lan] [PATCH] e1000e:Fix incorrect assumption that the function e1000e_up always runs successfully in e1000_change_mtu

2015-10-23 Thread Alexander Duyck
On 10/23/2015 09:09 PM, Nicholas Krause wrote: This fixes the function e1000_change_mtu to properly check and run the error code by e1000e_up as this function can fail and the error code should be returned to the caller of the function e1000_change_mtu to signal a error has occurred when calling

Re: [RFC PATCH net-next] net/core: initial support for stacked dev feature toggles

2015-10-23 Thread Alexander Duyck
On 10/23/2015 08:40 PM, Jarod Wilson wrote: There are some netdev features that make little sense to toggle on and off in a stacked device setup on only one device in the stack. The prime example is a bonded connection, where it really doesn't make sense to disable LRO on the master, but not on a

Re: [RFC PATCH net-next] net/core: initial support for stacked dev feature toggles

2015-10-23 Thread Tom Herbert
On Fri, Oct 23, 2015 at 11:40 PM, Jarod Wilson wrote: > There are some netdev features that make little sense to toggle on and > off in a stacked device setup on only one device in the stack. The prime > example is a bonded connection, where it really doesn't make sense to > disable LRO on the mas

Re: [PATCH] glibc: Terminate process on invalid netlink response from kernel [BZ #12926]

2015-10-23 Thread Mike Frysinger
On 23 Oct 2015 22:07, Florian Weimer wrote: > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/netlink_assert_response.c > @@ -0,0 +1,100 @@ > +/* Copyright (C) 2015 Free Software Foundation, Inc. > + This file is part of the GNU C Library. guess we like to have the first line be a short desc of th

[RFC PATCH net-next] net/core: initial support for stacked dev feature toggles

2015-10-23 Thread Jarod Wilson
There are some netdev features that make little sense to toggle on and off in a stacked device setup on only one device in the stack. The prime example is a bonded connection, where it really doesn't make sense to disable LRO on the master, but not on any of the slaves, nor does it really make sens

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-23 Thread Al Viro
On Fri, Oct 23, 2015 at 11:52:34AM +0200, casper@oracle.com wrote: > > > >Ho-hum... It could even be made lockless in fast path; the problems I see > >are > > * descriptor-to-file lookup becomes unsafe in a lot of locking > >conditions. Sure, most of that happens on the entry to some sy

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-23 Thread Kosuke Tatsukawa
J. Bruce Fields wrote: > On Fri, Oct 23, 2015 at 04:14:10AM +, Kosuke Tatsukawa wrote: >> J. Bruce Fields wrote: >> > On Fri, Oct 16, 2015 at 02:28:10AM +, Kosuke Tatsukawa wrote: >> >> Tatsukawa Kosuke wrote: >> >> > J. Bruce Fields wrote: >> >> >> On Thu, Oct 15, 2015 at 11:44:20AM +,

Re: [PATCH net-next] bnxt_en: Fix compile errors when CONFIG_BNXT_SRIOV is not set.

2015-10-23 Thread David Miller
From: Michael Chan Date: Fri, 23 Oct 2015 15:06:19 -0400 > struct bnxt_pf_info needs to be always defined. Move bnxt_update_vf_mac() > to bnxt_sriov.c and add some missing #ifdef CONFIG_BNXT_SRIOV. > > Reported-by: Jim Hull > Tested-by: Jim Hull > Signed-off-by: Michael Chan Applied, thanks

Re: ip_no_pmtu_disc and UDP

2015-10-23 Thread David Miller
From: Vincent Li Date: Fri, 23 Oct 2015 10:01:50 -0700 > I think the no_pmtu_disc could be renamed to pmtu_disc to be less > confusion to users. We cannot rename sysctl values exported to the user without breaking things. -- To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: [PATCH net] amd-xgbe: Use wmb before updating current descriptor count

2015-10-23 Thread David Miller
From: Tom Lendacky Date: Fri, 23 Oct 2015 11:57:27 -0500 > David, if this is indeed the proper fix would you want to me to send a > new patch based on this old patch or a new patch based on you having > reverted the old patch? One never sends me a "new patch" for a patch I've already applied, on

[PATCH 1/4] net: thunderx: Remove PF soft reset.

2015-10-23 Thread David Daney
From: Sunil Goutham In some silicon revisions, the soft reset clobbers PCI config space, so quit doing the reset. Signed-off-by: Sunil Goutham Signed-off-by: David Daney --- drivers/net/ethernet/cavium/thunder/nic_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethern

[PATCH 0/4] net: thunderx: Support pass-2 revision hardware.

2015-10-23 Thread David Daney
From: David Daney With the availability of a new revision of the ThunderX NIC hardware a few changes to the driver are required. With these, the driver works on all currently available hardware revisions. David Daney (1): net: thunderx: Rewrite silicon revision tests. Sunil Goutham (2): ne

[PATCH 3/4] net: thunderx: Rewrite silicon revision tests.

2015-10-23 Thread David Daney
From: David Daney The test for pass-1 silicon was incorrect, it should be for all revisions less than 8. Also the revision is already present in the pci_dev, so there is no need to read and keep a private copy. Remove rev_id and code to read it from struct nicpf. Create new static inline funct

[PATCH 4/4] net: thunderx: Incorporate pass2 silicon CPI index configuration changes

2015-10-23 Thread David Daney
From: Thanneeru Srinivasulu Add support for ThunderX pass2 CPI and MPI configuration changes. MPI_ALG is not enabled i.e MCAM parsing is disabled. Signed-off-by: Thanneeru Srinivasulu Signed-off-by: Sunil Goutham Signed-off-by: David Daney --- drivers/net/ethernet/cavium/thunder/nic_main.c |

[PATCH 2/4] net: thunderx: Fix incorrect subsystem devid of VF on pass2 silicon

2015-10-23 Thread David Daney
From: Sunil Goutham Signed-off-by: Sunil Goutham Signed-off-by: David Daney --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_main.c b/drivers/net/ethernet/cavium/thunder/nicvf_mai

Re: [ovs-dev] [RFC PATCH 1/3] odp-util: Fix CT action formating.

2015-10-23 Thread Jarno Rajahalme
> On Oct 23, 2015, at 4:20 PM, Joe Stringer wrote: > > On 20 October 2015 at 15:23, Jarno Rajahalme wrote: >> Comma was missing after "label" attribute. >> >> Signed-off-by: Jarno Rajahalme > > Acked-by: Joe Stringer Thanks for the review, pushed to master. Jarno -- To unsubscribe from

[PATCHv2 net 3/3] openvswitch: Fix skb leak using IPv6 defrag

2015-10-23 Thread Joe Stringer
nf_ct_frag6_gather() makes a clone of each skb passed to it, and if the reassembly is successful, expects the caller to free all of the original skbs using nf_ct_frag6_consume_orig(). This call was previously missing, meaning that the original fragments were never freed (with the exception of the l

[PATCHv2 net 2/3] ipv6: Export nf_ct_frag6_consume_orig()

2015-10-23 Thread Joe Stringer
This is needed in openvswitch to fix an skb leak in the next patch. Signed-off-by: Joe Stringer --- v2: No change. --- net/ipv6/netfilter/nf_conntrack_reasm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c in

[PATCHv2 net 1/3] openvswitch: Fix double-free on ip_defrag() errors

2015-10-23 Thread Joe Stringer
If ip_defrag() returns an error other than -EINPROGRESS, then the skb is freed. When handle_fragments() passes this back up to do_execute_actions(), it will be freed again. Prevent this double free by never freeing the skb in do_execute_actions() for errors returned by ovs_ct_execute. Always free i

Re: [ovs-dev] [RFC PATCH 2/3] tests: Enable debugging in pyftpdlib.

2015-10-23 Thread Joe Stringer
On 20 October 2015 at 15:23, Jarno Rajahalme wrote: > Helps diagnosing problems. > > Signed-off-by: Jarno Rajahalme I assume we don't check the output of this anywhere, so we don't need to amend the testsuite to keep things passing. Acked-by: Joe Stringer -- To unsubscribe from this list: send

Re: [ovs-dev] [RFC PATCH 1/3] odp-util: Fix CT action formating.

2015-10-23 Thread Joe Stringer
On 20 October 2015 at 15:23, Jarno Rajahalme wrote: > Comma was missing after "label" attribute. > > Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo in

[PATCH RTF] sh_eth: fix kernel oops in skb_put()

2015-10-23 Thread Sergei Shtylyov
In a low memory situation the following kernel oops occurs: Unable to handle kernel NULL pointer dereference at virtual address 0050 pgd = 8490c000 [0050] *pgd=4651e831, *pte=, *ppte= Internal error: Oops: 17 [#1] PREEMPT ARM Modules linked in: CPU: 0Not tainted (3.4-a

[PATCH net 3/3] openvswitch: Fix skb leak using IPv6 defrag

2015-10-23 Thread Joe Stringer
nf_ct_frag6_gather() makes a clone of each skb passed to it, and if the reassembly is successful, expects the caller to free all of the original skbs using nf_ct_frag6_consume_orig(). This call was previously missing, meaning that the original fragments were never freed (with the exception of the l

[PATCH net 2/3] ipv6: Export nf_ct_frag6_consume_orig()

2015-10-23 Thread Joe Stringer
This is needed in openvswitch to fix an skb leak in the next patch. Signed-off-by: Joe Stringer --- net/ipv6/netfilter/nf_conntrack_reasm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c index 701cd2bae0a9..c

[PATCH net 1/3] openvswitch: Fix double-free on ip_defrag() errors

2015-10-23 Thread Joe Stringer
If ip_defrag() returns an error other than -EINPROGRESS, then the skb is freed. When handle_fragments() passes this back up to do_execute_actions(), it will be freed again. Prevent this double free by always freeing the skb in ovs_ct_execute() if an error occurs. Fixes: 7f8a436eaa2c ("openvswitch:

Re: [PATCH net] ipv6: no CHECKSUM_PARTIAL on skbs with extension headers and recalc checksum during fragmentation

2015-10-23 Thread Eric Dumazet
On Fri, 2015-10-23 at 15:13 +0200, Hannes Frederic Sowa wrote: > CHECKSUM_PARTIAL should only be used on plain vanilla IPv6 + UDP packets > in ip6_append_data. Some drivers don't correctly handle extension headers, > especially not ipv6 fragmentation which could result in broken checksums. > > 1)

Re: [PATCH net-next] net: dsa: bcm_sf2: Implement FDB operations

2015-10-23 Thread Vivien Didelot
On Oct. Friday 23 (43) 01:20 PM, Florian Fainelli wrote: > On 23/10/15 12:28, Vivien Didelot wrote: > > On Oct. Friday 23 (43) 11:38 AM, Florian Fainelli wrote: > >> +static int bcm_sf2_sw_fdb_del(struct dsa_switch *ds, int port, > >> +const struct switchdev_obj_port_fdb *fd

Re: [iproute RFC PATCH 0/9] Document tc filters

2015-10-23 Thread Stephen Hemminger
On Fri, 23 Oct 2015 19:47:07 +0200 Phil Sutter wrote: > This series adds documentation in form of a dedicated man page for every > available tc filter with the exception of rsvp which I simply didn't > understand. In addition to that, it adds a list of filters with (very) basic > description to t

Re: CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)

2015-10-23 Thread Alexander Duyck
On 10/23/2015 03:17 PM, Helge Deller wrote: On 24.10.2015 00:00, Alexander Duyck wrote: On 10/23/2015 02:08 PM, Helge Deller wrote: * Eric Dumazet : On Fri, 2015-10-23 at 21:25 +0200, Helge Deller wrote: Then, how about simply changing it to twice of L1_CACHE_BYTES ? #define XPS_MIN_MAP_ALL

Re: ip_no_pmtu_disc and UDP

2015-10-23 Thread Hannes Frederic Sowa
Hello, On Fri, Oct 23, 2015, at 18:45, Vincent Li wrote: > It looks ip_no_pmtu_disc setting does not affect UDP IP packet DF bit > setting, is that intended behavior? echo 0, 1, 2, 3 respectively to > ip_no_pmtu_disc, UDP IP packet always have DF bit cleared, unless use > IP_PMTUDISC_DO on IP_MTU_

Re: Missing IPv4 routes

2015-10-23 Thread Alexander Duyck
On 10/23/2015 02:34 PM, Brian Rak wrote: I've got a weird situation here. I have a route that the kernel knows about, but won't display via the general RTM_GETROUTE call, but will display if I query for that particular route: # ip -4 route show | grep 108.61.171.x The use of 'x' here is going

Re: [iproute RFC PATCH 0/9] Document tc filters

2015-10-23 Thread Phil Sutter
On Fri, Oct 23, 2015 at 10:13:02PM +0200, Thomas Graf wrote: > On 10/23/15 at 07:47pm, Phil Sutter wrote: > > man/man8/Makefile | 4 +- > > man/man8/tc-basic.8 | 34 +++ > > man/man8/tc-cgroup.8 | 80 ++ > > man/man8/tc-flow.8| 265 > > man/man8/tc-flower.8

Re: CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)

2015-10-23 Thread Helge Deller
On 24.10.2015 00:00, Alexander Duyck wrote: > On 10/23/2015 02:08 PM, Helge Deller wrote: >> * Eric Dumazet : >>> On Fri, 2015-10-23 at 21:25 +0200, Helge Deller wrote: >>> Then, how about simply changing it to twice of L1_CACHE_BYTES ? #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES * 2

Re: CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)

2015-10-23 Thread Tom Herbert
On Fri, Oct 23, 2015 at 12:21 PM, Helge Deller wrote: > On 22.10.2015 23:37, Tom Herbert wrote: >> On Thu, Oct 22, 2015 at 1:00 PM, Helge Deller wrote: >>> Hi Tom & David, >>> >>> I've queued-up a patch for the parisc architecture which reduces >>> L1_CACHE_BYTES from 32 to 16: >>> https://pat

Re: CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)

2015-10-23 Thread Alexander Duyck
On 10/23/2015 02:08 PM, Helge Deller wrote: * Eric Dumazet : On Fri, 2015-10-23 at 21:25 +0200, Helge Deller wrote: Then, how about simply changing it to twice of L1_CACHE_BYTES ? #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES * 2 - sizeof(struct xps_map)) / sizeof(u16)) Seems good to me. G

[PATCH net-next] bpf: make tracing helpers gpl only

2015-10-23 Thread Alexei Starovoitov
exported perf symbols are GPL only, mark eBPF helper functions used in tracing as GPL only as well. Suggested-by: Peter Zijlstra Signed-off-by: Alexei Starovoitov --- this is on top of this patch that touches the same file: http://patchwork.ozlabs.org/patch/534664/ kernel/trace/bpf_trace.c |

[PATCH 2/2] sh_eth: fix RX buffer size calculation

2015-10-23 Thread Sergei Shtylyov
The RX buffer size calulation failed to account for the length granularity (which is now 32 bytes)... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: net/drivers/net/ethernet/renesas/sh_eth.c =

[PATCH 1/2] sh_eth: fix RX buffer size alignment

2015-10-23 Thread Sergei Shtylyov
Both Renesas R-Car and RZ/A1 manuals state that RX buffer length must be a multiple of 32 bytes, while the driver only uses 16 byte granularity... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/sh_eth.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Inde

Re: [PATCH RFC net-next 1/2] tcp: Add DPIFL thin stream detection mechanism

2015-10-23 Thread Eric Dumazet
On Fri, 2015-10-23 at 22:50 +0200, Bendik Rønning Opstad wrote: > > +/** > + * tcp_stream_is_thin_dpifl() - Tests if the stream is thin based on dynamic > PIF > + * limit > + * @tp: the tcp_sock struct > + * > + * Return: true if current packets in flight (PIF) coun

[PATCH 0/2] sh_eth: RX buffer alignment fixes

2015-10-23 Thread Sergei Shtylyov
Hello. Here's a set of 2 patches against DaveM's 'net.git' repo which are the fixes to the RX buffer size calculation. [1/2] sh_eth: fix RX buffer size alignment [2/2] sh_eth: fix RX buffer size calculation MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in t

Missing IPv4 routes

2015-10-23 Thread Brian Rak
I've got a weird situation here. I have a route that the kernel knows about, but won't display via the general RTM_GETROUTE call, but will display if I query for that particular route: # ip -4 route show | grep 108.61.171.x # ip route get 108.61.171.x 108.61.171.x dev MYIF cache # cat /pro

Re: CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)

2015-10-23 Thread Eric Dumazet
On Fri, 2015-10-23 at 23:08 +0200, Helge Deller wrote: > Can you then maybe give me an Acked-by or signed-off for the patch below? > It further adds a compile-time check to avoid that XPS_MIN_MAP_ALLOC > gets calculated to zero on any architecture - otherwise no queues would > be allocated. > >

Re: CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)

2015-10-23 Thread Helge Deller
On 23.10.2015 23:08, Helge Deller wrote: > * Eric Dumazet : >> On Fri, 2015-10-23 at 21:25 +0200, Helge Deller wrote: >> >>> Then, how about simply changing it to twice of L1_CACHE_BYTES ? >>> >>> #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES * 2 - sizeof(struct xps_map)) / >>> sizeof(u16)) >> >> >>

Re: CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)

2015-10-23 Thread Helge Deller
* Eric Dumazet : > On Fri, 2015-10-23 at 21:25 +0200, Helge Deller wrote: > > > Then, how about simply changing it to twice of L1_CACHE_BYTES ? > > > > #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES * 2 - sizeof(struct xps_map)) / > > sizeof(u16)) > > > Seems good to me. Great! Can you then mayb

[PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-23 Thread Bendik Rønning Opstad
RDB is a mechanism that enables a TCP sender to bundle redundant (already sent) data with TCP packets containing new data. By bundling (retransmitting) already sent data with each TCP packet containing new data, the connection will be more resistant to sporadic packet loss which reduces the applica

[PATCH RFC net-next 0/2] tcp: Redundant Data Bundling (RDB)

2015-10-23 Thread Bendik Rønning Opstad
This is a request for comments. Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing the latency for applications sending time-dependent data. Latency-sensitive applications or services, such as online games and remote desktop, produce traffic with thin-stream characteristics, c

[PATCH RFC net-next 1/2] tcp: Add DPIFL thin stream detection mechanism

2015-10-23 Thread Bendik Rønning Opstad
The existing mechanism for detecting thin streams (tcp_stream_is_thin) is based on a static limit of less than 4 packets in flight. This treats streams differently depending on the connections RTT, such that a stream on a high RTT link may never be considered thin, whereas the same application woul

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-23 Thread J. Bruce Fields
On Fri, Oct 23, 2015 at 04:14:10AM +, Kosuke Tatsukawa wrote: > J. Bruce Fields wrote: > > On Fri, Oct 16, 2015 at 02:28:10AM +, Kosuke Tatsukawa wrote: > >> Tatsukawa Kosuke wrote: > >> > J. Bruce Fields wrote: > >> >> On Thu, Oct 15, 2015 at 11:44:20AM +, Kosuke Tatsukawa wrote: > >>

Re: [PATCH net-next] net: dsa: bcm_sf2: Implement FDB operations

2015-10-23 Thread Florian Fainelli
On 23/10/15 12:28, Vivien Didelot wrote: > On Oct. Friday 23 (43) 11:38 AM, Florian Fainelli wrote: >> Add support for the FDB add, delete, and dump operations. The add and >> delete operations are implemented using directed ARL operations using >> the specified MAC address and consist in a read op

Re: [iproute RFC PATCH 0/9] Document tc filters

2015-10-23 Thread Thomas Graf
On 10/23/15 at 07:47pm, Phil Sutter wrote: > man/man8/Makefile | 4 +- > man/man8/tc-basic.8 | 34 +++ > man/man8/tc-cgroup.8 | 80 ++ > man/man8/tc-flow.8| 265 > man/man8/tc-flower.8 | 113 + > man/man8/tc-fw.8 | 66 + > man/man8/tc-rout

[PATCH] glibc: Terminate process on invalid netlink response from kernel [BZ #12926]

2015-10-23 Thread Florian Weimer
This patch revisits this glibc bug: https://sourceware.org/bugzilla/show_bug.cgi?id=12926 For some reason, this particular code path is very good at picking up file descriptors which have been reused in correctly. This happens if other threads have a race, close the wrong file descriptor (the

Re: CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)

2015-10-23 Thread Eric Dumazet
On Fri, 2015-10-23 at 21:25 +0200, Helge Deller wrote: > Then, how about simply changing it to twice of L1_CACHE_BYTES ? > > #define XPS_MIN_MAP_ALLOC ((L1_CACHE_BYTES * 2 - sizeof(struct xps_map)) / > sizeof(u16)) Seems good to me. -- To unsubscribe from this list: send the line "unsubscrib

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-23 Thread Alexander Duyck
On 10/23/2015 12:05 PM, Alex Williamson wrote: On Fri, 2015-10-23 at 11:36 -0700, Alexander Duyck wrote: On 10/21/2015 09:37 AM, Lan Tianyu wrote: This patchset is to propose a new solution to add live migration support for 82599 SRIOV network card. Im our solution, we prefer to put all devic

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-23 Thread Al Viro
On Fri, Oct 23, 2015 at 06:30:25PM +, David Holland wrote: > So, I'm coming late to this discussion and I don't have the original > context; however, to me this cited behavior seems undesirable and if I > ran across it in the wild I would probably describe it as a bug. Unfortunately, that's p

Re: [PATCH net v3] openvswitch: Fix egress tunnel info.

2015-10-23 Thread Pravin Shelar
On Fri, Oct 23, 2015 at 11:22 AM, Jiri Benc wrote: > On Fri, 23 Oct 2015 10:30:24 -0700, Pravin Shelar wrote: ... > >> > This doesn't do what the name suggests and is, actually, ovs specific. >> > The ip_tunnel_info can be provided as a part of lwtstate and this >> > function should handle that ca

Re: [PATCH net-next V17 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-23 Thread Thomas F Herbert
On 10/23/15 3:26 PM, Pravin Shelar wrote: On Wed, Oct 21, 2015 at 7:39 AM, Thomas F Herbert wrote: On 10/20/15 4:34 PM, Pravin Shelar wrote: On Tue, Oct 20, 2015 at 7:26 AM, Thomas F Herbert wrote: On 10/19/15 2:28 PM, Pravin Shelar wrote: On Sat, Oct 17, 2015 at 6:12 PM, Thomas F Herbert

Re: [PATCH net-next] net: dsa: bcm_sf2: Implement FDB operations

2015-10-23 Thread Vivien Didelot
On Oct. Friday 23 (43) 11:38 AM, Florian Fainelli wrote: > Add support for the FDB add, delete, and dump operations. The add and > delete operations are implemented using directed ARL operations using > the specified MAC address and consist in a read operation, write and > readback operation. > >

Re: [PATCH net-next V17 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-23 Thread Pravin Shelar
On Wed, Oct 21, 2015 at 7:39 AM, Thomas F Herbert wrote: > > > On 10/20/15 4:34 PM, Pravin Shelar wrote: >> >> On Tue, Oct 20, 2015 at 7:26 AM, Thomas F Herbert >> wrote: >>> >>> On 10/19/15 2:28 PM, Pravin Shelar wrote: On Sat, Oct 17, 2015 at 6:12 PM, Thomas F Herbert wrote: >

Re: CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)

2015-10-23 Thread Helge Deller
On 22.10.2015 23:50, Eric Dumazet wrote: > On Thu, 2015-10-22 at 22:00 +0200, Helge Deller wrote: >> Hi Tom & David, >> >> I've queued-up a patch for the parisc architecture which reduces >> L1_CACHE_BYTES from 32 to 16: >> https://patchwork.kernel.org/patch/7399291/ >> >> But this change will b

Re: CONFIG_XPS depends on L1_CACHE_BYTES being greater than sizeof(struct xps_map)

2015-10-23 Thread Helge Deller
On 22.10.2015 23:37, Tom Herbert wrote: > On Thu, Oct 22, 2015 at 1:00 PM, Helge Deller wrote: >> Hi Tom & David, >> >> I've queued-up a patch for the parisc architecture which reduces >> L1_CACHE_BYTES from 32 to 16: >> https://patchwork.kernel.org/patch/7399291/ >> >> But this change will bre

[PATCH net-next] net: dsa: bcm_sf2: Unhardcode port numbers

2015-10-23 Thread Florian Fainelli
While the current driver mostly supports BCM7445 which has a hardcoded location for its MoCA port on port 7 and port 0 for its internal PHY, this is not necessarily true for all other chips out there such as BCM3390 for instance. Walk the list of ports from Device Tree, get their port number ("reg

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-23 Thread Alex Williamson
On Fri, 2015-10-23 at 11:36 -0700, Alexander Duyck wrote: > On 10/21/2015 09:37 AM, Lan Tianyu wrote: > > This patchset is to propose a new solution to add live migration support > > for 82599 > > SRIOV network card. > > > > Im our solution, we prefer to put all device specific operation into VF a

[PATCH net-next] bnxt_en: Fix compile errors when CONFIG_BNXT_SRIOV is not set.

2015-10-23 Thread Michael Chan
struct bnxt_pf_info needs to be always defined. Move bnxt_update_vf_mac() to bnxt_sriov.c and add some missing #ifdef CONFIG_BNXT_SRIOV. Reported-by: Jim Hull Tested-by: Jim Hull Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 32 ++--- dr

[PATCH 0/2] Netronome NFP4000/NFP6000 NIC VF driver

2015-10-23 Thread Jakub Kicinski
This patchset adds support for VFs of Netronome's NFP-4000 and NFP-6000 based NICs. We are currently also preparing the submission for the PF driver, but it is not quite ready yet. The PF driver can be found on GitHub: https://github.com/Netronome/nfp-drv-kmods Jakub Kicinski (2): pci_ids: add

[PATCH 1/2] pci_ids: add Netronome Systems vendor

2015-10-23 Thread Jakub Kicinski
Add PCI vendor id for Netronome Systems. Signed-off-by: Jakub Kicinski Signed-off-by: Rolf Neugebauer --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index d9ba49cedc5d..1acbefc4bbda 100644 --- a/include/linux/p

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-23 Thread David Holland
On Wed, Oct 21, 2015 at 03:38:51PM +0100, Alan Burlison wrote: > On 21/10/2015 04:49, Al Viro wrote: > >BTW, for real fun, consider this: > >7) > >// fd is a socket > >fd2 = dup(fd); > >in thread A: accept(fd); > >in thread B: accept(fd); > >in thread C: accept(fd2); > >in thread D: close(

[PATCH net-next] net: dsa: bcm_sf2: Implement FDB operations

2015-10-23 Thread Florian Fainelli
Add support for the FDB add, delete, and dump operations. The add and delete operations are implemented using directed ARL operations using the specified MAC address and consist in a read operation, write and readback operation. The dump operation consists in using the ARL search and software filt

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-23 Thread Alexander Duyck
On 10/21/2015 09:37 AM, Lan Tianyu wrote: This patchset is to propose a new solution to add live migration support for 82599 SRIOV network card. Im our solution, we prefer to put all device specific operation into VF and PF driver and make code in the Qemu more general. VF status migration ==

Re: [PATCH net v3] openvswitch: Fix egress tunnel info.

2015-10-23 Thread Jiri Benc
On Fri, 23 Oct 2015 10:30:24 -0700, Pravin Shelar wrote: > I see lot of refactoring scope for vxlan code even without this patch. > I am planing to address it in net-next. Great, thanks a lot! > > What about IPv6? There's IPv6 support for metadata based vxlan in > > net.git, thus this should have

Re: [PATCH net-next 1/2] drivers: net: xgene: Add support RGMII TX/RX delay configuration

2015-10-23 Thread Iyappan Subramanian
On Fri, Oct 16, 2015 at 2:36 PM, Florian Fainelli wrote: > On 16/10/15 13:35, Iyappan Subramanian wrote: >> Add RGMII TX/RX delay configuration support. RGMII standard requires 2ns >> delay to help the RGMII bridge receiver to sample data correctly. If the >> default value does not provide proper

[PATCH net-next] af_unix: do not report POLLOUT on listeners

2015-10-23 Thread Eric Dumazet
From: Eric Dumazet poll(POLLOUT) on a listener should not report fd is ready for a write(). This would break some applications using poll() and pfd.events = -1, as they would not block in poll() Signed-off-by: Eric Dumazet Reported-by: Alan Burlison Tested-by: Eric Dumazet --- net/unix/af_u

[iproute RFC PATCH 6/9] tc: add a man page for route filter

2015-10-23 Thread Phil Sutter
Cc: Alexey Kuznetsov Signed-off-by: Phil Sutter --- man/man8/tc-route.8 | 74 + 1 file changed, 74 insertions(+) create mode 100644 man/man8/tc-route.8 diff --git a/man/man8/tc-route.8 b/man/man8/tc-route.8 new file mode 100644 index 000.

[iproute RFC PATCH 8/9] tc: add a man page for u32 filter

2015-10-23 Thread Phil Sutter
Cc: Alexey Kuznetsov Signed-off-by: Phil Sutter --- man/man8/tc-u32.8 | 663 ++ 1 file changed, 663 insertions(+) create mode 100644 man/man8/tc-u32.8 diff --git a/man/man8/tc-u32.8 b/man/man8/tc-u32.8 new file mode 100644 index 000..090f

[iproute RFC PATCH 1/9] tc: add a man page for basic filter

2015-10-23 Thread Phil Sutter
Cc: Thomas Graf Signed-off-by: Phil Sutter --- man/man8/tc-basic.8 | 34 ++ 1 file changed, 34 insertions(+) create mode 100644 man/man8/tc-basic.8 diff --git a/man/man8/tc-basic.8 b/man/man8/tc-basic.8 new file mode 100644 index 000..fb39eaa --- /dev/null +

[iproute RFC PATCH 3/9] tc: add a man page for flow filter

2015-10-23 Thread Phil Sutter
Cc: Patrick McHardy Signed-off-by: Phil Sutter --- man/man8/tc-flow.8 | 265 + 1 file changed, 265 insertions(+) create mode 100644 man/man8/tc-flow.8 diff --git a/man/man8/tc-flow.8 b/man/man8/tc-flow.8 new file mode 100644 index 000..f1

[iproute RFC PATCH 4/9] tc: add a man page for flower filter

2015-10-23 Thread Phil Sutter
Cc: Jiri Pirko Signed-off-by: Phil Sutter --- man/man8/tc-flower.8 | 113 +++ 1 file changed, 113 insertions(+) create mode 100644 man/man8/tc-flower.8 diff --git a/man/man8/tc-flower.8 b/man/man8/tc-flower.8 new file mode 100644 index 000..d

[iproute RFC PATCH 7/9] tc: add a man page for tcindex filter

2015-10-23 Thread Phil Sutter
Cc: Werner Almesberger Signed-off-by: Phil Sutter --- man/man8/tc-tcindex.8 | 58 +++ 1 file changed, 58 insertions(+) create mode 100644 man/man8/tc-tcindex.8 diff --git a/man/man8/tc-tcindex.8 b/man/man8/tc-tcindex.8 new file mode 100644 index

[iproute RFC PATCH 2/9] tc: add a man page for cgroup filter

2015-10-23 Thread Phil Sutter
Cc: Thomas Graf Signed-off-by: Phil Sutter --- man/man8/tc-cgroup.8 | 80 1 file changed, 80 insertions(+) create mode 100644 man/man8/tc-cgroup.8 diff --git a/man/man8/tc-cgroup.8 b/man/man8/tc-cgroup.8 new file mode 100644 index 000..2

[iproute RFC PATCH 5/9] tc: add a man page for fw filter

2015-10-23 Thread Phil Sutter
Cc: Alexey Kuznetsov Signed-off-by: Phil Sutter --- man/man8/tc-fw.8 | 66 1 file changed, 66 insertions(+) create mode 100644 man/man8/tc-fw.8 diff --git a/man/man8/tc-fw.8 b/man/man8/tc-fw.8 new file mode 100644 index 000..d742b47

[iproute RFC PATCH 0/9] Document tc filters

2015-10-23 Thread Phil Sutter
This series adds documentation in form of a dedicated man page for every available tc filter with the exception of rsvp which I simply didn't understand. In addition to that, it adds a list of filters with (very) basic description to tc.8, listing the specific man pages for detailed information. I

[iproute RFC PATCH 9/9] tc: ship filter man pages and refer to them in tc.8

2015-10-23 Thread Phil Sutter
Cc: Thomas Graf Cc: Alexey Kuznetsov Cc: Jiri Pirko Cc: Patrick McHardy Cc: Werner Almesberger Signed-off-by: Phil Sutter --- man/man8/Makefile | 4 +++- man/man8/tc.8 | 52 2 files changed, 55 insertions(+), 1 deletion(-) diff --gi

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-23 Thread Eric Dumazet
On Fri, 2015-10-23 at 17:40 +0100, Alan Burlison wrote: > On 23/10/2015 17:19, Eric Dumazet wrote: > > >>> The AF_UNIX poll one? No, I don't have the means to do so, and in any > >>> case that's not a POSIX issue, just a plain bug. I'm happy to log a bug > >>> if that helps. > > > > BTW, there is

Re: [PATCH 3/3] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-10-23 Thread Florian Fainelli
On 23/10/15 08:20, Måns Rullgård wrote: > Florian Fainelli writes: > >> On 22/10/15 07:02, Mans Rullgard wrote: >>> This adds a driver for the Aurora VLSI NB8800 Ethernet controller. >>> It is an almost complete rewrite of a driver originally found in >>> a Sigma Designs 2.6.22 tree. >> >> Some r

Hi friend. I want to transfer an abandonedUSD5.5Million into your account for us to share it. Contact me for details.

2015-10-23 Thread SMITH AWALI
-- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v6 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-23 Thread Punit Vara
This warning is reported by coccicheck: Signed-off-by: Punit Vara --- drivers/net/wireless/ath/wcn36xx/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index 900e72a..94bcc08 100644 --

Re: [PATCH net v3] openvswitch: Fix egress tunnel info.

2015-10-23 Thread Pravin Shelar
On Fri, Oct 23, 2015 at 5:17 AM, Jiri Benc wrote: > On Thu, 22 Oct 2015 18:17:16 -0700, Pravin B Shelar wrote: >> While transitioning to netdev based vport we broke OVS >> feature which allows user to retrieve tunnel packet egress >> information for lwtunnel devices. Following patch fixes it >> b

Re: [PATCH net-next 2/3] bpf: introduce bpf_perf_event_output() helper

2015-10-23 Thread Alexei Starovoitov
On 10/23/15 9:42 AM, Peter Zijlstra wrote: On Fri, Oct 23, 2015 at 08:02:00AM -0700, Alexei Starovoitov wrote: On 10/23/15 7:39 AM, Peter Zijlstra wrote: On Tue, Oct 20, 2015 at 08:02:34PM -0700, Alexei Starovoitov wrote: +static const struct bpf_func_proto bpf_perf_event_output_proto = { +

[iproute PATCH] tc: u32 filter coding style cleanup

2015-10-23 Thread Phil Sutter
Add missing spaces around operators to increase readability. Aside from that, make "preference" match a real synonym for "tos" and "dsfield" as it's effect was identical to them. Signed-off-by: Phil Sutter --- tc/f_u32.c | 56 +++- 1 file chang

[iproute PATCH] tc: improve filter help texts a bit

2015-10-23 Thread Phil Sutter
This fixes a few syntax errors and changes route filter help text to use classid instead of flowid to be consistent with other filters' help texts. Signed-off-by: Phil Sutter --- tc/f_flower.c | 4 ++-- tc/f_route.c | 2 +- tc/f_rsvp.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-23 Thread Al Viro
On Thu, Oct 22, 2015 at 09:50:10PM +0200, casper@oracle.com wrote: > >Sigh... It completely fails to mention descriptor-passing. Which > > a) is relevant to what "last close" means and > > b) had been there for nearly the third of a century. > > Why is that different? These clearly

Re: ip_no_pmtu_disc and UDP

2015-10-23 Thread Vincent Li
I think the no_pmtu_disc could be renamed to pmtu_disc to be less confusion to users. pmtu_disc: IP_PMTUDISC_DONT, clear DF bit pmtu_disc: IP_PMTUDISC_WANT, set DF bit just my .2 cents On Fri, Oct 23, 2015 at 9:45 AM, Vincent Li wrote: > Hi, > > It looks ip_no_pmtu_disc setting does not affec

Re: [PATCH net] amd-xgbe: Use wmb before updating current descriptor count

2015-10-23 Thread Tom Lendacky
On 10/23/2015 11:29 AM, Alexander Duyck wrote: On 10/21/2015 01:37 PM, Tom Lendacky wrote: The code currently uses the lightweight dma_wmb barrier before updating the current descriptor count. Under heavy load, the Tx cleanup routine was seeing the updated current descriptor count before the upd

ip_no_pmtu_disc and UDP

2015-10-23 Thread Vincent Li
Hi, It looks ip_no_pmtu_disc setting does not affect UDP IP packet DF bit setting, is that intended behavior? echo 0, 1, 2, 3 respectively to ip_no_pmtu_disc, UDP IP packet always have DF bit cleared, unless use IP_PMTUDISC_DO on IP_MTU_DISCOVER as ip man page says. in inet_create, seems to prove

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-23 Thread Alan Burlison
On 23/10/2015 17:19, Eric Dumazet wrote: The AF_UNIX poll one? No, I don't have the means to do so, and in any case that's not a POSIX issue, just a plain bug. I'm happy to log a bug if that helps. BTW, there is no kernel bug here. POSIX poll() man page says : POLLOUT Normal data may be

Re: [PATCH net-next 2/3] bpf: introduce bpf_perf_event_output() helper

2015-10-23 Thread Peter Zijlstra
On Fri, Oct 23, 2015 at 08:02:00AM -0700, Alexei Starovoitov wrote: > On 10/23/15 7:39 AM, Peter Zijlstra wrote: > >On Tue, Oct 20, 2015 at 08:02:34PM -0700, Alexei Starovoitov wrote: > >>>+static const struct bpf_func_proto bpf_perf_event_output_proto = { > >>>+ .func = bpf_perf_event_o

Re: [PATCH net] amd-xgbe: Use wmb before updating current descriptor count

2015-10-23 Thread Alexander Duyck
On 10/21/2015 01:37 PM, Tom Lendacky wrote: The code currently uses the lightweight dma_wmb barrier before updating the current descriptor count. Under heavy load, the Tx cleanup routine was seeing the updated current descriptor count before the updated descriptor information. As a result, the Tx

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-23 Thread Eric Dumazet
On Fri, 2015-10-23 at 09:00 -0700, Eric Dumazet wrote: > on the pages you think there is an error that matters. > > > > > > Have you tested the patch I sent ? > > > > The AF_UNIX poll one? No, I don't have the means to do so, and in any > > case that's not a POSIX issue, just a plain bug. I'm h

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-23 Thread Alan Burlison
On 23/10/2015 17:00, Eric Dumazet wrote: Ermm, you *really* want me to submit a patch removing 'Conforms to POSIX.1-2001' from *every* Linux manpage? Only on the pages you think there is an error that matters. If there's consensus that the current shutdown(), dup2(), close() and accept() be

  1   2   3   >