Re: [PATCH] man: Syntax and warning fixes

2015-11-09 Thread Ville Skyttä
On Mon, Nov 9, 2015 at 11:40 AM, Albino B Neto wrote: > 2015-11-07 7:55 GMT-02:00 Ville Skyttä : >>> Signed-off-by and description ? >> >> Superseding patches sent separately. I suggest documenting the >> requirement for Signed-off-by somewhere (README.devel?); > > Please read the Documentation/Su

PING: [PATCH] net: smsc911x: Reset PHY during initialization

2015-11-09 Thread Pavel Fedin
Hello! So, what should we do with this? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Pavel > Fedin > Sent: Monday, November 02, 2015 10:

Re: [PATCH RFC 5/6] net/faraday: Enable NCSI interface

2015-11-09 Thread Gavin Shan
On Tue, Nov 10, 2015 at 07:28:24AM +1100, Benjamin Herrenschmidt wrote: >On Mon, 2015-11-09 at 18:30 +1100, Gavin Shan wrote: >> >> Yeah, It's something that I hilighed in the cover letter. I was >> thinking we might need a better way to enable Tx/Rx before the >> interrupt is up, but couldn't fig

Re: [PATCH] drivers: net: cpsw: add support for fixed-links.

2015-11-09 Thread David Miller
From: Daniel Trautmann Date: Mon, 9 Nov 2015 20:24:14 +0100 > Add support for fixed-links in configurations without PHY. > (e.g. connection to a switch, SGMII point to point, SFPs) > > Check: Documentation/devicetree/bindings/net/fixed-link.txt. > > Signed-off-by: Daniel Trautmann This patch

Re: [PATCH] drivers: net: cpsw: add support for fixed-links.

2015-11-09 Thread David Miller
From: Daniel Trautmann Date: Mon, 9 Nov 2015 20:24:14 +0100 > @@ -2039,19 +2039,35 @@ static int cpsw_probe_dt(struct cpsw_priv *priv, > priv->phy_node = of_parse_phandle(slave_node, "phy-handle", 0); > parp = of_get_property(slave_node, "phy_id", &lenp); >

Re: Deadlock between bind and splice

2015-11-09 Thread Al Viro
On Tue, Nov 10, 2015 at 02:38:54AM +, Al Viro wrote: > On Fri, Nov 06, 2015 at 07:42:15AM -0800, Eric Dumazet wrote: > > > Thank you for this report. > > > > pipe is part of fs, not net ;) > > AF_UNIX bind() vs. socketpair() interplay, OTOH... FWIW, BSD folks unlock the socket for the durat

Re: [PATCH net] net: fix a race in dst_release()

2015-11-09 Thread David Miller
From: Eric Dumazet Date: Mon, 09 Nov 2015 17:51:23 -0800 > From: Eric Dumazet > > Only cpu seeing dst refcount going to 0 can safely > dereference dst->flags. > > Otherwise an other cpu might already have freed the dst. > > Fixes: 27b75c95f10d ("net: avoid RCU for NOCACHE dst") > Reported-by

Re: [PATCH] net: mvneta: Fix memory use after free.

2015-11-09 Thread David Miller
From: Justin Maggard Date: Mon, 9 Nov 2015 17:21:05 -0800 > After changing an interface's MTU, then bringing the interface down and > back up again, I immediately saw tons of kernel messages like below. > The reason for this bad behavior is mvneta_rxq_drop_pkts(), which calls > dma_unmap_single(

Re: Deadlock between bind and splice

2015-11-09 Thread Al Viro
On Fri, Nov 06, 2015 at 07:42:15AM -0800, Eric Dumazet wrote: > Thank you for this report. > > pipe is part of fs, not net ;) AF_UNIX bind() vs. socketpair() interplay, OTOH... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.

Re: [PATCH v3 net-next 4/4] net: af_unix: implement splice for stream af_unix sockets

2015-11-09 Thread Hannes Frederic Sowa
Hallo, On Tue, Nov 10, 2015, at 02:11, Eric Dumazet wrote: > On Thu, 2015-05-21 at 17:00 +0200, Hannes Frederic Sowa wrote: > > > + > > +static ssize_t skb_unix_socket_splice(struct sock *sk, > > + struct pipe_inode_info *pipe, > > +

Re: Deadlock between bind and splice

2015-11-09 Thread Al Viro
On Fri, Nov 06, 2015 at 01:58:27PM +0100, Dmitry Vyukov wrote: > Hello, > > I am on revision d1e41ff11941784f469f17795a4d9425c2eb4b7a (Nov 5) and > seeing the following lockdep reports. I don't have exact reproducer > program as it is caused by several independent programs (state > accumulated in

[PATCH net] net: fix a race in dst_release()

2015-11-09 Thread Eric Dumazet
From: Eric Dumazet Only cpu seeing dst refcount going to 0 can safely dereference dst->flags. Otherwise an other cpu might already have freed the dst. Fixes: 27b75c95f10d ("net: avoid RCU for NOCACHE dst") Reported-by: Greg Thelen Signed-off-by: Eric Dumazet --- net/core/dst.c |2 +- 1

[PATCH] net: mvneta: Fix memory use after free.

2015-11-09 Thread Justin Maggard
After changing an interface's MTU, then bringing the interface down and back up again, I immediately saw tons of kernel messages like below. The reason for this bad behavior is mvneta_rxq_drop_pkts(), which calls dma_unmap_single() on already-freed memory. So we need to switch the order of those t

Re: [PATCH v3 net-next 4/4] net: af_unix: implement splice for stream af_unix sockets

2015-11-09 Thread Eric Dumazet
On Thu, 2015-05-21 at 17:00 +0200, Hannes Frederic Sowa wrote: > + > +static ssize_t skb_unix_socket_splice(struct sock *sk, > + struct pipe_inode_info *pipe, > + struct splice_pipe_desc *spd) > +{ > + int ret; > + struct

[PATCH v3 1/4] e1000e: Remove unreachable code

2015-11-09 Thread Benjamin Poirier
msi-x interrupts are not shared so there's no need to check if the interrupt was really from this adapter. Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/e1000e/netdev.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers

[PATCH v3 0/4] e1000e msi-x fixes

2015-11-09 Thread Benjamin Poirier
Hi, For this series: Benjamin Poirier (4): e1000e: Remove unreachable code e1000e: Do not read icr in Other interrupt e1000e: Do not write lsc to ics in msi-x mode e1000e: Fix msi-x interrupt automask drivers/net/ethernet/intel/e1000e/defines.h | 3 +- drivers/net/ethernet/intel/e1000

[PATCH v3 3/4] e1000e: Do not write lsc to ics in msi-x mode

2015-11-09 Thread Benjamin Poirier
In msi-x mode, there is no handler for the lsc interrupt so there is no point in writing that to ics now that we always assume Other interrupts are caused by lsc. Reviewed-by: Jasna Hodzic Signed-off-by: Benjamin Poirier --- drivers/net/ethernet/intel/e1000e/defines.h | 3 ++- drivers/net/ethe

[PATCH v3 2/4] e1000e: Do not read icr in Other interrupt

2015-11-09 Thread Benjamin Poirier
removes the icr read in the other interrupt handler, uses eiac to autoclear the Other bit from icr and ims. This allows us to avoid interference with rx and tx interrupts in the Other interrupt handler. The information read from icr is not needed. IMS is configured such that the only interrupt cau

[PATCH v3 4/4] e1000e: Fix msi-x interrupt automask

2015-11-09 Thread Benjamin Poirier
Since the introduction of 82574 support in e1000e, the driver has worked on the assumption that msi-x interrupt generation is automatically disabled after each irq. As it turns out, this is not the case. Currently, rx interrupts can fire multiple times before and during napi processing. This can be

Re: [RFC PATCH net-next v2 0/8] openvswitch: NAT support.

2015-11-09 Thread Jarno Rajahalme
[Resending as plain text] > On Nov 9, 2015, at 5:31 AM, Patrick McHardy wrote: > > On 06.11, Jarno Rajahalme wrote: >> This series adds NAT support to openvswitch kernel module. A few >> changes are needed to the netfilter code to facilitate this (patches >> 1-3/8). Patches 4-7 make the openvs

Re: Fw: [Bug 106711] VXLAN: RTNL assertion failed at net/core/net_namespace.c:187

2015-11-09 Thread Cong Wang
On Mon, Nov 9, 2015 at 10:39 AM, Stephen Hemminger wrote: > > > Begin forwarded message: > > Date: Mon, 9 Nov 2015 09:42:52 + > From: "bugzilla-dae...@bugzilla.kernel.org" > > To: "shemmin...@linux-foundation.org" > Subject: [Bug 106711] VXLAN: RTNL assertion failed at > net/core/net_names

RE: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()

2015-11-09 Thread Luck, Tony
> ACK for the ACPI changes (and CCing Tony and Boris for the heads-up as they > are way more famailiar with the APEI code than I am). Sure. If kvfree() really is smart enough to figure it out then there it no point in the if (blah) kfree() else vfree(). The drivers/acpi/apei/erst.c code isn't doi

Re: linux-next network throughput performance regression

2015-11-09 Thread Eric Dumazet
On Mon, 2015-11-09 at 20:23 +, Simon Xiao wrote: > Thanks Eric to provide the data. I am looping Tom (as I am looking into his > recent patches) and Olaf (from Suse). > > So, if I understand it correctly, you are running netperf with single > TCP connection, and you got ~26Gbps initially and

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue

2015-11-09 Thread Jason Baron
On 11/09/2015 09:40 AM, Rainer Weikusat wrote: > An AF_UNIX datagram socket being the client in an n:1 association with > some server socket is only allowed to send messages to the server if the > receive queue of this socket contains at most sk_max_ack_backlog > datagrams. This implies that prospe

Re: [PATCH] inet: delay address promotion check until last request in message

2015-11-09 Thread Neil Horman
On Mon, Nov 09, 2015 at 10:35:42PM +0200, Julian Anastasov wrote: > > Hello, > > On Sun, 8 Nov 2015, Neil Horman wrote: > > > On Sat, Nov 07, 2015 at 01:49:25AM +0200, Julian Anastasov wrote: > > > > > > flush can provide many parameters. As there is no > > > any kind of indication in t

Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()

2015-11-09 Thread Rafael J. Wysocki
On Monday, November 09, 2015 08:56:10 PM Tetsuo Handa wrote: > There are many locations that do > > if (memory_was_allocated_by_vmalloc) > vfree(ptr); > else > kfree(ptr); > > but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory > using is_vmalloc_addr(). Unless call

Re: [PATCH v4 1/4] Produce system time from correlated clocksource

2015-11-09 Thread John Stultz
On Tue, Nov 3, 2015 at 11:18 AM, Stanton, Kevin B wrote: > On Wed, 21 Oct 2015, Thomas Gleixner wrote: >> On Tue, 20 Oct 2015, John Stultz wrote: >>> Being able to have various hardware sharing a time base is quite >>> useful, and methods for correlating timestamps together are useful. >>> But I d

Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()

2015-11-09 Thread Dilger, Andreas
On 2015/11/09, 04:56, "Tetsuo Handa" wrote: >There are many locations that do > > if (memory_was_allocated_by_vmalloc) >vfree(ptr); > else >kfree(ptr); > >but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory >using is_vmalloc_addr(). Unless callers have special reasons

Re: [PATCH] inet: delay address promotion check until last request in message

2015-11-09 Thread Julian Anastasov
Hello, On Sun, 8 Nov 2015, Neil Horman wrote: > On Sat, Nov 07, 2015 at 01:49:25AM +0200, Julian Anastasov wrote: > > > > flush can provide many parameters. As there is no > > any kind of indication in the netlink message that all addresses > > are removed, we can not avoid the prom

Re: [PATCH RFC 5/6] net/faraday: Enable NCSI interface

2015-11-09 Thread Benjamin Herrenschmidt
On Mon, 2015-11-09 at 18:30 +1100, Gavin Shan wrote: > > Yeah, It's something that I hilighed in the cover letter. I was > thinking we might need a better way to enable Tx/Rx before the > interrupt is up, but couldn't figure out one way. So I need some > advice here. No, that's not right. For Tx/

RE: linux-next network throughput performance regression

2015-11-09 Thread Simon Xiao
Thanks Eric to provide the data. I am looping Tom (as I am looking into his recent patches) and Olaf (from Suse). So, if I understand it correctly, you are running netperf with single TCP connection, and you got ~26Gbps initially and got ~30Gbps after turning the tx-usecs and tx-frames. Do you

Re: [PATCH] arm64: bpf: fix JIT stack setup

2015-11-09 Thread Z Lim
On Mon, Nov 9, 2015 at 10:08 AM, Shi, Yang wrote: > I added it to stay align with ARMv8 AAPCS to maintain the correct FP during > function call. It makes us get correct stack backtrace. > > I think we'd better to keep compliant with ARMv8 AAPCS in BPF JIT prologue > too. > > If nobody thinks it is

Re: [PATCH RFC net-next 0/2] tcp: Redundant Data Bundling (RDB)

2015-11-09 Thread Bendik Rønning Opstad
On 24/10/15 14:57, Eric Dumazet wrote: > Thank you for this very high quality patch submission. > > Please give us a few days for proper evaluation. > > Thanks ! Guys, thank you very much for taking the time to evaluate this. Since there haven't been any more feedback or comments I'll submit an R

[PATCH] drivers: net: cpsw: add support for fixed-links.

2015-11-09 Thread Daniel Trautmann
Add support for fixed-links in configurations without PHY. (e.g. connection to a switch, SGMII point to point, SFPs) Check: Documentation/devicetree/bindings/net/fixed-link.txt. Signed-off-by: Daniel Trautmann --- drivers/net/ethernet/ti/cpsw.c | 40 1 f

Re: [PATCH] packet: Allow packets with only a header (but no payload)

2015-11-09 Thread Felix Fietkau
On 2015-11-09 18:53, Willem de Bruijn wrote: > On Sat, Nov 7, 2015 at 8:11 AM, Felix Fietkau wrote: >> On 2015-07-31 00:15, Martin Blumenstingl wrote: >>> On Wed, Jul 29, 2015 at 8:05 AM, Willem de Bruijn >>> wrote: Martin, to return to your initial statement that PPPoE PADI packets can >>>

Re: [iproute PATCH v2 4/6] ipaddress: fix ipaddr_flush for Linux >= 3.1

2015-11-09 Thread Sergei Shtylyov
On 11/09/2015 09:51 PM, Sergei Shtylyov wrote: Linux version 3.1 introduced a consistency check for netlink dumps in commit 670dc28 ("netlink: advertise incomplete dumps"). This bites The scripts/checkpatch.pl now enforces 12-digit commit ID... Sorry, didn't realize it wasn't a kernel

Re: [iproute PATCH v2 4/6] ipaddress: fix ipaddr_flush for Linux >= 3.1

2015-11-09 Thread Sergei Shtylyov
Hello. On 11/08/2015 11:22 PM, Phil Sutter wrote: Linux version 3.1 introduced a consistency check for netlink dumps in commit 670dc28 ("netlink: advertise incomplete dumps"). This bites The scripts/checkpatch.pl now enforces 12-digit commit ID... iproute2 when flushing more addresses th

Fw: [Bug 107551] New: IPV4 Reassembling Problem

2015-11-09 Thread Stephen Hemminger
Begin forwarded message: Date: Mon, 9 Nov 2015 11:04:29 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 107551] New: IPV4 Reassembling Problem https://bugzilla.kernel.org/show_bug.cgi?id=107551 Bug ID: 107551 Summ

Fw: [Bug 106711] VXLAN: RTNL assertion failed at net/core/net_namespace.c:187

2015-11-09 Thread Stephen Hemminger
Begin forwarded message: Date: Mon, 9 Nov 2015 09:42:52 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 106711] VXLAN: RTNL assertion failed at net/core/net_namespace.c:187 https://bugzilla.kernel.org/show_bug.cgi?id=106711 Kari Hautio

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue

2015-11-09 Thread David Miller
From: Rainer Weikusat Date: Mon, 09 Nov 2015 14:40:48 + > + __remove_wait_queue(&unix_sk(u->peer_wake.private)->peer_wait, > + &u->peer_wake); This is more simply: __remove_wait_queue(&unix_sk(u->peer_wake.private)->peer_wait, q); > +static inline int un

Re: [RFC PATCH 0/2] net: mvneta: Introduce RSS support

2015-11-09 Thread Gregory CLEMENT
Hi Marcin, On ven., nov. 06 2015, Marcin Wojtas wrote: > Hi Gregory, > > >> I also choose to associate all the TX queues on the same CPU that the >> one associated to the RX queue. It allows to contain all the >> interrupts on the same CPU. I think that an improvement on this side >> would be

Re: [PATCH] arm64: bpf: fix JIT stack setup

2015-11-09 Thread Shi, Yang
On 11/8/2015 2:29 PM, Z Lim wrote: On Sat, Nov 7, 2015 at 6:27 PM, Alexei Starovoitov wrote: On Fri, Nov 06, 2015 at 09:36:17PM -0800, Yang Shi wrote: ARM64 JIT used FP (x29) as eBPF fp register, but FP is subjected to change during function call so it may cause the BPF prog stack base address

Re: [PATCH] packet: Allow packets with only a header (but no payload)

2015-11-09 Thread Willem de Bruijn
On Sat, Nov 7, 2015 at 8:11 AM, Felix Fietkau wrote: > On 2015-07-31 00:15, Martin Blumenstingl wrote: >> On Wed, Jul 29, 2015 at 8:05 AM, Willem de Bruijn wrote: >>> Martin, to return to your initial statement that PPPoE PADI packets can >>> have a zero payload: the PPPoE RFC states that PADI pa

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Russell King - ARM Linux
On Mon, Nov 09, 2015 at 06:08:49PM +0100, Andrew Lunn wrote: > You use fixed-phy when the MAC is connected to a switch, not a phy. Or > when the MAC is connected to an SFP module. ... hopefully not for much longer. Once -rc1 is out, I'll sort out posting my phylink and SFP module hotplug support

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Russell King - ARM Linux
On Mon, Nov 09, 2015 at 06:12:02PM +0100, Arnd Bergmann wrote: > On Monday 09 November 2015 17:08:34 Russell King - ARM Linux wrote: > > They are "optional" because when you're using a DSA switch, you don't > > specify a PHY (because, there isn't one). For example, this is what > > I'm using with

Re: network stream fairness

2015-11-09 Thread Eric Dumazet
On Mon, 2015-11-09 at 17:50 +0100, Niklas Cassel wrote: > > for i in `seq 1 20`; do ss -temoi dst 192.168.0.141; sleep 1; done ... > ESTAB 0 0192.168.0.1:54578 > 192.168.0.141:5201 rto:0.2 ato:0.04 cwnd:10 uid:20283 > ino:7

Re: [PATCH RESEND] net: Documentation: Fix default value tcp_limit_output_bytes

2015-11-09 Thread David Miller
From: Niklas Cassel Date: Mon, 9 Nov 2015 15:59:00 +0100 > Commit c39c4c6abb89 ("tcp: double default TSQ output bytes limit") > updated default value for tcp_limit_output_bytes > > Signed-off-by: Niklas Cassel Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Arnd Bergmann
On Monday 09 November 2015 18:08:49 Andrew Lunn wrote: > > > I suppose it comes down to, are we allowed to optionally implement > > > part of the DT binding? > > > > I'm not sure what you are asking. A lot of DT bindings have both > > optional and mandatory properties. For mvneta, the "phy" and "p

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Arnd Bergmann
On Monday 09 November 2015 17:08:34 Russell King - ARM Linux wrote: > They are "optional" because when you're using a DSA switch, you don't > specify a PHY (because, there isn't one). For example, this is what > I'm using with an Armada 388 board with a Marvell DSA switch. The > DSA does not appe

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Russell King - ARM Linux
On Mon, Nov 09, 2015 at 05:57:43PM +0100, Arnd Bergmann wrote: > I'm not sure what you are asking. A lot of DT bindings have both > optional and mandatory properties. For mvneta, the "phy" and "phy-mode" > properties are listed as mandatory, so the driver can safely assume > that they are always pr

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Andrew Lunn
> > I suppose it comes down to, are we allowed to optionally implement > > part of the DT binding? > > I'm not sure what you are asking. A lot of DT bindings have both > optional and mandatory properties. For mvneta, the "phy" and "phy-mode" > properties are listed as mandatory, so the driver can

Re: [PATCH] macvtap: Resolve possible __might_sleep warning in macvtap_do_read()

2015-11-09 Thread David Miller
From: Vladislav Yasevich Date: Mon, 9 Nov 2015 09:14:17 -0500 > macvtap_do_read code calls macvtap_put_user while it might be set up > to wait for the user. This results in the following warning: ... > Make sure thet we call finish_wait() if we have the skb to process > before trying to actual

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Arnd Bergmann
On Monday 09 November 2015 17:42:32 Andrew Lunn wrote: > On Mon, Nov 09, 2015 at 03:08:57PM +0100, Arnd Bergmann wrote: > > The fixed_phy infrastructure is done in a way that is optional, > > by providing 'static inline' helper functions doing nothing in > > include/linux/phy_fixed.h for all its AP

Re: network stream fairness

2015-11-09 Thread Niklas Cassel
On 11/09/2015 05:24 PM, Eric Dumazet wrote: > On Mon, 2015-11-09 at 08:07 -0800, Eric Dumazet wrote: > >> Your numbers suggest a cwnd growth then, which might show a CC bug. >> >> Please run the following when your iper3 runs on regular 4.3 kernel >> >> for i in `seq 1 10` >> do >> ss -temoi dst 1

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Andrew Lunn
On Mon, Nov 09, 2015 at 03:08:57PM +0100, Arnd Bergmann wrote: > The fixed_phy infrastructure is done in a way that is optional, > by providing 'static inline' helper functions doing nothing in > include/linux/phy_fixed.h for all its APIs. However, three out > of the four users (DSA, BCMGENET, and

Re: [PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread David Miller
From: Arnd Bergmann Date: Mon, 09 Nov 2015 15:08:57 +0100 > The fixed_phy infrastructure is done in a way that is optional, > by providing 'static inline' helper functions doing nothing in > include/linux/phy_fixed.h for all its APIs. However, three out > of the four users (DSA, BCMGENET, and SYS

Re: [PATCH] net: caif: check return value of alloc_netdev

2015-11-09 Thread David Miller
From: Rasmus Villemoes Date: Mon, 9 Nov 2015 13:19:10 +0100 > I don't know if dev can actually be NULL here, but the test should be > above alloc_netdev(), to avoid leaking the struct net_device in case > dev is actually NULL. And of course the return value from alloc_netdev > should be tested.

Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()

2015-11-09 Thread David Miller
From: Jan Kara Date: Mon, 9 Nov 2015 13:11:26 +0100 > You can add > > Acked-by: Jan Kara > > for the UDF and fs/xattr.c parts. Please do not quote and entire large patch just to give an ACK. Just quote the minimum necessary context, which is usually just the commit message. -- To unsubscribe

Re: network stream fairness

2015-11-09 Thread Eric Dumazet
On Mon, 2015-11-09 at 08:07 -0800, Eric Dumazet wrote: > Your numbers suggest a cwnd growth then, which might show a CC bug. > > Please run the following when your iper3 runs on regular 4.3 kernel > > for i in `seq 1 10` > do > ss -temoi dst 192.168.0.141 > sleep 1 > done > Another thing to tr

Re: [PATCH] net: hisilicon: NET_VENDOR_HISILICON should depend on HAS_DMA

2015-11-09 Thread David Miller
From: Geert Uytterhoeven Date: Mon, 9 Nov 2015 10:34:30 +0100 > If NO_DMA=y: ... > As this affects all of HNS_ENET, HNS_DSAF, HNS, HIX5HD2_GMAC, and > HIP04_ETH, add a dependency on HAS_DMA to the main NET_VENDOR_HISILICON > symbol to fix this. > > Signed-off-by: Geert Uytterhoeven Applied,

Re: network stream fairness

2015-11-09 Thread Eric Dumazet
On Mon, 2015-11-09 at 16:53 +0100, Niklas Cassel wrote: > On 11/09/2015 04:50 PM, Eric Dumazet wrote: > > On Mon, 2015-11-09 at 16:41 +0100, Niklas Cassel wrote: > >> I have a ethernet driver for a 100 Mbps NIC. > >> The NIC has dedicated hardware for offloading. > >> The driver has implemented TSO

Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()

2015-11-09 Thread Russell King - ARM Linux
On Mon, Nov 09, 2015 at 08:56:10PM +0900, Tetsuo Handa wrote: > There are many locations that do > > if (memory_was_allocated_by_vmalloc) > vfree(ptr); > else > kfree(ptr); > > but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory > using is_vmalloc_addr(). Unless cal

Re: network stream fairness

2015-11-09 Thread Niklas Cassel
On 11/09/2015 04:50 PM, Eric Dumazet wrote: > On Mon, 2015-11-09 at 16:41 +0100, Niklas Cassel wrote: >> I have a ethernet driver for a 100 Mbps NIC. >> The NIC has dedicated hardware for offloading. >> The driver has implemented TSO, GSO and BQL. >> Since the CPU on the SoC is rather weak, I'd rat

Re: network stream fairness

2015-11-09 Thread Eric Dumazet
On Mon, 2015-11-09 at 16:41 +0100, Niklas Cassel wrote: > I have a ethernet driver for a 100 Mbps NIC. > The NIC has dedicated hardware for offloading. > The driver has implemented TSO, GSO and BQL. > Since the CPU on the SoC is rather weak, I'd rather > not increase the CPU load by turning off off

network stream fairness

2015-11-09 Thread Niklas Cassel
I have a ethernet driver for a 100 Mbps NIC. The NIC has dedicated hardware for offloading. The driver has implemented TSO, GSO and BQL. Since the CPU on the SoC is rather weak, I'd rather not increase the CPU load by turning off offloading. Since commit 605ad7f184b6 ("tcp: refine TSO autosizing")

[PATCH RESEND] net: Documentation: Fix default value tcp_limit_output_bytes

2015-11-09 Thread Niklas Cassel
Commit c39c4c6abb89 ("tcp: double default TSQ output bytes limit") updated default value for tcp_limit_output_bytes Signed-off-by: Niklas Cassel --- Already sent the patch to linux-...@vger.kernel.org, but sending it to netdev@vger.kernel.org too. Documentation/networking/ip-sysctl.txt | 2 +-

[PATCH] unix: avoid use-after-free in ep_remove_wait_queue

2015-11-09 Thread Rainer Weikusat
An AF_UNIX datagram socket being the client in an n:1 association with some server socket is only allowed to send messages to the server if the receive queue of this socket contains at most sk_max_ack_backlog datagrams. This implies that prospective writers might be forced to go to sleep despite no

Re: [PATCH] inet: delay address promotion check until last request in message

2015-11-09 Thread Neil Horman
On Mon, Nov 09, 2015 at 07:31:38AM +0900, David Miller wrote: > From: Neil Horman > Date: Sun, 8 Nov 2015 16:56:41 -0500 > > > All I'm doing is, in effect masking the promote_secondaries sysctl > > for an interface doing a flush operation. > > Packets and other entities not controlled by RTNL ca

Re: [GIT] Networking

2015-11-09 Thread Rasmus Villemoes
On Mon, Nov 09 2015, Hannes Frederic Sowa wrote: > Hi, > > On Wed, Oct 28, 2015, at 15:27, Rasmus Villemoes wrote: >> >> I agree - proper overflow checking can be really hard. Quick, assuming a >> and b have the same unsigned integer type, is 'a+b> check overflow? Of course not (hint: promotion

[PATCH] macvtap: Resolve possible __might_sleep warning in macvtap_do_read()

2015-11-09 Thread Vladislav Yasevich
macvtap_do_read code calls macvtap_put_user while it might be set up to wait for the user. This results in the following warning: Jun 23 16:25:26 galen kernel: [ cut here ] Jun 23 16:25:26 galen kernel: WARNING: CPU: 0 PID: 30433 at kernel/sched/core.c: 7286 __might_sleep+

[PATCH] mvneta: add FIXED_PHY dependency

2015-11-09 Thread Arnd Bergmann
The fixed_phy infrastructure is done in a way that is optional, by providing 'static inline' helper functions doing nothing in include/linux/phy_fixed.h for all its APIs. However, three out of the four users (DSA, BCMGENET, and SYSTEMPORT) always 'select FIXED_PHY', presumably because they need tha

Re: [RFC PATCH net-next v2 7/8] openvswitch: Delay conntrack helper call for new connections.

2015-11-09 Thread Patrick McHardy
On 06.11, Jarno Rajahalme wrote: > There is no need to help connections that are not confirmed, so we can > delay helping new connections to the time when they are confirmed. > This change is needed for NAT support, and having this as a separate > patch will make the following NAT patch a bit easie

Re: [RFC PATCH net-next v2 0/8] openvswitch: NAT support.

2015-11-09 Thread Patrick McHardy
On 06.11, Jarno Rajahalme wrote: > This series adds NAT support to openvswitch kernel module. A few > changes are needed to the netfilter code to facilitate this (patches > 1-3/8). Patches 4-7 make the openvswitch kernel module ready for the > patch 8 that adds the NAT support for calling into ne

Re: Linux 4.2.4

2015-11-09 Thread Pablo Neira Ayuso
On Mon, Nov 09, 2015 at 01:35:11PM +0100, Gerhard Wiesinger wrote: > On 08.11.2015 18:20, Greg KH wrote: > >That's great, can you let me know the git commits that end up in Linus's > >tree? That's what we need for the stable kernel. > > Find the commits here: > https://git.kernel.org/cgit/linux/k

Re: Linux 4.2.4

2015-11-09 Thread Gerhard Wiesinger
On 08.11.2015 18:20, Greg KH wrote: On Sun, Nov 08, 2015 at 02:51:01PM +0100, Gerhard Wiesinger wrote: On 25.10.2015 17:29, Greg KH wrote: On Sun, Oct 25, 2015 at 11:48:54AM +0100, Gerhard Wiesinger wrote: On 25.10.2015 10:46, Willy Tarreau wrote: ipset *triggered* the problem. The whole stac

[PATCH] net: caif: check return value of alloc_netdev

2015-11-09 Thread Rasmus Villemoes
I don't know if dev can actually be NULL here, but the test should be above alloc_netdev(), to avoid leaking the struct net_device in case dev is actually NULL. And of course the return value from alloc_netdev should be tested. Signed-off-by: Rasmus Villemoes --- Maybe the existing code was suppo

[PATCH v2 4/4] tty: Remove drivers' extra tty_ldisc_flush()

2015-11-09 Thread Peter Hurley
The tty_port_close_start() helper already flushes the tty and ldisc buffers on final close; tty drivers which use this helper need not repeat tty_ldisc_flush(). Signed-off-by: Peter Hurley --- drivers/char/pcmcia/synclink_cs.c | 3 --- drivers/tty/amiserial.c | 2 -- drivers/tty/rocket

[PATCH v2 2/4] n_tty: Ignore all read data when closing

2015-11-09 Thread Peter Hurley
On final port close (and thus final tty close), only output flow control requests in the input data should be processed. Ignore all other input data, including parity errors, overruns and breaks. Signed-off-by: Peter Hurley --- drivers/tty/n_tty.c | 2 -- 1 file changed, 2 deletions(-) diff --g

[PATCH v2 3/4] tty: Abstract and encapsulate tty->closing behavior

2015-11-09 Thread Peter Hurley
tty->closing is exclusively used to cause the N_TTY line discipline to drop further input on final tty close (except XON/XOFF output flow control changes). In turn, this prevents the line discipline from generating new tty driver i/o requests (eg., when echoing) after the tty driver has performed h

[PATCH v2 1/4] tty: rocket: Remove private close_wait

2015-11-09 Thread Peter Hurley
This driver's private completion variable, close_wait, is no longer used for wait since "tty: Remove ASYNC_CLOSING checks in open()/hangup"; remove. Signed-off-by: Peter Hurley --- drivers/tty/rocket.c | 2 -- drivers/tty/rocket_int.h | 1 - 2 files changed, 3 deletions(-) diff --git a/driv

[PATCH v2 0/4] Replace tty->closing

2015-11-09 Thread Peter Hurley
Hi Greg, This series cleans up a messy and poorly documented mechanism required at tty final close to prevent drivers from crashing after h/w shutdown. Without special handling, N_TTY echoing will cause driver i/o requests _after_ h/w shutdown, which typically crashes the driver. Currently, the t

Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()

2015-11-09 Thread Jan Kara
On Mon 09-11-15 20:56:10, Tetsuo Handa wrote: > There are many locations that do > > if (memory_was_allocated_by_vmalloc) > vfree(ptr); > else > kfree(ptr); > > but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory > using is_vmalloc_addr(). Unless callers have specia

Re: [GIT] Networking

2015-11-09 Thread Hannes Frederic Sowa
Hi, On Wed, Oct 28, 2015, at 15:27, Rasmus Villemoes wrote: > On Wed, Oct 28 2015, Hannes Frederic Sowa > wrote: > > > Hi Linus, > > > > On Wed, Oct 28, 2015, at 10:39, Linus Torvalds wrote: > >> Get rid of it. And I don't *ever* want to see that shit again. > > > > I don't want to give up on th

Re: [PATCH 3/4] tty: Abstract and encapsulate tty->closing behavior

2015-11-09 Thread Peter Hurley
On 11/09/2015 04:12 AM, Johannes Stezenbach wrote: > On Sun, Nov 08, 2015 at 05:02:52PM -0500, Peter Hurley wrote: >> +void tty_ldisc_closing(struct tty_struct *tty) >> +{ >> +struct tty_ldisc *ld = tty_ldisc_ref(tty); >> + >> +if (ld->ops->closing) >> +ld->ops->closing(tty); >>

[PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()

2015-11-09 Thread Tetsuo Handa
There are many locations that do if (memory_was_allocated_by_vmalloc) vfree(ptr); else kfree(ptr); but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory using is_vmalloc_addr(). Unless callers have special reasons, we can replace this branch with kvfree(). Please chec

Re: [PATCH net 1/2] packet: do skb_probe_transport_header when we actually have data

2015-11-09 Thread Daniel Borkmann
On 11/07/2015 11:29 PM, David Miller wrote: From: Eric Dumazet Date: Sat, 07 Nov 2015 10:53:50 -0800 Well, imagine following scenario (a real one, as I use it all of time, thus how I discovered all trafgen traffic ends up on one slave only) Even if qdisc is bypassed on the bond0, the current

Re: AF_PACKET mmap() v4...

2015-11-09 Thread Daniel Borkmann
On 11/08/2015 05:27 AM, John Fastabend wrote: On 15-11-07 06:19 PM, Alexei Starovoitov wrote: On Thu, Nov 05, 2015 at 10:39:15AM +0100, Daniel Borkmann wrote: On 11/05/2015 10:07 AM, Arnd Bergmann wrote: On Thursday 05 November 2015 00:04:14 David Miller wrote: As part of fixing y2038 problem

Re: [PATCH net v2] bpf: fix trivial comment typo

2015-11-09 Thread Matthew Fernandez
On 05/11/15 16:32, David Miller wrote: From: Matthew Fernandez Date: Thu, 5 Nov 2015 11:09:52 +1100 bpf: fix trivial comment typo Signed-off-by: Matthew Fernandez This does not apply. It looks like your email client has corrupted the patch. Well I managed to foul that up nicely, didn't

Re: [GIT] Networking

2015-11-09 Thread Hannes Frederic Sowa
Hello, Ingo Molnar writes: > * Linus Torvalds wrote: > >> Does anybody have any particular other "uhhuh, overflow in multiplication" >> issues in mind? Because the interface for a saturating multiplication (or >> addition, for that matter) would actually be much easier. And would be >> trivi

Re: [GIT] Networking

2015-11-09 Thread Hannes Frederic Sowa
Hello, Ingo Molnar writes: > * Linus Torvalds wrote: > >> Does anybody have any particular other "uhhuh, overflow in multiplication" >> issues in mind? Because the interface for a saturating multiplication (or >> addition, for that matter) would actually be much easier. And would be >> trivi

Re: deadlock between setsockopt/getsockopt

2015-11-09 Thread Dmitry Vyukov
On Sun, Nov 8, 2015 at 6:16 PM, Eric Dumazet wrote: > On Sun, 2015-11-08 at 11:15 +0100, Dmitry Vyukov wrote: >> Hello, >> >> I've got the following deadlock report on commit >> d1e41ff11941784f469f17795a4d9425c2eb4b7a (Nov 5). >> >> >> [ INFO: possible circular locking dependency detected ] >> 4.

Re: [PATCH net-next ] net: ipv4: memset addr before calling copy_to_user()

2015-11-09 Thread Hannes Frederic Sowa
Hello, On Mon, Nov 9, 2015, at 07:52, Loganaden Velvindron wrote: > zero addr before calling copy_to_user() > > Signed-off-by: Loganaden Velvindron > --- > net/ipv4/ip_sockglue.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c > index c

Re: [PATCH] man: Syntax and warning fixes

2015-11-09 Thread Albino B Neto
2015-11-07 7:55 GMT-02:00 Ville Skyttä : >> Signed-off-by and description ? > > Superseding patches sent separately. I suggest documenting the > requirement for Signed-off-by somewhere (README.devel?); Please read the Documentation/SubmittingPatches. Albino -- To unsubscribe from this list: s

Re: [PATCH 3/4] tty: Abstract and encapsulate tty->closing behavior

2015-11-09 Thread Johannes Stezenbach
On Sun, Nov 08, 2015 at 05:02:52PM -0500, Peter Hurley wrote: > +void tty_ldisc_closing(struct tty_struct *tty) > +{ > + struct tty_ldisc *ld = tty_ldisc_ref(tty); > + > + if (ld->ops->closing) > + ld->ops->closing(tty); > + if (ld) > + tty_ldisc_deref(ld); > +}

Re: [PATCH] net: hisilicon: NET_VENDOR_HISILICON should depend on HAS_DMA

2015-11-09 Thread Arnd Bergmann
On Monday 09 November 2015 10:34:30 Geert Uytterhoeven wrote: > If NO_DMA=y: > > ERROR: "dma_set_mask" > [drivers/net/ethernet/hisilicon/hns/hns_enet_drv.ko] undefined! > ERROR: "dma_unmap_single" > [drivers/net/ethernet/hisilicon/hns/hns_enet_drv.ko] undefined! > ERROR: "dma_unmap_p

[PATCH] net: hisilicon: NET_VENDOR_HISILICON should depend on HAS_DMA

2015-11-09 Thread Geert Uytterhoeven
If NO_DMA=y: ERROR: "dma_set_mask" [drivers/net/ethernet/hisilicon/hns/hns_enet_drv.ko] undefined! ERROR: "dma_unmap_single" [drivers/net/ethernet/hisilicon/hns/hns_enet_drv.ko] undefined! ERROR: "dma_unmap_page" [drivers/net/ethernet/hisilicon/hns/hns_enet_drv.ko] undefined! ER

Re: [PATCH] man: Syntax and warning fixes

2015-11-09 Thread Daniel Borkmann
On 11/07/2015 05:40 PM, David Ahern wrote: On 11/7/15 2:55 AM, Ville Skyttä wrote: On Sat, Nov 7, 2015 at 11:47 AM, Albino B Neto wrote: 2015-11-07 7:44 GMT-02:00 Ville Skyttä : --- man/man8/tc-bpf.8 | 2 +- man/man8/tipc-bearer.8| 4 ++-- man/man8/tipc-link.8 | 6 +++---

Re: [PATCH net 1/2] packet: do skb_probe_transport_header when we actually have data

2015-11-09 Thread Daniel Borkmann
On 11/09/2015 04:11 AM, David Miller wrote: From: Daniel Borkmann Date: Sun, 08 Nov 2015 01:33:56 +0100 Hmm, yeah, on a (only quick) look, it seems this is mostly needed for the virtio_net related code in packet_snd() / packet_recvmsg(), not handled in RX/TX ring paths actually. $ git grep -n

Re: [GIT] Networking

2015-11-09 Thread Ingo Molnar
* Linus Torvalds wrote: > Does anybody have any particular other "uhhuh, overflow in multiplication" > issues in mind? Because the interface for a saturating multiplication (or > addition, for that matter) would actually be much easier. And would be > trivial > to have as an inline asm for c