Re: [PATCH v2] wait: add comment before waitqueue_active noting memory barrier is required

Peter Zijlstra wrote: > >> >> Second, on the waiting thread side, the CPU can reorder the load of >> >> CONDITION to occur during add_wait_queue active, before the entry is >> >> added to the wait queue. >> >> wake_up thread waiting thread >> >>

Re: [PATCH iproute2] ip-address: properly display zero IPv4 peer address

On Thu, Oct 22, 2015 at 10:34:28AM +0200, Thomas Haller wrote: > Kernel allows for zero IPv4 peer addresses (IFA_ADDRESS): > >ip address add 192.168.5.1 peer 0.0.0.0/24 dev dummy > > which is distinct from a usual address like: > >ip address add 192.168.5.1/24 dev dummy >ip address

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On Wed, Nov 11, 2015 at 09:49:48AM +0100, Arnd Bergmann wrote: > On Tuesday 10 November 2015 18:52:45 Z Lim wrote: > > On Tue, Nov 10, 2015 at 4:42 PM, Alexei Starovoitov > > wrote: > > > On Tue, Nov 10, 2015 at 04:26:02PM -0800, Shi, Yang wrote: > > >> On 11/10/2015

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On Wed, Nov 11, 2015 at 12:38:31PM +, Will Deacon wrote: > > Hmm, gcc doesn't have an eBPF compiler backend, so this won't work on > > gcc at all. The eBPF backend in LLVM recognizes the __sync_fetch_and_add() > > keyword and maps that to a BPF_XADD version (BPF_W or BPF_DW). In the > >

Re: [PATCH] netfilter: fix xt_TEE and xt_TPROXY dependencies

On Tue, Nov 10, 2015 at 01:22:15PM +0100, Arnd Bergmann wrote: > Kconfig is too smart for its own good: a Kconfig line that states > > select NF_DEFRAG_IPV6 if IP6_NF_IPTABLES > > means that if IP6_NF_IPTABLES is set to 'm', then NF_DEFRAG_IPV6 will > also be set to 'm', regardless of the

Fw: [Bug 107141] New: [1177853.192071] INFO: task accel-pppd:24263 blocked for more than 120 seconds.

Begin forwarded message: Date: Wed, 4 Nov 2015 10:46:56 + From: "bugzilla-dae...@bugzilla.kernel.org" To: "shemmin...@linux-foundation.org" Subject: [Bug 107141] New: [1177853.192071] INFO: task accel-pppd:24263

Re: [PATCH RESEND] net: Documentation: Fix default value tcp_limit_output_bytes

On Wed, 11 Nov 2015 11:57:24 -0500 (EST) David Miller wrote: > > I left this last time because Dave usually likes to pick up networking > > docs patches himself. This wasn't sent to netdev, though, so that's > > unlikely to happen. I've gone ahead and applied it, since it

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On Wed, Nov 11, 2015 at 12:35:48PM -0500, David Miller wrote: > From: Alexei Starovoitov > Date: Wed, 11 Nov 2015 09:27:00 -0800 > > > BPF_XADD == atomic_add() in kernel. period. > > we are not going to deprecate it or introduce something else. > > Agreed, it makes

Re: [PATCH RESEND] net: Documentation: Fix default value tcp_limit_output_bytes

On Mon, 9 Nov 2015 14:58:49 +0100 Niklas Cassel wrote: > Commit c39c4c6abb89 ("tcp: double default TSQ output bytes limit") > updated default value for tcp_limit_output_bytes I left this last time because Dave usually likes to pick up networking docs patches himself.

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On Wed, Nov 11, 2015 at 12:35:48PM -0500, David Miller wrote: > From: Alexei Starovoitov > Date: Wed, 11 Nov 2015 09:27:00 -0800 > > > BPF_XADD == atomic_add() in kernel. period. > > we are not going to deprecate it or introduce something else. > > Agreed, it makes

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

David Miller writes: > From: Måns Rullgård > Date: Wed, 11 Nov 2015 13:04:07 + > >> Måns Rullgård writes: >> >>> David Miller writes: >>> From: Måns Rullgård Date: Wed, 11 Nov 2015

Re: [PATCH 1/1] net: Add SO_REUSEPORT_LISTEN_OFF socket option as drain mode

On Tue, Nov 10, 2015 at 10:19 PM, Eric Dumazet wrote: > On Tue, 2015-11-10 at 21:41 -0800, Tom Herbert wrote: >> Tolga, are you still planning to respin this patch (when tree opens?) > > I was planning to add an union on skc_tx_queue_mapping and > sk_max_ack_backlog, so

[PATCH 02/10] netfilter: ingress: fix wrong input interface on hook

The input and output interfaces in nf_hook_state_init() are flipped. This fixes iif matching on nftables. Reported-by: Patrick McHardy Signed-off-by: Pablo Neira Ayuso --- include/linux/netfilter_ingress.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 01/10] netfilter: ingress: don't use nf_hook_list_active

From: Florian Westphal nf_hook_list_active() always returns true once at least one device has NF_INGRESS hook enabled. Thus, don't use this function. Instead, inverse the test and use the static key to elide list_empty test if no NF_INGRESS hooks are active. Signed-off-by:

regression in ixgbe SFP detection patch

Hello, I upgraded a machine from 3.14.x to v4.1.x and noted that I now have two kworker very often on D state, just after boot while I am not doing anything special. This issue remains indefinitely. This machine has four network interfaces: 01:00.0 Ethernet controller: Intel Corporation 82576

Re: [PATCH RESEND] net: Documentation: Fix default value tcp_limit_output_bytes

From: Jonathan Corbet Date: Wed, 11 Nov 2015 09:50:02 -0700 > On Mon, 9 Nov 2015 14:58:49 +0100 > Niklas Cassel wrote: > >> Commit c39c4c6abb89 ("tcp: double default TSQ output bytes limit") >> updated default value for tcp_limit_output_bytes > > I left

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue

Hi Rainer, > + > +/* Needs sk unix state lock. After recv_ready indicated not ready, > + * establish peer_wait connection if still needed. > + */ > +static int unix_dgram_peer_wake_me(struct sock *sk, struct sock *other) > +{ > + int connected; > + > + connected =

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

From: Alexei Starovoitov Date: Wed, 11 Nov 2015 09:27:00 -0800 > BPF_XADD == atomic_add() in kernel. period. > we are not going to deprecate it or introduce something else. Agreed, it makes no sense to try and tie C99 or whatever atomic semantics to something that

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On Wed, Nov 11, 2015 at 06:57:41PM +0100, Peter Zijlstra wrote: > On Wed, Nov 11, 2015 at 12:35:48PM -0500, David Miller wrote: > > From: Alexei Starovoitov > > Date: Wed, 11 Nov 2015 09:27:00 -0800 > > > > > BPF_XADD == atomic_add() in kernel. period. > > > we are

Re: [PATCH 1/1] net: Add SO_REUSEPORT_LISTEN_OFF socket option as drain mode

On Wed, Nov 11, 2015 at 9:23 AM, Eric Dumazet wrote: > On Wed, 2015-11-11 at 09:05 -0800, Tom Herbert wrote: >> On Tue, Nov 10, 2015 at 10:19 PM, Eric Dumazet >> wrote: >> > On Tue, 2015-11-10 at 21:41 -0800, Tom Herbert wrote: >> >> Tolga, are

[PATCH 08/10] netfilter: fix xt_TEE and xt_TPROXY dependencies

From: Arnd Bergmann Kconfig is too smart for its own good: a Kconfig line that states select NF_DEFRAG_IPV6 if IP6_NF_IPTABLES means that if IP6_NF_IPTABLES is set to 'm', then NF_DEFRAG_IPV6 will also be set to 'm', regardless of the state of the symbol from which it is

[PATCH 04/10] netfilter: ipset: Fix hash:* type expiration

From: Jozsef Kadlecsik Incorrect index was used when the data blob was shrinked at expiration, which could lead to falsely expired entries and memory leak when the comment extension was used too. Signed-off-by: Jozsef Kadlecsik ---

[PATCH 06/10] netfilter: Fix removal of GRE expectation entries created by PPTP

From: Anthony Lineham The uninitialized tuple structure caused incorrect hash calculation and the lookup failed. Link: https://bugzilla.kernel.org/show_bug.cgi?id=106441 Signed-off-by: Anthony Lineham Signed-off-by:

OVS VXLAN decap rule has full match on TTL for the outer headers?

Hi Joe/Jesse, We've noticed that VXLAN decap rules set by OVS in the below trivial VXLAN config contain full match on TTL=64 for the outer headers, can you explain the reasoning behind it? is that justa typo in dumping the flow? I also noticed that on my systems (upstream kernel 4.3.0-rc6+,

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On 11/11/2015 01:58 PM, Peter Zijlstra wrote: On Wed, Nov 11, 2015 at 12:38:31PM +, Will Deacon wrote: Hmm, gcc doesn't have an eBPF compiler backend, so this won't work on gcc at all. The eBPF backend in LLVM recognizes the __sync_fetch_and_add() keyword and maps that to a BPF_XADD version

[PATCH] fjes: fix inconsistent indenting

From: Colin Ian King minor change, indenting is one tab out. Signed-off-by: Colin Ian King --- drivers/net/fjes/fjes_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/fjes/fjes_hw.c

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue

Hannes Frederic Sowa writes: > On Tue, Nov 10, 2015, at 22:55, Rainer Weikusat wrote: >> An AF_UNIX datagram socket being the client in an n:1 association with >> some server socket is only allowed to send messages to the server if the >> receive queue of this socket

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

On Wed, 2015-11-11 at 14:15 +, Måns Rullgård wrote: > FWIW, with UDP I get 650 Mbps. Have you tried pktgen ? It should give you raw numbers, without the stack overhead, especially when using the clone operator. (It also has xmit_more support) If the NIC can not get more than 650 Mbps, not

Re: [PATCH 1/2] arm64: bpf: add 'store immediate' instruction

On Tue, Nov 10, 2015 at 06:45:39PM -0800, Z Lim wrote: > On Tue, Nov 10, 2015 at 2:41 PM, Yang Shi wrote: > > aarch64 doesn't have native store immediate instruction, such operation > > Actually, aarch64 does have "STR (immediate)". For arm64 JIT, we can > consider using it

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On 11/11/2015 12:58 PM, Will Deacon wrote: On Wed, Nov 11, 2015 at 11:42:11AM +0100, Daniel Borkmann wrote: On 11/11/2015 11:24 AM, Will Deacon wrote: On Wed, Nov 11, 2015 at 09:49:48AM +0100, Arnd Bergmann wrote: On Tuesday 10 November 2015 18:52:45 Z Lim wrote: On Tue, Nov 10, 2015 at 4:42

Re: [PATCH 1/1] can: sja1000: clear interrupts on start

2015-11-11 13:37 GMT+01:00 Marc Kleine-Budde : >> Some cred should go to Christian (added him to CC) for finding this >> problem and reporting it to me. > > I'll add a > > Reported-by: Christian Magnusson > > to the patch. > Can we just get an

Re: kasan r8169 use-after-free trace.

On Nov 11 05:16, Eric Dumazet wrote: > On Wed, 2015-11-11 at 10:19 +0100, Francois Romieu wrote: > > Dave Jones : > > > This happens during boot, (and then there's a flood of traces that happen > > > so fast > > > afterwards it completely overwhelms serial console; not

Re: PING: [PATCH] net: smsc911x: Reset PHY during initialization

From: Pavel Fedin Date: Wed, 11 Nov 2015 10:05:24 +0300 > Hello! > >> If you think I should reconsider the patch, you should resubmit it. > > I understand this, of course. But, before doing this i'd like to > clarify your concern, why exactly you think that loopback test

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

From: Måns Rullgård Date: Wed, 11 Nov 2015 13:04:07 + > Måns Rullgård writes: > >> David Miller writes: >> >>> From: Måns Rullgård >>> Date: Wed, 11 Nov 2015 00:40:09 + >>> When the DMA complete interrupt

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

Hi Daniel, Thanks for investigating this further. On Wed, Nov 11, 2015 at 04:52:00PM +0100, Daniel Borkmann wrote: > I played a bit around with eBPF code to assign the __sync_fetch_and_add() > return value to a var and dump it to trace pipe, or use it as return code. > llvm compiles it (with the

Re: [PATCH net v2 3/3] packet: fix tpacket_snd max frame and vlan handling

On Tue, Nov 10, 2015 at 6:51 PM, Daniel Borkmann wrote: > On 11/11/2015 12:24 AM, Willem de Bruijn wrote: >> >> On Tue, Nov 10, 2015 at 6:12 PM, Daniel Borkmann >> wrote: >>> >>> On 11/10/2015 11:52 PM, Willem de Bruijn wrote: > > >

Re: kasan r8169 use-after-free trace.

Dave Jones : > This happens during boot, (and then there's a flood of traces that happen so > fast > afterwards it completely overwhelms serial console; not sure if they're the > same/related or not). > >

Re: [iproute PATCH v2 6/6] iptoken: simplify iptoken_list a bit

On 11/08/2015 09:22 PM, Phil Sutter wrote: Since it uses only a single filter, rtnl_dump_filter() can be used. Signed-off-by: Phil Sutter Acked-by: Daniel Borkmann -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH 1/1] can: sja1000: clear interrupts on start

On 11/11/2015 01:29 PM, Mirza Krak wrote: >> Can you put a scope on the interrupt pin and see if it's a problem of >> the SoC and/or Linux or the SJA1000 not pulling the IRQ line. > > A little demonstration on what it looks like when the system is > resumed (added a printk in sja1000_start

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

On Wed, 2015-11-11 at 13:04 +, Måns Rullgård wrote: > I tried that, and throughput (as measured by iperf3) dropped by 2%. > Maybe I did something wrong. What link speed have you used, what was the throughput you got, and is the receiver using the same NIC ? -- To unsubscribe from this

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

Mason writes: > On 10/11/2015 22:51, Eric Dumazet wrote: > >> On Tue, 2015-11-10 at 21:21 +, Måns Rullgård wrote: >> >>> Even ixgbe uses napi_complete() while netdevice.h says one should >>> "consider using napi_complete_done() instead." Did the author consider >>> it

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

On Wed, 2015-11-11 at 13:54 +, Måns Rullgård wrote: > Mason writes: > > > On 10/11/2015 22:51, Eric Dumazet wrote: > > > >> On Tue, 2015-11-10 at 21:21 +, Måns Rullgård wrote: > >> > >>> Even ixgbe uses napi_complete() while netdevice.h says one should > >>> "consider

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

Eric Dumazet writes: > On Wed, 2015-11-11 at 13:48 +, Måns Rullgård wrote: >> Eric Dumazet writes: >> >> > On Wed, 2015-11-11 at 13:04 +, Måns Rullgård wrote: >> > >> >> I tried that, and throughput (as measured by iperf3) dropped by 2%.

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

Hi Daniel, On Wed, Nov 11, 2015 at 11:42:11AM +0100, Daniel Borkmann wrote: > On 11/11/2015 11:24 AM, Will Deacon wrote: > >On Wed, Nov 11, 2015 at 09:49:48AM +0100, Arnd Bergmann wrote: > >>On Tuesday 10 November 2015 18:52:45 Z Lim wrote: > >>>On Tue, Nov 10, 2015 at 4:42 PM, Alexei Starovoitov

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

Måns Rullgård writes: > Eric Dumazet writes: > >> On Wed, 2015-11-11 at 13:48 +, Måns Rullgård wrote: >>> Eric Dumazet writes: >>> >>> > On Wed, 2015-11-11 at 13:04 +, Måns Rullgård wrote: >>> > >>> >> I tried that, and

Re: [PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents

On 2015/11/3 6:05, Arnd Bergmann wrote: On Saturday 31 October 2015 02:18:19 Salil Mehta wrote: On 10/31/2015 1:40 AM, huangdaode wrote: On 2015/10/30 22:20, Arnd Bergmann wrote: On Tuesday 27 October 2015 19:16:34 huangdaode wrote: mdio@803c {

Is ndo_do_ioctl still acceptable?

Hi David & Folks, Soon I will submit a virtual tunnel device driver to LKML for review. It uses rtnl_link_register to create a virtual network interface, which then handles encryption, authentication, and some other things, amongst various configured peers. Right now the device is configurable

[PATCH net] sctp: translate host order to network order when setting a hmacid

now sctp auth cannot work well when setting a hmacid manually, which is caused by that we didn't use the network order for hmacid, so fix it by adding the transformation in sctp_auth_ep_set_hmacs. even we set hmacid with the network order in userspace, it still can't work, because of this

Re: [Intel-wired-lan] [net-next PATCH 2/3] ixgbe: Use __dev_uc_sync and __dev_uc_unsync for unicast addresses

On 11/11/2015 05:35 PM, Stephen Hemminger wrote: On Thu, 22 Oct 2015 16:26:36 -0700 Alexander Duyck wrote: +static int ixgbe_uc_unsync(struct net_device *netdev, const unsigned char *addr) +{ + struct ixgbe_adapter *adapter = netdev_priv(netdev); + +

Re: Why my NIC shows NUMA -1?

12.11.2015, 01:41, "Vincent Li" : > Hi > > Sorry I am not sure if this is the right list to ask this question, > please direct me to the correct one. thanks! > > I am using Intel 82599 on Dell PowerEdge R710 which should support > NUMA node, the box is running ubuntu

RE: PING: [PATCH] net: smsc911x: Reset PHY during initialization

Hello! > >> If you think I should reconsider the patch, you should resubmit it. > > > > I understand this, of course. But, before doing this i'd like to > > clarify your concern, why exactly you think that loopback test will > > break. > > If I didn't reply it means I don't have anything

Re: OVS VXLAN decap rule has full match on TTL for the outer headers?

On Thu, Nov 12, 2015 at 12:44 AM, Jesse Gross wrote: > On Wed, Nov 11, 2015 at 6:47 AM, Or Gerlitz wrote: >> Hi Joe/Jesse, >> >> We've noticed that VXLAN decap rules set by OVS in the below trivial VXLAN >> config contain full match on TTL=64 for the

RE: [Intel-wired-lan] [net-next PATCH 1/3] ixgbe: Refactor MAC address configuration code

-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Alexander Duyck Sent: Thursday, October 22, 2015 4:27 PM To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T Subject: [Intel-wired-lan] [net-next PATCH

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On Wed, Nov 11, 2015 at 11:21:35PM +0100, Peter Zijlstra wrote: > On Wed, Nov 11, 2015 at 11:55:59AM -0800, Alexei Starovoitov wrote: > > Therefore things like memory barriers, full set of atomics are not > > applicable > > in bpf world. > > There are still plenty of wait-free constructs one can

Re: [PATCH linux-firmware] qed: Add FW 8.4.2.0.

On Mon, Nov 09, 2015 at 09:54:34AM +0200, Yuval Mintz wrote: > From: Sudarsana Kalluru > > This adds the first FW entry to the newly added > Qlogic Ethernet Driver product series. > > Signed-off-by: Sudarsana Kalluru > Signed-off-by:

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On Wed, Nov 11, 2015 at 10:11:33AM -0800, Alexei Starovoitov wrote: > On Wed, Nov 11, 2015 at 06:57:41PM +0100, Peter Zijlstra wrote: > > On Wed, Nov 11, 2015 at 12:35:48PM -0500, David Miller wrote: > > > From: Alexei Starovoitov > > > Date: Wed, 11 Nov 2015

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue

Hi, On Wed, Nov 11, 2015, at 17:12, Rainer Weikusat wrote: > Hannes Frederic Sowa writes: > > On Tue, Nov 10, 2015, at 22:55, Rainer Weikusat wrote: > >> An AF_UNIX datagram socket being the client in an n:1 association with > >> some server socket is only allowed to

[PATCH net 0/3] ipv6: Fixes for pmtu update and DST_NOCACHE route

This patchset fixes: 1. An oops during IPv6 pmtu update on a IPv4 GRE running in an IPSec setup 2. Misc fixes on DST_NOCACHE route -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH net v3] af-unix: fix use-after-free with concurrent readers while splicing

On Wed, Nov 11, 2015, at 21:09, Eric Dumazet wrote: > On Wed, 2015-11-11 at 20:58 +0100, Hannes Frederic Sowa wrote: > > > > On Wed, Nov 11, 2015, at 20:42, Eric Dumazet wrote: > > > On Wed, 2015-11-11 at 20:35 +0100, Hannes Frederic Sowa wrote: > > > > > > > > On Wed, Nov 11, 2015, at 20:28,

Re: [PATCH 1/1] net: Add SO_REUSEPORT_LISTEN_OFF socket option as drain mode

On Wed, 2015-11-11 at 10:23 -0800, Tom Herbert wrote: > How about doing this in shutdown called for a listener? Seems a good idea, I will try it, thanks ! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On Wed, Nov 11, 2015 at 07:31:28PM +0100, Peter Zijlstra wrote: > > Add new one that does 'fetch_and_add' ? What is the real use case it > > will be used for? > > Look at all the atomic_{add,dec}_return*() users in the kernel. A typical > example would be a reader-writer lock implementations. See

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

From: Måns Rullgård Date: Wed, 11 Nov 2015 18:25:05 + > If the TX DMA channel is idle when start_xmit is called, it can be > started immediately. Checking the DMA status and starting it if > idle has to be done atomically somehow. ->ndo_start_xmit() is guaranteed to be

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

From: Måns Rullgård Date: Wed, 11 Nov 2015 19:35:05 + >> I don't think it's silly at all. > > I'm sure I read somewhere that the time spent spinning on a lock should > be kept as small as possible. > >> And unless you can measure it making a difference, don't knock the

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On Wed, Nov 11, 2015 at 07:31:28PM +0100, Peter Zijlstra wrote: > > Adding new intrinsic to llvm is not a big deal. I'll add it as soon > > as I have time to work on it or if somebody beats me to it I would be > > glad to test it and apply it. > > This isn't a speed coding contest. You want to

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On 11/11/2015 07:31 PM, Peter Zijlstra wrote: On Wed, Nov 11, 2015 at 10:11:33AM -0800, Alexei Starovoitov wrote: On Wed, Nov 11, 2015 at 06:57:41PM +0100, Peter Zijlstra wrote: On Wed, Nov 11, 2015 at 12:35:48PM -0500, David Miller wrote: From: Alexei Starovoitov

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

David Miller writes: > From: Måns Rullgård > Date: Wed, 11 Nov 2015 18:25:05 + > >> If the TX DMA channel is idle when start_xmit is called, it can be >> started immediately. Checking the DMA status and starting it if >> idle has to be done atomically

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

David Miller writes: > From: Måns Rullgård > Date: Wed, 11 Nov 2015 19:09:19 + > >> David Miller writes: >> >>> From: Måns Rullgård >>> Date: Wed, 11 Nov 2015 18:25:05 + >>> If the TX DMA channel is idle

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On Wed, Nov 11, 2015 at 07:50:15PM +0100, Daniel Borkmann wrote: > Well, on that note, it's not like you just change the target to bpf in your > Makefile and can compile (& load into the kernel) anything you want with it. > You do have to write small, restricted programs from scratch for a

Re: [PATCH net v3] af-unix: fix use-after-free with concurrent readers while splicing

On Wed, 2015-11-11 at 20:14 +0100, Hannes Frederic Sowa wrote: > On Wed, Nov 11, 2015, at 19:58, Eric Dumazet wrote: > Can you elaborate? > > I use tail as a cookie and check if we already tried to append to the > same tail skb with skb_append_pagefrags. If during allocation, which we > do

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

From: Måns Rullgård Date: Wed, 11 Nov 2015 19:25:46 + > David Miller writes: > >> From: Måns Rullgård >> Date: Wed, 11 Nov 2015 19:17:07 + >> >>> David Miller writes: >>> From: Måns Rullgård

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On 11/11/2015 08:23 PM, Peter Zijlstra wrote: On Wed, Nov 11, 2015 at 07:50:15PM +0100, Daniel Borkmann wrote: Well, on that note, it's not like you just change the target to bpf in your Makefile and can compile (& load into the kernel) anything you want with it. You do have to write small,

Re: [PATCH net v3] af-unix: fix use-after-free with concurrent readers while splicing

On Wed, Nov 11, 2015, at 20:42, Eric Dumazet wrote: > On Wed, 2015-11-11 at 20:35 +0100, Hannes Frederic Sowa wrote: > > > > On Wed, Nov 11, 2015, at 20:28, Eric Dumazet wrote: > > > On Wed, 2015-11-11 at 20:14 +0100, Hannes Frederic Sowa wrote: > > > > On Wed, Nov 11, 2015, at 19:58, Eric

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On Wed, Nov 11, 2015 at 10:11:33AM -0800, Alexei Starovoitov wrote: > On Wed, Nov 11, 2015 at 06:57:41PM +0100, Peter Zijlstra wrote: > > On Wed, Nov 11, 2015 at 12:35:48PM -0500, David Miller wrote: > > > From: Alexei Starovoitov > > > Date: Wed, 11 Nov 2015

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

From: Alexei Starovoitov Date: Wed, 11 Nov 2015 10:11:33 -0800 > bpf_xadd was never meant to be __sync_fetch_and_add equivalent. > From the day one it meant to be atomic_add() as kernel does it. +1 > I did piggy back on __sync in the llvm backend because it was

[PATCH net 2/3] ipv6: Check expire on DST_NOCACHE route

Since the expires of the DST_NOCACHE rt can be set during the ip6_rt_update_pmtu(), we also need to consider the expires value when doing ip6_dst_check(). This patches creates __rt6_check_expired() to only check the expire value (if one exists) of the current rt. In rt6_dst_from_check(), it adds

[PATCH net 3/3] ipv6: Check rt->dst.from for the DST_NOCACHE route

All DST_NOCACHE rt6_info used to have rt->dst.from set to its parent. After commit 8e3d5be73681 ("ipv6: Avoid double dst_free"), DST_NOCACHE is also set to rt6_info which does not have a parent (i.e. rt->dst.from is NULL). This patch catches the rt->dst.from == NULL case. Fixes: 8e3d5be73681

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On Wed, Nov 11, 2015 at 07:54:15PM +0100, Peter Zijlstra wrote: > On Wed, Nov 11, 2015 at 07:44:27PM +0100, Peter Zijlstra wrote: > > On Wed, Nov 11, 2015 at 07:31:28PM +0100, Peter Zijlstra wrote: > > > > Add new one that does 'fetch_and_add' ? What is the real use case it > > > > will be used

RE: [PATCH] fjes: fix inconsistent indenting

Thanks, Colin. Signed-off-by: Taku Izumi > -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Thursday, November 12, 2015 12:23 AM > To: David S. Miller; Izumi, Taku/泉 拓; Markus Elfring; netdev@vger.kernel.org > Cc:

Re: [PATCH 2/2] arm64: bpf: add BPF XADD instruction

On Wed, Nov 11, 2015 at 07:44:27PM +0100, Peter Zijlstra wrote: > On Wed, Nov 11, 2015 at 07:31:28PM +0100, Peter Zijlstra wrote: > > > Add new one that does 'fetch_and_add' ? What is the real use case it > > > will be used for? > > > > Look at all the atomic_{add,dec}_return*() users in the

Re: [PATCH net v3] af-unix: fix use-after-free with concurrent readers while splicing

On Tue, 2015-11-10 at 16:23 +0100, Hannes Frederic Sowa wrote: > During splicing an af-unix socket to a pipe we have to drop all > af-unix socket locks. While doing so we allow another reader to enter > unix_stream_read_generic which can read, copy and finally free another > skb. If exactly this

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

From: Måns Rullgård Date: Wed, 11 Nov 2015 19:09:19 + > David Miller writes: > >> From: Måns Rullgård >> Date: Wed, 11 Nov 2015 18:25:05 + >> >>> If the TX DMA channel is idle when start_xmit is called, it can be >>> started

Re: [PATCH net v3] af-unix: fix use-after-free with concurrent readers while splicing

On Wed, Nov 11, 2015, at 19:58, Eric Dumazet wrote: > On Tue, 2015-11-10 at 16:23 +0100, Hannes Frederic Sowa wrote: > > During splicing an af-unix socket to a pipe we have to drop all > > af-unix socket locks. While doing so we allow another reader to enter > > unix_stream_read_generic which can

Re: [PATCH net v3] af-unix: fix use-after-free with concurrent readers while splicing

On Wed, Nov 11, 2015, at 20:14, Hannes Frederic Sowa wrote: > On Wed, Nov 11, 2015, at 19:58, Eric Dumazet wrote: > > On Tue, 2015-11-10 at 16:23 +0100, Hannes Frederic Sowa wrote: > > > During splicing an af-unix socket to a pipe we have to drop all > > > af-unix socket locks. While doing so we

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

From: Måns Rullgård Date: Wed, 11 Nov 2015 19:17:07 + > David Miller writes: > >> From: Måns Rullgård >> Date: Wed, 11 Nov 2015 19:09:19 + >> >>> David Miller writes: >>> From: Måns Rullgård

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

David Miller writes: > From: Måns Rullgård > Date: Wed, 11 Nov 2015 19:17:07 + > >> David Miller writes: >> >>> From: Måns Rullgård >>> Date: Wed, 11 Nov 2015 19:09:19 + >>> David Miller

Re: [PATCH net v3] af-unix: fix use-after-free with concurrent readers while splicing

On Wed, 2015-11-11 at 20:58 +0100, Hannes Frederic Sowa wrote: > > On Wed, Nov 11, 2015, at 20:42, Eric Dumazet wrote: > > On Wed, 2015-11-11 at 20:35 +0100, Hannes Frederic Sowa wrote: > > > > > > On Wed, Nov 11, 2015, at 20:28, Eric Dumazet wrote: > > > > On Wed, 2015-11-11 at 20:14 +0100,

Re: regression in ixgbe SFP detection patch

On Nov11 20:33, Tantilov, Emil S wrote: > If the diff above is the patch you are referring to then you will break the > SFP+ detection in the case where the driver was loaded while there were no > SFP+ modules present in the cages. understood, I was surprised of the modification of behavior. --

RE: regression in ixgbe SFP detection patch

>-Original Message- >From: William Dauchy [mailto:will...@gandi.net] >Sent: Wednesday, November 11, 2015 9:35 AM >To: Kirsher, Jeffrey T; Tantilov, Emil S >Cc: da...@davemloft.net; netdev@vger.kernel.org; Schmitt, Phillip J; intel- >wired-...@lists.osuosl.org >Subject: regression in ixgbe

Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

David Miller writes: > From: Måns Rullgård > Date: Wed, 11 Nov 2015 19:35:05 + > >>> I don't think it's silly at all. >> >> I'm sure I read somewhere that the time spent spinning on a lock should >> be kept as small as possible. >> >>> And unless you

[ANNOUNCE] NetDev 1.1 Registration open

Hi! We are pleased to announce that registration is now open for netdev 1.1, the community-driven Linux networking conference held back-to-back with netconf in Sevilla, Spain, February 10-12, 2016. Registration is now open at: https://www.netdevconf.org/1.1/registration.html = Fees = * Regular

Re: regression in ixgbe SFP detection patch

On 11/11/2015 01:34 PM, William Dauchy wrote: On Nov11 20:33, Tantilov, Emil S wrote: If the diff above is the patch you are referring to then you will break the SFP+ detection in the case where the driver was loaded while there were no SFP+ modules present in the cages. understood, I was

Re: [Intel-wired-lan] regression in ixgbe SFP detection patch

William, Emil S wrote: >> It also fixes my issue: even if eth{2,3} are still up with no carrier, I >> don't have any kworker in D state. > > It appears that you have 2 ports with empty cages. If that is the case there > is no reason to keep the interfaces up. If you

[PATCH net v3 2/5] packet: always probe for transport header

We concluded that the skb_probe_transport_header() should better be called unconditionally. Avoiding the call into the flow dissector has also not really much to do with the direct xmit mode. While it seems that only virtio_net code makes use of GSO from non RX/TX ring packet socket paths, we

[PATCH net v3 0/5] packet fixes

Fixes a couple of issues in packet sockets, i.e. on TX ring side. See individual patches for details. v2 -> v3: - First two patches unchanged, kept Jason's Ack - Reworked 3rd patch and split into 3: - check for dev type as discussed with Willem - infer skb->protocol - fix max len for

[PATCH net 1/1] r8169: fix kasan reported skb use-after-free.

Signed-off-by: Francois Romieu Reported-by: Dave Jones Fixes: d7d2d89d4b0af ("r8169: Add software counter for multicast packages") Acked-by: Eric Dumazet Acked-by: Corinna Vinschen --- Applies to davem's

Why my NIC shows NUMA -1?

Hi Sorry I am not sure if this is the right list to ask this question, please direct me to the correct one. thanks! I am using Intel 82599 on Dell PowerEdge R710 which should support NUMA node, the box is running ubuntu 14.01.1 LTS , I am wondering why I get NUMA socket -1. in BIOS, the memory

Re: [PATCH net v3 4/5] packet: infer protocol from ethernet header if unset

On Wed, Nov 11, 2015 at 5:25 PM, Daniel Borkmann wrote: > In case no struct sockaddr_ll has been passed to packet > socket's sendmsg() when doing a TX_RING flush run, then > skb->protocol is set to po->num instead, which is the protocol > passed via socket(2)/bind(2). > >

Re: Why my NIC shows NUMA -1?

On 11/11/2015 02:41 PM, Vincent Li wrote: Hi Sorry I am not sure if this is the right list to ask this question, please direct me to the correct one. thanks! I am using Intel 82599 on Dell PowerEdge R710 which should support NUMA node, the box is running ubuntu 14.01.1 LTS , I am wondering why

[PATCH net v3 3/5] packet: only allow extra vlan len on ethernet devices

Packet sockets can be used by various net devices and are not really restricted to ARPHRD_ETHER device types. However, when currently checking for the extra 4 bytes that can be transmitted in VLAN case, our assumption is that we generally probe on ARPHRD_ETHER devices. Therefore, before looking

[PATCH net v3 1/5] packet: do skb_probe_transport_header when we actually have data

In tpacket_fill_skb() commit c1aad275b029 ("packet: set transport header before doing xmit") and later on 40893fd0fd4e ("net: switch to use skb_probe_transport_header()") was probing for a transport header on the skb from a ring buffer slot, but at a time, where the skb has _not even_ been filled

  1   2   >