Re: [RFC 5/8] net-next: ralink: add support for rt3050 family

2015-11-22 Thread John Crispin
On 23/11/2015 00:16, Andrew Lunn wrote: >> Hi Andrew, >> >> we have had a switch layer inside openwrt called swconfig for several >> years. at the moment i have an add-on patch in openwrt to provide an >> userland interface via that layer. > > Hi John > > I know of swconfig. However, it has

Re: [PATCH net-next v2 8/9] net: ipmr: rearrange and cleanup setsockopt

2015-11-22 Thread Cong Wang
On Sat, Nov 21, 2015 at 6:57 AM, Nikolay Aleksandrov wrote: > net/ipv4/ipmr.c | 191 > +++- > 1 file changed, 107 insertions(+), 84 deletions(-) Does this really simplify the code? :-/ -- To unsubscribe from this list:

Re: [PATCH net-next v2 4/9] net: ipmr: fix code and comment style

2015-11-22 Thread Cong Wang
On Sat, Nov 21, 2015 at 6:57 AM, Nikolay Aleksandrov wrote: > - > -/* > - * Setup for IP multicast routing > - */ > +/* Setup for IP multicast routing */ > static int __net_init ipmr_net_init(struct net *net) Comments like this one are never useful so can be just

Re: [PATCH net-next v2 2/9] net: ipmr: always define mroute_reg_vif_num

2015-11-22 Thread Cong Wang
On Sat, Nov 21, 2015 at 6:57 AM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > Before mroute_reg_vif_num was defined only if any of the CONFIG_PIMSM_ > options were set, but that's not really necessary as the size of the > struct is

Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup

2015-11-22 Thread Daniel Wagner
Hi Tejun, On 11/21/2015 05:13 PM, Tejun Heo wrote: > This is v3 of the xt_cgroup2 patchset. Changes from the last take are > > * Folded cgroup2 path matching into xt_cgroup as a new revision rather > than a separate xt_cgroup2 match as suggested by Pablo. > > * Refreshed on top of Nina's

Re: r8169 regression: UDP packets dropped intermittantly

2015-11-22 Thread Jonathan Woithe
On Fri, Nov 20, 2015 at 11:45:34PM +0100, Francois Romieu wrote: > The hardware stats are not exactly clear. Is the initial Tx - Rx packet > difference (6) at the hardware stats level expected ? Sorry, I missed this question earlier. When speaking to the external device, each UDP command packet

Re: What's the benefit of large Rx rings?

2015-11-22 Thread Yuval Mintz
>> This might be a dumb question, but I recently touched this >> and felt like I'm missing something basic - >> >> NAPI is being scheduled from soft-interrupt contex, and it >> has a ~strict quota for handling Rx packets [even though we're >> allowing practically unlimited handling of Tx

Re: r8169 regression: UDP packets dropped intermittantly

2015-11-22 Thread Jonathan Woithe
On Mon, Nov 23, 2015 at 12:02:44AM +0100, Francois Romieu wrote: > Jonathan Woithe : > [...] > > I'm a little confused though as to which patch you want me to apply. There > > was an inline patch against r8169.c in your message, and then there was > > another patch to

Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages

2015-11-22 Thread Dave Young
On 11/20/15 at 12:55pm, Johannes Berg wrote: > On Sun, 2015-11-15 at 19:25 +0100, Stefan Lippers-Hollmann wrote: > > Hi > > > > On 2015-11-15, Dave Young wrote: > > > cfg80211 module prints a lot of messages like below. Actually > > > printing once is acceptable but sometimes it will print again

Re: r8169 regression: UDP packets dropped intermittantly

2015-11-22 Thread Francois Romieu
Jonathan Woithe : [...] > I'm a little confused though as to which patch you want me to apply. There > was an inline patch against r8169.c in your message, and then there was > another patch to r8169.c in the form of an attachment. Both patches removed > the include of

Re: r8169 regression: UDP packets dropped intermittantly

2015-11-22 Thread Jonathan Woithe
On Sat, Nov 21, 2015 at 11:36:27PM +0100, Francois Romieu wrote: > Francois Romieu : > [...] > > If you can crash your system at will, you may apply the patch below to > da78dbff2e05630921c551dbbc70a4b7981a8fff ("r8169: remove work from irq > handler.") parent (aka

Re: [RFC 5/8] net-next: ralink: add support for rt3050 family

2015-11-22 Thread Andrew Lunn
> Hi Andrew, > > we have had a switch layer inside openwrt called swconfig for several > years. at the moment i have an add-on patch in openwrt to provide an > userland interface via that layer. Hi John I know of swconfig. However, it has been NACKed for mainline. So you either need to do

Re: [PATCH net-next 1/2] net: l3mdev: Add master device lookup by index

2015-11-22 Thread David Ahern
On 11/22/15 11:17 AM, David Miller wrote: From: David Ahern Date: Sun, 22 Nov 2015 10:30:32 -0700 In this case ... I understand the problem you are trying to solve, but I am saying you can't use sk_bound_dev_if to use it. I am confused by that response given

Re: [PATCH net-next 1/2] net: l3mdev: Add master device lookup by index

2015-11-22 Thread David Miller
From: David Ahern Date: Sun, 22 Nov 2015 21:02:04 -0700 > I am confused by that response given that sk_bound_dev_if is one of > the key principals for the VRF implementation. Applications wanting to > communicate over interfaces in a VRF have to set sk_bound_dev_if.

[RFC 5/8] net-next: ralink: add support for rt3050 family

2015-11-22 Thread John Crispin
Add support for SoCs from the rt3050 family. This include rt3050, rt3052, rt3352 and rt5350. These all have a builtin 5 port 100mbit switch. This patch includes rudimentary code to power up the switch. There are a lot of magic values that get written to the switch and the internal phys. These

[RFC 4/8] net-next: ralink: add support for rt2880

2015-11-22 Thread John Crispin
rt2880 is the oldest SoC with this core. It has a single gBit port that will normally be attached to an external phy of switch. The patch also adds the code required to drive the mdio bus. Signed-off-by: John Crispin Signed-off-by: Felix Fietkau

[RFC 3/8] net-next: ralink: add the drivers core files

2015-11-22 Thread John Crispin
This patch adds the main chunk of the driver. The ethernet core is used in all of the Mediatek/Ralink Wireless SoCs. Over the years we have seen verious changes to * the register layout * the type of ports (single/dual gbit, internal FE/Gbit switch) * dma engine and new offloading features were

[RFC 2/8] net-next: phy: dont auto handle carrier state when multiple phys are attached

2015-11-22 Thread John Crispin
A network core might have more than one phy attached to its cpu port via a switch. The current code will set the carrier state to on/off when ever a cable is plugged into any of these ports. The patch adds a new bool that allows the driver to tell the phy_device to not set the carrier state.

[RFC 1/8] Documentation: DT: net: add docs for ralink/mediatek SoC ethernet binding

2015-11-22 Thread John Crispin
Add three files. ralink,rt2880-net.txt descibes the actual frame engine and the other two describe the switch forntend bindings. Signed-off-by: John Crispin Signed-off-by: Felix Fietkau Signed-off-by: Michael Lee Cc:

[RFC 8/8] net-next: ralink: add Kconfig and Makefile

2015-11-22 Thread John Crispin
This patch adds the Makefile and Kconfig required to make the driver build. Signed-off-by: John Crispin Signed-off-by: Felix Fietkau Signed-off-by: Michael Lee --- drivers/net/ethernet/Kconfig |1 +

[RFC 6/8] net-next: ralink: add support for rt3883

2015-11-22 Thread John Crispin
Add support for rt3883 and its smaller version rt3662. They both have a single gBit port that will normally be attached to an external phy of switch. Signed-off-by: John Crispin Signed-off-by: Felix Fietkau Signed-off-by: Michael Lee ---

[RFC 7/8] net-next: ralink: add support for mt7620 family

2015-11-22 Thread John Crispin
Add support for SoCs from the mt7620 family. This include mt7620 and mt7621. These all have one dedicated external gbit port and a builtin 5 port 100mbit switch. Additionally one of the 5 switch ports can be changed to become an additional gbit port that we can attach a phy to. This patch includes

[PATCH 02/13] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0

2015-11-22 Thread Marcin Wojtas
The Ethernet controller found in the Armada 38x SoC's family support TCP/IP checksumming with frame sizes larger than 1600 bytes, however only on port 0. This commit enables this feature by using 'marvell,armada-xp-neta' in 'ethernet@7' node. Signed-off-by: Marcin Wojtas

[PATCH 03/13] net: mvneta: fix bit assignment in MVNETA_RXQ_CONFIG_REG

2015-11-22 Thread Marcin Wojtas
MVNETA_RXQ_HW_BUF_ALLOC bit which controls enabling hardware buffer allocation was mistakenly set as BIT(1). This commit fixes the assignment. Signed-off-by: Marcin Wojtas Cc: # v3.8+ --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1

[PATCH v1] net: stmmac: Free rx_skbufs before realloc

2015-11-22 Thread Shunqian Zheng
From: ZhengShunQian The init_dma_desc_rings() may realloc the rx_skbuff[] when suspend and resume. This patch free the rx_skbuff[] before reallocing memory. Signed-off-by: ZhengShunQian --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 18

[RFC PATCH v1] Trying to fix the stmmac memory leak during suspend/resume

2015-11-22 Thread Shunqian Zheng
From: ZhengShunQian When I run Suspend-to-Ram stress test on my Rockchip RK3288(SoC) board that integrated stmmac ethernet, it always OOM after a few iterations, usually 50 times is enough to reproduce. Compiled kernel with KMEMLEAK feature, I got the logs as below:

RE: [PATCH V3 net-next 3/5] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support HNS Driver

2015-11-22 Thread Yuval Mintz
> +static void hns_ae_set_tso_stats(struct hnae_handle *handle, int > +enable) { > + struct hns_ppe_cb *ppe_cb = hns_get_ppe_cb(handle); > + > + hns_ppe_set_tso_enable(ppe_cb, enable); } Style issues? > +void hns_ppe_set_tso_enable(struct hns_ppe_cb *ppe_cb, u32 value) { > +

Re: Use-after-free in ppoll

2015-11-22 Thread Dmitry Vyukov
On Sun, Nov 22, 2015 at 3:32 PM, Rainer Weikusat wrote: > Dmitry Vyukov writes: >> Hello, >> >> On commit f2d10565b9bdbb722bd43e6e1a759eeddb9645c8 (Nov 20). >> >> The following program triggers use-after-free: >> >> // autogenerated by

Re: Use-after-free in ppoll

2015-11-22 Thread Rainer Weikusat
Dmitry Vyukov writes: > Hello, > > On commit f2d10565b9bdbb722bd43e6e1a759eeddb9645c8 (Nov 20). > > The following program triggers use-after-free: > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include > #include > #include > > void

Use-after-free in ppoll

2015-11-22 Thread Dmitry Vyukov
Hello, On commit f2d10565b9bdbb722bd43e6e1a759eeddb9645c8 (Nov 20). The following program triggers use-after-free: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include void *thread(void *p) { syscall(SYS_write, (long)p,

Re: [PATCH 10/13] ARM: mvebu: add buffer manager nodes to armada-38x.dtsi

2015-11-22 Thread Sergei Shtylyov
Hello. On 11/22/2015 10:53 AM, Marcin Wojtas wrote: Armada 38x network controller supports hardware buffer management (BM). Since it is now enabled in mvneta driver, appropriate nodes can be added to armada-38x.dtsi - for the actual common BM unit (bm@c8000) and its internal SRAM (bm-bppi),

RE: [PATCH 07/15] net: Add driver helper functions to determine checksum offloadability

2015-11-22 Thread Yuval Mintz
> +struct skb_csum_offl_spec { ... > + no_encapped_ipv6:1, ... > +}; I don't think it's actually checked by this patch. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: Kernel 4.1.12 crash

2015-11-22 Thread Andrew
22.11.2015 07:17, Alexander Duyck wrote: On 11/21/2015 12:16 AM, Andrew wrote: Memory corruption, if happens, IMHO shouldn't be a hardware-related - almost all of these boxes, except H61M-based box from 1st log, works for a long time with uptime more than year; and only software was changed on

RE: [PATCH V4 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS

2015-11-22 Thread Yuval Mintz
> +static netdev_features_t hns_nic_fix_features( > + struct net_device *netdev, netdev_features_t features) { > + struct hns_nic_priv *priv = netdev_priv(netdev); > + > + switch (priv->enet_ver) { > + case AE_VERSION_1: > + features &= ~(NETIF_F_TSO |

MULTIPLE_TABLES and IP_ADVANCED_ROUTER

2015-11-22 Thread Geert Uytterhoeven
Hi, Is there a reason why IP_MULTIPLE_TABLES and IP_MROUTE_MULTIPLE_TABLES depend on IP_ADVANCED_ROUTER, while their IPV6 counterparts don't? net/ipv4/Kconfig: config IP_MULTIPLE_TABLES bool "IP: policy routing" depends on IP_ADVANCED_ROUTER

RE: [PATCH V3 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

2015-11-22 Thread Yuval Mintz
> +void hns_rcbv2_int_ctrl_hw(struct hnae_queue *q, u32 flag, u32 mask) > +{ > + u32 int_mask_en = !!mask; > + > + if (flag & RCB_INT_FLAG_TX) > + dsaf_write_dev(q, RCB_RING_INTMSK_TXWL_REG, > int_mask_en); > + > + if (flag & RCB_INT_FLAG_RX) > +

RE: [PATCH V3 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver

2015-11-22 Thread Yuval Mintz
> static void hns_ppe_init_hw(struct hns_ppe_cb *ppe_cb) { ... > + /* Set default RSS key and indrection table*/ > + const u32 rss_key[HNS_PPEV2_RSS_KEY_NUM] = { > + 0x6d5a56da, 0x255b0ec2, > + 0x4167253d, 0x43a38fb0, > + 0xd0ca2bcb, 0xae7b30b4, > +

[PATCH net-next] bnx2x: Utilize FW 7.13.1.0.

2015-11-22 Thread Yuval Mintz
Commit 46e8a249423ff "bnx2x: Add FW 7.13.1.0" added said .bin FW to linux-firmware; This patch incorporates the FW in the bnx2x driver. This introduces 2 fixes/enhancements: - In some management protocols there are outer-vlan configurations that can be dynamically changed while device is

Re: [PATCH 02/13] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0

2015-11-22 Thread Arnd Bergmann
On Sunday 22 November 2015 08:53:48 Marcin Wojtas wrote: > The Ethernet controller found in the Armada 38x SoC's family support > TCP/IP checksumming with frame sizes larger than 1600 bytes, however > only on port 0. > > This commit enables this feature by using 'marvell,armada-xp-neta' in >

Re: [PATCH 00/13] mvneta Buffer Management and enhancements

2015-11-22 Thread Arnd Bergmann
On Sunday 22 November 2015 08:53:46 Marcin Wojtas wrote: > > 3. Optimisations - concatenating TX descriptors' flush, basing on > xmit_more support and combined approach for finalizing egress processing. > Thanks to HR timer buffers can be released with small latency, which is > good for low

Re: [PATCH 07/13] bus: mvebu-mbus: provide api for obtaining IO and DRAM window information

2015-11-22 Thread Arnd Bergmann
On Sunday 22 November 2015 08:53:53 Marcin Wojtas wrote: > This commit enables finding appropriate mbus window and obtaining its > target id and attribute for given physical address in two separate > routines, both for IO and DRAM windows. This functionality > is needed for Armada XP/38x Network

Re: [PATCH net-next 1/2] net: l3mdev: Add master device lookup by index

2015-11-22 Thread David Miller
From: David Ahern Date: Sun, 22 Nov 2015 10:30:32 -0700 > In this case ... I understand the problem you are trying to solve, but I am saying you can't use sk_bound_dev_if to use it. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: Use-after-free in ppoll

2015-11-22 Thread Rainer Weikusat
Dmitry Vyukov writes: > On Sun, Nov 22, 2015 at 3:32 PM, Rainer Weikusat > wrote: >> Dmitry Vyukov writes: >>> Hello, >>> >>> On commit f2d10565b9bdbb722bd43e6e1a759eeddb9645c8 (Nov 20). >>> >>> The following program

Re: Use-after-free in ppoll

2015-11-22 Thread Rainer Weikusat
Rainer Weikusat writes: [...] > because of the close, this routine will be called with the peer_wait > wait_queue_head of the non-closed socket of the socket pair as > wait_address argument. This should have been "peer_wait wait_queue_head of the peer of the

Re: [RFC 5/8] net-next: ralink: add support for rt3050 family

2015-11-22 Thread John Crispin
On 22/11/2015 17:36, Andrew Lunn wrote: > On Sun, Nov 22, 2015 at 09:40:55AM +0100, John Crispin wrote: >> Add support for SoCs from the rt3050 family. This include rt3050, rt3052, >> rt3352 and rt5350. These all have a builtin 5 port 100mbit switch. This patch >> includes rudimentary code to

Re: [RFC 5/8] net-next: ralink: add support for rt3050 family

2015-11-22 Thread Andrew Lunn
On Sun, Nov 22, 2015 at 09:40:55AM +0100, John Crispin wrote: > Add support for SoCs from the rt3050 family. This include rt3050, rt3052, > rt3352 and rt5350. These all have a builtin 5 port 100mbit switch. This patch > includes rudimentary code to power up the switch. Hi John How do you plan to

Re: [PATCH net-next] net: IPv6 fib lookup tracepoint

2015-11-22 Thread David Miller
From: David Ahern Date: Thu, 19 Nov 2015 12:24:22 -0800 > Add tracepoint to show fib6 table lookups and result. > > Signed-off-by: David Ahern Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: [PATCH net-next] bnx2x: Utilize FW 7.13.1.0.

2015-11-22 Thread David Miller
From: Yuval Mintz Date: Sun, 22 Nov 2015 15:01:29 +0200 > Commit 46e8a249423ff "bnx2x: Add FW 7.13.1.0" added said .bin FW to > linux-firmware; This patch incorporates the FW in the bnx2x driver. > > This introduces 2 fixes/enhancements: > - In some management protocols

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

2015-11-22 Thread Kalle Valo
Arend van Spriel writes: > On 11/19/2015 08:48 AM, Kalle Valo wrote: >> Hauke Mehrtens writes: >> >>> On 11/18/2015 03:45 PM, Kalle Valo wrote: Part of reorganising wireless drivers directory and Kconfig. Note that I had to edit Makefiles

[PATCH v3] packet: Allow packets with only a header (but no payload)

2015-11-22 Thread Martin Blumenstingl
Commit 9c7077622dd91 ("packet: make packet_snd fail on len smaller than l2 header") added validation for the packet size in packet_snd. This change enforces that every packet needs a header (with at least hard_header_len bytes) plus a payload with at least one byte. Before this change the payload

Re: [PATCH net-next 1/2] net: l3mdev: Add master device lookup by index

2015-11-22 Thread David Miller
From: David Ahern Date: Thu, 19 Nov 2015 12:32:00 -0800 > Add helper to lookup master index given a device index. > > Signed-off-by: David Ahern I don't like where this is going. sk->sk_bound_dev_if is for device bindings which the user has

Re: [PATCH net-next 1/2] net: l3mdev: Add master device lookup by index

2015-11-22 Thread David Ahern
On 11/22/15 10:23 AM, David Miller wrote: From: David Ahern Date: Thu, 19 Nov 2015 12:32:00 -0800 Add helper to lookup master index given a device index. Signed-off-by: David Ahern I don't like where this is going. sk->sk_bound_dev_if

Re: [PATCH v2 00/27] wireless drivers vendor directories

2015-11-22 Thread Kalle Valo
Kalle Valo writes: > Hi, > > I started to reorganise drivers/net/wireless directory and follow what > drivers/net/ethernet has. The major change is that new vendor > directories are created and most of the drivers are now under those > vendor directories: > > admtek/ > ath/

Re: [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions

2015-11-22 Thread Pablo Neira Ayuso
On Sat, Nov 21, 2015 at 11:18:46AM -0500, Tejun Heo wrote: > libxt_cgroup will grow cgroup2 path based match. Postfix existing > symbols with _v0 and prepare for multi revision registration. While > at it, rename O_CGROUP to O_CLASSID and fwid to classid. > > Signed-off-by: Tejun Heo

Re: [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions

2015-11-22 Thread Pablo Neira Ayuso
On Sun, Nov 22, 2015 at 09:31:28PM +0100, Pablo Neira Ayuso wrote: > On Sat, Nov 21, 2015 at 11:18:46AM -0500, Tejun Heo wrote: > > --- a/extensions/libxt_cgroup.c > > +++ b/extensions/libxt_cgroup.c > > @@ -3,30 +3,30 @@ > > #include > > > > enum { > > - O_CGROUP = 0, > > + O_CLASSID =

What's the benefit of large Rx rings?

2015-11-22 Thread Yuval Mintz
Hi, This might be a dumb question, but I recently touched this and felt like I'm missing something basic - NAPI is being scheduled from soft-interrupt contex, and it has a ~strict quota for handling Rx packets [even though we're allowing practically unlimited handling of Tx completions]. Given

Re: [PATCH 02/13] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0

2015-11-22 Thread Marcin Wojtas
Arnd, 2015-11-22 21:00 GMT+01:00 Arnd Bergmann : > On Sunday 22 November 2015 08:53:48 Marcin Wojtas wrote: >> The Ethernet controller found in the Armada 38x SoC's family support >> TCP/IP checksumming with frame sizes larger than 1600 bytes, however >> only on port 0. >> >> This

Re: [PATCH 07/13] bus: mvebu-mbus: provide api for obtaining IO and DRAM window information

2015-11-22 Thread Marcin Wojtas
Arnd, 2015-11-22 21:02 GMT+01:00 Arnd Bergmann : > On Sunday 22 November 2015 08:53:53 Marcin Wojtas wrote: >> This commit enables finding appropriate mbus window and obtaining its >> target id and attribute for given physical address in two separate >> routines, both for IO and

Re: [PATCH 02/13] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0

2015-11-22 Thread Arnd Bergmann
On Sunday 22 November 2015 22:04:38 Marcin Wojtas wrote: > 2015-11-22 21:00 GMT+01:00 Arnd Bergmann : > > On Sunday 22 November 2015 08:53:48 Marcin Wojtas wrote: > >> The Ethernet controller found in the Armada 38x SoC's family support > >> TCP/IP checksumming with frame sizes

Re: [PATCH 00/13] mvneta Buffer Management and enhancements

2015-11-22 Thread Marcin Wojtas
Arnd, 2015-11-22 21:06 GMT+01:00 Arnd Bergmann : > On Sunday 22 November 2015 08:53:46 Marcin Wojtas wrote: >> >> 3. Optimisations - concatenating TX descriptors' flush, basing on >> xmit_more support and combined approach for finalizing egress processing. >> Thanks to HR timer

alternate queueing mechanism (was: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue)

2015-11-22 Thread Rainer Weikusat
Rainer Weikusat writes: [AF_UNIX SOCK_DGRAM throughput] > It may be possible to improve this by tuning/ changing the flow > control mechanism. Out of my head, I'd suggest making the queue longer > (the default value is 10) and delaying wake ups until the

Re: What's the benefit of large Rx rings?

2015-11-22 Thread Alexander Duyck
On Sun, Nov 22, 2015 at 12:19 PM, Yuval Mintz wrote: > Hi, > > This might be a dumb question, but I recently touched this > and felt like I'm missing something basic - > > NAPI is being scheduled from soft-interrupt contex, and it > has a ~strict quota for handling Rx

Re: [PATCH 02/13] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0

2015-11-22 Thread Marcin Wojtas
Arnd, > > If the feature set depends on the port number, we should think about > the way it gets handled again, as this is probably better not described > as something that depends (just) on the SoC, but on the way it gets > integrated. Maybe we can introduce an additional property for the >

[PATCH] staging: rtl8712: Cleanup _io_ops wrappers

2015-11-22 Thread Mauro Dreissig
This removes ugly and unnecessary declarations. Signed-off-by: Mauro Dreissig --- drivers/staging/rtl8712/rtl8712_io.c | 77 +++- 1 file changed, 22 insertions(+), 55 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_io.c