Re: [RFC PATCH 0/2] Crypto kernel TLS socket

2015-11-23 Thread Hannes Frederic Sowa
Hello, On Mon, Nov 23, 2015, at 18:42, Dave Watson wrote: > An approach for a kernel TLS socket. > > Only the symmetric encryption / decryption is done in-kernel, as well > as minimal framing handling. The handshake is kept in userspace, and > the negotiated cipher / keys / IVs are then set on

Re: [PATCH net-next] bpf: add show_fdinfo handler for maps

2015-11-23 Thread Hannes Frederic Sowa
On Mon, Nov 23, 2015, at 20:09, John Fastabend wrote: > On 15-11-23 10:03 AM, Alexei Starovoitov wrote: > > On Mon, Nov 23, 2015 at 05:11:58PM +0100, Hannes Frederic Sowa wrote: > >> > >> Actually, that is the reason why I mentioned it, so *the admin* can see > >> something is going on. Do you

Re: [RFC PATCH 2/2] Crypto kernel tls socket

2015-11-23 Thread Sowmini Varadhan
On (11/23/15 09:43), Dave Watson wrote: > Currently gcm(aes) represents ~80% of our SSL connections. > > Userspace interface: > > 1) A transform and op socket are created using the userspace crypto interface > 2) Setsockopt ALG_SET_AUTHSIZE is called > 3) Setsockopt ALG_SET_KEY is called twice,

Re: [PATCH 1/2] arm64: bpf: add 'store immediate' instruction

2015-11-23 Thread Shi, Yang
Hi folks, Any more comments on this patch (store immediate only)? I need more time to add XADD (I'm supposed everyone agrees it is equivalent to atomic_add). However, this one is irrelevant to XADD, so we may be able to apply it first? Thanks, Yang On 11/12/2015 7:45 PM, Z Lim wrote: On

Re: [PATCH net-next 0/6] kcm: Kernel Connection Multiplexor (KCM)

2015-11-23 Thread Hannes Frederic Sowa
Hello Tom, On Mon, Nov 23, 2015, at 18:33, Tom Herbert wrote: > > For me this still looks a little bit like messages could be delimited by > > TCP PSH flag, where we might need to have some more fine grained control > > over and besides that just adding better fanout semantics to TCP, no? > > >

[net-next 12/15] i40evf: fix compiler warning of unused variable

2015-11-23 Thread Jeff Kirsher
From: Jesse Brandeburg Compiler complained of an unused variable, which the driver was just using to store the result of a rd32 which is used to clear a register unconditionally. Just drop the unused variable and re-use one. Signed-off-by: Jesse Brandeburg

[net-next 11/15] ixgbe: Remove CS4227 diagnostic code

2015-11-23 Thread Jeff Kirsher
From: Mark Rustad Testing has now shown that the diagnostic code used with the CS4227 is no longer needed, so remove it. Signed-off-by: Mark Rustad Tested-by: Darin Miller Signed-off-by: Jeff Kirsher

[net-next 14/15] ixgbevf: fix spoofed packets with random MAC

2015-11-23 Thread Jeff Kirsher
From: Emil Tantilov If ixgbevf is loaded while the corresponding PF interface is down and the driver assigns a random MAC address, that address can be overwritten with the value of hw->mac.perm_addr, which would be 0 at that point. To avoid this case we init

[net-next 01/15] fm10k: do not assume VF always has 1 queue

2015-11-23 Thread Jeff Kirsher
From: Jacob Keller It is possible that the PF has not yet assigned resources to the VF. Although rare, this could result in the VF attempting to read queues it does not own and result in FUM or THI faults in the PF. To prevent this, check queue 0 before we continue in

[net-next 07/15] ixgbe: Fix handling of NAPI budget when multiple queues are enabled per vector

2015-11-23 Thread Jeff Kirsher
From: Alexander Duyck This patch corrects an issue in which the polling routine would increase the budget for Rx to at least 1 per queue if multiple queues were present. This would result in Rx packets being processed when the budget was 0 which is meant to indicate that no

[net-next 04/15] ixgbe: Delete redundant include file

2015-11-23 Thread Jeff Kirsher
From: Mark Rustad Delete a redundant include of net/vxlan.h. Signed-off-by: Mark Rustad Tested-by: Darin Miller Signed-off-by: Jeff Kirsher ---

[net-next 05/15] ixgbe: fix multiple kernel-doc errors

2015-11-23 Thread Jeff Kirsher
From: Jean Sacren The commit dfaf891dd3e1 ("ixgbe: Refactor the RSS configuration code") introduced a few kernel-doc errors: 1) The function name is missing; 2) The format is wrong; 3) The short description is redundant. Fix all the above for the correct execution of the

[net-next 03/15] ixgbe: drop null test before destroy functions

2015-11-23 Thread Jeff Kirsher
From: Julia Lawall Remove unneeded NULL test. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; @@ -if (x != NULL) \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); // Signed-off-by: Julia Lawall

[net-next 10/15] ixgbe/ixgbevf: use napi_schedule_irqoff()

2015-11-23 Thread Jeff Kirsher
From: Alexander Duyck The ixgbe_intr and ixgbe/ixgbevf_msix_clean_rings functions run from hard interrupt context or with interrupts already disabled in netpoll. They can use napi_schedule_irqoff() instead of napi_schedule() Signed-off-by: Alexander Duyck

[net-next 09/15] ixgbevf: Limit lowest interrupt rate for adaptive interrupt moderation to 12K

2015-11-23 Thread Jeff Kirsher
From: Alexander Duyck This patch is the ixgbevf version of commit 8ac34f10a5ea4 "ixgbe: Limit lowest interrupt rate for adaptive interrupt moderation to 12K" The same logic applies here as well as the same results since a netperf test will starve for memory in the time from

[net-next 06/15] fm10k: Fix handling of NAPI budget when multiple queues are enabled per vector

2015-11-23 Thread Jeff Kirsher
From: Alexander Duyck This patch corrects an issue in which the polling routine would increase the budget for Rx to at least 1 per queue if multiple queues were present. This would result in Rx packets being processed when the budget was 0 which is meant to indicate that no

[net-next 02/15] fm10k: Correct MTU for jumbo frames

2015-11-23 Thread Jeff Kirsher
From: Jacob Keller Based on hardware testing, the host interface supports up to 15368 bytes as the maximum frame size. To determine the correct MTU, we subtract 8 for the internal switch tag, 14 for the L2 header, and 4 for the appended FCS header, resulting in 15342

[net-next 08/15] ixgbe: Add KR mode support for CS4227 chip

2015-11-23 Thread Jeff Kirsher
From: Mark Rustad KR auto-neg mode is what we will be using going forward. The SW interface for this mode is different that what was used for iXFI. Signed-off-by: Mark Rustad Tested-by: Phil Schmitt Signed-off-by:

[net-next 15/15] intel: i40e: fix confused code

2015-11-23 Thread Jeff Kirsher
From: Rasmus Villemoes This code is pretty confused. The variable name 'bytes_not_copied' clearly indicates that the programmer knew the semantics of copy_{to,from}_user, but then the return value is checked for being negative and used as a -Exxx return value. I'm not

[net-next 13/15] ixgbevf: use ether_addr_copy instead of memcpy

2015-11-23 Thread Jeff Kirsher
From: Emil Tantilov replace some instances of memcpy for setting up the mac address with ether_addr_copy() Signed-off-by: Emil Tantilov Tested-by: Darin Miller Signed-off-by: Jeff Kirsher

Re: [PATCH net-next] bpf: add show_fdinfo handler for maps

2015-11-23 Thread John Fastabend
On 15-11-23 11:12 AM, Hannes Frederic Sowa wrote: > On Mon, Nov 23, 2015, at 20:09, John Fastabend wrote: >> On 15-11-23 10:03 AM, Alexei Starovoitov wrote: >>> On Mon, Nov 23, 2015 at 05:11:58PM +0100, Hannes Frederic Sowa wrote: Actually, that is the reason why I mentioned it, so *the

Re: [PATCH net-next 10/18] net/mlx5e: Write vlan list into vport context

2015-11-23 Thread Saeed Mahameed
On Mon, Nov 23, 2015 at 7:30 PM, Alexander Duyck wrote: > On 11/23/2015 03:11 AM, Or Gerlitz wrote: >> >> From: Saeed Mahameed >> >> Each Vport/vNIC must notify underlying e-Switch layer >> for vlan table changes in-order to update SR-IOV FDB

Re: [PATCH 13/14] mm: memcontrol: account socket memory in unified hierarchy memory controller

2015-11-23 Thread Johannes Weiner
On Mon, Nov 23, 2015 at 01:00:59PM +0300, Vladimir Davydov wrote: > I've another question regarding this socket_work: its reclaim target > always equals CHARGE_BATCH. Can't it result in a workload exceeding > memory.high in case there are a lot of allocations coming from different > cpus? In this

[net-next 00/15][pull request] Intel Wired LAN Driver Updates 2015-11-23

2015-11-23 Thread Jeff Kirsher
This series contains updates to ixgbe, ixgbevf, fm10k, i40e and i40evf. Jacob fixes an issue where VF could attempt to read queues it does not own, so prevent this we check queue 0 before we continue. Matthew fixes the MTU for jumbo frames for fm10k. Julia Lawall cleans up a unneeded NULL test

Re: [PATCH net-next 0/6] kcm: Kernel Connection Multiplexor (KCM)

2015-11-23 Thread David Miller
From: Tom Herbert Date: Mon, 23 Nov 2015 09:33:44 -0800 > The TCP PSH flag is not defined for message delineation (neither is > urgent pointer). We can't change that (many people have tried to add > message semantics to TCP protocol but have always failed miserably).

Re: [PATCH net-next] bpf: add show_fdinfo handler for maps

2015-11-23 Thread Alexei Starovoitov
On Mon, Nov 23, 2015 at 05:11:58PM +0100, Hannes Frederic Sowa wrote: > > Actually, that is the reason why I mentioned it, so *the admin* can see > something is going on. Do you want to protect ebpf from root? Skynet? ;) correct. To me both root and non-root are users in the first place and they

Re: [PATCH 09/14] net: tcp_memcontrol: simplify linkage between socket and page counter

2015-11-23 Thread Johannes Weiner
On Mon, Nov 23, 2015 at 12:36:46PM +0300, Vladimir Davydov wrote: > On Fri, Nov 20, 2015 at 01:56:48PM -0500, Johannes Weiner wrote: > > I actually had all this at first, but then wondered if it makes more > > sense to keep the legacy code in isolation. Don't you think it would > > be easier to

Re: [PATCH net-next 1/2] net: l3mdev: Add master device lookup by index

2015-11-23 Thread David Ahern
On 11/22/15 9:35 PM, David Miller wrote: From: David Ahern Date: Sun, 22 Nov 2015 21:02:04 -0700 I am confused by that response given that sk_bound_dev_if is one of the key principals for the VRF implementation. Applications wanting to communicate over interfaces in

Re: [patch] net/hsr: fix a warning message

2015-11-23 Thread David Miller
From: Dan Carpenter Date: Sat, 21 Nov 2015 13:34:12 +0300 > WARN_ON_ONCE() takes a condition, it doesn't take an error message. I > have converted this to WARN() instead. > > Signed-off-by: Dan Carpenter Applied, thanks Dan. -- To

Re: [PATCH net-next 09/18] net/mlx5e: Write UC/MC list and promisc mode into vport context

2015-11-23 Thread Saeed Mahameed
On Mon, Nov 23, 2015 at 7:23 PM, Alexander Duyck wrote: > On 11/23/2015 03:11 AM, Or Gerlitz wrote: >> >> From: Saeed Mahameed >> >> Each Vport/vNIC must notify underlying e-Switch layer >> for UC/MC list and promisc mode updates, in-order to

Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup

2015-11-23 Thread Tejun Heo
Hello, On Mon, Nov 23, 2015 at 10:53:46AM -0500, Tejun Heo wrote: > > [ 11.594536] [ cut here ] > > [ 11.595274] WARNING: CPU: 1 PID: 1 at kernel/cgroup_pids.c:97 > > pids_cancel.constprop.6+0x31/0x40() > > [ 11.595958] Modules linked in: > > [ 11.596199] CPU: 1

Re: [PATCH net-next 0/6] kcm: Kernel Connection Multiplexor (KCM)

2015-11-23 Thread Tom Herbert
On Mon, Nov 23, 2015 at 11:54 AM, David Miller wrote: > From: Tom Herbert > Date: Mon, 23 Nov 2015 09:33:44 -0800 > >> The TCP PSH flag is not defined for message delineation (neither is >> urgent pointer). We can't change that (many people have tried

[PATCH] drivers: net: xgene: fix: ifconfig up/down crash

2015-11-23 Thread Iyappan Subramanian
Fixing kernel crash when doing ifconfig down and up in a loop, [ 124.028237] Call trace: [ 124.030670] [] memcpy+0x20/0x180 [ 124.035436] [] skb_clone+0x3c/0xa8 [ 124.040374] [] __skb_tstamp_tx+0xc0/0x118 [ 124.045918] [] skb_tstamp_tx+0x10/0x1c [ 124.051203] [] xgene_enet_start_xmit+0x2e4/0x33c

Re: [PATCH RFC v2 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-11-23 Thread Bendik Rønning Opstad
On 23/11/15 18:43, Eric Dumazet wrote: > On Mon, 2015-11-23 at 17:26 +0100, Bendik Rønning Opstad wrote: > >> > + >> > +tcp_rdb_max_skbs - INTEGER >> > + Enable restriction on how many previous SKBs in the output queue >> > + RDB may include data from. A value of 1 will restrict bundling to >>

Re: [PATCH net-next v2 0/9] net: ipmr: cleanups and minor improvements

2015-11-23 Thread David Miller
From: Nikolay Aleksandrov Date: Sat, 21 Nov 2015 15:57:23 +0100 > Since I'll have to work with ipmr, I decided to clean it up and do some > minor improvements. Functionally there're almost no changes except the > SLAB_PANIC removal. Most of the patches just re-design some

Re: [net-next:master 48/50] net/dsa/dsa.c:783:16: error: implicit declaration of function 'gpio_to_desc'

2015-11-23 Thread David Miller
From: kbuild test robot Date: Tue, 24 Nov 2015 01:34:51 +0800 > All error/warnings (new ones prefixed by >>): > >net/dsa/dsa.c: In function 'dsa_of_probe': >>> net/dsa/dsa.c:783:16: error: implicit declaration of function >>> 'gpio_to_desc'

Re: stmmac: debugfs broken with multiple ethernets.

2015-11-23 Thread Pavel Machek
Hi! > stmmac_main will happily try to create two directories with the same > name. > > I guess something like > > static int id; > char name[100]; > > sprintf(name, STMMAC_RESOURCE_NAME "_%d", id++) > ... > > might be suitable, but did not try that further. Hmm. It seems this is fixed in

Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup

2015-11-23 Thread Daniel Wagner
On 11/23/2015 08:11 AM, Daniel Wagner wrote: > [3.217648] systemd[1]: tmp.mount: Directory /tmp to mount over is not > empty, mounting anyway. > [3.224665] BUG: spinlock bad magic on CPU#1, systemd/1 > [3.225653] lock: cgroup_sk_update_lock+0x0/0x60, .magic: , > .owner:

pull-request: can-next 2015-11-23

2015-11-23 Thread Marc Kleine-Budde
-22 20:47:14 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git tags/linux-can-next-for-4.5-20151123 for you to fetch changes up to 4716620d1b6291ce45522d1346c086f76b995d1c: can: xilinx: Convert to runtime_pm (2015-11-23 09:51

Re: [PATCH net-next 4/6] kcm: Kernel Connection Multiplexor module

2015-11-23 Thread Daniel Borkmann
On 11/20/2015 10:21 PM, Tom Herbert wrote: [...] + +/* Macro to invoke filter function. */ +#define KCM_RUN_FILTER(prog, ctx) \ + (*prog->bpf_func)(ctx, prog->insnsi) Any reason to redefine this macro? We already have the same one as: #define BPF_PROG_RUN(filter, ctx)

Re: [PATCH net-next v2 2/9] net: ipmr: always define mroute_reg_vif_num

2015-11-23 Thread Nikolay Aleksandrov
On 11/23/2015 06:23 AM, Cong Wang wrote: > On Sat, Nov 21, 2015 at 6:57 AM, Nikolay Aleksandrov > wrote: >> From: Nikolay Aleksandrov >> >> Before mroute_reg_vif_num was defined only if any of the CONFIG_PIMSM_ >> options were set, but that's not

Re: [PATCH net-next v2 4/9] net: ipmr: fix code and comment style

2015-11-23 Thread Nikolay Aleksandrov
On 11/23/2015 06:30 AM, Cong Wang wrote: > On Sat, Nov 21, 2015 at 6:57 AM, Nikolay Aleksandrov > wrote: >> - >> -/* >> - * Setup for IP multicast routing >> - */ >> +/* Setup for IP multicast routing */ >> static int __net_init ipmr_net_init(struct net *net) > >

[PATCH net-next v3 0/2] Netronome NFP4000/NFP6000 NIC VF driver

2015-11-23 Thread Jakub Kicinski
This patchset adds support for VFs of Netronome's NFP-4000 and NFP-6000 based NICs. We are currently also preparing the submission for the PF driver, but it is not quite ready yet. The PF driver can be found on GitHub: https://github.com/Netronome/nfp-drv-kmods changes since v2: Per DaveM

[PATCH net-next v3 1/2] pci_ids: add Netronome Systems vendor

2015-11-23 Thread Jakub Kicinski
Add PCI vendor id for Netronome Systems. Signed-off-by: Jakub Kicinski Signed-off-by: Rolf Neugebauer --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h

[PATCH net-next 17/18] net/mlx5: E-Switch, Introduce get vf statistics

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed Add support to get VF statistics using query vport counter command. Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/eswitch.c | 67 +++

[PATCH net-next 12/18] net/mlx5: E-Switch, Introduce FDB hardware capabilities

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed Define needed hardware structures and capabilities needed for E-Switch FDB flow tables and read them on driver load. Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz ---

[PATCH net-next 14/18] net/mlx5: E-Switch, Introduce Vport administration functions

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed Implement set VF mac/link state and query VF config to be used later in nedev VF ndos or any other management API. Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz ---

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

2015-11-23 Thread Arend van Spriel
On 11/23/2015 11:28 AM, Arend van Spriel wrote: On 11/22/2015 06:23 PM, Kalle Valo wrote: Arend van Spriel writes: On 11/19/2015 08:48 AM, Kalle Valo wrote: Hauke Mehrtens writes: On 11/18/2015 03:45 PM, Kalle Valo wrote: Part of reorganising

Re: [PATCH net-next v2 8/9] net: ipmr: rearrange and cleanup setsockopt

2015-11-23 Thread Nikolay Aleksandrov
On 11/23/2015 06:44 AM, Cong Wang wrote: > On Sat, Nov 21, 2015 at 6:57 AM, Nikolay Aleksandrov > wrote: >> net/ipv4/ipmr.c | 191 >> +++- >> 1 file changed, 107 insertions(+), 84 deletions(-) > > Does this really

[PATCH net-next 06/18] net/mlx5: Introduce access functions to modify/query vport state

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed In preparation for SR-IOV we add here an API to enable each e-switch manager (PF) to configure its VFs link states in e-switch preparation for ethernet sriov. Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz

[PATCH net-next 11/18] net/mlx5: Introducing E-Switch and l2 table

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed E-Switch is the software entity that represents and manages ConnectX4 inter-HCA ethernet l2 switching. E-Switch has its own Virtual Ports, each Vport/vNIC/VF can be connected to the device through a vport of an e-switch. Each e-switch is managed by one

[PATCH net-next 13/18] net/mlx5: E-Switch, Add SR-IOV (FDB) support

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed Enabling E-Switch SRIOV for nvfs+1 vports. Create E-Switch FDB for L2 UC/MC mac steering between VFs/PF and external vport (Uplink). FDB contains forwarding rules such as: UC MAC0 -> vport0(PF). UC MAC1 -> vport1. UC MAC2 ->

[PATCH net-next 18/18] net/mlx5e: Add support for SR-IOV ndos

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed Implement and enable SR-IOV ndos to manage SR-IOV configuration via netdev netlink API. Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 84

[PATCH net-next 02/18] net/mlx5_core: Add base sriov support

2015-11-23 Thread Or Gerlitz
From: Eli Cohen This patch adds SRIOV base support for mlx5 supported devices. The same driver is used for both PFs and VFs; VFs are identified by the driver through the flag MLX5_PCI_DEV_IS_VF added to the pci table entries. Virtual functions are created as usual through

[PATCH net-next 15/18] net/mlx5: E-Switch, Introduce HCA cap and E-Switch vport context

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed E-Switch vport context is unlike NIC vport context, managed by the E-Switch manager or vport_group_manager and not by the NIC(VF) driver. The E-Switch manager can access (read/modify) any of its vports E-Switch context. Currently E-Switch vport context

[PATCH net-next 03/18] net/mlx5: Add HW capabilities and structs for SR-IOV E-Switch.

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed Update HCA capabilities and HW struct to include needed capabilities for upcoming Ethernet Switch (SR-IOV E-Switch). Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz --- include/linux/mlx5/mlx5_ifc.h

[PATCH net-next 01/18] net/mlx5_core: Modify enable/disable hca functions

2015-11-23 Thread Or Gerlitz
From: Eli Cohen Modify these functions to have func_id argument to state which device we are referring to. This is done as a preparation for SRIOV support where a PF driver needs to control its virtual functions. Signed-off-by: Eli Cohen Signed-off-by: Or

[PATCH net-next 00/18] Introducing ConnectX-4 Ethernet SRIOV

2015-11-23 Thread Or Gerlitz
Hi Dave, This patchset introduces the support of Ethernet SRIOV in ConnectX-4 family of 100G Ethernet NICs. Some features are still missing, but all the basic SRIOV functionalities are there already. Basic Introduction: ConnectX-4 HW architecture provides two kinds of underlying HW switches.

[PATCH net-next 07/18] net/mlx5: Introduce access functions to modify/query vport promisc mode

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed Those functions are needed to notify the upcoming SR-IOV E-Switch(FDB) manager(PF), of the NIC vport (vf) promisc mode changes. Preperation for ethernet sriov and l2 table management. Signed-off-by: Saeed Mahameed Signed-off-by:

[PATCH net-next 05/18] net/mlx5: Introduce access functions to modify/query vport mac lists

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed Those functions are needed to notify the upcoming L2 table and SR-IOV E-Switch(FDB) manager(PF), of the NIC vport (vf) UC/MC mac lists changes. preperation for ethernet sriov and l2 table management. Signed-off-by: Saeed Mahameed

[PATCH net-next 04/18] net/mlx5: Update access functions to Query/Modify vport MAC address

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed In preparation for SR-IOV we add here an API to enable each e-switch client (PF/VF) to configure its L2 MAC addresses and for the e-switch manager (usually the PF) to access them in order to be able to configure them into the e-switch. Therefore we now

[PATCH net-next 16/18] net/mlx5: E-Switch, Introduce set vport vlan (VST mode)

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed Add query and modify functions to control client vlan and qos striping or insertion, in E-Switch vports contexts. Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz ---

[PATCH net-next 09/18] net/mlx5e: Write UC/MC list and promisc mode into vport context

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed Each Vport/vNIC must notify underlying e-Switch layer for UC/MC list and promisc mode updates, in-order to update l2 tables and SR-IOV FDB tables. We do that at set_rx_mode ndo. preperation for ethernet-SRIOV and l2 table management. Signed-off-by:

[PATCH net-next 08/18] net/mlx5: Introduce access functions to modify/query vport vlans

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed Those functions are needed to notify the upcoming L2 table and SR-IOV E-Switch(FDB) manager(PF), of the NIC vport (vf) vlan table changes. preperation for ethernet sriov and l2 table management. Signed-off-by: Saeed Mahameed

[PATCH net-next 10/18] net/mlx5e: Write vlan list into vport context

2015-11-23 Thread Or Gerlitz
From: Saeed Mahameed Each Vport/vNIC must notify underlying e-Switch layer for vlan table changes in-order to update SR-IOV FDB tables. We do that at vlan_rx_add_vid and vlan_rx_kill_vid ndos. Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz

Re: network card doesn't recovered itself after a SYN flooding attack

2015-11-23 Thread Daniel Borkmann
[ cc'ing netdev and r8169 folks ] On 11/22/2015 11:51 AM, Toralf Förster wrote: At 22th of November at 21:26 UTC my server (64 bit stable Gentoo hardened) suffered from a DDoS attack. From the kern.log: Nov 20 22:26:29 tor-relay kernel: [2431358.124515] TCP: request_sock_TCP:

Re: [PATCH 13/14] mm: memcontrol: account socket memory in unified hierarchy memory controller

2015-11-23 Thread Vladimir Davydov
On Fri, Nov 20, 2015 at 02:25:06PM -0500, Johannes Weiner wrote: > On Fri, Nov 20, 2015 at 04:10:33PM +0300, Vladimir Davydov wrote: > > On Thu, Nov 12, 2015 at 06:41:32PM -0500, Johannes Weiner wrote: > > ... > > > @@ -5514,16 +5550,43 @@ void sock_release_memcg(struct sock *sk) > > > */ > > >

Re: [PATCH net-next 3/6] net: Add MSG_BATCH flag

2015-11-23 Thread Hannes Frederic Sowa
Hello, On Fri, Nov 20, 2015, at 22:21, Tom Herbert wrote: > Add a new msg flag called MSG_BATCH. This flag is used in sendmsg to > indicate that more messages will follow (i.e. a batch of messages is > being sent). This is similar to MSG_MORE except that the following > messages are not merged

Re: yet another uninterruptable hang in sendfile

2015-11-23 Thread Jan Kara
Hello, On Sat 21-11-15 14:24:45, Dmitry Vyukov wrote: > On commit 8005c49d9aea74d382f474ce11afbbc7d7130bec (Nov 15). > > The program is: > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include > #include > > int main() > { > long r0 =

[PATCH] libertas: fix possible NULL dereference

2015-11-23 Thread Sudip Mukherjee
We were dereferencing cmd first and checking for NULL later. Lets first check for NULL. Signed-off-by: Sudip Mukherjee --- drivers/net/wireless/marvell/libertas/cfg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

2015-11-23 Thread Daniel Wagner
Hi Tejun, On 11/21/2015 05:14 PM, Tejun Heo wrote:> +static int > cgroup_mt_check_v1(const struct xt_mtchk_param *par) > +{ > + struct xt_cgroup_info_v1 *info = par->matchinfo; > + struct cgroup *cgrp; > + > + if ((info->invert_path & ~1) || (info->invert_classid & ~1)) > +

Re: [PATCH net-next 0/6] kcm: Kernel Connection Multiplexor (KCM)

2015-11-23 Thread Sowmini Varadhan
On (11/23/15 10:53), Hannes Frederic Sowa wrote: > > > > - Integration with TLS (TLS-in-kernel is a separate initiative). > > This is interesting: > > Regarding the last week's discussion about better OOB support in TCP > e.g. for SOCKET_DESTROY, do you already have a plan to handle TLS alerts

Re: [PATCH 8/9] netfilter: prepare xt_cgroup for multi revisions

2015-11-23 Thread Daniel Wagner
Hi Tejun, On 11/21/2015 05:14 PM, Tejun Heo wrote: > xt_cgroup will grow cgroup2 path based match. Postfix existing > symbols with _v0 and prepare for multi revision registration. > > Signed-off-by: Tejun Heo > Cc: Daniel Borkmann > Cc: Daniel Wagner

Re: Asterisk deadlocks since Kernel 4.1

2015-11-23 Thread Stefan Priebe - Profihost AG
Am 19.11.2015 um 20:51 schrieb Stefan Priebe: > > Am 19.11.2015 um 14:19 schrieb Florian Weimer: >> On 11/19/2015 01:46 PM, Stefan Priebe - Profihost AG wrote: >> >>> I can try Kernel 4.4-rc1 next week. Or something else? >> >> I found this bug report which indicates that 4.1.10 works: >> >>

Re: Asterisk deadlocks since Kernel 4.1

2015-11-23 Thread Hannes Frederic Sowa
On Mon, Nov 23, 2015, at 13:44, Stefan Priebe - Profihost AG wrote: > Am 19.11.2015 um 20:51 schrieb Stefan Priebe: > > > > Am 19.11.2015 um 14:19 schrieb Florian Weimer: > >> On 11/19/2015 01:46 PM, Stefan Priebe - Profihost AG wrote: > >> > >>> I can try Kernel 4.4-rc1 next week. Or something

Re: [PATCH V3 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS

2015-11-23 Thread Salil Mehta
On 20/11/15 14:07, Sergei Shtylyov wrote: On 11/19/2015 11:58 PM, Salil Mehta wrote: From: Salil This patch adds the support of ethtool TSO option to V1 patch, meant to add support of Hip06 SoC to HNS Signed-off-by: Salil Mehta

Re: Use-after-free in ppoll

2015-11-23 Thread Dmitry Vyukov
On Sun, Nov 22, 2015 at 7:46 PM, Rainer Weikusat wrote: > Dmitry Vyukov writes: >> On Sun, Nov 22, 2015 at 3:32 PM, Rainer Weikusat >> wrote: >>> Dmitry Vyukov writes: Hello,

Re: [PATCH 7/9] sock, cgroup: add sock->sk_cgroup

2015-11-23 Thread Daniel Wagner
Hi Tejun, On 11/21/2015 05:13 PM, Tejun Heo wrote: > Signed-off-by: Tejun Heo > Cc: Daniel Borkmann > Cc: Daniel Wagner I did a quick test and for new connection the cgroup2 match worked as expected. For an existing connection

Re: Deadlock between bind and splice

2015-11-23 Thread Dmitry Vyukov
On Tue, Nov 10, 2015 at 3:59 AM, Al Viro wrote: > On Tue, Nov 10, 2015 at 02:38:54AM +, Al Viro wrote: >> On Fri, Nov 06, 2015 at 07:42:15AM -0800, Eric Dumazet wrote: >> >> > Thank you for this report. >> > >> > pipe is part of fs, not net ;) >> >> AF_UNIX bind() vs.

pull-request: can 2015-11-23

2015-11-23 Thread Marc Kleine-Budde
repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-4.4-20151123 for you to fetch changes up to a2ec19f888f1fb06e2424486423a16f86ad1fcc4: can: remove obsolete assignment for CAN protocol error type (2015-11-23 09:37:38 +0100

[PATCH 3/3] can: remove obsolete assignment for CAN protocol error type

2015-11-23 Thread Marc Kleine-Budde
From: Oliver Hartkopp The assignment 'cf->data[2] |= CAN_ERR_PROT_UNSPEC' used at CAN error message creation time is obsolete as CAN_ERR_PROT_UNSPEC is zero and cf->data[2] is initialized with zero in alloc_can_err_skb() anyway. So we could either assign 'cf->data[2] =

[PATCH 1/3] can: sja1000: clear interrupts on start

2015-11-23 Thread Marc Kleine-Budde
From: Mirza Krak According to SJA1000 data sheet error-warning (EI) interrupt is not cleared by setting the controller in to reset-mode. Then if we have the following case: - system is suspended (echo mem > /sys/power/state) and SJA1000 is left in operating state

[PATCH 2/3] can: fix assignment of error location in CAN error messages

2015-11-23 Thread Marc Kleine-Budde
From: Oliver Hartkopp As Dan Carpenter reported in http://marc.info/?l=linux-can=144793696016187 the assignment of the error location in CAN error messages had some bit wise overlaps. Indeed the value to be assigned in data[3] is no bitfield but defines a single value

Re: [PATCH net-next 0/6] kcm: Kernel Connection Multiplexor (KCM)

2015-11-23 Thread Hannes Frederic Sowa
Hello, On Fri, Nov 20, 2015, at 22:21, Tom Herbert wrote: > Kernel Connection Multiplexor (KCM) is a facility that provides a > message based interface over TCP for generic application protocols. > The motivation for this is based on the observation that although > TCP is byte stream transport

Re: [PATCH v2 06/27] brcm80211: move under broadcom vendor directory

2015-11-23 Thread Arend van Spriel
On 11/22/2015 06:23 PM, Kalle Valo wrote: Arend van Spriel writes: On 11/19/2015 08:48 AM, Kalle Valo wrote: Hauke Mehrtens writes: On 11/18/2015 03:45 PM, Kalle Valo wrote: Part of reorganising wireless drivers directory and Kconfig. Note that I had

Re: Deadlock between bind and splice

2015-11-23 Thread Hannes Frederic Sowa
On Mon, Nov 23, 2015, at 09:32, Dmitry Vyukov wrote: > On Tue, Nov 10, 2015 at 3:59 AM, Al Viro wrote: > > On Tue, Nov 10, 2015 at 02:38:54AM +, Al Viro wrote: > >> On Fri, Nov 06, 2015 at 07:42:15AM -0800, Eric Dumazet wrote: > >> > >> > Thank you for this report. >

Re: [PATCH 09/14] net: tcp_memcontrol: simplify linkage between socket and page counter

2015-11-23 Thread Vladimir Davydov
On Fri, Nov 20, 2015 at 01:56:48PM -0500, Johannes Weiner wrote: > On Fri, Nov 20, 2015 at 03:42:16PM +0300, Vladimir Davydov wrote: > > On Thu, Nov 12, 2015 at 06:41:28PM -0500, Johannes Weiner wrote: > > > There won't be any separate counters for socket memory consumed by > > > protocols other

Re: [PATCH] netfilter: avoid harmless unnitialized variable warnings

2015-11-23 Thread Pablo Neira Ayuso
On Thu, Nov 19, 2015 at 01:49:59PM +0100, Arnd Bergmann wrote: > Several ARM default configurations give us warnings on recent > compilers about potentially uninitialized variables in the > nfnetlink code in two functions: > > net/netfilter/nfnetlink_queue.c: In function

[PATCH] drivers: net: xgene: optimizing the code

2015-11-23 Thread Saurabh Sengar
this patch does the following: 1 . remove unnecessary if, else condition 2 . reduce one variable 3 . change the return type of 2 functions to void as there return values turn out to be 0 always after above changes Signed-off-by: Saurabh Sengar ---

Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

2015-11-23 Thread Daniel Borkmann
On 11/23/2015 02:43 PM, Daniel Borkmann wrote: On 11/21/2015 07:54 PM, Florian Westphal wrote: Tejun Heo wrote: On Sat, Nov 21, 2015 at 05:56:06PM +0100, Florian Westphal wrote: +struct xt_cgroup_info_v1 { +__u8has_path; +__u8has_classid; +__u8

pull request: bluetooth-next 2015-11-23

2015-11-23 Thread Johan Hedberg
Hi Dave, Here's the first bluetooth-next pull request for the 4.5 kernel. - Add new Get Advertising Size Information management command - Add support for new system note message type on monitor channel - Refactor LE scan changes behind separate workqueue to avoid races - Fix issue with

[PATCH] net: cdc_ncm: fix NULL pointer deref in cdc_ncm_bind_common

2015-11-23 Thread Bjørn Mork
Commit 77b0a099674a ("cdc-ncm: use common parser") added a dangerous new trust in the CDC functional descriptors presented by the device, unconditionally assuming that any device handled by the driver has a CDC Union descriptor. This descriptor is required by the NCM and MBIM specs, but crashing

Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

2015-11-23 Thread Daniel Borkmann
On 11/21/2015 07:54 PM, Florian Westphal wrote: Tejun Heo wrote: On Sat, Nov 21, 2015 at 05:56:06PM +0100, Florian Westphal wrote: +struct xt_cgroup_info_v1 { + __u8has_path; + __u8has_classid; + __u8invert_path; +

[PATCH] net: fec: no need to test for the return type of of_property_read_u32

2015-11-23 Thread Saurabh Sengar
in case of error no need to set num_tx and num_rx = 1, because in case of error these variables will remain unchanged by of_property_read_u32 ie 1 only Signed-off-by: Saurabh Sengar --- drivers/net/ethernet/freescale/fec_main.c | 9 ++--- 1 file changed, 2

Re: severe regression in alx ethernet driver

2015-11-23 Thread Ldap Tester
The severe regression in alx ethernet driver is still present in the latest released kernel. Patches have been posted in https://bugzilla.kernel.org/show_bug.cgi?id=70761 There are reports that these patches have resolved the problem. Could you please review these patches and see if they can be

Re: [PATCH net-next v4] mpls: support for dead routes

2015-11-23 Thread Robert Shearman
On 21/11/15 05:16, Roopa Prabhu wrote: From: Roopa Prabhu Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection. Unlike ip routes, mpls routes are not deleted when the

Re: [PATCH net] vrf: fix double free and memory corruption on register_netdevice failure

2015-11-23 Thread David Miller
From: Nikolay Aleksandrov Date: Sat, 21 Nov 2015 19:46:19 +0100 > From: Nikolay Aleksandrov > > When vrf's ->newlink is called, if register_netdevice() fails then it > does free_netdev(), but that's also done by rtnl_newlink() so a second >

Re: [PATCH iproute2] Add support for rt_tables.d

2015-11-23 Thread Stephen Hemminger
On Wed, 18 Nov 2015 11:03:20 -0800 David Ahern wrote: > Add support for reading table id/name mappings from rt_tables.d > directory. > > Signed-off-by: David Ahern > --- > lib/rt_names.c | 18 ++ > 1 file changed, 18

[PATCH net-next 05/10] hv_netvsc: Eliminatte the data field from struct hv_netvsc_packet

2015-11-23 Thread K. Y. Srinivasan
Eliminatte the data field from struct hv_netvsc_packet. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h |5 ++--- drivers/net/hyperv/netvsc.c |5 +++-- drivers/net/hyperv/netvsc_drv.c |

[PATCH net-next 03/10] hv_netvsc: Eliminate the channel field in hv_netvsc_packet structure

2015-11-23 Thread K. Y. Srinivasan
Eliminate the channel field in hv_netvsc_packet structure. Signed-off-by: K. Y. Srinivasan Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 22 ++ drivers/net/hyperv/netvsc.c | 19 ---

  1   2   >