RE: [PATCH v2 net-next 1/5] net: local checksum offload for encapsulation

2016-01-07 Thread David Laight
From: Edward Cree > Sent: 07 January 2016 17:12 > The arithmetic properties of the ones-complement checksum mean that a > correctly checksummed inner packet, including its checksum, has a ones > complement sum depending only on whatever value was used to initialise > the checksum field before ch

[PATCH v2 net-next 5/5] Documentation/networking: add tx-offloads.txt to explain LCO

2016-01-07 Thread Edward Cree
It would also be a good place to explain GSO if someone wants to do that... Signed-off-by: Edward Cree --- Documentation/networking/00-INDEX| 2 + Documentation/networking/tx-offloads.txt | 122 +++ 2 files changed, 124 insertions(+) create mode 100644 Docu

[PATCH v2 net-next 2/5] net: enable LCO for udp_tunnel_handle_offloads() users

2016-01-07 Thread Edward Cree
The only protocol affected at present is Geneve. Signed-off-by: Edward Cree --- include/net/udp_tunnel.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/net/udp_tunnel.h b/include/net/udp_tunnel.h index cb2f89f..210eb90 100644 --- a/include/net/udp_tunnel.h +++ b/in

[PATCH v2 net-next 1/5] net: local checksum offload for encapsulation

2016-01-07 Thread Edward Cree
The arithmetic properties of the ones-complement checksum mean that a correctly checksummed inner packet, including its checksum, has a ones complement sum depending only on whatever value was used to initialise the checksum field before checksumming (in the case of TCP and UDP, this is the one

[PATCH v2 net-next 0/5] Local Checksum Offload

2016-01-07 Thread Edward Cree
Tested with a VXLAN tunnel over a device that doesn't support inner checksum offload (so the checksum will have been done in sw by validate_xmit_skb()). Changes from v1: * Enabled support in more encapsulation protocols. I think it now covers everything except GRE. * Wrote up some documentat

Re: [PATCH net-next] net, sched: add clsact qdisc

2016-01-07 Thread Daniel Borkmann
On 01/07/2016 05:29 PM, Eric Dumazet wrote: On Wed, 2016-01-06 at 02:00 +0100, Daniel Borkmann wrote: This work adds a generalization of the ingress qdisc as a qdisc holding only classifiers. The clsact qdisc works on ingress, but also on egress. In both cases, it's execution happens without tak

Re: suspicious rcu_dereference in tcp_v6_send_synack

2016-01-07 Thread Paul E. McKenney
On Thu, Jan 07, 2016 at 07:52:53AM -0800, Eric Dumazet wrote: > On Thu, 2016-01-07 at 10:32 -0500, Dave Jones wrote: > > === > > [ INFO: suspicious RCU usage. ] > > 4.4.0-rc8-firewall+ #1 Not tainted > > --- > > net/ipv6/tcp_ipv6.c:465 suspici

Re: [PATCH iproute2] tc: fix compilation with old gcc (< 4.6)

2016-01-07 Thread Nicolas Dichtel
Le 07/01/2016 14:56, Daniel Borkmann a écrit : Btw, for iproute2's net-next branch there're couple of other occasions as well. Stephen, how do you prefer to handle this? Should a separate patch be done against net-next branch to reduce merge conflicts? Thank you Daniel for noticing it. -- To uns

Question regarding {G,S}CHANNELS API

2016-01-07 Thread Jakub Kicinski
Hi! I'm trying to understand how number of "separate" rx/tx vs combined channels should be configured. I'd like to express asymmetric but mostly combined queue configuration (i.e. min(rx, tx) is combined the rest is separate). Since default number of RX queues is just 8 it is tempting to allocat

[PATCH] net: qmi_wwan: Add SIMCom 7230E

2016-01-07 Thread Kristian Evensen
From: Kristian Evensen SIMCom 7230E is a QMI LTE module with support for most "normal" bands. Manual testing has showed that only interface five works. Cc: Bjørn Mork Signed-off-by: Kristian Evensen --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net

suspicious rcu_dereference in tcp_v6_send_synack

2016-01-07 Thread Dave Jones
=== [ INFO: suspicious RCU usage. ] 4.4.0-rc8-firewall+ #1 Not tainted --- net/ipv6/tcp_ipv6.c:465 suspicious rcu_dereference_check() usage! other info that might help us debug this: rcu_scheduler_active = 1, debug_locks = 1 1 lock held by

Re: [BUG 4.4-rc4]: oops around sock_recvmsg

2016-01-07 Thread Holger Schurig
Hi, Russell, as asked I've sent the kernel via private mail to you. For the mailing list: As I "lost" the vmlinux (I continued working on the kernel) and scripts/extract-vmlinux didn't liked the vmlinux file, I reverted my changes and recompiled the kernel. The resulting System.map is identical

[PATCH 1/3] ipv4: Namespaceify tcp_keepalive_time sysctl knob

2016-01-07 Thread Nikolay Borisov
Different net namespaces might have different requirements as to the keepalive time of tcp sockets. This might be required in cases where different firewall rules are in place which require tcp timeout sockets to be increased/decreased independently of the host. Signed-off-by: Nikolay Borisov ---

Re: [PATCH iproute2] tc: fix compilation with old gcc (< 4.6)

2016-01-07 Thread Daniel Borkmann
On 01/07/2016 02:03 PM, Nicolas Dichtel wrote: From: Julien Floret gcc < 4.6 does not handle C11 syntax for the static initialization of anonymous struct/union, hence the following error: tc_bpf.c:260: error: unknown field map_type specified in initializer Signed-off-by: Julien Floret Signed

[PATCH] wlcore: fix error handling in wlcore_event_fw_logger

2016-01-07 Thread Andrzej Hajda
wlcore_read/wlcore_write can return negative values so it should be assigned to signed variable. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2120705 Fixes: 3719c17e181

[PATCH iproute2] tc: fix compilation with old gcc (< 4.6)

2016-01-07 Thread Nicolas Dichtel
From: Julien Floret gcc < 4.6 does not handle C11 syntax for the static initialization of anonymous struct/union, hence the following error: tc_bpf.c:260: error: unknown field map_type specified in initializer Signed-off-by: Julien Floret Signed-off-by: Nicolas Dichtel --- tc/tc_bpf.c | 48 +

Re: [BUG] skb corruption and kernel panic at forwarding with fragmentation

2016-01-07 Thread Eric Dumazet
On Thu, Jan 7, 2016 at 7:04 AM, Konstantin Khlebnikov wrote: > On Thu, Jan 7, 2016 at 2:59 PM, Eric Dumazet wrote: >> On Thu, Jan 7, 2016 at 6:38 AM, Konstantin Khlebnikov >> wrote: >>> >>> Also I've found strange thing: reason of expanding skb->cb from 40 to >>> 48 bypes in 2006 >>> 3e3850e989

[PATCH] iwl4965: Fix a memory leak in error handling code of __il4965_up

2016-01-07 Thread Jia-Ju Bai
When il4965_hw_nic_init in __il4965_up fails, the memory allocated by iwl4965_sta_alloc_lq in iwl4965_alloc_bcast_station is not freed. This patches adds il_dealloc_bcast_stations in the error handling code of __il4965_up to fix this problem. This patch has been tested in real device, and it ac

Dear: Account User,

2016-01-07 Thread ADMINISTRATOR
Dear: Account User, This message is from the System Administrator support center. Be informed that your E-mail account has exceeded the storage limit set by your administrator/database, you are currently running out of context and you may not be able to send or receive some new mail until you re-v

Re: [BUG] skb corruption and kernel panic at forwarding with fragmentation

2016-01-07 Thread Eric Dumazet
On Thu, Jan 7, 2016 at 6:38 AM, Konstantin Khlebnikov wrote: > > Also I've found strange thing: reason of expanding skb->cb from 40 to > 48 bypes in 2006 > 3e3850e989c5d2eb1aab6f0fd9257759f0f4cbc6 was that struct inet6_skb_parm does > not fit. But it's is only 24 bytes. Does some arches add pad af

Re: [PATCH net-next] net, sched: add clsact qdisc

2016-01-07 Thread Daniel Borkmann
On 01/07/2016 11:09 AM, Hannes Frederic Sowa wrote: Hi Daniel and Alexei, On 07.01.2016 04:53, Alexei Starovoitov wrote: On Wed, Jan 06, 2016 at 02:00:56AM +0100, Daniel Borkmann wrote: I decided to extend the sch_ingress module with clsact functionality so that commonly used code can be reus

Re: [BUG] skb corruption and kernel panic at forwarding with fragmentation

2016-01-07 Thread Konstantin Khlebnikov
On Thu, Jan 7, 2016 at 2:00 PM, Konstantin Khlebnikov wrote: > On Thu, Jan 7, 2016 at 2:49 AM, Florian Westphal wrote: >> Florian Westphal wrote: >>> Thadeu Lima de Souza Cascardo wrote: >>> > On Wed, Jan 06, 2016 at 11:11:41PM +0300, Konstantin Khlebnikov wrote: >> >> [ skb_gso_segment uses sk

Re: [PATCH net 2/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread Thomas Graf
On 01/06/16 at 01:33pm, David Wragg wrote: > Prior to 4.3, vxlan vports could transmit vxlan packets of any size, > constrained only by the ability to transmit the resulting UDP packets. > 4.3 introduced vxlan netdevs corresponding to vxlan vports. These > netdevs have an MTU, which limits the siz

Re: [PATCH net 1/2] vxlan: Relax the MTU constraint on vxlan devices

2016-01-07 Thread Thomas Graf
On 01/06/16 at 01:33pm, David Wragg wrote: > Allow the MTU of vxlan devices without an underlying device to be set to > larger values (up to a maximum based on IP packet limits and vxlan > overhead). > > Previously, their MTUs could not be set to higher than the conventional > ethernet value of 15

RE: [PATCH] arm64: net: bpf: don't BUG() on large shifts

2016-01-07 Thread David Laight
From: Alexei Starovoitov > Sent: 06 January 2016 22:13 > On Wed, Jan 06, 2016 at 09:31:27PM +0100, Rabin Vincent wrote: > > On Tue, Jan 05, 2016 at 09:55:58AM -0800, Alexei Starovoitov wrote: > > > this one is better to be addressed in verifier instead of eBPF JITs. > > > Please reject it in check_

[patch net-next v2 2/2] mlxsw: spectrum: remove FDB entry in case we get unknown object notification

2016-01-07 Thread Jiri Pirko
From: Jiri Pirko It may happen that we get notification for FDB entry for object (port, lag, vport), which does not exist. Currently we ignore that, which only causes this being re-sent in next notification. The entry will never disappear. So get rid of it by simply removing it using SFD register

[patch net-next v2 1/2] mlxsw: spectrum: pass local_port to mlxsw_sp_port_fdb_uc_op

2016-01-07 Thread Jiri Pirko
From: Jiri Pirko Do not pass struct mlxsw_sp_port to mlxsw_sp_port_fdb_uc_op and rather just pass local_port. This is needed in case this is called from SFN process function and mlxsw_sp_port is not existent for particular local_port. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- v1-

Re: [PATCH net-next v1 1/2] tipc: move netlink policies to netlink.h

2016-01-07 Thread Richard Alpe
On 2016-01-05 22:47, David Miller wrote: > From: Richard Alpe > Date: Tue, 5 Jan 2016 10:56:16 +0100 > >> Make the c files less cluttered and enable netlink attributes to be >> shared between files. This will prove useful in a future patch where a >> node message will contain a nested network. >>

[PATCH] net: plip: use new parport device model

2016-01-07 Thread Sudip Mukherjee
Modify plip driver to use the new parallel port device model. Signed-off-by: Sudip Mukherjee --- drivers/net/plip/plip.c | 36 1 file changed, 28 insertions(+), 8 deletions(-) diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c index 040b897..9c4b

Re: [PATCH net-next] net, sched: add clsact qdisc

2016-01-07 Thread Hannes Frederic Sowa
Hi Daniel and Alexei, On 07.01.2016 04:53, Alexei Starovoitov wrote: On Wed, Jan 06, 2016 at 02:00:56AM +0100, Daniel Borkmann wrote: I decided to extend the sch_ingress module with clsact functionality so that commonly used code can be reused, the module is being aliased with sch_clsact so th

[PATCH net-next 2/2] r8152: adjust ALDPS function

2016-01-07 Thread Hayes Wang
Replace disable_aldps() and enable_aldps() with aldps_en(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 72 +++-- 1 file changed, 34 insertions(+), 38 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 4f0bb6

[PATCH net-next 0/2] r8152: code adjustment

2016-01-07 Thread Hayes Wang
Adjust test_bit(), clear_bit(), disable_aldps(), and enable_aldps(). Hayes Wang (2): r8152: use test_and_clear_bit r8152: adjust ALDPS function drivers/net/usb/r8152.c | 92 + 1 file changed, 40 insertions(+), 52 deletions(-) -- 2.4.3 -- To

[PATCH net-next 1/2] r8152: use test_and_clear_bit

2016-01-07 Thread Hayes Wang
Replace test_bit() followed by clear_bit() with test_and_clear_bit(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 975e917..4f0bb67 100644 --

Re: [BUG 4.4-rc4]: oops around sock_recvmsg

2016-01-07 Thread Russell King - ARM Linux
On Thu, Jan 07, 2016 at 09:58:14AM +0100, Holger Schurig wrote: > This oops with sock_recvmsg() inside it now happened 3 times, just not > at my test box, only at one very remote from me. That's also the reason > why the log is truncated, the people that grabbed it from Windows with > Putty over th

[patch net-next 1/2] mlxsw: spectrum: pass local_port to mlxsw_sp_port_fdb_uc_op

2016-01-07 Thread Jiri Pirko
From: Jiri Pirko Do not pass struct mlxsw_sp_port to mlxsw_sp_port_fdb_uc_op and rather just pass local_port. This is needed in case this is called from SFN process function and mlxsw_sp_port is not existent for particular local_port. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- dr

[patch net-next 2/2] mlxsw: spectrum: remove FDB entry in case we get unknown object notification

2016-01-07 Thread Jiri Pirko
From: Jiri Pirko It may happen that we get notification for FDB entry for object (port, lag, vport), which does not exist. Currently we ignore that, which only causes this being re-sent in next notification. The entry will never disappear. So get rid of it by simply removing it using SFD register

[PATCH net] r8152: fix the wake event

2016-01-07 Thread Hayes Wang
When the autosuspend is enabled and occurs before system suspend, we should wake the device before running system syspend. Then, we could change the wake event for system suspend. Otherwise, the device would resume the system when receiving any packet. Signed-off-by: Hayes Wang --- drivers/net/u

Re: [v2] mwifiex: correctly handling kzalloc

2016-01-07 Thread Kalle Valo
> Since kzalloc can be failed in memory pressure, > it needs to be handled, otherwise NULL dereference could be happened > > Signed-off-by: Insu Yun Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: iwlegacy: 4965-mac: constify il_sensitivity_ranges structure

2016-01-07 Thread Kalle Valo
> The il_sensitivity_ranges is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > Acked-by: Stanislaw Gruszka Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe net

Re: [PATCH net-next] bpf: add skb_postpush_rcsum and fix dev_forward_skb occasions

2016-01-07 Thread Daniel Borkmann
On 01/07/2016 04:22 AM, kbuild test robot wrote: Hi Daniel, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Daniel-Borkmann/bpf-add-skb_postpush_rcsum-and-fix-dev_forward_skb-occasions/20160107-090423 config: x86_64-lkp (attached as .config

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2016-01-07 Thread zhuyj
On 01/07/2016 03:59 PM, Michal Kubecek wrote: On Thu, Jan 07, 2016 at 03:37:26PM +0800, zhuyj wrote: If I read this right, whenever this state (link up but speed/duplex unknown) is entered, you'll keep writing this message into kernel log every miimon milliseconds until something changes. I'm no

[PATCH v3 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2016-01-07 Thread Henri Roosen
Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC node.") only fixes finding PHY properties in MAC node for KSZ9021. This commit applies the same fix for KSZ9031. Fixes: 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not the bus' parent.") Acked-by: Andrew Lunn

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

2016-01-07 Thread Michal Kubecek
On Thu, Jan 07, 2016 at 03:37:26PM +0800, zhuyj wrote: > >If I read this right, whenever this state (link up but speed/duplex > >unknown) is entered, you'll keep writing this message into kernel log > >every miimon milliseconds until something changes. I'm not sure how long > >a NIC can stay in suc