Re: [PATCH] net: cavium: liquidio: use helpers ns_to_timespec64()

2016-01-27 Thread David Miller
From: Kefeng Wang Date: Wed, 27 Jan 2016 17:34:37 +0800 > Convert the driver to use ns_to_timespec64() to keep consistency > with timespec64_to_ns() instead of open coding the same logic. > > Signed-off-by: Kefeng Wang Applied, thank

[PATCH 3/3] lan78xx: throttle TX path at slower than SuperSpeed USB

2016-01-27 Thread Woojung.Huh
Throttle TX path only at slower than SuperSpeed USB. SuperSpeed USB has enough bandwidth to maintain GigE. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/lan78xx.c

[PATCH 1/3] lan78xx: change to use updated phy-ignore-interrupts

2016-01-27 Thread Woojung.Huh
Update lan78xx to use patch of commit 4f2aaf7dd95b ("Merge branch 'fix-phy-ignore-interrupts'"). Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git

[PATCH 2/3] lan78xx: Add to handle mux control per chip id

2016-01-27 Thread Woojung.Huh
Depends on chip, some EEPROM pins are muxed with LED function. Disable & restore LED function to access EEPROM. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 98 ++- 1 file changed, 71 insertions(+), 27

[PATCH 0/3] lan78xx: update and fixes

2016-01-27 Thread Woojung.Huh
Woojung Huh (3): lan78xx: change to use updated phy-ignore-interrupts lan78xx: Add to handle mux control per chip id lan78xx: throttle TX path at slower than SuperSpeed USB drivers/net/usb/lan78xx.c | 132 ++ 1 file changed, 88 insertions(+), 44

Re: [PULL] virtio: fixes, tests

2016-01-27 Thread Linus Torvalds
On Wed, Jan 27, 2016 at 2:15 PM, Michael S. Tsirkin wrote: >> >> Anyway, pulled. Just curious about how that thing happened. > > That's because apparently diffstat obeys orderfile rules: Ugh. I guess that makes sense, but it's still very annoying for something like a pull

Re: [PATCH net v2] tipc: fix connection abort during subscription cancel

2016-01-27 Thread David Miller
From: Parthasarathy Bhuvaragan Date: Wed, 27 Jan 2016 11:35:59 +0100 > In 'commit 7fe8097cef5f ("tipc: fix nullpointer bug when subscribing > to events")', we terminate the connection if the subscription > creation fails. > In the same commit, the

[PATCH] lib: fix callers of strtobool to use char array

2016-01-27 Thread Kees Cook
Some callers of strtobool were passing a pointer to unterminated strings. This fixes the issue and consolidates some logic in cifs. Signed-off-by: Kees Cook Cc: Amitkumar Karwar Cc: Nishant Sarmukadam Cc: Kalle Valo

Re: [PATCH 1/2] netfilter: ipvs: avoid unused variable warnings

2016-01-27 Thread Simon Horman
On Wed, Jan 27, 2016 at 10:01:42PM +0200, Julian Anastasov wrote: > > Hello, > > On Wed, 27 Jan 2016, Arnd Bergmann wrote: > > > The proc_create() and remove_proc_entry() functions do not reference > > their arguments when CONFIG_PROC_FS is disabled, so we get a couple > > of warnings

Re: [PATCH 2/2] netfilter: ipvs/SIP: handle ip_vs_fill_iph_skb_off failure

2016-01-27 Thread Simon Horman
On Wed, Jan 27, 2016 at 10:56:08PM +0200, Julian Anastasov wrote: > > Hello, > > On Wed, 27 Jan 2016, Arnd Bergmann wrote: > > > ip_vs_fill_iph_skb_off() may not find an IP header, and gcc has > > determined that ip_vs_sip_fill_param() then incorrectly accesses > > the protocol fields: >

[PATCHv2 net 0/2] Part 2 of v4.5-rc1 phylib regression

2016-01-27 Thread Andrew Lunn
White list PHY compatible values which indicate PHYs. Issue a warning when one is encountered. Update the documentation to make it clear what is expected in the compatible string. v2: Fix Grammar, reword changelog, add Tested-by and Acked-by. Andrew Lunn (2): of: of_mdio: Add a whitelist of

[PATCHv2 net 1/2] of: of_mdio: Add a whitelist of PHY compatibilities.

2016-01-27 Thread Andrew Lunn
Some phy nodes list a compatible value indicating the PHY make/model. This is never used to match the device to the driver. However it does confuse the code to separate a PHY from a generic MDIO device like a switch. Generic MDIO devices must have a compatible value, PHYs can list clause 22 or 45,

[PATCHv2 net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-27 Thread Andrew Lunn
PHY devices may only list compatibility with clause 22, 45, and if they need to be more specific, their PHY identifier values. No other compatible strings are allowed. Make this clear in the documentation, and remove examples where make/model compatible strings are listed. Signed-off-by: Andrew

i40e: Kernel unaligned access due to 'struct i40e_dma_mem' being 'packed'

2016-01-27 Thread tndave
Hi, i40e driver has 'struct i40e_dma_mem' defined with 'packed' directive causing kernel unaligned errors on sparc (when 40e_allocate_dma_mem_d() is being called) log_unaligned: 1031 callbacks suppressed Kernel unaligned access at TPC[448ae8] dma_4v_alloc_coherent+0x188/0x2e0 Kernel unaligned

Re: [PULL] virtio: fixes, tests

2016-01-27 Thread Michael S. Tsirkin
On Wed, Jan 27, 2016 at 11:57:52AM -0800, Linus Torvalds wrote: > On Wed, Jan 27, 2016 at 11:12 AM, Michael S. Tsirkin wrote: > > > > arch/sh/include/asm/barrier.h| 1 - > > tools/virtio/asm/barrier.h | 22 +- > > tools/virtio/linux/compiler.h

Re: Bypass at packet-page level (Was: Optimizing instruction-cache, more packets at each stage)

2016-01-27 Thread Alexei Starovoitov
On Wed, Jan 27, 2016 at 09:47:50PM +0100, Jesper Dangaard Brouer wrote: > Sum: 18.75 % => calc: 30.0 ns (sum: 30.0 ns) => Total: 159.9 ns > > To get around the cache-miss in eth_type_trans(), I created a > "icache-loop" in mlx5e_poll_rx_cq() and pull all RX-ring packets "out", > before calling

Re: [PATCH] lib: fix callers of strtobool to use char array

2016-01-27 Thread Kees Cook
On Wed, Jan 27, 2016 at 4:58 PM, Joe Perches wrote: > On Wed, 2016-01-27 at 16:45 -0800, Kees Cook wrote: >> Some callers of strtobool were passing a pointer to unterminated strings. >> This fixes the issue and consolidates some logic in cifs. > > This may be incomplete as it

Re: Bypass at packet-page level (Was: Optimizing instruction-cache, more packets at each stage)

2016-01-27 Thread Tom Herbert
On Wed, Jan 27, 2016 at 12:47 PM, Jesper Dangaard Brouer wrote: > On Mon, 25 Jan 2016 23:10:16 +0100 > Jesper Dangaard Brouer wrote: > >> On Mon, 25 Jan 2016 09:50:16 -0800 John Fastabend >> wrote: >> >> > On 16-01-25 09:09 AM,

[PATCH] net_sched: drr: check for NULL pointer in drr_dequeue

2016-01-27 Thread Bernie Harris
There are cases where qdisc_dequeue_peeked can return NULL, and the result is dereferenced later on in the function. Similarly to the other qdisc dequeue functions, check whether the skb pointer is NULL and if it is, goto out. Signed-off-by: Bernie Harris ---

Re: [PATCH net 0/4] net: add rx_unhandled stat counter

2016-01-27 Thread Jarod Wilson
On Wed, Jan 27, 2016 at 01:09:47PM -0800, Eric Dumazet wrote: > On Wed, 2016-01-27 at 15:21 -0500, Jarod Wilson wrote: > > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index 289c231..7973ab5 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netdevice.h

Re: [PULL] virtio: fixes, tests

2016-01-27 Thread Junio C Hamano
Linus Torvalds writes: > On Wed, Jan 27, 2016 at 2:15 PM, Michael S. Tsirkin wrote: >>> >>> Anyway, pulled. Just curious about how that thing happened. >> >> That's because apparently diffstat obeys orderfile rules: > > Ugh. I guess that makes

[PATCH] ptp: ixp46x: use helpers for converting ns to timespec

2016-01-27 Thread Kefeng Wang
Convert the driver to use ns_to_timespec64() and timespec64_to_ns() instead of open coding the same logic. Signed-off-by: Kefeng Wang --- drivers/ptp/ptp_ixp46x.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/ptp/ptp_ixp46x.c

WARNING at net/mac80211/rate.c:513 ieee80211_get_tx_rates [mac80211]

2016-01-27 Thread Linus Torvalds
Hmm. So my daughter has a little Gigabyte Brix that has rtl8821ae wireless in it. Yeah, nasty, I know, but it has actually worked reasonably well. .. except now I upgraded the nearest access point, and now wireless on that machine no longer works. Or rather, it actually *does* work in the sense

Re: [PATCH net 0/4] net: add rx_unhandled stat counter

2016-01-27 Thread Jarod Wilson
On Thu, Jan 28, 2016 at 01:02:15AM -0500, Jarod Wilson wrote: > On Wed, Jan 27, 2016 at 01:09:47PM -0800, Eric Dumazet wrote: > > On Wed, 2016-01-27 at 15:21 -0500, Jarod Wilson wrote: > > > > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > > index 289c231..7973ab5 100644

Re: [PATCH] net_sched: drr: check for NULL pointer in drr_dequeue

2016-01-27 Thread Bernie Harris
Thank you. I will add unlikely() and re-submit the patch. From: Cong Wang Sent: 27 January 2016 07:03 To: Bernie Harris Cc: Linux Kernel Network Developers; David Miller; Jamal Hadi Salim; sta...@vger.kernel.org Subject: Re:

NEW ARRIVALS, CISCO,CPU's,Memory, LAPTOP AND AVAYA

2016-01-27 Thread Laison Computech Inc
Dear Sir/Madam, Clean tested working pulls CPUs and QTYs in stock. 115 X X5650 65 X E5410 75 X X5660 145 X E5530 100 X E5645 40 X X5680 75 X X5690 Brand new sealed IP phones and QTYs in stock. 55 x CP-7937G 77 x CP-7942G 54 x CP-7945G 75 x CP-7962G .. 45 x Avaya 9630

Re: [PATCH net 0/4] net: add rx_unhandled stat counter

2016-01-27 Thread Jarod Wilson
On Thu, Jan 28, 2016 at 01:02:15AM -0500, Jarod Wilson wrote: > On Wed, Jan 27, 2016 at 01:09:47PM -0800, Eric Dumazet wrote: > > On Wed, 2016-01-27 at 15:21 -0500, Jarod Wilson wrote: > > > > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > > index 289c231..7973ab5 100644

Re: [PATCH] lib: fix callers of strtobool to use char array

2016-01-27 Thread Joe Perches
On Wed, 2016-01-27 at 16:45 -0800, Kees Cook wrote: > Some callers of strtobool were passing a pointer to unterminated strings. > This fixes the issue and consolidates some logic in cifs. This may be incomplete as it duplicates the behavior for the old number of characters, but this is not a

Re: [PATCH 4.1] [media] media/vivid-osd: fix info leak in ioctl

2016-01-27 Thread Yuki Machida
Hi Greg, On 2016年01月26日 02:18, Greg KH wrote: On Mon, Jan 25, 2016 at 07:42:18PM +0900, Yuki Machida wrote: commit eda98796aff0d9bf41094b06811f5def3b4c333c upstream. The vivid_fb_ioctl() code fails to initialize the 16 _reserved bytes of struct fb_vblank after the ->hcount member. Add an

Re: [PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-27 Thread Nicolas Ferre
Le 27/01/2016 16:51, Nicolas Ferre a écrit : > Le 27/01/2016 15:04, Arnd Bergmann a écrit : >> The macb_clk_init function returns three clock pointers, unless >> the it fails to get the first ones. We correctly handle the >> failure case by propagating the error from macb_probe, but >> gcc does

Re: switchdev automated testing

2016-01-27 Thread Andrew Lunn
On Wed, Jan 27, 2016 at 03:46:57PM +0100, Jiri Pirko wrote: > Hi All. > > Just want to send a small note here about what we use for mlxsw driver > automated testing. It can be handy for other people using switchdev > infra, namely DSA guys. Hi Jiri I have a few hacked together python scripts

Re: [PATCH 3/9] net: bgmac: clarify CONFIG_BCMA dependency

2016-01-27 Thread Paul Gortmaker
[[PATCH 3/9] net: bgmac: clarify CONFIG_BCMA dependency] On 27/01/2016 (Wed 15:04) Arnd Bergmann wrote: > The bgmac driver depends on BCMA_HOST_SOC, which is only used > when CONFIG_BCMA is enabled. However, it is a bool option and can > be set when CONFIG_BCMA=m, and then bgmac can be built-in,

Re: [PATCH 8/9] net: nb8800: avoid uninitialized variable warning

2016-01-27 Thread Arnd Bergmann
On Wednesday 27 January 2016 14:13:16 Måns Rullgård wrote: > Arnd Bergmann writes: > > > The nb8800_poll() function initializes the 'next' variable in the > > loop looking for new input data. We know this will be called at > > least once because 'budget' is a guaranteed to be a

Re: [PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-27 Thread Nicolas Ferre
Le 27/01/2016 15:04, Arnd Bergmann a écrit : > The macb_clk_init function returns three clock pointers, unless > the it fails to get the first ones. We correctly handle the > failure case by propagating the error from macb_probe, but > gcc does not realize this and incorrectly warns about a later

Re: [PATCH 1/1] netfilter: h323: avoid potential attack

2016-01-27 Thread Eric Dumazet
On Wed, 2016-01-27 at 22:40 +0800, Zhouyi Zhou wrote: > From: Zhouyi Zhou > > I think hackers chould build a malicious h323 packet to overflow > the pointer p which will panic during the memcpy(addr, p, len) > > For example, he may fabricate a very large

Re: switchdev automated testing

2016-01-27 Thread Jiri Pirko
Wed, Jan 27, 2016 at 04:51:14PM CET, and...@lunn.ch wrote: >On Wed, Jan 27, 2016 at 03:46:57PM +0100, Jiri Pirko wrote: >> Hi All. >> >> Just want to send a small note here about what we use for mlxsw driver >> automated testing. It can be handy for other people using switchdev >> infra, namely

Re: [ovs-dev] [PATCH net 1/2] vxlan: Relax the MTU constraint on vxlan devices

2016-01-27 Thread roopa
On 1/10/16, 2:28 AM, Thomas Graf wrote: > On 01/09/16 at 10:39am, roopa wrote: >> On 1/6/16, 5:33 AM, David Wragg wrote: >>> Allow the MTU of vxlan devices without an underlying device to be set to >>> larger values (up to a maximum based on IP packet limits and vxlan >>> overhead). >>> >>>

[PATCH net] macvlan: make operstate and carrier more accurate

2016-01-27 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Currently when a macvlan is being initialized and the lower device is netif_carrier_ok(), the macvlan device doesn't run through rfc2863_policy() and is left with UNKNOWN operstate. Fix it by adding an unconditional linkwatch event for the

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-27 Thread Florian Fainelli
On January 26, 2016 5:57:55 PM PST, Andrew Lunn wrote: >> Well, we do now, since that is one of the results used by >> of_mdiobus_child_is_phy(), > >It uses it, but do not rely on it, since for backwards compatibility, >we cannot assume it is there. > >You can never change an

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-27 Thread Olof Johansson
On Tue, Jan 26, 2016 at 4:11 PM, Andrew Lunn wrote: > PHY devices may only list clause 22, 45, and their PHY identifier > values as compatible values. No other compatible strings are allowed. > Make this clear in the documentation, and remove examples where > make/model compatible

Re: i40e: Kernel unaligned access due to 'struct i40e_dma_mem' being 'packed'

2016-01-27 Thread David Miller
From: tndave Date: Wed, 27 Jan 2016 17:50:14 -0800 > Hi, > > i40e driver has 'struct i40e_dma_mem' defined with 'packed' directive > causing kernel unaligned errors on sparc (when > 40e_allocate_dma_mem_d() > is being called) > > log_unaligned: 1031 callbacks

[PATCH next] ipvlan: inherit MTU from master device

2016-01-27 Thread Mahesh Bandewar
From: Mahesh Bandewar When we create IPvlan slave; we use ether_setup() and that sets up default MTU to 1500 while the master device may have lower / different MTU. Any subsequent changes to the masters' MTU are reflected into the slaves' MTU setting. However if those don't

Re: [PATCH net-next 1/8] net: local checksum offload for encapsulation

2016-01-27 Thread Zang MingJie
I have also noticed that for gso, all gso segs will have exactly same outer udp checksum, this is also because inner checksum cancellation. Can we also optimize that outer udp checksum should be only calculated once for all gso segs ? On 01/09/2016 03:45 AM, Edward Cree wrote: The

[RFC PATCH net-next 3/3] sctp: Add GSO support

2016-01-27 Thread Marcelo Ricardo Leitner
This patch enables SCTP to do GSO. SCTP has this pecualiarty that its packets cannot be just segmented to (P)MTU. Its chunks must be contained in IP segments, padding respected. So we can't just generate a big skb, set gso_size to the fragmentation point and deliver it to IP layer. Instead, this

[RFC PATCH net-next 1/3] skbuff: export skb_gro_receive

2016-01-27 Thread Marcelo Ricardo Leitner
sctp GSO requires it and sctp can be compiled as a module, so export this function. Signed-off-by: Marcelo Ricardo Leitner --- net/core/skbuff.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index

[RFC PATCH net-next 0/3] sctp: add GSO support

2016-01-27 Thread Marcelo Ricardo Leitner
This patchset is merely a RFC for the moment. There are some controversial points that I'd like to discuss before actually proposing the patches. The points are more detailed in the 3rd patch. Another approach that I can think of, is using something related to what Dave Miller mentioned on the

[RFC PATCH net-next 2/3] sctp: offloading support structure

2016-01-27 Thread Marcelo Ricardo Leitner
This patch just adds initial offloading bits, just to ease reviewing of the next one. It will be merged with GSO patch itself in the actual submission. Signed-off-by: Marcelo Ricardo Leitner --- include/linux/skbuff.h | 2 ++ include/net/sctp/sctp.h | 4

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-27 Thread Andrew Lunn
On Wed, Jan 27, 2016 at 08:41:56AM -0800, Olof Johansson wrote: > On Tue, Jan 26, 2016 at 4:11 PM, Andrew Lunn wrote: > > PHY devices may only list clause 22, 45, and their PHY identifier > > values as compatible values. No other compatible strings are allowed. > > Make this clear

[PATCH iproute2] bridge: support for static fdb entries

2016-01-27 Thread Roopa Prabhu
From: Roopa Prabhu There is no intuitive option to add static fdb entries today. 'temp' seems to have a side effect of adding 'static' fdb entries. But the name and intent of 'temp' does not say anything about it being static. example: bridge fdb add operates as

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-27 Thread Olof Johansson
On Wed, Jan 27, 2016 at 9:11 AM, Andrew Lunn wrote: > On Wed, Jan 27, 2016 at 08:41:56AM -0800, Olof Johansson wrote: >> On Tue, Jan 26, 2016 at 4:11 PM, Andrew Lunn wrote: >> > PHY devices may only list clause 22, 45, and their PHY identifier >> > values as

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-27 Thread Andrew Lunn
> Only case I can see the need for a make/model string is if there's a > need to add model-specific properties since you'd need a compatible > then (or make those properties shared between all phy bindings). Documentation/devicetree/bindings/net/micrel-ksz90x1.txt It adds optional properties to

Re: [PATCH v2] net:Add sysctl_tcp_sg_max_skb_frags

2016-01-27 Thread Hannes Frederic Sowa
On 27.01.2016 16:15, Eric Dumazet wrote: On Wed, 2016-01-27 at 14:20 +0100, Hans Westgaard Ry wrote: Devices may have limits on the number of fragments in an skb they support. Current codebase uses a constant as maximum for number of fragments one skb can hold and use. When enabling

Re: [PATCH net 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()

2016-01-27 Thread Hannes Frederic Sowa
On 27.01.2016 14:45, Paolo Abeni wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 3c8834b..973cb73 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1183,11 +1183,10 @@ static struct rt6_info *ip6_pol_route_output(struct net *net, struct fib6_table return

[PATCH net] tcp: beware of alignments in tcp_get_info()

2016-01-27 Thread Eric Dumazet
From: Eric Dumazet With some combinations of user provided flags in netlink command, it is possible to call tcp_get_info() with a buffer that is not 8-bytes aligned. It does matter on some arches, so we need to use put_unaligned() to store the u64 fields. Current iproute2

[PATCH] ixgbe: add a callback to set the maximum transmit bitrate

2016-01-27 Thread Rostislav Pehlivanov
This commit adds a callback which allows to adjust the maximum transmit bitrate the card can output. This makes it possible to get a smooth traffic instead of the default burst-y behaviour when trying to output e.g. a video stream. Much of the logic needed to get a correct bcnrc_val was taken

[PULL] virtio: fixes, tests

2016-01-27 Thread Michael S. Tsirkin
The following changes since commit 92e963f50fc74041b5e9e744c330dca48e04f08d: Linux 4.5-rc1 (2016-01-24 13:06:47 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

RE: [PATCH iproute2] bridge: support for static fdb entries

2016-01-27 Thread Rosen, Rami
+1 'temp' seems indeed not to be intuitive enough as 'static' in this context. Regards, Rami Rosen Intel Corporation -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Roopa Prabhu Sent: Wednesday, January 27, 2016 7:10 PM To:

Re: [PATCH] net: bcmgenet: bcmgenet.h: fix 0x0x prefix

2016-01-27 Thread Florian Fainelli
On 27/01/16 05:54, Antonio Ospite wrote: > Fix the 0x0x prefix in an integer constant. > > In this case, while at it, also fix a typo (s/unitcast/unicast/). > > Signed-off-by: Antonio Ospite > Cc: Florian Fainelli Acked-by: Florian Fainelli

Re: [RFC PATCH net-next 1/3] skbuff: export skb_gro_receive

2016-01-27 Thread Marcelo Ricardo Leitner
Em 27-01-2016 16:35, Eric Dumazet escreveu: On Wed, 2016-01-27 at 15:06 -0200, Marcelo Ricardo Leitner wrote: sctp GSO requires it and sctp can be compiled as a module, so export this function. Signed-off-by: Marcelo Ricardo Leitner --- net/core/skbuff.c | 1 + 1

Re: [RFC PATCH net-next 1/3] skbuff: export skb_gro_receive

2016-01-27 Thread Eric Dumazet
On Wed, 2016-01-27 at 15:06 -0200, Marcelo Ricardo Leitner wrote: > sctp GSO requires it and sctp can be compiled as a module, so export > this function. > > Signed-off-by: Marcelo Ricardo Leitner > --- > net/core/skbuff.c | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH] igb: Fix VLAN tag stripping on Intel i350

2016-01-27 Thread Jeff Kirsher
On Wed, 2016-01-27 at 14:28 +0100, Corinna Vinschen wrote: > Problem: When switching off VLAN offloading on an i350, the VLAN > interface gets unusable.  For testing, set up a VLAN on an i350 > and some remote machine, e.g.: > >   $ ip link add link eth0 name eth0.42 type vlan id 42 >   $ ip addr

Re: [PATCH] hostap: avoid uninitialized variable use in hfa384x_get_rid

2016-01-27 Thread Russell King - ARM Linux
On Wed, Jan 27, 2016 at 02:45:26PM +0100, Arnd Bergmann wrote: > To ensure we get consistent error handling here, this changes the code > to only set rlen if we actually read data correctly, which also takes > care of the warning. It may be a good idea to do the job better. Looking at the code:

RE: [PATCH 1/1] bonding: Use notifiers for slave link state detection

2016-01-27 Thread Tantilov, Emil S
>-Original Message- >From: Jay Vosburgh [mailto:jay.vosbu...@canonical.com] >Sent: Monday, January 25, 2016 10:01 PM >To: zhuyj >Cc: mkube...@suse.cz; vfal...@gmail.com; go...@cumulusnetworks.com; >netdev@vger.kernel.org; Shteinbock, Boris (Wind River); Tantilov, Emil S >Subject: Re:

Re: [PATCH net-next 09/10] net: Add a hardware buffer management helper API

2016-01-27 Thread Florian Fainelli
On 12/01/16 11:10, Gregory CLEMENT wrote: > This basic implementation allows to share code between driver using > hardware buffer management. As the code is hardware agnostic, there is > few helpers, most of the optimization brought by the an HW BM has to be > done at driver level. > >

Re: [PATCH v2] net:Add sysctl_tcp_sg_max_skb_frags

2016-01-27 Thread David Miller
From: Hans Westgaard Ry Date: Wed, 27 Jan 2016 14:20:29 +0100 > Devices may have limits on the number of fragments in an skb they support. Then this belongs as a global networking setting not a protocol specfic one.

[PATCH net 4/4] bond: track sum of rx_unhandled for all slaves

2016-01-27 Thread Jarod Wilson
Sample output with this set applied for an active-backup bond: $ cat /proc/net/dev Inter-| Receive | Transmit face |bytespackets errs drop unh fifo frame compressed multicast|bytes packets errs drop fifo colls carrier compressed

[PATCH net 2/4] net-procfs: show rx_unhandled counters

2016-01-27 Thread Jarod Wilson
The rx_unhandled counters get output here in a column after drop with a heading name of unh. I'm not sure if perhaps /proc/net/dev should be considered a stable interface that shouldn't be mucked with. If so, this can certainly be dropped, without impacting the core functionality. CC:

[PATCH net 0/4] net: add rx_unhandled stat counter

2016-01-27 Thread Jarod Wilson
The network core tries to keep track of dropped packets, but some packets you wouldn't really call dropped, so much as intentionally ignored, under certain circumstances. One such case is that of bonding and team device slaves that are currently inactive. Their respective rx_handler functions

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

2016-01-27 Thread Cong Wang
On Tue, Jan 26, 2016 at 6:23 PM, Eric Dumazet wrote: > On Tue, 2016-01-26 at 15:12 -0800, Cong Wang wrote: >> On Tue, Jan 26, 2016 at 2:55 PM, Julian Calaby >> wrote: >> > Hi Cong, >> > >> > On Wed, Jan 27, 2016 at 4:53 AM, Cong Wang

Re: [PULL] virtio: fixes, tests

2016-01-27 Thread Linus Torvalds
On Wed, Jan 27, 2016 at 11:12 AM, Michael S. Tsirkin wrote: > > arch/sh/include/asm/barrier.h| 1 - > tools/virtio/asm/barrier.h | 22 +- > tools/virtio/linux/compiler.h| 9 + > tools/virtio/linux/kernel.h | 1 + >

[4.2.y-ckt stable] Patch "=?UTF-8?q?veth:=20don=E2=80=99t=20modify=20ip=5Fsummed;=20doing?= =?UTF-8?q?=20so=20treats=20packets=20with=20bad=20checksums=20as=20good.?=" has been added to the 4.2.y-ckt

2016-01-27 Thread Kamal Mostafa
This is a note to let you know that I have just added a patch titled =?UTF-8?q?veth:=20don=E2=80=99t=20modify=20ip=5Fsummed;=20doing?= =?UTF-8?q?=20so=20treats=20packets=20with=20bad=20checksums=20as=20good.?= to the linux-4.2.y-queue branch of the 4.2.y-ckt extended stable tree which can

Re: [PATCH 1/2] netfilter: ipvs: avoid unused variable warnings

2016-01-27 Thread Julian Anastasov
Hello, On Wed, 27 Jan 2016, Arnd Bergmann wrote: > The proc_create() and remove_proc_entry() functions do not reference > their arguments when CONFIG_PROC_FS is disabled, so we get a couple > of warnings about unused variables in IPVS: > > ipvs/ip_vs_app.c:608:14: warning: unused

[PATCH net 1/4] net: add rx_unhandled stat counter

2016-01-27 Thread Jarod Wilson
This adds an rx_unhandled stat counter, along with a sysfs statistics node, and copies the counter out via netlink as well. CC: "David S. Miller" CC: Eric Dumazet CC: Jiri Pirko CC: Daniel Borkmann CC: Tom

[PATCH net 3/4] team: track sum of rx_unhandled for all slaves

2016-01-27 Thread Jarod Wilson
CC: Jiri Pirko CC: netdev@vger.kernel.org Signed-off-by: Jarod Wilson --- drivers/net/team/team.c | 10 +++--- include/linux/if_team.h | 1 + 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c

[PATCH 4.2.y-ckt 252/268] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

2016-01-27 Thread Kamal Mostafa
4.2.8-ckt3 -stable review patch. If anyone has any objections, please let me know. ---8< From: Vijay Pandurangan [ Upstream commit ce8c839b74e3017996fad4e1b7ba2e2625ede82f ] Packets that arrive from real hardware

Re: [PATCH RESEND net] nfc: use GFP_USER for user-controlled kmalloc

2016-01-27 Thread Eric Dumazet
On Wed, 2016-01-27 at 11:50 -0800, Cong Wang wrote: > Hmm? I think nfc_llcp_send_ui_frame() needs to do some fragmention > with this temporary memory, or you are saying msg_iter has some > API available to seek the pointer? Even if so, it doesn't look like > suitable for -stable. >

Re: [PATCH net 0/4] net: add rx_unhandled stat counter

2016-01-27 Thread Eric Dumazet
On Wed, 2016-01-27 at 15:21 -0500, Jarod Wilson wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 289c231..7973ab5 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -180,6 +180,7 @@ struct net_device_stats { > unsigned long

Re: Bypass at packet-page level (Was: Optimizing instruction-cache, more packets at each stage)

2016-01-27 Thread Jesper Dangaard Brouer
On Mon, 25 Jan 2016 23:10:16 +0100 Jesper Dangaard Brouer wrote: > On Mon, 25 Jan 2016 09:50:16 -0800 John Fastabend > wrote: > > > On 16-01-25 09:09 AM, Tom Herbert wrote: > > > On Mon, Jan 25, 2016 at 5:15 AM, Jesper Dangaard Brouer > > >

Re: [PATCH 2/2] netfilter: ipvs/SIP: handle ip_vs_fill_iph_skb_off failure

2016-01-27 Thread Julian Anastasov
Hello, On Wed, 27 Jan 2016, Arnd Bergmann wrote: > ip_vs_fill_iph_skb_off() may not find an IP header, and gcc has > determined that ip_vs_sip_fill_param() then incorrectly accesses > the protocol fields: > > net/netfilter/ipvs/ip_vs_pe_sip.c: In function 'ip_vs_sip_fill_param': >

Re: [PATCH net] ipv4: early demux should be aware of fragments

2016-01-27 Thread David Miller
From: Eric Dumazet Date: Tue, 26 Jan 2016 16:59:42 -0800 > From: Eric Dumazet > > We should not assume a valid protocol header is present, > as this is not the case for IPv4 fragments. > > Lets avoid extra cache line misses and potential bugs > if

[PATCH] tcp: Change reference to experimental CWND RFC.

2016-01-27 Thread Jörg Thalheim
Signed-off-by: Jörg Thalheim --- include/net/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index 051dc5c2..74d8eb4 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -216,7 +216,7 @@ void

Re: [PATCH net 1/2] of: of_mdio: Add a whitelist of PHY compatibilities.

2016-01-27 Thread Aaro Koskinen
Hi, On Wed, Jan 27, 2016 at 01:11:38AM +0100, Andrew Lunn wrote: > Some phy nodes list a compatible value indicating the PHY make/model. > This is never used to match the device to the driver. However it does > confuse the code to separate a PHY from a generic MDIO device like a > switch. Generic

Re: [PATCH 0/2] vhost: cross-endian code cleanup

2016-01-27 Thread Greg Kurz
On Wed, 13 Jan 2016 18:09:34 +0100 Greg Kurz wrote: > This series is a respin of the following patch: > > http://patchwork.ozlabs.org/patch/565921/ > > Patch 1 is preliminary work: it gives better names to the helpers that are > involved in cross-endian support. > >

802.11ad symmetry

2016-01-27 Thread Samsonov Dmitry
Hello! bonding-de...@lists.sourceforge.net is not accepting e-mails, so I assume this list is the correct destination. Is there a way to make LACP bonding between a linux box and a switch to be symmetric? As I understand, currently there is no way to guarantee, that hash, generated for two

[PATCH net v2] tipc: fix connection abort during subscription cancel

2016-01-27 Thread Parthasarathy Bhuvaragan
In 'commit 7fe8097cef5f ("tipc: fix nullpointer bug when subscribing to events")', we terminate the connection if the subscription creation fails. In the same commit, the subscription creation result was based on the value of the subscription pointer (set in the function) instead of the return

[RFC] mac80211: introduce netdev queue control for txqs

2016-01-27 Thread Michal Kazior
Until now all stations (notably in AP mode) would share 4 AC queues exposed via netdev. This meant that whenever a single station's AC became full all other stations' AC were considered full and stopped as well. This was suboptimal and could lead to per station traffic starvation and/or

switchdev automated testing

2016-01-27 Thread Jiri Pirko
Hi All. Just want to send a small note here about what we use for mlxsw driver automated testing. It can be handy for other people using switchdev infra, namely DSA guys. The framework is called LNST: http://lnst-project.org/ Switchdev recipes are located in LNST git repo here:

[PATCH 1/1] netfilter: h323: avoid potential attack

2016-01-27 Thread Zhouyi Zhou
From: Zhouyi Zhou I think hackers chould build a malicious h323 packet to overflow the pointer p which will panic during the memcpy(addr, p, len) For example, he may fabricate a very large taddr->ipAddress.ip; Signed-off-by: Zhouyi Zhou ---

[PATCH 2/9] net: hp100: remove unnecessary #ifdefs

2016-01-27 Thread Arnd Bergmann
Building the hp100 ethernet driver causes warnings when both the PCI and EISA drivers are disabled: ethernet/hp/hp100.c: In function 'hp100_module_init': ethernet/hp/hp100.c:3047:2: warning: label 'out3' defined but not used [-Wunused-label] ethernet/hp/hp100.c: At top level:

[PATCH 3/9] net: bgmac: clarify CONFIG_BCMA dependency

2016-01-27 Thread Arnd Bergmann
The bgmac driver depends on BCMA_HOST_SOC, which is only used when CONFIG_BCMA is enabled. However, it is a bool option and can be set when CONFIG_BCMA=m, and then bgmac can be built-in, leading to an obvious link error: drivers/built-in.o: In function `bgmac_init': :(.init.text+0x7f2c):

[PATCH 4/9] net: moxart: use correct accessors for DMA memory

2016-01-27 Thread Arnd Bergmann
The moxart ethernet driver confuses coherent DMA buffers with MMIO registers. moxart_ether.c: In function 'moxart_mac_setup_desc_ring': moxart_ether.c:146:428: error: passing argument 1 of '__fswab32' makes integer from pointer without a cast [-Werror=int-conversion] moxart_ether.c:74:39:

[PATCH 7/9] net: macb: avoid uninitialized variables

2016-01-27 Thread Arnd Bergmann
The macb_clk_init function returns three clock pointers, unless the it fails to get the first ones. We correctly handle the failure case by propagating the error from macb_probe, but gcc does not realize this and incorrectly warns about a later use of those: In file included from

[PATCH 9/9] net: tg3: avoid uninitialized variable warning

2016-01-27 Thread Arnd Bergmann
The tg3_set_eeprom() function correctly initializes the 'start' variable, but gcc generates a false warning: drivers/net/ethernet/broadcom/tg3.c: In function 'tg3_set_eeprom': drivers/net/ethernet/broadcom/tg3.c:12057:4: warning: 'start' may be used uninitialized in this function

[PATCH 6/9] net: vxge: avoid unused function warnings

2016-01-27 Thread Arnd Bergmann
When CONFIG_PCI_MSI is disabled, we get warnings about unused functions in the vxge driver: drivers/net/ethernet/neterion/vxge/vxge-main.c:2121:13: warning: 'adaptive_coalesce_tx_interrupts' defined but not used [-Wunused-function] drivers/net/ethernet/neterion/vxge/vxge-main.c:2149:13: warning:

[PATCH 8/9] net: nb8800: avoid uninitialized variable warning

2016-01-27 Thread Arnd Bergmann
The nb8800_poll() function initializes the 'next' variable in the loop looking for new input data. We know this will be called at least once because 'budget' is a guaranteed to be a positive number when we enter the function, but the compiler doesn't know that and warns when the variable is used

[PATCH 5/9] net: fddi/defxx: avoid warning about uninitialized variable use

2016-01-27 Thread Arnd Bergmann
The defxx driver can be configured for different kinds of buses, and appears to be handling this correctly, but the compiler cannot see how it always initializes the bar_start and bar_length fields it uses depending on the configured bus, so we get a warning with recent gcc versions:

Re: [PATCH 8/9] net: nb8800: avoid uninitialized variable warning

2016-01-27 Thread Måns Rullgård
Arnd Bergmann writes: > The nb8800_poll() function initializes the 'next' variable in the > loop looking for new input data. We know this will be called at > least once because 'budget' is a guaranteed to be a positive number > when we enter the function, but the compiler doesn't

[patch net] switchdev: Require RTNL mutex to be held when sending FDB notifications

2016-01-27 Thread Jiri Pirko
From: Ido Schimmel When switchdev drivers process FDB notifications from the underlying device they resolve the netdev to which the entry points to and notify the bridge using the switchdev notifier. However, since the RTNL mutex is not held there is nothing preventing the

[patch net 00/11] mlxsw: driver fixes

2016-01-27 Thread Jiri Pirko
From: Jiri Pirko Couple of various mlxsw driver fixes. Ido Schimmel (11): mlxsw: spectrum: Handle port leaving LAG while bridged mlxsw: reg: Add the Switch Filtering DB Flush register mlxsw: spectrum: Flush FDB when leaving bridge mlxsw: spectrum: Don't forward

[patch net 11/11] mlxsw: reg: Use correct offset in field definiton

2016-01-27 Thread Jiri Pirko
From: Ido Schimmel The rx_lane, tx_lane and module fields in the PMLP register don't have an additional offset besides the base one (0x04), so set it to 0x00. Fixes: 4ec14b7634b2 ("mlxsw: Add interface to access registers and process events") Signed-off-by: Ido Schimmel

  1   2   >