From: Zhu Yanjun
The commit 0e4d422f5f72 ("ixgbe: do not call check_link for ethtool
in ixgbe_get_settings()") decreases the bonding failures. But the
following time slice still results in a bonding failure.
bondingixgbe
| |
|carrier_on
Hi, Emil
Thanks for your patch.
After I applied your patch, the following are the feedback from my users.
"
Users had tested the latest patch that you provided and it is much improved
now. However it’s still not good enough as the users are planning field
deployment. Here are their findings:
Currently link priority changes isn't handled for active links. In
this patch we resolve this by changing our priority if the peer passes
a valid priority in a state message.
Reviewed-by: Jon Maloy
Signed-off-by: Richard Alpe
---
net/tipc/link.c | 6 ++
1 file changed, 6 insertions(+)
diff
Changing certain link attributes (link tolerance and link priority)
from the TIPC management tool is supposed to automatically take
effect at both endpoints of the affected link.
Currently the media address is not instantiated for the link and is
used uninstantiated when crafting protocol messages
Hi Sudip,
On Mon, Feb 1, 2016 at 3:25 PM, Sudip Mukherjee
wrote:
> On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote:
>> Hi Sudip,
>>
>> On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee
>> wrote:
>> > On error we jumped to the error label and returned the error code but we
>> > misse
On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote:
> Hi Sudip,
>
> On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee
> wrote:
> > On error we jumped to the error label and returned the error code but we
> > missed releasing sinfo.
> >
> > Signed-off-by: Sudip Mukherjee
>
> Should the
From: Zhu Yanjun
rcu_read_lock and rcu_read_unlock are to protect the function
bond_miimon_inspect. As such, moving rcu_read_lock and rcu_read_unlock
to the function bond_miimon_inspect to make the source code compact.
CC: Jay Vosburgh
CC: Veaceslav Falico
CC: Andy Gospodarek
Signed-off-by: Z
Hannes Frederic Sowa wrote:
> On 29.01.2016 12:30, Paolo Abeni wrote:
>> The current implementation of ip6_dst_lookup_tail basically
>> ignore the egress ifindex match: if the saddr is set,
>> ip6_route_output() purposefully ignores flowi6_oif, due
>> to the commit d46a9d678e4c ("net: ipv6: Dont
Hannes Frederic Sowa wrote:
> On 29.01.2016 12:30, Paolo Abeni wrote:
>> Currently, the egress interface index specified via IPV6_PKTINFO
>> is ignored by __ip6_datagram_connect(), so that RFC 3542 section 6.7
>> can be subverted when the user space application calls connect()
>> before sendmsg()
This adds initial support for offloading the u32 tc classifier. This
initial implementation only implements a few base matches and actions
to illustrate the use of the infrastructure patches.
However it is an interesting subset because it handles the u32 next
hdr logic to correctly map tcp packets
This adds an ixgbe data structure that is used to determine what
headers:fields can be matched and in what order they are supported.
For hardware devices this can be a bit tricky because typically
only pre-programmed (firmware, ucode, rtl) parse graphs will be
supported and we don't yet have an in
This is a helper function drivers can use to learn if the
action type is a drop action.
Signed-off-by: John Fastabend
---
include/net/tc_act/tc_gact.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/include/net/tc_act/tc_gact.h b/include/net/tc_act/tc_gact.h
index 592a6bc..
Its useful to turn off the qdisc offload feature at a per device
level. This gives us a big hammer to enable/disable offloading.
More fine grained control (i.e. per rule) may be supported later.
Signed-off-by: John Fastabend
---
include/linux/netdev_features.h |3 +++
net/core/ethtool.c
This patch allows netdev drivers to consume cls_u32 offloads via
the ndo_setup_tc ndo op.
This works aligns with how network drivers have been doing qdisc
offloads for mqprio.
Signed-off-by: John Fastabend
---
include/linux/netdevice.h |6 +++-
include/net/pkt_cls.h | 33 +
This patch updates setup_tc so we can pass additional parameters into
the ndo op in a generic way. To do this we provide structured union
and type flag.
This lets each classifier and qdisc provide its own set of attributes
without having to add new ndo ops or grow the signature of the
callback.
S
The ndo_setup_tc() op was added to support drivers offloading tx
qdiscs however only support for mqprio was ever added. So we
only ever added support for passing the number of traffic classes
to the driver.
This patch generalizes the ndo_setup_tc op so that a handle can
be provided to indicate if
I was waiting for net-next to open to submit this but it seems like
a good idea to get an RFC out there for folks to start looking over.
This extends the setup_tc framework so it can support more than just
the mqprio offload and push other classifiers and qdiscs into the
hardware. The series here
On (01/31/16 16:24), Eric Dumazet wrote:
>
> But this test is absolutely useless, what about testing arches that
> actually care ?
>
Yes, I plan to help test this out tomorrow, Tom suggested setting up
gre-teb between x86 and sparc.
--Sowmini
Le 31/01/2016 16:24, Eric Dumazet a écrit :
> On Sun, 2016-01-31 at 13:37 -0800, Tom Herbert wrote:
>> Call get_unaligned_be32 when we access 32-bit fields in
>> __skb_flow_dissect. At the beginning check for unlikely case of
>> 1-byte aligned packet.
>>
>> Note that flow_dissector may be asked to
On Sun, 2016-01-31 at 13:37 -0800, Tom Herbert wrote:
> Call get_unaligned_be32 when we access 32-bit fields in
> __skb_flow_dissect. At the beginning check for unlikely case of
> 1-byte aligned packet.
>
> Note that flow_dissector may be asked to parse packet unaligned
> fields in two instances:
On Sun, 2016-01-31 at 14:13 -0800, Tom Herbert wrote:
> Neither is GRE enabled by default in Linux and it is not a typical
> case. So that patch is an optimization for a very narrow use case that
> impacts the core data path for everyone. Please at least consider
> making it configurable.
No idea
Hi Sudip,
On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee
wrote:
> On error we jumped to the error label and returned the error code but we
> missed releasing sinfo.
>
> Signed-off-by: Sudip Mukherjee
Should the From: and Signed-off-by: email addresses be the same?
> ---
> net/mac80211/sta_i
The smc91x driver doesn't honor the probe deferral mechanism when the
interrupt source is not yet available, such as one provided by a gpio
controller not probed.
Fix this by propagating the platform_get_irq() error code as the probe
return value.
Signed-off-by: Robert Jarzmik
---
drivers/net/e
On Fri, Jan 29, 2016 at 6:15 PM, Eric Dumazet wrote:
> On Fri, 2016-01-29 at 16:47 -0800, Tom Herbert wrote:
>
>> Hmm, thanks for pointing that out. It looks like this is called by a
>> couple drivers as part of pulling up the data to get alignment. I am
>> actually surprised they are doing this.
Tom Herbert wrote:
> Call get_unaligned_be32 when we access 32-bit fields in
> __skb_flow_dissect. At the beginning check for unlikely case of
> 1-byte aligned packet.
>
> Note that flow_dissector may be asked to parse packet unaligned
> fields in two instances:
>
> 1) Packet from a driver which
Hi,
I've updated all three boxes to 4.1.15. I've just had link outage again,
but this time I got more detailed backtrace..
not sure, but maybe it could be of some help?
[Jan30 23:53] ixgbe :03:00.0 eth0: NIC Link is Down
[ +0.097285] bond0: link status definitely down for interface eth0, di
Hi Tom,
[auto build test WARNING on net/master]
url:
https://github.com/0day-ci/linux/commits/Tom-Herbert/net-Allow-flow-dissector-to-handle-non-4-byte-aligned-headers/20160201-053832
config: xtensa-allyesconfig (attached as .config)
reproduce:
wget
https://git.kernel.org/cgit/linux/
Call get_unaligned_be32 when we access 32-bit fields in
__skb_flow_dissect. At the beginning check for unlikely case of
1-byte aligned packet.
Note that flow_dissector may be asked to parse packet unaligned
fields in two instances:
1) Packet from a driver which is aligned to Ethernet header
(2
On (01/31/16 11:17), David Miller wrote:
>
> > If nothing else we can discuss this further in Seville as I am just
> > not convinced changing the drivers is the right way to go about fixing
> > this, and I won't have the time to really get around to doing any of
> > it until I have come back from
From: Alexander Duyck
Date: Sun, 31 Jan 2016 01:12:03 -0800
> If nothing else we can discuss this further in Seville as I am just
> not convinced changing the drivers is the right way to go about fixing
> this, and I won't have the time to really get around to doing any of
> it until I have come
On Sat, Jan 30, 2016 at 03:26:35PM -0800, David Miller wrote:
> From: Jarod Wilson
> Date: Sat, 30 Jan 2016 15:53:05 -0500
>
> > On Sat, Jan 30, 2016 at 03:39:01PM -0500, Jarod Wilson wrote:
> >> Ew, no, it won't work correctly on 32-bit. The for loop is going to copy
> >> data into dst from beyo
Hello.
On 01/31/2016 06:33 PM, Corcodel Marian wrote:
These bits is already set on set geatures stage.
Features.
Signed-off-by: Corcodel Marian
[...]
MBR, Sergei
Hello.
On 01/31/2016 06:33 PM, Corcodel Marian wrote:
These bits is already set on set geatures stage.
Features.
Signed-off-by: Corcodel Marian
[...]
MBR, Sergei
These bits is already set on set geatures stage.
Signed-off-by: Corcodel Marian
---
drivers/net/ethernet/realtek/r8169.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c
b/drivers/net/ethernet/realtek/r8169.c
index 17d5571..a8fb86d 100644
--- a/drivers/ne
On Saturday 30 January 2016 19:47:36 Vasily Averin wrote:
> Patch makes safe an access to 'oiph' and 'oudph' variables
> if they was not initilized.
>
> Signed-off-by: Vasily Averin
> ---
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
On Saturday 30 January 2016 18:33:26 Vasily Averin wrote:
> On 26.01.2016 02:58, Jeff Kirsher wrote:
> > From: Arnd Bergmann
> >
> > intel/i40e/i40e_txrx.c: In function 'i40e_xmit_frame_ring':
> > intel/i40e/i40e_txrx.c:2367:20: error: 'oiph' may be used uninitialized in
> > this function [-Werr
On Fri, Jan 29, 2016 at 10:48:26PM +0100, Nikolay Aleksandrov wrote:
> On 01/29/2016 10:45 PM, Jay Vosburgh wrote:
> > Nikolay Aleksandrov wrote:
> >
> >> On 01/25/2016 05:24 PM, Bjørnar Ness wrote:
> >>> As subject says, 802.3ad bonding is not working with virtio network model.
> >>>
> >>> The o
On Sat, Jan 30, 2016 at 12:41:16PM +0100, Nikolay Aleksandrov wrote:
> On 01/30/2016 07:59 AM, David Miller wrote:
> > From: Nikolay Aleksandrov
> > Date: Fri, 29 Jan 2016 22:48:26 +0100
> >
> >> On 01/29/2016 10:45 PM, Jay Vosburgh wrote:
> >>> Nikolay Aleksandrov wrote:
> >>>
> On 01/25/2
On Fri, Jan 29, 2016 at 01:45:00PM -0800, Jay Vosburgh wrote:
> Nikolay Aleksandrov wrote:
>
> >On 01/25/2016 05:24 PM, Bjørnar Ness wrote:
> >> As subject says, 802.3ad bonding is not working with virtio network model.
> >>
> >> The only errors I see is:
> >>
> >> No 802.3ad response from the
On Sat, Jan 30, 2016 at 7:45 PM, David Miller wrote:
> From: Alexander Duyck
> Date: Sat, 30 Jan 2016 17:13:35 -0800
>
>> The NIC hardware only allows us to set receive buffer sizes in 1K
>> increments. I think fm10k may be an exception in that it may be able
>> to support 512 byte, but otherwis
40 matches
Mail list logo
