Re: [PATCH v2] mwifiex: advertise low priority scan feature

2016-03-21 Thread Wei-Ning Huang
Tested-by: Wei-Ning Huang On Tue, Mar 22, 2016 at 12:09 PM, Wei-Ning Huang wrote: > From: Amitkumar Karwar > > Low priority scan handling code which delays or aborts scan > operation based on Tx traffic is removed recently. The

Re: [PATCH] mwifiex: advertise low priority scan feature

2016-03-21 Thread Wei-Ning Huang
Hi Kalle, Thanks for the review. I accidentally removed the s-o-b line from akarwar in this version. The original patch can be found at: https://chromium-review.googlesource.com/#/c/246052/ I've resent a new one. Wei-Ning On Mon, Mar 21, 2016 at 6:28 PM, Kalle Valo wrote:

[PATCH v2] mwifiex: advertise low priority scan feature

2016-03-21 Thread Wei-Ning Huang
From: Amitkumar Karwar Low priority scan handling code which delays or aborts scan operation based on Tx traffic is removed recently. The reason is firmware already takes care of it in our new feature scan channel gap. Hence we should advertise low priority scan support to

Re: [PATCH v2] net: add missing descriptions in net_device_priv_flags

2016-03-21 Thread David Miller
From: Luis de Bethencourt Date: Mon, 21 Mar 2016 20:58:28 + > The flags IFF_XMIT_DST_RELEASE_PERM, IFF_IPVLAN_MASTER and > IFF_IPVLAN_SLAVE are missing descriptions for the Documentation. Adding > them. > > Signed-off-by: Luis de Bethencourt

Re: [PATCH 1/2] net: Fix indentation of the conf/ documentation block

2016-03-21 Thread David Miller
From: Benjamin Poirier Date: Mon, 21 Mar 2016 13:21:39 -0700 > Commit d67ef35fff67 ("clarify documentation for > net.ipv4.igmp_max_memberships") mistakenly indented a block of > documentation such that it now looks like it belongs to a specific sysctl. > Restore that block's

Re: [PATCH 2/2] igmp: Document sysctl_igmp_max_msf

2016-03-21 Thread David Miller
From: Benjamin Poirier Date: Mon, 21 Mar 2016 13:21:40 -0700 > Signed-off-by: Benjamin Poirier Applied.

Re: Make DST_CACHE a silent config option

2016-03-21 Thread David Miller
From: Dave Jones Date: Mon, 21 Mar 2016 18:37:22 -0400 > commit 911362c70d ("net: add dst_cache support") added a new > kconfig option that gets selected by other networking options. > It seems the intent wasn't to offer this as a user-selectable > option given the lack

Re: [PATCH] net: Add missing kernel-doc for netdev ptype lists

2016-03-21 Thread David Miller
From: Benjamin Poirier Date: Mon, 21 Mar 2016 14:08:28 -0700 > .//include/linux/netdevice.h:1826: warning: No description found for > parameter 'ptype_all' > .//include/linux/netdevice.h:1826: warning: No description found for > parameter 'ptype_specific' > > Introduced by

Re: [PATCH RESEND] net: ipv4: Fix truncated timestamp returned by inet_current_timestamp()

2016-03-21 Thread David Miller
From: Deepa Dinamani Date: Mon, 21 Mar 2016 18:21:26 -0700 > The millisecond timestamps returned by the function is > converted to network byte order by making a call to htons(). > htons() only returns __be16 while __be32 is required here. > > This was identified by the

Re: [Make-wifi-fast] [RFCv2 1/3] mac80211: implement fq_codel for software queuing

2016-03-21 Thread David Lang
On Wed, 16 Mar 2016, Michal Kazior wrote: Since 11n aggregation become important to get the best out of txops. However aggregation inherently requires buffering and queuing. Once variable medium conditions to different associated stations is considered it became apparent that bufferbloat can't

RE: [PATCH net-next 1/3] net: add the AF_KCM entries to family name tables

2016-03-21 Thread Dexuan Cui
> From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, March 21, 2016 23:28 > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com;

Re: [PATCH net-next] net/mlx4_core: Fix backward compatibility on VFs

2016-03-21 Thread Alexey Kardashevskiy
On 03/22/2016 12:56 AM, Eli Cohen wrote: On Mon, Mar 21, 2016 at 04:02:16PM +1100, Alexey Kardashevskiy wrote: After more tries, I found that if for whatever reason mlx4_core fails to stop while shutting the guest down (last message is "mlx4_core :00:00.0: mlx4_shutdown was called"), then

[PATCH RESEND] net: ipv4: Fix truncated timestamp returned by inet_current_timestamp()

2016-03-21 Thread Deepa Dinamani
The millisecond timestamps returned by the function is converted to network byte order by making a call to htons(). htons() only returns __be16 while __be32 is required here. This was identified by the sparse warning from the buildbot: net/ipv4/af_inet.c:1405:16: sparse: incorrect type in return

Re: [PATCH net 09/10] net: hns: adds limitation for debug port mtu

2016-03-21 Thread Yisen Zhuang
在 2016/3/21 22:17, Sergei Shtylyov 写道: > Hello. > > On 03/21/2016 02:06 PM, Yisen Zhuang wrote: > >> From: Kejian Yan >> >> If mtu for debug port is set more than 1500, it may cause that packets >> are dropped by ppe. So maximum value for debug port should be 1500. >> >>

Re: [PATCH net 06/10] net: hns: fix return value of the function about rss

2016-03-21 Thread Yisen Zhuang
在 2016/3/21 23:42, David Miller 写道: > From: Yisen Zhuang > Date: Mon, 21 Mar 2016 19:06:37 +0800 > >> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c >> b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c >> index 3c4a3bc..f3a5e05 100644 >> ---

Re: [PATCH net 03/10] net: hns: add uc match for debug ports

2016-03-21 Thread Yisen Zhuang
在 2016/3/21 23:40, David Miller 写道: > From: Yisen Zhuang > Date: Mon, 21 Mar 2016 19:06:34 +0800 > >> +(void)hns_mac_set_promisc(mac_cb, (u8)!!en); > > This cast to void is unnecssary. I think hns_mac_set_promisc don't need to return a value, so i will fix it in

Re: [PATCH net 01/10] net: hns: bug fix about ping6

2016-03-21 Thread Yisen Zhuang
在 2016/3/21 23:39, David Miller 写道: > From: Yisen Zhuang > Date: Mon, 21 Mar 2016 19:06:32 +0800 > >> From: Kejian Yan >> >> The current upstreaming code fails to ping other IPv6 net device, because >> the enet receives the multicast packets with

[PATCH 1/1] net: ipv4: Fix truncated timestamp returned by inet_current_timestamp()

2016-03-21 Thread Deepa Dinamani
The millisecond timestamps returned by the function is converted to network byte order by making a call to htons(). htons() only returns __be16 while __be32 is required here. This was identified by the sparse warning from the buildbot: net/ipv4/af_inet.c:1405:16: sparse: incorrect type in return

Make DST_CACHE a silent config option

2016-03-21 Thread Dave Jones
commit 911362c70d ("net: add dst_cache support") added a new kconfig option that gets selected by other networking options. It seems the intent wasn't to offer this as a user-selectable option given the lack of help text, so this patch converts it to a silent option. Signed-off-by: Dave Jones

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

2016-03-21 Thread Sergei Shtylyov
On 03/21/2016 11:41 PM, Uwe Kleine-König wrote: Commit 687908c2b649 ("net: phy: at803x: simplify using devm_gpiod_get_optional and its 4th argument") introduced a dependency on GPIOLIB that was not there before. This commit removes such dependency by checking the return code and comparing it

Re: [PATCH] net: Add missing kernel-doc for netdev ptype lists

2016-03-21 Thread Luis de Bethencourt
On 21/03/16 21:08, Benjamin Poirier wrote: > .//include/linux/netdevice.h:1826: warning: No description found for > parameter 'ptype_all' > .//include/linux/netdevice.h:1826: warning: No description found for > parameter 'ptype_specific' > > Introduced by commit 7866a621043f ("dev: add per

Re: [PATCH net-next] change nfqueue failopen to apply also to receive message buffer in addition to queue size

2016-03-21 Thread Pablo Neira Ayuso
On Mon, Mar 21, 2016 at 11:23:43AM +, Yigal Reiss (yreiss) wrote: > @@ -582,10 +585,17 @@ __nfqnl_enqueue_packet(struct net *net, struct > nfqnl_instance *queue, > *packet_id_ptr = htonl(entry->id); > > /* nfnetlink_unicast will either free the nskb or add it to a socket */ > -

[PATCH] net: Add missing kernel-doc for netdev ptype lists

2016-03-21 Thread Benjamin Poirier
.//include/linux/netdevice.h:1826: warning: No description found for parameter 'ptype_all' .//include/linux/netdevice.h:1826: warning: No description found for parameter 'ptype_specific' Introduced by commit 7866a621043f ("dev: add per net_device packet type chains") Cc: Salam Noureddine

RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-21 Thread Alan Stern
On Mon, 21 Mar 2016 woojung@microchip.com wrote: > > > > But this leaves open the issue that querying the device too often will > > > > prevent it from going into autosuspend. It seems to me that the best > > > > way to deal with this is to make sure that the autosuspend timeout is > > > >

Re: [PATCH] net: add missing descriptions in net_device_priv_flags

2016-03-21 Thread Luis de Bethencourt
On 21/03/16 20:41, Benjamin Poirier wrote: > On 2016/03/21 20:20, Luis de Bethencourt wrote: >> The flags IFF_XMIT_DST_RELEASE_PERM, IFF_IPVLAN_MASTER and >> IFF_IPVLAN_SLAVE are missing descriptions for the Documentation. Adding >> them. >> >> Signed-off-by: Luis de Bethencourt

[PATCH v2] net: add missing descriptions in net_device_priv_flags

2016-03-21 Thread Luis de Bethencourt
The flags IFF_XMIT_DST_RELEASE_PERM, IFF_IPVLAN_MASTER and IFF_IPVLAN_SLAVE are missing descriptions for the Documentation. Adding them. Signed-off-by: Luis de Bethencourt Suggested-by: Benjamin Poirier --- Hi, Changing the description of

Re: [PATCH] net: add missing descriptions in net_device_priv_flags

2016-03-21 Thread Benjamin Poirier
On 2016/03/21 20:20, Luis de Bethencourt wrote: > The flags IFF_XMIT_DST_RELEASE_PERM, IFF_IPVLAN_MASTER and > IFF_IPVLAN_SLAVE are missing descriptions for the Documentation. Adding > them. > > Signed-off-by: Luis de Bethencourt > --- > Hi, > > I also noticed this issue

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

2016-03-21 Thread Uwe Kleine-König
Hello Sergei, On Mon, Mar 21, 2016 at 11:15:13PM +0300, Sergei Shtylyov wrote: > On 03/16/2016 08:25 PM, Sebastian Frias wrote: > > >Commit 687908c2b649 ("net: phy: at803x: simplify using > >devm_gpiod_get_optional and its 4th argument") introduced a dependency > >on GPIOLIB that was not there

[PATCH] ip.7: Fix incorrect sockopt name

2016-03-21 Thread Benjamin Poirier
"IP_LEAVE_GROUP" does not exist. It was perhaps a confusion with MCAST_LEAVE_GROUP. Change the text to IP_DROP_MEMBERSHIP which has the same function as MCAST_LEAVE_GROUP and is documented in the ip.7 man page. Reference: Linux kernel net/ipv4/ip_sockglue.c do_ip_setsockopt() Cc: Radek Pazdera

[PATCH 2/2] igmp: Document sysctl_igmp_max_msf

2016-03-21 Thread Benjamin Poirier
Signed-off-by: Benjamin Poirier --- Documentation/networking/ip-sysctl.txt | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt index d3768e8..b183e2b 100644 ---

[PATCH 1/2] net: Fix indentation of the conf/ documentation block

2016-03-21 Thread Benjamin Poirier
Commit d67ef35fff67 ("clarify documentation for net.ipv4.igmp_max_memberships") mistakenly indented a block of documentation such that it now looks like it belongs to a specific sysctl. Restore that block's original position. Cc: Jeremy Eder Signed-off-by: Benjamin Poirier

[PATCH] net: add missing descriptions in net_device_priv_flags

2016-03-21 Thread Luis de Bethencourt
The flags IFF_XMIT_DST_RELEASE_PERM, IFF_IPVLAN_MASTER and IFF_IPVLAN_SLAVE are missing descriptions for the Documentation. Adding them. Signed-off-by: Luis de Bethencourt --- Hi, I also noticed this issue when running make htmldocs. Having better documentation is great

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

2016-03-21 Thread Sergei Shtylyov
Hello. On 03/16/2016 08:25 PM, Sebastian Frias wrote: Commit 687908c2b649 ("net: phy: at803x: simplify using devm_gpiod_get_optional and its 4th argument") introduced a dependency on GPIOLIB that was not there before. This commit removes such dependency by checking the return code and

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

2016-03-21 Thread Uwe Kleine-König
Hello Sebastian, On Mon, Mar 21, 2016 at 04:36:47PM +0100, Sebastian Frias wrote: > On 03/21/2016 02:54 PM, Uwe Kleine-König wrote: > >> - We'd also need to check that 'gpiod' is not NULL > > > > That is the optional part. If gpiod is NULL, you have one of the devices > > that don't need to

Re: [RFC PATCH 0/9] RFC6864 compliant GRO and GSO partial offload

2016-03-21 Thread Jesse Gross
On Mon, Mar 21, 2016 at 12:46 PM, Alexander Duyck wrote: > On Mon, Mar 21, 2016 at 11:50 AM, David Miller wrote: >> From: Alexander Duyck >> Date: Fri, 18 Mar 2016 16:24:38 -0700 >> >>> This patch series addresses two things.

RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-21 Thread Woojung.Huh
> > > But this leaves open the issue that querying the device too often will > > > prevent it from going into autosuspend. It seems to me that the best > > > way to deal with this is to make sure that the autosuspend timeout is > > > shorter than the interal between queries, not to make the

Re: [PATCH 1/3] tc: f_u32: add missing spaces around operators

2016-03-21 Thread Stephen Hemminger
On Wed, 16 Mar 2016 17:56:12 +0100 Luca Lemmo wrote: > Signed-off-by: Luca Lemmo All applied,

Re: [iproute PATCH] Use ARRAY_SIZE macro everywhere

2016-03-21 Thread Stephen Hemminger
On Thu, 17 Mar 2016 20:28:08 +0100 Phil Sutter wrote: > This patch was generated by the following semantic patch (a trimmed down > version of what is shipped with Linux sources): > > @@ > type T; > T[] E; > @@ > ( > - (sizeof(E)/sizeof(*E)) > + ARRAY_SIZE(E) > | > -

Re: [RFC PATCH 0/9] RFC6864 compliant GRO and GSO partial offload

2016-03-21 Thread Alexander Duyck
On Mon, Mar 21, 2016 at 11:50 AM, David Miller wrote: > From: Alexander Duyck > Date: Fri, 18 Mar 2016 16:24:38 -0700 > >> This patch series addresses two things. >> >> First it enables what I am calling RFC6864 compliant GRO. Basically what >> I am

Re: [iproute PATCH 2/8] tc: connmark, pedit: Rename BRANCH to CONTROL

2016-03-21 Thread Stephen Hemminger
On Wed, 16 Mar 2016 22:56:18 +0100 Phil Sutter wrote: > As Jamal suggested, BRANCH is the wrong name, as these keywords go > beyond simple branch control - e.g. loops are possible, too. Therefore > rename the non-terminal to CONTROL instead which should be more > appropriate. > >

FOR YOUR INFORMATION DEAR BENEFICIARY,

2016-03-21 Thread David Kedogo
FOR YOUR INFORMATION DEAR BENEFICIARY, Your Over-due ATM Card payment of $1.5MUSD by the UN Office have deposited to the ATM MASTER CARD OFFICE. All you have to do now is to contact the Office Manager Dr. peter Akupa Boni at: (peterakupa...@gmail.com) and Phone number: +229 61 31 07 78 , he will

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-21 Thread Alan Stern
On Mon, 21 Mar 2016, Oliver Neukum wrote: > On Mon, 2016-03-21 at 14:24 -0400, Alan Stern wrote: > > On Mon, 21 Mar 2016, Oliver Neukum wrote: > > > > > On Mon, 2016-03-21 at 10:57 -0400, Alan Stern wrote: > > > > > > > One possible solution is to export a sysfs parameter to prevent > > > >

Re: [RFC PATCH 0/9] RFC6864 compliant GRO and GSO partial offload

2016-03-21 Thread David Miller
From: Alexander Duyck Date: Fri, 18 Mar 2016 16:24:38 -0700 > This patch series addresses two things. > > First it enables what I am calling RFC6864 compliant GRO. Basically what > I am doing is allowing one of two patterns for incoming frames. Either the > IP ID will

Re: [PATCH] rtnetlink.7: add missing RTA_* attributes

2016-03-21 Thread Stephen Hemminger
On Tue, 15 Mar 2016 13:06:27 +0100 Jan Moskyto Matejka wrote: > Used Bird's source code, kernel source code, iproute2 source code and > iproute2 manpages to find meanings of these new attributes. > > Signed-off-by: Jan Moskyto Matejka This is patch against linux man

Re: [PATCH v6 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-03-21 Thread Yuchung Cheng
On Thu, Mar 17, 2016 at 4:26 PM, Bendik Rønning Opstad wrote: > > >> diff --git a/Documentation/networking/ip-sysctl.txt > >> b/Documentation/networking/ip-sysctl.txt > >> index 6a92b15..8f3f3bf 100644 > >> --- a/Documentation/networking/ip-sysctl.txt > >> +++

RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-21 Thread Alan Stern
On Mon, 21 Mar 2016 woojung@microchip.com wrote: > > But this leaves open the issue that querying the device too often will > > prevent it from going into autosuspend. It seems to me that the best > > way to deal with this is to make sure that the autosuspend timeout is > > shorter than the

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-21 Thread Oliver Neukum
On Mon, 2016-03-21 at 14:24 -0400, Alan Stern wrote: > On Mon, 21 Mar 2016, Oliver Neukum wrote: > > > On Mon, 2016-03-21 at 10:57 -0400, Alan Stern wrote: > > > > > One possible solution is to export a sysfs parameter to prevent > > > statistics collection (or more generally, to change the

Re: [iproute PATCH v2 4/4] tc/p_ip.c: Lint through checkpatch.pl

2016-03-21 Thread Stephen Hemminger
On Wed, 2 Mar 2016 18:45:43 + Phil Sutter wrote: > This diff was generated by using the fix-inplace option of checkpatch.pl > and breaking the overlong lines of parse_ip() and parse_ip6() > signatures. > > Signed-off-by: Phil Sutter You need to resubmit this

Re: [patch iproute2 2/2] add devlink tool

2016-03-21 Thread Stephen Hemminger
On Tue, 15 Mar 2016 15:43:49 +0100 Jiri Pirko wrote: > From: Jiri Pirko > > Add new tool called devlink which is userspace counterpart of devlink > Netlink socket. > > Signed-off-by: Jiri Pirko Lots of checkpatch issues. ERROR: code

Re: [PATCH net-next 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-03-21 Thread David Miller
From: Jiri Pirko Date: Tue, 15 Mar 2016 09:24:17 +0100 > Tue, Mar 15, 2016 at 09:08:44AM CET, ro...@cumulusnetworks.com wrote: >>Apart from the usability concern i have described earlier, this just seems an >>overkill ...having to redefine every attribute. > > I don't hear

Re: [PATCH] ipv6: remove unused in6_addr struct

2016-03-21 Thread Luis de Bethencourt
On 21/03/16 18:13, David Miller wrote: > From: Luis de Bethencourt > Date: Mon, 21 Mar 2016 17:37:28 + > >> struct in6_addr isn't used anymore in inet6_connection_sock.h, removing >> the forward declaration. >> >> Fixes: 1b33bc3e9e90 ("ipv6: remove obsolete inet6

RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-21 Thread Woojung.Huh
> But this leaves open the issue that querying the device too often will > prevent it from going into autosuspend. It seems to me that the best > way to deal with this is to make sure that the autosuspend timeout is > shorter than the interal between queries, not to make the querying >

Re: linux-next: Tree for Mar 21 (openvswitch)

2016-03-21 Thread Randy Dunlap
On 03/20/16 21:13, Stephen Rothwell wrote: > Hi all, > > Please do not add any v4.7 related material to your linux-next included > trees until after v4.6-rc1 is released. > > Changes since 20160318: > on i386: ERROR: "nf_nat_icmp_reply_translation" [net/openvswitch/openvswitch.ko] undefined!

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-21 Thread Alan Stern
On Mon, 21 Mar 2016, Oliver Neukum wrote: > On Mon, 2016-03-21 at 10:57 -0400, Alan Stern wrote: > > > One possible solution is to export a sysfs parameter to prevent > > statistics collection (or more generally, to change the interval at > > which it occurs). > > Surely, not performing a

Re: [PATCH] ipv6: remove unused in6_addr struct

2016-03-21 Thread David Miller
From: Luis de Bethencourt Date: Mon, 21 Mar 2016 17:37:28 + > struct in6_addr isn't used anymore in inet6_connection_sock.h, removing > the forward declaration. > > Fixes: 1b33bc3e9e90 ("ipv6: remove obsolete inet6 functions") > Signed-off-by: Luis de Bethencourt

[ethtool PATCH v6 1/2] ethtool.c: add support for ETHTOOL_xLINKSETTINGS ioctls

2016-03-21 Thread David Decotigny
From: David Decotigny More info with kernel commit 8d3f2806f8fb ("Merge branch 'ethtool-ksettings'"). Note: The new features implemented in this patch depend on kernel commit 793cf87de9d1 ("Set cmd field in ETHTOOL_GLINKSETTINGS response to wrong nwords"). Signed-off-by:

[ethtool PATCH v6 2/2] ethtool: use netlink socket when AF_INET not available

2016-03-21 Thread David Decotigny
From: David Decotigny Signed-off-by: David Decotigny --- configure.ac | 2 +- ethtool.c| 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 3105415..47d2a0f 100644 --- a/configure.ac +++

[PATCH] ipv6: remove unused in6_addr struct

2016-03-21 Thread Luis de Bethencourt
struct in6_addr isn't used anymore in inet6_connection_sock.h, removing the forward declaration. Fixes: 1b33bc3e9e90 ("ipv6: remove obsolete inet6 functions") Signed-off-by: Luis de Bethencourt --- include/net/inet6_connection_sock.h | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH] net: phy: at803x: Add support to control PHY LEDs

2016-03-21 Thread Vishal Thanki
Hi, On Thu, Mar 17, 2016 at 07:07:12PM +0100, Vishal Thanki wrote: > > > > They might not be on/off controllable individually, but you can often > > set them to show Packet RX, Packet TX, Link, speed, etc, in a > > reasonably flexible way. So you could have LED triggers mapping to > > these

Re: [PATCH net 0/2] net: propagate max_gso_segs and max_gso_size

2016-03-21 Thread David Miller
From: Eric Dumazet Date: Mon, 21 Mar 2016 09:55:09 -0700 > bridge code does not properly update max_gso_segs and max_gso_size. > > Since this was not really obvious, first patch adds two new rtnetlink > attributes to help debugging this kind of issues (ip -d link) > >

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-21 Thread Oliver Neukum
On Mon, 2016-03-21 at 10:57 -0400, Alan Stern wrote: > One possible solution is to export a sysfs parameter to prevent > statistics collection (or more generally, to change the interval at > which it occurs). Surely, not performing a task can hardly be beaten in terms of power consumption.

Re: [PATCH net v2] vxlan: fix too large pskb_may_pull with remote checksum

2016-03-21 Thread David Miller
From: Jiri Benc Date: Mon, 21 Mar 2016 17:50:05 +0100 > vxlan_remcsum is called after iptunnel_pull_header and thus the skb has > vxlan header already pulled. Don't include vxlan header again in the > calculation. > > Signed-off-by: Jiri Benc Applied,

Re: [PATCH net] vxlan: fix sparse warnings

2016-03-21 Thread David Miller
From: Jiri Benc Date: Mon, 21 Mar 2016 17:39:18 +0100 > Sparse reports false positives for the header manipulation inlines. Annotate > them correctly. > > Tested by sparse on a little endian and big endian machine. > > Fixes: 54bfd872bf16d ("vxlan: keep flags and vni in

[PATCH net-next v2 0/2] basic ioctl support for netlink sockets

2016-03-21 Thread David Decotigny
From: David Decotigny This removes the requirement that ethtool be tied to the support of a specific L3 protocol, also updates a comment. History: v2 updated commit description for the netlink ioctl patch v1 initial submission

[PATCH net-next v2 1/2] ethtool: minor doc update

2016-03-21 Thread David Decotigny
From: David Decotigny Updates: commit 793cf87de9d1 ("ethtool: Set cmd field in ETHTOOL_GLINKSETTINGS response to wrong nwords") Signed-off-by: David Decotigny --- include/uapi/linux/ethtool.h | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH net-next v2 2/2] netlink: add support for NIC driver ioctls

2016-03-21 Thread David Decotigny
From: David Decotigny By returning -ENOIOCTLCMD, sock_do_ioctl() falls back to calling dev_ioctl(), which provides support for NIC driver ioctls, which includes ethtool support. This is similar to the way ioctls are handled in udp.c or tcp.c. This removes the requirement

Re: [PATCH] ipv6: Fix the pmtu path for connected UDP socket

2016-03-21 Thread Wei Wang
Hey Cong, This solution probably will not work. First of all, if you look into __ip6_rt_update_pmtu(), it creates a new dst and this dst does not get passed back to its caller. So unless we tweak this function to pass the new dst back, we can only update sk->sk_dst_cache inside the function

[PATCH net v2] vxlan: fix too large pskb_may_pull with remote checksum

2016-03-21 Thread Jiri Benc
vxlan_remcsum is called after iptunnel_pull_header and thus the skb has vxlan header already pulled. Don't include vxlan header again in the calculation. Signed-off-by: Jiri Benc --- v2: Changed wording of the patch description to explain where the header is pulled. ---

[PATCH net 1/2] net/rtnetlink: add IFLA_GSO_MAX_SEGS and IFLA_GSO_MAX_SIZE attributes

2016-03-21 Thread Eric Dumazet
It can be useful to report dev->gso_max_segs and dev->gso_max_size so that "ip -d link" can display them to help debugging. For the moment, these attributes are read-only. Signed-off-by: Eric Dumazet Cc: Petri Gynther Cc: Stephen Hemminger

[PATCH net 0/2] net: propagate max_gso_segs and max_gso_size

2016-03-21 Thread Eric Dumazet
bridge code does not properly update max_gso_segs and max_gso_size. Since this was not really obvious, first patch adds two new rtnetlink attributes to help debugging this kind of issues (ip -d link) Second patch fixes bridge code. Eric Dumazet (2): net/rtnetlink: add IFLA_GSO_MAX_SEGS and

[PATCH net 2/2] bridge: update max_gso_segs and max_gso_size

2016-03-21 Thread Eric Dumazet
It can be useful to lower max_gso_segs on NIC with very low number of TX descriptors like bcmgenet. However, this is defeated by bridge since it does not propagate the lower value of max_gso_segs and max_gso_size. Signed-off-by: Eric Dumazet Cc: Petri Gynther

[PATCH 2/2] can: rcar_can: Move Renesas CAN driver to rcar dir

2016-03-21 Thread Ramesh Shanmugasundaram
This patch clubs the Renesas controller drivers in one rcar dir. Signed-off-by: Ramesh Shanmugasundaram --- drivers/net/can/Kconfig | 10 -- drivers/net/can/Makefile | 1 - drivers/net/can/rcar/Kconfig | 10

[PATCH 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-21 Thread Ramesh Shanmugasundaram
This patch adds support for the CAN FD controller found in Renesas R-Car SoCs. The controller operates in CAN FD only mode by default. CAN FD mode supports both Classical CAN & CAN FD frame formats. The controller supports ISO 11898-1:2015 CAN FD format only. This controller supports two

[PATCH v4 0/2] Add CAN FD driver support to r8a7795 SoC

2016-03-21 Thread Ramesh Shanmugasundaram
Hi All, Thanks for the review comments. This patch is based on linux-can-next tag (linux-can-next-for-4.6-20160310) This patch depends on [RFC] [PATCH v4] can: fix handling of unmodifiable configuration options (http://permalink.gmane.org/gmane.linux.can/9148) Changes since v3:

[PATCH net] vxlan: fix sparse warnings

2016-03-21 Thread Jiri Benc
Sparse reports false positives for the header manipulation inlines. Annotate them correctly. Tested by sparse on a little endian and big endian machine. Fixes: 54bfd872bf16d ("vxlan: keep flags and vni in network byte order") Reported-by: kbuild test robot Signed-off-by:

[PATCH] net: add description for len argument of dev_get_phys_port_name

2016-03-21 Thread Luis de Bethencourt
When the function dev_get_phys_port_name was added it missed a description for it's len argument. Adding it. Fixes: db24a9044ee1 ("net: add support for phys_port_name") Signed-off-by: Luis de Bethencourt --- Hi, Noticed this when running make htmldocs. It gives the

Re: [PATCH net] ipv4: fix broadcast packets reception

2016-03-21 Thread Paolo Abeni
On Mon, 2016-03-21 at 11:50 -0400, David Miller wrote: > From: Paolo Abeni > Date: Mon, 21 Mar 2016 16:42:11 +0100 > > > Currently, ingress ipv4 broadcast datagrams are dropped if the > > ingress interface lacks an ipv4 address. This is caused by > > multiple issues: > > > >

Re: [GIT] Networking

2016-03-21 Thread Yishai Hadas
On 3/19/2016 6:42 AM, David Miller wrote: There is a merge conflict against the RDMA tree pull wrt the mlx4 driver, which I don't know how to resolve. Can you please point on the conflict ? is it still open that needs our input ?

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

2016-03-21 Thread Jiri Slaby
Hello, On 03/18/2016, 09:52 PM, Tejun Heo wrote: > On Thu, Mar 17, 2016 at 01:00:13PM +0100, Jiri Slaby wrote: I have not done that yet, but today, I see: destroy_workqueue: name='req_hci0' pwq=88002f590300 wq->dfl_pwq=88002f591e00 pwq->refcnt=2 pwq->nr_active=0

Re: [PATCH net] ipv4: fix broadcast packets reception

2016-03-21 Thread David Miller
From: Paolo Abeni Date: Mon, 21 Mar 2016 16:42:11 +0100 > Currently, ingress ipv4 broadcast datagrams are dropped if the > ingress interface lacks an ipv4 address. This is caused by > multiple issues: > > - in udp_v4_early_demux() ip_check_mc_rcu is invoked even on > bcast

[PATCH net] ipv4: fix broadcast packets reception

2016-03-21 Thread Paolo Abeni
Currently, ingress ipv4 broadcast datagrams are dropped if the ingress interface lacks an ipv4 address. This is caused by multiple issues: - in udp_v4_early_demux() ip_check_mc_rcu is invoked even on bcast packets - ip_route_input_slow() always try to validate the source This patch tries to

Re: [PATCH net 06/10] net: hns: fix return value of the function about rss

2016-03-21 Thread David Miller
From: Yisen Zhuang Date: Mon, 21 Mar 2016 19:06:37 +0800 > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c > b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c > index 3c4a3bc..f3a5e05 100644 > --- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c > +++

Re: [PATCH net 03/10] net: hns: add uc match for debug ports

2016-03-21 Thread David Miller
From: Yisen Zhuang Date: Mon, 21 Mar 2016 19:06:34 +0800 > + (void)hns_mac_set_promisc(mac_cb, (u8)!!en); This cast to void is unnecssary. > +static void hns_gmac_set_uc_match(void *mac_drv, u16 en) > +{ > + struct mac_driver *drv = (struct mac_driver

Re: [PATCH net 01/10] net: hns: bug fix about ping6

2016-03-21 Thread David Miller
From: Yisen Zhuang Date: Mon, 21 Mar 2016 19:06:32 +0800 > From: Kejian Yan > > The current upstreaming code fails to ping other IPv6 net device, because > the enet receives the multicast packets with the src mac addr whick is the

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

2016-03-21 Thread Sebastian Frias
Hi Uwe, On 03/21/2016 02:54 PM, Uwe Kleine-König wrote: >> >> Two things: >> - I suppose that in such hypothetical case the dependency on GPIOLIB >> would be required and thus be there > > I don't agree. There are bugs out there, and maybe the reason is as > simple as "the implementor of the

Re: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue

2016-03-21 Thread Joachim Eastwood
On 21 March 2016 at 13:40, Rob Herring wrote: > On Sat, Mar 19, 2016 at 12:00:22AM +0800, Chen-Yu Tsai wrote: >> Hi, >> >> On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE >> wrote: >> > +- clocks: Must contain a phandle for each entry in

Re: [patch] mdio-sun4i: oops in error handling in probe

2016-03-21 Thread David Miller
From: Dan Carpenter Date: Mon, 21 Mar 2016 12:02:31 +0300 > We could end up dereferencing an error pointer when we call > regulator_disable(). > > Fixes: 4bdcb1dd9feb ('net: Add MDIO bus driver for the Allwinner EMAC') > Signed-off-by: Dan Carpenter

Re: [PATCH] net: smc911x: avoid unused variable warnings

2016-03-21 Thread David Miller
From: Arnd Bergmann Date: Mon, 21 Mar 2016 09:30:59 +0100 > The change to use the generic DMA engine API in the smc911x > driver has led to a harmless warning about unused local variables: > > smsc/smc911x.c: In function 'smc911x_probe': > smsc/smc911x.c:1796:20: error: unused

Re: [PATCH net-next 1/3] net: add the AF_KCM entries to family name tables

2016-03-21 Thread David Miller
Two things wrong with this submission: 1) You need to provide an initial "[PATCH net-next 0/3] ..." header posting explaining at a high level what this patch series is about and how it is implemented and why. 2) The net-next tree is closed at this time because we are in the merge window,

RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-21 Thread Woojung.Huh
> -Original Message- > From: Guenter Roeck [mailto:li...@roeck-us.net] > Sent: Sunday, March 20, 2016 6:59 PM > To: Geert Uytterhoeven; Woojung Huh - C21699; UNGLinuxDriver; David S. > Miller > Cc: Rafael J. Wysocki; netdev@vger.kernel.org; linux-...@vger.kernel.org; >

Re: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-21 Thread Alan Stern
On Mon, 21 Mar 2016, Oliver Neukum wrote: > On Sun, 2016-03-20 at 11:43 +0100, Geert Uytterhoeven wrote: > > If CONFIG_PM=n: > > > > drivers/net/usb/lan78xx.c: In function ‘lan78xx_get_stats64’: > > drivers/net/usb/lan78xx.c:3274: error: ‘struct dev_pm_info’ has no > > member named

RE: [PATCH] lan78xx: Protect runtime_auto check by #ifdef CONFIG_PM

2016-03-21 Thread Woojung.Huh
> -Original Message- > From: Oliver Neukum [mailto:oneu...@suse.com] > Sent: Monday, March 21, 2016 4:36 AM > To: Geert Uytterhoeven > Cc: Woojung Huh - C21699; UNGLinuxDriver; David S. Miller; Guenter Roeck; > Rafael J. Wysocki; netdev@vger.kernel.org; linux-...@vger.kernel.org; >

Re: [PATCH 4/5] ath9k: fix misleading indentation

2016-03-21 Thread Kalle Valo
Arnd Bergmann writes: > A cleanup patch in linux-3.18 moved around some code in the ath9k > driver and left some code to be indented in a misleading way, > made worse by the addition of some new code for p2p mode, as > discovered by a new gcc-6 warning: > >

Re: [PATCH 3/5] ath9k: fix buffer overrun for ar9287

2016-03-21 Thread Kalle Valo
Arnd Bergmann writes: > Code that was added back in 2.6.38 has an obvious overflow > when accessing a static array, and at the time it was added > only a code comment was put in front of it as a reminder > to have it reviewed properly. > > This has not happened, but gcc-6 now

Re: [PATCH net 09/10] net: hns: adds limitation for debug port mtu

2016-03-21 Thread Sergei Shtylyov
Hello. On 03/21/2016 02:06 PM, Yisen Zhuang wrote: From: Kejian Yan If mtu for debug port is set more than 1500, it may cause that packets are dropped by ppe. So maximum value for debug port should be 1500. Signed-off-by: Kejian Yan

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

2016-03-21 Thread Uwe Kleine-König
Hello Sebastian, On Mon, Mar 21, 2016 at 01:48:45PM +0100, Sebastian Frias wrote: > On 03/18/2016 08:12 PM, Uwe Kleine-König wrote: > > On Fri, Mar 18, 2016 at 04:56:21PM +0100, Sebastian Frias wrote: > >> On 03/18/2016 01:54 PM, Uwe Kleine-König wrote: > >>> From a driver perspecitive, it would

Re: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue

2016-03-21 Thread Giuseppe CAVALLARO
On 3/21/2016 11:45 AM, Alexandre Torgue wrote: Hi, 2016-03-18 17:00 GMT+01:00 Chen-Yu Tsai : Hi, On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE wrote: Signed-off-by: Alexandre TORGUE diff --git

Re: [PATCH net-next] net/mlx4_core: Fix backward compatibility on VFs

2016-03-21 Thread Eli Cohen
On Mon, Mar 21, 2016 at 04:02:16PM +1100, Alexey Kardashevskiy wrote: > > After more tries, I found that if for whatever reason mlx4_core > fails to stop while shutting the guest down (last message is > "mlx4_core :00:00.0: mlx4_shutdown was called"), then next time > VF in guest won't start.

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

2016-03-21 Thread Sebastian Frias
Hi Uwe, On 03/18/2016 08:12 PM, Uwe Kleine-König wrote: > Hello Sebastian, > > On Fri, Mar 18, 2016 at 04:56:21PM +0100, Sebastian Frias wrote: >> On 03/18/2016 01:54 PM, Uwe Kleine-König wrote: >>> From a driver perspecitive, it would be nice if devm_gpiod_get_optional >>> returned NULL iff the

Re: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue

2016-03-21 Thread Rob Herring
On Sat, Mar 19, 2016 at 12:00:22AM +0800, Chen-Yu Tsai wrote: > Hi, > > On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE > wrote: > > Signed-off-by: Alexandre TORGUE > > > > diff --git

  1   2   >