On Thu, Mar 24, 2016 at 01:50:30PM +0800, oulijun wrote:
> Hi,
>I am Lijun Ou. I have sent the PATCH v4 of HiSilicon RoCE driver at March
> 22, 2016.
> if you are convenient, please help to review. Welcome to give your reviewing.
Hi Lijun,
Please read whole document which describes how to sub
Hi,
On Wed, Mar 23, 2016 at 10:10:06PM -0700, Tolga Ceylan wrote:
> I apologize for not properly following up on this. I had the
> impression that we did not want to merge my original patch and then I
> also noticed that it fails to keep the hash consistent. Recently, I
> read the follow ups on it
Hi,
I am Lijun Ou. I have sent the PATCH v4 of HiSilicon RoCE driver at March
22, 2016.
if you are convenient, please help to review. Welcome to give your reviewing.
thanks
Lijun Ou
On Mon, Dec 21, 2015 at 12:41 PM, Willy Tarreau wrote:
> On Mon, Dec 21, 2015 at 12:38:27PM -0800, Tom Herbert wrote:
>> On Fri, Dec 18, 2015 at 11:00 PM, Willy Tarreau wrote:
>> > On Fri, Dec 18, 2015 at 06:38:03PM -0800, Eric Dumazet wrote:
>> >> On Fri, 2015-12-18 at 19:58 +0100, Willy Tarreau
2016-03-24 1:38 GMT+08:00, Pablo Neira Ayuso :
> On Thu, Mar 24, 2016 at 12:42:43AM +0800, Baozeng wrote:
>> 2016-03-22 23:27 GMT+08:00 Eric Dumazet :
>> > Untested patch would be :
>> >
>> > diff --git a/net/bridge/netfilter/ebtables.c
>> > b/net/bridge/netfilter/ebtables.c
>> > index 67b2e27999aa
A crash is observed when a decrypted packet is processed in receive
path. get_rps_cpus() tries to dereference the skb->dev fields but it
appears that the device is freed from the poison pattern.
[] get_rps_cpu+0x94/0x2f0
[] netif_rx_internal+0x140/0x1cc
[] netif_rx+0x74/0x94
[] xfrm_input+0x754/0x
On Wed, Mar 23, 2016 at 6:37 PM, Jesse Gross wrote:
> On Wed, Mar 23, 2016 at 11:19 AM, Alexander Duyck
> wrote:
>> On Wed, Mar 23, 2016 at 10:09 AM, Tom Herbert wrote:
>>> Can you add some description about strategy for dealing with ip_id?
>>
>> Yeah. I still need to add more documentation. I
Several bug fixes rolling in, some for changes introduced in this
merge window, and some for problems that have existed for some time:
1) Fix prepare_to_wait() handling in AF_VSOCK, from Claudio Imbrenda.
2) The new DST_CACHE should be a silent config option, from Dave
Jones.
3) inet_current
On Wed, Mar 23, 2016 at 6:43 PM, Jesse Gross wrote:
> On Fri, Mar 18, 2016 at 4:24 PM, Alexander Duyck wrote:
>> In RFC 6864 it is stated that we can essentially ignore the IPv4 ID field
>> if we have not and will not use fragmentation. Such a frame is defined
>> as having the DF flag set to 1,
From: 严海双
Date: Thu, 24 Mar 2016 09:53:33 +0800
> The two changes is dependent, because "pingv6_prot" and
> “pingv6_protosw” must be moved to the behind also, to avoid having
> to declare static “ping_v6_sendmsg” prototypes first.
Agreed, and applied, thank you.
From: Eric Dumazet
Date: Wed, 23 Mar 2016 18:39:57 -0700
> On Thu, 2016-03-24 at 08:45 +0800, Herbert Xu wrote:
>> On Wed, Mar 23, 2016 at 10:29:25AM -0700, Eric Dumazet wrote:
>> >
>> > OK, but before calling netif_rx() are we properly testing dev->flags
>> > IFF_UP status ?
>> >
>> > Otherwise
From: Haiyang Zhang
Date: Wed, 23 Mar 2016 14:54:48 -0700
> Reorder the code in netvsc_sc_open(), so num_sc_offered is only decremented
> after vmbus_open() is called. This avoid pontential race of removing device
> before all channels are setup.
>
> Signed-off-by: Haiyang Zhang
> Reviewed-by:
On Thu, 2016-03-24 at 08:45 +0800, Herbert Xu wrote:
> On Wed, Mar 23, 2016 at 10:29:25AM -0700, Eric Dumazet wrote:
> >
> > OK, but before calling netif_rx() are we properly testing dev->flags
> > IFF_UP status ?
> >
> > Otherwise, we still allow packets being queued after flush_backlog() had
> >
On Fri, Mar 18, 2016 at 4:24 PM, Alexander Duyck wrote:
> In RFC 6864 it is stated that we can essentially ignore the IPv4 ID field
> if we have not and will not use fragmentation. Such a frame is defined
> as having the DF flag set to 1, and the MF and frag_offset as 0. Currently
> for GRO we w
On Wed, Mar 23, 2016 at 11:19 AM, Alexander Duyck
wrote:
> On Wed, Mar 23, 2016 at 10:09 AM, Tom Herbert wrote:
>> Can you add some description about strategy for dealing with ip_id?
>
> Yeah. I still need to add more documentation. I just didn't want to
> get into details on it until we have f
From: Tom Herbert
Date: Wed, 23 Mar 2016 17:28:20 -0700
> On Wed, Mar 23, 2016 at 11:27 AM, David Miller wrote:
>> From: Bjorn Helgaas
>> Date: Wed, 23 Mar 2016 08:45:30 -0500
>>
>>> Fix typos. Capitalize CPU, NAPI, RCU consistently. Align structure
>>> indentation. No functional change inte
On Wed, Mar 23, 2016 at 10:29:25AM -0700, Eric Dumazet wrote:
>
> OK, but before calling netif_rx() are we properly testing dev->flags
> IFF_UP status ?
>
> Otherwise, we still allow packets being queued after flush_backlog() had
> been called.
That's the first thing enqueue_to_backlog tests.
Ch
On Wed, Mar 23, 2016 at 11:27 AM, David Miller wrote:
> From: Bjorn Helgaas
> Date: Wed, 23 Mar 2016 08:45:30 -0500
>
>> Fix typos. Capitalize CPU, NAPI, RCU consistently. Align structure
>> indentation. No functional change intended; only comment and whitespace
>> changes.
>>
>> Signed-off-by
What about something like this:
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index ed44663..21b4102 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -1394,6 +1394,19 @@ static void ip6_rt_update_pmtu(struct dst_entry
*dst, struct sock *sk,
__ip6_rt_update_pmtu(dst, sk, skb ? ipv6_hd
On Wed, 2016-03-23 at 16:17 -0700, Tom Herbert wrote:
> Thanks Eric. Do you think it is reasonable to not use
> SLAB_DESTROY_BY_RCU for UDP since it probably has a much lower
> allocation rate than what we'd see in TCP?
This is absolutely reasonable ;)
On Wed, Mar 23, 2016 at 4:04 PM, Or Gerlitz wrote:
>
> I know there's history here, and in the 4.5 cycle things were much
> worse, but I still wanted to put things in their more precise place,
> if you don't mind.
We'll see how things shape up in the future. Once bitten, twice shy,
as they say.
On Wed, Mar 23, 2016 at 3:59 PM, Eric Dumazet wrote:
> On Wed, 2016-03-23 at 15:36 -0700, Tom Herbert wrote:
>> This patches adds udp6_lib_lookup_skb_noref, udp4_lib_lookup_skb_noref
>> and related support to allow a caller to lookup a UDP socket
>> without automatically taking a reference. The lo
On Wed, Mar 23, 2016 at 4:00 PM, Edward Cree wrote:
> On 23/03/16 22:36, Alexander Duyck wrote:
>> On Wed, Mar 23, 2016 at 2:05 PM, Edward Cree wrote:
>>> I disagree. Surely we should be able to "soft segment" the packet just
>>> before we give it to the physical device, and then tell it to do d
2016-03-23 4:55 GMT+09:00 David Miller :
> From: Yoshihiro Kaneko
> Date: Wed, 23 Mar 2016 00:22:00 +0900
>
>> From: Kazuya Mizuguchi
>>
>> This patch supports the following interrupts.
>>
>> - One interrupt for multiple (timestamp, error, gPTP)
>> - One interrupt for emac
>> - Four interrupts fo
On Wed, Mar 16, 2016 at 7:44 PM, Linus Torvalds
wrote:
> On Wed, Mar 16, 2016 at 10:35 AM, Doug Ledford wrote:
>> On 3/16/2016 1:18 PM, Linus Torvalds wrote:
>>> On Tue, Mar 15, 2016 at 5:58 PM, Stephen Rothwell
>>> wrote:
I fixed it up (see below) and can carry the fix as necessary (no a
On 23/03/16 22:36, Alexander Duyck wrote:
> On Wed, Mar 23, 2016 at 2:05 PM, Edward Cree wrote:
>> I disagree. Surely we should be able to "soft segment" the packet just
>> before we give it to the physical device, and then tell it to do dumb copying
>> of both the VXLAN and IPIP headers? At thi
On Wed, 2016-03-23 at 15:36 -0700, Tom Herbert wrote:
> This patches adds udp6_lib_lookup_skb_noref, udp4_lib_lookup_skb_noref
> and related support to allow a caller to lookup a UDP socket
> without automatically taking a reference. The lookup and caller
> use of the socket must be done under rcu_
Now that the UDP encapsulation GRO functions have been moved to the UDP
socket we not longer need the udp_offload insfrastructure so removing it.
Signed-off-by: Tom Herbert
---
include/linux/netdevice.h | 17 -
include/net/protocol.h| 3 ---
net/ipv4/udp_offload.c| 63 --
This patches adds udp6_lib_lookup_skb_noref, udp4_lib_lookup_skb_noref
and related support to allow a caller to lookup a UDP socket
without automatically taking a reference. The lookup and caller
use of the socket must be done under rcu_read_lock.
This feature will be used in a fast receive encaps
Adapt gue_gro_receive, gue_gro_complete to take a socket argument.
Set the encap_fast flag on fou sockets. Don't set udp_offloads
any more.
Signed-off-by: Tom Herbert
---
net/ipv4/fou.c | 49 ++---
1 file changed, 18 insertions(+), 31 deletions(-)
dif
Add gro_receive, gro_complete and encap_fast to
struct udp_tunnel_sock_cfg.
Signed-off-by: Tom Herbert
---
include/net/udp_tunnel.h | 8
net/ipv4/udp_tunnel.c| 3 +++
2 files changed, 11 insertions(+)
diff --git a/include/net/udp_tunnel.h b/include/net/udp_tunnel.h
index b831140..3
In inet_iif check if skb_rtable is NULL for the skb and return
skb->skb_iif if it is.
This change allows inet_iif to be called before the dst
information has been set in the skb (e.g. when doing socket based
UDP GRO).
Signed-off-by: Tom Herbert
---
include/net/route.h | 7 ---
1 file change
This patch adds GRO functions (gro_receive and gro_complete) to UDP
sockets. udp_gro_receive is changed to perfrom a noref socket lookup
on a packet. If a socket is found the related GRO functions are called.
This features obsoletes using UDP offload infrastructure for GRO
(udp_offload). This has
This patch allows fast receive encapsulation processing. A configuration
flag, encap_fast, may be set in a UDP socket. When this flag is set
encap_rcv may be called without taking a reference to the the
encapsulation socket (which is usually unnecessary since the
encapsulation socket is not written
Adapt vxlan_gro_receive, vxlan_gro_complete to take a socket argument.
Set these functions in tunnel_config. Don't set udp_offloads any more.
Signed-off-by: Tom Herbert
---
drivers/net/vxlan.c | 31 +--
include/net/vxlan.h | 1 -
2 files changed, 9 insertions(+), 23
Adapt geneve_gro_receive, geneve_gro_complete to take a socket argument.
Set these functions in tunnel_config. Don't set udp_offloads any more.
Signed-off-by: Tom Herbert
---
drivers/net/geneve.c | 29 +
1 file changed, 9 insertions(+), 20 deletions(-)
diff --git a/
This patch set does two things:
- Add GRO functions (gro_receive and gro_complete) to UDP sockets.
- Implement "fast receive encapsulation".
Add GRO functions (gro_receive and gro_complete) to UDP sockets. In
udp_gro_receive and udp_gro_complete a socket lookup is done instead of
looking up the p
On Wed, Mar 23, 2016 at 2:05 PM, Edward Cree wrote:
> On 23/03/16 18:06, Alexander Duyck wrote:
>> On Wed, Mar 23, 2016 at 9:27 AM, Edward Cree wrote:
>>> My belief is that my way is (in the long run) simpler: ultimately it gets
>>> rid of per-protocol GSO callbacks entirely. Every header gets w
On March 23, 2016 1:01:28 PM PDT, Petri Gynther wrote:
>1. Add bytes_compl local variable to collect transmitted bytes
> - dev->stats updates can then be moved outside the while-loop
> - bytes_compl is also needed for future BQL support
>2. When bcmgenet device uses Tx checksum offload, each t
On March 23, 2016 1:01:28 PM PDT, Petri Gynther wrote:
>1. Add bytes_compl local variable to collect transmitted bytes
> - dev->stats updates can then be moved outside the while-loop
> - bytes_compl is also needed for future BQL support
>2. When bcmgenet device uses Tx checksum offload, each t
Hello Linus,
Here are the target-pending for-next-merge updates for v4.6-rc1.
Please go ahead and pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
for-next-merge
You'll hit one minor merge conflict in t4fw_api.h with net-next as
reported by SFR:
https://lkml.o
On March 23, 2016 2:23:57 PM PDT, Eric Dumazet wrote:
>On Wed, 2016-03-23 at 13:01 -0700, Petri Gynther wrote:
>> 1. Add bytes_compl local variable to collect transmitted bytes
>>- dev->stats updates can then be moved outside the while-loop
>>- bytes_compl is also needed for future BQL sup
On Wed, Mar 23, 2016 at 10:10 PM, Andrew Lunn wrote:
> On Wed, Mar 23, 2016 at 09:24:00PM +0100, Vishal Thanki wrote:
>> Hi,
>>
>> > My suggestion was that the hardware needs to control the LEDs. You
>> > have software doing it. You might be able to do this with the PHY
>> > state machine for link
On Wed, 2016-03-23 at 13:01 -0700, Petri Gynther wrote:
> skb_len needs to be skb_headlen(skb) in bcmgenet_xmit_single().
>
> Fragmented skbs can have only Ethernet + IP + TCP headers (14+20+20=54 bytes)
> in the linear buffer, followed by the rest in fragments. Bumping skb_len to
> ETH_ZLEN would
Hi,
Our Stock list.
Brand NEW
96 x Cisco 7900 IP Phone
87 x Unified IP Phone 6900
12 x Unified IP Phone 8900
76 x Unified IP Phone 9900
55 x Unified IP Phone 8800
67 x Cisco 1921
67 x Cisco 1941
56 x Cisco CP-7961G 7961G
34 x Cisco CP-7971G-GE 7971G
19 x Cisco Unified IP Conference Station 7937G
On Wed, 2016-03-23 at 13:01 -0700, Petri Gynther wrote:
> 1. Add bytes_compl local variable to collect transmitted bytes
>- dev->stats updates can then be moved outside the while-loop
>- bytes_compl is also needed for future BQL support
> 2. When bcmgenet device uses Tx checksum offload, ea
On Wed, Mar 23, 2016 at 09:24:00PM +0100, Vishal Thanki wrote:
> Hi,
>
> > My suggestion was that the hardware needs to control the LEDs. You
> > have software doing it. You might be able to do this with the PHY
> > state machine for link. But activity is never going to be accepted if
> > software
On 23/03/16 18:06, Alexander Duyck wrote:
> On Wed, Mar 23, 2016 at 9:27 AM, Edward Cree wrote:
>> My belief is that my way is (in the long run) simpler: ultimately it gets
>> rid of per-protocol GSO callbacks entirely. Every header gets written
>> correctly* when the packet initially traverses t
Hi,
> My suggestion was that the hardware needs to control the LEDs. You
> have software doing it. You might be able to do this with the PHY
> state machine for link. But activity is never going to be accepted if
> software control.
>
> The LED trigger attached to an LED should be used to configur
On Wed, Mar 23, 2016 at 12:35 PM, Jesse Gross wrote:
> On Fri, Mar 18, 2016 at 4:25 PM, Alexander Duyck wrote:
>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
>> b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> index 39b0009253c2..ac3964a9f5c0 100644
>> --- a/drivers/net/ethernet/int
Reorder the code in netvsc_sc_open(), so num_sc_offered is only decremented
after vmbus_open() is called. This avoid pontential race of removing device
before all channels are setup.
Signed-off-by: Haiyang Zhang
Reviewed-by: K. Y. Srinivasan
---
drivers/net/hyperv/rndis_filter.c | 12 ++-
skb_len needs to be skb_headlen(skb) in bcmgenet_xmit_single().
Fragmented skbs can have only Ethernet + IP + TCP headers (14+20+20=54 bytes)
in the linear buffer, followed by the rest in fragments. Bumping skb_len to
ETH_ZLEN would be incorrect for this case, as it would introduce garbage
between
1. Add bytes_compl local variable to collect transmitted bytes
- dev->stats updates can then be moved outside the while-loop
- bytes_compl is also needed for future BQL support
2. When bcmgenet device uses Tx checksum offload, each transmitted
skb has an extra 64-byte header prepended to i
Hello.
On 03/23/2016 01:49 PM, Sebastian Frias wrote:
This removes the dependency on GPIOLIB for non faulty PHYs.
Indeed, without this patch, if GPIOLIB is not selected
devm_gpiod_get_optional() will return -ENOSYS and the driver probe
call will fail, regardless of the actual PHY hardware.
Ou
On Fri, Mar 18, 2016 at 4:25 PM, Alexander Duyck wrote:
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
> b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index 39b0009253c2..ac3964a9f5c0 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/
From: Bjorn Helgaas
Date: Wed, 23 Mar 2016 13:47:23 -0500
> Fix typos. Capitalize CPU, NAPI, RCU consistently. Align structure
> indentation. No functional change intended; only comment and whitespace
> changes.
>
> Signed-off-by: Bjorn Helgaas
Applied, thank you.
On Wed, Mar 23, 2016 at 06:51:39PM +0100, Vishal Thanki wrote:
> Expose these LEDs by means of a platform device which
> can be controlled by a suitable LED driver.
I would expose the leds directly here in this driver, not via a
separate platform device.
Andrew
> +static void at803x_led_work(struct work_struct *work)
> +{
> + struct at803x_phy_led *led =
> + container_of(work, struct at803x_phy_led, work);
> + union at803x_led_manual_ctrl regval = led->regval;
> +
> + phy_write(led->led_grp->phydev, led->reg, regval.value);
> +}
>
On Wed, Mar 23, 2016 at 06:51:37PM +0100, Vishal Thanki wrote:
> Hi all,
>
> Based on suggestions from Andrew and Florian, I have made some changes
> to expose the ethernet PHY LEDs using kernel LED subsystem. The following
> ALPHA patchset introduces two new LED triggers:
>
> 1) -eth-phy-link:
>
Fix typos. Capitalize CPU, NAPI, RCU consistently. Align structure
indentation. No functional change intended; only comment and whitespace
changes.
Signed-off-by: Bjorn Helgaas
---
include/linux/netdevice.h | 215 ++---
1 file changed, 106 insertions(+
From: Andrew Lunn
Date: Wed, 23 Mar 2016 17:51:11 +0100
> On Wed, Mar 23, 2016 at 05:37:38PM +0100, Arnd Bergmann wrote:
>> dev_dbg_ratelimited() is a macro that ignores its arguments when DEBUG is
>> not set, which can lead to unused variable warnings:
>>
>> ethernet/mellanox/mlxsw/pci.c: In fu
From: Guillaume Nault
Date: Wed, 23 Mar 2016 16:38:55 +0100
> Let channels hold a reference on their network namespace.
> Some channel types, like ppp_async and ppp_synctty, can have their
> userspace controller running in a different namespace. Therefore they
> can't rely on them to preclude the
On Wed, 2016-03-23 at 14:25 -0400, David Miller wrote:
> From: Eric Dumazet
> Date: Tue, 22 Mar 2016 19:33:52 -0700
>
> > On Wed, 2016-03-23 at 09:35 +0800, Haishuang Yan wrote:
> >> vlan drivers lack proper propagation of gso_min_segs from lower device.
> >>
> >> Signed-off-by: Haishuang Yan
>
From: Bjorn Helgaas
Date: Wed, 23 Mar 2016 08:45:30 -0500
> Fix typos. Capitalize CPU, NAPI, RCU consistently. Align structure
> indentation. No functional change intended; only comment and whitespace
> changes.
>
> Signed-off-by: Bjorn Helgaas
Does not apply to the current 'net' tree, plea
From: Eric Dumazet
Date: Tue, 22 Mar 2016 19:33:52 -0700
> On Wed, 2016-03-23 at 09:35 +0800, Haishuang Yan wrote:
>> vlan drivers lack proper propagation of gso_min_segs from lower device.
>>
>> Signed-off-by: Haishuang Yan
>> ---
>
> The plan was to get rid of gso_min_segs, as nothing uses i
From: Haishuang Yan
Date: Wed, 23 Mar 2016 09:34:43 +0800
> Dropped skb's should be documented by an appropriate return value.
> Use the correct NET_RX_DROP and NET_RX_SUCCESS values for that reason.
>
> Signed-off-by: Haishuang Yan
IP protocol handlers do not use NET_RX_* values like this.
T
From: Alexander Duyck
Date: Tue, 22 Mar 2016 16:18:07 -0700
> This patch corrects an oversight in which we were allowing the encap_level
> value to pass from the outer headers to the inner headers. As a result we
> were incorrectly identifying UDP or GRE tunnels as also making use of ipip
> or s
On Wed, Mar 23, 2016 at 10:09 AM, Tom Herbert wrote:
> On Fri, Mar 18, 2016 at 4:25 PM, Alexander Duyck wrote:
>> This patch adds support for something I am referring to as GSO partial.
>> The basic idea is that we can support a broader range of devices for
>> segmentation if we use fixed outer h
On Wed, Mar 23, 2016 at 9:27 AM, Edward Cree wrote:
> On 22/03/16 21:38, Alexander Duyck wrote:
>> On Tue, Mar 22, 2016 at 12:40 PM, Edward Cree wrote:
>>> But won't the tunnel dev have the feature flag for GSO_PARTIAL depending
>>> on what the underlying dev advertises? (Or, at least, could we
Expose these LEDs by means of a platform device which
can be controlled by a suitable LED driver.
Signed-off-by: Vishal Thanki
---
drivers/net/phy/at803x.c | 55 +-
include/linux/phy/at803x.h | 45 +
2 files change
Add the LED triggers for ethernet PHY link and activity
status. The triggers are set mainly based on the
PHY state machine.
Signed-off-by: Vishal Thanki
---
drivers/net/phy/Kconfig | 7 +
drivers/net/phy/Makefile | 1 +
drivers/net/phy/phy.c| 20 +++--
drivers/net/
Hi all,
Based on suggestions from Andrew and Florian, I have made some changes
to expose the ethernet PHY LEDs using kernel LED subsystem. The following
ALPHA patchset introduces two new LED triggers:
1) -eth-phy-link:
To monitor the PHY Link status
2) -eth-phy-activity:
To monitor the PHY activ
This patch adds support for controlling the Link and
Activity LED of AT8030 ethernet PHY through LED subsystem.
Signed-off-by: Vishal Thanki
---
drivers/leds/Kconfig | 7 ++
drivers/leds/Makefile | 1 +
drivers/leds/leds-at803x.c | 158 +
From: Vladimir Zapolskiy
Date: Wed, 23 Mar 2016 01:06:04 +0200
> devm_ioremap_resource() returns ERR_PTR() value on error, it never
> returns NULL, fix it and propagate the returned error upwards.
>
> Fixes: 656e705243fd ("net-next: mediatek: add support for MT7623 ethernet")
> Signed-off-by: Vl
Such cleanups and tidies are not appropriate to be submitted at this time.
Only bug fixes should be going into the tree right now.
From: Sebastian Frias
Date: Wed, 23 Mar 2016 11:49:09 +0100
> This removes the dependency on GPIOLIB for non faulty PHYs.
>
> Indeed, without this patch, if GPIOLIB is not selected
> devm_gpiod_get_optional() will return -ENOSYS and the driver probe
> call will fail, regardless of the actual PHY
From: Sergei Shtylyov
Date: Wed, 23 Mar 2016 00:44:40 +0300
> The driver of course "knows" that the chip's reset signal is active low,
> so it drives the GPIO to 0 to reset the PHY and to 1 otherwise; however
> all this will only work iff the GPIO is specified as active-high in the
> device t
On Thu, Mar 24, 2016 at 12:42:43AM +0800, Baozeng wrote:
> 2016-03-22 23:27 GMT+08:00 Eric Dumazet :
> > Untested patch would be :
> >
> > diff --git a/net/bridge/netfilter/ebtables.c
> > b/net/bridge/netfilter/ebtables.c
> > index 67b2e27999aa..fceb7354d169 100644
> > --- a/net/bridge/netfilter/e
If dl2k is modified at all, maybe convert the
printks to netdev_ too so that the logging
output is more like other networking drivers.
Something like:
---
drivers/net/ethernet/dlink/dl2k.c | 181 +-
1 file changed, 100 insertions(+), 81 deletions(-)
diff --git
On Wed, 2016-03-23 at 21:29 +0800, Herbert Xu wrote:
> On Wed, Mar 23, 2016 at 06:25:47AM -0700, Eric Dumazet wrote:
> >
> > Wont this prevent device from being dismantled ?
>
> This is only held while the crypto processing is ongoing.
>
> > Where is this xfrm queue purged at device dismantle ?
>
On Tue, Mar 22, 2016 at 4:18 PM, Alexander Duyck wrote:
> This patch corrects an oversight in which we were allowing the encap_level
> value to pass from the outer headers to the inner headers. As a result we
> were incorrectly identifying UDP or GRE tunnels as also making use of ipip
> or sit wh
On 03/23/2016 03:55 PM, Bjorn Helgaas wrote:
[+cc Vlad]
On Wed, Mar 23, 2016 at 08:45:30AM -0500, Bjorn Helgaas wrote:
Fix typos. Capitalize CPU, NAPI, RCU consistently. Align structure
indentation. No functional change intended; only comment and whitespace
changes.
Signed-off-by: Bjorn H
On Thu, 2016-03-24 at 00:42 +0800, Baozeng wrote:
> Thanks for your quick patch. I tested it but it still reproduce the
> bug. We should limit the length of the name,
> not the prefix. The following patch fixs it.
>
> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
On Fri, Mar 18, 2016 at 4:25 PM, Alexander Duyck wrote:
> This patch adds support for something I am referring to as GSO partial.
> The basic idea is that we can support a broader range of devices for
> segmentation if we use fixed outer headers and have the hardware only
> really deal with segmen
On Wed, Mar 23, 2016 at 05:37:38PM +0100, Arnd Bergmann wrote:
> dev_dbg_ratelimited() is a macro that ignores its arguments when DEBUG is
> not set, which can lead to unused variable warnings:
>
> ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cqe_sdq_handle':
> ethernet/mellanox/mlxsw/pci
2016-03-22 23:27 GMT+08:00 Eric Dumazet :
>
> On Tue, 2016-03-22 at 08:21 -0700, Eric Dumazet wrote:
> > On Tue, 2016-03-22 at 23:08 +0800, Baozeng Ding wrote:
> > > Hi all,
> > >
> > > The following program triggers an out-of-bounds bug in
> > > sctp_getsockopt. The kernel version is 4.5 (on Mar 1
dev_dbg_ratelimited() is a macro that ignores its arguments when DEBUG is
not set, which can lead to unused variable warnings:
ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cqe_sdq_handle':
ethernet/mellanox/mlxsw/pci.c:646:18: warning: unused variable 'pdev'
[-Wunused-variable]
ethernet/
On 22/03/16 21:38, Alexander Duyck wrote:
> On Tue, Mar 22, 2016 at 12:40 PM, Edward Cree wrote:
>> But won't the tunnel dev have the feature flag for GSO_PARTIAL depending
>> on what the underlying dev advertises? (Or, at least, could we make it
>> bethatway?)
> This stuff doesn't work. That is
On Wed, Mar 23, 2016 at 04:38:55PM +0100, Guillaume Nault wrote:
> Let channels hold a reference on their network namespace.
> Some channel types, like ppp_async and ppp_synctty, can have their
> userspace controller running in a different namespace. Therefore they
> can't rely on them to preclude
This commit fixed indent in file. Labels must be start of the line
Signed-off-by: Maxim Zhukov
---
drivers/net/ethernet/dlink/dl2k.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/dlink/dl2k.c
b/drivers/net/ethernet/dlink/dl2k.c
index d
This commit fixed spacing errors and warnings.
this output command git diff origin/master -w drivers/net/ethernet/dlink
diff --git a/drivers/net/ethernet/dlink/dl2k.c
b/drivers/net/ethernet/dlink/dl2k.c
index f92b6d9..e635b1e 100644
--- a/drivers/net/ethernet/dlink/dl2k.c
+++ b/drivers/net/ethern
> The rtl8821ae_dm_txpower_tracking_callback_thermalmeter function
> contains a call to RT_TRACE() that is indented in a misleading
> way, as pointed out by a gcc-6 warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c: In function
> 'rtl8821ae_dm_txpower_tracking_callback_thermalmete
> From: Jia-Ju Bai
>
> The memory allocated by kzalloc in b43_bus_dev_ssb_init and
> b43_bus_dev_bcma_init is not freed.
> This patch fixes the bug by adding kfree in b43_ssb_remove,
> b43_bcma_remove and error handling code of b43_bcma_probe.
>
> Thanks Michael for his suggestion.
>
> Signed-
Let channels hold a reference on their network namespace.
Some channel types, like ppp_async and ppp_synctty, can have their
userspace controller running in a different namespace. Therefore they
can't rely on them to preclude their netns from being removed from
under them.
The VRSS_CHANNEL_MAX is the max number of channels supported by Hyper-V
hosts. We use it for the related array sizes instead of using NR_CPUS,
which may be set to several thousands.
This patch reduces possible memory allocation failures.
Signed-off-by: Haiyang Zhang
Reviewed-by: K. Y. Srinivasan
struct netvsc_device is freed in rndis_filter_device_remove(). So we save
the nvdev->num_chn into a temp variable for later usage.
(Please also include this patch into stable branch.)
Signed-off-by: Haiyang Zhang
Reviewed-by: K. Y. Srinivasan
---
drivers/net/hyperv/netvsc_drv.c |5 -
On Wed, 2016-03-23 at 17:36 +0300, Maxim Zhukov wrote:
> This commit fixed spacing errors and warnings.
This commit log should show that you've tested this
by stating something like:
"git diff -w shows no difference"
and
"objdiff shows no changes"
If objdiff shows changes, you nee
This commit fixed indent in file. Labels must be start of the line
Signed-off-by: Maxim Zhukov
---
drivers/net/ethernet/dlink/dl2k.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/dlink/dl2k.c
b/drivers/net/ethernet/dlink/dl2k.c
index d
This commit fixed spacing errors and warnings.
Signed-off-by: Maxim Zhukov
---
drivers/net/ethernet/dlink/dl2k.c | 491 +++---
1 file changed, 245 insertions(+), 246 deletions(-)
diff --git a/drivers/net/ethernet/dlink/dl2k.c
b/drivers/net/ethernet/dlink/dl2k.c
[+cc Vlad]
On Wed, Mar 23, 2016 at 08:45:30AM -0500, Bjorn Helgaas wrote:
> Fix typos. Capitalize CPU, NAPI, RCU consistently. Align structure
> indentation. No functional change intended; only comment and whitespace
> changes.
>
> Signed-off-by: Bjorn Helgaas
> ---
> include/linux/netdevice
1 - 100 of 128 matches
Mail list logo
