Re: [PATCHv2 net-next 4/6] sctp: add the sctp_diag.c file

2016-04-08 Thread Eric Dumazet
On Sat, 2016-04-09 at 12:53 +0800, Xin Long wrote: > This one will implement all the interface of inet_diag, inet_diag_handler. > which includes sctp_diag_dump, sctp_diag_dump_one and sctp_diag_get_info. > +static int inet_assoc_diag_fill(struct sock *sk, > + struct

[PATCH net-next] net: bcmgenet: use __napi_schedule_irqoff()

2016-04-08 Thread Eric Dumazet
From: Florian Fainelli bcmgenet_isr1() and bcmgenet_isr0() run in hard irq context, we do not need to block irq again. Signed-off-by: Florian Fainelli Signed-off-by: Eric Dumazet ---

Re: [PATCH net-next] net: bcmgenet: use napi_complete_done()

2016-04-08 Thread Eric Dumazet
On Fri, 2016-04-08 at 22:19 -0700, Florian Fainelli wrote: > Along the same line of changes, we could use napi_schedule_irqoff since NAPI > is always scheduled from ISR context. Good point, I'll cook the patch ;) Thanks !

Re: [PATCH net-next] net: bcmgenet: use napi_complete_done()

2016-04-08 Thread Florian Fainelli
On April 8, 2016 10:06:40 PM PDT, Eric Dumazet wrote: >From: Eric Dumazet > >By using napi_complete_done(), we allow fine tuning >of /sys/class/net/ethX/gro_flush_timeout for higher GRO aggregation >efficiency for a Gbit NIC. > >Check commit

Re: [PATCHv2 net-next 1/6] sctp: add sctp_info dump api for sctp_diag

2016-04-08 Thread Eric Dumazet
On Sat, 2016-04-09 at 12:53 +0800, Xin Long wrote: > sctp_diag will dump some important details of sctp's assoc or ep, we use > sctp_info to describe them, sctp_get_sctp_info to get them, and export > it to sctp_diag.ko. > > +int sctp_get_sctp_info(struct sock *sk, struct sctp_association

Re: [PATCHv2 net-next 1/6] sctp: add sctp_info dump api for sctp_diag

2016-04-08 Thread Eric Dumazet
On Sat, 2016-04-09 at 12:53 +0800, Xin Long wrote: > sctp_diag will dump some important details of sctp's assoc or ep, we use > sctp_info to describe them, sctp_get_sctp_info to get them, and export > it to sctp_diag.ko. > > Signed-off-by: Xin Long > --- >

[GIT] Networking

2016-04-08 Thread David Miller
1) Stale SKB data pointer access across pskb_may_pull() calls in L2TP, from Haishuang Yan. 2) Fix multicast frame handling in mac80211 AP code, from Felix Fietkau. 3) mac80211 station hashtable insert errors not handled properly, fix from Johannes Berg. 4) Fix TX descriptor count

[PATCH net-next] net: bcmgenet: use napi_complete_done()

2016-04-08 Thread Eric Dumazet
From: Eric Dumazet By using napi_complete_done(), we allow fine tuning of /sys/class/net/ethX/gro_flush_timeout for higher GRO aggregation efficiency for a Gbit NIC. Check commit 24d2e4a50737 ("tg3: use napi_complete_done()") for details. Signed-off-by: Eric Dumazet

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Eric Dumazet
On Fri, 2016-04-08 at 21:13 -0700, Petri Gynther wrote: > What values does the networking core program into BQL dynamic limits > that my code in netdev->ndo_open() would wipe out? > 0 and 0 Clearing again these values by 0 and 0 is defensive programming. As I said, no BQL enabled driver does

[PATCHv2 net-next 6/6] sctp: fix some rhashtable functions using in sctp proc/diag

2016-04-08 Thread Xin Long
When rhashtable_walk_init return err, no release function should be called, and when rhashtable_walk_start return err, we should only invoke rhashtable_walk_exit to release the source. But now when sctp_transport_walk_start return err, we just call rhashtable_walk_stop/exit, and never care about

[PATCHv2 net-next 3/6] sctp: export some functions for sctp_diag in inet_diag

2016-04-08 Thread Xin Long
inet_diag_msg_common_fill is used to fill the diag msg common info, we need to use it in sctp_diag as well, so export it. We also add inet_diag_get_handler() to access inet_diag_table in sctp diag. Signed-off-by: Xin Long --- net/ipv4/inet_diag.c | 9 - 1 file

[PATCHv2 net-next 5/6] sctp: merge the seq_start/next/exits in remaddrs and assocs

2016-04-08 Thread Xin Long
In sctp proc, these three functions in remaddrs and assocs are the same. we should merge them into one. Signed-off-by: Xin Long --- net/sctp/proc.c | 45 + 1 file changed, 9 insertions(+), 36 deletions(-) diff --git

[PATCHv2 net-next 4/6] sctp: add the sctp_diag.c file

2016-04-08 Thread Xin Long
This one will implement all the interface of inet_diag, inet_diag_handler. which includes sctp_diag_dump, sctp_diag_dump_one and sctp_diag_get_info. It will work as a modules, and register inet_diag_handler when loading. Signed-off-by: Xin Long ---

[PATCHv2 net-next 1/6] sctp: add sctp_info dump api for sctp_diag

2016-04-08 Thread Xin Long
sctp_diag will dump some important details of sctp's assoc or ep, we use sctp_info to describe them, sctp_get_sctp_info to get them, and export it to sctp_diag.ko. Signed-off-by: Xin Long --- include/linux/sctp.h| 65 +

[PATCHv2 net-next 0/6] sctp: support sctp_diag in kernel

2016-04-08 Thread Xin Long
This patchset will add sctp_diag module to implement diag interface on sctp in kernel. For a listening sctp endpoint, we will just dump it's ep info. For a sctp connection, we will the assoc info and it's ep info. The ss dump will looks like: [iproute2]# ./misc/ss --sctp -n -l State

[PATCHv2 net-next 2/6] sctp: export some apis or variables for sctp_diag and reuse some for proc

2016-04-08 Thread Xin Long
For some main variables in sctp.ko, we couldn't export it to other modules, so we have to define some api to access them. It will include sctp transport and endpoint's traversal. There are some transport traversal functions for sctp_diag, we can also use it for sctp_proc. cause they have the

Re: [PATCH net-next] ibmvnic: Enable use of multiple tx/rx scrqs

2016-04-08 Thread David Miller
From: John Allen Date: Wed, 6 Apr 2016 11:49:55 -0500 > Enables the use of multiple transmit and receive scrqs allowing the ibmvnic > driver to take advantage of multiqueue functionality. To achieve this, the > driver must implement the process of negotiating the

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Petri Gynther
On Fri, Apr 8, 2016 at 6:56 PM, Eric Dumazet wrote: > On Fri, 2016-04-08 at 18:39 -0700, Petri Gynther wrote: >> On Fri, Apr 8, 2016 at 1:36 PM, David Miller wrote: >> > From: Petri Gynther >> > Date: Tue, 5 Apr 2016 17:50:01

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Alexander Duyck
On Fri, Apr 8, 2016 at 6:56 PM, Eric Dumazet wrote: > On Fri, 2016-04-08 at 18:39 -0700, Petri Gynther wrote: >> On Fri, Apr 8, 2016 at 1:36 PM, David Miller wrote: >> > From: Petri Gynther >> > Date: Tue, 5 Apr 2016 17:50:01

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Eric Dumazet
On Fri, 2016-04-08 at 18:39 -0700, Petri Gynther wrote: > On Fri, Apr 8, 2016 at 1:36 PM, David Miller wrote: > > From: Petri Gynther > > Date: Tue, 5 Apr 2016 17:50:01 -0700 > > > >> Add Byte Queue Limits (BQL) support to bcmgenet driver. > >> > >>

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Petri Gynther
On Fri, Apr 8, 2016 at 1:36 PM, David Miller wrote: > From: Petri Gynther > Date: Tue, 5 Apr 2016 17:50:01 -0700 > >> Add Byte Queue Limits (BQL) support to bcmgenet driver. >> >> Signed-off-by: Petri Gynther > > As Eric Dumazet

RE: [PATCH -v2] drivers: net: ethernet: intel: e1000e: fix ethtool autoneg off for non-copper

2016-04-08 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Daniel Walker > Sent: Tuesday, April 5, 2016 11:30 AM > To: Ruinskiy, Dima ; Kirsher, Jeffrey T > ; Brandeburg, Jesse > ;

Re: How do I avoid recvmsg races with IP_RECVERR?

2016-04-08 Thread Andy Lutomirski
On Tue, Jun 2, 2015 at 5:33 PM, Hannes Frederic Sowa wrote: > On Wed, Jun 3, 2015, at 02:03, Andy Lutomirski wrote: >> On Tue, Jun 2, 2015 at 2:50 PM, Hannes Frederic Sowa >> wrote: >> >> My proposal would be to make the error conversion

Re: [PATCH net-next v2] vxlan: synchronously and race-free destruction of vxlan sockets

2016-04-08 Thread Hannes Frederic Sowa
On Sat, Apr 9, 2016, at 01:24, Cong Wang wrote: > On Fri, Apr 8, 2016 at 1:55 PM, Hannes Frederic Sowa > wrote: > > Due to the fact that the udp socket is destructed asynchronously in a > > work queue, we have some nondeterministic behavior during shutdown of > >

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

2016-04-08 Thread Bjorn Andersson
On Fri 08 Apr 16:01 PDT 2016, Timur Tabi wrote: > Bjorn Andersson wrote: > > >It sounds like you're trying to say that the pins used can be are > >muxed as GPIO or MDIO, in the TLMM. > > I'm not 100% sure, but I think that's correct. If you don't want to have > normal networking, you could

Re: [PATCH net-next v2] vxlan: synchronously and race-free destruction of vxlan sockets

2016-04-08 Thread Cong Wang
On Fri, Apr 8, 2016 at 1:55 PM, Hannes Frederic Sowa wrote: > Due to the fact that the udp socket is destructed asynchronously in a > work queue, we have some nondeterministic behavior during shutdown of > vxlan tunnels and creating new ones. Fix this by keeping the

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

2016-04-08 Thread Timur Tabi
Bjorn Andersson wrote: It sounds like you're trying to say that the pins used can be are muxed as GPIO or MDIO, in the TLMM. I'm not 100% sure, but I think that's correct. If you don't want to have normal networking, you could connect those external pins to some GPIO device (like an LED or

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

2016-04-08 Thread Bjorn Andersson
On Fri, Apr 8, 2016 at 12:06 PM, Timur Tabi wrote: > Andrew Lunn wrote: > >> There are two different things here. One is configuring the pin to be >> a GPIO. The second is using the GPIO as a GPIO. In this case, >> bit-banging the MDIO bus. >> >> The firmware could be doing

[PATCH iproute2 -master 1/3] tc, bpf: add new csum and tunnel signatures

2016-04-08 Thread Daniel Borkmann
Add new signatures for BPF_FUNC_csum_diff, BPF_FUNC_skb_get_tunnel_opt and BPF_FUNC_skb_set_tunnel_opt. Signed-off-by: Daniel Borkmann --- include/bpf_api.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/bpf_api.h b/include/bpf_api.h index

[PATCH iproute2 -master 2/3] tc, bpf: further improve error reporting

2016-04-08 Thread Daniel Borkmann
Make it easier to spot issues when loading the object file fails. This includes reporting in what pinned object specs differ, better indication when we've reached instruction limits. Don't retry to load a non relo program once we failed with bpf(2), and report out of bounds tail call key. Also,

[PATCH iproute2 -master 0/3] Minor tc/bpf updates

2016-04-08 Thread Daniel Borkmann
Some minor updates to improve error reporting, add signatures and recently introduced map flags attribute. Set is against master branch. Thanks! Daniel Borkmann (3): tc, bpf: add new csum and tunnel signatures tc, bpf: further improve error reporting tc, bpf: add support for map

[PATCH iproute2 -master 3/3] tc, bpf: add support for map pre/allocation

2016-04-08 Thread Daniel Borkmann
Follow-up to kernel commit 6c9059817432 ("bpf: pre-allocate hash map elements"). Add flags support, so that we can pass in BPF_F_NO_PREALLOC flag for disallowing preallocation. Update examples accordingly and also remove the BPF_* map helper macros from them as they were not very useful.

[net-next][PATCH 1/2] RDS: fix endianness for dp_ack_seq

2016-04-08 Thread Santosh Shilimkar
From: Qing Huang dp->dp_ack_seq is used in big endian format. We need to do the big endianness conversion when we assign a value in host format to it. Signed-off-by: Qing Huang Signed-off-by: Santosh Shilimkar ---

[net-next][PATCH 2/2] RDS: Fix the atomicity for congestion map update

2016-04-08 Thread Santosh Shilimkar
Two different threads with different rds sockets may be in rds_recv_rcvbuf_delta() via receive path. If their ports both map to the same word in the congestion map, then using non-atomic ops to update it could cause the map to be incorrect. Lets use atomics to avoid such an issue. Full credit to

[net-next][PATCH 0/2] RDS: couple of fixes for 4.6

2016-04-08 Thread Santosh Shilimkar
Patches are also available at below git tree. git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux.git for_4.6/net-next/rds-fixes Qing Huang (1): RDS: fix endianness for dp_ack_seq Santosh Shilimkar (1): RDS: Fix the atomicity for congestion map update net/rds/cong.c | 4 ++--

[PATCH RFT 2/2] macb: kill PHY reset code

2016-04-08 Thread Sergei Shtylyov
With the 'phylib' now being aware of the "reset-gpios" PHY node property, there should be no need to frob the PHY reset in this driver anymore... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/cadence/macb.c | 17 -

[PATCH RFT 1/2] phylib: add device reset GPIO support

2016-04-08 Thread Sergei Shtylyov
The PHY devices sometimes do have their reset signal (maybe even power supply?) tied to some GPIO and sometimes it also does happen that a boot loader does not leave it deasserted. So far this issue has been attacked from (as I believe) a wrong angle: by teaching the MAC driver to manipulate the

[PATCH RFT 0/2] Teach phylib hard-resetting devices

2016-04-08 Thread Sergei Shtylyov
Hello. Here's the set of 2 patches against DaveM's 'net-next.git' repo. They add to 'phylib' support for resetting devices via GPIO and do some clean up after doing that... [1/2] phylib: add device reset GPIO support [2/2] macb: kill PHY reset code MBR, Sergei

Re: [PATCH net-next 1/8] perf: optimize perf_fetch_caller_regs

2016-04-08 Thread Steven Rostedt
On Tue, 5 Apr 2016 14:06:26 +0200 Peter Zijlstra wrote: > On Mon, Apr 04, 2016 at 09:52:47PM -0700, Alexei Starovoitov wrote: > > avoid memset in perf_fetch_caller_regs, since it's the critical path of all > > tracepoints. > > It's called from perf_sw_event_sched,

Re: [net-next PATCH 2/5] GSO: Add GSO type for fixed IPv4 ID

2016-04-08 Thread Alexander Duyck
On Fri, Apr 8, 2016 at 2:41 PM, Jesse Gross wrote: > On Fri, Apr 8, 2016 at 5:33 PM, Alexander Duyck wrote: >> This patch adds support for TSO using IPv4 headers with a fixed IP ID >> field. This is meant to allow us to do a lossless GRO in the case of TCP

Re: [PATCH v4] route: do not cache fib route info on local routes with oif

2016-04-08 Thread Julian Anastasov
Hello, On Fri, 8 Apr 2016, Chris Friesen wrote: > For local routes that require a particular output interface we do not want > to cache the result. Caching the result causes incorrect behaviour when > there are multiple source addresses on the interface. The end result > being that if

Re: [RFC PATCH 07/11] GENEVE: Add option to mangle IP IDs on inner headers when using TSO

2016-04-08 Thread Alexander Duyck
On Fri, Apr 8, 2016 at 2:40 PM, Jesse Gross wrote: > On Thu, Apr 7, 2016 at 8:52 PM, Alexander Duyck > wrote: >> Just a thought. What if I replaced NETIF_F_TSO_FIXEDID with something >> that meant we could mange the IP ID like a

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

2016-04-08 Thread Timur Tabi
Vikram Sethi wrote: On the FSM9900 SOC (which uses device-tree), the two pins that connect to the external PHY are gpio pins. However, the driver needs to reprogram the pinmux so that those pins are wired to the Emac controller. That's what the the gpio code in this driver is doing: it's

Re: [net-next PATCH 2/5] GSO: Add GSO type for fixed IPv4 ID

2016-04-08 Thread Jesse Gross
On Fri, Apr 8, 2016 at 5:33 PM, Alexander Duyck wrote: > This patch adds support for TSO using IPv4 headers with a fixed IP ID > field. This is meant to allow us to do a lossless GRO in the case of TCP > flows that use a fixed IP ID such as those that convert IPv6 header to

Re: [RFC PATCH 07/11] GENEVE: Add option to mangle IP IDs on inner headers when using TSO

2016-04-08 Thread Jesse Gross
On Thu, Apr 7, 2016 at 8:52 PM, Alexander Duyck wrote: > Just a thought. What if I replaced NETIF_F_TSO_FIXEDID with something > that meant we could mange the IP ID like a NETIF_F_TSO_IPID_MANGLE > (advice for better name welcome). Instead of the feature flag meaning

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-08 Thread Alexei Starovoitov
On Fri, Apr 08, 2016 at 10:08:08PM +0200, Jesper Dangaard Brouer wrote: > On Fri, 8 Apr 2016 10:26:53 -0700 > Alexei Starovoitov wrote: > > > On Fri, Apr 08, 2016 at 02:33:40PM +0200, Jesper Dangaard Brouer wrote: > > > > > > On Fri, 8 Apr 2016 12:36:14 +0200

[PATCH v4] route: do not cache fib route info on local routes with oif

2016-04-08 Thread Chris Friesen
For local routes that require a particular output interface we do not want to cache the result. Caching the result causes incorrect behaviour when there are multiple source addresses on the interface. The end result being that if the intended recipient is waiting on that interface for the packet

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

2016-04-08 Thread Vikram Sethi
On 04/08/2016 02:06 PM, Timur Tabi wrote: > Andrew Lunn wrote: > >> There are two different things here. One is configuring the pin to be >> a GPIO. The second is using the GPIO as a GPIO. In this case, >> bit-banging the MDIO bus. >> >> The firmware could be doing the configuration, setting the

[next-queue PATCH 1/3] i40e/i40evf: Add support for GSO partial with UDP_TUNNEL_CSUM and GRE_CSUM

2016-04-08 Thread Alexander Duyck
This patch makes it so that i40e and i40evf can use GSO_PARTIAL to support segmentation for frames with checksums enabled in outer headers. As a result we can now send data over these types of tunnels at over 20Gb/s versus the 12Gb/s that was previously possible on my system. The advantage with

[next-queue PATCH 2/3] ixgbe/ixgbevf: Add support for GSO partial

2016-04-08 Thread Alexander Duyck
This patch adds support for partial GSO segmentation in the case of tunnels. Specifically with this change the driver an perform segmenation as long as the frame either has IPv6 inner headers, or we are allowed to mangle the IP IDs on the inner header. This is needed because we will not be

[next-queue PATCH 3/3] igb/igbvf: Add support for GSO partial

2016-04-08 Thread Alexander Duyck
This patch adds support for partial GSO segmentation in the case of tunnels. Specifically with this change the driver an perform segmenation as long as the frame either has IPv6 inner headers, or we are allowed to mangle the IP IDs on the inner header. This is needed because we will not be

[next-queue PATCH 0/3] Add support for GSO partial to Intel NIC drivers

2016-04-08 Thread Alexander Duyck
So these are the patches needed to enable tunnel segmentation offloads on the igb, igbvf, ixgbe, and ixgbevf drivers. In addition this patch extends the i40e and i40evf drivers to include segmentation support for tunnels with outer checksums. The net performance gain for these patches are pretty

[PATCH net-next v2] vxlan: synchronously and race-free destruction of vxlan sockets

2016-04-08 Thread Hannes Frederic Sowa
Due to the fact that the udp socket is destructed asynchronously in a work queue, we have some nondeterministic behavior during shutdown of vxlan tunnels and creating new ones. Fix this by keeping the destruction process synchronous in regards to the user space process so IFF_UP can be reliably

Re: [PATCH v4 1/2] RDS: memory allocated must be align to 8

2016-04-08 Thread santosh shilimkar
On 4/8/2016 1:10 PM, David Miller wrote: From: santosh shilimkar Date: Fri, 8 Apr 2016 12:44:39 -0700 On 4/7/2016 4:57 AM, Shamir Rabinovitch wrote: Fix issue in 'rds_ib_cong_recv' when accessing unaligned memory allocated by 'rds_page_remainder_alloc' using

Re: [PATCH net-next v2] net: dsa: document missing functions

2016-04-08 Thread David Miller
From: Vivien Didelot Date: Wed, 6 Apr 2016 11:06:20 -0400 > Add description for the missing port_vlan_prepare, port_fdb_prepare, > port_fdb_dump functions in the DSA documentation. > > Signed-off-by: Vivien Didelot

Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops

2016-04-08 Thread David Miller
From: Vivien Didelot Date: Wed, 6 Apr 2016 11:55:02 -0400 > Neither the DSA layer nor the bridge code (see br_set_state) really care > about eventual errors from STP state setters, so make it void. > > The DSA layer separates the prepare and commit phases

Re: [PATCH] net: thunderx: Fix broken of_node_put() code.

2016-04-08 Thread David Daney
On 04/08/2016 01:15 PM, David Miller wrote: From: David Daney Date: Fri, 8 Apr 2016 09:41:35 -0700 Due to mail server malfunction, this patch was sent twice. Please ignore this duplicate. This submission had another problem too. Do not use the date of your

Re: pull-request: mac80211-next 2016-04-06

2016-04-08 Thread David Miller
From: Johannes Berg Date: Wed, 06 Apr 2016 15:26:50 +0200 > On Wed, 2016-04-06 at 15:25 +0200, Johannes Berg wrote: >> Hi Dave, >> >> For the 4.6 cycle, there's of course much more. The few things that >> > > Err, -next, so that's 4.7. Pulled, and I fixed the

Re: pull-request: mac80211 2016-04-06

2016-04-08 Thread David Miller
From: Johannes Berg Date: Wed, 6 Apr 2016 15:19:58 +0200 > First set of fixes for 4.6. Nothing really stands out. > > Let me know if there's any problem. Pulled, thanks Johannes.

Re: [PATCH net] vxlan: synchronously and race-free destruction of vxlan sockets

2016-04-08 Thread Eric Dumazet
On Fri, 2016-04-08 at 22:30 +0200, Hannes Frederic Sowa wrote: > Hi Marcelo, > ng rtnl? > > I thought about that and try not to use synchronize_rcu, but I don't see > any other way. Anyway, ndo_stop isn't really fast path and is used to > shut the interface down. Also since we have lwtunnels we

[PATCH] net: thunderx: Fix broken of_node_put() code.

2016-04-08 Thread David Daney
From: David Daney commit b7d3e3d3d21a ("net: thunderx: Don't leak phy device references on -EPROBE_DEFER condition.") incorrectly moved the call to of_node_put() outside of the loop. Under normal loop exit, the node has already had of_node_put() called, so the extra call

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread David Miller
From: Petri Gynther Date: Tue, 5 Apr 2016 17:50:01 -0700 > Add Byte Queue Limits (BQL) support to bcmgenet driver. > > Signed-off-by: Petri Gynther As Eric Dumazet indicated, your ->ndo_init() code to reset the queues is probably not necessary at

Re: [PATCH v3] route: do not cache fib route info on local routes with oif

2016-04-08 Thread Julian Anastasov
Hello, On Fri, 8 Apr 2016, Chris Friesen wrote: > For local routes that require a particular output interface we do not want to > cache the result. Caching the result causes incorrect behaviour when there > are > multiple source addresses on the interface. The end result being that

[net-next PATCH 2/5] GSO: Add GSO type for fixed IPv4 ID

2016-04-08 Thread Alexander Duyck
This patch adds support for TSO using IPv4 headers with a fixed IP ID field. This is meant to allow us to do a lossless GRO in the case of TCP flows that use a fixed IP ID such as those that convert IPv6 header to IPv4 headers. In addition I am adding a feature that for now I am referring to TSO

[net-next PATCH 4/5] GSO: Support partial segmentation offload

2016-04-08 Thread Alexander Duyck
This patch adds support for something I am referring to as GSO partial. The basic idea is that we can support a broader range of devices for segmentation if we use fixed outer headers and have the hardware only really deal with segmenting the inner header. The idea behind the naming is due to the

[net-next PATCH 3/5] GRO: Add support for TCP with fixed IPv4 ID field, limit tunnel IP ID values

2016-04-08 Thread Alexander Duyck
This patch does two things. First it allows TCP to aggregate TCP frames with a fixed IPv4 ID field. As a result we should now be able to aggregate flows that were converted from IPv6 to IPv4. In addition this allows us more flexibility for future implementations of segmentation as we may be

[net-next PATCH 5/5] Documentation: Add documentation for TSO and GSO features

2016-04-08 Thread Alexander Duyck
This document is a starting point for defining the TSO and GSO features. The whole thing is starting to get a bit messy so I wanted to make sure we have notes somwhere to start describing what does and doesn't work. Signed-off-by: Alexander Duyck ---

[net-next PATCH 1/5] ethtool: Add support for toggling any of the GSO offloads

2016-04-08 Thread Alexander Duyck
The strings were missing for several of the GSO offloads that are available. This patch provides the missing strings so that we can toggle or query any of them via the ethtool command. Signed-off-by: Alexander Duyck --- net/core/ethtool.c |2 ++ 1 file changed, 2

Re: [PATCH net] bridge, netem: mark mailing lists as moderated

2016-04-08 Thread David Miller
From: Stephen Hemminger Date: Tue, 5 Apr 2016 13:43:53 -0700 > I moderate these (lightly loaded) lists to block spam. > > Signed-off-by: Stephen Hemminger Applied, thanks.

[net-next PATCH 0/5] GRO Fixed IPv4 ID support and GSO partial support

2016-04-08 Thread Alexander Duyck
This patch series sets up a few different things. First it adds support for GRO of frames with a fixed IP ID value. This will allow us to perform GRO for frames that go through things like an IPv6 to IPv4 header translation. The second item we add is support for segmenting frames that are

Re: [PATCH net] vxlan: synchronously and race-free destruction of vxlan sockets

2016-04-08 Thread Hannes Frederic Sowa
Hi Marcelo, On 08.04.2016 20:51, Marcelo Ricardo Leitner wrote: On Thu, Apr 07, 2016 at 04:57:40PM +0200, Hannes Frederic Sowa wrote: Due to the fact that the udp socket is destructed asynchronously in a work queue, we have some nondeterministic behavior during shutdown of vxlan tunnels and

Re: [PATCH] net: thunderx: Fix broken of_node_put() code.

2016-04-08 Thread David Miller
From: David Daney Date: Fri, 8 Apr 2016 09:41:35 -0700 > Due to mail server malfunction, this patch was sent twice. Please > ignore this duplicate. This submission had another problem too. Do not use the date of your commit as the date that gets put into your email

Re: [PATCH v4 1/2] RDS: memory allocated must be align to 8

2016-04-08 Thread David Miller
From: santosh shilimkar Date: Fri, 8 Apr 2016 12:44:39 -0700 > On 4/7/2016 4:57 AM, Shamir Rabinovitch wrote: >> Fix issue in 'rds_ib_cong_recv' when accessing unaligned memory >> allocated by 'rds_page_remainder_alloc' using uint64_t pointer. >> > Sorry I still

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-08 Thread Jesper Dangaard Brouer
On Fri, 8 Apr 2016 10:26:53 -0700 Alexei Starovoitov wrote: > On Fri, Apr 08, 2016 at 02:33:40PM +0200, Jesper Dangaard Brouer wrote: > > > > On Fri, 8 Apr 2016 12:36:14 +0200 Jesper Dangaard Brouer > > wrote: > > > > > > +/* user return

Re: [PATCH v2] route: do not cache fib route info on local routes with oif

2016-04-08 Thread Chris Friesen
On 04/08/2016 01:14 PM, Julian Anastasov wrote: Your patch is corrupted. I was in the same trap some time ago but with different client: From Documentation/email-clients.txt: Don't send patches with "format=flowed". This can cause unexpected and unwanted line breaks.

[PATCH v3] route: do not cache fib route info on local routes with oif

2016-04-08 Thread Chris Friesen
For local routes that require a particular output interface we do not want to cache the result. Caching the result causes incorrect behaviour when there are multiple source addresses on the interface. The end result being that if the intended recipient is waiting on that interface for the packet

Re: [PATCH net] tuntap: restore default qdisc

2016-04-08 Thread David Miller
From: Jason Wang Date: Fri, 8 Apr 2016 13:26:48 +0800 > After commit f84bb1eac027 ("net: fix IFF_NO_QUEUE for drivers using > alloc_netdev"), default qdisc was changed to noqueue because > tuntap does not set tx_queue_len during .setup(). This patch restores > default qdisc

Re: [PATCH v4 1/2] RDS: memory allocated must be align to 8

2016-04-08 Thread santosh shilimkar
On 4/7/2016 4:57 AM, Shamir Rabinovitch wrote: Fix issue in 'rds_ib_cong_recv' when accessing unaligned memory allocated by 'rds_page_remainder_alloc' using uint64_t pointer. Sorry I still didn't follow this change still. What exactly is the problem. Signed-off-by: Shamir Rabinovitch

[PATCH v3 0/2] sctp: delay calls to sk_data_ready() as much as possible

2016-04-08 Thread Marcelo Ricardo Leitner
1st patch is a preparation for the 2nd. The idea is to not call ->sk_data_ready() for every data chunk processed while processing packets but only once before releasing the socket. v2: patchset re-checked, small changelog fixes v3: on patch 2, make use of local vars to make it more readable

[PATCH v3 1/2] sctp: compress bit-wide flags to a bitfield on sctp_sock

2016-04-08 Thread Marcelo Ricardo Leitner
It wastes space and gets worse as we add new flags, so convert bit-wide flags to a bitfield. Currently it already saves 4 bytes in sctp_sock, which are left as holes in it for now. The whole struct needs packing, which should be done in another patch. Note that do_auto_asconf cannot be merged,

[PATCH v3 2/2] sctp: delay calls to sk_data_ready() as much as possible

2016-04-08 Thread Marcelo Ricardo Leitner
Currently processing of multiple chunks in a single SCTP packet leads to multiple calls to sk_data_ready, causing multiple wake up signals which are costy and doesn't make it wake up any faster. With this patch it will note that the wake up is pending and will do it before leaving the state

Re: [patch net-next] devlink: share user_ptr pointer for both devlink and devlink_port

2016-04-08 Thread David Miller
From: Jiri Pirko Date: Fri, 8 Apr 2016 19:12:48 +0200 > From: Jiri Pirko > > Ptr to devlink structure can be easily obtained from > devlink_port->devlink. So share user_ptr[0] pointer for both and leave > user_ptr[1] free for other users. > >

Re: [PATCH v4 2/2] RDS: fix congestion map corruption for PAGE_SIZE > 4k

2016-04-08 Thread santosh shilimkar
On 4/7/2016 4:57 AM, Shamir Rabinovitch wrote: When PAGE_SIZE > 4k single page can contain 2 RDS fragments. If 'rds_ib_cong_recv' ignore the RDS fragment offset in to the page it then read the data fragment as far congestion map update and lead to corruption of the RDS connection far congestion

Re: [patch net-next 0/6] mlxsw: small driver update + one tiny devlink dependency

2016-04-08 Thread David Miller
From: Jiri Pirko Date: Fri, 8 Apr 2016 19:11:19 +0200 > Cosmetics, in preparation to sharedbuffer patchset. > First patch is here to allow patch number two. Series applied, thanks Jiri.

[PATCH] mISDN: Fixing missing validation in base_sock_bind()

2016-04-08 Thread Emrah Demir
From: Emrah Demir Add validation code into mISDN/socket.c Signed-off-by: Emrah Demir --- drivers/isdn/mISDN/socket.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/isdn/mISDN/socket.c b/drivers/isdn/mISDN/socket.c index 0d29b5a..99e5f97 100644

Re: [PATCH v5 net-next 00/15] MTU/buffer reconfig changes

2016-04-08 Thread David Miller
From: Jakub Kicinski Date: Thu, 7 Apr 2016 19:39:33 +0100 > I re-discussed MPLS/MTU internally, dropped it from the patch 1, > re-tested everything, found out I forgot about debugfs pointers, > fixed that as well. > > v5: > - don't reserve space in RX buffers for

Re: [PATCH v2] route: do not cache fib route info on local routes with oif

2016-04-08 Thread Julian Anastasov
Hello, On Fri, 8 Apr 2016, Chris Friesen wrote: > For local routes that require a particular output interface we do not want to > cache the result. Caching the result causes incorrect behaviour when there > are > multiple source addresses on the interface. The end result being that if

FROM: MR. OLIVER SENO!!

2016-04-08 Thread AKINWUMI
Dear Sir. I bring you greetings. My name is Mr.Oliver Seno Lim, I am a staff of Abbey National Plc. London and heading our regional office in West Africa. Our late customer named Engr.Ben W.westland, made a fixed deposit amount of US$7Million.He did not declare any next of kin in any of his

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

2016-04-08 Thread Timur Tabi
Andrew Lunn wrote: There are two different things here. One is configuring the pin to be a GPIO. The second is using the GPIO as a GPIO. In this case, bit-banging the MDIO bus. The firmware could be doing the configuration, setting the pin as a GPIO. However, the firmware cannot be doing the

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-08 Thread Jesper Dangaard Brouer
On Fri, 8 Apr 2016 10:02:00 -0700 Brenden Blanco wrote: > On Fri, Apr 08, 2016 at 02:33:40PM +0200, Jesper Dangaard Brouer wrote: > > > > On Fri, 8 Apr 2016 12:36:14 +0200 Jesper Dangaard Brouer > > wrote: > > > > > > +/* user return codes for

[PATCH] net: ipv6: Do not keep linklocal and loopback addresses

2016-04-08 Thread David Ahern
f1705ec197e7 added the option to retain user configured addresses on an admin down. A comment to one of the later revisions suggested using the IFA_F_PERMANENT flag rather than adding a user_managed boolean to the ifaddr struct. A side effect of this change is that link local and loopback

Re: [PATCH v2 1/5] net: w5100: move mmiowb into register access callbacks

2016-04-08 Thread Akinobu Mita
2016-04-08 1:29 GMT+09:00 David Miller : > > Where is your "[PATCH v2 0/5] ..." header posting explaing what this series > is doing, at a high level, how it is doing that, and why it is doing it > that way? > > This is mandator for patch series submissions. I see. I'll

Re: [PATCH net] vxlan: synchronously and race-free destruction of vxlan sockets

2016-04-08 Thread Marcelo Ricardo Leitner
Hi Hannes, On Thu, Apr 07, 2016 at 04:57:40PM +0200, Hannes Frederic Sowa wrote: > Due to the fact that the udp socket is destructed asynchronously in a > work queue, we have some nondeterministic behavior during shutdown of > vxlan tunnels and creating new ones. Fix this by keeping the

[PATCH] drivers/net/ethernet/jme.c: Deinline jme_reset_mac_processor, save 2816 bytes

2016-04-08 Thread Denys Vlasenko
This function compiles to 895 bytes of machine code. Clearly, this isn't a time-critical function. For one, it has a number of udelay(1) calls. Signed-off-by: Denys Vlasenko CC: David S. Miller CC: linux-ker...@vger.kernel.org CC:

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Eric Dumazet
On Fri, 2016-04-08 at 09:54 -0700, Petri Gynther wrote: > On Wed, Apr 6, 2016 at 1:25 PM, Florian Fainelli wrote: > > > > 2016-04-05 17:50 GMT-07:00 Petri Gynther : > > > Add Byte Queue Limits (BQL) support to bcmgenet driver. > > > > > > Signed-off-by:

Re: [PATCH] ieee802154/adf7242: fix memory leak of firmware

2016-04-08 Thread Marcel Holtmann
Hi Sudip, > If the firmware upload or the firmware verification fails then we > printed the error message and exited but we missed releasing the > firmware. > > Signed-off-by: Sudip Mukherjee > --- > drivers/net/ieee802154/adf7242.c | 2 ++ > 1 file changed, 2

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-08 Thread Alexei Starovoitov
On Fri, Apr 08, 2016 at 02:33:40PM +0200, Jesper Dangaard Brouer wrote: > > On Fri, 8 Apr 2016 12:36:14 +0200 Jesper Dangaard Brouer > wrote: > > > > +/* user return codes for PHYS_DEV prog type */ > > > +enum bpf_phys_dev_action { > > > + BPF_PHYS_DEV_DROP, > > > +

Re: [PATCH] net: thunderx: Fix broken of_node_put() code.

2016-04-08 Thread David Daney
Due to mail server malfunction, this patch was sent twice. Please ignore this duplicate. Thanks, David Daney On 03/31/2016 06:01 PM, David Daney wrote: From: David Daney commit b7d3e3d3d21a ("net: thunderx: Don't leak phy device references on -EPROBE_DEFER

Re: [patch net-next 0/5] mlxsw: small driver update

2016-04-08 Thread David Miller
From: Jiri Pirko Date: Fri, 8 Apr 2016 17:51:55 +0200 > Fri, Apr 08, 2016 at 05:45:20PM CEST, j...@resnulli.us wrote: >>From: Jiri Pirko >> >>Cosmetics, in preparation to sharedbuffer patchset. > > Dave, I just realized there is dependency on: > "devlink:

Re: [PATCH net-next] ipv6, token: allow for clearing the current device token

2016-04-08 Thread Daniel Borkmann
On 04/08/2016 05:36 PM, Hannes Frederic Sowa wrote: On 08.04.2016 17:25, Bjørn Mork wrote: Hannes Frederic Sowa writes: On Fri, Apr 8, 2016, at 16:18, Bjørn Mork wrote: Daniel Borkmann writes: if (!token) return -EINVAL; -

  1   2   >