[PATCH 8/8] batman-adv: initialize ELP orig address on secondary interfaces

2016-05-17 Thread Antonio Quartulli
From: Marek Lindner This fix prevents nodes to wrongly create a 00:00:00:00:00:00 originator which can potentially interfere with the rest of the neighbor statistics. Fixes: d6f94d91f766 ("batman-adv: ELP - adding basic infrastructure") Signed-off-by: Marek Lindner

[PATCH 6/8] batman-adv: Fix integer overflow in batadv_iv_ogm_calc_tq

2016-05-17 Thread Antonio Quartulli
From: Sven Eckelmann The undefined behavior sanatizer detected an signed integer overflow in a setup with near perfect link quality UBSAN: Undefined behaviour in net/batman-adv/bat_iv_ogm.c:1246:25 signed integer overflow: 8713350 * 255 cannot be

[PATCH 1/8] batman-adv: fix skb deref after free

2016-05-17 Thread Antonio Quartulli
From: Florian Westphal batadv_send_skb_to_orig() calls dev_queue_xmit() so we can't use skb->len. Fixes: 953324776d6d ("batman-adv: network coding - buffer unicast packets before forward") Signed-off-by: Florian Westphal Reviewed-by: Sven Eckelmann

[PATCH 2/8] batman-adv: Avoid nullptr derefence in batadv_v_neigh_is_sob

2016-05-17 Thread Antonio Quartulli
From: Sven Eckelmann batadv_neigh_ifinfo_get can return NULL when it cannot find (even when only temporarily) anymore the neigh_ifinfo in the list neigh->ifinfo_list. This has to be checked to avoid kernel Oopses when the ifinfo is dereferenced. This a situation which isn't

[PATCH 7/8] batman-adv: Avoid duplicate neigh_node additions

2016-05-17 Thread Antonio Quartulli
From: Linus Lüssing Two parallel calls to batadv_neigh_node_new() might race for creating and adding the same neig_node. Fix this by including the check for any already existing, identical neigh_node within the spin-lock. This fixes splats like the following: [

[PATCH 5/8] batman-adv: make sure ELP/OGM orig MAC is updated on address change

2016-05-17 Thread Antonio Quartulli
When the MAC address of the primary interface is changed, update the originator address in the ELP and OGM skb buffers as well in order to reflect the change. Fixes: d6f94d91f766 ("batman-adv: ELP - adding basic infrastructure") Reported-by: Marek Lindner Signed-off-by:

[PATCH 4/8] batman-adv: Fix unexpected free of bcast_own on add_if error

2016-05-17 Thread Antonio Quartulli
From: Sven Eckelmann The function batadv_iv_ogm_orig_add_if allocates new buffers for bcast_own and bcast_own_sum. It is expected that these buffers are unchanged in case either bcast_own or bcast_own_sum couldn't be resized. But the error handling of this function frees the

[PATCH 3/8] batman-adv: Fix refcnt leak in batadv_v_neigh_*

2016-05-17 Thread Antonio Quartulli
From: Sven Eckelmann The functions batadv_neigh_ifinfo_get increase the reference counter of the batadv_neigh_ifinfo. These have to be reduced again when the reference is not used anymore to correctly free the objects. Fixes: 9786906022eb ("batman-adv: B.A.T.M.A.N. V -

pull request: batman-adv 20160518

2016-05-17 Thread Antonio Quartulli
Hi David, these are the fixes that couldn't make it for linux-4.6 rebased on top of net-next. They were all supposed to be applied on 4.6, therefore it would be nice if you could queue them for inclusion in the 4.6.1 stable release. Please pull or let me know of any problem! I also have a

Re: [PATCH] net: au1000 eth: simplify logical expression

2016-05-17 Thread Florian Fainelli
Le 17/05/2016 16:58, Heinrich Schuchardt a écrit : > (a && a > 0) is equivalent to (a > 0). > > Signed-off-by: Heinrich Schuchardt Acked-by: Florian Fainelli -- Florian

Re: Crashes in -next due to 'phy: add support for a reset-gpio specification'

2016-05-17 Thread Florian Fainelli
9.371540] Unable to handle kernel paging request at virtual address > 001c > [9.371540] pc = d0320926, ra = 903209d1 > [9.375358] Oops: sig: 11 [#1] > [9.376081] PREEMPT > [9.377080] CPU: 0 PID: 1 Comm: swapper Not tainted > 4.6.0-next-20160517 #1 >

Crashes in -next due to 'phy: add support for a reset-gpio specification'

2016-05-17 Thread Guenter Roeck
[9.371540] pc = d0320926, ra = 903209d1 [9.375358] Oops: sig: 11 [#1] [9.376081] PREEMPT [9.377080] CPU: 0 PID: 1 Comm: swapper Not tainted 4.6.0-next-20160517 #1 [9.378397] task: d7c2c000 ti: d7c3 task.ti: d7c3 [9.379394] a00: 903209d1 d7c31bd0 d7fb5810 0001

Re: QRTR merge conflict resolution

2016-05-17 Thread Bjorn Andersson
On Tue 17 May 17:43 PDT 2016, Stephen Rothwell wrote: > Hi David, > > On Tue, 17 May 2016 14:11:54 -0400 (EDT) David Miller > wrote: > > > > From: Bjorn Andersson > > Date: Fri, 13 May 2016 15:19:09 -0700 > > > > > I have prepared the merge of

Re: [GIT] Networking

2016-05-17 Thread Emmanuel Grumbach
On Wed, May 18, 2016 at 4:00 AM, Linus Torvalds wrote: > On Tue, May 17, 2016 at 12:11 PM, David Miller wrote: >> >> Highlights: > > Lowlights: > > 1) the iwlwifi driver seems to be broken > > My laptop that uses the intel 7680 iwlwifi module

Re: [PATCH v9 net-next 5/7] openvswitch: add layer 3 support to ovs_packet_cmd_execute()

2016-05-17 Thread Simon Horman
On Tue, May 17, 2016 at 04:51:08PM +0200, Jiri Benc wrote: > On Wed, 4 May 2016 16:36:31 +0900, Simon Horman wrote: > > + /* Packets from user space for execution only have metadata key > > +* attributes. OVS_KEY_ATTR_PACKET_ETHERTYPE is then used to specify > > +* the starting layer

Re: [PATCH v9 net-next 4/7] openvswitch: add layer 3 flow/port support

2016-05-17 Thread Simon Horman
On Tue, May 17, 2016 at 04:43:20PM +0200, Jiri Benc wrote: > On Thu, 12 May 2016 07:46:52 +0900, Simon Horman wrote: > > If we can live with a bogus skb->mac_len value that is sufficient for > > ovs_flow_key_extract.() and set correctly by key_extract() (which happens > > anyway) we could do

[PATCH net-next 0/2] tcp: add NV congestion control

2016-05-17 Thread Lawrence Brakmo
This patchset adds support for NV congestion control. This version of NV does much better than previous versions when things are very congested. Tested in a rack using between 1 and 380 active TCP-NV flows. Consists of the following patches: [PATCH net-next 1/2] tcp: add in_flight to

[PATCH net-next 1/2] tcp: add in_flight to tcp_skb_cb

2016-05-17 Thread Lawrence Brakmo
Add in_flight (bytes in flight when packet was sent) field to tx component of tcp_skb_cb and make it available to congestion modules' pkts_acked() function through the ack_sample function argument. Signed-off-by: Lawrence Brakmo Acked-by: Yuchung Cheng ---

[PATCH net-next 2/2] tcp: add NV congestion control

2016-05-17 Thread Lawrence Brakmo
TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC. It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A description of TCP-NV, including implementation

[PATCH v2] net: Fix coding style warnings and errors.

2016-05-17 Thread Amit Ghadge
This is a patch to clean checkpatch warnings and errors in the Space.c file. Clean up the following warnings and errors. WARNING : * Block comments use * on subsequent lines * Missing a blank line after declarations * networking block comments don't use an empty /* line, use /* * please, no space

Re: [PATCH 1/1] net: hns: avoid null pointer dereference

2016-05-17 Thread Yisen Zhuang
Hi Heinrich, This patch is fine to me. Thanks, Yisen 在 2016/5/18 4:01, Heinrich Schuchardt 写道: > In the statement > assert(priv || priv->ae_handle); > the right side of || is only evaluated if priv is null. > > Signed-off-by: Heinrich Schuchardt > --- >

Re: [GIT] Networking

2016-05-17 Thread Linus Torvalds
On Tue, May 17, 2016 at 12:11 PM, David Miller wrote: > > Highlights: Lowlights: 1) the iwlwifi driver seems to be broken My laptop that uses the intel 7680 iwlwifi module no longer connects to the network. It fails with a "Microcode SW error detected." and spews out

[PATCH 1/1] brcm80211: simplify assignment

2016-05-17 Thread Heinrich Schuchardt
Simplify assignment in wlc_phy_rxcal_gainctrl_nphy_rev5. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next 2/4] ocfs2/cluster: block BH in TCP callbacks

2016-05-17 Thread Eric Dumazet
TCP stack can now run from process context. Use read_lock_bh() variant to restore previous assumption. Fixes: 5413d1babe8f ("net: do not block BH while processing socket backlog") Fixes: d41a69f1d390 ("tcp: make tcp_sendmsg() aware of socket backlog") Signed-off-by: Eric Dumazet

[PATCH net-next 3/4] rds: tcp: block BH in TCP callbacks

2016-05-17 Thread Eric Dumazet
TCP stack can now run from process context. Use read_lock_bh(>sk_callback_lock) variant to restore previous assumption. Fixes: 5413d1babe8f ("net: do not block BH while processing socket backlog") Fixes: d41a69f1d390 ("tcp: make tcp_sendmsg() aware of socket backlog") Signed-off-by: Eric Dumazet

[PATCH net-next 4/4] tipc: block BH in TCP callbacks

2016-05-17 Thread Eric Dumazet
TCP stack can now run from process context. Use read_lock_bh(>sk_callback_lock) variant to restore previous assumption. Fixes: 5413d1babe8f ("net: do not block BH while processing socket backlog") Fixes: d41a69f1d390 ("tcp: make tcp_sendmsg() aware of socket backlog") Signed-off-by: Eric Dumazet

[PATCH 1/1] rtlwifi: rtl8192ee: simplify coding

2016-05-17 Thread Heinrich Schuchardt
Simplify _rtl92ee_phy_path_adda_on. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ee/phy.c

[PATCH net-next 0/4] net: block BH in TCP callbacks

2016-05-17 Thread Eric Dumazet
Four layers using TCP stack were assuming sk_callback_lock could be locked using read_lock() in their handlers because TCP stack was running with BH disabled. This is no longer the case. Since presumably the rest could also depend on BH being disabled, just use read_lock_bh(). Then each layer

[PATCH net-next 1/4] scsi_tcp: block BH in TCP callbacks

2016-05-17 Thread Eric Dumazet
iscsi_sw_tcp_data_ready() and iscsi_sw_tcp_state_change() were using read_lock(>sk_callback_lock) which is fine if caller disabled BH. TCP stack no longer has this requirement and can run from process context. Use read_lock_bh() variant to restore previous assumption. Ideally this code could

Re: QRTR merge conflict resolution

2016-05-17 Thread Stephen Rothwell
Hi David, On Tue, 17 May 2016 14:11:54 -0400 (EDT) David Miller wrote: > > From: Bjorn Andersson > Date: Fri, 13 May 2016 15:19:09 -0700 > > > I have prepared the merge of net-next and the conflicting tag from the > > Qualcomm SOC, please

[PATCH] wifi: ath6kl: simplify logical condition

2016-05-17 Thread Heinrich Schuchardt
x <= 7 implies x < 8. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/ath/ath6kl/wmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c index 631c3a0..b8cf04d

[PATCH 1/1] net: pegasus: remove dead coding

2016-05-17 Thread Heinrich Schuchardt
(!count || count < 4) is always true. So let's remove the coding which is dead at least since 2005. Signed-off-by: Heinrich Schuchardt --- drivers/net/usb/pegasus.c | 53 --- 1 file changed, 53 deletions(-) diff --git

Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer

2016-05-17 Thread Francois Romieu
David Miller : > From: Shuyu Wei > Date: Tue, 17 May 2016 23:25:20 +0800 > > > diff --git a/drivers/net/ethernet/arc/emac_main.c > > b/drivers/net/ethernet/arc/emac_main.c > > index a3a9392..df3dfef 100644 > > --- a/drivers/net/ethernet/arc/emac_main.c >

[PATCH] net: au1000 eth: simplify logical expression

2016-05-17 Thread Heinrich Schuchardt
(a && a > 0) is equivalent to (a > 0). Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/amd/au1000_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c index

[net-next RFC 1/1] net sched actions: introduce timestamp for first time used

2016-05-17 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Useful to know when the action was first used for accounting (and debugging) Signed-off-by: Jamal Hadi Salim --- include/net/act_api.h| 2 ++ include/uapi/linux/pkt_cls.h | 1 + net/sched/act_api.c | 1 +

Re: [PATCH] net: phy: Ensure the state machine is called when phy is UP

2016-05-17 Thread David Mosberger
[Resending with mailing list address corrected. Sorry about that.] I believe I'm seeing the same issue as in this thread: http://www.spinics.net/lists/netdev/msg373670.html macb Ethernet driver and after upgrading from 4.4.0 to 4.60, the Ethernet interface would not initialize unless I force

[PATCH 1/1] iwlwifi: rs: remove superfluous check

2016-05-17 Thread Heinrich Schuchardt
If we dereference a variable anyway in other parts of the code, there is no need to check against NULL in a single place. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/1] mwiflex: avoid possible null pointer dereference

2016-05-17 Thread Heinrich Schuchardt
Do not dereference card before checking against NULL value. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/marvell/mwifiex/pcie.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c

[PATCH 1/1] mwifiex: illegal assignment

2016-05-17 Thread Heinrich Schuchardt
Variable adapter is incorrectly initialized. Fixes: bf00dc22bc7a ("mwifiex: AMSDU Rx frame handling in AP mode") Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/marvell/mwifiex/uap_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] asix: Fix offset calculation in asix_rx_fixup() causing slow transmissions

2016-05-17 Thread Dean Jenkins
Hi John, Thanks for your patch. I think the patch has already been applied. The git commit subject of "asix: Fix offset calculation in asix_rx_fixup() causing slow transmissions" I think is a bit misleading as the bug relates to reception and not transmission. I guess that your intent was

[PATCH 1/1] rtlwifi: rtl8723be: avoid undefined behavior

2016-05-17 Thread Heinrich Schuchardt
Do not return undefined value for transmission power if the rate is invalid. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/1] net: rsi: eliminate superfluous NULL check

2016-05-17 Thread Heinrich Schuchardt
msg is dereferenced before checking against NULL, e.g. when assigning pad_bytes. Remove the superfluous check in function rsi_mgmt_pkt_to_core. Signed-off-by: Heinrich Schuchardt --- drivers/net/wireless/rsi/rsi_91x_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 1/1] net: irda: avoid null pointer dereference

2016-05-17 Thread Heinrich Schuchardt
Only dereference variable self after checking it is not NULL. Signed-off-by: Heinrich Schuchardt --- drivers/net/irda/nsc-ircc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/irda/nsc-ircc.c b/drivers/net/irda/nsc-ircc.c index

[PATCH 1/1] net: ieee802154/adf7242: syntax error ifdef DEBUG

2016-05-17 Thread Heinrich Schuchardt
If DEBUG is defined, a superfluous closing brace is introduced. Signed-off-by: Heinrich Schuchardt --- drivers/net/ieee802154/adf7242.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c index

Re: [PATCH 1/1] net: ehea: avoid null pointer dereference

2016-05-17 Thread Thadeu Lima de Souza Cascardo
On Tue, May 17, 2016 at 10:28:54PM +0200, Heinrich Schuchardt wrote: > ehea_get_port may return NULL. Do not dereference NULL value. > > Fixes: 8c4877a4128e ("ehea: Use the standard logging functions") > Signed-off-by: Heinrich Schuchardt Acked-by: Thadeu Lima de Souza

Re: [PATCH 1/1] net: thunderx: avoid null pointer dereference

2016-05-17 Thread Heinrich Schuchardt
On 05/17/2016 10:21 PM, David Daney wrote: > On 05/17/2016 12:40 PM, Heinrich Schuchardt wrote: >> In function bgx_lmac_handler only use a member of >> lmac after checking it is not null. >> > > Were you seeing and actual OOPs, or is this only a theoretical problem > flagged by some sort of

Re: [PATCH] net: don't lose features in netdev_add_tso_features()

2016-05-17 Thread Dimitris Michailidis
On Tue, May 17, 2016 at 11:10 AM, David Miller wrote: > From: Dimitris Michailidis > Date: Mon, 16 May 2016 15:33:35 -0700 > >> The goal of netdev_add_tso_features() is to enable all TSO features but >> it unintentionally loses NETIF_F_ALL_FOR_ALL

[net-next PATCH 1/2] net sched: indentation and other stylistic fixes

2016-05-17 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Signed-off-by: Jamal Hadi Salim --- include/net/act_api.h | 14 -- include/net/tc_act/tc_defact.h | 4 ++-- include/uapi/linux/pkt_cls.h | 6 +++--- net/sched/act_api.c| 19 +++

[net-next PATCH 2/2] net sched: actions use tcf_lastuse_update

2016-05-17 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Signed-off-by: Jamal Hadi Salim --- net/sched/act_connmark.c | 2 +- net/sched/act_csum.c | 2 +- net/sched/act_ife.c | 6 +++--- net/sched/act_ipt.c | 2 +- net/sched/act_mirred.c | 1 - net/sched/act_nat.c | 2

[net-next PATCH 0/2] net sched small OCD cleanups

2016-05-17 Thread Jamal Hadi Salim
From: Jamal Hadi Salim I have been staring at these small OCD cleanups for a while. Got cycles to do them as prep for another patch i am working on. Indentation/stylistic and consistency updates Jamal Hadi Salim (2): net sched: indentation and other OCD stylistic fixes

[Patch net] kcm: fix a signedness in kcm_splice_read()

2016-05-17 Thread Cong Wang
skb_splice_bits() returns int, kcm_splice_read() returns ssize_t, both are signed. We may need another patch to make them all ssize_t, but that deserves a separated patch. Fixes: 91687355b927 ("kcm: Splice support") Reported-by: David Binderman Cc: Tom Herbert

Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional

2016-05-17 Thread Alexander Graf
> Am 17.05.2016 um 22:40 schrieb Dan Murphy : > >> On 05/17/2016 03:37 PM, Alexander Graf wrote: >> Hi David, >> >>> Am 17.05.2016 um 20:48 schrieb David Miller : >>> >>> From: Dan Murphy >>> Date: Tue, 17 May 2016 13:34:34 -0500 >>>

[PATCH 1/1] net: i40e: avoid null pointer dereference

2016-05-17 Thread Heinrich Schuchardt
In function i40e_debug_aq parameter desc is assumed to be possibly NULL. Do not dereference it before checking the value. Fixes: f905dd62be88 ("i40e/i40evf: add max buf len to aq debug print helper") Signed-off-by: Heinrich Schuchardt ---

Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional

2016-05-17 Thread Dan Murphy
On 05/17/2016 03:37 PM, Alexander Graf wrote: > Hi David, > >> Am 17.05.2016 um 20:48 schrieb David Miller : >> >> From: Dan Murphy >> Date: Tue, 17 May 2016 13:34:34 -0500 >> >>> David >>> On 05/17/2016 01:22 PM, David Miller wrote: From: Alexander

Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional

2016-05-17 Thread Alexander Graf
Hi David, > Am 17.05.2016 um 20:48 schrieb David Miller : > > From: Dan Murphy > Date: Tue, 17 May 2016 13:34:34 -0500 > >> David >> >>> On 05/17/2016 01:22 PM, David Miller wrote: >>> From: Alexander Graf >>> Date: Mon, 16 May 2016

Re: [PATCH 1/1] net: thunderx: avoid null pointer dereference

2016-05-17 Thread David Daney
On 05/17/2016 12:40 PM, Heinrich Schuchardt wrote: In function bgx_lmac_handler only use a member of lmac after checking it is not null. Were you seeing and actual OOPs, or is this only a theoretical problem flagged by some sort of static code checker? Signed-off-by: Heinrich Schuchardt

[PATCH 1/1] net: ehea: avoid null pointer dereference

2016-05-17 Thread Heinrich Schuchardt
ehea_get_port may return NULL. Do not dereference NULL value. Fixes: 8c4877a4128e ("ehea: Use the standard logging functions") Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/ibm/ehea/ehea_main.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-)

[PATCH 1/1] net: hns: avoid null pointer dereference

2016-05-17 Thread Heinrich Schuchardt
In the statement assert(priv || priv->ae_handle); the right side of || is only evaluated if priv is null. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 1/1] net: thunderx: avoid null pointer dereference

2016-05-17 Thread Heinrich Schuchardt
In function bgx_lmac_handler only use a member of lmac after checking it is not null. Signed-off-by: Heinrich Schuchardt --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[RFC PATCH net] e1000e: keep vlan interfaces functional after rxvlan off

2016-05-17 Thread Jarod Wilson
I've got a bug report about an e1000e interface, where a vlan interface is set up on top of it: $ ip link add link ens1f0 name ens1f0.99 type vlan id 99 $ ip link set ens1f0 up $ ip link set ens1f0.99 up $ ip addr add 192.168.99.92 dev ens1f0.99 At this point, I can ping another host on vlan 99,

Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional

2016-05-17 Thread David Miller
From: Dan Murphy Date: Tue, 17 May 2016 13:34:34 -0500 > David > > On 05/17/2016 01:22 PM, David Miller wrote: >> From: Alexander Graf >> Date: Mon, 16 May 2016 20:52:43 +0200 >> >>> If you compile without OF_MDIO support in an RGMII configuration, we fail >>> to

Amministratore di sistema

2016-05-17 Thread Web Admin
-- La cassetta postale ha superato il limite di archiviazione, che è 20 GB come impostato dall'amministratore, si sta attualmente eseguendo il 20,9 GB, si potrebbe non essere in grado di inviare o ricevere nuovi messaggi fino a quando è convalidare nuovamente la cassetta postale. Per

Re: [PATCH iproute2] ss: Tell user about -EOPNOTSUPP for SOCK_DESTROY

2016-05-17 Thread subashab
On 2016-05-16 20:29, Lorenzo Colitti wrote: On Tue, May 17, 2016 at 11:24 AM, David Ahern wrote: As I mentioned we can print the unsupported once or per socket matched and with the socket params. e.g., + } else if (errno == EOPNOTSUPP) { +

Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional

2016-05-17 Thread Dan Murphy
David On 05/17/2016 01:22 PM, David Miller wrote: > From: Alexander Graf > Date: Mon, 16 May 2016 20:52:43 +0200 > >> If you compile without OF_MDIO support in an RGMII configuration, we fail >> to configure the dp83867 phy today by writing garbage into its configuration >>

Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()

2016-05-17 Thread David Miller
From: Florian Fainelli Date: Tue, 17 May 2016 11:27:12 -0700 > On 05/17/2016 11:20 AM, David Miller wrote: >> From: Rabin Vincent >> Date: Mon, 16 May 2016 13:15:56 +0200 >> >>> From: Rabin Vincent >>> >>> Since e7f4dc3536a

Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()

2016-05-17 Thread Florian Fainelli
On 05/17/2016 11:20 AM, David Miller wrote: > From: Rabin Vincent > Date: Mon, 16 May 2016 13:15:56 +0200 > >> From: Rabin Vincent >> >> Since e7f4dc3536a ("mdio: Move allocation of interrupts into core"), >> platforms which call fixed_phy_add() before

Re: [PATCH v2 2/2] net: Fix coding style warnings and errors.

2016-05-17 Thread Amit Ghadge
On Tue, May 17, 2016 at 02:01:52PM -0400, David Miller wrote: > > Whenever you have to make changes to a patch within a series, you must always > resubmit the entire series, not just the one that need changes. You want say submit patch with version series v1, v2 or patches series? If that is

Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer

2016-05-17 Thread David Miller
From: Shuyu Wei Date: Tue, 17 May 2016 23:25:20 +0800 > diff --git a/drivers/net/ethernet/arc/emac_main.c > b/drivers/net/ethernet/arc/emac_main.c > index a3a9392..df3dfef 100644 > --- a/drivers/net/ethernet/arc/emac_main.c > +++ b/drivers/net/ethernet/arc/emac_main.c > @@

Re: [Patch net] net_sched: close another race condition in tcf_mirred_release()

2016-05-17 Thread David Miller
From: Cong Wang Date: Mon, 16 May 2016 15:11:18 -0700 > We saw the following extra refcount release on veth device: > > kernel: [7957821.463992] unregister_netdevice: waiting for mesos50284 to > become free. Usage count = -1 > > Since we heavily use mirred action

Re: [PATCH v2 1/2] phy dp83867: Fix compilation with CONFIG_OF_MDIO=m

2016-05-17 Thread David Miller
From: Alexander Graf Date: Mon, 16 May 2016 20:52:42 +0200 > When CONFIG_OF_MDIO is configured as module, the #define for it really > is CONFIG_OF_MDIO_MODULE, not CONFIG_OF_MDIO. So if we are compiling it > as module, the dp83867 doesn't see that OF_MDIO was selected and doesn't

Re: [PATCH v2] r8169: default to 64-bit DMA on recent PCIe chips

2016-05-17 Thread David Miller
From: Ard Biesheuvel Date: Sat, 14 May 2016 22:40:15 +0200 > The current logic around the 'use_dac' module parameter prevents the > r81969 driver from being loadable on 64-bit systems without any RAM > below 4 GB when the parameter is left at its default value. > > So

Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional

2016-05-17 Thread David Miller
From: Alexander Graf Date: Mon, 16 May 2016 20:52:43 +0200 > If you compile without OF_MDIO support in an RGMII configuration, we fail > to configure the dp83867 phy today by writing garbage into its configuration > registers. > > On the other hand if you do compile with OF_MDIO

Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()

2016-05-17 Thread David Miller
From: Rabin Vincent Date: Mon, 16 May 2016 13:15:56 +0200 > From: Rabin Vincent > > Since e7f4dc3536a ("mdio: Move allocation of interrupts into core"), > platforms which call fixed_phy_add() before fixed_mdio_bus_init() is > called (for example,

Re: QRTR merge conflict resolution

2016-05-17 Thread David Miller
From: Bjorn Andersson Date: Fri, 13 May 2016 15:19:09 -0700 > I have prepared the merge of net-next and the conflicting tag from the > Qualcomm SOC, please include this in your pull towards Linus to avoid > the merge conflict. Pulled, thanks.

Re: [PATCH] net: don't lose features in netdev_add_tso_features()

2016-05-17 Thread David Miller
From: Dimitris Michailidis Date: Mon, 16 May 2016 15:33:35 -0700 > The goal of netdev_add_tso_features() is to enable all TSO features but > it unintentionally loses NETIF_F_ALL_FOR_ALL features. This is because > the netdev_increment_features() it calls clears any

Re: [PATCH v2 net-next] bpf: arm64: remove callee-save registers use for tmp registers

2016-05-17 Thread David Miller
From: Yang Shi Date: Mon, 16 May 2016 16:36:26 -0700 > In the current implementation of ARM64 eBPF JIT, R23 and R24 are used for > tmp registers, which are callee-saved registers. This leads to variable size > of JIT prologue and epilogue. The latest blinding constant change

Re: [PATCH] asix: Fix offset calculation in asix_rx_fixup() causing slow transmissions

2016-05-17 Thread David Miller
From: John Stultz Date: Mon, 16 May 2016 20:36:15 -0700 > In testing with HiKey, we found that since > commit 3f30b158eba5 ("asix: On RX avoid creating bad Ethernet > frames"), > we're seeing lots of noise during network transfers: ... > And network throughput ends up

Re: [PATCH v2 2/2] net: Fix coding style warnings and errors.

2016-05-17 Thread David Miller
Whenever you have to make changes to a patch within a series, you must always resubmit the entire series, not just the one that need changes.

Re: [patch net] switchdev: pass pointer to fib_info instead of copy

2016-05-17 Thread David Miller
From: Jiri Pirko Date: Tue, 17 May 2016 18:58:08 +0200 > From: Jiri Pirko > > The problem is that fib_info->nh is [0] so the struct fib_info > allocation size depends on number of nexthops. If we just copy fib_info, > we do not copy the nexthops info and

[PATCH v2 2/2] net: Fix coding style warnings and errors.

2016-05-17 Thread Amit Ghadge
This is a patch to clean checkpatch warnings and errors in the Space.c file. Clean up the following warnings and errors. WARNING : * Block comments use * on subsequent lines * Missing a blank line after declarations * networking block comments don't use an empty /* line, use /* * please, no space

Re: pull-request: wireless-drivers-next 2016-05-13

2016-05-17 Thread Kalle Valo
David Miller writes: > From: Kalle Valo > Date: Tue, 17 May 2016 09:43:34 +0300 > >> I noticed that you had marked this as Superseded in pathwork[1]. I was >> actually hoping that you would pull this with the instructions how to >> fix the conflict.

[patch net] switchdev: pass pointer to fib_info instead of copy

2016-05-17 Thread Jiri Pirko
From: Jiri Pirko The problem is that fib_info->nh is [0] so the struct fib_info allocation size depends on number of nexthops. If we just copy fib_info, we do not copy the nexthops info and driver accesses memory which is not ours. Given the fact that fib4 does not defer

Re: linux-4.6/net/kcm/kcmsock.c:1508: bad if test ?

2016-05-17 Thread Cong Wang
On Tue, May 17, 2016 at 9:44 AM, David Miller wrote: > From: Cong Wang > Date: Tue, 17 May 2016 09:04:21 -0700 > >> On Mon, May 16, 2016 at 11:40 AM, David Binderman >> wrote: >>> Hello there, >>> >>>

Re: linux-4.6/net/kcm/kcmsock.c:1508: bad if test ?

2016-05-17 Thread David Miller
From: Cong Wang Date: Tue, 17 May 2016 09:04:21 -0700 > On Mon, May 16, 2016 at 11:40 AM, David Binderman > wrote: >> Hello there, >> >> linux-4.6/net/kcm/kcmsock.c:1508]: (style) Checking if unsigned >> variable 'copied' is less than zero.

Re: [PATCH net] net: dsa: mv88e6xxx: remove bridge work

2016-05-17 Thread David Miller
From: Vivien Didelot Date: Tue, 17 May 2016 11:39:23 -0400 > Do we want to send this fix to -net as well? net isn't open and is irrelevant right now, everything goes through the net-next tree since we are in the merge window.

Aw: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer

2016-05-17 Thread Lino Sanfilippo
Hi, > Von: "Shuyu Wei" > @@ -685,13 +684,15 @@ static int arc_emac_tx(struct sk_buff *skb, struct > net_device *ndev) > wmb(); > > skb_tx_timestamp(skb); > + priv->tx_buff[*txbd_curr].skb = skb; > + > + dma_wmb(); > > *info = cpu_to_le32(FOR_EMAC

Re: [PATCH net] tipc: fix nametable publication field in nl compat

2016-05-17 Thread David Miller
From: Richard Alpe Date: Tue, 17 May 2016 16:57:37 +0200 > The publication field of the old netlink API should contain the > publication key and not the publication reference. > > Fixes: 44a8ae94fd55 (tipc: convert legacy nl name table dump to nl compat) >

Re: [PATCH v2 net] drivers: net: Don't print unpopulated net_device name

2016-05-17 Thread David Miller
From: Harvey Hunt Date: Tue, 17 May 2016 14:33:27 +0100 > For ethernet devices, net_device.name will be eth%d before > register_netdev() is called. Don't print the net_device name until > the format string is replaced. > > Signed-off-by: Harvey Hunt

Re: [PATCH net-next 1/1] qed: add support for dcbx.

2016-05-17 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Tue, 17 May 2016 06:44:26 -0400 > This patch adds the necessary driver support for Management Firmware to > configure the device/firmware with the dcbx results. Management Firmware > is responsible for communicating the DCBX and

Re: [PATCH v3 -net-next] ravb: Add missing free_irq() calls to ravb_close()

2016-05-17 Thread David Miller
From: Geert Uytterhoeven Date: Tue, 17 May 2016 11:05:34 +0200 > When reopening the network device on ra7795/salvator-x, e.g. after a > DHCP timeout: > > IP-Config: Reopening network devices... > genirq: Flags mismatch irq 139. (eth0:ch0:rx_be) vs.

Re: [RESEND PATCH v6 0/6] Add Ethernet support on STM32F429

2016-05-17 Thread David Miller
From: Maxime Coquelin Date: Tue, 17 May 2016 11:20:16 +0200 > Hi David, > > 2016-05-09 21:06 GMT+02:00 David Miller : >> From: Alexandre TORGUE >> Date: Mon, 9 May 2016 12:31:33 +0200 >> >>> STM32F429 Chip embeds a

Re: [patch v2] qed: Remove a stray tab

2016-05-17 Thread David Miller
From: Dan Carpenter Date: Tue, 17 May 2016 11:09:20 +0300 > This line was indented more than it should be. > > Signed-off-by: Dan Carpenter > Acked-by: Yuval Mintz Applied.

Re: [PATCH net] net: dsa: mv88e6xxx: remove bridge work

2016-05-17 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> Do we want to send this fix to -net as well? > > I don't see this bug as being highly critical that it needs to be > fixed immediately. > > I would suggest we wait until -rc1 is out, and then produce a backport > version. Given the changes we

Re: pull-request: wireless-drivers-next 2016-05-13

2016-05-17 Thread David Miller
From: Kalle Valo Date: Tue, 17 May 2016 09:43:34 +0300 > I noticed that you had marked this as Superseded in pathwork[1]. I was > actually hoping that you would pull this with the instructions how to > fix the conflict. But do you actually want me to resubmit the pull >

Re: [net-next 0/2][pull request] 10GbE Intel Wired LAN Driver Updates 2016-05-16

2016-05-17 Thread David Miller
From: Jeff Kirsher Date: Mon, 16 May 2016 19:25:22 -0700 > This series contains 2 fixes to ixgbe only. Pulled, thanks Jeff.

Re: linux-4.6/net/kcm/kcmsock.c:1508: bad if test ?

2016-05-17 Thread Cong Wang
On Mon, May 16, 2016 at 11:40 AM, David Binderman wrote: > Hello there, > > linux-4.6/net/kcm/kcmsock.c:1508]: (style) Checking if unsigned > variable 'copied' is less than zero. > > Source code is > > if (copied < 0) { > > but > >size_t copied; > > Suggest

Re: [PATCH net] net: dsa: mv88e6xxx: remove bridge work

2016-05-17 Thread Andrew Lunn
On Tue, May 17, 2016 at 11:39:23AM -0400, Vivien Didelot wrote: > Hi David, > > David Miller writes: > > > From: Vivien Didelot > > Date: Fri, 13 May 2016 21:28:28 -0400 > > > >> Hi David, > >> > >> Vivien Didelot

Re: [PATCH] ixgbe: take online CPU number as MQ max limit when alloc_etherdev_mq()

2016-05-17 Thread Alexander Duyck
On Tue, May 17, 2016 at 2:00 AM, ethan zhao wrote: > Alexander, > > > On 2016/5/17 0:09, Alexander Duyck wrote: >> >> On Sun, May 15, 2016 at 7:59 PM, ethan zhao wrote: >>> >>> Alexander, >>> >>> On 2016/5/14 0:46, Alexander Duyck wrote: On

Re: [PATCH net] net: dsa: mv88e6xxx: remove bridge work

2016-05-17 Thread Vivien Didelot
Hi David, David Miller writes: > From: Vivien Didelot > Date: Fri, 13 May 2016 21:28:28 -0400 > >> Hi David, >> >> Vivien Didelot writes: >> >>> Now that the bridge code defers the switchdev port

Re: [PATCH 2/2] net: Fix coding style warnings and errors.

2016-05-17 Thread David Miller
From: Amit Ghadge Date: Tue, 17 May 2016 08:46:30 +0530 > Clean up checkpatch warnings and errors: > > * WARNING: Block comments use * on subsequent lines > * WARNING: Missing a blank line after declarations > * WARNING: networking block comments don't use an empty /* line,

  1   2   >