Hi Eric,
On Thu, May 26, 2016 at 06:08:22AM -0700, Eric Dumazet wrote:
> On Thu, 2016-05-26 at 16:41 +0800, Feng Tang wrote:
> > On Wed, May 25, 2016 at 07:53:41PM -0400, David Miller wrote:
>
> > >
> > > But now that we have at least two instances of this code we really
> > > need to put a comm
> This looks right to me, but doesn't ether_addr_copy() have alignment
> requirements? Could someone more familiar with that review these
> changes to ensure they're met?
Thanks for catching this.
The requirement is to be __aligned(2). I've added 4 instances of
ether_addr_copy with 8 addresses as
Hi:
This series tries to optimize vhost_net polling at two points:
- Stop rx polling for reduicng the unnecessary wakeups during
handle_rx().
- Conditonally enable tx polling for reducing the unnecessary
traversing and spinlock touching.
Test shows about 17% improvement on rx pps.
Please re
We always poll tx for socket, this is sub optimal since:
- it will be only used when we exceed the sndbuf of the socket.
- since we use two independent polls for tx and vq, this will slightly
increase the waitqueue traversing time and more important, vhost
could not benefit from commit
9e641
We don't stop rx polling socket during rx processing, this will lead
unnecessary wakeups from under layer net devices (E.g
sock_def_readable() form tun). Rx will be slowed down in this
way. This patch avoids this by stop polling socket during rx
processing. A small drawback is that this introduces
Hi All,
On Mon, May 30, 2016 at 12:53 PM, Kirtika Ruchandani
wrote:
> This patch fixes the following spacing issues reported
> by checkpatch.pl -
> - space preferred around that
> - no space needed after cast.
> - Alignment should match open parenthesis
> - suspect code indent for conditional st
Hi Kirtika,
On Mon, May 30, 2016 at 4:04 PM, Kirtika Ruchandani
wrote:
>> Adding the brackets around the & expression doesn't look spacing
>> related to me. What's the exact warning this is fixing?
>
> From the commit message - "This patch also contains two hunks to fix
> 'line over 80 characters
> Adding the brackets around the & expression doesn't look spacing
> related to me. What's the exact warning this is fixing?
>From the commit message - "This patch also contains two hunks to fix
'line over 80 characters',
that are spacing related". This is the second hunk, the first being
the comm
From: Eric Garver
Date: Thu, 26 May 2016 12:28:05 -0400
> Clarify how secure_redirects works. Mention that RFC1122 always applies.
>
> Signed-off-by: Eric Garver
Applied, thanks.
From: Edward Cree
Date: Thu, 26 May 2016 21:46:05 +0100
> Signed-off-by: Edward Cree
> ---
> This seems to work in my testing, but I first looked at the flow dissector
> API less than four hours ago, so I might be doing it wrong.
>
> I still think that this is too big a change for 'net' and tha
From: Baozeng Ding
Date: Thu, 26 May 2016 21:07:42 +0800
> Fix a logic error to avoid potential null pointer dereference.
>
> Signed-off-by: Baozeng Ding
Applied.
From: Elad Kanfi
Date: Thu, 26 May 2016 15:00:06 +0300
> From: Elad Kanfi
>
> Since NAPI works by shutting down event interrupts when theres
> work and turning them on when theres none, the net driver must
> make sure that interrupts are disabled when it reschedules polling.
> By calling napi_r
From: Dan Carpenter
Date: Thu, 26 May 2016 09:46:22 +0300
> If we pass ERR_PTR(-EFAULT) to kfree() then it's going to oops.
>
> Fixes: 2ece068e1b1d ('ptp: use memdup_user().')
> Signed-off-by: Dan Carpenter
Applied, thanks.
Hi All,
On Mon, May 30, 2016 at 12:54 PM, Kirtika Ruchandani
wrote:
> This patch fixes the checkpatch.pl warning -
> "prefer kcalloc over kzalloc with multiply"
>
> Signed-off-by: Kirtika Ruchandani
Looks right to me.
Reviewed-by: Julian Calaby
Thanks,
Julian Calaby
> ---
> net/wireless/
From: Andy Shevchenko
Date: Thu, 26 May 2016 14:43:52 +0300
> Use %*ph specifier to dump small buffers in hex format instead doing this
> byte-by-byte.
>
> Signed-off-by: Andy Shevchenko
Applied.
From: wangyunjian
Date: Thu, 26 May 2016 14:27:59 +0800
> In function virtnet_open() and virtnet_probe(), func try_fill_recv()
> will be executed at the same time. VQ in virtqueue_add() is not protected
> well and BUG_ON will be triggered when virito_net.ko being removed.
>
> Signed-off-by: Yunj
Hi All,
On Mon, May 30, 2016 at 12:54 PM, Kirtika Ruchandani
wrote:
> This patch fixes the checkpatch.pl warning "foo * bar should be
> foo *bar"
>
> Signed-off-by: Kirtika Ruchandani
Looks right to me.
Reviewed-by: Julian Calaby
Thanks,
Julian Calaby
> ---
> net/wireless/nl80211.c | 4 +
Hi All,
On Mon, May 30, 2016 at 12:54 PM, Kirtika Ruchandani
wrote:
> Fix 'implementation' spelling, reported by checkpatch.pl
>
> Signed-off-by: Kirtika Ruchandani
Looks right to me.
Reviewed-by: Julian Calaby
Thanks,
Julian Calaby
> ---
> net/wireless/nl80211.c | 2 +-
> 1 file changed
Hi All,
On Mon, May 30, 2016 at 12:53 PM, Kirtika Ruchandani
wrote:
> This patch fixes the checkpatch.pl warning "multiple assignments
> should be avoided."
>
> Signed-off-by: Kirtika Ruchandani
I'm not sure I agree with checkpatch here, but this looks right to me.
Reviewed-by: Julian Calaby
From: Christoph Fritz
Date: Thu, 26 May 2016 04:06:47 +0200
> @@ -1695,6 +1745,7 @@ static int smsc95xx_resume(struct usb_interface *intf)
>
> /* do this first to ensure it's cleared even in error case */
> pdata->suspend_flags = 0;
> + schedule_delayed_work(&pdata->carrier_chec
Hi All,
On Mon, May 30, 2016 at 12:53 PM, Kirtika Ruchandani
wrote:
> This patch fixes the following spacing issues reported
> by checkpatch.pl -
> - space preferred around that
> - no space needed after cast.
> - Alignment should match open parenthesis
> - suspect code indent for conditional st
From: Arnd Bergmann
Date: Wed, 25 May 2016 16:50:45 +0200
> A recent cleanup moved MAX_IPTUN_ENCAP_OPS along with some other
> definitions, but it is now invisible when CONFIG_INET is
> not defined, but still referenced from ip6_tunnel.h:
>
> In file included from net/xfrm/xfrm_input.c:17:0:
> i
From: Arnd Bergmann
Date: Wed, 25 May 2016 16:50:46 +0200
> A previous patch added the fou6.ko module, but that failed to link
> in a couple of configurations:
>
> net/built-in.o: In function `ip6_tnl_encap_add_fou_ops':
> net/ipv6/fou6.c:88: undefined reference to `ip6_tnl_encap_add_ops'
> net/
Hi All,
On Mon, May 30, 2016 at 12:52 PM, Kirtika Ruchandani
wrote:
> This patch fixes the warning - "comparison to NULL (foo == NULL)
> could be written as (!foo)"
>
> Signed-off-by: Kirtika Ruchandani
Looks right to me.
Reviewed-by: Julian Calaby
Thanks,
Julian Calaby
> ---
> net/wirele
Hi All,
On Mon, May 30, 2016 at 12:52 PM, Kirtika Ruchandani
wrote:
> This patch fixes the following checkpatch,pl warning -
> - braces {} should be used on all arms of this statement.
>
> Signed-off-by: Kirtika Ruchandani
Looks right to me.
Reviewed-by: Julian Calaby
Thanks,
Julian Calaby
Hi All,
On Mon, May 30, 2016 at 12:52 PM, Kirtika Ruchandani
wrote:
> This patch fixes the checkpatch,pl to prefer ether_addr_copy
> over memcpy.
>
> Signed-off-by: Kirtika Ruchandani
This looks right to me, but doesn't ether_addr_copy() have alignment
requirements? Could someone more familiar
In the case of CHECKSUM_COMPLETE the skb checksum should be updated in
{push,pop}_mpls() as they the type in the ethernet header.
As suggested by Pravin Shelar.
Cc: Pravin Shelar
Fixes: 25cd9ba0abc0 ("openvswitch: Add basic MPLS support to kernel")
Signed-off-by: Simon Horman
---
v2
* Use helpe
There are two firmware events we handle similarly in brcmfmac:
BRCMF_E_LINK and BRCMF_E_IF. The difference from firmware point of view
is that the first one means BSS remains present in the firmware. Trying
to (re)create it (e.g. when adding new virtual interface) will result in
an error.
Current
Fix 'implementation' spelling, reported by checkpatch.pl
Signed-off-by: Kirtika Ruchandani
---
net/wireless/nl80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 6f8e2a7..c6d870e 100644
--- a/net/wireless/nl80211.c
+++
This patch fixes the checkpatch.pl warning -
"prefer kcalloc over kzalloc with multiply"
Signed-off-by: Kirtika Ruchandani
---
net/wireless/nl80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 46757af..2964406 100644
This patch fixes the checkpatch.pl warning "foo * bar should be
foo *bar"
Signed-off-by: Kirtika Ruchandani
---
net/wireless/nl80211.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index c6d870e..46757af 100644
--- a/net/w
This patch fixes the checkpatch.pl warning "multiple assignments
should be avoided."
Signed-off-by: Kirtika Ruchandani
---
net/wireless/nl80211.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index ad7cdce..6f8e2a7 100644
--
This patch fixes the following spacing issues reported
by checkpatch.pl -
- space preferred around that
- no space needed after cast.
- Alignment should match open parenthesis
- suspect code indent for conditional statements
- Statements should start on a tabstop
This patch also contains two hunk
This patch fixes the warning - "comparison to NULL (foo == NULL)
could be written as (!foo)"
Signed-off-by: Kirtika Ruchandani
---
net/wireless/nl80211.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 945405d..11cbf0b
This patch fixes the checkpatch,pl to prefer ether_addr_copy
over memcpy.
Signed-off-by: Kirtika Ruchandani
---
net/wireless/nl80211.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index cd422bd..34b8fbe 100644
--- a/
This patch fixes the following checkpatch,pl warning -
- braces {} should be used on all arms of this statement.
Signed-off-by: Kirtika Ruchandani
---
net/wireless/nl80211.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/net/wireless/nl80211.c b/net/
This patch fixes the following checkpatch.pl issues -
- Please don't use multiple blank lines
- Blank lines aren't necessary before a close brace
- Missing a blank line after declarations
Reviewed-by: Julian Calaby
Signed-off-by: Kirtika Ruchandani
---
net/wireless/nl80211.c | 22 ++
This patch fixes the following checkpatch.pl warnings about
comments in nl80211.c :
- networking block comments don't use an empty '/*' line
- block comments use a trailing '*/' on a separate line
Reviewed-by: Julian Calaby
Signed-off-by: Kirtika Ruchandani
---
net/wireless/nl80211.c | 129
This patch-set attempts to fix checkpatch.pl issues found in nl80211.c.
Each patch describes the specific warnings/checks/errors it addresses.
This patch-set ignores 'line over 80 chars' warnings, except for 2 cases.
Please check for issues with the 'fixes' for 'alignment should match
open parenthe
The miscellaneous operation is implemented in BIOS, the kernel can call
_DSM method help to call the implementation in ACPI case. Here is a patch
to do that.
Signed-off-by: Kejian Yan
Signed-off-by: Yisen Zhuang
---
change log:
v2: use a serial function to implement the reset sequence
v1: fir
hns-mdio needs to register itself to mii-bus. The info of the device can
be read by both DT and ACPI.
HNS tries to call Linux PHY driver to help access PHY-devices, the HNS
hardware topology is as below. The MDIO controller may control several
PHY-devices, and each PHY-device connects to a MAC devi
acpi_evaluate_dsm() will be used to handle the _DSM method in ACPI case.
It will be compiled in non-ACPI case, but the function is in acpi_bus.h
and acpi_bus.h can only be used in ACPI case, so this patch add the stub
function to linux/acpi.h to make compiled successfully in non-ACPI cases.
Cc: Ra
The misc operation for different hw platform may be different, if using
current implementation, it will add a new branch on each function for
every new hw platform, so we add a method for this operation.
Signed-off-by: Kejian Yan
Signed-off-by: Yisen Zhuang
---
drivers/net/ethernet/hisilicon/hn
Enet needs to get configration parameter by acpi. This patch
adds support of ACPI for enet. The configuration parameter will
be configed in BIOS.
Signed-off-by: Kejian Yan
Signed-off-by: Yisen Zhuang
---
change log:
v2:
1. use acpi_dev_found() instead of acpi_match_device_ids()
2. use
This series adds HNS support of acpi. The routine will call some ACPI
helper functions, like acpi_dev_found() and acpi_evaluate_dsm(), which
are not included in other cases. In order to make system compile
successfully in other cases except ACPI, it needs to add relative stub
functions to linux/acp
Hns-mdio only supports DT case now. do some cleanup to prepare
for introducing other cases later, no functional change.
Signed-off-by: Kejian Yan
Signed-off-by: Yisen Zhuang
---
drivers/net/ethernet/hisilicon/hns_mdio.c | 46 +++
1 file changed, 23 insertions(+), 23
In ACPI case, there is no interface to register phy device to mdio-bus.
Phy device has to be registered itself to mdio-bus, and then enet can
get the phy device's info so that it can config the phy-device to help
to trasmit and receive data.
HNS hardware topology is as below. The MDIO controller ma
OF series functions can be used only for DT case. Use unified
device property function instead to support both DT and ACPI.
Signed-off-by: Kejian Yan
Signed-off-by: Yisen Zhuang
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 9 +
drivers/net/ethernet/hisilicon/hns/hns_enet.c
Dsaf needs to get configuration parameter by ACPI, so this patch add
support of ACPI.
Signed-off-by: Kejian Yan
Signed-off-by: Yisen Zhuang
---
change log:
v2:
1. use dev_of_node() instead of IS_ENABLED() to check if it is in
DT case,
2. split a new patch to implement misc operation method,
As device_node is only used by DT case, HNS needs to treat the other
cases including ACPI. It needs to use uniform ways to handle both of
DT and ACPI. This patch chooses phy_device, and of_phy_connect and
of_phy_attach are only used by DT case. It needs to use uniform interface
to handle that seque
acpi_dev_found() will be used to detect if a given ACPI device is in the
system. It will be compiled in non-ACPI case, but the function is in
acpi_bus.h and acpi_bus.h can only be used in ACPI case, so this patch add
the stub function to linux/acpi.h to make compiled successfully in
non-ACPI cases.
As device_node is only used by DT case, it is expected to find uniform
ways. So fwnode_handle is the suitable method.
Signed-off-by: Kejian Yan
Signed-off-by: Yisen Zhuang
---
change log:
v2: remove the redundant line
v1: first submit
link: https://lkml.org/lkml/2016/5/13/98
---
drivers/net
As irq_of_parse_and_map is only used by DT case, it is excepted to use
a uniform interface. So it is used platform_get_irq() instead.
Signed-off-by: Kejian Yan
Signed-off-by: Yisen Zhuang
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletio
On 2016/05/28 13:37, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> $bridge -c vlan show
> port vlan ids
> swp1 1 PVID Egress Untagged
>10-13
>
> swp2 1 PVID Egress Untagged
>10-13
>
> br01 PVID Egress Untagged
>
> $bridge -j vlan show
> {
> "swp1": [{
>
Hi Kirtika,
On Mon, May 30, 2016 at 10:44 AM, Kirtika Ruchandani
wrote:
>>> There's too much stuff here to quickly review, it'd be nice if you
>>> could split this up into patches that do the following:
>
> Is it preferable to resend the whole patch-set or just patch 3/3 in
> this one as a separa
>> There's too much stuff here to quickly review, it'd be nice if you
>> could split this up into patches that do the following:
Is it preferable to resend the whole patch-set or just patch 3/3 in
this one as a separate set?
> There's too much stuff here to quickly review, it'd be nice if you
> could split this up into patches that do the following:
Thanks, I will send out a v2 with the split you suggested.
Hi Kirtika,
On Sun, May 29, 2016 at 1:31 PM, Kirtika Ruchandani
wrote:
> This patch fixes the following checkpatch.pl issues -
There's too much stuff here to quickly review, it'd be nice if you
could split this up into patches that do the following:
Space issues:
> - space preferred around that
Hi All,
On Sun, May 29, 2016 at 1:31 PM, Kirtika Ruchandani
wrote:
> This patch fixes the following checkpatch.pl issues -
> - Please don't use multiple blank lines
> - Blank lines aren't necessary before a close brace
> - Missing a blank line after declarations
>
> Signed-off-by: Kirtika Ruchand
Hi All,
On Sun, May 29, 2016 at 1:30 PM, Kirtika Ruchandani
wrote:
> This patch fixes the following checkpatch.pl warnings about
> comments in nl80211.c :
> - networking block comments don't use an empty '/*' line
> - block comments use a trailing '*/' on a separate line
>
> Signed-off-by: Kirtik
Hi,
[auto build test WARNING on next-20160527]
url:
https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/brcmfmac-don-t-remove-interface-on-link-down-firmware-event/20160530-054251
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160
There are two firmware events we handle similarly in brcmfmac:
BRCMF_E_LINK and BRCMF_E_IF. The difference from firmware point of view
is that the first one means BSS remains present in the firmware. Trying
to (re)create it (e.g. when adding new virtual interface) will result in
an error.
Current
From: Kazuya Mizuguchi
Use SET_RUNTIME_PM_OPS macro instead of assigning a member of
dev_pm_ops directly.
Signed-off-by: Kazuya Mizuguchi
Signed-off-by: Yoshihiro Kaneko
---
This patch is based on the master branch of David Miller's next networking
tree.
drivers/net/ethernet/renesas/ravb_ma
From: Masaru Nagai
This patch adds enabling separation filter(ESF) is setting value of B'11.
This setting filter for separating AVB stream frames from non-AVB stream
frames is enabled. Non-matching frames from a stream are processed in
queue 0(best effort). H/W manual recommends B'11 or B'10.
Whe
Since commit 5cd1adb ("Update to current iptables headers") the build
with m_ipt.o and the following config will fail:
TC_CONFIG_XT:=n
TC_CONFIG_XT_OLD:=n
TC_CONFIG_XT_OLD_H:=n
This patch renames "iptables_target" to "xtables_target" and some other
things which gets renamed and I noticed while re
On Tue, May 17, 2016 at 12:50:02AM +0300, Yuval Mintz wrote:
> The new QED firmware contains several new additions;
> As for bug-fixes, it fixes a couple of issues:
> - Wrong classification of packets in 4-port devices.
> - Anti-spoof interoperability with encapsulated packets.
> - Tx-switching
On Thu, May 26, 2016 at 11:58 PM, Simon Horman
wrote:
> In the case of CHECKSUM_COMPLETE the skb checksum should be updated in
> {push,pop}_mpls() as they the type in the ethernet header.
>
> As suggested by Pravin Shelar.
>
> Cc: Pravin Shelar
> Fixes: 25cd9ba0abc0 ("openvswitch: Add basic MPLS
When the peer link is created, its "iflink" information is not
advertised through netlink. If a user is maintaining a cache from all
updates, it will miss this information:
2: veth0@NONE: mtu 1500 qdisc noop state DOWN group
default
link/ether ae:0e:08:af:fb:a0 brd ff:ff:ff:ff:ff:ff
Now we cannot distinguish that one sk is a udp or sctp style when
we use ss to dump sctp_info. it's necessary to dump it as well.
For sctp_diag, ss support is not officially available, thus there
are no official users of this yet, so we can add this field in the
middle of sctp_info without breakin
69 matches
Mail list logo
