Re: [PATCH 01/12] net: mediatek: fix DQL support

2016-06-05 Thread John Crispin
On 05/06/2016 09:32, David Miller wrote: > From: John Crispin > Date: Sun, 5 Jun 2016 08:32:54 +0200 > >> @@ -625,7 +625,16 @@ static int mtk_tx_map(struct sk_buff *skb, struct >> net_device *dev, >> WRITE_ONCE(itxd->txd3, (TX_DMA_SWC | TX_DMA_PLEN0(skb_headlen(skb)) | >>

Re: [RFC PATCH 0/4] Make inotify instance/watches be accounted per userns

2016-06-05 Thread Nikolay Borisov
On 06/03/2016 11:41 PM, Eric W. Biederman wrote: > Nikolay Borisov writes: > >> On 06/02/2016 07:58 PM, Eric W. Biederman wrote: >>> >>> Nikolay please see my question for you at the end. > [snip] >>> All of that said there is definitely a practical question that needs to >>> be asked. Nikola

[Patch v3 4/5] fsl/qe: Add QE TDM lib

2016-06-05 Thread Zhao Qiang
QE has module to support TDM, some other protocols supported by QE are based on TDM. add a qe-tdm lib, this lib provides functions to the protocols using TDM to configurate QE-TDM. Signed-off-by: Zhao Qiang --- Changes for v2: - delete dead code - use strcmp instead of strcasecmp

[Patch v3 5/5] drivers/net: support hdlc function for QE-UCC

2016-06-05 Thread Zhao Qiang
The driver add hdlc support for Freescale QUICC Engine. It support NMSI and TSA mode. Signed-off-by: Zhao Qiang --- Changes for v2: - remove useless code. - remove Unnecessary casts - return IRQ_NONE when there are no interrupt - remove Useless comments Changes for

[Patch v3 1/5] fsl/qe: add rx_sync and tx_sync for TDM mode

2016-06-05 Thread Zhao Qiang
Rx_sync and tx_sync are used by QE-TDM mode, add them to struct ucc_fast_info. Signed-off-by: Zhao Qiang --- Changes for v2: - use strcmp instead of strcasecmp Changes for v3: - na drivers/soc/fsl/qe/qe.c | 6 ++ include/soc/fsl/qe/qe.h | 2 ++ include/soc/fsl/q

[Patch v3 2/5] fsl/qe: setup clock source for TDM mode

2016-06-05 Thread Zhao Qiang
Add tdm clock configuration in both qe clock system and ucc fast controller. Signed-off-by: Zhao Qiang --- Changes for v2: - break codes getting clock_bits and source to smaller functions. - add __iomem to qe_mux_reg - add bits operation functions for qe and use it

[PATCH net 3/3] bnxt_en: Simplify VLAN receive logic.

2016-06-05 Thread Michael Chan
Since both CTAG and STAG rx acceleration must be enabled together, we only need to check one feature flag (NETIF_F_HW_VLAN_CTAG_RX) before calling __vlan_hwaccel_put_tag(). Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 29 + 1 file change

[PATCH net 2/3] bnxt_en: Enable and disable RX CTAG and RX STAG VLAN acceleration together.

2016-06-05 Thread Michael Chan
The hardware can only be set to strip or not strip both the VLAN CTAG and STAG. It cannot strip one and not strip the other. Add logic to bnxt_fix_features() to toggle both feature flags when the user is toggling one of them. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/b

[PATCH net 0/3] bnxt_en: Bug fixes.

2016-06-05 Thread Michael Chan
Fix a race condition and VLAN rx acceleration logic. Michael Chan (3): bnxt_en: Fix tx push race condition. bnxt_en: Enable and disable RX CTAG and RX STAG VLAN acceleration together. bnxt_en: Simplify VLAN receive logic. drivers/net/ethernet/broadcom/bnxt/bnxt.c | 47 +

[PATCH net 1/3] bnxt_en: Fix tx push race condition.

2016-06-05 Thread Michael Chan
Set the is_push flag in the software BD before the tx data is pushed to the chip. It is possible to get the tx interrupt as soon as the tx data is pushed. The tx handler will not handle the event properly if the is_push flag is not set and it will crash. Signed-off-by: Michael Chan --- drivers

Re: [PATCH 09/12] net: mediatek: increase watchdog_timeo

2016-06-05 Thread John Crispin
On 05/06/2016 16:56, Andrew Lunn wrote: > On Sun, Jun 05, 2016 at 08:33:02AM +0200, John Crispin wrote: >> During stress testing, after reducing the threshold value, we have seen >> TX timeouts that were caused by the watchdog_timeo value being too low. >> Increase the value to 5 * HZ which is a

Re: [Patch net] act_police: fix a crash during removal

2016-06-05 Thread Cong Wang
On Fri, Jun 3, 2016 at 4:28 PM, David Miller wrote: > From: Cong Wang > Date: Wed, 1 Jun 2016 16:15:20 -0700 > >> The police action is using its own code to initialize tcf hash >> info, which makes us to forgot to initialize a->hinfo correctly. >> Fix this by calling the helper function tcf_hash

Re: [net-next PATCH 3/3] net sched actions: aggregate dumping of actions timeinfo

2016-06-05 Thread Cong Wang
On Sun, Jun 5, 2016 at 7:26 AM, Jamal Hadi Salim wrote: > diff --git a/include/net/act_api.h b/include/net/act_api.h > index 8389c00..5453f52 100644 > --- a/include/net/act_api.h > +++ b/include/net/act_api.h > @@ -80,6 +80,14 @@ static inline void tcf_lastuse_update(struct tcf_t *tm) >

Re: [PATCH net-next 1/3] arm64: bpf: implement bpf_tail_call() helper

2016-06-05 Thread Z Lim
Hi Daniel, On Sun, Jun 5, 2016 at 12:53 AM, Daniel Borkmann wrote: > On 06/05/2016 01:46 AM, kbuild test robot wrote: >> >> Hi, >> >> [auto build test ERROR on net-next/master] >> >> url: >> https://github.com/0day-ci/linux/commits/Zi-Shen-Lim/arm6

RE: [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced"

2016-06-05 Thread Fugang Duan
From: Colin King Sent: Sunday, June 05, 2016 3:01 AM > To: Fugang Duan ; netdev@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > Subject: [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced" > > From: Colin Ian King > > trivial fix to spelling mistake in pr_err message > > Sign

Re: rhashtable - rhashtable_insert_fast failed

2016-06-05 Thread Herbert Xu
On Sat, Jun 04, 2016 at 09:35:27AM +0200, Phil Sutter wrote: > [Cc'ing other interested parties, therefore full-quoting.] > > Hi Helge, > > On Fri, Jun 03, 2016 at 10:22:26PM +0200, Helge Deller wrote: > > Hi Phil, > > > > I'm testing 4.7.0-rc1-64bit on a parisc/hppa machine and get > > those me

Re: [PATCH v3 RESEND 0/7] Add MDIO bus multiplexer support for iProc SoCs

2016-06-05 Thread David Miller
From: Andrew Lunn Date: Fri, 3 Jun 2016 18:32:47 +0200 >> Reason for resend: >> -Rebased on v4.7-rc1 > > How do you see this getting merged? Via netdev? If so, you should be > based on net-next/master, not v4.7-rc1. Indeed, please respin. Also, in your Subject lines, always have a space after

Re: [PATCH net-next 2/9] net: dsa: Add support for parsing the old binding

2016-06-05 Thread Andrew Lunn
> How much support do we want to have for the old binding for in tree > platforms? Is the plan to migrate them all to the new binding? I think there are three cases to consider. 1) There are some old boards using setup.c files which have a platform device, platform data, etc. I've never used D

Re: [PATCH net-next v2 0/5] hv_netvsc: cleanup after untangling the pointer mess

2016-06-05 Thread David Miller
From: Vitaly Kuznetsov Date: Fri, 3 Jun 2016 17:50:57 +0200 > Changes since v1: > - resend when net-next is open [David Miller] > - rebased to current net-next. > > After we made traveling through our internal structures explicit it became > obvious that some functions take arguments they don't

Re: [PATCH net] bnx2x: allow adding VLANs while interface is down

2016-06-05 Thread David Miller
From: Michal Schmidt Date: Fri, 3 Jun 2016 15:32:18 +0200 > Since implementing VLAN filtering in commit 05cc5a39ddb74 > ("bnx2x: add vlan filtering offload") bnx2x refuses to add a VLAN while > the interface is down: > > # ip link add link enp3s0f0 enp3s0f0_10 type vlan id 10 > RTNETLINK an

Re: [PATCHv2 net-next] sctp: sctp should change socket state when shutdown is received

2016-06-05 Thread David Miller
From: Xin Long Date: Fri, 3 Jun 2016 22:42:45 +0800 > Now sctp doesn't change socket state upon shutdown reception. It changes > just the assoc state, even though it's a TCP-style socket. > > For some cases, if we really need to check sk->sk_state, it's necessary to > fix this issue, at least w

Re: [PATCH 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

2016-06-05 Thread David Miller
From: Date: Fri, 3 Jun 2016 02:07:15 -0700 > From: Tien Hock Loh > > This adds support for TSE PCS that uses SGMII adapter when the phy-mode of > the dwmac is set to sgmii > > Signed-off-by: Tien Hock Loh Please at least make an effort to use consistent coding style. You rework this functio

Re: [PATCH net-next] net: disable fragment reassembly if high_thresh is zero

2016-06-05 Thread David Miller
From: Michal Kubecek Date: Fri, 27 May 2016 17:53:52 +0200 > Before commit 6d7b857d541e ("net: use lib/percpu_counter API for > fragmentation mem accounting"), setting the reassembly high threshold > to 0 prevented fragment reassembly as first fragment would be always > evicted before second coul

Re: [PATCH net-next 7/9] net: dsa: Initialize CPU port ethtool ops per tree

2016-06-05 Thread Andrew Lunn
On Sun, Jun 05, 2016 at 03:29:01PM -0700, Florian Fainelli wrote: > Le 04/06/2016 13:38, Andrew Lunn a écrit : > >> index e8386157de30..938262010524 100644 > >> --- a/net/dsa/dsa2.c > >> +++ b/net/dsa/dsa2.c > >> @@ -346,7 +346,7 @@ static int dsa_ds_apply(struct dsa_switch_tree *dst, > >> struct

RE: [PATCH v2 1/2] ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround

2016-06-05 Thread Fugang Duan
From: Lucas Stach Sent: Saturday, June 04, 2016 12:31 AM > To: Shawn Guo ; Fugang Duan > Cc: devicet...@vger.kernel.org; patchwork-...@pengutronix.de; > ker...@pengutronix.de; linux-arm-ker...@lists.infradead.org; > netdev@vger.kernel.org > Subject: [PATCH v2 1/2] ARM: imx6: disable deeper idle

RE: ath9k gpio request

2016-06-05 Thread Pan, Miaoqing
Got it, thanks. There is no difference of the changes for AR9462 which is the chip Sudip tested. Thanks, Miaoqing -Original Message- From: Kalle Valo [mailto:kv...@codeaurora.org] Sent: Saturday, June 04, 2016 10:38 PM To: Pan, Miaoqing Cc: Sudip Mukherjee ; Stephen Rothwell ; ath9k-

Re: [PATCH RFC v7 3/5] skb_array: array based FIFO for skbs

2016-06-05 Thread Jason Wang
On 2016年06月03日 21:04, Michael S. Tsirkin wrote: On Fri, Jun 03, 2016 at 02:58:39PM +0200, Jesper Dangaard Brouer wrote: > >On Thu, 2 Jun 2016 19:08:26 +0300 "Michael S. Tsirkin" wrote: > > >A simple array based FIFO of pointers. Intended for net stack so uses > >skbs for type safety. Implem

Re: [linux-sunxi] [PATCH 1/5] ethernet: add sun8i-emac driver

2016-06-05 Thread Chen-Yu Tsai
On Mon, Jun 6, 2016 at 6:32 AM, André Przywara wrote: > On 03/06/16 10:56, LABBE Corentin wrote: > > Hi, > > first: thanks for posting this and the time and work that you spent on > it. With the respective DT nodes this works for me on the Pine64 and > turns this board eventually into something us

Re: [PATCH v2 net] fq_codel: fix NET_XMIT_CN behavior

2016-06-05 Thread Cong Wang
On Sun, Jun 5, 2016 at 1:55 PM, Eric Dumazet wrote: > On Sun, 2016-06-05 at 13:54 -0700, Eric Dumazet wrote: > >> BTW, we might need a similar fix in sch_fq.c > > I meant sch_sfq.c > Potentially all of the following: net/sched/sch_choke.c: return NET_XMIT_CN; net/sched/sch_fifo.c: return NET_

Re: [PATCH net-next 2/9] net: dsa: Add support for parsing the old binding

2016-06-05 Thread Florian Fainelli
Le 04/06/2016 13:00, Andrew Lunn a écrit : >> -static int dsa_cpu_parse(struct device_node *port, u32 index, >> - struct dsa_switch_tree *dst, >> - struct dsa_switch *ds) >> +static int _dsa_cpu_parse(struct dsa_switch_tree *dst, >> + st

Re: [PATCH net-next 4/9] net: dsa: Initialize ds->enabled_port_mask and ds->phys_mii_mask

2016-06-05 Thread Florian Fainelli
Le 04/06/2016 13:29, Andrew Lunn a écrit : >> @@ -517,6 +541,15 @@ static int dsa_parse_ports_dn(struct device_node >> *ports, struct dsa_switch *ds) >> return -EINVAL; >> >> ds->ports[reg].dn = port; >> + >> +if (dsa_port_is_cpu(port)) >> +

Re: [linux-sunxi] [PATCH 1/5] ethernet: add sun8i-emac driver

2016-06-05 Thread André Przywara
On 03/06/16 10:56, LABBE Corentin wrote: Hi, first: thanks for posting this and the time and work that you spent on it. With the respective DT nodes this works for me on the Pine64 and turns this board eventually into something useful. Some comments below: > This patch add support for sun8i-ema

Re: [PATCH net-next 8/9] net: dsa: bcm_sf2: Make it a real platform device driver

2016-06-05 Thread Florian Fainelli
Le 04/06/2016 13:55, Andrew Lunn a écrit : >> -static struct dsa_switch_driver bcm_sf2_switch_driver = { >> +static struct dsa_switch_driver bcm_sf2_switch_ops = { >> .tag_protocol = DSA_TAG_PROTO_BRCM, >> .probe = bcm_sf2_sw_drv_probe, >> .setup

Re: [PATCH net-next 7/9] net: dsa: Initialize CPU port ethtool ops per tree

2016-06-05 Thread Florian Fainelli
Le 04/06/2016 13:38, Andrew Lunn a écrit : >> index e8386157de30..938262010524 100644 >> --- a/net/dsa/dsa2.c >> +++ b/net/dsa/dsa2.c >> @@ -346,7 +346,7 @@ static int dsa_ds_apply(struct dsa_switch_tree *dst, >> struct dsa_switch *ds) >> continue; >> } >> >> -retur

Re: [PATCH 07/23] netfilter: x_tables: check standard target size too

2016-06-05 Thread Florian Westphal
Andreas Schwab wrote: > > From: Florian Westphal > > > > We have targets and standard targets -- the latter carries a verdict. > > > > The ip/ip6tables validation functions will access t->verdict for the > > standard targets to fetch the jump offset or verdict for chainloop > > detection, but thi

[PATCH 0/2] NET: PHY: Add PHY LED control binding.

2016-06-05 Thread Hauke Mehrtens
This is now spitted out of the patch series that adds support the Ethernet PHY. The second patch depends on the Ethernet PHY code which I send before. How should this get merged, or should I split this in a different way? Hauke Mehrtens (2): NET: PHY: Add PHY LED control binding. NET: PHY:

[PATCH 2/2] NET: PHY: Intel XWAY: add LED configuration support

2016-06-05 Thread Hauke Mehrtens
This makes it possible to configure the behavior of the LEDs connected to a PHY. The LEDs are controlled by the chip, this makes it possible to configure the behavior when the hardware should activate and deactivate the LEDs. Signed-off-by: Hauke Mehrtens --- .../devicetree/bindings/phy/intel-xw

[PATCH 1/2] NET: PHY: Add PHY LED control binding.

2016-06-05 Thread Hauke Mehrtens
This binding makes it possible to control the LEDs of an Ethernet PHY. These settings allow it to abstract the hardware configuration which tells the hardware when to switch the LED constant on or blink for example. This will be used by the Intel XWAY PHY driver. I also checked datasheets for some

[PATCH] NET: PHY: adds driver for Intel XWAY PHY

2016-06-05 Thread Hauke Mehrtens
This adds support for the Intel (former Lantiq) XWAY 11G and 22E PHYs. These PHYs are also named PEF 7061, PEF 7071, PEF 7072. Signed-off-by: John Crispin Signed-off-by: Hauke Mehrtens --- changes since last RFC: * activated interrupts for all versions, if it causes problems it should be d

Re: [PATCH 07/23] netfilter: x_tables: check standard target size too

2016-06-05 Thread Andreas Schwab
Pablo Neira Ayuso writes: > From: Florian Westphal > > We have targets and standard targets -- the latter carries a verdict. > > The ip/ip6tables validation functions will access t->verdict for the > standard targets to fetch the jump offset or verdict for chainloop > detection, but this happens

Re: [PATCH v2 net] fq_codel: fix NET_XMIT_CN behavior

2016-06-05 Thread Eric Dumazet
On Sun, 2016-06-05 at 13:54 -0700, Eric Dumazet wrote: > BTW, we might need a similar fix in sch_fq.c I meant sch_sfq.c

Re: [PATCH v2 net] fq_codel: fix NET_XMIT_CN behavior

2016-06-05 Thread Eric Dumazet
On Sun, 2016-06-05 at 13:30 -0700, Cong Wang wrote: > On Sat, Jun 4, 2016 at 12:55 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > > > My prior attempt to fix the backlogs of parents failed. > > > > If we return NET_XMIT_CN, our parents wont increase their backlog, > > so our qdisc_tree_reduce

Re: [PATCH v2 net] fq_codel: fix NET_XMIT_CN behavior

2016-06-05 Thread Cong Wang
On Sat, Jun 4, 2016 at 12:55 PM, Eric Dumazet wrote: > From: Eric Dumazet > > My prior attempt to fix the backlogs of parents failed. > > If we return NET_XMIT_CN, our parents wont increase their backlog, > so our qdisc_tree_reduce_backlog() should take this into account. > Acked-by: Cong Wang

[PATCH] staging: r8188eu: Fix scheduling while atomic splat

2016-06-05 Thread Larry Finger
Commit fadbe0cd5292851608e2e01b91d9295fa287b9fe ("staging: rtl8188eu: Remove rtw_zmalloc(), wrapper for kzalloc()") changed all allocation calls to be GFP_KERNEL even though the original wrapper was testing to determine if the caller was in atomic mode. Most of the mistakes were corrected with comm

Re: [PATCH 1/1] ixgbe: replace rtnl_lock with rcu_read_lock

2016-06-05 Thread Alexander Duyck
On Sun, Jun 5, 2016 at 2:14 AM, wrote: > From: Zhu Yanjun > > > Signed-off-by: Zhu Yanjun > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > b/drivers/net/etherne

RE: [RFC net-next 1/1] ethtool: Add support for set eeprom metadata.

2016-06-05 Thread Yuval Mintz
> > > > > Currently ethtool implementation does not have a way to pass the > > > > > metadata for eeprom related operations. Some adapters have a > > > > > complicated non-volatile memory implementation that requires > > > > > additional information – there are drivers [bnx2x and bnxt] that > > > >

Re: [PATCH net-next] net, cls: allow for deleting all filters for given parent

2016-06-05 Thread Daniel Borkmann
On 06/05/2016 02:53 PM, Sergei Shtylyov wrote: On 6/4/2016 7:24 PM, Daniel Borkmann wrote: [...] Need a comment here, something like /* FALL THRU */. Hmm, not really, I think it's obvious enough. +default: return -ENOENT; -prio = TC_H_MAKE(0x8000U, 0U);

Re: ath9k gpio request

2016-06-05 Thread Sudip Mukherjee
On Saturday 04 June 2016 08:07 PM, Kalle Valo wrote: (Fixing top posting) "Pan, Miaoqing" writes: --- a/drivers/net/wireless/ath/ath9k/reg.h +++ b/drivers/net/wireless/ath/ath9k/reg.h @@ -1122,8 +1122,8 @@ enum { #define AR9300_NUM_GPIO 16 #define AR9330_NUM_GPI

Re: [RFC net-next 1/1] ethtool: Add support for set eeprom metadata.

2016-06-05 Thread Ben Hutchings
On Sun, 2016-06-05 at 13:29 +, Yuval Mintz wrote: > > > > > > Currently ethtool implementation does not have a way to pass the > > > > metadata for eeprom related operations. Some adapters have a > > > > complicated non-volatile memory implementation that requires > > > > additional informatio

Good Day

2016-06-05 Thread China Textiles Ltd
It is my pleasure to announce to you the vacancy of a collection representative post for China Textiles Ltd in your country,if you are interested you will be given 5% for every collection made on our clients, for more details Respond. Sincerely, Dave Desmond.

[PATCH V2] staging: r8188eu: Fix crash caused by commit 99aded71b52c

2016-06-05 Thread Larry Finger
Commit 99aded71b52cfdfa22721c42e42efdd13a02f0a6 ("Staging: drivers: rtl8188eu: use sizeof(*ptr) instead of sizeof(struct)") introduces an error in that the sizeof(struct hal_data_8188e) is 18712, while the sizeof(*adapt->HalData) is only 1! As a result, the system panics. Fixes: 99aded71b52cfdfa22

[PATCH] staging: r8188eu: Remove some false positives from kmemleak

2016-06-05 Thread Larry Finger
When this driver preallocates some SKBs, kmemleak is unable to find that allocated memory when it scans. When the driver is unloaded, that memory is released; therefore, the report is a false positive. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/hal/rtl8188eu_recv.c | 2 ++ 1 file

Re: [PATCH][RT] netpoll: Always take poll_lock when doing polling

2016-06-05 Thread Alison Chaiken
Steven Rostedt suggests in reference to "[PATCH][RT] netpoll: Always take poll_lock when doing polling" >> [ Alison, can you try this patch ] Sebastian follows up: >Alison, did you try it? Sorry for not responding sooner. I was hoping to come to a complete understanding of the system before rep

Re: [PATCH 09/12] net: mediatek: increase watchdog_timeo

2016-06-05 Thread Andrew Lunn
On Sun, Jun 05, 2016 at 08:33:02AM +0200, John Crispin wrote: > During stress testing, after reducing the threshold value, we have seen > TX timeouts that were caused by the watchdog_timeo value being too low. > Increase the value to 5 * HZ which is a value commonly used by many other > drivers. I

[net-next PATCH 1/1] net sched: indentation and other OCD stylistic fixes

2016-06-05 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Signed-off-by: Jamal Hadi Salim --- include/net/act_api.h | 14 -- include/net/tc_act/tc_defact.h | 4 ++-- include/uapi/linux/pkt_cls.h | 6 +++--- net/sched/act_api.c| 19 +++ net/sched/act_bpf.c| 3 ++-

[net-next PATCH 0/3] net sched action timestamp improvements

2016-06-05 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Various aggregations of duplicated code, fixes and introduction of firstused timestamp Jamal Hadi Salim (3): net sched: actions use tcf_lastuse_update for consistency net sched actions: introduce timestamp for firsttime use net sched actions: aggregate dumping of act

[net-next PATCH 1/3] net sched: actions use tcf_lastuse_update for consistency

2016-06-05 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Signed-off-by: Jamal Hadi Salim --- net/sched/act_connmark.c | 2 +- net/sched/act_csum.c | 2 +- net/sched/act_ife.c | 6 +++--- net/sched/act_ipt.c | 2 +- net/sched/act_mirred.c | 1 - net/sched/act_nat.c | 2 +- net/sched/act_pedit.c| 2 +- ne

[net-next PATCH 3/3] net sched actions: aggregate dumping of actions timeinfo

2016-06-05 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Signed-off-by: Jamal Hadi Salim --- include/net/act_api.h| 8 net/sched/act_bpf.c | 6 +- net/sched/act_connmark.c | 5 + net/sched/act_csum.c | 6 ++ net/sched/act_gact.c | 5 + net/sched/act_ife.c | 4 +--- net/sched/act_ip

[net-next PATCH 2/3] net sched actions: introduce timestamp for firsttime use

2016-06-05 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Useful to know when the action was first used for accounting (and debugging) Signed-off-by: Jamal Hadi Salim --- include/net/act_api.h| 2 ++ include/uapi/linux/pkt_cls.h | 1 + net/sched/act_api.c | 1 + net/sched/act_bpf.c | 1 + net/sched/act

[PATCH net-next] net/sched: cls_flower: Introduce support in SKIP SW flag

2016-06-05 Thread Amir Vadai
From: Amir Vadai In order to make a filter processed only by hardware, skip_sw flag should be supplied. This is an addition to the already existing skip_hw flag (filter will be processed by software only). If no flag is specified, filter will be processed by both software and hardware. If only h

Re: [PATCH v2] ethernet:arc: Fix racing of TX ring buffer

2016-06-05 Thread Shuyu Wei
On Mon, May 30, 2016 at 11:41:22PM +0200, Lino Sanfilippo wrote: > > Did you see the same issues with the patch before (the one that, as you wrote, > survived a whole night of stress testing)? > > Lino Hi Lino, Sorry for my late reply. I retested the previous patch, it did have the same issue. H

RE: [RFC net-next 1/1] ethtool: Add support for set eeprom metadata.

2016-06-05 Thread Yuval Mintz
> > > Currently ethtool implementation does not have a way to pass the > > > metadata for eeprom related operations. Some adapters have a > > > complicated non-volatile memory implementation that requires > > > additional information – there are drivers [bnx2x and bnxt] that use > > > the ‘magic’ f

Re: [PATCH v2] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT_CBPF

2016-06-05 Thread Willem de Bruijn
> Acked-by: Daniel Borkmann > > [ Cc Willem: I believe we also need something similar for PACKET_FANOUT_DATA > when PACKET_FANOUT_CBPF is requested since we have the same issue with the > pointer in struct sock_fprog there, too. ] Indeed. I'll send a patch in a few days (am traveling). Thanks

[iproute2 resend PATCH 1/1] man: tc-ife.8: man page for ife action

2016-06-05 Thread Jamal Hadi Salim
From: Lucas Bates Signed-off-by: Lucas Bates Signed-off-by: Jamal Hadi Salim Acked-by: Phil Sutter --- man/man8/tc-ife.8 | 117 ++ 1 file changed, 117 insertions(+) create mode 100644 man/man8/tc-ife.8 diff --git a/man/man8/tc-ife.8 b/man/

Re: [PATCH v2 net] fq_codel: fix NET_XMIT_CN behavior

2016-06-05 Thread Jamal Hadi Salim
On 16-06-04 03:55 PM, Eric Dumazet wrote: From: Eric Dumazet My prior attempt to fix the backlogs of parents failed. If we return NET_XMIT_CN, our parents wont increase their backlog, so our qdisc_tree_reduce_backlog() should take this into account. v2: Florian Westphal pointed out that we co

Re: [PATCH net-next] net, cls: allow for deleting all filters for given parent

2016-06-05 Thread Sergei Shtylyov
Hello. On 6/4/2016 7:24 PM, Daniel Borkmann wrote: Add a possibility where the user can just specify the parent and all filters under that parent are then being purged. Currently, for example for scripting, one needs to specify pref/prio to have a well-defined number for 'tc filter del' command

Re: [RFC net-next 1/1] ethtool: Add support for set eeprom metadata.

2016-06-05 Thread Ben Hutchings
On Sun, 2016-06-05 at 10:16 +, Yuval Mintz wrote: > > > > Currently ethtool implementation does not have a way to pass the metadata > > for > > eeprom related operations. Some adapters have a complicated non-volatile > > memory implementation that requires additional information – there are

Re: [PATCH net-next] net, cls: allow for deleting all filters for given parent

2016-06-05 Thread Jamal Hadi Salim
On 16-06-04 12:24 PM, Daniel Borkmann wrote: Add a possibility where the user can just specify the parent and all filters under that parent are then being purged. Currently, for example for scripting, one needs to specify pref/prio to have a well-defined number for 'tc filter del' command for add

RE: [PATCH net] bnx2x: allow adding VLANs while interface is down

2016-06-05 Thread Yuval Mintz
> > Since implementing VLAN filtering in commit 05cc5a39ddb74 > > ("bnx2x: add vlan filtering offload") bnx2x refuses to add a VLAN > > while the interface is down. > > Hi Michal - thanks; I'll review this one on Sunday. I'm a bit worried about the fact we're hiding actual issues - E.g., if for s

Re: [PATCH 1/1] ixgbe: replace rtnl_lock with rcu_read_lock

2016-06-05 Thread Eric Dumazet
On Sun, 2016-06-05 at 17:14 +0800, zyjzyj2...@gmail.com wrote: > From: Zhu Yanjun > > > Signed-off-by: Zhu Yanjun > --- You do not explain if this is a bug fix (targeting net tree) or simply an optimization in the slow path (targeting net-next tree) ? A changelog, even small, would be nice, e

[PATCH 3.10 128/143] VSOCK: do not disconnect socket when peer has shutdown SEND only

2016-06-05 Thread Willy Tarreau
From: Ian Campbell commit dedc58e067d8c379a15a8a183c5db318201295bb upstream. The peer may be expecting a reply having sent a request and then done a shutdown(SHUT_WR), so tearing down the whole socket at this point seems wrong and breaks for me with a client which does a SHUT_WR. Looking at oth

Re: [PATCH] net: wireless: marvell: libertas: Remove create_workqueue

2016-06-05 Thread Tejun Heo
On Sat, Jun 04, 2016 at 07:29:01PM +0530, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > In if_sdio.c, the workqueue card->workqueue has workitem > &card->packet_worker, which is mapped to if_sdio_host_to_card_worker. > The workitem is involved in sending

Re: [PATCH] net: ethernet: cavium: liquidio: response_manager: Remove create_workqueue

2016-06-05 Thread Tejun Heo
On Sat, Jun 04, 2016 at 08:21:40PM +0530, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workitem viz > (&cwq->wk.work which maps to oct_poll_req_completion) is involved > in normal device operation. WQ_MEM_RE

Re: [PATCH] net: ethernet: cavium: liquidio: request_manager: Remove create_workqueue

2016-06-05 Thread Tejun Heo
On Sat, Jun 04, 2016 at 08:54:00PM +0530, Bhaktipriya Shridhar wrote: > diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c > b/drivers/net/ethernet/cavium/liquidio/request_manager.c > index a2a2465..9313915 100644 > --- a/drivers/net/ethernet/cavium/liquidio/request_manager.c > ++

RE: [RFC net-next 1/1] ethtool: Add support for set eeprom metadata.

2016-06-05 Thread Yuval Mintz
> Currently ethtool implementation does not have a way to pass the metadata for > eeprom related operations. Some adapters have a complicated non-volatile > memory implementation that requires additional information – there are drivers > [bnx2x and bnxt] that use the ‘magic’ field in the {G,S}EEPRO

[PATCH net-next 5/6] qed: PF enforce MAC limitation of VFs

2016-06-05 Thread Yuval Mintz
The only limitation relating to MACs the PF enforce today on its VFs is in case it has a forced-unicast MAC address for them, in which case they can't configure other unicast addresses. Specifically, the PF isn't enforcing the number of MAC addresse a VF can configure regardless of the nubmer of su

[PATCH net-next 3/6] qed: Make PF more robust against malicious VF

2016-06-05 Thread Yuval Mintz
There are several requests the VF can make toward the PF which the driver would pass to firmware without checking the validity first - specifically, opening queues and updating vports. Such configurations might cause the firmware to assert. This adds validation of the legality of said configuratio

[PATCH net-next 6/6] qed: PF to reply to unknown messages

2016-06-05 Thread Yuval Mintz
If a future VF would send the PF an unknown message, the PF today would not send a reply. This would have 2 bad effects: a. VF would have to timeout on the request. b. If VF were to send an additional message to PF, firmware would mark it as malicious. Instead, if there's some valid reply

[PATCH net-next 4/6] qed: Move doorbell calculation from VF to PF

2016-06-05 Thread Yuval Mintz
Today, the VF is aware of its queues context-ids, and calculates the doorbell address when opening its queues on its own. The configuration of doorbells in HW can sometime in the future be changed by the PF [hw has several configurable features that might affect doorbell addresses, e.g., dpm suppor

[PATCH net-next 2/6] qed: PF-VF resource negotiation

2016-06-05 Thread Yuval Mintz
One of the goals of the vf's first message to the PF [acquire] is to learn about the number of resources available to it [macs, vlans, etc.]. This is done via negotiation - the VF requires a set of resources, which the PF either approves or disaproves and sends a smaller set of resources as alterna

[PATCH net-next 0/6] qed: IOV series - relax firmware requirements

2016-06-05 Thread Yuval Mintz
In order for VFs to work, current implementation demands that the VF's requried storm firmware would be exactly the version that was loaded by the PF, which is a very harsh requirement. This patch series is intended to relax this - the recently submitted firmware is intended to be forward/backward

[PATCH net-next 1/6] qed: Relax VF firmware requirements

2016-06-05 Thread Yuval Mintz
Current driver require an exact match between VF and PF storm firmware; Any difference would fail the VF acquire message, causing the VF probe to be aborted. While there's still dependencies between the two, the recent FW submission has relaxed the match requirement - instead of an exact match, th

[PATCH 1/1] ixgbe: replace rtnl_lock with rcu_read_lock

2016-06-05 Thread zyjzyj2000
From: Zhu Yanjun Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 088c47c..cb19cbc 100644 -

ixgbe: replace rtnl_lock with rcu_read_lock

2016-06-05 Thread zyjzyj2000
Hi,all I am using the ixgbe nic. I found that the rtnl_lock is being used to enable upper device, such as macvlan. I am curious why rcu_read_lock is not used here. I replaced rtnl_lock with rcu_read_lock here. Then I made tests and it can work well. So can the rtnl_lock be replaced with

Re: [PATCH net-next 1/3] arm64: bpf: implement bpf_tail_call() helper

2016-06-05 Thread Daniel Borkmann
On 06/05/2016 01:46 AM, kbuild test robot wrote: Hi, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Zi-Shen-Lim/arm64-bpf-implement-bpf_tail_call-helper/20160605-060435 config: arm64-defconfig (attached as .config) compiler: aarch64-linux-gnu-gcc

Re: [PATCH net] bridge: Fix incorrect re-injection of STP packets

2016-06-05 Thread Ido Schimmel
Hi Florian, Fri, Jun 03, 2016 at 12:39:45PM IDT, ido...@mellanox.com wrote: >Commit 8626c56c8279 ("bridge: fix potential use-after-free when hook >returns QUEUE or STOLEN verdict") fixed incorrect usage of NF_HOOK's >return value by consuming packets in okfn via br_pass_frame_up(). > >However, thi

Re: [PATCH 01/12] net: mediatek: fix DQL support

2016-06-05 Thread David Miller
From: John Crispin Date: Sun, 5 Jun 2016 08:32:54 +0200 > @@ -625,7 +625,16 @@ static int mtk_tx_map(struct sk_buff *skb, struct > net_device *dev, > WRITE_ONCE(itxd->txd3, (TX_DMA_SWC | TX_DMA_PLEN0(skb_headlen(skb)) | > (!nr_frags * TX_DMA_LS0))); > > -

[PATCH] staging: r8188eu: Fix crash caused by commit 99aded71b52c

2016-06-05 Thread Larry Finger
Commit 99aded71b52cfdfa22721c42e42efdd13a02f0a6 ("Staging: drivers: rtl8188eu: use sizeof(*ptr) instead of sizeof(struct)") introduces an error in that the sizeof(struct hal_data_8188e) is 18712, while the sizeof(*adapt->HalData) is only 1! As a result, the system panics. Fixes: 99aded71b52cfdfa22

[PATCH 10/12] net: mediatek: fix off by one in the TX ring allocation

2016-06-05 Thread John Crispin
The TX ring setup has an off by one error causing it to not utilise all descriptors. This has the side effect that we need to reset the next pointer at runtime to make it work. Fix the off by one and remove the code fixing the ring at runtime. Signed-off-by: John Crispin --- drivers/net/ethernet

[PATCH 11/12] net: mediatek: only wake the queue if it is stopped

2016-06-05 Thread John Crispin
The current code unconditionally wakes up the queue at the end of each tx_poll action. Change the code to only wake up the queues if any of them have actually been stopped before. Signed-off-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 17 - 1 file changed

[PATCH 12/12] net: mediatek: remove superfluous queue wake up call

2016-06-05 Thread John Crispin
The code checks if the queue should be stopped because we are below the threshold of free descriptors only to check if it should be started again. If we do end up in a state where we are at the threshold limit, it makes more sense to just stop the queue and wait for the next IRQ to trigger the TX h