Re: [PATCH 0/6] eBPF JIT for PPC64

On 2016/06/10 10:47PM, David Miller wrote: > From: "Naveen N. Rao" > Date: Tue, 7 Jun 2016 19:02:17 +0530 > > > Please note that patch [2] is a pre-requisite for this patchset, and is > > not yet upstream. > ... > > [1]

Re: [PATCH ipvs-next] ipvs: count pre-established TCP states as active

On Sun, Jun 12, 2016 at 06:27:39PM +0300, Julian Anastasov wrote: > > Hello, > > On Fri, 3 Jun 2016, Michal Kubecek wrote: > > > Some users observed that "least connection" distribution algorithm doesn't > > handle well bursts of TCP connections from reconnecting clients after > > a node

[PATCH net] net_sched: prio: rollback allocations if prio_init() fails

From: Eric Dumazet Now prio_init() can return -ENOMEM, it also has to make sure any allocated qdisc are freed, since the caller (qdisc_create()) wont call ->destroy() handler for us. Fixes: cbdf45116478 ("net_sched: prio: properly report out of memory errors")

Re: [PATCH net] net_sched: prio: properly report out of memory errors

On Sun, 2016-06-12 at 20:45 -0700, Cong Wang wrote: > On Sun, Jun 12, 2016 at 4:21 PM, Eric Dumazet wrote: > > + struct Qdisc *child; > > + > > + if (q->queues[i] != _qdisc) > > + continue; > > + > > + child =

Re: [PATCH net] net_sched: fix pfifo_head_drop behavior vs backlog

On Sun, Jun 12, 2016 at 8:01 PM, Eric Dumazet wrote: > From: Eric Dumazet > > When the qdisc is full, we drop a packet at the head of the queue, > queue the current skb and return NET_XMIT_CN > > Now we track backlog on upper qdiscs, we need to call >

Re: [PATCH net] net_sched: prio: properly report out of memory errors

On Sun, Jun 12, 2016 at 4:21 PM, Eric Dumazet wrote: > + struct Qdisc *child; > + > + if (q->queues[i] != _qdisc) > + continue; > + > + child = qdisc_create_dflt(sch->dev_queue, _qdisc_ops, > +

Re: [PATCH] netfilter/nflog: nflog-range does not truncate packets

On 06/09/2016 01:57 PM, Vishwanath Pai wrote: > On 06/08/2016 08:16 AM, Pablo Neira Ayuso wrote: >> Looking again at your code: >> >> case NFULNL_COPY_PACKET: >> - if (inst->copy_range > skb->len) >> + data_len = inst->copy_range; >> + if

Re: [PATCH v4] udp reuseport: fix packet of same flow hashed to different socket

On Mon, 2016-06-13 at 11:02 +0800, Su Xuemin wrote: > From: "Su, Xuemin" > > There is a corner case in which udp packets belonging to a same > flow are hashed to different socket when hslot->count changes from 10 > to 11: ... > Signed-off-by: Su, Xuemin

[PATCH v4] udp reuseport: fix packet of same flow hashed to different socket

From: "Su, Xuemin" There is a corner case in which udp packets belonging to a same flow are hashed to different socket when hslot->count changes from 10 to 11: 1) When hslot->count <= 10, __udp_lib_lookup() searches udp_table->hash, and always passes 'daddr' to

[PATCH net] net_sched: fix pfifo_head_drop behavior vs backlog

From: Eric Dumazet When the qdisc is full, we drop a packet at the head of the queue, queue the current skb and return NET_XMIT_CN Now we track backlog on upper qdiscs, we need to call qdisc_tree_reduce_backlog(), even if the qlen did not change. Fixes: 2f5fb43f

udp failures traced to e858fae2b0b8

Mike: UDP tests in my vrf unit test suite are failing. git bisect points to: dsa@kenny:~/kernel-2.git$ git bisect good e858fae2b0b8f41f0bed2cdffde25e7c97da38a7 is the first bad commit commit e858fae2b0b8f41f0bed2cdffde25e7c97da38a7 Author: Mike Rapoport Date: Wed

Re: [RFC] Handle error writing UINT_MAX to u32 fields

The suggested change would extend the usable range of positive numbers by one bit only. As many systems are 64 bit this does not seem forward looking. I would prefer to have a routine that can handle 64 bit integers with limits (let's call it proc_doint64vec_minmax) which uses fields extra1 and

Re: [very-RFC 6/8] Add TSN event-tracing

On Sun, 12 Jun 2016 23:25:10 +0200 Henrik Austad wrote: > > > +#include > > > +#include > > > +/* #include */ > > > + > > > +/* FIXME: update to TRACE_CLASS to reduce overhead */ > > > > I'm curious to why I didn't do this now. A class would make less > > duplication of

Re: [PATCH v2 -next] sched: remove NET_XMIT_POLICED

From: Cong Wang Date: Sat, 11 Jun 2016 17:14:09 -0700 > On Sat, Jun 11, 2016 at 3:54 PM, David Miller wrote: >> From: Florian Westphal >> Date: Sat, 11 Jun 2016 12:46:04 +0200 >> >>> sch_atm returns this when TC_ACT_SHOT

Re: [PATCH] net: ethernet: ti: cpsw: use destroy ctlr to destroy channels

From: Ivan Khoronzhuk Date: Sat, 11 Jun 2016 01:11:54 +0300 > There is no reason to destroy channels that are destroyed while > cpdma_ctlr destroy. In this case no need to remember how much > channels where created and destroy them by one, as cpdma_ctlr > destroys all

Re: [PATCH net-next RFT] net: fec: handle small PHY reset durations more precisely

From: Stefan Wahren Date: Wed, 8 Jun 2016 20:42:46 + > Since msleep is based on jiffies the PHY reset could take longer > than expected. So use msleep for values greater than 20 msec otherwise > usleep_range. > > Signed-off-by: Stefan Wahren

Re: [PATCH net] net_sched: prio: properly report out of memory errors

From: Eric Dumazet Date: Sun, 12 Jun 2016 16:21:47 -0700 > From: Eric Dumazet > > At Qdisc creation or change time, prio_tune() creates missing > pfifo qdiscs but does not return an error code if one > qdisc could not be allocated. > > Leaving a

RE: [PATCH v2 1/2] ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround

From: Lucas Stach Sent: Thursday, June 09, 2016 5:35 PM > To: Fugang Duan ; Shawn Guo > Cc: devicet...@vger.kernel.org; patchwork-...@pengutronix.de; > ker...@pengutronix.de; linux-arm-ker...@lists.infradead.org; >

[PATCH] esp: correct offset for ESN when using NAT-T

The offset for calculating ESN was not taking into account the new UDP header created for NAT-T. --- net/ipv4/esp4.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c index 4779374..c84d1fc 100644 --- a/net/ipv4/esp4.c +++ b/net/ipv4/esp4.c @@ -223,6 +223,8

[PATCH] IPsec NAT-T issue

During testing we have discovered an issue with IPsec NAT-T where the SPI is over writing the source and dest ports of the UDP header. I'm not super familiar with this code, but I've found a solution that seems to work in my setup. I'd like some feedback on this please, if it's the right thing

Re: off-by-one in DecodeQ931

Attached is the patch generated with git format-patch. On Mon, Jun 6, 2016 at 10:55 AM, Pablo Neira Ayuso wrote: > On Mon, Jun 06, 2016 at 04:35:55PM +0200, Florian Westphal wrote: >> Toby DiPasquale wrote: >> > Is this latest patch OK? >> >> Yes, I don't

[PATCH net] net_sched: prio: properly report out of memory errors

From: Eric Dumazet At Qdisc creation or change time, prio_tune() creates missing pfifo qdiscs but does not return an error code if one qdisc could not be allocated. Leaving a qdisc in non operational state without telling user anything about this problem is not good. Also,

Re: [PATCH net] fib_rules: don't break ECN with TOS rules

On 6/11/16 3:10 PM, Hannes Frederic Sowa wrote: @@ -215,6 +216,9 @@ static int fib4_rule_configure(struct fib_rule *rule, struct sk_buff *skb, rule4->dst_len = frh->dst_len; rule4->dstmask = inet_make_mask(rule4->dst_len); rule4->tos = frh->tos; + if

Re: [very-RFC 0/8] TSN driver for the kernel

On Sun, Jun 12, 2016 at 07:43:34PM +0900, Takashi Sakamoto wrote: > On Jun 12 2016 17:31, Henrik Austad wrote: > > On Sun, Jun 12, 2016 at 01:30:24PM +0900, Takashi Sakamoto wrote: > >> On Jun 12 2016 12:38, Takashi Sakamoto wrote: > >>> In your patcset, there's no actual codes about how to handle

QUICK LOAN OFFER

[iproute2 PATCH 1/1] action pedit: stylistic changes

From: Jamal Hadi Salim More modern layout. Signed-off-by: Jamal Hadi Salim --- tc/m_pedit.c | 118 +++ 1 file changed, 62 insertions(+), 56 deletions(-) diff --git a/tc/m_pedit.c b/tc/m_pedit.c

[PATCH] net: ethernet: enic: move to new ethtool api {get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move the enic driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/cisco/enic/enic_ethtool.c | 28 +-- 1 files changed, 16 insertions(+), 12 deletions(-)

Re: [RFC PATCH iproute2] tc: let m_ipt work with new iptables API headers

Hi, On 05/29/2016 08:27 PM, Alexander Aring wrote: > Since commit 5cd1adb ("Update to current iptables headers") the build > with m_ipt.o and the following config will fail: > > TC_CONFIG_XT:=n > TC_CONFIG_XT_OLD:=n > TC_CONFIG_XT_OLD_H:=n > > This patch renames "iptables_target" to

Re: [very-RFC 6/8] Add TSN event-tracing

On Sun, Jun 12, 2016 at 12:58:03PM -0400, Steven Rostedt wrote: > On Sun, 12 Jun 2016 01:01:34 +0200 > Henrik Austad wrote: > > > From: Henrik Austad > > > > This needs refactoring and should be updated to use TRACE_CLASS, but for > > now it provides a fair

[net-next PATCH v2 1/1] net sched actions: skbedit add support for mod-ing skb pkt_type

From: Jamal Hadi Salim Extremely useful for setting packet type to host so i dont have to modify the dst mac address using pedit (which requires that i know the mac address) Signed-off-by: Jamal Hadi Salim --- include/net/tc_act/tc_skbedit.h| 10

Re: [net-next PATCH 1/1] net sched actions: skbedit add support for mod-ing skb pkt_type

On 16-06-12 05:12 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim Extremely useful for setting packet type to host so i dont have to modify the dst mac address using pedit (which requires that i know the mac address) Signed-off-by: Jamal Hadi Salim

[net-next PATCH 1/1] net sched actions: skbedit add support for mod-ing skb pkt_type

From: Jamal Hadi Salim Extremely useful for setting packet type to host so i dont have to modify the dst mac address using pedit (which requires that i know the mac address) Signed-off-by: Jamal Hadi Salim --- include/net/tc_act/tc_skbedit.h| 10

Re: ebpf: issue with clang

Hello, On Sun, 2016-06-12 at 20:35 +0200, Daniel Borkmann wrote: > On 06/12/2016 07:37 PM, Eric Leblond wrote: > > On Thu, 2016-06-09 at 17:34 -0700, Alexei Starovoitov wrote: > > > On Thu, Jun 09, 2016 at 11:10:05PM +0200, Eric Leblond wrote: > > > > Hello, > > > > > > > > I'm working on

Re: ebpf: issue with clang

On 06/12/2016 07:37 PM, Eric Leblond wrote: On Thu, 2016-06-09 at 17:34 -0700, Alexei Starovoitov wrote: On Thu, Jun 09, 2016 at 11:10:05PM +0200, Eric Leblond wrote: Hello, I'm working on integrating ebpf cluster load balancing for AF_PACKET and I've got some problem to get real code inside

Re: [PATCH 1/5] ethernet: add sun8i-emac driver

Le 09/06/2016 02:44, LABBE Corentin a écrit : > Hello > > I agree to all your comments, but for some I have additionnal questions > > On Mon, Jun 06, 2016 at 11:25:15AM -0700, Florian Fainelli wrote: >> On 06/03/2016 02:56 AM, LABBE Corentin wrote: >> >> [snip] >> >>> + >>> +/* The datasheet

Re: ebpf: issue with clang

Hello, On Thu, 2016-06-09 at 17:34 -0700, Alexei Starovoitov wrote: > On Thu, Jun 09, 2016 at 11:10:05PM +0200, Eric Leblond wrote: > > Hello, > > > > I'm working on integrating ebpf cluster load balancing for > > AF_PACKET > > and I've got some problem to get real code inside the EBPF filter. >

Re: [very-RFC 6/8] Add TSN event-tracing

On Sun, 12 Jun 2016 01:01:34 +0200 Henrik Austad wrote: > From: Henrik Austad > > This needs refactoring and should be updated to use TRACE_CLASS, but for > now it provides a fair debug-window into TSN. > > Cc: "David S. Miller" > Cc:

Re: [PATCH] net: alx: Work around the DMA RX overflow issue

On Sun, 2016-06-12 at 17:36 +0800, Feng Tang wrote: > Commit 26c5f03 uses a new skb allocator to avoid the RFD overflow > issue. > > But from debugging without datasheet, we found the error always > happen when the DMA RX address is set to 0xfc0, which is very > likely to be a HW/silicon

Re: [PATCH v3] udp reuseport: fix packet of same flow hashed to different socket

On Sun, 2016-06-12 at 20:43 +0800, Su Xuemin wrote: > From: "Su, Xuemin" ... > Signed-off-by: Su, Xuemin > Signed-off-by: Eric Dumazet > --- First, I want to thank you for this very high quality submission, especially if

Re: [PATCH ipvs-next] ipvs: count pre-established TCP states as active

Hello, On Fri, 3 Jun 2016, Michal Kubecek wrote: > Some users observed that "least connection" distribution algorithm doesn't > handle well bursts of TCP connections from reconnecting clients after > a node or network failure. > > This is because the algorithm counts active connection

[PATCH v3] udp reuseport: fix packet of same flow hashed to different socket

From: "Su, Xuemin" There is a corner case in which udp packets belonging to a same flow are hashed to different socket when hslot->count changes from 10 to 11: 1) When hslot->count <= 10, __udp_lib_lookup() searches udp_table->hash, and always passes 'daddr' to

Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

On Sat, 2016-06-11 at 19:26 -0700, David Miller wrote: > From: Vidya Sagar Ravipati > Date: Sat, 11 Jun 2016 16:22:38 -0700 > > > As part of ethtool application, application is requesting  the drivers > > to provide the supported eeprom size to allocate memory buffer

Re: [PATCH net-next] ethtool: Macro definition for SFF-8436/8636 Memory map max sizes

On Sat, 2016-06-11 at 15:51 -0700, David Miller wrote: [...] > Why do we need these values in the header file at all? Because we don't like putting magic numbers in driver code, and these sizes are defined by standards that are independent of a single driver. > The application can probe the size

Re: [linux-sunxi] [PATCH 0/5] net-next: ethernet: add sun8i-emac driver

Hi, On 03-06-16 11:56, LABBE Corentin wrote: Hello This patch series add the driver for sun8i-emac which handle the Ethernet MAC present on Allwinner H3/A83T/A64 SoCs. It supports 10/100/1000 Mbit/s speed with half/full duplex. It can use an internal PHY (MII 10/100) or an external PHY via

Re: [PATCH] netlink.7: describe netlink socket options

Hi Andrey, On 06/10/2016 10:28 PM, Andrey Vagin wrote: > Cc: Kir Kolyshkin > Cc: Michael Kerrisk > Cc: Herbert Xu > Cc: Patrick McHardy > Cc: Christophe Ricard > Cc: Nicolas

Re: [very-RFC 0/8] TSN driver for the kernel

On Jun 12 2016 17:31, Henrik Austad wrote: > On Sun, Jun 12, 2016 at 01:30:24PM +0900, Takashi Sakamoto wrote: >> On Jun 12 2016 12:38, Takashi Sakamoto wrote: >>> In your patcset, there's no actual codes about how to handle any >>> interrupt contexts (software / hardware), how to handle packet

Re: [PATCH net] fib_rules: don't break ECN with TOS rules

On Sun, Jun 12, 2016, at 11:28, Julian Anastasov wrote: > > Hello, > > On Sun, 12 Jun 2016, Hannes Frederic Sowa wrote: > > > On Sun, Jun 12, 2016, at 02:09, Julian Anastasov wrote: > > > > > > Well, may be the confusion comes from commit 89aef8921bfb > > > ("ipv4: Delete routing

[PATCH net] ipv4: fix checksum annotation in udp4_csum_init

Reported-by: Cong Wang Cc: Cong Wang Cc: Tom Herbert Fixes: 4068579e1e098fa ("net: Implmement RFC 6936 (zero RX csums for UDP/IPv6") Signed-off-by: Hannes Frederic Sowa --- net/ipv4/udp.c | 7

Re: [PATCH v9 11/22] IB/hns: Add IB device registration

On 2016/6/9 14:26, Leon Romanovsky wrote: On Wed, Jun 01, 2016 at 11:37:53PM +0800, Lijun Ou wrote: This patch registered IB device when loaded, and unregistered IB device when removed. Signed-off-by: Wei Hu Signed-off-by: Nenglong Zhao

[PATCH] net: alx: Work around the DMA RX overflow issue

Commit 26c5f03 uses a new skb allocator to avoid the RFD overflow issue. But from debugging without datasheet, we found the error always happen when the DMA RX address is set to 0xfc0, which is very likely to be a HW/silicon problem. So one idea is instead of adding a new allocator, why not

Re: [PATCH net] fib_rules: don't break ECN with TOS rules

Hello, On Sun, 12 Jun 2016, Hannes Frederic Sowa wrote: > On Sun, Jun 12, 2016, at 02:09, Julian Anastasov wrote: > > > > Well, may be the confusion comes from commit 89aef8921bfb > > ("ipv4: Delete routing cache.") where the 'tos &= IPTOS_RT_MASK;' > > line is lost from

Re: [very-RFC 0/8] TSN driver for the kernel

On Jun 12 2016 17:28, Henrik Austad wrote: > On Sun, Jun 12, 2016 at 12:38:36PM +0900, Takashi Sakamoto wrote: >> I'm one of maintainers for ALSA firewire stack, which handles IEC >> 61883-1/6 and vendor-unique packets on IEEE 1394 bus for consumer >> recording equipments. >> (I'm not in

Re: [very-RFC 0/8] TSN driver for the kernel

On Sun, Jun 12, 2016 at 01:30:24PM +0900, Takashi Sakamoto wrote: > On Jun 12 2016 12:38, Takashi Sakamoto wrote: > > In your patcset, there's no actual codes about how to handle any > > interrupt contexts (software / hardware), how to handle packet payload, > > and so on. Especially, for recent

Re: [very-RFC 0/8] TSN driver for the kernel

On Sun, Jun 12, 2016 at 12:38:36PM +0900, Takashi Sakamoto wrote: > Hi, > > I'm one of maintainers for ALSA firewire stack, which handles IEC > 61883-1/6 and vendor-unique packets on IEEE 1394 bus for consumer > recording equipments. > (I'm not in MAINTAINERS because I'm a shy boy.) > > IEC

Re: [ovs-dev] [PATCH net-next] NSH(Network Service Header) implementation

On Mon, Jun 06, 2016 at 05:45:08PM -0700, pravin shelar wrote: > On Mon, Jun 6, 2016 at 2:34 AM, Yi Yang wrote: > > IETF defined NSH(Network Service Header) for Service > > Function Chaining, this is an IETF draft > > > > https://tools.ietf.org/html/draft-ietf-sfc-nsh-05 > >

Re: [Bridge] [PATCH net-next v2] bridge: Synchronize unicast filtering with FDB

On 16/06/12 (日) 1:17, Nikolay Aleksandrov via Bridge wrote: On 06/11/2016 07:35 AM, David Miller wrote: From: Toshiaki Makita Date: Mon, 6 Jun 2016 21:20:13 +0900 Patrick Schaaf reported that flooding due to a missing fdb entry of the address of macvlan on the