Re: [PATCH v1 1/1] ipv4: Prevent malformed UFO fragments in ip_append_page

From: Steven Caron Date: Mon, 13 Jun 2016 14:01:19 + > As the ip fragment offset field counts 8-byte chunks, non-final ip > fragments must be multiples of 8 bytes of payload. Depending on the > mtu and ip option sizes, ip_append_page wasn't respecting this, >

Re: [PATCH net] gre: fix error handler

On Tue, 2016-06-14 at 22:15 -0700, Eric Dumazet wrote: > From: Eric Dumazet > > 1) gre_parse_header() can be called from gre_err() > >At this point transport header points to ICMP header, not the inner > header. > > 2) We can not really change transport header as

Re: [patch net-next] net: hns: add skb_reset_mac_header() after skb being alloc

From: Yisen Zhuang Date: Mon, 13 Jun 2016 20:41:22 +0800 > From: Kejian Yan > > HNS receives a packet without doing anything, but it should call > skb_reset_mac_header() to initialize the header before using > eth_hdr(). > > Fixes:

Re: [PATCH net-next 0/3] r8152: code adjustment for PHY

From: Hayes Wang Date: Mon, 13 Jun 2016 17:49:35 +0800 > These patches are for adjusting the code about PHY and setting speed. Series applied, thanks.

Re: [PATCH net-next] net/sched: flower: Return error when hw can't offload and skip_sw is set

From: Amir Vadai Date: Mon, 13 Jun 2016 12:06:39 +0300 > From: Amir Vadai > > When skip_sw is set and hardware fails to apply filter, return error to > user. This will make error propagation logic similar to the one > currently used in u32 classifier. >

Re: [PATCH net-next 1/1] Remove the redundant initialization statement.

From: Sudarsana Reddy Kalluru Date: Mon, 13 Jun 2016 05:01:10 -0400 > The callback ".getcbx" is being initialized twice. This was introduced by > the commit 0fdeb72aa6c9 ("qede: Add dcbnl support."). The patch removes the > redundant initialization statement. > >

Re: [PATCH] net: hns: update the dependency

From: Yisen Zhuang Date: Mon, 13 Jun 2016 19:56:27 +0800 > From: Kejian Yan > > After the patchset about adding support of ACPI (commit id is 6343488) > being applied, HNS does not depend on OF. It depends on OF or ACPI, so > the Kconfig file

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

From: Netanel Belgazal Date: Mon, 13 Jun 2016 11:46:13 +0300 > +#define ena_trc_dbg(format, arg...) \ > + pr_debug("[ENA_COM: %s] " format, __func__, ##arg) > +#define ena_trc_info(format, arg...) \ > + pr_info("[ENA_COM: %s] " format, __func__, ##arg) >

Re: [PATCH v2 0/5] ipvs: fix backup sync daemon with IPv6, and minor updates

Hello, On Tue, 14 Jun 2016, Quentin Armitage wrote: > This series of patches arise from discovering that: > ipvsadm --start-daemon backup --mcast-group IPv6_address ... > would always fail. > > The first patch resolves the problem. The second and third patches are > optimizations that

Re: [PATCH net v2 0/4] ovs: fix rtnl notifications on interface deletion

From: pravin shelar Date: Mon, 13 Jun 2016 12:39:16 -0700 > On Mon, Jun 13, 2016 at 1:31 AM, Nicolas Dichtel > wrote: >> >> There was no rtnl notifications for interfaces (gre, vxlan, geneve) created >> by ovs. This problem is fixed by adjusting the

[PATCH net] gre: fix error handler

From: Eric Dumazet 1) gre_parse_header() can be called from gre_err() At this point transport header points to ICMP header, not the inner header. 2) We can not really change transport header as ipgre_err() will later assume transport header still points to ICMP header.

Re: [PATCH net-next 00/10] net_sched: defer skb freeing while changing qdiscs

On Tue, 2016-06-14 at 19:13 -0700, Cong Wang wrote: > No objection from me. It looks like a good optimization > before we can improve the qdisc root spinlock. > > Just one nit: You probably want to keep rtnl_kfree_skbs() > within qdisc layer unless you have any plan to use it > in other places.

Re: [very-RFC 0/8] TSN driver for the kernel

Hi Richard, On Tue, 14 Jun 2016 19:04:44 +0200, Richard Cochran write: >> Well, I guess I should have said, I am not too familiar with the >> breadth of current audio hardware, high end or low end. Of course I >> would like to see even consumer devices work with AVB, but it is up to >> the ALSA

Re: [very-RFC 0/8] TSN driver for the kernel

Hi Richard, > On Mon, Jun 13, 2016 at 01:47:13PM +0200, Richard Cochran wrote: >> 3. ALSA support for tunable AD/DA clocks. The rate of the Listener's >>DA clock must match that of the Talker and the other Listeners. >>Either you adjust it in HW using a VCO or similar, or you do >>

Re: [PATCH net-next 00/10] net_sched: defer skb freeing while changing qdiscs

On Mon, Jun 13, 2016 at 8:21 PM, Eric Dumazet wrote: > qdiscs/classes are changed under RTNL protection and often > while blocking BH and root qdisc spinlock. > > When lots of skbs need to be dropped, we free > them under these locks causing TX/RX freezes, > and more

RE: [Intel-wired-lan] [PATCHv2 net-next] net: igb: Only dma sync frame length

> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Andrew Lunn > Sent: Friday, June 3, 2016 2:03 PM > To: Kirsher, Jeffrey T ; David Miller > > Cc: netdev ;

Re: [PATCH v9 05/22] IB/hns: Add initial profile resource

Hi, On 2016/6/9 15:01, Leon Romanovsky wrote: > On Wed, Jun 01, 2016 at 11:37:47PM +0800, Lijun Ou wrote: >> This patch mainly configured some profile resoure. For example, >> vendor_id, hardware version, and some data structure sizes so on. >> >> Signed-off-by: Wei Hu >>

Re: [PATCH net] htb: call qdisc_root with rcu read lock held

On Mon, Jun 13, 2016 at 9:16 PM, Florian Westphal wrote: > saw a debug splat: > net/include/net/sch_generic.h:287 suspicious rcu_dereference_check() usage! > other info that might help us debug this: > rcu_scheduler_active = 1, debug_locks = 0 > 2 locks held by kworker/2:1/710: >

Re: [RFC PATCH iproute2] tc: let m_ipt work with new iptables API headers

On Sun, 29 May 2016 20:27:13 +0200 Alexander Aring wrote: > Since commit 5cd1adb ("Update to current iptables headers") the build > with m_ipt.o and the following config will fail: > > TC_CONFIG_XT:=n > TC_CONFIG_XT_OLD:=n > TC_CONFIG_XT_OLD_H:=n > > This patch renames

Re: [ldv-project] [net] libertas: potential race condition

On Tue, Jun 14, 2016 at 05:16:11PM +0400, Pavel Andrianov wrote: > 08.06.2016 02:51, James Cameron пишет: > >On Tue, Jun 07, 2016 at 09:39:55AM -0500, Dan Williams wrote: > >>On Tue, 2016-06-07 at 13:30 +0400, Pavel Andrianov wrote: > >>>Hi! > >>> > >>>There is a potential race condition in >

Re: [PATCH] IPsec NAT-T issue

The restoration is happening - but being actioned on the wrong location. The destination IP address is being saved and restored, and the SPI being written directly after the destination IP address. From my understanding though, the ESN shuffling should have saved and restored the UDP source /

Re: [PATCH iproute2] ip rule: Add support for l3mdev rules

On Fri, 10 Jun 2016 10:47:17 -0700 David Ahern wrote: > Kernel commit 96c63fa7393d ("net: Add l3mdev rule") added support for > the FRA_L3MDEV attribute. The attribute enables use of l3mdev rules > which mean 'get table id from l3 master device'. This patch adds >

[PATCH net-next V2 2/9] liquidio: Host queue mapping changes

This patch is to allocate the input queues based on Numa node in tx path and queue mapping changes based on the mapping info provided by firmware. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by:

[PATCH net-next V2 6/9] liquidio: Consider PTP for packet size calculations

This patch is to refactor packet size calculations to support PTP enabled for 66xx and 68xx cards and also other cards that do not support PTP. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix

[PATCH net-next V2 7/9] liquidio: New driver FW command structure

This patch is for new driver/firmware control command structure (octnic_packet_params and octnic_cmd_setup ) and resultant code changes. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix

[PATCH net-next V2 1/9] liquidio: Avoid double free during soft command

This patch is to resolve the double free issue by checking proper return values from soft command. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V2 5/9] liquidio: RX desc alloc changes

This patch is to add page based buffers for receive side descriptors of the driver and separate free routines for rx and tx buffers. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V2 0/9] liquidio: Updates and Bug fixes

Dave, Following are updates for liquidio bug fixes and driver support for new firmware interface. These updates are divided into smaller logical patches as mentioned by you. These set of nine patches should be applied in the following order as some of them depend on earlier patches in the list.

[PATCH net-next V2 4/9] liquidio:RX queue alloc changes

This patch is to allocate rx queue's memory based on numa node and also use page based buffers for rx traffic improvements. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V2 3/9] liquidio:Scatter gather list per IQ

This patch is to allocate and manage scatter gather lists per input queue(iq's) and remove queue's interdependence. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V2 9/9] liquidio: Introduce new octeon2/3 header

Added support for new instruction header for octeon2/octeon3(ih) and corresponding changes. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V2 8/9] liquidio: Replace ifidx for FW commands

This patch decoupled the firmware side ifidx and host side interface number. It also has some minor name change for linkinfo sturct field. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix

Re: [iproute PATCH 1/2] tc: m_action: Fix for field init before memset

On Wed, 15 Jun 2016 00:26:08 +0200 Phil Sutter wrote: > From: Phil Sutter > > Initializing req.t.tca_family before setting the whole req object to > zero using memset does not make sense. Instead initialize the field > after calling memset. > > Note that this

Re: [PATCH 2/2] dt: bindings: Add bindings for Cirrus Logic CS89x0 ethernet chip

On Mon, Jun 13, 2016 at 06:52:17PM +0300, Alexander Shiyan wrote: > Add device tree binding documentation details for Cirrus Logic > CS8900/CS8920 ethernet chip. > > Signed-off-by: Alexander Shiyan > --- > Documentation/devicetree/bindings/net/cirrus,cs89x0.txt | 13

[PATCH net-next] ila: Fix checksum neutral mapping

The algorithm for checksum neutral mapping is incorrect. This problem was being hidden since we were previously always performing checksum offload on the translated addresses and only with IPv6 HW csum. Enabling an ILA router shows the issue. Corrected algorithm: old_loc is the original locator

Re: [PATCH net-next 00/11] bnxt_en: Updates for net-next.

From: Michael Chan Date: Mon, 13 Jun 2016 02:25:27 -0400 > -Add default VLAN support for VFs. > -Add NPAR (NIC partioning) support. > -Add support for new device 5731x and 5741x. GRO logic is different. > -Support new ETHTOOL_{G|S}LINKSETTINGS. Series applied, thanks.

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add addressing mode to info

Hi, Andrew Lunn writes: > On Tue, Jun 14, 2016 at 06:24:17PM -0400, Vivien Didelot wrote: >> Hi Andrew, >> >> Andrew Lunn writes: >> >> >> - ret = mdiobus_read_nested(bus, addr, reg); >> >> + ret = mdiobus_read_nested(bus, sw_addr + addr, reg); >> >> if (ret

Re: [PATCH v4] udp reuseport: fix packet of same flow hashed to different socket

From: Su Xuemin Date: Mon, 13 Jun 2016 11:02:50 +0800 > From: "Su, Xuemin" > > There is a corner case in which udp packets belonging to a same > flow are hashed to different socket when hslot->count changes from 10 > to 11: > > 1) When

[net PATCH] i40e/i40evf: Fix i40e_rx_checksum

There are a couple of issues I found in i40e_rx_checksum while doing some recent testing. As a result I have found the Rx checksum logic is pretty much broken and returning that the checksum is valid for tunnels in cases where it is not. First the inner types are not the correct values to use to

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add addressing mode to info

On Tue, Jun 14, 2016 at 06:24:17PM -0400, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > >> - ret = mdiobus_read_nested(bus, addr, reg); > >> + ret = mdiobus_read_nested(bus, sw_addr + addr, reg); > >>if (ret < 0) > >>return ret; > > > > If we

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

On Mon, Jun 13, 2016 at 02:07:56PM +0800, Dongpo Li wrote: > This patch adds the Hisilicon Fast Ethernet MAC(FEMAC) driver. > The FEMAC supports max speed 100Mbps and has been used in many > Hisilicon SoC. > > Reviewed-by: Jiancheng Xue > Signed-off-by: Dongpo Li

[iproute PATCH 2/2] tc: m_action: Drop unused variable nladdr in tc_action_gd()

From: Phil Sutter This has been there since the introduction of tc/m_action.c back in 2004 and was apparently never in use. Signed-off-by: Phil Sutter --- tc/m_action.c | 4 1 file changed, 4 deletions(-) diff --git a/tc/m_action.c b/tc/m_action.c index

[iproute PATCH 1/2] tc: m_action: Fix for field init before memset

From: Phil Sutter Initializing req.t.tca_family before setting the whole req object to zero using memset does not make sense. Instead initialize the field after calling memset. Note that this change has no functional effect since AF_UNSPEC is defined to 0 anyway, so this fix

RE: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD

> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, June 14, 2016 1:35 PM > To: pali.ro...@gmail.com > Cc: gre...@linuxfoundation.org; and...@lunn.ch; Limonciello, Mario > ; hayesw...@realtek.com; linux- >

Re: [PATCH v2 net-next v2 11/12] net: dsa: mv88e6xxx: add an SMI ops structure

Hi Andrew, Andrew Lunn writes: >> +struct mv88e6xxx_smi_ops { >> +int (*read)(struct mii_bus *bus, int sw_addr, >> +int addr, int reg, u16 *val); >> +int (*write)(struct mii_bus *bus, int sw_addr, >> + int addr, int reg, u16 val); >> +};

Re: [PATCH 1/3] net: Add MDIO bus driver for the Hisilicon FEMAC

On Mon, Jun 13, 2016 at 02:07:54PM +0800, Dongpo Li wrote: > This patch adds a separate driver for the MDIO interface of the > Hisilicon Fast Ethernet MAC. > > Reviewed-by: Jiancheng Xue > Signed-off-by: Dongpo Li > --- >

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

> This was DT as well with a recent fedora/NetworkManager. It > actually seems to be timing related to how fast the device gets > configured after the initial phy probe. There is something like a 1 > second window or so where it will work, but if network manager takes > longer than that, the

[iproute PATCH 0/2] Two cosmetic fixes in tc/m_action.c

Found these when doing something else. Shouldn't cause any functional change. Phil Sutter (2): tc: m_action: Fix for field init before memset tc: m_action: Drop unused variable nladdr in tc_action_gd() tc/m_action.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) --

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add addressing mode to info

Hi Andrew, Andrew Lunn writes: >> -ret = mdiobus_read_nested(bus, addr, reg); >> +ret = mdiobus_read_nested(bus, sw_addr + addr, reg); >> if (ret < 0) >> return ret; > > If we are doing direct access, doesn't it means sw_addr is 0? > > So isn't this

[PATCH] [v5] net: emac: emac gigabit ethernet controller driver

Add supports for ethernet controller HW on Qualcomm Technologies, Inc. SoC. This driver supports the following features: 1) Checksum offload. 2) Interrupt coalescing support. 3) SGMII phy. 4) phylib interface for external phy Based on original work by Niranjana Vishwanathapura

Re: [PATCH v2 net-next v2 10/12] net: dsa: mv88e6xxx: iterate on compatible info

Hi Andrew, Andrew Lunn writes: > On Tue, Jun 14, 2016 at 02:31:51PM -0400, Vivien Didelot wrote: >> With legacy probing, we cannot have a compatible info structure. We have >> to guess it. Instead of using only the first info structure of the info >> table, iterate over the

Re: [PATCH v2 net-next v2 09/12] net: dsa: mv88e6xxx: add SMI detection helper

Hi Andrew, Andrew Lunn writes: >> -name = info->name; >> +dev_info(dev, "switch 0x%x detected: %s, revision %u\n", prod_num, >> + info->name, rev); >> >> -ps = devm_kzalloc(dsa_dev, sizeof(*ps), GFP_KERNEL); >> +ps = devm_kzalloc(dev, sizeof(*ps),

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add addressing mode to info

On Tue, Jun 14, 2016 at 02:31:53PM -0400, Vivien Didelot wrote: > When the SMI address of the switch chip on the SMI master bus is not > zero, some chips (e.g. 88E6352) use an indirect access through two SMI > Command and Data registers, while others (e.g. 88E6060) still use a > direct access. >

Re: [PATCH v2 net-next v2 11/12] net: dsa: mv88e6xxx: add an SMI ops structure

> +struct mv88e6xxx_smi_ops { > + int (*read)(struct mii_bus *bus, int sw_addr, > + int addr, int reg, u16 *val); > + int (*write)(struct mii_bus *bus, int sw_addr, > + int addr, int reg, u16 val); > +}; > + I think this API would be better if it used ps,

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/15/2016 12:53 AM, Jeremy Linton wrote: If the interrupt configuration isn't set and we are using the It's never set, judging by the driver code. internal phy, then we need to poll the phy to reliably detect phy state changes. What address your internal PHY is at? Mine is at

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/14/2016 04:42 PM, Sergei Shtylyov wrote: On 06/15/2016 12:40 AM, Jeremy Linton wrote: If the interrupt configuration isn't set and we are using the It's never set, judging by the driver code. internal phy, then we need to poll the phy to reliably detect phy state changes.

[PATCH v2 net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

From: Philip Prindeville In the presence of firewalls which improperly block ICMP Unreachable (including Fragmentation Required) messages, Path MTU Discovery is prevented from working. A workaround is to handle IPv4 payloads opaquely, ignoring

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add addressing mode to info

Hi Andrew, Andrew Lunn writes: >> @@ -3681,7 +3681,7 @@ mv88e6xxx_smi_detect(struct device *dev, struct >> mii_bus *bus, int sw_addr, >> u16 id; >> >> ops = _smi_direct_ops; >> -if (sw_addr > 0) >> +if (sw_addr > 0 && info->flags & MV88E6XXX_FLAG_MULTI_CHIP)

Re: [PATCH v2 net-next v2 09/12] net: dsa: mv88e6xxx: add SMI detection helper

On Tue, Jun 14, 2016 at 02:31:50PM -0400, Vivien Didelot wrote: > Extract the allocation and switch ID reading code used by both legacy > and new probing into an helper function which uses a info structure to > describe how to access the switch ID register. > > Signed-off-by: Vivien Didelot

Re: [PATCH v2 net-next v2 10/12] net: dsa: mv88e6xxx: iterate on compatible info

On Tue, Jun 14, 2016 at 02:31:51PM -0400, Vivien Didelot wrote: > With legacy probing, we cannot have a compatible info structure. We have > to guess it. Instead of using only the first info structure of the info > table, iterate over the compatible data. > > That way, the legacy code will

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/15/2016 12:40 AM, Jeremy Linton wrote: If the interrupt configuration isn't set and we are using the It's never set, judging by the driver code. internal phy, then we need to poll the phy to reliably detect phy state changes. What address your internal PHY is at? Mine is at

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/14/2016 04:34 PM, Sergei Shtylyov wrote: On 06/15/2016 12:29 AM, Jeremy Linton wrote: If the interrupt configuration isn't set and we are using the It's never set, judging by the driver code. internal phy, then we need to poll the phy to reliably detect phy state changes.

Re: [CRIU] TCP_REPAIR MSS issue

On Tue, Jun 14, 2016 at 07:37:12PM +, Eggert, Lars wrote: > Hi, > > On 2016-06-14, at 19:15, Andrey Vagin wrote: > > Recently we found that we have to restore more parameters for tcp > > sockets. > > https://patchwork.kernel.org/patch/9144995/ > > thanks for the

Re: [PATCH iproute2] ip route: Add annotation for replaced routes

On 6/14/16 3:34 PM, Stephen Hemminger wrote: On Thu, 9 Jun 2016 13:05:42 -0700 David Ahern wrote: If NLM_F_REPLACE flag is set then a route is replacing an existing route. Prepend "Replaced " to these routes similar to how "Deleted " is added to deleted routes.

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add addressing mode to info

> @@ -3681,7 +3681,7 @@ mv88e6xxx_smi_detect(struct device *dev, struct mii_bus > *bus, int sw_addr, > u16 id; > > ops = _smi_direct_ops; > - if (sw_addr > 0) > + if (sw_addr > 0 && info->flags & MV88E6XXX_FLAG_MULTI_CHIP) > ops = _smi_indirect_ops; Hi Vivien

Re: [PATCH iproute2] ip route: Add annotation for replaced routes

On Thu, 9 Jun 2016 13:05:42 -0700 David Ahern wrote: > If NLM_F_REPLACE flag is set then a route is replacing an existing route. > Prepend "Replaced " to these routes similar to how "Deleted " is added > to deleted routes. > > Signed-off-by: David Ahern

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/15/2016 12:29 AM, Jeremy Linton wrote: If the interrupt configuration isn't set and we are using the It's never set, judging by the driver code. internal phy, then we need to poll the phy to reliably detect phy state changes. What address your internal PHY is at? Mine is at

Re: [PATCH net-next v2] tcp: use RFC6298 compliant TCP RTO calculation

On Tue, Jun 14, 2016 at 12:18 PM, Daniel Metz wrote: > From: Daniel Metz > > This patch adjusts Linux RTO calculation to be RFC6298 Standard > compliant. MinRTO is no longer added to the computed RTO, RTO damping > and overestimation are decreased.

Re: [iproute2 PATCH 1/1] action pedit: stylistic changes

On Sun, 12 Jun 2016 17:40:34 -0400 Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > More modern layout. > > Signed-off-by: Jamal Hadi Salim Applied, also added a few more cleanups here.

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/14/2016 03:44 PM, Sergei Shtylyov wrote: On 06/14/2016 07:16 PM, Jeremy Linton wrote: If the interrupt configuration isn't set and we are using the It's never set, judging by the driver code. internal phy, then we need to poll the phy to reliably detect phy state changes.

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/15/2016 12:12 AM, Jeremy Linton wrote: If the interrupt configuration isn't set and we are using the It's never set, judging by the driver code. AFAIK, I think that its set when the device is configured as a platform device, or there is an external phy/interrupt setup in DT. I

Re: [iproute2 PATCH] utils: fix hex digits parsing in hexstring_a2n()

On Tue, 14 Jun 2016 20:55:17 + Beniamino Galvani wrote: > strtoul() only modifies errno on overflow, so if errno is not zero > before calling the function its value is preserved and makes the > function fail for valid inputs; initialize it. > > Signed-off-by: Beniamino

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/14/2016 11:59 PM, Jeremy Linton wrote: If the interrupt configuration isn't set and we are using the It's never set, judging by the driver code. internal phy, then we need to poll the phy to reliably detect phy state changes. What address your internal PHY is at? Mine is at

Re: [PATCH net] net_sched: fix pfifo_head_drop behavior vs backlog

From: Eric Dumazet Date: Sun, 12 Jun 2016 20:01:25 -0700 > From: Eric Dumazet > > When the qdisc is full, we drop a packet at the head of the queue, > queue the current skb and return NET_XMIT_CN > > Now we track backlog on upper qdiscs, we need to

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: > On 2016/6/13 17:06, Arnd Bergmann wrote: > > On Monday, June 13, 2016 2:07:56 PM CEST Dongpo Li wrote: > > You tx function uses BQL to optimize the queue length, and that > > is great. You also check xmit reclaim for rx interrupts, so >

Re: [PATCH v2 net-next v2 05/12] net: dsa: mv88e6xxx: add switch register helpers

On Tue, Jun 14, 2016 at 02:31:46PM -0400, Vivien Didelot wrote: > The mixed assignments, allocations and registrations in the probe code > make it hard to follow the logic and figure out what is DSA or chip > specific. > > Extract the struct dsa_switch related code in a simple >

Re: [PATCH] esp: correct offset for ESN when using NAT-T

From: Blair Steven Date: Mon, 13 Jun 2016 11:48:14 +1200 > The offset for calculating ESN was not taking into account the new UDP > header created for NAT-T. All submissions must include a proper signoff.

Re: [PATCH v2 net-next v2 01/12] net: dsa: mv88e6xxx: fix style issues

On Tue, Jun 14, 2016 at 02:31:42PM -0400, Vivien Didelot wrote: > This patch fixes 5 style problems reported by checkpatch: > > WARNING: suspect code indent for conditional statements (8, 24) > #492: FILE: drivers/net/dsa/mv88e6xxx.c:492: > + if (phydev->link) > +

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/14/2016 03:44 PM, Sergei Shtylyov wrote: On 06/14/2016 07:16 PM, Jeremy Linton wrote: If the interrupt configuration isn't set and we are using the It's never set, judging by the driver code. AFAIK, I think that its set when the device is configured as a platform device, or

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/14/2016 03:44 PM, Sergei Shtylyov wrote: On 06/14/2016 07:16 PM, Jeremy Linton wrote: If the interrupt configuration isn't set and we are using the It's never set, judging by the driver code. internal phy, then we need to poll the phy to reliably detect phy state changes.

Re: [PATCH v2 net-next v2 08/12] net: dsa: mv88e6xxx: read switch ID from info

Hi, Sergei Shtylyov writes: >> -id = mv88e6xxx_reg_read(ps, REG_PORT(0), PORT_SWITCH_ID); >> +of_id = of_match_node(mv88e6xxx_of_id_table, np); > > You could use of_device_get_match_data() here. > >> +if (!of_id) >> +return

padata - is serial actually serial?

Hi Steffen & Folks, I submit a job to padata_do_parallel(). When the parallel() function triggers, I do some things, and then call padata_do_serial(). Finally the serial() function triggers, where I complete the job (check a nonce, etc). The padata API is very appealing because not only does it

[PATCH iproute2 3/6] ip neigh: Add support for keyword

Add vrf keyword to 'ip neigh' commands. Allows listing neighbor entries for all links associated with a given VRF. $ ip neigh show vrf NAME versus current syntax: $ ip neigh show master DEV Signed-off-by: David Ahern --- ip/ipneigh.c | 14 +- 1 file

[PATCH iproute2 1/6] ip vrf: Add name_is_vrf

Add name_is_vrf function to determine if given name corresponds to a VRF device. Signed-off-by: David Ahern --- ip/ip_common.h | 2 ++ ip/iplink_vrf.c | 53 + 2 files changed, 55 insertions(+) diff --git

[PATCH iproute2 5/6] ip vrf: Add ipvrf_get_table

Add ipvrf_get_table to lookup table id for device name. Returns 0 on any error or if name is not a VRF device. Signed-off-by: David Ahern --- ip/ip_common.h | 1 + ip/iplink_vrf.c | 66 + 2 files changed, 67

[PATCH iproute2 4/6] ip route: Change type mask to bitmask

Allow option to select multiple route types to show or exlude specific route types. Signed-off-by: David Ahern --- ip/iproute.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index 8224d7ffa94b..aae693d17be8

[PATCH iproute2 6/6] ip route: Add support for vrf keyword

Add vrf keyword to 'ip route' commands. Allows: 1. Users can list routes by VRF name: $ ip route show vrf NAME VRF tables have all routes including local and broadcast routes. The VRF keyword filters LOCAL and BROADCAST routes; to see all routes the table option can be used. Or to

[PATCH iproute2 2/6] ip link/addr: Add support for vrf keyword

Add vrf keyword to 'ip link' and 'ip addr' commands (common list code). Allows: 1. Adding a link to a VRF using the vrf name: $ ip link set NAME vrf NAME Versus the current syntax: $ ip link set NAME master DEV Removing a link from a VRF still uses 'ip link set NAME nomaster' 2.

[PATCH iproute2 0/6] Add support for vrf keyword

Currently the syntax for VRF related commands is rather kludgy and inconsistent from one subcommand to another. This set adds support for the VRF keyword to the link, address, neigh, and route commands to improve the user experience listing data associated with vrfs, modifying routes or doing a

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/14/2016 03:44 PM, Sergei Shtylyov wrote: On 06/14/2016 07:16 PM, Jeremy Linton wrote: If the interrupt configuration isn't set and we are using the It's never set, judging by the driver code. internal phy, then we need to poll the phy to reliably detect phy state changes.

[iproute2 PATCH] utils: fix hex digits parsing in hexstring_a2n()

strtoul() only modifies errno on overflow, so if errno is not zero before calling the function its value is preserved and makes the function fail for valid inputs; initialize it. Signed-off-by: Beniamino Galvani --- lib/utils.c | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/14/2016 01:42 PM, Andrew Lunn wrote: On Tue, Jun 14, 2016 at 11:16:02AM -0500, Jeremy Linton wrote: If the interrupt configuration isn't set and we are using the internal phy, then we need to poll the phy to reliably detect phy state changes. Hi Jeremy Why does the external phy not

Re: [PATCH] mdio: mux: avoid 'maybe-uninitialized' warning

On Tue, Jun 14, 2016 at 12:03:17PM +0200, Arnd Bergmann wrote: > The latest changes to the MDIO code introduced a false-positive > warning with gcc-6 (possibly others): > > drivers/net/phy/mdio-mux.c: In function 'mdio_mux_init': > drivers/net/phy/mdio-mux.c:188:3: error: 'parent_bus_node' may be

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/14/2016 07:16 PM, Jeremy Linton wrote: If the interrupt configuration isn't set and we are using the It's never set, judging by the driver code. internal phy, then we need to poll the phy to reliably detect phy state changes. What address your internal PHY is at? Mine is at 1,

Re: [very-RFC 0/8] TSN driver for the kernel

On Tue, Jun 14, 2016 at 08:26:15PM +0200, Richard Cochran wrote: > On Tue, Jun 14, 2016 at 11:30:00AM +0200, Henrik Austad wrote: > > So loop data from kernel -> userspace -> kernelspace and finally back to > > userspace and the media application? > > Huh? I wonder where you got that idea. Let

Re: [RFC] Handle error writing UINT_MAX to u32 fields

On 2016-06-12 20:30, subas...@codeaurora.org wrote: The suggested change would extend the usable range of positive numbers by one bit only. As many systems are 64 bit this does not seem forward looking. I would prefer to have a routine that can handle 64 bit integers with limits (let's call it

Re: Avoiding bridge flood of multicast when L2 switch is used

> netdev experts, > > When there is a L2 switch underneath the network interface a flooding of > multicast at the bridge interface results in one copy of this going through > each > of the slave resulting in multiple multicast packets reaching the underlying > switch. Yes, this is something

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/14/2016 11:12 PM, Andrew Lunn wrote: On Tue, Jun 14, 2016 at 10:49:20PM +0300, Sergei Shtylyov wrote: On 06/14/2016 10:27 PM, Sergei Shtylyov wrote: If the interrupt configuration isn't set and we are using the internal phy, then we need to poll the phy to reliably detect phy state

Re: [PATCH net-next v4 0/7] vmxnet3: upgrade to version 3

On 06/14/2016 11:52 AM, Shrikrishna Khare wrote: > This patchset upgrades vmxnet3 to version 3. > > Changes in v2: > - Following patch is updated. See that patch for details: >vmxnet3: add support for get_coalesce, set_coalesce ethtool > > Changes in v3: > - fix subject line to use

Re: [PATCH] net: smsc911x: If PHY doesn't have an interrupt then POLL

On 06/14/2016 02:49 PM, Sergei Shtylyov wrote: On 06/14/2016 10:27 PM, Sergei Shtylyov wrote: If the interrupt configuration isn't set and we are using the internal phy, then we need to poll the phy to reliably detect phy state changes. Signed-off-by: Jeremy Linton ---

  1   2   3   >