Re: [PATCH] [linux-next] rtlwifi: Fix typo in printk

2016-06-28 Thread Larry Finger
On 06/28/2016 10:37 PM, Masanari Iida wrote: This patch fix spelling typos found in drivers/net/wireless/realtek. Signed-off-by: Masanari Iida Acked--by: Larry Finger Thanks, Larry ---

[net-next 01/16] i40e: add functions to control default VSI

2016-06-28 Thread Jeff Kirsher
From: Mitch Williams Add functions to enable and disable default VSI on a VEB. This allows for configuration of limited promiscuous mode specifically for bridging purposes. Change-ID: I0cc5bd68b31c500fdff4d47e1f15d50d2739faf4 Signed-off-by: Mitch Williams

[net-next 13/16] i40e: add VSI info to macaddr messages

2016-06-28 Thread Jeff Kirsher
From: Shannon Nelson Since the macaddr add and delete happens asynchronously, error messages don't easily get associated to the actual request. Here we add a bit of information to the error messages to help determine the source of the error. Change-ID:

[net-next 12/16] i40e: set default VSI without a reset

2016-06-28 Thread Jeff Kirsher
From: Mitch Williams Remove the need for a reset when the device enters limited promiscuous mode. This was causing heartburn for people who were using VFs and bridging, since this would require all of the VFs to undergo a reset each time the PF changed its

[net-next 11/16] i40evf: always activate correct MAC address filter

2016-06-28 Thread Jeff Kirsher
From: Mitch Williams Always add MAC address at the tail of the MAC filter list. Since the device's "real" MAC address is added first, it will always be at the beginning of the list. This prevents an issue where the "real" MAC filter might not get added if too many

[net-next 09/16] i40e: Removing unnecessary code which caused supported link mode bug

2016-06-28 Thread Jeff Kirsher
From: Avinash Dayanand Removing this code which wasn't allowing 100BaseT to show up in the supported link modes for 10GBaseT PHYs. Change-ID: Iada2eafa7ef6b4bac9a2a1380ff533ae5de51e1d Signed-off-by: Avinash Dayanand Tested-by: Andrew

[net-next 10/16] i40e: Fix RSS to not be limited by the number of CPUs

2016-06-28 Thread Jeff Kirsher
From: Catherine Sullivan Limiting qcount to pf->num_lan_msix, effectively limits the RSS queues to only use the number of CPUs, and ignore all other queues. We don't want to do this. If the user has changed the RSS settings to use more queues then CPUS, we want to

[net-next 00/16][pull request] 40GbE Intel Wired LAN Driver Updates 2016-06-27

2016-06-28 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Mitch provides several changes, first adds functions to enable and disable VSI on a VEB, which allows for configuration of limited promiscuous mode specifically for bridging purposes. Sets the RSS Hash Enable registers by default now that VF

[net-next 14/16] i40e/i40evf: Bump version from 1.5.16 to 1.6.4

2016-06-28 Thread Jeff Kirsher
From: Bimmy Pujari Signed-off-by: Bimmy Pujari Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--

[net-next 04/16] i40e: Add a call to set the client interface down

2016-06-28 Thread Jeff Kirsher
From: Catherine Sullivan We were failing to set the client interface down when we put the VSI down. Add this call so that the client doesn't get an open called with no close. Also remove an un-needed delay. The VF should not be affected at all by i40e_down.

[net-next 07/16] i40e: Save PCI state before suspend

2016-06-28 Thread Jeff Kirsher
From: Greg Rose The i40e_suspend() function was failing to save PCI state and this would result in a kernel stack trace from a WARN_ONCE in the pci_legacy_suspend() function. Add a call to pci_save_state() to fix that problem. Change-ID:

Re: [PATCH 0/4] Mesh mpm fixes and enhancements

2016-06-28 Thread Julian Calaby
Hi Yaniv, On Tue, Jun 28, 2016 at 9:13 PM, Yaniv Machani wrote: > This patch set is addressing some issues found in the current 802.11s > implementation, > specifically when using hostap mpm. > It's aligning the beacon format and handling some corner cases. > > Maital Hahn (2):

[net-next 16/16] i40e: Don't notify client(s) for DCB changes on all VSIs

2016-06-28 Thread Jeff Kirsher
From: Neerav Parikh When LLDP/DCBX change happens the i40e driver code flow tried to notify the client(s) for each of the PF VSIs. This resulted into kernel panic on the first VSI that didn't have any netdev associated to it. The DCB change notification to the client(s)

[net-next 08/16] i40e: fix missing DA cable check

2016-06-28 Thread Jeff Kirsher
From: Serey Kong When a Direct Attach (DA) cable is used, if the i40e_set_settings function is called it would return an error. Add the DA type so the function won't fail. Change-ID: I2b802f27a5d91cfefa72fd1f852acb4d74647a8e Signed-off-by: Serey Kong

[net-next 06/16] i40e: Clean up MSIX IRQs before suspend

2016-06-28 Thread Jeff Kirsher
From: Greg Rose The i40e_suspend() function calls another function that preps the device for the power save and resume by freeing all the Tx/Rx resources and interrupts but that function does not free the "other" causes interrupt vector and IRQ. It also fails to call

[net-next 03/16] i40e: write HENA for VFs

2016-06-28 Thread Jeff Kirsher
From: Mitch Williams Now that VF RSS is configured by the PF driver, it needs to set the RSS Hash Enable registers by default. Without this, no packets will be hashed and they'll all end up on queue 0. Change-ID: I38e425f40ddb81e3b19a951cfbb939fa5b1123f1

[net-next 02/16] i40e: add hw struct local variable

2016-06-28 Thread Jeff Kirsher
From: Mitch Williams This function uses the i40e_hw struct all over the place, so why doesn't it keep a pointer to the struct? Add this pointer as a local variable and use it consistently throughout the function. Change-ID: I10eb688fe40909433fcb8ac7ac891cef67445d72

[net-next 15/16] i40e: Fix errors resulted while turning off TSO

2016-06-28 Thread Jeff Kirsher
From: Tushar Dave On systems with 128 CPUs, turning off TSO results in errors, i40e :03:00.0: failed to get tracking for 1 vectors for VSI 400, err=-12 i40e :03:00.0: Couldn't create FDir VSI i40e :03:00.0: i40e_ptp_init: PTP not supported on eth0 i40e

[net-next 05/16] i40evf: don't overflow buffer

2016-06-28 Thread Jeff Kirsher
From: Mitch Williams If the user adds an obscene amount of MAC addresses, the driver will run into the situation where it has too many address requests to fit into a single PF message. The driver checks for this case, and calculates the maximum number of messages that

Re: [PATCH] [linux-next] rtlwifi: Fix typo in printk

2016-06-28 Thread Julian Calaby
Hi All, On Wed, Jun 29, 2016 at 1:37 PM, Masanari Iida wrote: > This patch fix spelling typos found in drivers/net/wireless/realtek. > > Signed-off-by: Masanari Iida Looks right to me. Reviewed-by: Julian Calaby Thanks,

[net] e1000e: keep VLAN interfaces functional after rxvlan off

2016-06-28 Thread Jeff Kirsher
From: Jarod Wilson I've got a bug report about an e1000e interface, where a VLAN interface is set up on top of it: $ ip link add link ens1f0 name ens1f0.99 type vlan id 99 $ ip link set ens1f0 up $ ip link set ens1f0.99 up $ ip addr add 192.168.99.92 dev ens1f0.99 At this

[PATCH] [linux-next] rtlwifi: Fix typo in printk

2016-06-28 Thread Masanari Iida
This patch fix spelling typos found in drivers/net/wireless/realtek. Signed-off-by: Masanari Iida --- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c | 2 +- drivers/net/wireless/realtek/rtlwifi/rtl8192c/phy_common.c | 2 +-

RE: [PATCH net-next v3 0/7] r8152: support new chips

2016-06-28 Thread Hayes Wang
> From: Hayes Wang > Sent: Tuesday, June 28, 2016 8:29 PM > To: netdev@vger.kernel.org > Cc: nic_swsd; linux-ker...@vger.kernel.org; linux-...@vger.kernel.org; Hayes > Wang > Subject: [PATCH net-next v3 0/7] r8152: support new chips Excuse me. Please ignore these patches. We want to do more tests

[PATCH net-next] cxgb4: Introduce API for sending work requests on ctrl queue via copy

2016-06-28 Thread Hariprasad Shenai
If the ctrl queue is full, just follows current path by allocating an skb. If that fails then caller will just have to handle that case as before. Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 +

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

2016-06-28 Thread Herbert Xu
On Tue, Jun 28, 2016 at 10:35:31AM -0700, Andy Lutomirski wrote: > > Do you mean this code: Yes. > I'm wondering why support for scatterlists is all-or-nothing. Why > can't we initialize a hash object and then alternate between passing > it scatterlists and pointers? Because once you have

Re: Doing crypto in small stack buffers (bluetooth vs vmalloc-stack crash, etc)

2016-06-28 Thread Herbert Xu
On Tue, Jun 28, 2016 at 10:32:12AM -0400, George Spelvin wrote: > > - struct crypto_instance > - struct crypto_spawn > - struct crypto_blkcipher > - struct blkcipher_desc > - More on the context structures returned by crypto_tfm_ctx blkcipher is obsolete and will be removed soon. So if you are

Re: [iproute PATCH 1/2] ip-address: Support filtering by slave type, too

2016-06-28 Thread David Ahern
On 6/28/16 7:07 AM, Phil Sutter wrote: This patch allows to query all interfaces enslaved to a bridge or bond using the following syntax: works for vrf's too.

Re: [PATCH v3] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule

2016-06-28 Thread David Ahern
On 6/28/16 6:03 AM, Mateusz Bajorski wrote: diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c index 98298b1..fa0c3ff 100644 --- a/net/core/fib_rules.c +++ b/net/core/fib_rules.c @@ -269,6 +269,46 @@ errout: return err; } +static int rule_exists(struct fib_rules_ops *ops, struct

[PATCH net-next 08/10] liquidio: Droq validation

2016-06-28 Thread Raghu Vatsavayi
This patch removes redudant droq num validation. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next 09/10] liquidio: Remove redundant code

2016-06-28 Thread Raghu Vatsavayi
This patch removes redundant file includes and conditions. Provides some meaningful comments and code alignment. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next 05/10] liquidio: iq/oq limits

2016-06-28 Thread Raghu Vatsavayi
This patch removes the dependency of number of iq/oq's on number of cpus. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu

[PATCH net-next 10/10] liquidio: Response header changes

2016-06-28 Thread Raghu Vatsavayi
This patch changes response header to be able to communicate with new firmware interface. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next 06/10] liquidio: free resources during shutdown

2016-06-28 Thread Raghu Vatsavayi
This patch fixes the issue of proper freeing of queue memory resources during free device. It also has fix for correct pcie error reporting. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix

[PATCH net-next 01/10] liquidio: Vxlan support

2016-06-28 Thread Raghu Vatsavayi
This patch adds support for Vxaln offloads in liquidio driver. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next 03/10] liquidio: IQ synchronization

2016-06-28 Thread Raghu Vatsavayi
This patch tries to protect against bh preemption with sc_buf_pool. It also modifies the syncronization primitives during input queue processing. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by:

[PATCH net-next 07/10] liquidio: MTU limits

2016-06-28 Thread Raghu Vatsavayi
This patch limits the MTU between 68 bytes and 16000 bytes. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next 04/10] liquidio: softcommand delay

2016-06-28 Thread Raghu Vatsavayi
This patch updates the delay constant for softcommands in accrodance with new requirements. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next 02/10] liquidio: Macro replacements

2016-06-28 Thread Raghu Vatsavayi
This patch has minor replacements of ACCESS_ONCE macros with WRITE_ONCE and replacement of BUG_ON with polite version WARN_ON. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next 00/10] liquidio updates and bug fixes

2016-06-28 Thread Raghu Vatsavayi
Dave, Following are some more updates and bug fixes for liquidio driver. Please apply the patches in following order as some of the patches depend on earlier patches in the sereis. Raghu Vatsavayi (10): liquidio: Vxlan support liquidio: Macro replacements liquidio: IQ synchronization

Re: [PATCH v2 iproute2 3/3] ss: Add support to filter on device

2016-06-28 Thread Stephen Hemminger
On Tue, 28 Jun 2016 11:40:40 -0600 David Ahern wrote: > On 6/27/16 3:13 PM, Stephen Hemminger wrote: > > On Mon, 27 Jun 2016 11:34:25 -0700 > > David Ahern wrote: > > > >> + case SSF_DEVCOND: > >> + { > >> + struct

[PATCH] ip route: timeout for routes has to be set in seconds

2016-06-28 Thread Andrey Vagin
From: Andrew Vagin Currently a timeout is multiplied by HZ in user-space and then it multiplied by HZ in kernel-space. $ ./ip/ip r add 2002::0/64 dev veth1 expires 10 $ ./ip/ip -6 r 2002::/64 dev veth1 metric 1024 linkdown expires 996sec pref medium Cc: Xin Long

[PATCH V2 net-next] tcp: increase size at which tcp_bound_to_half_wnd bounds to > TCP_MSS_DEFAULT

2016-06-28 Thread Seymour, Shane M
In previous commit 01f83d69844d307be2aa6fea88b0e8fe5cbdb2f4 the following comments were added: "When peer uses tiny windows, there is no use in packetizing to sub-MSS pieces for the sake of SWS or making sure there are enough packets in the pipe for fast recovery." The test should be >

[PATCH 2/2] net: ethernet: lpc_eth: use phy_ethtool_{get|set}_link_ksettings

2016-06-28 Thread Philippe Reynes
There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the same code in the driver. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/nxp/lpc_eth.c | 26 ++ 1 files changed, 2

RE: [PATCH net-next] tcp: increase size at which tcp_bound_to_half_wnd bounds to > TCP_MSS_DEFAULT

2016-06-28 Thread Seymour, Shane M
> From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Your diff is reversed. Sorry my apologies, I'll send a V2.

Re: [PATCH net-next] tcp: increase size at which tcp_bound_to_half_wnd bounds to > TCP_MSS_DEFAULT

2016-06-28 Thread Neal Cardwell
On Tue, Jun 28, 2016 at 5:54 PM, Seymour, Shane M wrote: >> From: Eric Dumazet [mailto:eric.duma...@gmail.com] ... >> Anyway, your patch is reversed. > > I'm not sure what you mean by reversed, I didn't change the direction > of the test in the code just what it's being

Re: [PATCH net-next] tcp: increase size at which tcp_bound_to_half_wnd bounds to > TCP_MSS_DEFAULT

2016-06-28 Thread Eric Dumazet
On Tue, 2016-06-28 at 21:54 +, Seymour, Shane M wrote: > > From: Eric Dumazet [mailto:eric.duma...@gmail.com] > > Trying to cope with ridiculous windows these days is really a waste of > > time, as we perform this check for all tcp sendmsg() calls :( > > I don't disagree with you but

[PATCH 1/2] net: ethernet: lpc_eth: use phydev from struct net_device

2016-06-28 Thread Philippe Reynes
The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes ---

RE: [PATCH net-next] tcp: increase size at which tcp_bound_to_half_wnd bounds to > TCP_MSS_DEFAULT

2016-06-28 Thread Seymour, Shane M
> From: Eric Dumazet [mailto:eric.duma...@gmail.com] > Trying to cope with ridiculous windows these days is really a waste of > time, as we perform this check for all tcp sendmsg() calls :( I don't disagree with you but unfortunately there are still devices out there like this and probably will

Re: [PATCH v4] wlcore: spi: add wl18xx support

2016-06-28 Thread Rob Herring
On Sun, Jun 26, 2016 at 10:10:54AM +, Reizer, Eyal wrote: > Add support for using with both wl12xx and wl18xx. > > - all wilink family needs special init command for entering wspi mode. > extra clock cycles should be sent after the spi init command while the > cs pin is high. > - Use

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

2016-06-28 Thread Rob Herring
On Fri, Jun 24, 2016 at 06:46:48PM -0500, Timur Tabi wrote: > Add supports for ethernet controller HW on Qualcomm Technologies, Inc. SoC. > This driver supports the following features: > 1) Checksum offload. > 2) Interrupt coalescing support. > 3) SGMII phy. > 4) phylib interface for external phy

Re: [RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

2016-06-28 Thread Sergei Shtylyov
Hello. On 06/28/2016 10:34 PM, Jon Mason wrote: Signed-off-by: Jon Mason --- .../devicetree/bindings/net/brcm,bgmac-enet.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt

Re: [RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

2016-06-28 Thread Andrew Lunn
On Tue, Jun 28, 2016 at 03:34:40PM -0400, Jon Mason wrote: > Move the BCMA MDIO phy into a separate file, as it is very tightly > coupled with the BCMA bus. This will help with the upcoming BCMA > removal from the bgmac driver. Optimally, this should be moved into > phy drivers, but it is too

Re: [RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints

2016-06-28 Thread Joe Perches
On Tue, 2016-06-28 at 15:34 -0400, Jon Mason wrote: > The bgmac_* print wrappers call dev_* prints with the dev pointer from > the bcma core.  In anticipation of removing the bcma requirement for > this driver, these must be changed to not reference that struct.  So, > simply change all of the

[RFC 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints

2016-06-28 Thread Jon Mason
The bgmac_* print wrappers call dev_* prints with the dev pointer from the bcma core. In anticipation of removing the bcma requirement for this driver, these must be changed to not reference that struct. So, simply change all of the bgmac_* prints to their dev_* counterparts. In some cases

[RFC 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file

2016-06-28 Thread Jon Mason
Move the BCMA MDIO phy into a separate file, as it is very tightly coupled with the BCMA bus. This will help with the upcoming BCMA removal from the bgmac driver. Optimally, this should be moved into phy drivers, but it is too tightly coupled with the bgmac driver to effectively move it without

[RFC 5/7] net: ethernet: bgmac: Add platform device support

2016-06-28 Thread Jon Mason
The bcma portion of the driver has been split off into a bcma specific driver. This has been mirrored for the platform driver. The last references to the bcma core struct have been changed into a generic function call. These function calls are wrappers to either the original bcma code or new

[RFC 4/7] net: ethernet: bgmac: convert to feature flags

2016-06-28 Thread Jon Mason
The bgmac driver is using the bcma provides device ID and revision, as well as the SoC ID and package, to determine which features are necessary to enable, reset, etc in the driver. In anticipation of removing the bcma requirement for this driver, these must be changed to not reference that

[RFC 0/7] net: ethernet: bgmac: Add platform device support

2016-06-28 Thread Jon Mason
I'm sending out this RFC to see if this is the direction the maintainers would like to go to add support for other, non-bcma iProc SoC's to the bgmac driver. Specifically, we are interested in adding support for the NSP, Cygnus, and NS2 families (with more possible down the road). To support

[RFC 7/7] ARM: dts: NSP: Add bgmac entries

2016-06-28 Thread Jon Mason
Add device tree entries for the ethernet devices present on the Broadcom Northstar Plus SoCs Signed-off-by: Jon Mason --- arch/arm/boot/dts/bcm-nsp.dtsi | 16 arch/arm/boot/dts/bcm958625k.dts | 8 2 files changed, 24 insertions(+) diff --git

[RFC 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

2016-06-28 Thread Jon Mason
Signed-off-by: Jon Mason --- .../devicetree/bindings/net/brcm,bgmac-enet.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/brcm,bgmac-enet.txt diff --git

[RFC 2/7] net: ethernet: bgmac: add dma_dev pointer

2016-06-28 Thread Jon Mason
The dma buffer allocation, etc references a dma_dev device pointer from the bcma core. In anticipation of removing the bcma requirement for this driver, these must be changed to not reference that struct. Add a dma_dev device pointer to the bgmac stuct and reference that instead. Signed-off-by:

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-28 Thread John Fastabend
On 16-06-28 12:12 PM, Jiri Pirko wrote: > Tue, Jun 28, 2016 at 09:04:00PM CEST, sridhar.samudr...@intel.com wrote: >> >> >> On 6/28/2016 11:46 AM, Jiri Pirko wrote: >>> Tue, Jun 28, 2016 at 07:19:06PM CEST, john.fastab...@gmail.com wrote: On 16-06-28 09:19 AM, John Fastabend wrote: > On

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-28 Thread Jiri Pirko
Tue, Jun 28, 2016 at 09:04:00PM CEST, sridhar.samudr...@intel.com wrote: > > >On 6/28/2016 11:46 AM, Jiri Pirko wrote: >>Tue, Jun 28, 2016 at 07:19:06PM CEST, john.fastab...@gmail.com wrote: >>>On 16-06-28 09:19 AM, John Fastabend wrote: On 16-06-28 03:25 AM, Or Gerlitz wrote: >On

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-28 Thread Samudrala, Sridhar
On 6/28/2016 11:46 AM, Jiri Pirko wrote: Tue, Jun 28, 2016 at 07:19:06PM CEST, john.fastab...@gmail.com wrote: On 16-06-28 09:19 AM, John Fastabend wrote: On 16-06-28 03:25 AM, Or Gerlitz wrote: On 6/28/2016 8:57 AM, John Fastabend wrote: On 16-06-27 09:07 AM, Saeed Mahameed wrote: Add

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-28 Thread Jiri Pirko
Tue, Jun 28, 2016 at 07:19:06PM CEST, john.fastab...@gmail.com wrote: >On 16-06-28 09:19 AM, John Fastabend wrote: >> On 16-06-28 03:25 AM, Or Gerlitz wrote: >>> On 6/28/2016 8:57 AM, John Fastabend wrote: On 16-06-27 09:07 AM, Saeed Mahameed wrote: > Add the commands to set and show the

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

2016-06-28 Thread Phil Sutter
On Tue, Jun 28, 2016 at 11:59:04AM -0600, David Ahern wrote: > On 6/28/16 11:58 AM, Phil Sutter wrote: > >> since .ifr_qlen is already referenced in that function seems like your > >> suggestion above (struct ifreq ifr = { .ifr_qlen = 0 };) should be > >> acceptable. > > > > You mean regarding

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

2016-06-28 Thread David Ahern
On 6/28/16 11:58 AM, Phil Sutter wrote: since .ifr_qlen is already referenced in that function seems like your suggestion above (struct ifreq ifr = { .ifr_qlen = 0 };) should be acceptable. You mean regarding compatibility of using that define? Or are you concerned with gcc creating suboptimal

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

2016-06-28 Thread Phil Sutter
On Tue, Jun 28, 2016 at 11:37:43AM -0600, David Ahern wrote: > On 6/28/16 11:37 AM, Phil Sutter wrote: > >>> I saw these too with gcc-3.4.6 but not with 5.3.0. It appears to be a > >>> gcc bug[1]. One possible workaround is to match the brace level of the > >>> first field, but it's quite ugly:

Re: [PATCH v2 iproute2 3/3] ss: Add support to filter on device

2016-06-28 Thread David Ahern
On 6/27/16 3:13 PM, Stephen Hemminger wrote: On Mon, 27 Jun 2016 11:34:25 -0700 David Ahern wrote: + case SSF_DEVCOND: + { + struct aafilter *a = (void *)f->pred; I don't like the wandering bracket left, but all the code has that.

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

2016-06-28 Thread David Ahern
On 6/28/16 11:37 AM, Phil Sutter wrote: I saw these too with gcc-3.4.6 but not with 5.3.0. It appears to be a gcc bug[1]. One possible workaround is to match the brace level of the first field, but it's quite ugly: [2]. Another way might be to initialize one of the fields to zero, like so: |

Re: [PATCH v2 net-next] tcp: md5: use kmalloc() backed scratch areas

2016-06-28 Thread Andy Lutomirski
On Mon, Jun 27, 2016 at 8:41 PM, Herbert Xu wrote: > On Mon, Jun 27, 2016 at 10:58:42AM -0700, Andy Lutomirski wrote: >> >> I wonder if it's worth switching from ahash to shash, though. It >> would probably be simpler and faster. > > No shash is not appropriate here

Re: [PATCH v2] notifier: Fix soft lockup for notifier_call_chain().

2016-06-28 Thread Cong Wang
On Mon, Jun 27, 2016 at 11:22 PM, Eric Dumazet wrote: > Lot of this code was written decade ago where nobody expected a root > user was going to try hard to crash its host ;) +1 Adding cond_resched() to appropriate network notifiers sounds better.

Re: [iproute PATCH v3 0/6] Big C99 style initializer rework

2016-06-28 Thread Phil Sutter
On Mon, Jun 27, 2016 at 02:10:49PM -0700, Stephen Hemminger wrote: > On Mon, 27 Jun 2016 20:23:02 +0200 > Phil Sutter wrote: > > > Hi, > > > > On Mon, Jun 27, 2016 at 10:59:12AM -0700, Stephen Hemminger wrote: > > > On Thu, 23 Jun 2016 17:34:08 + > > > Phil Sutter

Re: Deleting child qdisc doesn't reset parent to default qdisc?

2016-06-28 Thread Jiri Kosina
On Tue, 28 Jun 2016, Cong Wang wrote: > > BTW, I've started to actually work on fixing this, and I've noticed that > > TBF behavior actually violates what's stated in pfifo_fast manpage: > > > > == > > Whenever an interface is created, the pfifo_fast qdisc is > >

Re: Deleting child qdisc doesn't reset parent to default qdisc?

2016-06-28 Thread Cong Wang
On Tue, Jun 28, 2016 at 8:19 AM, Jiri Kosina wrote: > BTW, I've started to actually work on fixing this, and I've noticed that > TBF behavior actually violates what's stated in pfifo_fast manpage: > > == > Whenever an interface is created, the pfifo_fast qdisc

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-28 Thread John Fastabend
On 16-06-28 09:19 AM, John Fastabend wrote: > On 16-06-28 03:25 AM, Or Gerlitz wrote: >> On 6/28/2016 8:57 AM, John Fastabend wrote: >>> On 16-06-27 09:07 AM, Saeed Mahameed wrote: Add the commands to set and show the mode of SRIOV E-Switch, two modes are supported: * legacy

[iproute PATCH v4] Use ARRAY_SIZE macro everywhere

2016-06-28 Thread Phil Sutter
This patch was generated by the following semantic patch (a trimmed down version of what is shipped with Linux sources): @@ type T; T[] E; @@ ( - (sizeof(E)/sizeof(*E)) + ARRAY_SIZE(E) | - (sizeof(E)/sizeof(E[...])) + ARRAY_SIZE(E) | - (sizeof(E)/sizeof(T)) + ARRAY_SIZE(E) ) The only manual

Re: [PATCH] libertas_tf: Remove create_workqueue

2016-06-28 Thread Kalle Valo
Bhaktipriya Shridhar writes: > Ping! I'm lagging behind, the patch is still on my queue: https://patchwork.kernel.org/patch/9162447/ Please don't top most, it's annoying. -- Kalle Valo

Re: [PATCH] libertas_tf: Remove create_workqueue

2016-06-28 Thread Bhaktipriya Shridhar
Ping! Thanks, Bhaktipriya On Sun, Jun 12, 2016 at 4:17 AM, Tejun Heo wrote: > On Wed, Jun 08, 2016 at 01:38:53AM +0530, Bhaktipriya Shridhar wrote: >> alloc_workqueue replaces deprecated create_workqueue(). >> >> A dedicated workqueue has been used since the workitem (viz >>

Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

2016-06-28 Thread Cong Wang
On Tue, Jun 28, 2016 at 7:30 AM, Or Gerlitz wrote: > Wow, can you please report us the exact card type (lspci -nn | grep -i > mellanox) and firmware version (ethtool -i $DEV) See below. Does commit f8c6455bb04b944edb69e rely on any firmware change to get an expected

[RFC PATCH] sch_tbf: avoid silent fallback to noop_qdisc (was Re: Deleting child qdisc doesn't reset parent to default qdisc?)

2016-06-28 Thread Jiri Kosina
On Fri, 15 Apr 2016, Eric Dumazet wrote: > Then you need to save the initial qdisc (bfifo for TBF) in a special > place, to make sure the delete operation is guaranteed to succeed. > > Or fail the delete if the bfifo can not be allocated. > > I can tell that determinism if far more interesting

Re: [PATCH net-next 08/16] net/devlink: Add E-Switch mode control

2016-06-28 Thread John Fastabend
On 16-06-28 03:25 AM, Or Gerlitz wrote: > On 6/28/2016 8:57 AM, John Fastabend wrote: >> On 16-06-27 09:07 AM, Saeed Mahameed wrote: >>> Add the commands to set and show the mode of SRIOV E-Switch, two >>> modes are supported: >>> >>> * legacy : operating in the "old" L2 based mode (DMAC --> VF

Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

2016-06-28 Thread Oliver Hartkopp
On 06/28/2016 09:36 AM, Holger Schurig wrote: static void can_dellink(struct net_device *dev, struct list_head *head); and static void can_dellink(struct net_device *dev, struct list_head *head) { return; } Wouldn't the canonical form be this: static void can_dellink(struct

Re: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-06-28 Thread Rick Jones
On 06/28/2016 02:59 AM, Dexuan Cui wrote: The idea here is: IMO the syscalls sys_read()/write() shoudn't return -ENOMEM, so I have to make sure the buffer allocation succeeds? I tried to use kmalloc with __GFP_NOFAIL, but I hit a warning in in mm/page_alloc.c: WARN_ON_ONCE((gfp_flags &

RE: [PATCH v12 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-06-28 Thread Dexuan Cui
> From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, June 28, 2016 21:45 > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com;

[PATCH net v2] openvswitch: fix conntrack netlink event delivery

2016-06-28 Thread Samuel Gauthier
Only the first and last netlink message for a particular conntrack are actually sent. The first message is sent through nf_conntrack_confirm when the conntrack is committed. The last one is sent when the conntrack is destroyed on timeout. The other conntrack state change messages are not

Re: Deleting child qdisc doesn't reset parent to default qdisc?

2016-06-28 Thread Jiri Kosina
On Fri, 15 Apr 2016, Eric Dumazet wrote: > > TBF is probably a bad example because it started life as a classless > > qdisc. There was only one built-in fifo queue that was shaped. Then > > someone made it classful and changed this behavior. To me it sounds > > reasonable to have the default

[PATCH net-next v2 1/2] net: rtnetlink: add support for the IFLA_STATS_LINK_XSTATS_SLAVE attribute

2016-06-28 Thread Nikolay Aleksandrov
This patch adds support for the IFLA_STATS_LINK_XSTATS_SLAVE attribute which allows to export per-slave statistics if the master device supports the linkxstats callback. The attribute is passed down to the linkxstats callback and it is up to the callback user to use it (an example has been added

[PATCH net-next v2 2/2] net: bridge: add support for IGMP/MLD stats and export them via netlink

2016-06-28 Thread Nikolay Aleksandrov
This patch adds stats support for the currently used IGMP/MLD types by the bridge. The stats are per-port (plus one stat per-bridge) and per-direction (RX/TX). The stats are exported via netlink via the new linkxstats API (RTM_GETSTATS). In order to minimize the performance impact, a new option is

[PATCH net-next v2 0/2] net: bridge: add support for IGMP/MLD stats

2016-06-28 Thread Nikolay Aleksandrov
Hi all, This patchset adds support for the new IFLA_STATS_LINK_XSTATS_SLAVE attribute which can be used with RTM_GETSTATS in order to export per-slave statistics. It works by passing the attribute to the linkxstats callback and if the callback user supports it - it should dump that slave's stats.

Re: [PATCH net-next 10/16] net/mlx5e: Add devlink based SRIOV mode changes (legacy --> offloads)

2016-06-28 Thread Andy Gospodarek
On Tue, Jun 28, 2016 at 05:25:11PM +0300, Or Gerlitz wrote: > On 6/28/2016 4:42 PM, Andy Gospodarek wrote: > >On Mon, Jun 27, 2016 at 07:07:23PM +0300, Saeed Mahameed wrote: > >>From: Or Gerlitz > >> > >>Implement handlers for the devlink commands to get and set the SRIOV >

RE: [PATCH 2/4] mac80211/cfg: mesh: fix healing time when a mesh peer is disconnecting

2016-06-28 Thread Machani, Yaniv
On Tue, Jun 28, 2016 at 15:27:47, Bob Copeland wrote: > linux- wirel...@vger.kernel.org; netdev@vger.kernel.org; Hahn, Maital > Subject: Re: [PATCH 2/4] mac80211/cfg: mesh: fix healing time when a > mesh peer is disconnecting > > On Tue, Jun 28, 2016 at 02:13:05PM +0300, Yaniv Machani wrote: > >

[RFC] WireGuard: next generation secure network tunnel

2016-06-28 Thread Jason A. Donenfeld
Hi Dave & Folks, Today I'm releasing WireGuard, an encrypted and authenticated tunneling virtual interface for the kernel. It uses next-generation cryptography and is designed to be both easy to use and simple to implement (only ~4000 LoC, which compared to xfrm or openvpn is spectacular),

Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

2016-06-28 Thread Or Gerlitz
On Tue, Jun 28, 2016 at 12:44 AM, Cong Wang wrote: > On Mon, Jun 27, 2016 at 2:08 PM, Or Gerlitz wrote: >> On Mon, Jun 27, 2016 at 9:22 PM, Cong Wang wrote: >> can you point/paste the exact warning and how to reproduce

Re: Doing crypto in small stack buffers (bluetooth vs vmalloc-stack crash, etc)

2016-06-28 Thread George Spelvin
> We have actually gained quite a bit of documentation recently. > Have you looked at Documentation/DocBook/crypto-API.tmpl? > > More is always welcome of course. It's improved since I last looked at it, but there are still many structures that aren't described: - struct crypto_instance -

Re: [PATCH net-next 10/16] net/mlx5e: Add devlink based SRIOV mode changes (legacy --> offloads)

2016-06-28 Thread Or Gerlitz
On 6/28/2016 4:42 PM, Andy Gospodarek wrote: On Mon, Jun 27, 2016 at 07:07:23PM +0300, Saeed Mahameed wrote: From: Or Gerlitz Implement handlers for the devlink commands to get and set the SRIOV E-Switch mode. When turning to the offloads mode, we disable the e-switch

Re: [PATCH] rtlwifi: Create _rtl_dbg_trace function to reduce RT_TRACE code size

2016-06-28 Thread Larry Finger
On 06/27/2016 10:55 PM, Joe Perches wrote: On Mon, 2016-06-27 at 19:53 -0500, Larry Finger wrote: On 06/25/2016 05:46 PM, Joe Perches wrote: This debugging macro can expand to a lot of code. Make it a function to reduce code size. (x86-64 defconfig w/ all rtlwifi drivers and allyesconfig) $

Re: [PATCH net-next 0/6] net: dsa: Platform data for dsa2.c

2016-06-28 Thread Andrew Lunn
On Mon, Jun 27, 2016 at 06:19:28PM -0700, Florian Fainelli wrote: > 2016-06-27 18:05 GMT-07:00 Andrew Lunn : > > On Mon, Jun 27, 2016 at 05:52:37PM -0700, Florian Fainelli wrote: > >> Hi all, > >> > >> This patch series adds support for platform data using the new code from > >>

Re: [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template

2016-06-28 Thread Bob Copeland
On Tue, Jun 28, 2016 at 02:13:06PM +0300, Yaniv Machani wrote: > From: Meirav Kama > > There are several values in HT info elements of mesh beacon (built by the > mac80211) that are incorrect. Would be good to enumerate the problems here. > To fix them: > 1. mac80211 will check

[PATCH] net: can: Introduce MEN 16Z192-00 CAN controller driver

2016-06-28 Thread Andreas Werner
This CAN Controller is found on MEN Chameleon FPGAs. The driver/device supports the CAN2.0 specification. There are 255 RX and 255 Tx buffer within the IP. The pointer for the buffer are handled by HW to make the access from within the driver as simple as possible. The driver also supports

  1   2   3   >