[Patch net] ppp: defer netns reference release for ppp channel

Matt reported that we have a NULL pointer dereference in ppp_pernet() from ppp_connect_channel(), i.e. pch->chan_net is NULL. This is due to that a parallel ppp_unregister_channel() could happen while we are in ppp_connect_channel(), during which pch->chan_net set to NULL. Since we need a

Re: [PATCH net] net: mvneta: set real interrupt per packet for tx_done

Hi, On Wed, Jul 06, 2016 at 04:18:58AM +0200, Marcin Wojtas wrote: > From: Dmitri Epshtein > > Commit aebea2ba0f74 ("net: mvneta: fix Tx interrupt delay") intended to > set coalescing threshold to a value guaranteeing interrupt generation > per each sent packet, so that

Re: [PATCH stable] sfc: report supported link speeds on SFP connections

From: Bert Kenward Date: Tue, 28 Jun 2016 11:11:11 +0100 > commit 1974282ab547df7437276c8d4ec47f3d2300f339 > Author: Bert Kenward > Date: Mon Jun 6 17:29:30 2016 +0100 > > sfc: report supported link speeds on SFP connections

Re: Backport bpf: try harder on clones when writing into skb? [Commit: 3697649ff29e0f647565eed04b27a7779c646a22]

From: Alexei Starovoitov Date: Tue, 5 Jul 2016 19:16:51 -0700 > On Tue, Jul 05, 2016 at 08:35:18AM -0700, Sargun Dhillon wrote: >> Does it make sense to backport >> 3697649ff29e0f647565eed04b27a7779c646a22 from 4.6 to the longterm >> (4.4) release? I can trivially

Re: [RFC 0/7] netlink: Add allocation flag to netlink_unicast()

From: Masashi Honma Date: Wed, 6 Jul 2016 09:28:29 +0900 > Though currently such a use case was not found, to solve potential > issue we will add an allocation flag to netlink_unicast(). We don't solve potential issues, we solve real issues. There is no reason to add

[PATCH] batman-adv: fix boolreturn.cocci warnings

net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in function 'batadv_bla_process_claim' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci CC: Sven Eckelmann

Re: [PATCH] xfrm: fix crash in XFRM_MSG_GETSA netlink handler

On Tue, Jul 05, 2016 at 12:13:03PM -0700, David Miller wrote: > From: Vegard Nossum > Date: Tue, 5 Jul 2016 10:18:08 +0200 > > > If we hit any of the error conditions inside xfrm_dump_sa(), then > > xfrm_state_walk_init() never gets called. However, we still call > >

Re: Backport bpf: try harder on clones when writing into skb? [Commit: 3697649ff29e0f647565eed04b27a7779c646a22]

On Tue, Jul 05, 2016 at 08:35:18AM -0700, Sargun Dhillon wrote: > Does it make sense to backport > 3697649ff29e0f647565eed04b27a7779c646a22 from 4.6 to the longterm > (4.4) release? I can trivially recreate the issue represented by > 3697649ff29e0f647565eed04b27a7779c646a22 by attaching a eBPF

[PATCH net] net: mvneta: set real interrupt per packet for tx_done

From: Dmitri Epshtein Commit aebea2ba0f74 ("net: mvneta: fix Tx interrupt delay") intended to set coalescing threshold to a value guaranteeing interrupt generation per each sent packet, so that buffers can be released with no delay. In fact setting threshold to '1' was wrong,

Re: [PATCH net-next 00/10] NCSI Support

On Tue, 2016-07-05 at 19:07 -0700, Alexei Starovoitov wrote: > > Great! Thanks for clarifying. > So then future netlink api is mandatory to drive this kernel patches? > How one can use this set without it? The netlink API is to tweak things, it works reasonably well autonomously without it. >

Re: [PATCH net-next 00/10] NCSI Support

On Wed, Jul 06, 2016 at 07:42:39AM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2016-07-05 at 10:44 -0700, Alexei Starovoitov wrote: > > > >  .../... > > > > > The design for the patchset is highlighted as below: > > > > > > > >    * The NCSI interface is abstracted with "struct ncsi_dev".

Re: Problem: BUG_ON hit in ppp_pernet() when re-connect after changing shared key on LAC

On Tue, Jul 5, 2016 at 5:05 PM, Matt Bennett wrote: > On 07/06/2016 08:37 AM, Cong Wang wrote: >> On Tue, Jul 5, 2016 at 10:59 AM, Cong Wang wrote: >>> On Mon, Jul 4, 2016 at 7:50 PM, Matt Bennett >>>

Re: [PATCH net-next v2 3/4] net: dsa: Suffix function manipulating device_node with _dn

Hi, Florian Fainelli writes: > On 07/05/2016 03:36 PM, Andrew Lunn wrote: >> On Tue, Jul 05, 2016 at 03:07:12PM -0700, Florian Fainelli wrote: >>> Make it clear that these functions take a device_node structure pointer >> >> Hi Florian >> >> Didn't we agree that we would

Re: Network hang after c3f1010b30f7fc611139cfb702a8685741aa6827 with CIPSO & Smack

On 7/5/2016 5:49 PM, David Ahern wrote: > On 7/5/16 5:38 PM, Casey Schaufler wrote: >> I have encountered a system hang with my Smack >> networking tests that bisects to the change below. >> I can't say that I have any idea why the change >> would impact the Smack processing, but there appears >>

Where is a git tree for submitting patch

Though I have made a patch to netdev, kbuild failed. The kbuild failed with the file "net/netlabel/netlabel_calipso.c". Though I watched below two trees, there was not such a file. http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/tree/net/netlabel

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/usb/r8152.c between commit: 2609af19362d ("r8152: fix runtime function for RTL8152") from the net tree and commit: a028a9e003f2 ("r8152: move the settings of PHY to a work queue") from the net-next

Re: Network hang after c3f1010b30f7fc611139cfb702a8685741aa6827 with CIPSO & Smack

On 7/5/16 5:38 PM, Casey Schaufler wrote: I have encountered a system hang with my Smack networking tests that bisects to the change below. I can't say that I have any idea why the change would impact the Smack processing, but there appears to be some serious packet processing going on. The

Network hang after c3f1010b30f7fc611139cfb702a8685741aa6827 with CIPSO & Smack

I have encountered a system hang with my Smack networking tests that bisects to the change below. I can't say that I have any idea why the change would impact the Smack processing, but there appears to be some serious packet processing going on. The Smack code is using CIPSO on the loopback

[RFC 6/7] genetlink: Add allocation flag to genlmsg_unicast()

Signed-off-by: Masashi Honma --- drivers/net/gtp.c | 3 ++- drivers/net/team/team.c | 5 +++-- drivers/net/wireless/mac80211_hwsim.c | 2 +- fs/dlm/netlink.c | 2 +- include/net/genetlink.h | 8 +---

[RFC 7/7] genetlink: Add allocation flag to genlmsg_reply()

Add allocation flag to genlmsg_reply() and remove netlink_unicast() temporal functionality for stepwise modification. Signed-off-by: Masashi Honma --- drivers/block/drbd/drbd_nl.c | 2 +- drivers/net/wireless/mac80211_hwsim.c | 2 +- include/net/genetlink.h

[RFC 2/7] netfilter: Add allocation flag to nfnetlink_unicast()

Signed-off-by: Masashi Honma --- include/linux/netfilter/nfnetlink.h | 2 +- net/netfilter/nfnetlink.c | 4 ++-- net/netfilter/nfnetlink_log.c | 4 ++-- net/netfilter/nfnetlink_queue.c | 3 ++- 4 files changed, 7 insertions(+), 6 deletions(-) diff

[RFC 4/7] infiniband: Add allocation flag to ibnl_unicast()

Signed-off-by: Masashi Honma --- drivers/infiniband/core/iwpm_msg.c | 6 +++--- drivers/infiniband/core/iwpm_util.c | 5 +++-- drivers/infiniband/core/iwpm_util.h | 1 + drivers/infiniband/core/netlink.c | 4 ++-- include/rdma/rdma_netlink.h | 3 ++- 5 files

[RFC 3/7] netlink: Add allocation flag to nlmsg_unicast()

Signed-off-by: Masashi Honma --- crypto/crypto_user.c | 3 ++- drivers/infiniband/core/netlink.c | 2 +- include/net/genetlink.h | 2 +- include/net/netlink.h | 6 -- net/core/rtnetlink.c | 2 +-

[RFC 5/7] net: Add allocation flag to rtnl_unicast()

Signed-off-by: Masashi Honma --- include/linux/rtnetlink.h | 3 ++- net/core/net_namespace.c | 2 +- net/core/rtnetlink.c | 10 ++ net/dcb/dcbnl.c | 2 +- net/decnet/dn_route.c | 3 ++- net/ipv4/devinet.c| 2 +- net/ipv4/ipmr.c

[RFC 0/7] netlink: Add allocation flag to netlink_unicast()

Though netlink_broadcast() has allocation flag which can specify memory allocation type (ex. GFP_KERNEL/GFP_ATOMIC), netlink_unicast() does not have it. This can cause "BUG: sleeping function called from invalid context at" with CONFIG_DEBUG_ATOMIC_SLEEP enabled kernel when calling

[RFC 1/7] netlink: Add allocation flag to netlink_unicast()

Though netlink_broadcast() has allocation flag which can specify memory allocation type (ex. GFP_KERNEL/GFP_ATOMIC), netlink_unicast() does not have it. This can cause "BUG: sleeping function called from invalid context at" with CONFIG_DEBUG_ATOMIC_SLEEP enabled kernel when calling

Re: Problem: BUG_ON hit in ppp_pernet() when re-connect after changing shared key on LAC

On 07/06/2016 08:37 AM, Cong Wang wrote: > On Tue, Jul 5, 2016 at 10:59 AM, Cong Wang wrote: >> On Mon, Jul 4, 2016 at 7:50 PM, Matt Bennett >> wrote: >>> Using printk I have confirmed that ppp_pernet() is called from >>>

Re: DCB Auto turn off when link become up with Intel 82599ES ixgbe driver

On 16-07-05 08:38 AM, Alexander Duyck wrote: > On Tue, Jul 5, 2016 at 8:17 AM, ayuj wrote: >> I'm trying to configure DCB in back-to-back scenario. >> System details >> >> OS :- CentOS 7.2 >> kernel 3.10.0-327.el7.x86_64 >> lldpad:- lldpad v0.9.46 >> dcbtool:- v0.9.46 >>

[GIT] Networking

1) All users of AF_PACKET's fanout feature want a symmetric packet header hash for load balancing purposes, so give it to them. 2) Fix vlan state synchronization in e1000e, from Jarod Wilson. 3) Use correct socket pointer in ip_skb_dst_mtu(), from Shmulik Ladkani. 4) mlx5 bug fixes from

Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac

On Tue, Jul 5, 2016 at 9:37 AM, Arnd Bergmann wrote: > On Monday, July 4, 2016 9:34:35 AM CEST Ray Jui wrote: >> On 7/1/2016 8:42 AM, Arnd Bergmann wrote: >> > On Friday, July 1, 2016 11:17:25 AM CEST Jon Mason wrote: >> >> On Fri, Jul 1, 2016 at 5:46 AM, Arnd Bergmann

Re: [PATCH net-next v2 3/4] net: dsa: Suffix function manipulating device_node with _dn

> That is true for the devices I know about, both in and out of tree, > however, while discussing offline with Vivien it seemed like there was a > potential need for having a x86-based platform which could need that, > Vivien do you think this platform could be in-tree one day (if not already)?

Re: [PATCH net-next 3/9] net: r6040: Utilize skb_put_padto()

Florian Fainelli : [...] > diff --git a/drivers/net/ethernet/rdc/r6040.c > b/drivers/net/ethernet/rdc/r6040.c > index 75776eee36f9..46ed093348da 100644 > --- a/drivers/net/ethernet/rdc/r6040.c > +++ b/drivers/net/ethernet/rdc/r6040.c > @@ -815,6 +815,9 @@ static netdev_tx_t

Re: [PATCH net-next v2 3/4] net: dsa: Suffix function manipulating device_node with _dn

On 07/05/2016 03:36 PM, Andrew Lunn wrote: > On Tue, Jul 05, 2016 at 03:07:12PM -0700, Florian Fainelli wrote: >> Make it clear that these functions take a device_node structure pointer > > Hi Florian > > Didn't we agree that we would only support a single device via a C > coded platform data

Re: [PATCH 2/3] netfilter: Create revision 2 of xt_hashlimit to support higher pps rates

On 06/23/2016 07:16 AM, Pablo Neira Ayuso wrote: > On Wed, Jun 01, 2016 at 08:11:38PM -0400, Vishwanath Pai wrote: >> +static void >> +cfg_copy(struct hashlimit_cfg2 *to, void *from, int revision) >> +{ >> +if (revision == 1) { >> +struct hashlimit_cfg1 *cfg = (struct

Re: [PATCH net-next v2 4/4] net: dsa: Move ports assignment closer to error checking

On Tue, Jul 05, 2016 at 03:07:13PM -0700, Florian Fainelli wrote: > Move the assignment of ports in _dsa_register_switch() closer to where > it is checked, no functional change. Re-order declarations to be > preserve the inverted christmas tree style. > > Signed-off-by: Florian Fainelli

Re: [PATCH net-next v2 3/4] net: dsa: Suffix function manipulating device_node with _dn

On Tue, Jul 05, 2016 at 03:07:12PM -0700, Florian Fainelli wrote: > Make it clear that these functions take a device_node structure pointer Hi Florian Didn't we agree that we would only support a single device via a C coded platform data structure? All the functions you are renaming will never

Re: [PATCH net-next v2 2/4] net: dsa: Make most functions take a dsa_port argument

On Tue, Jul 05, 2016 at 03:07:11PM -0700, Florian Fainelli wrote: > In preparation for allowing platform data, and therefore no valid > device_node pointer, make most DSA functions takes a pointer to a > dsa_port structure whenever possible. While at it, introduce a > dsa_port_is_valid() helper

Re: [PATCH net-next v2 1/4] net: dsa: Pass device pointer to dsa_register_switch

On Tue, Jul 05, 2016 at 03:07:10PM -0700, Florian Fainelli wrote: > In preparation for allowing dsa_register_switch() to be supplied with > device/platform data, pass down a struct device pointer instead of a > struct device_node. > > Signed-off-by: Florian Fainelli

[PATCH RESEND net-next] netvsc: Use the new in-place consumption APIs in the rx path

From: K. Y. Srinivasan Use the new APIs for eliminating a copy on the receive path. These new APIs also help in minimizing the number of memory barriers we end up issuing (in the ringbuffer code) since we can better control when we want to expose the ring state to the host.

[PATCH net-next v2 2/4] net: dsa: Make most functions take a dsa_port argument

In preparation for allowing platform data, and therefore no valid device_node pointer, make most DSA functions takes a pointer to a dsa_port structure whenever possible. While at it, introduce a dsa_port_is_valid() helper function which checks whether port->dn is NULL or not at the moment.

[PATCH net-next v2 3/4] net: dsa: Suffix function manipulating device_node with _dn

Make it clear that these functions take a device_node structure pointer Signed-off-by: Florian Fainelli --- net/dsa/dsa2.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index 3a782ceef716..bdde5d217326

[PATCH net-next v2 0/4] net: dsa: Preparatory patches for pdata

Hi all, This is a resend of the patches that just clean up and prepare net/dsa/dsa2.c to support platform data in the future. Florian Fainelli (4): net: dsa: Pass device pointer to dsa_register_switch net: dsa: Make most functions take a dsa_port argument net: dsa: Suffix function

[PATCH net-next v2 4/4] net: dsa: Move ports assignment closer to error checking

Move the assignment of ports in _dsa_register_switch() closer to where it is checked, no functional change. Re-order declarations to be preserve the inverted christmas tree style. Signed-off-by: Florian Fainelli --- net/dsa/dsa2.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH net-next v2 1/4] net: dsa: Pass device pointer to dsa_register_switch

In preparation for allowing dsa_register_switch() to be supplied with device/platform data, pass down a struct device pointer instead of a struct device_node. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 2 +- drivers/net/dsa/mv88e6xxx/chip.c | 7

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

On 07/05/2016 02:51 PM, Mason wrote: >>> Therefore, loss of context cannot possibly explain the >>> warning I am seeing. >> >> No, but if you go all the way down to trying to suspend and the last >> step is the firmware failing, anything you have suspended needs to be >> unwinded, for your

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

On 05/07/2016 23:22, Florian Fainelli wrote: > On 07/05/2016 01:26 PM, Mason wrote: >> On 05/07/2016 18:20, Florian Fainelli wrote: >>> On 07/05/2016 08:56 AM, Mason wrote: On 05/07/2016 17:28, Florian Fainelli wrote: > nb8800.c does not currently show suspend/resume hooks

Re: [PATCH net-next 00/10] NCSI Support

On Tue, 2016-07-05 at 10:44 -0700, Alexei Starovoitov wrote: >  .../... > > > The design for the patchset is highlighted as below: > > > > > >    * The NCSI interface is abstracted with "struct ncsi_dev". It's > > > registered > > >  when net_device is created, started to work by calling

Re: [PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings

On Tue, 2016-07-05 at 14:15 -0700, Florian Fainelli wrote: > On 07/05/2016 02:07 PM, Philippe Reynes wrote: > > Hi Florian, > > > > On 05/07/16 06:30, Florian Fainelli wrote: > > > Le 04/07/2016 16:03, David Miller a écrit : > > > > From: Philippe Reynes > > > > Date: Sun,  3

Re: [PATCH net-next 22/24] rcu: Suppress sparse warnings for rcu_dereference_raw()

On Tue, Jul 05, 2016 at 02:14:49PM +0100, David Howells wrote: > From: Paul E. McKenney > > Data structures that are used both with and without RCU protection > are difficult to write in a sparse-clean manner. If you mark the > relevant pointers with __rcu, sparse

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

On 07/05/2016 01:26 PM, Mason wrote: > On 05/07/2016 18:20, Florian Fainelli wrote: >> On 07/05/2016 08:56 AM, Mason wrote: >>> On 05/07/2016 17:28, Florian Fainelli wrote: >>> nb8800.c does not currently show suspend/resume hooks implemented, are you positive that when you suspend, you

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

Veli-Matti Lintu wrote: >2016-06-30 14:15 GMT+03:00 Veli-Matti Lintu : >> 2016-06-29 18:59 GMT+03:00 Jay Vosburgh : >>> Veli-Matti Lintu wrote: > >>> I tried this locally,

Re: [PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings

On 07/05/2016 02:07 PM, Philippe Reynes wrote: > Hi Florian, > > On 05/07/16 06:30, Florian Fainelli wrote: >> Le 04/07/2016 16:03, David Miller a écrit : >>> From: Philippe Reynes >>> Date: Sun, 3 Jul 2016 17:33:57 +0200 >>> There are two generics functions

Re: [PATCH net] ipv6: Fix mem leak in rt6i_pcpu

From: Martin KaFai Lau Date: Tue, 5 Jul 2016 12:10:23 -0700 > It was first reported and reproduced by Petr (thanks!) in > https://bugzilla.kernel.org/show_bug.cgi?id=119581 > > free_percpu(rt->rt6i_pcpu) used to always happen in ip6_dst_destroy(). > > However, after fixing a

Re: [PATCH] net: fix decnet rtnexthop parsing

From: Vegard Nossum Date: Tue, 5 Jul 2016 21:12:53 +0200 > dn_fib_count_nhs() could enter an infinite loop if nhp->rtnh_len == 0 > (i.e. if userspace passes a malformed netlink message). > > Let's use the helpers from net/nexthop.h which take care of all this > stuff.

Re: [PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings

Hi Florian, On 05/07/16 06:30, Florian Fainelli wrote: Le 04/07/2016 16:03, David Miller a écrit : From: Philippe Reynes Date: Sun, 3 Jul 2016 17:33:57 +0200 There are two generics functions phy_ethtool_{get|set}_link_ksettings, so we can use them instead of defining the

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

2016-07-05 17:01 GMT+03:00 Veli-Matti Lintu : > 2016-06-30 14:15 GMT+03:00 Veli-Matti Lintu : >> 2016-06-29 18:59 GMT+03:00 Jay Vosburgh : >>> Veli-Matti Lintu wrote: > >>> I

Re: [iproute PATCH 0/2] Netns performance improvements

Hi Eric, Thanks for your quick and insightful reply rightfully pointing out the lack of rationale behind this change. So let me try to catch up: On Tue, Jul 05, 2016 at 09:44:00AM -0500, Eric W. Biederman wrote: > Phil Sutter writes: > > > Stress-testing OpenStack Neutron revealed

Re: Problem: BUG_ON hit in ppp_pernet() when re-connect after changing shared key on LAC

On Tue, Jul 5, 2016 at 10:59 AM, Cong Wang wrote: > On Mon, Jul 4, 2016 at 7:50 PM, Matt Bennett > wrote: >> Using printk I have confirmed that ppp_pernet() is called from >> ppp_connect_channel() when the BUG occurs (i.e. pch->chan_net

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

On 05/07/2016 18:20, Florian Fainelli wrote: > On 07/05/2016 08:56 AM, Mason wrote: >> On 05/07/2016 17:28, Florian Fainelli wrote: >> >>> nb8800.c does not currently show suspend/resume hooks implemented, are >>> you positive that when you suspend, you properly tear down all HW, stop >>> transmit

Re: [PATCH iptables 3/3] libxt_hashlimit: iptables-restore does not work as expected with xt_hashlimit

On 06/25/2016 05:39 AM, Pablo Neira Ayuso wrote: > I see, but I'm not convinced about this /proc rename feature. > > I think the main point of this, as well as other entries in bugzilla > related to this, is ability to update an existing hashlimit state. > > So, I'm not proposing to rename

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

Veli-Matti Lintu wrote: [...] >I have understood that only miimon is available with 802.3ad: > >bonding.txt: > >802.3ad: >... >Finally, the 802.3ad mode mandates the use of the MII monitor, >therefore, the ARP monitor is not available in this mode. >

Re: [PATCH net-next 06/24] rxrpc: Dup the main conn list for the proc interface

David Miller wrote: > Wouldn't it be better to just code the proc stuff to walk whatever > table the rest of the stack uses to hold all of the connections > as TCP et al. do? I should also mention that this is an intermediate step. Splitting out the procfs list makes it

Re: [PATCH net-next 05/24] rxrpc: Provide more refcount helper functions

David Miller wrote: > I don't see anything in this patch dealing with refcount helper functions. I'm amending the patch description to: rxrpc: Provide queuing helper functions Provide queueing helper functions so that the queueing of local and connection

Re: [PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets

Sergei Shtylyov wrote: > > When commit 0d12f8a4027d021c9cc942f09f38d28288020c5d moved to keeping the > >scripts/checkpatch.pl now enforces the common commit citing style as for > the Fixes: tag and the patch description, you need to specify the summary

Re: [PATCH net-next 06/24] rxrpc: Dup the main conn list for the proc interface

David Miller wrote: > Wouldn't it be better to just code the proc stuff to walk whatever > table the rest of the stack uses to hold all of the connections > as TCP et al. do? There won't be "a table" that the rest of the stack uses. There will be more than one. Service

Re: [PATCH net-next 05/24] rxrpc: Provide more refcount helper functions

David Miller wrote: > I don't see anything in this patch dealing with refcount helper functions. Good point. I split that part out and you took it already. Will amend. David

Re: [PATCH] cxgb4: update latest firmware version supported

From: Ganesh Goudar Date: Tue, 5 Jul 2016 18:07:24 +0530 > Change t4fw_version.h to update latest firmware version number > > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH] net/mlx5: Avoid setting unused var when modifying vport node GUID

From: Or Gerlitz Date: Tue, 5 Jul 2016 12:17:12 +0300 > GCC complains on unused-but-set-variable, clean this up. > > Fixes: 23898c763f4a ('net/mlx5: E-Switch, Modify node guid on vf set MAC') > Signed-off-by: Or Gerlitz Applied.

[PATCH] net: fix decnet rtnexthop parsing

dn_fib_count_nhs() could enter an infinite loop if nhp->rtnh_len == 0 (i.e. if userspace passes a malformed netlink message). Let's use the helpers from net/nexthop.h which take care of all this stuff. We can do exactly the same as e.g. fib_count_nexthops() and fib_get_nhs() from

Re: [PATCH] xfrm: fix crash in XFRM_MSG_GETSA netlink handler

From: Vegard Nossum Date: Tue, 5 Jul 2016 10:18:08 +0200 > If we hit any of the error conditions inside xfrm_dump_sa(), then > xfrm_state_walk_init() never gets called. However, we still call > xfrm_state_walk_done() from xfrm_dump_sa_done(), which will crash > because

Re: [PATCH net] bonding: fix enslavement slave link notifications

From: Saeed Mahameed Date: Tue, 5 Jul 2016 12:09:47 +0300 > From: Aviv Heller > > Currently, link notifications are not sent by > bond_set_slave_link_state() upon enslavement if > the slave is enslaved when up. > > This happens because slave->link

[PATCH net] ipv6: Fix mem leak in rt6i_pcpu

It was first reported and reproduced by Petr (thanks!) in https://bugzilla.kernel.org/show_bug.cgi?id=119581 free_percpu(rt->rt6i_pcpu) used to always happen in ip6_dst_destroy(). However, after fixing a deadlock bug in commit 9c7370a166b4 ("ipv6: Fix a potential deadlock when creating pcpu

[RFC PATCH 0/2] strp: Stream parser for messages

This patch set introduces a utility for parsing application layer protocol messages in a TCP stream. This is a generalization of the mechanism implemented of Kernel Connection Multiplexor. This patch set adapts KCM to use the strparser. We expect that kTLS can use this mechanism also. RDS would

[RFC PATCH 1/2] strparser: Stream parser for messages

This patch introduces a utility for parsing application layer protocol messages in a TCP stream. This is a generalization of the mechanism implemented of Kernel Connection Multiplexor. The API includes a context structure, a set of callbacks, utility functions, and a data ready function. A

[RFC PATCH 2/2] kcm: Use stream parser

Adapt KCM to use the stream parser. This mostly involves removing the RX handling and setting up the strparser using the interface. Signed-off-by: Tom Herbert --- include/net/kcm.h | 36 + net/kcm/Kconfig | 1 + net/kcm/kcmproc.c | 41 +++-- net/kcm/kcmsock.c |

Re: [RESEND/BUG PATCH v3] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0

On 07/05/2016 01:45 PM, Sergei Shtylyov wrote: The patch has been merged to 4.7-rc6, why resend it? Sorry, I must have missed the merge. Thanks,

Re: [net-next PATCH] net: tracepoint napi:napi_poll add work and budget

From: Jesper Dangaard Brouer Date: Tue, 05 Jul 2016 19:35:27 +0200 > Can this patch go thought the net-next tree? Sure... when it actually compiles. If you're changing a fundamental signature like this, it is in your best interest to do an allmodconfig build... before I do.

Re: [RESEND/BUG PATCH v3] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0

The patch has been merged to 4.7-rc6, why resend it?

Re: [PATCH -next] connector: make cn_proc explicitly non-modular

From: Paul Gortmaker Date: Mon, 4 Jul 2016 17:50:58 -0400 > The Kconfig controlling build of this code is currently: > > drivers/connector/Kconfig:config PROC_EVENTS > drivers/connector/Kconfig: bool "Report process events to userspace" > > ...meaning that it

Re: [PATCH v2 net-next 1/1] net sched actions: mirred add support for setting Dst MAC address

On Tue, Jul 5, 2016 at 4:04 AM, Jamal Hadi Salim wrote: > Second arguement usability, from: > > sudo $TC filter add dev $ETH parent : pref 11 protocol ip u32 \ > match ip protocol 1 0xff flowid 1:2 \ > action pedit munge offset -14 u8 set 0x02 \ > munge offset -13

Re: Problem: BUG_ON hit in ppp_pernet() when re-connect after changing shared key on LAC

On Mon, Jul 4, 2016 at 7:50 PM, Matt Bennett wrote: > Using printk I have confirmed that ppp_pernet() is called from > ppp_connect_channel() when the BUG occurs (i.e. pch->chan_net is NULL). > > This behavior appears to have been introduced in commit 1f461dc

Re: [PATCH net-next 01/24] rxrpc: Fix processing of authenticated/encrypted jumbo packets

Hello. On 07/05/2016 04:12 PM, David Howells wrote: When a jumbo packet is being split up and processed, the crypto checksum for each split-out packet is in the jumbo header and needs placing in the reconstructed packet header. When commit 0d12f8a4027d021c9cc942f09f38d28288020c5d moved to

[net-next PATCH] net: tracepoint napi:napi_poll add work and budget

An important information for the napi_poll tracepoint is knowing the work done (packets processed) by the napi_poll() call. Add both the work done and budget, as they are related. Signed-off-by: Jesper Dangaard Brouer --- Can this patch go thought the net-next tree?

Re: [PATCH net-next 00/10] NCSI Support

On Mon, Jul 04, 2016 at 01:03:06AM +0300, Or Gerlitz wrote: > On Sun, Jul 3, 2016 at 8:32 AM, Gavin Shan wrote: > > This series rebases on David's linux-net git repo ("master" branch). It's > > to support NCSI stack on net/farady/ftgmac100.c > > > > The following figure

Re: [PATCH net] r8152: fix runtime function for RTL8152

From: Hayes Wang Date: Tue, 5 Jul 2016 16:11:46 +0800 > The RTL8152 doesn't have U1U2 and U2P3 features, so use different > runtime functions for RTL812 and RTL8153 by adding autosuspend_en() > to rtl_ops. > > Signed-off-by: Hayes Wang Applied,

Re: dccp: potential deadlock in dccp_v4_ctl_send_reset

On Tue, 2016-07-05 at 10:17 -0700, Cong Wang wrote: > On Tue, Jul 5, 2016 at 4:59 AM, Dmitry Vyukov wrote: > > other info that might help us debug this: > > Possible unsafe locking scenario: > > > >CPU0 > > > > lock(slock-AF_INET); > > > >

Re: [PATCH -next v2] net: hns: fix return value check in hns_dsaf_get_cfg()

From: weiyj...@163.com Date: Tue, 5 Jul 2016 07:56:52 + > From: Wei Yongjun > > In case of error, function devm_ioremap_resource() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > >

Re: [PATCH net-next 06/24] rxrpc: Dup the main conn list for the proc interface

From: David Howells Date: Tue, 05 Jul 2016 14:12:54 +0100 > The main connection list is used for two independent purposes: primarily it > is used to find connections to reap and secondarily it is used to list > connections in procfs. > > Split the procfs list out from the

Re: dccp: potential deadlock in dccp_v4_ctl_send_reset

On Tue, Jul 5, 2016 at 4:59 AM, Dmitry Vyukov wrote: > other info that might help us debug this: > Possible unsafe locking scenario: > >CPU0 > > lock(slock-AF_INET); > > lock(slock-AF_INET); > > *** DEADLOCK *** > > 1 lock held by

Re: [PATCH net-next 05/24] rxrpc: Provide more refcount helper functions

From: David Howells Date: Tue, 05 Jul 2016 14:12:47 +0100 > Provide refcount helper functions for connections so that the code doesn't > touch conn->usage directly. > > Also provide queueing helper functions so that the queueing of local and > connection objects can be

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

On 07/05/2016 08:56 AM, Mason wrote: > On 05/07/2016 17:28, Florian Fainelli wrote: > >> nb8800.c does not currently show suspend/resume hooks implemented, are >> you positive that when you suspend, you properly tear down all HW, stop >> transmit queues, etc. and do the opposite upon resumption?

Re: [patch net-next 00/16] mlxsw: Implement IPV4 unicast routing

From: Jiri Pirko Date: Tue, 5 Jul 2016 11:27:36 +0200 > This patchset enables IPv4 unicast routing in the Mellanox Spectrum ASIC > switch driver. This builds upon the work that was done by a couple of > previous patchsets. > > Patches 1,2,6 add a couple of dependencies

Re: ethtool needs a new maintainer

On Mon, Jul 04, 2016 at 07:18:48PM +0200, Ben Hutchings wrote: > On Mon, 2016-06-27 at 09:51 -0400, John W. Linville wrote: > > On Sun, Jun 26, 2016 at 06:11:41PM +0200, Ben Hutchings wrote: > > > I've become steadily less enthusiastic and less responsive as a > > > maintainer over the past year

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

On 05/07/2016 17:28, Florian Fainelli wrote: > nb8800.c does not currently show suspend/resume hooks implemented, are > you positive that when you suspend, you properly tear down all HW, stop > transmit queues, etc. and do the opposite upon resumption? I am currently testing the error path for

[PATCH] Add support for configuring Infiniband GUIDs

Add two NLA's that allow configuration of Infiniband node or port GUIDs by referencing the IPoIB net device set over then physical function. The format to be used is as follows: ip link set dev ib0 vf 0 node_guid 00:02:c9:03:00:21:6e:70 ip link set dev ib0 vf 0 port_guid 00:02:c9:03:00:21:6e:78

Re: DCB Auto turn off when link become up with Intel 82599ES ixgbe driver

On Tue, Jul 5, 2016 at 8:17 AM, ayuj wrote: > I'm trying to configure DCB in back-to-back scenario. > System details > > OS :- CentOS 7.2 > kernel 3.10.0-327.el7.x86_64 > lldpad:- lldpad v0.9.46 > dcbtool:- v0.9.46 > ixgbe :- ixgbe-4.3.15 > > steps followed:- > > # modporbe

ethtool TODO list - additional info

Hi ! Some days ago, Jiri Pirko was talking about some next steps to implement for ethtool. I haven't seen any follow up since ethtool's maintainer change. Can we have additional details about these ? - libethtool - API - generic netlink - sub commands syntax - TODO/bugzilla On Mon, Jul 4,

Backport bpf: try harder on clones when writing into skb? [Commit: 3697649ff29e0f647565eed04b27a7779c646a22]

Does it make sense to backport 3697649ff29e0f647565eed04b27a7779c646a22 from 4.6 to the longterm (4.4) release? I can trivially recreate the issue represented by 3697649ff29e0f647565eed04b27a7779c646a22 by attaching a eBPF filter that clones an ingress ICMP packet, and then tries to set the

[RESEND/BUG PATCH v3] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0

By default, mdiobus_alloc() sets the PHYs to polling mode, but a pointer size memcpy means that a couple IRQs end up being overwritten with a value of 0. This means that PHY_POLL is disabled and results in unpredictable behavior depending on the PHY's location on the MDIO bus. Remove that memcpy

Re: WARNING: CPU: 0 PID: 0 at net/ipv4/af_inet.c:155 inet_sock_destruct+0x1c4/0x1dc

Le 05/07/2016 07:50, Mason a écrit : > On 05/07/2016 15:33, Mason wrote: > >> I was testing suspend/resume sequences where the suspend operation >> fails and returns without having suspended the platform. >> >> # echo mem > /sys/power/state >> [ 90.322264] PM: Syncing filesystems ... done. >> [

  1   2   3   >