Re: PROBLEM: MTU of ipsec tunnel drops continuously until traffic stops

2016-07-18 Thread Matt Bennett
On 07/05/2016 03:55 PM, Matt Bennett wrote: > On 07/04/2016 11:12 PM, Steffen Klassert wrote: >> On Mon, Jul 04, 2016 at 03:52:50AM +, Matt Bennett wrote: >>> *Resending as plain text so the mailing list accepts it.. Sorry Steffen and >>> Herbert* >>> >>> ​Hi, >>> >>> During long run testing

Re: [PATCH] net/sched/sch_htb: clamp xstats tokens to fit into 32-bit int

2016-07-18 Thread David Miller
From: Konstantin Khlebnikov Date: Sat, 16 Jul 2016 17:08:56 +0300 > In kernel HTB keeps tokens in signed 64-bit in nanoseconds. In netlink > protocol these values are converted into pshed ticks (64ns for now) and > truncated to 32-bit. In struct tc_htb_xstats fields

[Patch-V2 2/3] chcr: Support for Chelsio's Crypto Hardware

2016-07-18 Thread Yeshaswi M R Gowda
The Chelsio's Crypto Hardware can perform the following operations: SHA1, SHA224, SHA256, SHA384 and SHA512, HMAC(SHA1), HMAC(SHA224), HMAC(SHA256), HMAC(SHA384), HAMC(SHA512), AES-128-CBC, AES-192-CBC, AES-256-CBC, AES-128-XTS, AES-256-XTS This patch implements the driver for above mentioned

[Patch-V2 1/3] cxgb4: Add Chelsio LLD support Chelsio Crypto ULD

2016-07-18 Thread Yeshaswi M R Gowda
The Chelsio crypto driver is an Upper Layer Driver (ULD), making use of the Chelsio Lower Layer Driver (LLD - cxgb4). The LLD facilitates the basic infrastructure services of the ULD. These services include queue allocation, deallocation and registration with LLD. The queues are used for sending

[Patch-V2 0/3] crypto/chcr: Add Chelsio Crypto Driver

2016-07-18 Thread Yeshaswi M R Gowda
Hi Herbert, This patch series contains 3 patches that add support for Chelsio's Crypto Hardware. The patch series has been created against Herbert Xu's tree (crypto-2.6). It includes patches for Chelsio Low Level Driver(cxgb4) and adds the new crypto Upper Layer Driver(chcr) under a new

[Patch-V2 3/3] crypto: Added Chelsio Menu to the Kconfig file

2016-07-18 Thread Yeshaswi M R Gowda
Adds the config entry for the Chelsio Crypto Driver, Makefile changes for the same. Signed-off-by: Yeshaswi M R Gowda --- drivers/crypto/Kconfig |2 ++ drivers/crypto/Makefile |1 + 2 files changed, 3 insertions(+) diff --git a/drivers/crypto/Kconfig

RE: [PATCH/RFC] packet: fix sock_tx_timestamp() in packet_snd() via sendto syscall

2016-07-18 Thread Yoshihiro Shimoda
Hi, > From: Willem de Bruijn > Sent: Saturday, July 16, 2016 12:31 AM > > On Thu, Jul 14, 2016 at 10:49 PM, Yoshihiro Shimoda > wrote: > > Since the sendto syscall doesn't have msg_control buffer, > > the sock_tx_timestamp() in packet_snd() cannot work

[PATCH v3] packet: fix second argument of sock_tx_timestamp()

2016-07-18 Thread Yoshihiro Shimoda
This patch fixes an issue that a syscall (e.g. sendto syscall) cannot work correctly. Since the sendto syscall doesn't have msg_control buffer, the sock_tx_timestamp() in packet_snd() cannot work correctly because the socks.tsflags is set to 0. So, this patch sets the socks.tsflags to

Re: [PATCH V2] Add flow control to the portmapper

2016-07-18 Thread Leon Romanovsky
On Mon, Jul 18, 2016 at 02:23:30PM -0500, Shiraz Saleem wrote: > From: Mustafa Ismail > > During connection establishment with a large number of connections, > it is possible that the connection requests might fail. Adding flow > control prevents this failure. Change

RE: [PATCH] packet: fix second argument of sock_tx_timestamp()

2016-07-18 Thread Yoshihiro Shimoda
> -Original Message- > From: Yoshihiro Shimoda > Sent: Tuesday, July 19, 2016 2:15 PM > > This patch fixes an issue that a syscall (e.g. sendto syscall) cannot > work correctly. Since the sendto syscall doesn't have msg_control buffer, > the sock_tx_timestamp() in packet_snd() cannot work

[PATCH] packet: fix second argument of sock_tx_timestamp()

2016-07-18 Thread Yoshihiro Shimoda
This patch fixes an issue that a syscall (e.g. sendto syscall) cannot work correctly. Since the sendto syscall doesn't have msg_control buffer, the sock_tx_timestamp() in packet_snd() cannot work correctly because the socks.tsflags is set to 0. So, this patch sets the socks.tsflags to

Re: [PATCH net-next] macvtap: correctly free skb during socket destruction

2016-07-18 Thread David Miller
From: Jason Wang Date: Tue, 19 Jul 2016 11:02:59 +0800 > We should use kfree_skb() instead of kfree() to free an skb. > > Fixes: 362899b8725b ("macvtap: switch to use skb array") > Reported-by: Dan Carpenter > Signed-off-by: Jason Wang

Re: [RFC PATCH 00/30] Kernel NET policy

2016-07-18 Thread David Miller
From: "Liang, Kan" Date: Tue, 19 Jul 2016 01:49:41 + > Yes, rtnl will bring some overheads. But the configuration is one > time thing for application or socket. It only happens on receiving > first packet. Thanks for destroying our connection rates. This kind of

Re: [PATCH net-next v3 10/12] net: dsa: support switchdev ageing time attr

2016-07-18 Thread Florian Fainelli
Le 18/07/2016 à 20:24, Andrew Lunn a écrit : > On Mon, Jul 18, 2016 at 08:45:38PM -0400, Vivien Didelot wrote: >> Add a new function for DSA drivers to handle the switchdev >> SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute. >> >> The ageing time is passed as milliseconds. >> >> Also because we can

Re: [PATCH net-next v3 10/12] net: dsa: support switchdev ageing time attr

2016-07-18 Thread Andrew Lunn
On Mon, Jul 18, 2016 at 08:45:38PM -0400, Vivien Didelot wrote: > Add a new function for DSA drivers to handle the switchdev > SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute. > > The ageing time is passed as milliseconds. > > Also because we can have multiple logical bridges on top of a physical

Re: [patch 1/1] kernel/trace/bpf_trace.c: work around gcc-4.4.4 anon union initialization bug

2016-07-18 Thread Fengguang Wu
On Mon, Jul 18, 2016 at 07:38:27PM -0700, Alexei Starovoitov wrote: On Tue, Jul 19, 2016 at 08:38:02AM +0800, Fengguang Wu wrote: Hi Alexei, On Mon, Jul 18, 2016 at 05:33:07PM -0700, Alexei Starovoitov wrote: >On Mon, Jul 18, 2016 at 03:50:58PM -0700, a...@linux-foundation.org wrote: >>From:

[PATCH net-next] macvtap: correctly free skb during socket destruction

2016-07-18 Thread Jason Wang
We should use kfree_skb() instead of kfree() to free an skb. Fixes: 362899b8725b ("macvtap: switch to use skb array") Reported-by: Dan Carpenter Signed-off-by: Jason Wang --- drivers/net/macvtap.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH net-next v3 03/12] net: dsa: mv88e6xxx: extract device mapping

2016-07-18 Thread Andrew Lunn
On Mon, Jul 18, 2016 at 08:45:31PM -0400, Vivien Didelot wrote: > The Device Mapping register is an indirect table access. > > Provide helpers to access this table and explicit the checking of the > new DSA_RTABLE_NONE routing table value. > > Signed-off-by: Vivien Didelot

Re: [PATCH v8 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-18 Thread Alexei Starovoitov
On Mon, Jul 18, 2016 at 03:07:01PM +0200, Tom Herbert wrote: > On Mon, Jul 18, 2016 at 2:48 PM, Thomas Graf wrote: > > On 07/18/16 at 01:39pm, Tom Herbert wrote: > >> On Mon, Jul 18, 2016 at 11:10 AM, Thomas Graf wrote: > >> > I agree with that but I would like to

Re: [patch 1/1] kernel/trace/bpf_trace.c: work around gcc-4.4.4 anon union initialization bug

2016-07-18 Thread Alexei Starovoitov
On Tue, Jul 19, 2016 at 08:38:02AM +0800, Fengguang Wu wrote: > Hi Alexei, > > On Mon, Jul 18, 2016 at 05:33:07PM -0700, Alexei Starovoitov wrote: > >On Mon, Jul 18, 2016 at 03:50:58PM -0700, a...@linux-foundation.org wrote: > >>From: Andrew Morton > >>Subject:

[PATCH net-next v3 10/10] net/faraday: Mask PHY interrupt with NCSI mode

2016-07-18 Thread Gavin Shan
Bogus PHY interrupts are observed. This masks the PHY interrupt when the interface works in NCSI mode as there is no attached PHY under the circumstance. Signed-off-by: Gavin Shan Acked-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c |

[PATCH net-next v3 01/10] net/ncsi: Resource management

2016-07-18 Thread Gavin Shan
NCSI spec (DSP0222) defines several objects: package, channel, mode, filter, version and statistics etc. This introduces the data structs to represent those objects and implement functions to manage them. Also, this introduces CONFIG_NET_NCSI for the newly implemented NCSI stack. * The user

[PATCH net-next v3 03/10] net/ncsi: NCSI response packet handler

2016-07-18 Thread Gavin Shan
The NCSI response packets are sent to MC (Management Controller) from the remote end. They are responses of NCSI command packets for multiple purposes: completion status of NCSI command packets, return NCSI channel's capability or configuration etc. This defines struct to represent NCSI response

[PATCH net-next v3 08/10] net/faraday: Support NCSI mode

2016-07-18 Thread Gavin Shan
This makes ftgmac100 driver support NCSI mode. The NCSI is enabled on the interface if property "use-nc-si" or "use-ncsi" is found from the device node in device tree. * No PHY device is used when NCSI mode is enabled. * The NCSI device (struct ncsi_dev) is created when probing the

[PATCH net-next v3 05/10] net/ncsi: NCSI AEN packet handler

2016-07-18 Thread Gavin Shan
This introduces NCSI AEN packet handlers that result in (A) the currently active channel is reconfigured; (B) Currently active channel is deconfigured and disabled, another channel is chosen as active one and configured. Case (B) won't happen if hardware arbitration has been enabled, the channel

[PATCH net-next v3 02/10] net/ncsi: NCSI command packet handler

2016-07-18 Thread Gavin Shan
The NCSI command packets are sent from MC (Management Controller) to remote end. They are used for multiple purposes: probe existing NCSI package/channel, retrieve NCSI channel's capability, configure NCSI channel etc. This defines struct to represent NCSI command packets and introduces function

[PATCH net-next v3 07/10] net/faraday: Read MAC address from chip

2016-07-18 Thread Gavin Shan
The device is assigned with random MAC address. It isn't reasonable. An valid MAC address might have been provided by (uboot) firmware by device-tree or in chip. It's reasonable to use it to maintain consistency. This uses the MAC address from device-tree or that in the chip if it's valid.

[PATCH net-next v3 09/10] net/faraday: Match driver according to compatible property

2016-07-18 Thread Gavin Shan
This matches the driver with devices compatible with "faraday,ftgmac100" declared in the device tree. Originally, device's name from device tree for it. Signed-off-by: Gavin Shan Acked-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c | 16

[PATCH net-next v3 00/10] NCSI Support

2016-07-18 Thread Gavin Shan
This series rebases on David's linux-net git repo ("master" branch). It's to support NCSI stack on drivers/net/ethernet/faraday/ftgmac100.c. The implementation is based on NCSI spec (version: 1.1.0): https://www.dmtf.org/sites/default/files/standards/documents/DSP0222_1.1.0.pdf As the following

[PATCH net-next v3 04/10] net/ncsi: Package and channel management

2016-07-18 Thread Gavin Shan
This manages NCSI packages and channels: * The available packages and channels are enumerated in the first time of calling ncsi_start_dev(). The channels' capabilities are probed in the meanwhile. The NCSI network topology won't change until the NCSI device is destroyed. * There in a

[PATCH net-next v3 06/10] net/faraday: Helper functions to create or destroy MDIO interface

2016-07-18 Thread Gavin Shan
This introduces two helper functions to create or destroy MDIO interface. No logical changes introduced except the proper MDIO names are given when having more than one MDIO bus. Signed-off-by: Gavin Shan Acked-by: Joel Stanley ---

RE: [RFC PATCH 00/30] Kernel NET policy

2016-07-18 Thread Liang, Kan
> > > Also of course it would be fundamentally less efficient than kernel > > code doing that, just because of the additional context switches > > needed. > > Synchronizing or configuring any kind of queues already requires rtnl_mutex. > I didn't test it but acquiring rtnl mutex in

Re: [PATCH net-next v2 02/10] net/ncsi: NCSI command packet handler

2016-07-18 Thread Gavin Shan
On Mon, Jul 18, 2016 at 10:15:21AM +1000, Gavin Shan wrote: >On Fri, Jul 15, 2016 at 10:08:23PM +0800, kbuild test robot wrote: >>[auto build test ERROR on net-next/master] >> >>url: >>https://github.com/0day-ci/linux/commits/Gavin-Shan/NCSI-Support/20160715-190549 >>config: i386-allmodconfig

[PATCH net-next v3 12/12] net: dsa: mv88e6xxx: add support for DSA ageing time

2016-07-18 Thread Vivien Didelot
Implement the DSA driver function to configure the bridge ageing time. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c

[PATCH net-next v3 09/12] net: dsa: mv88e6xxx: add cap for IRL

2016-07-18 Thread Vivien Didelot
Add capability flags to describe the presence of Ingress Rate Limit unit registers and an helper function to clear it. In the meantime, fix a few harmless issues: - 6185 and 6095 don't have such registers (reserved) - the previous code didn't wait for the IRL operation to complete

[PATCH net-next v3 10/12] net: dsa: support switchdev ageing time attr

2016-07-18 Thread Vivien Didelot
Add a new function for DSA drivers to handle the switchdev SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute. The ageing time is passed as milliseconds. Also because we can have multiple logical bridges on top of a physical switch and ageing time are switch-wide, call the driver function with the

[PATCH net-next v3 11/12] net: dsa: mv88e6xxx: add G1 helper for ageing time

2016-07-18 Thread Vivien Didelot
All Marvell switch chips from (88E6060 to 88E6390) have a ATU Control register containing bits 11:4 to configure an ATU Age Time quotient. However the coefficient used to calculate the ATU Age Time vary with the models. E.g. 88E6060, 88E6352 and 88E6390 use respectively 16, 15 and 3.75 seconds.

[PATCH net-next v3 04/12] net: dsa: mv88e6xxx: extract trunk mapping

2016-07-18 Thread Vivien Didelot
The Trunk Mask and Trunk Mapping registers are two Global 2 indirect accesses to trunking configuration. Add helpers for these tables and simplify the Global 2 setup. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn ---

[PATCH net-next v3 06/12] net: dsa: mv88e6xxx: rework Switch MAC setter

2016-07-18 Thread Vivien Didelot
Switches such as 88E6185 as 3 Switch MAC registers in Global 1. Newer chips such as 88E6352 have freed these registers in favor of an indirect access in a Switch MAC/WoL/WoF register in Global 2. Explicit this difference with G1 and G2 helpers and flags. Also, note that this indirect access is a

[PATCH net-next v3 02/12] net: dsa: mv88e6xxx: split setup of Global 1 and 2

2016-07-18 Thread Vivien Didelot
Separate the setup of Global 1 and Global 2 internal SMI devices and add a flag to describe the presence of this second registers set. Also rearrange the G1 setup in the registers order. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn

[PATCH net-next v3 01/12] net: dsa: mv88e6xxx: remove basic function flags

2016-07-18 Thread Vivien Didelot
All 88E6xxx Marvell switches (even the old not supported yet 88E6060) have at least an ATU, per-port STP states and VLAN map, to run basic switch functions such as Spanning Tree and port based VLANs. Get rid of the related MV88E6XXX_FLAG_{ATU,PORTSTATE,VLANTABLE} flags, as they are defaults to

[PATCH net-next v3 08/12] net: dsa: mv88e6xxx: add cap for Priority Override

2016-07-18 Thread Vivien Didelot
Add flags and helpers to describe the presence of Priority Override Table (POT) related registers and simplify the setup of Global 2. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 36

[PATCH net-next v3 07/12] net: dsa: mv88e6xxx: add cap for PVT

2016-07-18 Thread Vivien Didelot
Add flags to describe the presence of Cross-chip Port VLAN Table (PVT) related registers and simplify the setup of Global 2. Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 16

[PATCH net-next v3 00/12] net: dsa: mv88e6xxx: Global2 cleanup and STP

2016-07-18 Thread Vivien Didelot
The Marvell switches registers are organized in distinct internal SMI devices, such as PHY, Port, Global 1 or Global 2 registers sets. Since not all chips support every registers sets or have slightly differences in them (such as old 88E6060 or new 88E6390 likely to be supported soon), make the

[PATCH net-next v3 03/12] net: dsa: mv88e6xxx: extract device mapping

2016-07-18 Thread Vivien Didelot
The Device Mapping register is an indirect table access. Provide helpers to access this table and explicit the checking of the new DSA_RTABLE_NONE routing table value. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 75

[PATCH net-next v3 05/12] net: dsa: mv88e6xxx: add cap for MGMT Enables bits

2016-07-18 Thread Vivien Didelot
Some switches provide a Rsvd2CPU mechanism used to choose which of the 16 reserved multicast destination addresses matching 01:80:c2:00:00:0x should be considered as MGMT and thus forwarded to the CPU port. Other switches extend this mechanism to also configure as MGMT the additional 16 reserved

Re: [patch 1/1] kernel/trace/bpf_trace.c: work around gcc-4.4.4 anon union initialization bug

2016-07-18 Thread Fengguang Wu
Hi Alexei, On Mon, Jul 18, 2016 at 05:33:07PM -0700, Alexei Starovoitov wrote: On Mon, Jul 18, 2016 at 03:50:58PM -0700, a...@linux-foundation.org wrote: From: Andrew Morton Subject: kernel/trace/bpf_trace.c: work around gcc-4.4.4 anon union initialization bug

Re: [PATCH iproute2 -master] bpf: also check elf for official e_machine value

2016-07-18 Thread Alexei Starovoitov
On Tue, Jul 19, 2016 at 01:09:52AM +0200, Daniel Borkmann wrote: > Use the official BPF ELF e_machine value that was assigned recently [1] > and will be propagated to glibc, libelf et al. LLVM will switch to it > in 3.9 release, therefore we need to prepare tc to check for EM_ELF as > well, older

Re: [patch 1/1] kernel/trace/bpf_trace.c: work around gcc-4.4.4 anon union initialization bug

2016-07-18 Thread Alexei Starovoitov
On Mon, Jul 18, 2016 at 03:50:58PM -0700, a...@linux-foundation.org wrote: > From: Andrew Morton > Subject: kernel/trace/bpf_trace.c: work around gcc-4.4.4 anon union > initialization bug > > kernel/trace/bpf_trace.c: In function 'bpf_event_output': >

[PATCH iproute2 -master] bpf: also check elf for official e_machine value

2016-07-18 Thread Daniel Borkmann
Use the official BPF ELF e_machine value that was assigned recently [1] and will be propagated to glibc, libelf et al. LLVM will switch to it in 3.9 release, therefore we need to prepare tc to check for EM_ELF as well, older version still have the EM_NONE. [1]

Re: [PATCH resend] virtio-net: Remove more stack DMA

2016-07-18 Thread Michael S. Tsirkin
On Mon, Jul 18, 2016 at 03:34:49PM -0700, Andy Lutomirski wrote: > VLAN and MQ control was doing DMA from the stack. Fix it. > > Cc: Michael S. Tsirkin > Cc: "netdev@vger.kernel.org" > Signed-off-by: Andy Lutomirski Acked-by: Michael

[patch 1/1] kernel/trace/bpf_trace.c: work around gcc-4.4.4 anon union initialization bug

2016-07-18 Thread akpm
From: Andrew Morton Subject: kernel/trace/bpf_trace.c: work around gcc-4.4.4 anon union initialization bug kernel/trace/bpf_trace.c: In function 'bpf_event_output': kernel/trace/bpf_trace.c:312: error: unknown field 'next' specified in initializer

[PATCH resend] virtio-net: Remove more stack DMA

2016-07-18 Thread Andy Lutomirski
VLAN and MQ control was doing DMA from the stack. Fix it. Cc: Michael S. Tsirkin Cc: "netdev@vger.kernel.org" Signed-off-by: Andy Lutomirski --- I tested VLAN addition and removal with CONFIG_VMAP_STACK=y, CONFIG_DEBUG_SG=y and it got

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

2016-07-18 Thread pravin shelar
On Sun, Jul 17, 2016 at 9:50 PM, Simon Horman wrote: > [CC Jiri Benc for portion regarding GRE] > > Hi Pravin, > > On Fri, Jul 15, 2016 at 02:07:37PM -0700, pravin shelar wrote: >> On Wed, Jul 13, 2016 at 12:31 AM, Simon Horman >> wrote: >>

RE: [E1000-devel] [PATCH 1/1] ixgbevf: avoid checking hang when performing hardware reset

2016-07-18 Thread Skidmore, Donald C
> -Original Message- > From: zyjzyj2...@gmail.com [mailto:zyjzyj2...@gmail.com] > Sent: Monday, July 18, 2016 6:45 AM > To: e1000-de...@lists.sourceforge.net; netdev@vger.kernel.org; Kirsher, > Jeffrey T > Subject: [E1000-devel] [PATCH 1/1] ixgbevf: avoid

Re: [PATCH 2/2] net: ethernet: marvell: pxa168_eth: use phy_ethtool_{get|set}_link_ksettings

2016-07-18 Thread Florian Fainelli
On 07/17/2016 02:30 PM, Philippe Reynes wrote: > There are two generics functions phy_ethtool_{get|set}_link_ksettings, > so we can use them instead of defining the same code in the driver. > > Signed-off-by: Philippe Reynes > --- > - cmd.phy_address = pep->phy_addr; > -

Re: [PATCH 1/2] net: ethernet: marvell: pxa168_eth: use phydev from struct net_device

2016-07-18 Thread Philippe Reynes
Hi, On 18/07/16 12:14, Sergei Shtylyov wrote: Hello. On 7/18/2016 12:30 AM, Philippe Reynes wrote: The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver

Re: [RFC PATCH 00/30] Kernel NET policy

2016-07-18 Thread Hannes Frederic Sowa
Hello, On Mon, Jul 18, 2016, at 21:43, Andi Kleen wrote: > > I wonder if this can be attacked from a different angle. What would be > > missing to add support for this in user space? The first possibility > > that came to my mind is to just multiplex those hints in the kernel. > > "just" is the

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add support for DSA ageing time

2016-07-18 Thread Andrew Lunn
> OK. I think caching per-port (and thus per-bridge) ageing time would do > the trick and keep DSA drivers simple. What about the following patch? Hi Vivien This looks good. I would suggest you do some testing with a printk, and force some topology changes, just to make sure it works how we

Re: [RFC PATCH 00/30] Kernel NET policy

2016-07-18 Thread Daniel Borkmann
On 07/18/2016 08:30 PM, Liang, Kan wrote: On 07/18/2016 08:55 AM, kan.li...@intel.com wrote: [...] On a higher level picture, why for example, a new cgroup in combination with tc shouldn't be the ones resolving these policies on resource usage? The NET policy doesn't support cgroup yet, but

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add support for DSA ageing time

2016-07-18 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > On Mon, Jul 18, 2016 at 03:59:38PM -0400, Vivien Didelot wrote: >> Andrew Lunn writes: >> >> >> Nope, the bridge ageing time is not per-port, even though switchdev ops >> >> are per-port by design. This is a switch-wide

RE: [RFC PATCH 00/30] Kernel NET policy

2016-07-18 Thread Liang, Kan
> >> > >> On Mon, Jul 18, 2016 at 8:45 AM, Andi Kleen wrote: > >> >> It seems strange to me to add such policies to the kernel. > >> >> Addmittingly, documentation of some settings is non-existent and > >> >> one needs various different tools to set this (sysctl, procfs,

Re: [RFC PATCH 00/30] Kernel NET policy

2016-07-18 Thread Cong Wang
On Mon, Jul 18, 2016 at 1:14 PM, Liang, Kan wrote: > > >> >> On Mon, Jul 18, 2016 at 8:45 AM, Andi Kleen wrote: >> >> It seems strange to me to add such policies to the kernel. >> >> Addmittingly, documentation of some settings is non-existent and one >>

Re: Getting IP address and port of a file descriptor

2016-07-18 Thread Cong Wang
On Mon, Jul 18, 2016 at 12:09 PM, Peter Chen wrote: > Hi, > >I was wondering, if I was in the kernel, and I intercepted a system > call such as read(). Would I be able, from the fd, determine the > whether the fd is (1) a network socket? (2) the IP address and

Re: [PATCH v2 05/11] Kbuild: don't add obj tree in additional includes

2016-07-18 Thread Michal Marek
On Wed, Jun 15, 2016 at 05:45:47PM +0200, Arnd Bergmann wrote: > When building with separate object directories and driver specific > Makefiles that add additional header include paths, Kbuild adjusts > the gcc flags so that we include both the directory in the source > tree and in the object

RE: [RFC PATCH 00/30] Kernel NET policy

2016-07-18 Thread Liang, Kan
> > On Mon, Jul 18, 2016 at 8:45 AM, Andi Kleen wrote: > >> It seems strange to me to add such policies to the kernel. > >> Addmittingly, documentation of some settings is non-existent and one > >> needs various different tools to set this (sysctl, procfs, sysfs, ethtool,

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add support for DSA ageing time

2016-07-18 Thread Andrew Lunn
On Mon, Jul 18, 2016 at 03:59:38PM -0400, Vivien Didelot wrote: > Andrew Lunn writes: > > >> Nope, the bridge ageing time is not per-port, even though switchdev ops > >> are per-port by design. This is a switch-wide attribute. > > > > So you are saying the core is doing all the

[no subject]

2016-07-18 Thread J Walker

Re: [PATCH net] bnxt_en: Remove locking around txr->dev_state

2016-07-18 Thread Michael Chan
On Mon, Jul 18, 2016 at 1:02 PM, Florian Fainelli wrote: > txr->dev_state was not consistently manipulated with the acquisition of > the per-queue lock, after further inspection the lock does not seem > necessary, either the value is read as BNXT_DEV_STATE_CLOSING or 0. > >

[PATCH net] bnxt_en: Remove locking around txr->dev_state

2016-07-18 Thread Florian Fainelli
txr->dev_state was not consistently manipulated with the acquisition of the per-queue lock, after further inspection the lock does not seem necessary, either the value is read as BNXT_DEV_STATE_CLOSING or 0. Reported-by: coverity (CID 1339583) Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add support for DSA ageing time

2016-07-18 Thread Vivien Didelot
Andrew Lunn writes: >> Nope, the bridge ageing time is not per-port, even though switchdev ops >> are per-port by design. This is a switch-wide attribute. > > So you are saying the core is doing all the reference counting, etc, > when swapping between fast and slow ageing? I

Re: [PATCH 0/2] Fix DMA channel misreporting for the Renesas Ethernet drivers

2016-07-18 Thread David Miller
From: Sergei Shtylyov Date: Mon, 18 Jul 2016 17:13:02 +0300 > Hello. > > On 07/18/2016 09:24 AM, David Miller wrote: > >>>Here's a set of 2 patches against DaveM's 'net.git' repo fixing >>> up the DMA channel reporting by 'ifconfig'... >> >> Is some

Re: [RFC PATCH 00/30] Kernel NET policy

2016-07-18 Thread Andi Kleen
> > So where is your policy for power saving? From past experience I can tell > > you > > There is no policy for power saving yet. I will add it to my todo list. Yes it's interesting to consider. The main goal here is to maximize CPU idle residency? I wonder if that's that much different from

RE: [RFC PATCH 00/30] Kernel NET policy

2016-07-18 Thread Liang, Kan
> On Sun, Jul 17, 2016 at 11:55 PM, wrote: > > From: Kan Liang > > > > It is a big challenge to get good network performance. First, the > > network performance is not good with default system settings. Second, > > it is too difficult to do automatic

Re: [RFC PATCH 00/30] Kernel NET policy

2016-07-18 Thread Andi Kleen
> I wonder if this can be attacked from a different angle. What would be > missing to add support for this in user space? The first possibility > that came to my mind is to just multiplex those hints in the kernel. "just" is the handwaving part here -- you're proposing a micro kernel approach

Re: [PATCH v2 net-next v2 09/12] net: dsa: mv88e6xxx: add cap for IRL

2016-07-18 Thread Andrew Lunn
On Mon, Jul 18, 2016 at 02:46:25PM -0400, Vivien Didelot wrote: > Add capability flags to describe the presence of Ingress Rate Limit unit > registers and an helper function to clear it. > > In the meantime, fix a few harmless issues: > > - 6185 and 6095 don't have such registers (reserved) >

Re: [PATCH v2 net-next v2 03/12] net: dsa: mv88e6xxx: extract device mapping

2016-07-18 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> +/* Indirect write to single pointer-data register with an Update bit */ >> +static int mv88e6xxx_update_write(struct mv88e6xxx_chip *chip, >> + int addr, int reg, u16 update) > > Hi Vivien > > I don't think

Re: [PATCH v2 net-next v2 08/12] net: dsa: mv88e6xxx: add cap for Priority Override

2016-07-18 Thread Andrew Lunn
On Mon, Jul 18, 2016 at 02:46:24PM -0400, Vivien Didelot wrote: > Add flags and helpers to describe the presence of Priority Override > Table (POT) related registers and simplify the setup of Global 2. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew

Re: [PATCH v2 net-next v2 06/12] net: dsa: mv88e6xxx: rework Switch MAC setter

2016-07-18 Thread Andrew Lunn
On Mon, Jul 18, 2016 at 02:46:22PM -0400, Vivien Didelot wrote: > Switches such as 88E6185 as 3 Switch MAC registers in Global 1. Newer > chips such as 88E6352 have freed these registers in favor of an indirect > access in a Switch MAC/WoL/WoF register in Global 2. > > Explicit this difference

Re: [PATCH v2 net-next v2 07/12] net: dsa: mv88e6xxx: add cap for PVT

2016-07-18 Thread Andrew Lunn
On Mon, Jul 18, 2016 at 02:46:23PM -0400, Vivien Didelot wrote: > Add flags to describe the presence of Cross-chip Port VLAN Table (PVT) > related registers and simplify the setup of Global 2. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn

Re: [PATCH v2 net-next v2 05/12] net: dsa: mv88e6xxx: add cap for MGMT Enables bits

2016-07-18 Thread Andrew Lunn
On Mon, Jul 18, 2016 at 02:46:21PM -0400, Vivien Didelot wrote: > Some switches provide a Rsvd2CPU mechanism used to choose which of the > 16 reserved multicast destination addresses matching 01:80:c2:00:00:0x > should be considered as MGMT and thus forwarded to the CPU port. > > Other switches

Re: [PATCH v2 net-next v2 04/12] net: dsa: mv88e6xxx: extract trunk mapping

2016-07-18 Thread Andrew Lunn
On Mon, Jul 18, 2016 at 02:46:20PM -0400, Vivien Didelot wrote: > The Trunk Mask and Trunk Mapping registers are two Global 2 indirect > accesses to trunking configuration. > > Add helpers for these tables and simplify the Global 2 setup. > > Signed-off-by: Vivien Didelot

Re: brcmfmac: respect hidden_ssid for AP interfaces

2016-07-18 Thread Kalle Valo
Rafał Miłecki wrote: > This was succesfully tested with 4366B1. A small workaround is needed > for the main interface otherwise it would stuck at the hidden state. > > Signed-off-by: Rafał Miłecki Thanks, 1 patch applied to wireless-drivers-next.git: c940de10d45e brcmfmac:

Re: [PATCH v2 net-next v2 03/12] net: dsa: mv88e6xxx: extract device mapping

2016-07-18 Thread Andrew Lunn
> +/* Indirect write to single pointer-data register with an Update bit */ > +static int mv88e6xxx_update_write(struct mv88e6xxx_chip *chip, > + int addr, int reg, u16 update) Hi Vivien I don't think mv88e6xxx_update_read() makes any sense? Can we just infer write?

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add support for DSA ageing time

2016-07-18 Thread Andrew Lunn
> Nope, the bridge ageing time is not per-port, even though switchdev ops > are per-port by design. This is a switch-wide attribute. So you are saying the core is doing all the reference counting, etc, when swapping between fast and slow ageing? Andrew

Re: wlcore/wl18xx: mesh: added initial mesh support for wl8

2016-07-18 Thread Kalle Valo
"Machani, Yaniv" wrote: > From: Maital Hahn > > 1. Added support for interface and role of mesh type. > 2. Enabled enable/start of mesh-point role, >and opening and closing a connection with a mesh peer. > 3. Added multirole combination of mesh and ap >

Re: [PATCH v2 net-next v2 02/12] net: dsa: mv88e6xxx: split setup of Global 1 and 2

2016-07-18 Thread Andrew Lunn
On Mon, Jul 18, 2016 at 02:46:18PM -0400, Vivien Didelot wrote: > Separate the setup of Global 1 and Global 2 internal SMI devices and add > a flag to describe the presence of this second registers set. Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add support for DSA ageing time

2016-07-18 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > This is way too simplistic. > > The switchdev call is per port. This manipulates the whole switch. We > need to somehow handle the difference. > > I've not look at the bridge code, but i assume it initially sets each > port to a long age time,

[PATCH V2] Add flow control to the portmapper

2016-07-18 Thread Shiraz Saleem
From: Mustafa Ismail During connection establishment with a large number of connections, it is possible that the connection requests might fail. Adding flow control prevents this failure. Change ibnl unicast to use netlink messaging with blocking to enable flow control.

Re: [PATCH v2 net-next v2 01/12] net: dsa: mv88e6xxx: remove basic function flags

2016-07-18 Thread Andrew Lunn
On Mon, Jul 18, 2016 at 02:46:17PM -0400, Vivien Didelot wrote: > All 88E6xxx Marvell switches (even the old not supported yet 88E6060) > have at least an ATU, per-port STP states and VLAN map, to run basic > switch functions such as Spanning Tree and port based VLANs. > > Get rid of the related

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add support for DSA ageing time

2016-07-18 Thread Andrew Lunn
On Mon, Jul 18, 2016 at 02:46:28PM -0400, Vivien Didelot wrote: > Implement the DSA driver function to configure the bridge ageing time. > > Signed-off-by: Vivien Didelot > --- > drivers/net/dsa/mv88e6xxx/chip.c | 14 ++ > 1 file changed, 14

Getting IP address and port of a file descriptor

2016-07-18 Thread Peter Chen
Hi, I was wondering, if I was in the kernel, and I intercepted a system call such as read(). Would I be able, from the fd, determine the whether the fd is (1) a network socket? (2) the IP address and port of this socket? What are the kernel data structures and functions that can get these

Re: [RFC PATCH 00/30] Kernel NET policy

2016-07-18 Thread Hannes Frederic Sowa
On 18.07.2016 17:45, Andi Kleen wrote: >> It seems strange to me to add such policies to the kernel. >> Addmittingly, documentation of some settings is non-existent and one needs >> various different tools to set this (sysctl, procfs, sysfs, ethtool, etc). > > The problem is that different

Re: [PATCH v8 04/11] net/mlx4_en: add support for fast rx drop bpf program

2016-07-18 Thread Brenden Blanco
On Mon, Jul 18, 2016 at 01:39:02PM +0200, Tom Herbert wrote: > On Mon, Jul 18, 2016 at 11:10 AM, Thomas Graf wrote: > > On 07/15/16 at 10:49am, Tom Herbert wrote: [...] > >> To me, an XDP program is just another attribute of an RX queue, it's > >> really not special!. We already

[PATCH net] net: switchdev: change ageing_time type to clock_t

2016-07-18 Thread Vivien Didelot
The switchdev value for the SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute is a clock_t and requires to use helpers such as clock_t_to_jiffies() to convert to milliseconds. Change ageing_time type from u32 to clock_t to make it explicit. Fixes: f55ac58ae64c ("switchdev: add bridge ageing_time

[PATCH v2 net-next v2 08/12] net: dsa: mv88e6xxx: add cap for Priority Override

2016-07-18 Thread Vivien Didelot
Add flags and helpers to describe the presence of Priority Override Table (POT) related registers and simplify the setup of Global 2. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 37 +--

[PATCH v2 net-next v2 00/12] net: dsa: mv88e6xxx: Global2 cleanup and STP

2016-07-18 Thread Vivien Didelot
The Marvell switches registers are organized in distinct internal SMI devices, such as PHY, Port, Global 1 or Global 2 registers sets. Since not all chips support every registers sets or have slightly differences in them (such as old 88E6060 or new 88E6390 likely to be supported soon), make the

Re: [PATCH 3/3] mac80211: mesh: fixed HT ies in beacon template

2016-07-18 Thread Johannes Berg
On Mon, 2016-07-18 at 09:38 -0400, Bob Copeland wrote: > On Wed, Jul 13, 2016 at 02:45:40PM +0300, Yaniv Machani wrote: > > The HT capab info field inside the HT capab IE of the mesh beacon > > is incorrect (in the case of 20MHz channel width). > > To fix this driver will check configuration from

[PATCH v2 net-next v2 02/12] net: dsa: mv88e6xxx: split setup of Global 1 and 2

2016-07-18 Thread Vivien Didelot
Separate the setup of Global 1 and Global 2 internal SMI devices and add a flag to describe the presence of this second registers set. Also rearrange the G1 setup in the registers order. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c

[PATCH v2 net-next v2 06/12] net: dsa: mv88e6xxx: rework Switch MAC setter

2016-07-18 Thread Vivien Didelot
Switches such as 88E6185 as 3 Switch MAC registers in Global 1. Newer chips such as 88E6352 have freed these registers in favor of an indirect access in a Switch MAC/WoL/WoF register in Global 2. Explicit this difference with G1 and G2 helpers and flags. Signed-off-by: Vivien Didelot

  1   2   3   >