[Patch net-next 2/2] net_sched: get rid of struct tcf_common

2016-07-20 Thread Cong Wang
After the previous patch, struct tc_action should be enough to represent the generic tc action, tcf_common is not necessary at more. This patch gets rid of it to make tc action code more readable. Cc: Jamal Hadi Salim Signed-off-by: Cong Wang ---

[Patch net-next 0/2] net_sched: refactor tc action structures

2016-07-20 Thread Cong Wang
These two patches factor our the struct tcf_common. Cong Wang (2): net_sched: move tc_action into tcf_common net_sched: get rid of struct tcf_common include/net/act_api.h| 91 +++--- include/net/tc_act/tc_bpf.h | 5 +- include/net/tc_act/tc_connmark.h | 5 +-

[Patch net-next 1/2] net_sched: move tc_action into tcf_common

2016-07-20 Thread Cong Wang
struct tc_action is confusing, currently we use it for two purposes: 1) Pass in arguments and carry out results from helper functions 2) A generic representation for tc actions The first one is error-prone, since we need to make sure we don't miss anything. This patch aims to get rid of this use,

Re: [PATCH net-next] samples: Add an IPv6 '-6' option to the pktgen scripts

2016-07-20 Thread David Miller
From: Martin KaFai Lau Date: Wed, 20 Jul 2016 15:48:43 -0700 > Add a '-6' option to the sample pktgen scripts for sending out > IPv6 packets. > > [root@kerneldev010.prn1 ~/pktgen]# ./pktgen_sample03_burst_single_flow.sh -i > eth0 -s 64 -d fe80::f652:14ff:fec2:a14c -m

Re: [PATCH net-next 2/2] net/mlx5e: Query minimum required header copy during xmit

2016-07-20 Thread Alexei Starovoitov
On Thu, Jul 21, 2016 at 01:20:02AM +0300, Saeed Mahameed wrote: > From: Hadar Hen Zion > > Add support for query the minimum inline mode from the Firmware. > It is required for correct TX steering according to L3/L4 packet > headers. > > Each send queue (SQ) has inline mode

Re: [PATCH net-next 0/3] misc cleanups for xdp

2016-07-20 Thread David Miller
From: Brenden Blanco Date: Wed, 20 Jul 2016 17:22:32 -0700 > This addresses several of the non-blocking comments left over from the > xdp patch set. See individual patches for details. Series applied, thanks.

Re: [net-next 00/20][pull request] 100GbE Intel Wired LAN Driver Updates 2016-07-20

2016-07-20 Thread David Miller
From: Jeff Kirsher Date: Wed, 20 Jul 2016 15:23:38 -0700 > This series contains updates to fm10k only. Pulled, thanks Jeff.

Re: [PATCH net-next v2 0/3] net: dsa: mv88e6xxx: rework EEPROM code

2016-07-20 Thread David Miller
From: Vivien Didelot Date: Wed, 20 Jul 2016 18:18:33 -0400 > Some switches can access an optional external EEPROM via its registers. > > The 88E6352 family of switches have 8-bit address / 16-bit data access. > The new 88E6390 family has 16-bit address /

Re: [PATCH net-next v2] net/faraday: Disallow using reversed MAC address from hardware

2016-07-20 Thread David Miller
From: Gavin Shan Date: Thu, 21 Jul 2016 11:42:54 +1000 > The initial MAC address is retrieved from hardware if it's not > provided by device-tree. The reserved MAC address from hardware > will be used if non-reserved MAC address is invalid. It will > cause mismatched

[RFC PATCH net-next] ibmvnic: Handle backing device failover and reinitialization

2016-07-20 Thread Thomas Falcon
An upcoming feature of IBM VNIC protocol is the ability to configure redundant backing devices for a VNIC client. In case of a failure on the current backing device, the driver will receive a signal from the hypervisor indicating that a failover will occur. The driver will then wait for a message

Re: [PATCH V2] Add flow control to the portmapper

2016-07-20 Thread Shiraz Saleem
On Tue, Jul 19, 2016 at 08:32:53PM +0300, Leon Romanovsky wrote: > On Tue, Jul 19, 2016 at 09:50:24AM -0500, Shiraz Saleem wrote: > > On Tue, Jul 19, 2016 at 08:40:06AM +0300, Leon Romanovsky wrote: > > > > > > You are the one user of this new inline function. > > > Why don't you directly call to

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2016-07-20 Thread Florian Fainelli
Le 20/07/2016 à 17:35, Andrew Lunn a écrit : > On Wed, Jul 20, 2016 at 06:26:41PM -0400, Vivien Didelot wrote: >> This patch simply moves the legacy DSA code from dsa.c to legacy.c, >> except the few shared symbols which remain in dsa.c. > > I think it is a bit early for this. Lets convert all in

[PATCH net-next v2] net/faraday: Disallow using reversed MAC address from hardware

2016-07-20 Thread Gavin Shan
The initial MAC address is retrieved from hardware if it's not provided by device-tree. The reserved MAC address from hardware will be used if non-reserved MAC address is invalid. It will cause mismatched MAC address seen by hardware and software. This disallows using the reserved hardware MAC

linux-next: manual merge of the net-next tree with the net tree

2016-07-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/mellanox/mlx4/en_ethtool.c between commit: ec25bc04ed8e ("net/mlx4_en: Add resilience in low memory systems") from the net tree and commit: 9ecc2d86171a ("net/mlx4_en: add xdp forwarding and

Re: [PATCH] net/faraday: Disallow using reversed MAC address from hardware

2016-07-20 Thread Gavin Shan
On Thu, Jul 21, 2016 at 11:29:23AM +1000, Gavin Shan wrote: >The initial MAC address is retrieved from hardware if it's not >provided by device-tree. The reserved MAC address from hardware >will be used if non-reserved MAC address is invalid. It will >cause mismatched MAC address seen by hardware

[PATCH] net/faraday: Disallow using reversed MAC address from hardware

2016-07-20 Thread Gavin Shan
The initial MAC address is retrieved from hardware if it's not provided by device-tree. The reserved MAC address from hardware will be used if non-reserved MAC address is invalid. It will cause mismatched MAC address seen by hardware and software. This disallows using the reserved hardware MAC

Re: [PATCH net-next 3/3] bpf: make xdp sample variable names more meaningful

2016-07-20 Thread Alexei Starovoitov
On Wed, Jul 20, 2016 at 05:22:35PM -0700, Brenden Blanco wrote: > The naming choice of index is not terribly descriptive, and dropcnt is > in fact incorrect for xdp2. Pick better names for these: ipproto and > rxcnt. > > Signed-off-by: Brenden Blanco Thanks! Acked-by:

Re: [PATCH net-next 2/3] rtnl: protect do_setlink from IFLA_XDP_ATTACHED

2016-07-20 Thread Alexei Starovoitov
On Wed, Jul 20, 2016 at 05:22:34PM -0700, Brenden Blanco wrote: > The IFLA_XDP_ATTACHED nested attribute is meant for read-only, and while > do_setlink properly ignores it, it should be more paranoid and reject > commands that try to set it. > > Signed-off-by: Brenden Blanco

Re: [PATCH net-next 1/3] net/mlx4_en: use READ_ONCE when freeing xdp_prog

2016-07-20 Thread Alexei Starovoitov
On Wed, Jul 20, 2016 at 05:22:33PM -0700, Brenden Blanco wrote: > For consistency, and in order to hint at the synchronous nature of the > xdp_prog field, use READ_ONCE in the destroy path of the ring. All > occurrences should now use either READ_ONCE or xchg. > > Signed-off-by: Brenden Blanco

Re: [RFC] ethtool bandwidth per-queue commands

2016-07-20 Thread John Fastabend
On 16-07-20 01:00 PM, ivan wrote: > Hi everyone. > > The ethtool interface has ETHTOOL_PERQUEUE command that is used to > read/set per-queue parameters for multiqueue Ethernet devices. > > I want to apply additional per-queue commands like per-queue bandwidth > and per-queue number of

Re: [PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset

2016-07-20 Thread Alexei Starovoitov
On Thu, Jul 21, 2016 at 12:39:53AM +0300, Saeed Mahameed wrote: > memset the command buffers rather than the pointers to them. that is still wrong commit log. This patch makes zero difference to generated code. '' is the same as 'in' > Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for

RE: [PATCH] igb: fix adjusting ptp timestamps for tx/rx latency

2016-07-20 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Kshitiz Gupta > Sent: Saturday, July 16, 2016 12:24 AM > To: Kirsher, Jeffrey T ; Nathan Sullivan > ; Brown, Aaron F > Cc:

Re: [PATCH net-next v2 3/3] net: dsa: mv88e6xxx: kill last locked reg_read

2016-07-20 Thread Andrew Lunn
On Wed, Jul 20, 2016 at 06:18:36PM -0400, Vivien Didelot wrote: > Get rid of the last usage of the locked mv88e6xxx_reg_read function with > a new mv88e6xxx_port_read helper, useful later for chips with different > port registers base address. > > Signed-off-by: Vivien Didelot

Re: [PATCH net-next v2 2/3] net: dsa: mv88e6xxx: rework EEPROM access

2016-07-20 Thread Andrew Lunn
On Wed, Jul 20, 2016 at 06:18:35PM -0400, Vivien Didelot wrote: > The 6352 family of switches and compatibles provide a 8-bit address and > 16-bit data access to an optional EEPROM. > > Newer chip such as the 6390 family slightly changed the access to 16-bit > address and 8-bit data. > > This

Re: [PATCH net-next v2 1/3] net: dsa: mv88e6xxx: remove unused phy_mutex

2016-07-20 Thread Andrew Lunn
On Wed, Jul 20, 2016 at 06:18:34PM -0400, Vivien Didelot wrote: > Only reg_lock is necessary now and phy_mutex is dead. Remove it. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2016-07-20 Thread Andrew Lunn
On Wed, Jul 20, 2016 at 06:26:41PM -0400, Vivien Didelot wrote: > This patch simply moves the legacy DSA code from dsa.c to legacy.c, > except the few shared symbols which remain in dsa.c. I think it is a bit early for this. Lets convert all in kernel users to the new binding first. >

[PATCH net-next 1/3] net/mlx4_en: use READ_ONCE when freeing xdp_prog

2016-07-20 Thread Brenden Blanco
For consistency, and in order to hint at the synchronous nature of the xdp_prog field, use READ_ONCE in the destroy path of the ring. All occurrences should now use either READ_ONCE or xchg. Signed-off-by: Brenden Blanco --- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 6

[PATCH net-next 3/3] bpf: make xdp sample variable names more meaningful

2016-07-20 Thread Brenden Blanco
The naming choice of index is not terribly descriptive, and dropcnt is in fact incorrect for xdp2. Pick better names for these: ipproto and rxcnt. Signed-off-by: Brenden Blanco --- samples/bpf/xdp1_kern.c | 12 ++-- samples/bpf/xdp2_kern.c | 14 +++--- 2

[PATCH net-next 2/3] rtnl: protect do_setlink from IFLA_XDP_ATTACHED

2016-07-20 Thread Brenden Blanco
The IFLA_XDP_ATTACHED nested attribute is meant for read-only, and while do_setlink properly ignores it, it should be more paranoid and reject commands that try to set it. Signed-off-by: Brenden Blanco --- net/core/rtnetlink.c | 4 1 file changed, 4 insertions(+)

[PATCH net-next 0/3] misc cleanups for xdp

2016-07-20 Thread Brenden Blanco
This addresses several of the non-blocking comments left over from the xdp patch set. See individual patches for details. Brenden Blanco (3): net/mlx4_en: use READ_ONCE when freeing xdp_prog rtnl: protect do_setlink from IFLA_XDP_ATTACHED bpf: make xdp sample variable names more meaningful

Re: [PATCH net-next v3 1/2] bpf: Add bpf_copy_to_user BPF helper to be called in tracers (kprobes)

2016-07-20 Thread Daniel Borkmann
On 07/20/2016 11:58 AM, Sargun Dhillon wrote: [...] So, with that, what about the following: It includes -Desupporting no MMU platforms as we've deemed them incapable of being safe -Checking that we're not in a kthread -Checking that the active mm is the thread's mm -A log message indicating

Re: [PATCH net-next] samples: Add an IPv6 '-6' option to the pktgen scripts

2016-07-20 Thread Alexei Starovoitov
On 7/20/16 3:48 PM, Martin KaFai Lau wrote: Add a '-6' option to the sample pktgen scripts for sending out IPv6 packets. [root@kerneldev010.prn1 ~/pktgen]# ./pktgen_sample03_burst_single_flow.sh -i eth0 -s 64 -d fe80::f652:14ff:fec2:a14c -m f4:52:14:c2:a1:4c -b 32 -6 [root@kerneldev011.prn1

[PATCH net-next] samples: Add an IPv6 '-6' option to the pktgen scripts

2016-07-20 Thread Martin KaFai Lau
Add a '-6' option to the sample pktgen scripts for sending out IPv6 packets. [root@kerneldev010.prn1 ~/pktgen]# ./pktgen_sample03_burst_single_flow.sh -i eth0 -s 64 -d fe80::f652:14ff:fec2:a14c -m f4:52:14:c2:a1:4c -b 32 -6 [root@kerneldev011.prn1 ~]# tcpdump -i eth0 -nn -c3 port 9 tcpdump:

Re: [PATCH net-next] net: dsa: b53: use module_mdio_driver

2016-07-20 Thread Florian Fainelli
On 07/20/2016 03:26 PM, Vivien Didelot wrote: > Reduce boilerplate for module declaration with module_mdio_driver. > > Signed-off-by: Vivien Didelot Acked-by: Florian Fainelli -- Florian

[GIT] [4.8] NFC update

2016-07-20 Thread Samuel Ortiz
Hi David, This is the first NFC pull request for 4.8. We have: - A fairly large NFC digital stack patchset: * RTOX fixes. * Proper DEP RWT support. * ACK and NACK PDUs handling fixes, in both initiator and target modes. * A few memory leak fixes. - A conversion of the nfcsim driver

Re: [PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset

2016-07-20 Thread David Miller
From: Saeed Mahameed Date: Thu, 21 Jul 2016 00:39:53 +0300 > memset the command buffers rather than the pointers to them. > > Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for VXLAN tunneling") > Signed-off-by: Saeed Mahameed > --- > > V2: > -

[PATCH net-next] net: dsa: add CONFIG_NET_DSA_LEGACY

2016-07-20 Thread Vivien Didelot
This patch simply moves the legacy DSA code from dsa.c to legacy.c, except the few shared symbols which remain in dsa.c. Compile legacy.o only if a new CONFIG_NET_DSA_LEGACY symbol is enabled, which is true by default. DSA drivers without legacy support don't need the probe function as well as

[net-next 15/20] fm10k: enable bus master after every reset

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller If an FLR occurs, VF devices will be knocked out of bus master mode, and the driver will be unable to recover from the reset properly, resulting in malicious driver events and an infinite reset loop. In the normal case, the bus master mode will

[net-next 12/20] fm10k: use common reset flow when handling io errors from PCI stack

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller Now that we have extracted the necessary steps for a split suspend/resume flow, re-use these functions instead of using the current open coded flow. This ensures that we don't miss any steps. It also ensures that we have the correct driver states set.

[net-next 07/20] fm10k: use actual hardware registers when checking for pending Tx

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller Signed-off-by: Jacob Keller Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 8 +--- 1 file changed,

[net-next 10/20] fm10k: split fm10k_reinit into two functions

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller There are several flows in the driver which perform the similar function of tearing down software and restoring software to recover from certain errors or PCIe events, including: * fm10k_reinit * fm10k_suspend/resume *

[net-next 08/20] fm10k: only warn when stop_hw fails with FM10K_ERR_REQUESTS_PENDING

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller When stop_hw() routine fails with FM10K_ERR_REQUESTS_PENDING, this indicates that the Tx or Rx queues did not shutdown within the time limit. Print a more suitable message at the dev_info level instead of dev_err. Signed-off-by: Jacob Keller

[net-next 05/20] fm10k: don't stop reset due to FM10K_ERR_REQUESTS_PENDING

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller Don't report FM10K_ERR_REQUESTS_PENDING when we fail to disable queues within the timeout. This can occur due to a hardware Tx hang, or when the switch ethernet fabric is resetting while we are transmitting traffic. It can sometimes take up to 500ms

[net-next 06/20] fm10k: perform data path reset even when switch is not ready

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller A while ago, an additional check for the switch being ready was added to reset_hw. A recent refactor accidentally made this check return an error code on failure which caused fm10k_probe to fail when the switch wasn't brought up first. The original

[net-next 14/20] fm10k: use common flow for suspend and resume

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller Continuing the effort to commonize the similar suspend/resume flows, finish up by using the new fm10k_handle_suspand and fm10k_handle_resume functions for the standard suspend/resume flow. Signed-off-by: Jacob Keller

[net-next 01/20] fm10k: no need to continue in fm10k_down if __FM10K_DOWN already set

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller Return early from fm10k_down() when we are already down, since that means another thread is either already finished or has started going down, so shouldn't conflict with them. Signed-off-by: Jacob Keller Tested-by:

[net-next 02/20] fm10k: avoid possible null pointer dereference in fm10k_update_stats

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller It's currently possible for fm10k_update_stats to be called during the window when we go down and the rings are removed. This can result in a null pointer dereference. In fm10k_get_stats64 we work around this by using ACCESS_ONCE and a null pointer

[PATCH net-next] net: dsa: b53: use module_mdio_driver

2016-07-20 Thread Vivien Didelot
Reduce boilerplate for module declaration with module_mdio_driver. Signed-off-by: Vivien Didelot --- drivers/net/dsa/b53/b53_mdio.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/net/dsa/b53/b53_mdio.c

[net-next 03/20] fm10k: prevent multiple threads updating statistics

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller Also prevent updating stats while the interface is down. If we're already updating stats, just return doing nothing. When we take the device down, block stat updates until we come back up. This ensures that we avoid tearing down rings when we're

[net-next 11/20] fm10k: implement prepare_suspend and handle_resume

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller Implement fm10k_prepare_suspend and fm10k_handle_resume functions which abstract around the now existing fm10k_prepare_for_reset and fm10k_handle_reset. The new functions also handle stopping the service task, which is something that the original

[net-next 16/20] fm10k: check if PCIe link is restored

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller Sometimes, a VF driver will lose PCIe address access, such as due to a PF FLR event. In fm10k_detach_subtask, poll and check whether the PCIe register space is active again and restore the device when it has. Signed-off-by: Jacob Keller

[net-next 04/20] fm10k: Reset mailbox global interrupts

2016-07-20 Thread Jeff Kirsher
From: Ngai-Mint Kwan When a data path reset is initiated, write control to the PCIE_GMBX is yanked from the switch manager. The switch manager writes to this register to clear mailbox global interrupt bits as part of its mailbox interrupt handling routine. When the

[net-next 20/20] fm10k: bump version number

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller Signed-off-by: Jacob Keller Tested-by: Krishneil Singh Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +- 1 file changed, 1

[net-next 09/20] fm10k: wait for queues to drain if stop_hw() fails once

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller It turns out that sometimes during a reset the Tx queues will be temporarily stuck longer than .stop_hw() expects. Work around this issue by attempting to .stop_hw() first. If it tails, wait a number of attempts until the Tx queues appear to be

[net-next 17/20] fm10k: implement request_lport_map pointer

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller If the fm10k interface is brought up, but the switch manager software is not running, the driver will continuously request the lport map every few seconds in the base driver watchdog routine. Eventually after several minutes the switch mailbox Tx fifo

[net-next 13/20] fm10k: implement reset_notify handler for PCIe FLR events

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller When a function level PCI reset is triggered using sysfs, it calls the driver's .reset_notify error handler. Implement a handler based on the now split fm10k_prepare_for_reset and fm10k_handle_reset functions, so that we fully reset the driver when

[net-next 18/20] fm10k: force link to remain down for at least a second on resume events

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller When we resume from an AER recovery with many active VFs, the PF sees many spurious link up and link down events. Prevent this by delaying link down for at least one second after the resume event. Signed-off-by: Jacob Keller

[net-next 19/20] fm10k: return proper error code when pci_enable_msix_range fails

2016-07-20 Thread Jeff Kirsher
From: Jacob Keller The pci_enable_msix_range() function returns a positive value of the number of allocated vectors if it succeeds. On failure it returns a negative error code. Return this code properly so that the error message printed by the driver will show the

[net-next 00/20][pull request] 100GbE Intel Wired LAN Driver Updates 2016-07-20

2016-07-20 Thread Jeff Kirsher
This series contains updates to fm10k only. Ngai-Mint provides a fix to clear PCIE_GMBX bits to ensure the proper functioning of the mailbox global interrupt after a data path reset. Jake provides most of the patches in the series, starting with a early return from fm10k_down() if we are already

[PATCH net-next v2 2/3] net: dsa: mv88e6xxx: rework EEPROM access

2016-07-20 Thread Vivien Didelot
The 6352 family of switches and compatibles provide a 8-bit address and 16-bit data access to an optional EEPROM. Newer chip such as the 6390 family slightly changed the access to 16-bit address and 8-bit data. This commit cleans up the EEPROM access code for 16-bit access and makes it easy to

[PATCH net-next 0/2] Mellanox 100G mlx5 minimum inline header mode

2016-07-20 Thread Saeed Mahameed
Hi Dave, This small series from Hadar adds the support for minimum inline header mode query in mlx5e NIC driver. Today on TX the driver copies to the HW descriptor only up to L2 header which is the default required mode and sufficient for today's needs. The header in the HW descriptor is used

[PATCH net-next 2/2] net/mlx5e: Query minimum required header copy during xmit

2016-07-20 Thread Saeed Mahameed
From: Hadar Hen Zion Add support for query the minimum inline mode from the Firmware. It is required for correct TX steering according to L3/L4 packet headers. Each send queue (SQ) has inline mode that defines the minimal required headers that needs to be copied into the SQ

[PATCH net-next v2 1/3] net: dsa: mv88e6xxx: remove unused phy_mutex

2016-07-20 Thread Vivien Didelot
Only reg_lock is necessary now and phy_mutex is dead. Remove it. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h

[PATCH net-next 1/2] net/mlx5e: Check the minimum inline header mode before xmit

2016-07-20 Thread Saeed Mahameed
From: Hadar Hen Zion Each send queue (SQ) has inline mode that defines the minimal required inline headers in the SQ WQE. Before sending each packet check that the minimum required headers on the WQE are copied. Signed-off-by: Hadar Hen Zion

[PATCH net-next v2 3/3] net: dsa: mv88e6xxx: kill last locked reg_read

2016-07-20 Thread Vivien Didelot
Get rid of the last usage of the locked mv88e6xxx_reg_read function with a new mv88e6xxx_port_read helper, useful later for chips with different port registers base address. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 35

[PATCH net-next v2 0/3] net: dsa: mv88e6xxx: rework EEPROM code

2016-07-20 Thread Vivien Didelot
Some switches can access an optional external EEPROM via its registers. The 88E6352 family of switches have 8-bit address / 16-bit data access. The new 88E6390 family has 16-bit address / 8-bit data access. This patchset cleans up the EEPROM code with 16-suffixed Global2 helpers and makes it

[PATCH net] packet: propagate sock_cmsg_send() error

2016-07-20 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh sock_cmsg_send() can return different error codes and not only -EINVAL, and we should properly propagate them. Fixes: c14ac9451c34 ("sock: enable timestamping using control messages") Signed-off-by: Soheil Hassas Yeganeh Cc:

Re: [PATCH net-next 1/3] net: dsa: mv88e6xxx: remove unused phy_mutex

2016-07-20 Thread David Miller
From: Vivien Didelot Date: Wed, 20 Jul 2016 12:05:45 -0400 > Only reg_lock is necessary now and phy_mutex is dead. Remove it. > --- > drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 6 -- > 1 file changed, 6 deletions(-) Missing a proper Signoff.

Re: [PATCH net-next v3] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-20 Thread David Miller
From: Kristian Evensen Date: Tue, 19 Jul 2016 16:54:11 +0200 > The firmware in several ZTE devices (at least the MF823/831/910 > modems/mifis) use OS fingerprinting to determine which type of device to > export. In addition, these devices export a REST API which can

Re: [patch net-next 0/2] mlxsw: Add per-{Prio,TC} counters

2016-07-20 Thread David Miller
From: Jiri Pirko Date: Tue, 19 Jul 2016 15:35:52 +0200 > From: Jiri Pirko > > Ido says: > > Add per-priority and per-tc counters, which are very useful for debugging > purposes and fine-tuning. Series applied.

Re: [PATCH -next] net: cpmac: fix error handling of cpmac_probe()

2016-07-20 Thread David Miller
From: Wei Yongjun Date: Tue, 19 Jul 2016 12:37:53 + > From: Wei Yongjun > > Add the missing free_netdev() before return from function > cpmac_probe() in the error handling case. > This patch revert commit 0465be8f4f1d ("net: cpmac: fix in >

Re: [PATCH -next] wan/fsl_ucc_hdlc: remove .owner field for driver

2016-07-20 Thread David Miller
From: Wei Yongjun Date: Tue, 19 Jul 2016 11:25:03 + > From: Wei Yongjun > > Remove .owner field if calls are used which set it automatically. > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > Signed-off-by: Wei

Re: [PATCH -next] net: ethernet: nb8800: fix error handling of nb8800_probe()

2016-07-20 Thread David Miller
From: Wei Yongjun Date: Tue, 19 Jul 2016 11:33:10 + > From: Wei Yongjun > > In ops->reset() error handling case, clk_disable_unprepare() is missed > before return from this function. > > Signed-off-by: Wei Yongjun

Re: [PATCH -next] net/mlx5: Use PTR_ERR_OR_ZERO() to simplify the code

2016-07-20 Thread David Miller
From: Wei Yongjun Date: Tue, 19 Jul 2016 11:35:46 + > From: Wei Yongjun > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR. > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Wei Yongjun

Re: [PATCH -next] wan/fsl_ucc_hdlc: use module_platform_driver to simplify the code

2016-07-20 Thread David Miller
From: Wei Yongjun Date: Tue, 19 Jul 2016 11:25:16 + > From: Wei Yongjun > > module_platform_driver() makes the code simpler by eliminating > boilerplate code. > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH -next] net: axienet: Fix return value check in axienet_probe()

2016-07-20 Thread David Miller
From: Wei Yongjun Date: Tue, 19 Jul 2016 11:23:24 + > From: Wei Yongjun > > In case of error, the function of_parse_phandle() returns NULL > pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL

Re: pull request: bluetooth-next 2016-07-19

2016-07-20 Thread David Miller
From: Johan Hedberg Date: Tue, 19 Jul 2016 09:14:52 +0300 > Here's likely the last bluetooth-next pull request for the 4.8 kernel: > > - Fix for L2CAP setsockopt > - Fix for is_suspending flag handling in btmrvl driver > - Addition of Bluetooth HW & FW info fields to

[PATCH net V2] net/mlx5e: Fix del vxlan port command buffer memset

2016-07-20 Thread Saeed Mahameed
memset the command buffers rather than the pointers to them. Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for VXLAN tunneling") Signed-off-by: Saeed Mahameed --- V2: - Improved log message. drivers/net/ethernet/mellanox/mlx5/core/vxlan.c | 4 ++-- 1 file changed,

Re: [net-next v2 0/6] common library for Chelsio drivers

2016-07-20 Thread David Miller
From: "Nicholas A. Bellinger" Date: Wed, 20 Jul 2016 14:13:55 -0700 > DaveM, if you'd prefer to pick it up, I'm happy to drop it. There were review comments and changes requested.

Re: [net-next v2 0/6] common library for Chelsio drivers

2016-07-20 Thread Nicholas A. Bellinger
Hi Varun & Co, On Sat, 2016-07-16 at 22:49 +0530, Varun Prakash wrote: > Hi, > > This patch series adds common library module(libcxgb.ko) > for Chelsio drivers to remove duplicate code. > > This series moves common iSCSI DDP Page Pod manager > code from cxgb4.ko to libcxgb.ko, earlier this

RE: [RFC] ethtool bandwidth per-queue commands

2016-07-20 Thread Liang, Kan
> > Hi everyone. > > The ethtool interface has ETHTOOL_PERQUEUE command that is used to > read/set per-queue parameters for multiqueue Ethernet devices. > > I want to apply additional per-queue commands like per-queue bandwidth > and per-queue number of descriptors (like number of rings). >

Re: Network hang after c3f1010b30f7fc611139cfb702a8685741aa6827 with CIPSO & Smack

2016-07-20 Thread Paul Moore
On Tue, Jul 19, 2016 at 7:37 PM, Casey Schaufler wrote: > Digging into this further I have determined that the > circumstances leading to this issue are somewhat complex. > The good news is that there seems to be a very limited > circumstances under which the problem

Re: [iproute PATCH 1/2] ipaddress: Simplify vf_info parsing

2016-07-20 Thread Phil Sutter
On Wed, Jun 01, 2016 at 03:36:09PM -0700, Greg Rose wrote: > On Wed, Jun 1, 2016 at 3:07 PM, Phil Sutter wrote: > > On Wed, Jun 01, 2016 at 03:00:08PM -0700, Greg Rose wrote: > >> On Wed, Jun 1, 2016 at 1:03 PM, Phil Sutter wrote: > >> > Not sure whether I misinterpret

[RFC] ethtool bandwidth per-queue commands

2016-07-20 Thread ivan
Hi everyone. The ethtool interface has ETHTOOL_PERQUEUE command that is used to read/set per-queue parameters for multiqueue Ethernet devices. I want to apply additional per-queue commands like per-queue bandwidth and per-queue number of descriptors (like number of rings). Currently only

Re: [PATCH net-next] bpf, elf: add official ELF machine define for eBPF

2016-07-20 Thread David Miller
From: Daniel Borkmann Date: Wed, 20 Jul 2016 20:17:47 +0200 > Add the official BPF ELF e_machine value that was assigned recently [1,2] > and will be propagated to glibc, et al. LLVM is switching to it in 3.9 > release. > > [1] >

Re: [iproute PATCH v2] ip-address.8: Document autojoin flag

2016-07-20 Thread Stephen Hemminger
On Tue, 12 Jul 2016 07:56:16 + Phil Sutter wrote: > Description copied from related kernel support commit message with a > little tailoring to fit. > > While at it, fix font of non-terminal CONFFLAG-LIST in synopsis. > > Signed-off-by: Phil Sutter Applied

Re: [patch iproute2] jsonw: Fix indentation of ending "}"

2016-07-20 Thread Stephen Hemminger
On Mon, 18 Jul 2016 09:51:17 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > Fix indentation of the very last "}" which is currently indented, > leaving the last 2 "}" like this: > \t} > \t} > EOF > > So fix it to be: > \t} > } > EOF > > Fixes fcc16c2287

Re: [PATCH v2 3/5] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-07-20 Thread Rob Herring
On Wed, Jul 20, 2016 at 10:03:18AM +0200, LABBE Corentin wrote: > This patch adds documentation for Device-Tree bindings for the > Allwinner sun8i-emac driver. > > Signed-off-by: LABBE Corentin > --- > .../bindings/net/allwinner,sun8i-emac.txt | 65 >

Re: [iproute PATCH v5 1/5] tc: m_action: Improve conversion to C99 style initializers

2016-07-20 Thread Stephen Hemminger
On Mon, 18 Jul 2016 14:48:41 + Phil Sutter wrote: > This improves my initial change in the following points: > > - Flatten embedded struct's initializers. > - No need to initialize variables to zero as the key feature of C99 > initializers is to do this implicitly. > - By

Re: [PATCH v10 00/12] Add driver bpf hook for early packet drop and forwarding

2016-07-20 Thread David Miller
From: Tariq Toukan Date: Wed, 20 Jul 2016 12:18:49 +0300 > > On 20/07/2016 8:09 AM, David Miller wrote: >> From: Brenden Blanco >> Date: Tue, 19 Jul 2016 12:16:45 -0700 >> >>> This patch set introduces new infrastructure for programmatically >>>

Re: [PATCH iproute2 net-next 0/5] bridge: json support for fdb and vlan show

2016-07-20 Thread Stephen Hemminger
On Fri, 27 May 2016 21:37:11 -0700 Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch series adds json support for a few bridge show commands. > We plan to follow up with json support for additional commands soon. > > Anuradha

Re: [PATCH iproute2] ss: Fix support for device filter by index

2016-07-20 Thread Stephen Hemminger
On Fri, 15 Jul 2016 15:41:35 -0700 David Ahern wrote: > Support was recently added for device filters. The intent was to allow > the device to be specified by name or index, and using the if%u format > (dev == if5) or the simpler and more intuitive index alone (dev ==

Re: [PATCH] bpf: fix implicit declaration of bpf_prog_add

2016-07-20 Thread David Miller
From: Brenden Blanco Date: Wed, 20 Jul 2016 07:55:52 -0700 > For the ifndef case of CONFIG_BPF_SYSCALL, an inline version of > bpf_prog_add needs to exist otherwise the build breaks on some configs. > > drivers/net/ethernet/mellanox/mlx4/en_netdev.c:2544:10: error:

Re: [PATCH] wlcore: spi: fix build warning caused by redundant variable

2016-07-20 Thread Kalle Valo
"Reizer, Eyal" writes: > The ret variable is unused in wlcore_probe_of() > Remove it for fixing build warning. > > Fixes: 01efe65aba65 ("wlcore: spi: add wl18xx support") > Signed-off-by: Eyal Reizer Applied to wireless-drivers-next, thanks. -- Kalle Valo

[PATCH net-next] bpf, elf: add official ELF machine define for eBPF

2016-07-20 Thread Daniel Borkmann
Add the official BPF ELF e_machine value that was assigned recently [1,2] and will be propagated to glibc, et al. LLVM is switching to it in 3.9 release. [1] https://github.com/llvm-mirror/llvm/commit/36b9c09330bfb5e771914cfe307588f30d5510d2 [2]

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

2016-07-20 Thread pravin shelar
On Tue, Jul 19, 2016 at 5:02 PM, Simon Horman wrote: > On Mon, Jul 18, 2016 at 03:34:52PM -0700, pravin shelar wrote: >> On Sun, Jul 17, 2016 at 9:50 PM, Simon Horman >> wrote: >> > [CC Jiri Benc for portion regarding GRE] >> > >> > Hi

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

2016-07-20 Thread Brenden Blanco
On Tue, Jul 19, 2016 at 03:05:37PM -0700, Alexei Starovoitov wrote: > On Tue, Jul 19, 2016 at 12:16:57PM -0700, Brenden Blanco wrote: > > Add a sample that rewrites and forwards packets out on the same > > interface. Observed single core forwarding performance of ~10Mpps. > > > > Since the mlx4

Re: [PATCH v10 04/12] rtnl: add option for setting link xdp prog

2016-07-20 Thread Brenden Blanco
On Wed, Jul 20, 2016 at 10:38:49AM +0200, Daniel Borkmann wrote: > On 07/19/2016 09:16 PM, Brenden Blanco wrote: > >Sets the bpf program represented by fd as an early filter in the rx path > >of the netdev. The fd must have been created as BPF_PROG_TYPE_XDP. > >Providing a negative value as fd

Re: [PATCH v10 05/12] net/mlx4_en: add support for fast rx drop bpf program

2016-07-20 Thread Brenden Blanco
On Wed, Jul 20, 2016 at 11:07:57AM +0200, Daniel Borkmann wrote: > On 07/19/2016 09:16 PM, Brenden Blanco wrote: [...] > >+if (ring->xdp_prog) > >+bpf_prog_put(ring->xdp_prog); > > Would be good if you also make this a READ_ONCE() here. I believe this is the > only other spot in

Re: [PATCH net] net/bonding: Enforce active-backup policy for IPoIB bonds

2016-07-20 Thread Andy Gospodarek
On Wed, Jul 20, 2016 at 10:13:47AM -0700, Jay Vosburgh wrote: > Andy Gospodarek wrote: > > >On Wed, Jul 20, 2016 at 05:44:20PM +0300, Saeed Mahameed wrote: > >> From: Mark Bloch > >> > >> When using an IPoIB bond currently only active-backup mode

  1   2   >