Re: [RFC PATCH 2/3] net: macb: Add support for 1588 for Zynq Ultrascale+ MPSoC

Hi Nicolas, Thanks for your reply On Tue, Aug 9, 2016 at 10:26 PM, Punnaiah Choudary Kalluri wrote: > Hi Nicolas, > > 1588 implementation in cadence GEM IP we have in Zynq Ultascale+ MPSoC is > Different to the one in Zynq SOC. > > In earlier version, all

Re: [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device

From: Toshiaki Makita Date: Thu, 4 Aug 2016 11:11:19 +0900 > Adding fdb entries pointing to the bridge device uses fdb_insert(), > which lacks various checks and does not respect added_by_user flag. > > As a result, some inconsistent behavior can happen: > *

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

On Tue, Aug 09, 2016 at 08:52:01PM -0700, Alexei Starovoitov wrote: > On Tue, Aug 09, 2016 at 08:40:05PM -0700, Sargun Dhillon wrote: > > On Tue, Aug 09, 2016 at 08:27:32PM -0700, Alexei Starovoitov wrote: > > > On Tue, Aug 09, 2016 at 06:26:37PM -0700, Sargun Dhillon wrote: > > > > On Tue, Aug

e1000: __pskb_pull_tail failed

MY NFS server running 4.8-rc1 is getting flooded with this message: e1000e :00:19.0 eth0: __pskb_pull_tail failed. Never saw it happen with 4.7 or earlier. That device is this onboard NIC: 00:19.0 Ethernet controller: Intel Corporation Ethernet Connection (2) I218-V Dave

Re: problem with MPLS and TSO/GSO

On 7/25/16 10:39 AM, Lennert Buytenhek wrote: > Hi! > > I am seeing pretty horrible TCP transmit performance (anywhere between > 1 and 10 Mb/s, on a 10 Gb/s interface) when traffic is sent out over a > route that involves MPLS labeling, and this seems to be due to an > interaction between MPLS

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

On Tue, Aug 09, 2016 at 08:40:05PM -0700, Sargun Dhillon wrote: > On Tue, Aug 09, 2016 at 08:27:32PM -0700, Alexei Starovoitov wrote: > > On Tue, Aug 09, 2016 at 06:26:37PM -0700, Sargun Dhillon wrote: > > > On Tue, Aug 09, 2016 at 06:02:34PM -0700, Alexei Starovoitov wrote: > > > > On Tue, Aug

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

On Tue, Aug 09, 2016 at 08:27:32PM -0700, Alexei Starovoitov wrote: > On Tue, Aug 09, 2016 at 06:26:37PM -0700, Sargun Dhillon wrote: > > On Tue, Aug 09, 2016 at 06:02:34PM -0700, Alexei Starovoitov wrote: > > > On Tue, Aug 09, 2016 at 05:55:26PM -0700, Sargun Dhillon wrote: > > > > On Tue, Aug

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

On Tue, Aug 09, 2016 at 06:26:37PM -0700, Sargun Dhillon wrote: > On Tue, Aug 09, 2016 at 06:02:34PM -0700, Alexei Starovoitov wrote: > > On Tue, Aug 09, 2016 at 05:55:26PM -0700, Sargun Dhillon wrote: > > > On Tue, Aug 09, 2016 at 05:23:50PM -0700, Alexei Starovoitov wrote: > > > > On Tue, Aug

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

On 08/09/2016 06:09 PM, Timur Tabi wrote: > Florian Fainelli wrote: > >> nr_frags can't be bigger than MAX_SKB_FRAGS, hence these checks all >> other drivers do against 1 + MAX_SKB_FRAGS. > > Doh, I just realized something. emac_mac_tx_buf_send() just needs to > make sure that there's enough

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

On Tue, Aug 09, 2016 at 06:02:34PM -0700, Alexei Starovoitov wrote: > On Tue, Aug 09, 2016 at 05:55:26PM -0700, Sargun Dhillon wrote: > > On Tue, Aug 09, 2016 at 05:23:50PM -0700, Alexei Starovoitov wrote: > > > On Tue, Aug 09, 2016 at 05:00:12PM -0700, Sargun Dhillon wrote: > > > > This adds a

Re: [PATCH] bonding: Allow tun-interfaces as slaves

On 2016/8/10 7:51, Jay Vosburgh wrote: > Jörn Engel wrote: > >> On Tue, Aug 09, 2016 at 12:06:36PM -0700, David Miller wrote: On Tue, Aug 09, 2016 at 09:28:45PM +0800, Ding Tianhong wrote: Simply not checking errors when setting the mac address solves the

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

Florian Fainelli wrote: nr_frags can't be bigger than MAX_SKB_FRAGS, hence these checks all other drivers do against 1 + MAX_SKB_FRAGS. Doh, I just realized something. emac_mac_tx_buf_send() just needs to make sure that there's enough room for ONE skb. For some reason I thought it had to

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

On Tue, Aug 09, 2016 at 05:55:26PM -0700, Sargun Dhillon wrote: > On Tue, Aug 09, 2016 at 05:23:50PM -0700, Alexei Starovoitov wrote: > > On Tue, Aug 09, 2016 at 05:00:12PM -0700, Sargun Dhillon wrote: > > > This adds a bpf helper that's similar to the skb_in_cgroup helper to check > > > whether

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

On Tue, Aug 09, 2016 at 05:23:50PM -0700, Alexei Starovoitov wrote: > On Tue, Aug 09, 2016 at 05:00:12PM -0700, Sargun Dhillon wrote: > > This adds a bpf helper that's similar to the skb_in_cgroup helper to check > > whether the probe is currently executing in the context of a specific > > subset

Re: [net-next v2 v2 2/2] samples/bpf: Add opensnoop example that uses current_task_in_cgroup helper

On Tue, Aug 09, 2016 at 05:00:58PM -0700, Sargun Dhillon wrote: > This example adds the trace_opensnoop BPF sample. This example program > prints all activities of files being opened for all programs in the > provided cgroupsv2 cgroup and it's descendants in the cgroupv2 hierarchy. > > It

Re: [net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

On Tue, Aug 09, 2016 at 05:00:12PM -0700, Sargun Dhillon wrote: > This adds a bpf helper that's similar to the skb_in_cgroup helper to check > whether the probe is currently executing in the context of a specific > subset of the cgroupsv2 hierarchy. It does this based on membership test > for a

Re: [PATCH v6 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

On 08/08/2016 10:38 PM, f...@48lvckh6395k16k5.yundunddos.com wrote: From: Gao Feng The PPTP is encapsulated by GRE header with that GRE_VERSION bits must contain one. But current GRE RPS needs the GRE_VERSION must be zero. So RPS does not work for PPTP traffic. In my test

Re: [PATCHv2 3/4] pci: Determine actual VPD size on first access

On Tue, 2016-08-09 at 11:12 -0700, Alexander Duyck wrote: > > The PCI spec is what essentially assumes that there is only one block. > If I am not mistaken in the case of this device the second block here > actually contains device configuration data, not actual VPD data.  The > issue here is

[net-next v2 v2 2/2] samples/bpf: Add opensnoop example that uses current_task_in_cgroup helper

This example adds the trace_opensnoop BPF sample. This example program prints all activities of files being opened for all programs in the provided cgroupsv2 cgroup and it's descendants in the cgroupv2 hierarchy. It populate a cgroups arraymap prior to execution in userspace. This means that the

[net-next v2 v2 1/2] bpf: Add bpf_current_task_in_cgroup helper

This adds a bpf helper that's similar to the skb_in_cgroup helper to check whether the probe is currently executing in the context of a specific subset of the cgroupsv2 hierarchy. It does this based on membership test for a cgroup arraymap. It is invalid to call this in an interrupt, and it'll

[net-next v2 v2 0/2] Add bpf current_task_in_cgroup helper & opensnoop example

This patchset includes a helper and an example to determine whether the probe is currently executing in the context of a specific cgroup based on a cgroup bpf map / array. The helper checks the cgroupsv2 hierarchy based on the handle in the map and if the current cgroup is equal to it, or a

Re: [PATCH] bonding: Allow tun-interfaces as slaves

Jörn Engel wrote: >On Tue, Aug 09, 2016 at 12:06:36PM -0700, David Miller wrote: >> > On Tue, Aug 09, 2016 at 09:28:45PM +0800, Ding Tianhong wrote: >> > >> > Simply not checking errors when setting the mac address solves the >> > problem for me. No new features needed.

[PATCH v3 05/13] net: ethernet: ti: cpsw: don't check slave num in runtime

No need to check const slave num in runtime for every packet, and ndev for slaves w/o ndev is anyway NULL. So remove redundant check and macro. Reviewed-by: Mugunthan V N Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 11

[PATCH v3 04/13] net: ethernet: ti: cpsw: remove clk var from priv

There is no need to hold link to clk, it's used only once while probe. Reviewed-by: Mugunthan V N Reviewed-by: Grygorii Strashko Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 10 -- 1 file

[PATCH v3 06/13] net: ethernet: ti: cpsw: create common struct to hold shared driver data

This patch simply create holder for common data and as a start moves pdev var to it. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 62 ++ 1 file changed, 39 insertions(+), 23 deletions(-) diff --git

[PATCH v3 08/13] net: ethernet: ti: cpsw: move links on h/w registers to cpsw_common

The pointers on h/w registers are common for every cpsw_private instance, so no need to hold them for every ndev. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 97 +++--- 1 file changed, 53 insertions(+), 44

[PATCH v3 09/13] net: ethernet: ti: cpsw: move cpdma resources to cpsw_common

Every net device private struct holds links to shared cpdma resources. No need to save and every time synchronize these resources per net dev. So, move it to common driver struct. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 97

[PATCH v3 03/13] net: ethernet: ti: cpsw: remove priv from cpsw_get_slave_port() parameters list

There is no need in priv here. Reviewed-by: Mugunthan V N Reviewed-by: Grygorii Strashko Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH v3 00/13] net: ethernet: ti: cpsw: split driver data and per ndev data

In dual_emac mode the driver can handle 2 network devices. Each of them can use its own private data and common data/resources. This patchset splits common driver data/resources and private per net device data. It leads to: - reduce memory usage - increase code readability - allows add a bunch of

[PATCH v3 11/13] net: ethernet: ti: cpsw: move platform data and slaves info to cpsw_common

These data are common for net devs in dual_emac mode. No need to hold it for every priv instance, so move them under cpsw_common. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 265 + 1 file changed, 137

[PATCH v3 02/13] net: ethernet: ti: cpsw: remove intr dbg msg from poll handlers

At poll handler no possibility to figure out which network device is handling packets, as cpdma channels are common for both network devices in dual_emac mode. Currently, the messages are printed only for one device, in fact, there is two. This print msg is incorrect and seems is not very useful,

[PATCH v3 01/13] net: ethernet: ti: cpsw: simplify submit routine

As second net dev is created only in case of dual_emac mode, port number can be figured out in simpler way. Also no need to pass redundant ndev struct. Reviewed-by: Mugunthan V N Reviewed-by: Grygorii Strashko Signed-off-by: Ivan Khoronzhuk

[PATCH v3 10/13] net; ethernet: ti: cpsw: move irq stuff under cpsw_common

The irq data are common for net devs in dual_emac mode. So no need to hold these data in every priv struct, move them under cpsw_common. Also delete irq_num var, as after optimization it's not needed. Correct number of irqs to 2, as anyway, driver is using only 2, at least for now. Signed-off-by:

[PATCH v3 07/13] net: ethernet: ti: cpsw: replace pdev on dev

No need to hold pdev link when only dev is needed. This allows to simplify a bunch of cpsw->pdev->dev now and farther. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 65 ++ 1 file changed, 34 insertions(+),

[PATCH v3 12/13] net: ethernet: ti: cpsw: move napi struct to cpsw_common

The napi structs are common for both net devices in dual_emac mode, In order to not hold duplicate links to them, move to cpsw_common. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 52 ++ 1 file changed,

[PATCH v3 13/13] net: ethernet: ti: cpsw: move ale, cpts and drivers params under cpsw_common

The ale, cpts, version, rx_packet_max, bus_freq, interrupt pacing parameters are common per net device that uses the same h/w. So, move them to common driver structure. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 235

Re: [PATCH v2] net: phy: micrel: Add specific suspend

From: Wenyou Yang Date: Fri, 5 Aug 2016 14:35:41 +0800 > Disable all interrupts when suspend, they will be enabled > when resume. Otherwise, the suspend/resume process will be > blocked occasionally. > > Signed-off-by: Wenyou Yang > Acked-by:

Re: [PATCH net-next v2 0/2] HFSC patches

From: Michal Soltys Date: Wed, 3 Aug 2016 00:44:53 +0200 > Changes since v1: > > - in the first patch's commit message, reference old patch using kernel.org's > historical tree (instead of using gmane) > - in the second patch we just remove variable > > Notes regarding

Re: [PATCH 2/2] ravb: add sleep PM suspend/resume support

From: Niklas Söderlund Date: Wed, 3 Aug 2016 15:56:47 +0200 > The interface would not function after the system had been woken up > after have been suspended (echo mem > /sys/power/state) cycle. The > reason for this is that all device registers have been

Re: [PATCH net-next v3 1/3] strparser: Stream parser for messages

From: Tom Herbert Date: Mon, 1 Aug 2016 14:28:47 -0700 > +/* Lower lock held */ > +void strp_parser_err(struct strparser *strp, int err, read_descriptor_t > *desc) > +{ > + desc->error = err; > + kfree_skb(strp->rx_skb_head); > + strp->rx_skb_head = NULL; > +

Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

David Ahern wrote: > On 8/9/16 1:01 AM, Erik Kline wrote: >> On 9 August 2016 at 14:20, David Miller wrote: >>> From: Lorenzo Colitti >>> Date: Tue, 9 Aug 2016 10:00:25 +0900 >>> Note that pretty much every sendmsg codepath allows other data to

Re: [PATCH net] ibmveth: Disable tx queue while changing mtu

From: Thomas Falcon Date: Tue, 9 Aug 2016 12:47:37 -0500 > If the device is running while the MTU is changed, ibmveth > is closed and the bounce buffer is freed. If a transmission > is sent before ibmveth can be reopened, ibmveth_start_xmit > tries to copy to the

Re: [PATCH v2] net: dsa: b53: constify b53_io_ops structures

From: Julia Lawall Date: Tue, 9 Aug 2016 19:09:45 +0200 > The b53_io_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > v2: Refer to the right structure in

Re: [PATCH] dm9000: Fix irq trigger type setup on non-dt platforms

From: Robert Jarzmik Date: Tue, 09 Aug 2016 19:20:44 +0200 > Sylwester Nawrocki writes: > >> Commit b5a099c67a1c36b "net: ethernet: davicom: fix devicetree irq >> resource" causes an interrupt storm after the ethernet interface >> is activated on

Re: [PATCH net-next] ppp: build ifname using unit identifier for rtnl based devices

From: Guillaume Nault Date: Tue, 9 Aug 2016 15:12:26 +0200 > Userspace programs generally need to know the name of the ppp devices > they create. Both ioctl and rtnl interfaces use the ppp sheme > to name them. But although the suffix used by the ioctl interface can > be

[PATCH 2/2] net: ethernet: renesas: sh_eth: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/renesas/sh_eth.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git

[PATCH 1/2] net: ethernet: renesas: sh_eth: use phydev from struct net_device

The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phy_dev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes ---

Re: [PATCH 1/1] bonding: fix the typo

From: zyjzyj2...@gmail.com Date: Tue, 9 Aug 2016 21:36:04 +0800 > From: Zhu Yanjun > > The message "803.ad" should be "802.3ad". > > Signed-off-by: Zhu Yanjun Applied.

Re: [PATCH net-next] net: Remove fib_local variable

From: David Ahern Date: Tue, 9 Aug 2016 06:51:06 -0700 > After commit 0ddcf43d5d4a ("ipv4: FIB Local/MAIN table collapse") > fib_local is set but not used. Remove it. > > Signed-off-by: David Ahern Applied, thanks David.

Re: [RFC PATCH v5 2/3] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

On 08/09/2016 02:34 AM, Kedareswara rao Appana wrote: > Device-tree binding documentation for xilinx gmiitorgmii converter. > > Signed-off-by: Kedareswara rao Appana > --- > Changes for v5: > ---> Fixed Indentation in the example as suggested by Michal. > Changes for v4: >

[PATCH iproute v3 0/5] iproute: ila and fou additions

Patch set includes: - Allow configuring checksum mode for ila LWT (e.g. configure checksum neutral - Configuration for performing ila translations using netfilter hook - fou encapsulation for ip6tnl and gre6 - fou listener for IPv6 v2: - Fixed coding style issues v3: - Fixed

[PATCH iproute v3 1/5] ila: Support for checksum neutral translation

Add configuration of ila LWT tunnels for checksum mode including checksum neutral translation. Signed-off-by: Tom Herbert --- ip/iproute_lwtunnel.c | 58 +-- 1 file changed, 56 insertions(+), 2 deletions(-) diff --git

[PATCH iproute v3 2/5] ila: Support for configuring ila to use netfilter hook

Signed-off-by: Tom Herbert --- ip/Makefile| 2 +- ip/ip.c| 3 +- ip/ip_common.h | 1 + ip/ipila.c | 268 + 4 files changed, 272 insertions(+), 2 deletions(-) create mode 100644 ip/ipila.c diff

[PATCH iproute v3 4/5] gre6: Support for fou encapsulation

Signed-off-by: Tom Herbert --- ip/link_gre.c | 2 +- ip/link_gre6.c | 101 + 2 files changed, 102 insertions(+), 1 deletion(-) diff --git a/ip/link_gre.c b/ip/link_gre.c index 5dc4067..3b99e56 100644 ---

[PATCH iproute v3 3/5] ip6tnl: Support for fou encapsulation

Signed-off-by: Tom Herbert --- ip/link_ip6tnl.c | 92 +++- 1 file changed, 91 insertions(+), 1 deletion(-) diff --git a/ip/link_ip6tnl.c b/ip/link_ip6tnl.c index 89861c6..59162a3 100644 --- a/ip/link_ip6tnl.c +++

[PATCH iproute v3 5/5] fou: Allowing configuring IPv6 listener

Signed-off-by: Tom Herbert --- ip/ipfou.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/ip/ipfou.c b/ip/ipfou.c index 2a6ae17..0673d11 100644 --- a/ip/ipfou.c +++ b/ip/ipfou.c @@ -25,8 +25,9 @@ static void usage(void) { -

Re: [RFC PATCH v5 1/3] net: Add mask for Control register 10Mbps speed

On 08/09/2016 02:34 AM, Kedareswara rao Appana wrote: > This patch adds mask for the Control register > 10Mbps speed. > > Signed-off-by: Kedareswara rao Appana Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH RESEND net-next 15/15] smc: proc-fs interface for smc connections

From: Ursula Braun Date: Tue, 9 Aug 2016 12:13:00 +0200 > + sock_hold(>sk); ... > +out_line: > + seq_putc(m, '\n'); > + sock_put(>sk); You hold the smc_proc_list_lock during this function's execution, therefore the table cannot change and therefore the

Re: [PATCH v1 1/1] net: phy: Add edge-rate, mac-if, read, write func to Microsemi PHYs.

On 08/08/2016 06:43 AM, Nagaraju Lakkaraju wrote: > crosemi PHYsBcc: > Subject: [PATCH v1 1/1] net: phy: Add edge-rate, mac-if, read, write func to > Reply-To: Nagaraju Lakkaraju > > Hello, > > As part of 2nd patch, Add Edge rate control, MAC Interface, Read and

Re: [PATCH RESEND net-next 13/15] smc: receive data from RMBE

From: Ursula Braun Date: Tue, 9 Aug 2016 12:12:58 +0200 > + xchg(>rx_curs_confirmed.acurs, > + smc_curs_read(conn->local_tx_ctrl.cons.acurs)); Why in the world do you need to use xchg() in all of these places? It makes no sense

Re: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

On 08/09/2016 02:34 AM, Kedareswara rao Appana wrote: > This patch adds support for gmiitorgmii converter. > > The GMII to RGMII IP core provides the Reduced Gigabit Media > Independent Interface (RGMII) between Ethernet physical media > Devices and the Gigabit Ethernet controller. This core can

[patch net-next v6 2/3] net: core: add SW stats to if_stats_msg

From: Nogah Frankel Add a nested attribute of SW stats to if_stats_msg under IFLA_STATS_LINK_SW_64. Signed-off-by: Nogah Frankel Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko ---

[patch net-next v6 0/3] return offloaded stats as default and expose original sw stats

From: Jiri Pirko The problem we try to handle is about offloaded forwarded packets which are not seen by kernel. Let me try to draw it: port1 port2 (HW stats are counted here) \ / \/

[patch net-next v6 1/3] netdevice: add SW statistics ndo

From: Nogah Frankel Stats should return the number of packets that went though a port by SW or HW. But when one has offloaded traffic, one might want to know how many packets went via slow path. So this ndo return SW statistics for packets that went via CPU, (opposed to HW

[patch net-next v6 3/3] mlxsw: spectrum: Implement SW stats ndo and expose HW stats by default

From: Nogah Frankel Add a function to get the SW statistics with an ndo. Change the default statistics ndo to return HW statistics (like the one returned by ethtool_ops). The HW stats are collected to a cache by delayed work every 1 sec. Signed-off-by: Nogah Frankel

Re: [PATCH] bonding: Allow tun-interfaces as slaves

On Tue, Aug 09, 2016 at 12:06:36PM -0700, David Miller wrote: > > On Tue, Aug 09, 2016 at 09:28:45PM +0800, Ding Tianhong wrote: > > > > Simply not checking errors when setting the mac address solves the > > problem for me. No new features needed. > > But it only works in certain modes. > > So

Re: [Patch net 1/5] net_sched: remove the leftover cleanup_a()

On 16-08-08 04:46 PM, Cong Wang wrote: After refactoring tc_action into tcf_common, we no longer need to cleanup temporary "actions" in list, they are permanently stored in the hashtable. Fixes: a85a970af265 ("net_sched: move tc_action into tcf_common") Reported-by: Jamal Hadi Salim

Re: [PATCH net v2] vti: flush x-netns xfrm cache when vti interface is removed

From: Lance Richardson Date: Tue, 9 Aug 2016 15:29:42 -0400 > When executing the script included below, the netns delete operation > hangs with the following message (repeated at 10 second intervals): > > kernel:unregister_netdevice: waiting for lo to become free. Usage

Re: [PATCH net 0/6] rxrpc: Miscellaneous fixes

/dhowells/linux-fs.git/log/?h=rxrpc-fixes > > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-fixes-20160809 Pulled, thanks David.

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

Timur Tabi wrote: I used to work on PowerPC, so I respect making things work for both endians. However, even I think that this is overkill for my driver. First, there's no way this driver will ever be used on a big-endian system. Second, I'm pretty sure there are lots of places that would need

[PATCH net v2] vti: flush x-netns xfrm cache when vti interface is removed

When executing the script included below, the netns delete operation hangs with the following message (repeated at 10 second intervals): kernel:unregister_netdevice: waiting for lo to become free. Usage count = 1 This occurs because a reference to the lo interface in the "secure" netns is

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

On 08/09/2016 11:25 AM, Timur Tabi wrote: > I need some help figuring that out. Like I said, I didn't write this > driver initially, so there are parts that I don't really understand. I > copied the above code from other drivers, but after studying your > question, I think I understand what

Re: size of data_segs_[in|out] and segs_[in|out]

On 8/9/16 3:04 PM, David Miller wrote: From: rapier Date: Tue, 9 Aug 2016 13:17:59 -0400 I cannot deny that would be a problem but conversely, those applications are currently in a position where they may be depending on inaccurate data. I'm not advocating breaking things

Re: [PATCH] bonding: Allow tun-interfaces as slaves

From: Jörn Engel Date: Tue, 9 Aug 2016 11:40:57 -0700 > On Tue, Aug 09, 2016 at 11:21:31AM -0700, Jay Vosburgh wrote: >> The balance-rr mode (as well as the -xor mode) is designed to >> interoperate with a Cisco Etherchannel-style static link aggregation, >> which

Re: [PATCH] bonding: Allow tun-interfaces as slaves

From: Jörn Engel Date: Tue, 9 Aug 2016 11:08:30 -0700 > On Tue, Aug 09, 2016 at 09:28:45PM +0800, Ding Tianhong wrote: >> >> I think if the bonding dev has to support L3 virtual device, we need to add >> new bond features to distinguish the dev and make the >> bond xmit

Re: size of data_segs_[in|out] and segs_[in|out]

From: rapier Date: Tue, 9 Aug 2016 13:17:59 -0400 > I cannot deny that would be a problem but conversely, those > applications are currently in a position where they may be depending > on inaccurate data. I'm not advocating breaking things for the sake of > breaking things but my

RE: [Intel-wired-lan] e1000e: PHY cann't be initialized correctly on some I218 controllers

> -Original Message- > From: Avargil, Raanan > Sent: Tuesday, August 9, 2016 8:11 AM > To: Denis Turischev ; intel-wired- > l...@lists.osuosl.org; Brown, Aaron F ; Kirsher, > Jeffrey T > Cc:

Re: [PATCH] bonding: Allow tun-interfaces as slaves

On Tue, Aug 09, 2016 at 11:21:31AM -0700, Jay Vosburgh wrote: > Jörn Engel wrote: > >On Tue, Aug 09, 2016 at 10:18:41AM +0800, Ding Tianhong wrote: > >> > >> I don't understand your problem clearly, can you explain more about how > >> the 00503b6f702e break tun-interfaces

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

On Tue, Aug 9, 2016 at 1:25 PM, Timur Tabi wrote: > Lino Sanfilippo wrote: > >>> +/* Fill up transmit descriptors */ >>> +static void emac_tx_fill_tpd(struct emac_adapter *adpt, >>> +struct emac_tx_queue *tx_q, struct sk_buff >>> *skb, >>> +

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

Lino Sanfilippo wrote: +/* Fill up transmit descriptors */ +static void emac_tx_fill_tpd(struct emac_adapter *adpt, +struct emac_tx_queue *tx_q, struct sk_buff *skb, +struct emac_tpd *tpd) +{ + u16 nr_frags =

Re: [PATCH] bonding: Allow tun-interfaces as slaves

Jörn Engel wrote: >Hello Tianhong! > >On Tue, Aug 09, 2016 at 10:18:41AM +0800, Ding Tianhong wrote: >> >> I don't understand your problem clearly, can you explain more about how the >> 00503b6f702e break tun-interfaces >> and we will try to fix it. > >Here is a trivial

4.7.0: RCU stall in nf_conntrack

Hi, I just experienced network hangup with 4.7.0, it happened shortly after resume from hibernate: [201988.443552] INFO: rcu_preempt detected stalls on CPUs/tasks: [201988.443556] Tasks blocked on level-0 rcu_node (CPUs 0-3): P14563 [201988.443557] (detected by 3, t=18002

Re: [PATCHv2 3/4] pci: Determine actual VPD size on first access

On Tue, Aug 9, 2016 at 5:54 AM, Alexey Kardashevskiy wrote: > On 10/02/16 08:04, Bjorn Helgaas wrote: >> On Wed, Jan 13, 2016 at 12:25:34PM +0100, Hannes Reinecke wrote: >>> PCI-2.2 VPD entries have a maximum size of 32k, but might actually >>> be smaller than that. To figure out

Re: size of data_segs_[in|out] and segs_[in|out]

On 8/8/16 7:02 PM, David Miller wrote: From: rapier Date: Mon, 8 Aug 2016 18:02:29 -0400 As such, would it be feasible to define these instruments as 64bit instead of 32bit? If so, a cursory look at the code seems to indicate that this would only require a change in the

Re: [PATCH] bonding: Allow tun-interfaces as slaves

On Tue, Aug 09, 2016 at 09:28:45PM +0800, Ding Tianhong wrote: > > This patch is a simple solution for this problem, but I don't think it is the > right solution, the bond is a virtual device base on L2, > if the slave has no mac address, it will break the design principle, so we > need to

Re: [Patch net 5/5] net_sched: convert tcf_exts from list to flex_array

On Tue, Aug 9, 2016 at 1:03 AM, Amir Vadai wrote: > >> -#define tc_single_action(_exts) \ >> - (list_is_singular(&(_exts)->actions)) >> +#define tc_no_actions(_exts) (&(_exts)->nr_actions == 0) >> +#define tc_single_action(_exts) (&(_exts)->nr_actions == 1) > > Should

[PATCH net] ibmveth: Disable tx queue while changing mtu

If the device is running while the MTU is changed, ibmveth is closed and the bounce buffer is freed. If a transmission is sent before ibmveth can be reopened, ibmveth_start_xmit tries to copy to the null bounce buffer, leading to a kernel oops. The proposed solution disables the tx queue until

Re: [PATCH v2] net: dsa: b53: constify b53_io_ops structures

On 08/09/2016 10:09 AM, Julia Lawall wrote: > The b53_io_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Acked-by: Florian Fainelli -- Florian

Re: [PATCH] net: dsa: b53: constify xfrm_replay structures

On Tue, 9 Aug 2016, Florian Fainelli wrote: > On 08/09/2016 09:58 AM, Julia Lawall wrote: > > The xfrm_replay structures are never modified, so declare them as const. > > You mean b53_io_ops here, right? Oops. I sent a v2. julia > Other than that LTGM, but this will > have to wait for

Re: [PATCH] dm9000: Fix irq trigger type setup on non-dt platforms

Sylwester Nawrocki writes: > Commit b5a099c67a1c36b "net: ethernet: davicom: fix devicetree irq > resource" causes an interrupt storm after the ethernet interface > is activated on S3C24XX platform (ARM non-dt), due to the interrupt > trigger type not being set properly.

[PATCH v2] net: dsa: b53: constify b53_io_ops structures

The b53_io_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- v2: Refer to the right structure in the commit message drivers/net/dsa/b53/b53_common.c |3 ++- drivers/net/dsa/b53/b53_mdio.c

Re: [PATCH] net: dsa: b53: constify xfrm_replay structures

On 08/09/2016 10:23 AM, Florian Fainelli wrote: > On 08/09/2016 09:58 AM, Julia Lawall wrote: >> The xfrm_replay structures are never modified, so declare them as const. > > You mean b53_io_ops here, right? Other than that LTGM, but this will > have to wait for "net"next to re_open since this is

Re: [PATCH] net: dsa: b53: constify xfrm_replay structures

On 08/09/2016 09:58 AM, Julia Lawall wrote: > The xfrm_replay structures are never modified, so declare them as const. You mean b53_io_ops here, right? Other than that LTGM, but this will have to wait for "net"next to re_open since this is more of a cleanup than bugfix. Thanks! -- Florian

[PATCH] net: dsa: b53: constify xfrm_replay structures

The xfrm_replay structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/net/dsa/b53/b53_common.c |3 ++- drivers/net/dsa/b53/b53_mdio.c |2 +- drivers/net/dsa/b53/b53_mmap.c |2 +-

RE: [RFC PATCH 2/3] net: macb: Add support for 1588 for Zynq Ultrascale+ MPSoC

Hi Nicolas, 1588 implementation in cadence GEM IP we have in Zynq Ultascale+ MPSoC is Different to the one in Zynq SOC. In earlier version, all timestamp values will be stored in registers and there is no specific Mechanism to distinguish the received ethernet frame that contains time stamp

[PATCH] xfrm: constify xfrm_replay structures

The xfrm_replay structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- include/net/xfrm.h |2 +- net/xfrm/xfrm_replay.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [RFC PATCH 2/3] net: macb: Add support for 1588 for Zynq Ultrascale+ MPSoC

Le 21/09/2015 à 19:49, Harini Katakam a écrit : > On Fri, Sep 11, 2015 at 1:27 PM, Harini Katakam > wrote: >> Cadence GEM in Zynq Ultrascale+ MPSoC supports 1588 and provides a >> 102 bit time counter with 48 bits for seconds, 30 bits for nsecs and >> 24 bits for

[PATCH net 0/6] rxrpc: Miscellaneous fixes

to deal with. (*) Fix a missing skb free. --- The patches can be found here also: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-fixes-20160809

[PATCH net 2/6] rxrpc: Need to flag call as being released on connect failure

If rxrpc_new_client_call() fails to make a connection, the call record that it allocated needs to be marked as RXRPC_CALL_RELEASED before it is passed to rxrpc_put_call() to indicate that it no longer has any attachment to the AF_RXRPC socket. Without this, an assertion failure may occur at:

[PATCH net 1/6] rxrpc: fix uninitialized pointer dereference in debug code

From: Arnd Bergmann A newly added bugfix caused an uninitialized variable to be used for printing debug output. This is harmless as long as the debug setting is disabled, but otherwise leads to an immediate crash. gcc warns about this when -Wmaybe-uninitialized is enabled:

  1   2   >