Re: [PATCH v4 1/2] libxt_hashlimit: Prepare libxt_hashlimit.c for revision 2

2016-10-03 Thread Pablo Neira Ayuso
On Mon, Sep 26, 2016 at 03:08:17PM -0400, Vishwanath Pai wrote: > I am planning to add a revision 2 for the hashlimit xtables module to > support higher packets per second rates. This patch renames all the > functions and variables related to revision 1 by adding _v1 at the > end of the names. App

Re: [PATCH v4 2/2] libxt_hashlimit: Create revision 2 of xt_hashlimit to support higher pps rates

2016-10-03 Thread Pablo Neira Ayuso
On Mon, Sep 26, 2016 at 03:08:52PM -0400, Vishwanath Pai wrote: > libxt_hashlimit: Create revision 2 of xt_hashlimit to support higher pps > rates > > Create a new revision for the hashlimit iptables extension module. Rev 2 > will support higher pps of upto 1 million, Version 1 supports only 10k.

Re: [PATCH v2] phy: micrel.c: Enable ksz9031 energy-detect power-down mode

2016-10-03 Thread Andrew Lunn
On Tue, Oct 04, 2016 at 07:52:04AM +0200, Mike Looijmans wrote: > Set bit 0 in register 1C.23 to enable the EDPD feature of the > KSZ9031 PHY. This reduces power consumption when the link is > down. > > Signed-off-by: Mike Looijmans Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v5 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-03 Thread Andrew Lunn
On Tue, Oct 04, 2016 at 12:48:59AM -0400, David Miller wrote: > From: Raju Lakkaraju > Date: Mon, 3 Oct 2016 12:53:13 +0530 > > > From: Raju Lakkaraju > > > > Edge-rate: > > As system and networking speeds increase, a signal's output transition, > > also know as the edge rate or slew rate (V/ns

Re: [PATCH] netfilter: fix namespace handling in nf_log_proc_dostring

2016-10-03 Thread Pablo Neira Ayuso
On Sun, Sep 18, 2016 at 09:40:55PM +0200, Jann Horn wrote: > nf_log_proc_dostring() used current's network namespace instead of the one > corresponding to the sysctl file the write was performed on. Because the > permission check happens at open time and the nf_log files in namespaces > are accessi

Re: [PATCH] ipv6 addrconf: disallow rtr_solicits < -1

2016-10-03 Thread Maciej Żenczykowski
> Please remove the const qualifier and the casts to be consistent > with how we handle this elsewhere. > > Thanks. I can of course trivially make that change. But: (on net-next/master) git grep 'extra[12].*=.*\(void *[*]\)' currently finds 45 matches, and this patch adds a 46th. In particular

Re: [PATCH net] Panic when tc_lookup_action_n finds a partially initialized action.

2016-10-03 Thread Krister Johansen
Hi Cong, Thanks for the feedback. On Mon, Oct 03, 2016 at 11:22:33AM -0700, Cong Wang wrote: > On Sat, Oct 1, 2016 at 8:13 PM, Krister Johansen > wrote: > > A tc_action_ops structure is visibile as soon as it is placed in the > > act_base list. When tcf_regsiter_action adds an item to this list

Re: [PATCH net] Panic when tc_lookup_action_n finds a partially initialized action.

2016-10-03 Thread Krister Johansen
On Sun, Oct 02, 2016 at 09:18:06PM -0400, Jamal Hadi Salim wrote: > On 16-10-01 11:13 PM, Krister Johansen wrote: > >A tc_action_ops structure is visibile as soon as it is placed in the > >act_base list. When tcf_regsiter_action adds an item to this list and > >drops act_mod_lock, registration is

Re: [PATCH v2 net-next 0/8] net/ncsi: NCSI Improvment and bug fixes

2016-10-03 Thread David Miller
From: Gavin Shan Date: Tue, 4 Oct 2016 11:25:46 +1100 > This series of patches improves NCSI stack according to the comments > I received after the NCSI code was merged to 4.8.rc1: > > * PATCH[1/8] fixes the build warning caused by xchg() with ia64-linux-gcc. > The atomic operations are r

Re: [PATCH net] Add netdev all_adj_list refcnt propagation to fix panic

2016-10-03 Thread David Miller
From: Andrew Collins Date: Mon, 3 Oct 2016 13:43:02 -0600 > This is a respin of a patch to fix a relatively easily reproducible kernel > panic related to the all_adj_list handling for netdevs in recent kernels. > > The following sequence of commands will reproduce the issue: > > ip link add lin

[PATCH v2] phy: micrel.c: Enable ksz9031 energy-detect power-down mode

2016-10-03 Thread Mike Looijmans
Set bit 0 in register 1C.23 to enable the EDPD feature of the KSZ9031 PHY. This reduces power consumption when the link is down. Signed-off-by: Mike Looijmans --- v2: Unconditionally enable EDPD mode drivers/net/phy/micrel.c | 21 + 1 file changed, 21 insertions(+) diff --g

Re: [PATCH net-next 0/7] xen-netback: guest rx side refactor

2016-10-03 Thread David Miller
From: Paul Durrant Date: Mon, 3 Oct 2016 08:31:05 +0100 > This series refactors the guest rx side of xen-netback: > > - The code is moved into its own source module. > > - The prefix variant of GSO handling is retired (since it is no longer > in common use, and alternatives exist). > > - The

Re: [PATCH v5 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-03 Thread David Miller
From: Raju Lakkaraju Date: Mon, 3 Oct 2016 12:53:13 +0530 > From: Raju Lakkaraju > > Edge-rate: > As system and networking speeds increase, a signal's output transition, > also know as the edge rate or slew rate (V/ns), takes on greater importance > because high-speed signals come with a price.

Re: [PATCH] ipv6 addrconf: disallow rtr_solicits < -1

2016-10-03 Thread David Miller
From: Maciej Żenczykowski Date: Sun, 2 Oct 2016 23:41:57 -0700 > From: Maciej Żenczykowski > > This disallows setting /proc/sys/net/ipv6/conf/*/router_solicitations > to values below -1. > > -1 continues to mean an unlimited number of retransmits. > > Note: this depends on 'ipv6 addrconf: re

Re: [PATCH] vmxnet3: Wake queue from reset work

2016-10-03 Thread David Miller
From: Benjamin Poirier Date: Mon, 3 Oct 2016 10:47:50 +0800 > vmxnet3_reset_work() expects tx queues to be stopped (via > vmxnet3_quiesce_dev -> netif_tx_disable). However, this races with the > netif_wake_queue() call in netif_tx_timeout() such that the driver's > start_xmit routine may be call

Re: [net-next] i40e: avoid NULL pointer dereference and recursive errors on early PCI error

2016-10-03 Thread David Miller
From: Jeff Kirsher Date: Mon, 3 Oct 2016 00:31:12 -0700 > From: Guilherme G Piccoli > > Although rare, it's possible to hit PCI error early on device > probe, meaning possibly some structs are not entirely initialized, > and some might even be completely uninitialized, leading to NULL > pointe

Re: [net-next 0/2][pull request] 100GbE Intel Wired LAN Driver Updates 2016-10-02

2016-10-03 Thread David Miller
From: Jeff Kirsher Date: Sun, 2 Oct 2016 23:40:41 -0700 > This series contains updates to fm10k only. > > Jake fixes an issue where PTP applications requesting software timestamps > may complain that the requested mode is not supported, so add a generic > callback for those drivers that have so

Re: [net-next 0/3][pull request] 40GbE Intel Wired LAN Driver Updates 2016-10-03

2016-10-03 Thread David Miller
From: Jeff Kirsher Date: Mon, 3 Oct 2016 19:25:00 -0700 > This series contains fixes to i40e only. > > Stefan Assmann provides the changes in this series to resolve an issue > where when we run out of MSIx vectors, iWARP gets disabled automatically. > First adds a check for "no vectors left" du

Re: [PATCH net-next 0/7] qed*: Add qedr infrastructure support

2016-10-03 Thread David Miller
From: Yuval Mintz Date: Sat, 1 Oct 2016 21:59:54 +0300 > In the last couple of weeks we've been sending RFCs for the qedr > driver - the RoCE driver for QLogic FastLinQ 4 line of adapters. > Latest RFC can be found at [1]. > > At Doug's advice [2], we've decided to split the series into two:

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-10-03 Thread R. Parameswaran
Hi James, Please see inline, thanks for the reply: On Sat, 1 Oct 2016, James Chapman wrote: > On 30/09/16 03:39, R. Parameswaran wrote: > > > >>> + /* Adjust MTU, factor overhead - underlay L3 hdr, overlay L2 hdr*/ > >>> + if (tunnel->sock->sk_family == AF_INET) > >>> + overhead += (E

[net-next 0/3][pull request] 40GbE Intel Wired LAN Driver Updates 2016-10-03

2016-10-03 Thread Jeff Kirsher
This series contains fixes to i40e only. Stefan Assmann provides the changes in this series to resolve an issue where when we run out of MSIx vectors, iWARP gets disabled automatically. First adds a check for "no vectors left" during MSIx vector allocation for VMDq, which will prevent more vectors

[net-next 2/3] i40e: fix MSI-X vector redistribution if hw limit is reached

2016-10-03 Thread Jeff Kirsher
From: Stefan Assmann The driver allocates 1 vector per CPU thread and the current hardware limit for vectors is 129 per PF. On systems with 128 or more threads this currently means all vectors are used by the PF leaving no room for additional features like VMDq, iWARP, etc... The code that should

[net-next 3/3] i40e: fix sideband flow director vector allocation

2016-10-03 Thread Jeff Kirsher
From: Stefan Assmann Currently if the MSI-X vector limit is reached the sideband flow director gets disabled. A bit too early to make that decision, as vectors may get re-distributed. So move the check further back. Signed-off-by: Stefan Assmann Tested-by: Andrew Bowers Signed-off-by: Jeff Kir

[net-next 1/3] i40e: check if vectors are already depleted when doing VMDq allocation

2016-10-03 Thread Jeff Kirsher
From: Stefan Assmann During MSI-X vector allocation for VMDq, a check for "no vectors left" was missing, add it. This prevents more vectors to be allocated than available. Signed-off-by: Stefan Assmann Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i

Re: [PATCH net] vti6: flush x-netns xfrm cache when vti interface is removed

2016-10-03 Thread Lance Richardson
> From: "Nicolas Dichtel" > To: da...@davemloft.net, "steffen klassert" > Cc: netdev@vger.kernel.org, "Nicolas Dichtel" , > "Lance Richardson" > Sent: Friday, September 30, 2016 5:11:07 AM > Subject: [PATCH net] vti6: flush x-netns xfrm cache when vti interface is > removed > > This is the sa

Re: [PATCH] ptp: Fix resource leak in case of error

2016-10-03 Thread David Miller
From: Christophe JAILLET Date: Sun, 2 Oct 2016 09:04:16 +0200 > A call to 'ida_simple_remove()' is missing in the error handling path. > > This as been spotted with the following coccinelle script which tries to > detect missing 'ida_simple_remove()' call in error handling paths. ... > Signed-

Re: [PATCH -next] net: qcom/emac: fix return value check in emac_sgmii_config()

2016-10-03 Thread David Miller
From: Wei Yongjun Date: Sat, 1 Oct 2016 09:12:29 + > From: Wei Yongjun > > In case of error, the function ioremap() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check > should be replaced with NULL test. > > Also add check for return value of platform_get_re

Re: [PATCH v3] net: hns: mark symbols static where possible

2016-10-03 Thread David Miller
From: Baoyou Xie Date: Sat, 1 Oct 2016 16:15:26 +0800 > We get a few warnings when building kernel with W=1: ... > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'st

Re: [PATCH] af_unix: fix garbage collect vs. MSG_PEEK

2016-10-03 Thread David Miller
From: Miklos Szeredi Date: Thu, 29 Sep 2016 14:09:14 +0200 > @@ -1550,6 +1550,17 @@ static int unix_attach_fds(struct scm_cookie *scm, > struct sk_buff *skb) > return max_level; > } > > +static void unix_peek_fds(struct scm_cookie *scm, struct sk_buff *skb) > +{ > + scm->fp = scm_fp

Re: [PATCH v3 net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-10-03 Thread David Miller
From: Shmulik Ladkani Date: Thu, 29 Sep 2016 14:03:32 +0300 > skb2->skb_iif = skb->dev->ifindex; > skb2->dev = dev; > - err = dev_queue_xmit(skb2); > + if (tcf_mirred_act_direction(m_eaction) & AT_EGRESS) > + err = dev_queue_xmit(skb2); > + else > +

Re: [PATCH v3 net 1/2] net/sched: act_vlan: Push skb->data to mac_header prior calling skb_vlan_*() functions

2016-10-03 Thread David Miller
From: Shmulik Ladkani Date: Thu, 29 Sep 2016 12:10:40 +0300 > Generic skb_vlan_push/skb_vlan_pop functions don't properly handle the > case where the input skb data pointer does not point at the mac header: > > - They're doing push/pop, but fail to properly unwind data back to its > original l

Re: [PATCH v3 net 2/2] net: skbuff: Limit skb_vlan_pop/push() to expect skb->data at mac header

2016-10-03 Thread David Miller
From: Shmulik Ladkani Date: Thu, 29 Sep 2016 12:10:41 +0300 > skb_vlan_pop/push were too generic, trying to support the cases where > skb->data is at mac header, and cases where skb->data is arbitrarily > elsewhere. > > Supporting an arbitrary skb->data was complex and bogus: > - It failed to u

Re: linux-next: Tree for Sep 27

2016-10-03 Thread Sergey Senozhatsky
On (09/27/16 19:03), Sergey Senozhatsky wrote: > Hello, > > On (09/27/16 16:40), Stephen Rothwell wrote: > > > > Changes since 20160923: > > > > seems that commit e3b37f11e6e4e6b6 ("netfilter: replace list_head with > single linked list") breaks the build on !CONFIG_NETFILTER_INGRESS systems >

[PATCH v2 net-next 6/8] net/ncsi: Rework the channel monitoring

2016-10-03 Thread Gavin Shan
The original NCSI channel monitoring was implemented based on a backoff algorithm: the GLS response should be received in the specified interval. Otherwise, the channel is regarded as dead and failover should be taken if current channel is an active one. There are several problems in the implementa

[PATCH v2 net-next 0/8] net/ncsi: NCSI Improvment and bug fixes

2016-10-03 Thread Gavin Shan
This series of patches improves NCSI stack according to the comments I received after the NCSI code was merged to 4.8.rc1: * PATCH[1/8] fixes the build warning caused by xchg() with ia64-linux-gcc. The atomic operations are removed. The NCSI's lock should be taken when reading or updatin

[PATCH v2 net-next 4/8] net/ncsi: Rework request index allocation

2016-10-03 Thread Gavin Shan
The NCSI request index (struct ncsi_request::id) is put into instance ID (IID) field while sending NCSI command packet. It was designed the available IDs are given in round-robin fashion. @ndp->request_id was introduced to represent the next available ID, but it has been used as number of successiv

[PATCH v2 net-next 2/8] net/ncsi: Introduce NCSI_RESERVED_CHANNEL

2016-10-03 Thread Gavin Shan
This defines NCSI_RESERVED_CHANNEL as the reserved NCSI channel ID (0x1f). No logical changes introduced. Signed-off-by: Gavin Shan Reviewed-by: Joel Stanley --- net/ncsi/internal.h| 1 + net/ncsi/ncsi-manage.c | 14 +++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --g

[PATCH v2 net-next 8/8] net/faraday: Stop NCSI device on shutdown

2016-10-03 Thread Gavin Shan
This stops NCSI device when closing the network device so that the NCSI device can be reenabled later. Signed-off-by: Gavin Shan Reviewed-by: Joel Stanley --- drivers/net/ethernet/faraday/ftgmac100.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/faraday/ftgmac100.c

[PATCH v2 net-next 5/8] net/ncsi: Allow to extend NCSI request properties

2016-10-03 Thread Gavin Shan
There is only one NCSI request property for now: the response for the sent command need drive the workqueue or not. So we had one field (@driven) for the purpose. We lost the flexibility to extend NCSI request properties. This replaces @driven with @flags and @req_flags in NCSI request and NCSI co

[PATCH v2 net-next 1/8] net/ncsi: Avoid unused-value build warning from ia64-linux-gcc

2016-10-03 Thread Gavin Shan
xchg() is used to set NCSI channel's state in order for consistent access to the state. xchg()'s return value should be used. Otherwise, one build warning will be raised (with -Wunused-value) as below message indicates. It is reported by ia64-linux-gcc (GCC) 4.9.0. net/ncsi/ncsi-manage.c: In func

[PATCH v2 net-next 3/8] net/ncsi: Don't probe on the reserved channel ID (0x1f)

2016-10-03 Thread Gavin Shan
We needn't send CIS (Clear Initial State) command to the NCSI reserved channel (0x1f) in the enumeration. We shouldn't receive a valid response from CIS on NCSI channel 0x1f. Signed-off-by: Gavin Shan Reviewed-by: Joel Stanley --- net/ncsi/ncsi-manage.c | 4 ++-- 1 file changed, 2 insertions(+)

[PATCH v2 net-next 7/8] net/ncsi: Introduce ncsi_stop_dev()

2016-10-03 Thread Gavin Shan
This introduces ncsi_stop_dev(), as counterpart to ncsi_start_dev(), to stop the NCSI device so that it can be reenabled in future. This API should be called when the network device driver is going to shutdown the device. There are 3 things done in the function: Stop the channel monitoring; Reset c

Re: [PATCH v2 net-next 0/2] bnx2x: page allocation failure

2016-10-03 Thread David Miller
From: "Baron, Jason" Date: Mon, 3 Oct 2016 20:24:32 + > Or should I just send the incremental at this point? Incremental is required at this point.

Re: [v2] mwifiex: report wakeup for wowlan

2016-10-03 Thread Rajat Jain
Hello Kalie, On Mon, Oct 3, 2016 at 6:04 AM, Kalle Valo wrote: > Rajat Jain wrote: >> Enable notifying wakeup source to the PM core in case of >> a wake on wireless LAN event. >> >> Signed-off-by: Wei-Ning Huang >> Signed-off-by: Rajat Jain >> Tested-by: Wei-Ning Huang >> Reviewed-by: Eric Ca

Re: pull-request: mac80211-next 2016-09-30

2016-10-03 Thread David Miller
From: Johannes Berg Date: Mon, 03 Oct 2016 12:07:00 +0200 > On Mon, 2016-10-03 at 01:54 -0400, David Miller wrote: >>  >> Could you please look into this and send me a new pull request with >> the conflicts resolved? >> > > Sure, will do (tomorrow, we have a holiday today). > > Would you prefe

Re: [RFC v3 03/22] bpf,landlock: Add a new arraymap type to deal with (Landlock) handles

2016-10-03 Thread Kees Cook
On Wed, Sep 14, 2016 at 12:23 AM, Mickaël Salaün wrote: > This new arraymap looks like a set and brings new properties: > * strong typing of entries: the eBPF functions get the array type of > elements instead of CONST_PTR_TO_MAP (e.g. > CONST_PTR_TO_LANDLOCK_HANDLE_FS); > * force sequential f

Re: [RFC v3 11/22] seccomp,landlock: Handle Landlock hooks per process hierarchy

2016-10-03 Thread Kees Cook
On Wed, Sep 14, 2016 at 3:34 PM, Mickaël Salaün wrote: > > On 14/09/2016 20:43, Andy Lutomirski wrote: >> On Wed, Sep 14, 2016 at 12:24 AM, Mickaël Salaün wrote: >>> A Landlock program will be triggered according to its subtype/origin >>> bitfield. The LANDLOCK_FLAG_ORIGIN_SECCOMP value will trig

Re: [RFC v3 19/22] landlock: Add interrupted origin

2016-10-03 Thread Kees Cook
On Wed, Sep 14, 2016 at 6:19 PM, Andy Lutomirski wrote: > On Wed, Sep 14, 2016 at 3:14 PM, Mickaël Salaün wrote: >> >> On 14/09/2016 20:29, Andy Lutomirski wrote: >>> On Wed, Sep 14, 2016 at 12:24 AM, Mickaël Salaün wrote: This third origin of hook call should cover all possible trigger pat

Re: [RFC v3 16/22] bpf/cgroup,landlock: Handle Landlock hooks per cgroup

2016-10-03 Thread Kees Cook
On Wed, Sep 14, 2016 at 12:24 AM, Mickaël Salaün wrote: > This allows to add new eBPF programs to Landlock hooks dedicated to a > cgroup thanks to the BPF_PROG_ATTACH command. Like for socket eBPF > programs, the Landlock hooks attached to a cgroup are propagated to the > nested cgroups. However,

Re: [RFC v3 07/22] landlock: Handle file comparisons

2016-10-03 Thread Kees Cook
On Wed, Sep 14, 2016 at 12:24 AM, Mickaël Salaün wrote: > Add eBPF functions to compare file system access with a Landlock file > system handle: > * bpf_landlock_cmp_fs_prop_with_struct_file(prop, map, map_op, file) > This function allows to compare the dentry, inode, device or mount > point o

Re: [RFC v2 00/10] Landlock LSM: Unprivileged sandboxing

2016-10-03 Thread Kees Cook
On Tue, Sep 20, 2016 at 10:08 AM, Mickaël Salaün wrote: > > On 15/09/2016 11:19, Pavel Machek wrote: >> Hi! >> >>> This series is a proof of concept to fill some missing part of seccomp as >>> the >>> ability to check syscall argument pointers or creating more dynamic security >>> policies. The g

Re: [PATCH v2 net-next 0/2] bnx2x: page allocation failure

2016-10-03 Thread Baron, Jason
> On Sep 26, 2016, at 9:46 AM, David Miller wrote: > > From: Jason Baron > Date: Thu, 22 Sep 2016 17:12:24 -0400 > >> While configuring ~500 multicast addrs, we ran into high order >> page allocation failures. They don't need to be high order, and >> thus I'm proposing to split them into at m

Re: [PATCH] ipv6 addrconf: disallow rtr_solicits < -1

2016-10-03 Thread Cong Wang
On Mon, Oct 3, 2016 at 1:01 PM, Maciej Żenczykowski wrote: > It is if you don't want build warnings about discarding 'const' qualifier. Why do you need to mark it as const? We don't do this in sysctl_net_ipv4.c.

Re: [PATCH] ipv6 addrconf: disallow rtr_solicits < -1

2016-10-03 Thread Maciej Żenczykowski
It is if you don't want build warnings about discarding 'const' qualifier.

Re: net: vrf: Handle ipv6 multicast and link-local addresses

2016-10-03 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 03, 2016 at 10:27:44PM +0200, Geert Uytterhoeven escreveu: > On Wed, Aug 3, 2016 at 10:11 PM, David Ahern wrote: > > On 8/3/16 1:57 PM, Geert Uytterhoeven wrote: > >>> +static void vrf_ip6_input_dst(struct sk_buff *skb, struct net_device > >>> *vrf_dev, > >>> > +

[PATCH net] Add netdev all_adj_list refcnt propagation to fix panic

2016-10-03 Thread Andrew Collins
This is a respin of a patch to fix a relatively easily reproducible kernel panic related to the all_adj_list handling for netdevs in recent kernels. The following sequence of commands will reproduce the issue: ip link add link eth0 name eth0.100 type vlan id 100 ip link add link eth0 name eth0.20

Re: [PATCH] ipv6 addrconf: disallow rtr_solicits < -1

2016-10-03 Thread Cong Wang
On Sun, Oct 2, 2016 at 11:41 PM, Maciej Żenczykowski wrote: > +static const int minus_one = -1; > static const int one = 1; > static const int two_five_five = 255; > > @@ -5789,7 +5790,8 @@ static const struct ctl_table addrconf_sysctl[] = { > .data = &ipv6_devconf.rtr_

Re: [PATCH v3 net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-10-03 Thread Cong Wang
On Thu, Sep 29, 2016 at 4:03 AM, Shmulik Ladkani wrote: > skb2->skb_iif = skb->dev->ifindex; > skb2->dev = dev; > - err = dev_queue_xmit(skb2); > + if (tcf_mirred_act_direction(m_eaction) & AT_EGRESS) > + err = dev_queue_xmit(skb2); > + else > +

Re: [PATCH -next] net: qcom/emac: fix return value check in emac_sgmii_config()

2016-10-03 Thread Timur Tabi
Wei Yongjun wrote: From: Wei Yongjun In case of error, the function ioremap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Also add check for return value of platform_get_resource(). Fixes: 54e19bc74f33 ("net: qcom/emac: do

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Robert Jarzmik
Mark Rutland writes: > On Mon, Oct 03, 2016 at 06:11:23PM +0200, Robert Jarzmik wrote: >> Mark Rutland writes: >> >> reg-u16-align4 tells that a specific hardware doesn't support 16 bit writes >> not >> being 32 bits aligned, or said differently that a "store" 16 bits wide on an >> address of

Re: [PATCH net-next 2/3] net: ethernet: mediatek: get hw lro capability by the chip id instead of by the dtsi

2016-10-03 Thread John Crispin
Hi Nelson, comment inline On 03/10/2016 09:18, Nelson Chang wrote: > Because hw lro started to be supported from MT7623, the proper way to check if > the feature is capable is to judge by the chip id instead of by the dtsi. > > Signed-off-by: Nelson Chang > --- > drivers/net/ethernet/mediatek/

Re: [PATCH net-next 1/3] net: ethernet: mediatek: get the chip id by ETHDMASYS registers

2016-10-03 Thread John Crispin
Hi Nelson, comments inline On 03/10/2016 09:18, Nelson Chang wrote: > The driver gets the chip id by ETHSYS_CHIPID0_3/ETHSYS_CHIPID4_7 registers > in mtk_probe(). > > Signed-off-by: Nelson Chang > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 27 +++ > drivers/net

Re: [PATCH 3/3] net: fec: align IP header in hardware

2016-10-03 Thread Eric Nelson
Hi Russell, On 10/01/2016 09:52 PM, Russell King - ARM Linux wrote: > On Fri, Sep 30, 2016 at 07:16:12AM -0700, Eric Nelson wrote: >> On ARM, the CPU can't handle misaligned memory cycles without >> taking an alignment fault and NET_IP_ALIGN is set to 2. > > Let's get this right... With Linux on

Re: [PATCH net] Panic when tc_lookup_action_n finds a partially initialized action.

2016-10-03 Thread Cong Wang
On Sat, Oct 1, 2016 at 8:13 PM, Krister Johansen wrote: > A tc_action_ops structure is visibile as soon as it is placed in the > act_base list. When tcf_regsiter_action adds an item to this list and > drops act_mod_lock, registration is not complete until > register_pernet_subsys() finishes. Hmm

Re: [PATCH net-next] openvswitch: correctly fragment packet with mpls headers

2016-10-03 Thread Pravin Shelar
On Mon, Oct 3, 2016 at 9:33 AM, Jiri Benc wrote: > If mpls headers were pushed to a defragmented packet, the refragmentation no > longer works correctly after 48d2ab609b6b ("net: mpls: Fixups for GSO"). The > network header has to be shifted after the mpls headers for the > fragmentation and resto

Re: [PATCH 2/7] ethtool: avoid resource leak of strings in do_gprivflags

2016-10-03 Thread Jarod Wilson
On Fri, Sep 30, 2016 at 03:56:16PM -0400, John W. Linville wrote: > Coverity issue: 1363119 > Fixes: e1ee596326ae ("Add support for querying and setting private flags") > > Signed-off-by: John W. Linville > --- > ethtool.c | 18 +- > 1 file changed, 13 insertions(+), 5 deletions(

Re: [PATCH v2 net-next 1/2] net: centralize net_device min/max MTU checking

2016-10-03 Thread Jarod Wilson
On Sun, Oct 02, 2016 at 10:43:22PM -0400, David Miller wrote: > From: Jakub Sitnicki > Date: Fri, 30 Sep 2016 11:37:24 +0200 > > > On Wed, Sep 28, 2016 at 10:20 PM GMT, Jarod Wilson wrote: > >> While looking into an MTU issue with sfc, I started noticing that almost > >> every NIC driver with an

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Mark Rutland
On Mon, Oct 03, 2016 at 06:11:23PM +0200, Robert Jarzmik wrote: > Mark Rutland writes: > > > On Mon, Oct 03, 2016 at 11:05:53AM +0200, Robert Jarzmik wrote: > >> Add a workaround for mainstone, idp and stargate2 boards, for u16 writes > >> which must be aligned on 32 bits addresses. > >> > >> Si

RE: [PATCH 3/3] net: fec: align IP header in hardware

2016-10-03 Thread David Laight
From: Russell King - ARM Linux > Sent: 01 October 2016 20:52 > On Fri, Sep 30, 2016 at 07:16:12AM -0700, Eric Nelson wrote: > > On ARM, the CPU can't handle misaligned memory cycles without > > taking an alignment fault and NET_IP_ALIGN is set to 2. > > Let's get this right... With Linux on MMU p

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Mark Rutland
On Mon, Oct 03, 2016 at 05:09:13PM +0100, Russell King - ARM Linux wrote: > Please note that the binding doc for smsc,lan91c111.txt is slightly wrong > on two counts: > > 1) compatible property: > > compatible = "smsc,lan91c111"; > > vs the code: > > static const struct of_device_id smc91x_matc

[PATCH net-next] openvswitch: correctly fragment packet with mpls headers

2016-10-03 Thread Jiri Benc
If mpls headers were pushed to a defragmented packet, the refragmentation no longer works correctly after 48d2ab609b6b ("net: mpls: Fixups for GSO"). The network header has to be shifted after the mpls headers for the fragmentation and restored afterwards. Fixes: 48d2ab609b6b ("net: mpls: Fixups f

Re: [PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode

2016-10-03 Thread Mike Looijmans
On 03-10-16 16:35, Andrew Lunn wrote: +Boolean: + + - enable-edpd : Not related to timing. Specify this property to enable + energy-detect power-down mode in the PHY. The Broadcom PHYs unconditionally enable this feature. The SMSC driver has an option: smsc,disabl

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Robert Jarzmik
Jeremy Linton writes: > Hi Robert, > > On 10/03/2016 04:05 AM, Robert Jarzmik wrote: >> Add a workaround for mainstone, idp and stargate2 boards, for u16 writes >> which must be aligned on 32 bits addresses. >> >> Signed-off-by: Robert Jarzmik >> --- >> Documentation/devicetree/bindings/net/sms

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Robert Jarzmik
Mark Rutland writes: > On Mon, Oct 03, 2016 at 11:05:53AM +0200, Robert Jarzmik wrote: >> Add a workaround for mainstone, idp and stargate2 boards, for u16 writes >> which must be aligned on 32 bits addresses. >> >> Signed-off-by: Robert Jarzmik >> --- >> Documentation/devicetree/bindings/net/

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Russell King - ARM Linux
On Mon, Oct 03, 2016 at 04:46:25PM +0100, Mark Rutland wrote: > On Mon, Oct 03, 2016 at 11:05:53AM +0200, Robert Jarzmik wrote: > > Add a workaround for mainstone, idp and stargate2 boards, for u16 writes > > which must be aligned on 32 bits addresses. > > > > Signed-off-by: Robert Jarzmik > > --

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Mark Rutland
On Mon, Oct 03, 2016 at 11:05:53AM +0200, Robert Jarzmik wrote: > Add a workaround for mainstone, idp and stargate2 boards, for u16 writes > which must be aligned on 32 bits addresses. > > Signed-off-by: Robert Jarzmik > --- > Documentation/devicetree/bindings/net/smsc911x.txt | 2 ++ > 1 file c

Re: [PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Jeremy Linton
Hi Robert, On 10/03/2016 04:05 AM, Robert Jarzmik wrote: Add a workaround for mainstone, idp and stargate2 boards, for u16 writes which must be aligned on 32 bits addresses. Signed-off-by: Robert Jarzmik --- Documentation/devicetree/bindings/net/smsc911x.txt | 2 ++ 1 file changed, 2 insertio

Re: [PATCH 0/2] cxgb4 FR_NSMR_TPTE_WR support

2016-10-03 Thread Doug Ledford
On 9/27/2016 6:03 PM, Steve Wise wrote: >> >>> From: Steve Wise Date: Fri, 16 Sep 2016 07:54:55 -0700 > This series enables a new work request to optimize small REG_MR > operations. This is intended for 4.9. If everyone agrees, I suggest > Doug take both the cxgb4

Re: [PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode

2016-10-03 Thread Andrew Lunn
> +Boolean: > + > + - enable-edpd : Not related to timing. Specify this property to enable > + energy-detect power-down mode in the PHY. The Broadcom PHYs unconditionally enable this feature. The SMSC driver has an option: smsc,disable-energy-detect because it seems

Re: [PATCH] ptp: Fix resource leak in case of error

2016-10-03 Thread Richard Cochran
On Sun, Oct 02, 2016 at 09:04:16AM +0200, Christophe JAILLET wrote: > A call to 'ida_simple_remove()' is missing in the error handling path. > > This as been spotted with the following coccinelle script which tries to > detect missing 'ida_simple_remove()' call in error handling paths. Acked-by:

Re: [PATCH net v2] net: pktgen: fix pkt_size

2016-10-03 Thread Greg
On Sat, 2016-10-01 at 20:05 +0200, Paolo Abeni wrote: > On Fri, 2016-09-30 at 08:39 -0700, Greg wrote: > > On Fri, 2016-09-30 at 16:56 +0200, Paolo Abeni wrote: > > > The commit 879c7220e828 ("net: pktgen: Observe needed_headroom > > > of the device") increased the 'pkt_overhead' field value by > >

[PATCH] phy: micrel.c: Support ksz9031 energy-detect power-down mode

2016-10-03 Thread Mike Looijmans
Set bit 0 in register 1C.23 to enable the EDPD feature of the KSZ9031 PHY. This reduces power consumption when the link is down. To use this, set "enable-edpd" in the devicetree. Signed-off-by: Mike Looijmans --- .../devicetree/bindings/net/micrel-ksz90x1.txt| 6 ++ drivers/net/phy/

Re: [v2] mwifiex: report wakeup for wowlan

2016-10-03 Thread Kalle Valo
Rajat Jain wrote: > Enable notifying wakeup source to the PM core in case of > a wake on wireless LAN event. > > Signed-off-by: Wei-Ning Huang > Signed-off-by: Rajat Jain > Tested-by: Wei-Ning Huang > Reviewed-by: Eric Caruso > Acked-by: Amitkumar Karwar The commit log doesn't give any back

Re: [net-next PATCH] net: netlink messages for HW addr programming

2016-10-03 Thread Patrick Ruddy
On Tue, 2016-09-20 at 07:49 +0200, Jiri Pirko wrote: > Tue, Sep 20, 2016 at 07:31:27AM CEST, ro...@cumulusnetworks.com wrote: > >On 9/19/16, 7:46 AM, Patrick Ruddy wrote: > >> On Sun, 2016-09-18 at 07:51 -0700, Roopa Prabhu wrote: > >>> On 9/15/16, 9:48 AM, Patrick Ruddy wrote: > Add RTM_NEWAD

Re: pull-request: mac80211-next 2016-09-30

2016-10-03 Thread Johannes Berg
On Mon, 2016-10-03 at 01:54 -0400, David Miller wrote: >  > Could you please look into this and send me a new pull request with > the conflicts resolved? > Sure, will do (tomorrow, we have a holiday today). Would you prefer I send you the merge resolution for your tree, or just pull in net for a

Re: [PATCH v4 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-03 Thread Raju Lakkaraju
Hi Andrew, On Mon, Oct 03, 2016 at 09:56:56AM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > > > +vsc8531_0: ethernet-phy@0 { > > > > +compatible = "ethernet-phy-id0007.0570"; > > > > +vsc8531,vddmac = /bits/ 16 > > > > ; > > > > +

[PATCH 1/3] net: smc91x: isolate u16 writes alignment workaround

2016-10-03 Thread Robert Jarzmik
Writes to u16 has a special handling on 3 PXA platforms, where the hardware wiring forces these writes to be u32 aligned. This patch isolates this handling for PXA platforms as before, but enables this "workaround" to be set up dynamically, which will be the case in device-tree build types. This

[PATCH 3/3] net: smsc911x: add u16 workaround for pxa platforms

2016-10-03 Thread Robert Jarzmik
Add a workaround for mainstone, idp and stargate2 boards, for u16 writes which must be aligned on 32 bits addresses. Signed-off-by: Robert Jarzmik --- Documentation/devicetree/bindings/net/smsc911x.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/sm

[PATCH 2/3] net: smc91x: take into account half-word workaround

2016-10-03 Thread Robert Jarzmik
For device-tree builds, platforms such as mainstone, idp and stargate2 must have their u16 writes all aligned on 32 bit boundaries. This is already enabled in platform data builds, and this patch adds it to device-tree builds. Signed-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc91x.c

[PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

2016-10-03 Thread Pavel Machek
bluetooth.h is not part of user API, so __ variants are not neccessary here. Signed-off-by: Pavel Machek diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h index bfd1590..aea0371 100644 --- a/include/net/bluetooth/bluetooth.h +++ b/include/net/bluetooth/bluetoot

Re: [PATCH v4 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-03 Thread Andrew Lunn
> > > +vsc8531_0: ethernet-phy@0 { > > > +compatible = "ethernet-phy-id0007.0570"; > > > +vsc8531,vddmac = /bits/ 16 > > > ; > > > +vsc8531,edge-slowdown= /bits/ 8 <17>; > > > > No, real values please: > > > >

Re: [PATCH v4 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

2016-10-03 Thread Raju Lakkaraju
Hi Andrew, Thank you for code review and valuable comments. On Wed, Sep 28, 2016 at 06:16:53PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > +Optional properties: > > +- vsc8531,vddmac : The vddmac in mV. > > +- vsc8531,edge-slowdown : % the edge should be slowed down relative to

[PATCH net-next 7/7] xen/netback: add fraglist support for to-guest rx

2016-10-03 Thread Paul Durrant
From: Ross Lagerwall This allows full 64K skbuffs (with 1500 mtu ethernet, composed of 45 fragments) to be handled by netback for to-guest rx. Signed-off-by: Ross Lagerwall [re-based] Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/interface.c | 2 +- drivers/net/xen

[PATCH net-next 0/7] xen-netback: guest rx side refactor

2016-10-03 Thread Paul Durrant
This series refactors the guest rx side of xen-netback: - The code is moved into its own source module. - The prefix variant of GSO handling is retired (since it is no longer in common use, and alternatives exist). - The code is then simplified and modifications made to improve performance.

[PATCH net-next 1/7] xen-netback: separate guest side rx code into separate module

2016-10-03 Thread Paul Durrant
The netback source module has become very large and somewhat confusing. This patch simply moves all code related to the backend to frontend (i.e guest side rx) data-path into a separate rx source module. This patch contains no functional change, it is code movement and minimal changes to avoid pat

[PATCH net-next 3/7] xen-netback: refactor guest rx

2016-10-03 Thread Paul Durrant
From: David Vrabel Refactor the to-guest (rx) path to: 1. Push responses for completed skbs earlier, reducing latency. 2. Reduce the per-queue memory overhead by greatly reducing the maximum number of grant copy ops in each hypercall (from 4352 to 64). Each struct xenvif_queue is now onl

[PATCH net-next 6/7] xen-netback: batch copies for multiple to-guest rx packets

2016-10-03 Thread Paul Durrant
From: David Vrabel Instead of flushing the copy ops when an packet is complete, complete packets when their copy ops are done. This improves performance by reducing the number of grant copy hypercalls. Latency is still limited by the relatively small size of the copy batch. Signed-off-by: Davi

[PATCH net-next 5/7] xen-netback: process guest rx packets in batches

2016-10-03 Thread Paul Durrant
From: David Vrabel Instead of only placing one skb on the guest rx ring at a time, process a batch of up-to 64. This improves performance by ~10% in some tests. Signed-off-by: David Vrabel [re-based] Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/rx.c | 15 +

[PATCH net-next 4/7] xen-netback: immediately wake tx queue when guest rx queue has space

2016-10-03 Thread Paul Durrant
From: David Vrabel When an skb is removed from the guest rx queue, immediately wake the tx queue, instead of after processing them. Signed-off-by: David Vrabel [re-based] Signed-off-by: Paul Durrant --- Cc: Wei Liu --- drivers/net/xen-netback/rx.c | 24 1 file change

[PATCH net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

2016-10-03 Thread Paul Durrant
As far as I am aware only very old Windows network frontends make use of this style of passing GSO packets from backend to frontend. These frontends can easily be replaced by the freely available Xen Project Windows PV network frontend, which uses the 'default' mechanism for passing GSO packets, wh

  1   2   >