Re: [PATCH net-next v2 7/9] net: use core MTU range checking in misc drivers

On Sat, Oct 22, 2016 at 09:27:59PM +0200, Stefan Richter wrote: > Adding Cc: linux1394-devel, dropping several Ccs, no additional comment. > > On Oct 22 Stefan Richter wrote: > > On Oct 20 Jarod Wilson wrote: > > > firewire-net: > > > - set min/max_mtu > > > - remove fwnet_change_mtu > > [...]

Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

On Sat, Oct 22, 2016 at 09:46:24AM +0200, Sven Eckelmann wrote: > The maximum MTU is defined via the slave devices of an batman-adv > interface. Thus it is not possible to calculate the max_mtu during the > creation of the batman-adv device when no slave devices are attached. Doing > so would for

Re: [PATCH v7] net: ip, diag -- Add diag interface for raw sockets

From: Cyrill Gorcunov Date: Fri, 21 Oct 2016 13:03:44 +0300 > In criu we are actively using diag interface to collect sockets > present in the system when dumping applications. And while for > unix, tcp, udp[lite], packet, netlink it works as expected, > the raw sockets do

Re: [PATCH] netfilter: don't permit unprivileged writes to global state via sysctls

From: Jann Horn Date: Sat, 22 Oct 2016 23:23:42 +0200 > On Thu, Oct 20, 2016 at 02:37:47PM -0400, David Miller wrote: >> From: Pablo Neira Ayuso >> Date: Thu, 20 Oct 2016 20:22:24 +0200 >> >> > On Sat, Sep 24, 2016 at 12:21:04AM +0200, Jann Horn wrote: >>

Re: [PATCH] netfilter: don't permit unprivileged writes to global state via sysctls

On Thu, Oct 20, 2016 at 02:37:47PM -0400, David Miller wrote: > From: Pablo Neira Ayuso > Date: Thu, 20 Oct 2016 20:22:24 +0200 > > > On Sat, Sep 24, 2016 at 12:21:04AM +0200, Jann Horn wrote: > >> This prevents the modification of nf_conntrack_max in unprivileged network >

Re: [PATCH net 0/7] qed*: fix series.

From: Date: Fri, 21 Oct 2016 04:43:38 -0400 > The patch series contains several minor bug fixes for qed/qede modules. > Please consider applying this to 'net' branch. Series applied, thanks.

Re: [PATCH] net: skip genenerating uevents for network namespaces that are exiting

From: Andrei Vagin Date: Thu, 20 Oct 2016 19:46:26 -0700 > @@ -1525,6 +1530,9 @@ void netdev_unregister_kobject(struct net_device *ndev) > { > struct device *dev = &(ndev->dev); > > + if (!list_empty(_net(ndev)->exit_list)) > +

Re: [PATCH net-next 0/2] Add BPF numa id helper

From: Daniel Borkmann Date: Fri, 21 Oct 2016 00:30:25 +0200 > This patch set adds a helper for retrieving current numa node > id and a test case for SO_REUSEPORT. Series applied.

Re: [PATCH net-next v6 0/3] udp: refactor memory accounting

From: Paolo Abeni Date: Fri, 21 Oct 2016 13:55:44 +0200 > This patch series refactor the udp memory accounting, replacing the > generic implementation with a custom one, in order to remove the needs for > locking the socket on the enqueue and dequeue operations. The socket

Re: [Patch net] ipv4: use the right lock for ping_group_range

From: Cong Wang Date: Thu, 20 Oct 2016 14:19:46 -0700 > This reverts commit a681574c99be23e4d20b769bf0e543239c364af5 > ("ipv4: disable BH in set_ping_group_range()") because we never > read ping_group_range in BH context (unlike local_port_range). > > Then, since we

Re: [PATCH net 0/2] net: dsa: bcm_sf2: Do not rely on kexec_in_progress

From: Florian Fainelli Date: Fri, 21 Oct 2016 14:21:54 -0700 > These are the two patches following the discussing we had on > kexec_in_progress. > > Feel free to apply or discard them, thanks! Applied, thanks.

Re: [PATCH] netns: revert "netns: avoid disabling irq for netns id"

I'm tired of hearing you guys go back and forth with each other and will simply apply the revert. Thanks.

Re: [PATCH] netns: revert "netns: avoid disabling irq for netns id"

On Fri, Oct 21, 2016 at 11:38 PM, Cong Wang wrote: > On Fri, Oct 21, 2016 at 6:49 PM, Paul Moore wrote: >> Eventually we should be able to reintroduce this code once we have >> rewritten the audit multicast code to queue messages much the same >> way

Re: [PATCH net-next v2 7/9] net: use core MTU range checking in misc drivers

Adding Cc: linux1394-devel, dropping several Ccs, no additional comment. On Oct 22 Stefan Richter wrote: > On Oct 20 Jarod Wilson wrote: > > firewire-net: > > - set min/max_mtu > > - remove fwnet_change_mtu > [...] > > --- a/drivers/firewire/net.c > > +++ b/drivers/firewire/net.c > > @@

Re: [PATCH net-next v2 7/9] net: use core MTU range checking in misc drivers

On Oct 20 Jarod Wilson wrote: > firewire-net: > - set min/max_mtu > - remove fwnet_change_mtu [...] > --- a/drivers/firewire/net.c > +++ b/drivers/firewire/net.c [...] > @@ -1478,9 +1467,10 @@ static int fwnet_probe(struct fw_unit *unit, >* Use the RFC 2734 default 1500 octets or the

Re: [Patch net] net: saving irq context for peernet2id()

On Fri, Oct 21, 2016 at 11:26 PM, Cong Wang wrote: > On Fri, Oct 21, 2016 at 1:03 PM, Paul Moore wrote: >> On Fri, Oct 21, 2016 at 2:02 PM, Cong Wang wrote: >>> On Fri, Oct 21, 2016 at 9:19 AM, Paul Moore

Re: [PATCH net-next 6/6] net: use core MTU range checking in misc drivers

On Oct 22 Stefan Richter wrote: > On Oct 19 Jarod Wilson wrote: > > On Thu, Oct 20, 2016 at 12:38:46AM +0200, Stefan Richter wrote: > > > On Oct 19 Sabrina Dubroca wrote: > > > > 2016-10-18, 22:33:33 -0400, Jarod Wilson wrote: [...] > > > > > @@ -1481,6 +1471,8 @@ static int fwnet_probe(struct

Re: [PATCH] flow_dissector: avoid uninitialized variable access

On Sat, Oct 22, 2016 at 8:57 AM, Eric Garver wrote: > On Sat, Oct 22, 2016 at 12:16:29AM +0200, Arnd Bergmann wrote: >> On Friday, October 21, 2016 11:05:45 PM CEST Arnd Bergmann wrote: >> > >> > Can you explain why "dissector_uses_key(flow_dissector, >> > FLOW_DISSECTOR_KEY_VLAN)

[PATCH v1 1/1] ISDN: eicon: replace custom hex_dump_to_buffer()

Instead of custom approach re-use generic helper to convert bytes to hex format. The output is slightly changed, namely string starts from the first dword value. Signed-off-by: Andy Shevchenko --- drivers/isdn/hardware/eicon/message.c | 34

Re: [PATCH] flow_dissector: avoid uninitialized variable access

On Sat, Oct 22, 2016 at 12:16:29AM +0200, Arnd Bergmann wrote: > On Friday, October 21, 2016 11:05:45 PM CEST Arnd Bergmann wrote: > > > > Can you explain why "dissector_uses_key(flow_dissector, > > FLOW_DISSECTOR_KEY_VLAN) && skb_vlan_tag_present(skb)" implies > > "eth_type_vlan(proto))"? > > >

Re: [PATCH -next] rocker: fix error return code in rocker_world_check_init()

Sat, Oct 22, 2016 at 04:31:06PM CEST, weiyj...@gmail.com wrote: >From: Wei Yongjun > >Fix to return error code -EINVAL from the error handling >case instead of 0, as done elsewhere in this function. > >Signed-off-by: Wei Yongjun Fixes:

[PATCH -next] net: netcp: add missing of_node_put() in netcp_probe()

From: Wei Yongjun This node pointer is returned by of_get_child_by_name() with refcount incremented in this function. of_node_put() on it before exitting this function. This is detected by Coccinelle semantic patch. Signed-off-by: Wei Yongjun

[PATCH -next] net: ena: use setup_timer() and mod_timer()

From: Wei Yongjun Use setup_timer() instead of init_timer(), being the preferred/standard way to set a timer up. Also, quoting the mod_timer() function comment: -> mod_timer() is a more efficient way to update the expire field of an active timer (if the timer is

[PATCH -next] amd-xgbe: Fix error return code in xgbe_probe()

From: Wei Yongjun Fix to return error code -ENODEV from the DMA is not supported error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/amd/xgbe/xgbe-main.c | 1 + 1 file

[PATCH -next] net: ns83820: use dev_kfree_skb_irq instead of kfree_skb

From: Wei Yongjun It is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled, spin_lock_irqsave() make sure always in irq disable context. So the kfree_skb() should be replaced with dev_kfree_skb_irq(). This is detected by

[PATCH -next] rocker: fix error return code in rocker_world_check_init()

From: Wei Yongjun Fix to return error code -EINVAL from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/rocker/rocker_main.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH -next] net: eth: altera: Fix error return code in altera_tse_probe()

From: Wei Yongjun Fix to return error code -EINVAL from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/altera/altera_tse_main.c | 2 ++ 1 file changed, 2

[PATCH -next] net: dsa: mv88e6xxx: use setup_timer to simplify the code

From: Wei Yongjun Use setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: Wei Yongjun --- drivers/net/dsa/mv88e6xxx/chip.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Get A Part Time Job Today

Hello My Name is Steven Moore.We seek the service of a Secret Shopper in our apex-consult Organization. The assignment will pay per duty .You can make $200 everyday , depends on how fast you able to take up your work. I am sure you cannot spend more than 1-2 hours per day on your

[PATCH -next] net: netcp: drop kfree for memory allocated with devm_kzalloc

From: Wei Yongjun It's not necessary to free memory allocated with devm_kzalloc in the remove path and using kfree leads to a double free. Fixes: 84640e27f230 ("net: netcp: Add Keystone NetCP core ethernet driver") Signed-off-by: Wei Yongjun ---

Re: [PATCH net-next 09/15] ethernet/dlink: use core min/max MTU checking

On Oct 18 Jarod Wilson wrote: > On Tue, Oct 18, 2016 at 04:45:51PM +0300, Denis Kirjanov wrote: > > On 10/17/16, Jarod Wilson wrote: [...] > > > --- a/drivers/net/ethernet/dlink/sundance.c > > > +++ b/drivers/net/ethernet/dlink/sundance.c > > > @@ -580,6 +580,10 @@ static int

Re: [PATCH net-next 6/6] net: use core MTU range checking in misc drivers

On Oct 19 Jarod Wilson wrote: > On Thu, Oct 20, 2016 at 12:38:46AM +0200, Stefan Richter wrote: > > On Oct 19 Sabrina Dubroca wrote: > > > 2016-10-18, 22:33:33 -0400, Jarod Wilson wrote: > > > [...] > > > > diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c > > > > index 309311b..b5f125c

[PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

The maximum MTU is defined via the slave devices of an batman-adv interface. Thus it is not possible to calculate the max_mtu during the creation of the batman-adv device when no slave devices are attached. Doing so would for example break non-fragmentation setups which then (incorrectly) allow an

Re: [PATCH] net: skip genenerating uevents for network namespaces that are exiting

Hi Cong, On Thu, Oct 20, 2016 at 10:25 PM, Andrey Vagin wrote: > On Thu, Oct 20, 2016 at 8:10 PM, Cong Wang wrote: >> On Thu, Oct 20, 2016 at 7:46 PM, Andrei Vagin wrote: >>> No one can see these events, because a network

Re: [net-next,v2,7/9] net: use core MTU range checking in misc drivers

On Donnerstag, 20. Oktober 2016 13:55:22 CEST Jarod Wilson wrote: [...] > batman-adv: > - set max_mtu > - remove batadv_interface_change_mtu > - initialization is a little async, not 100% certain that max_mtu is set > in the optimal place, don't have hardware to test with batman-adv is creating

Re: [PATCH] flow_dissector: avoid uninitialized variable access

Sat, Oct 22, 2016 at 03:48:48AM CEST, torva...@linux-foundation.org wrote: >On Fri, Oct 21, 2016 at 9:31 AM, Jiri Pirko wrote: >> >> I don't see how vlan could be used uninitialized. But I understand that >> this is impossible for gcc to track it. Please just use