[PATCH net] MAINTAINERS: Update qlogic networking drivers

2016-10-23 Thread Yuval Mintz
Following Cavium's acquisition of qlogic we need to update all the qlogic drivers maintainer's entries to point to our new e-mail addresses, as well as update some of the driver's maintainers as those are no longer working for Cavium. I would like to thank Sony Chacko and Rajesh Borundia for

[PATCH net] netvsc: fix incorrect receive checksum offloading

2016-10-23 Thread Stephen Hemminger
From: Stephen Hemminger The Hyper-V netvsc driver was looking at the incorrect status bits in the checksum info. It was setting the receive checksum unnecessary flag based on the IP header checksum being correct. The checksum flag is skb is about TCP and UDP checksum

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-10-23 Thread Shrijeet Mukherjee
On Sun, Oct 23, 2016 at 9:38 AM, Stephen Hemminger wrote: > Overall, I am glad to see XDP support more widely available. Minor stuff > in implementation. > >> >> +/* this function is not called from the receive_buf path directly as >> + * we want to use the page model

Re: [PATCH net-next 1/2] firewire: net: fix maximum possible MTU

2016-10-23 Thread Jarod Wilson
On Sun, Oct 23, 2016 at 04:29:03PM +0200, Stefan Richter wrote: > Commit b3e3893e1253 ("net: use core MTU range checking in misc drivers") > mistakenly introduced an upper limit for firewire-net's MTU based on the > local link layer controller's reception capability. Revert this. Neither > RFC

Re: [PATCH net-next 2/2] firewire: net: set initial MTU = 1500 unconditionally, fix IPv6 on some CardBus cards

2016-10-23 Thread Jarod Wilson
On Sun, Oct 23, 2016 at 04:30:56PM +0200, Stefan Richter wrote: > firewire-net, like the older eth1394 driver, reduced the initial MTU to > less than 1500 octets if the local link layer controller's asynchronous > packet reception limit was lower. > > This is bogus, since this reception limit

Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

2016-10-23 Thread Jarod Wilson
On Sun, Oct 23, 2016 at 09:17:50AM +0200, Sven Eckelmann wrote: > On Samstag, 22. Oktober 2016 21:08:26 CEST Jarod Wilson wrote: > [...] > > You're going to > > need more than just this revert though, since batman-adv calls > > ether_setup, which will set min_mtu = 68, max_mtu = 1500, unless > >

Re: [RFC PATCH 01/13] pinctrl: meson: Add GXL pinctrl definitions

2016-10-23 Thread Linus Walleij
On Fri, Oct 21, 2016 at 4:40 PM, Neil Armstrong wrote: > Add support for the Amlogic Meson GXL SoC, this is a partially complete > definition only based on the Amlogic Vendor tree. > > This definition differs a lot from the GXBB and needs a separate entry. > >

[PATCH net] udp: fix IP_CHECKSUM handling

2016-10-23 Thread Eric Dumazet
From: Eric Dumazet First bug was added in commit ad6f939ab193 ("ip: Add offset parameter to ip_cmsg_recv") : Tom missed that ipv4 udp messages could be received on AF_INET6 socket. ip_cmsg_recv(msg, skb) should have been replaced by ip_cmsg_recv_offset(msg, skb,

linux-next: manual merge of the net-next tree with the net tree

2016-10-23 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: include/net/udp.h between commit: 286c72deabaa ("udp: must lock the socket in udp_disconnect()") from the net tree and commit: f970bd9e3a06 ("udp: implement memory accounting helpers") from the net-next tree. I

Re: [PATCH net 1/1] net sched filters: fix notification of filter delete with proper handle

2016-10-23 Thread Daniel Borkmann
On 10/23/2016 05:35 PM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim An actual commit message would be good especially if it's a fix for -net tree plus stable. Thanks. Signed-off-by: Jamal Hadi Salim --- net/sched/cls_api.c | 3 ++- 1 file

Re: pull request: bluetooth 2016-10-21

2016-10-23 Thread David Miller
From: Johan Hedberg Date: Fri, 21 Oct 2016 17:40:53 +0300 > Here are some more Bluetooth fixes for the 4.9 kernel: > > - Fix to btwilink driver probe function return value > - Power management fix to hci_bcm > - Fix to encoding name in scan response data > > Please

Re: [PATCH net-next] lwt: Remove unused len field

2016-10-23 Thread David Miller
From: Thomas Graf Date: Fri, 21 Oct 2016 16:10:22 +0200 > The field is initialized by ILA and MPLS but never used. Remove it. > > Signed-off-by: Thomas Graf Applied, thanks Thomas.

Re: [PATCH] ipv6: do not increment mac header when it's unset

2016-10-23 Thread David Miller
From: "Jason A. Donenfeld" Date: Fri, 21 Oct 2016 18:28:25 +0900 > Otherwise we'll overflow the integer. This occurs when layer 3 tunneled > packets are handed off to the IPv6 layer. > > Signed-off-by: Jason A. Donenfeld Applied, thanks. Have fun playing

Re: [PATCH net] net: fec: Call swap_buffer() prior to IP header alignment

2016-10-23 Thread David Miller
From: Fabio Estevam Date: Fri, 21 Oct 2016 09:34:29 -0200 > From: Fabio Estevam > > Commit 3ac72b7b63d5 ("net: fec: align IP header in hardware") breaks > networking on mx28. > > There is an erratum on mx28 (ENGR121613 - ENET big endian mode > not

Re: [PATCH v2 net-next 1/1] driver: tun: Forbid to set IFF_TUN and IFF_TAP at the same time

2016-10-23 Thread David Miller
From: f...@ikuai8.com Date: Fri, 21 Oct 2016 19:02:15 +0800 > From: Gao Feng > > Current tun driver permits the ifr_flags is set with IFF_TUN and > IFF_TAP at the same time. But actually there is only IFF_TUN flag > works. And it does not make sense these two flags are set, so

Re: [PATCH] net: sctp, forbid negative length

2016-10-23 Thread David Miller
From: Jiri Slaby Date: Fri, 21 Oct 2016 14:13:24 +0200 > Most of getsockopt handlers in net/sctp/socket.c check len against > sizeof some structure like: > if (len < sizeof(int)) > return -EINVAL; > > On the first look, the check seems to be correct. But

Re: [PATCH net 1/1] bnx2x: Use the correct divisor value for PHC clock readings.

2016-10-23 Thread David Miller
From: Date: Fri, 21 Oct 2016 02:09:17 -0400 > From: Sudarsana Reddy Kalluru > > Time Sync (PTP) implementation uses the divisor/shift value for converting > the clock ticks to nanoseconds. Driver currently defines shift value as 1, > this

Re: [PATCH net-next] net: allow to kill a task which waits net_mutex in copy_new_ns

2016-10-23 Thread David Miller
From: Andrei Vagin Date: Thu, 20 Oct 2016 19:45:43 -0700 > From: Andrey Vagin > > net_mutex can be locked for a long time. It may be because many > namespaces are being destroyed or many processes decide to create > a network namespace. > > Both these

Re: [PATCH net-next] net/sched: em_meta: Fix 'meta vlan' to correctly recognize zero VID frames

2016-10-23 Thread David Miller
From: Shmulik Ladkani Date: Fri, 21 Oct 2016 00:18:08 +0300 > META_COLLECTOR int_vlan_tag() assumes that if the accel tag (vlan_tci) > is zero, then no vlan accel tag is present. > > This is incorrect for zero VID vlan accel packets, making the following > match fail:

Re: [patch net-next 0/6] mlxsw: Driver update

2016-10-23 Thread David Miller
From: Jiri Pirko Date: Fri, 21 Oct 2016 16:07:17 +0200 > Mostly cosmetics and small resource values management rewrite. Series applied, thanks Jiri.

[PATCH net-next] flow_dissector: fix vlan tag handling

2016-10-23 Thread Arnd Bergmann
gcc warns about an uninitialized pointer dereference in the vlan priority handling: net/core/flow_dissector.c: In function '__skb_flow_dissect': net/core/flow_dissector.c:281:61: error: 'vlan' may be used uninitialized in this function [-Werror=maybe-uninitialized] As pointed out by Jiri Pirko,

Re: send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit

2016-10-23 Thread Jamal Hadi Salim
On 16-10-23 02:20 PM, Xin Long wrote: This patch doesn't ignore all the ENOMEN cases, only after msg is enqueued in out queue/send queue, in the lower layer, when alloc new skb and copy data from old skb, if it fails to alloc new skb, sctp will ignore this ENOMEM, as this msg will be taken care

Re: send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit

2016-10-23 Thread Xin Long
> I think the specific use case this patch addresses > seems to have bitten us in an older kernel sctp (3.11?). > A send() on a loaded network box caused the skb to > alloc in what appears to be this code path and fail (problem > is intermittent, so not 100% sure). errno seen was ENOMEM. >

[PATCH net] sctp: fix the panic caused by route update

2016-10-23 Thread Xin Long
Commit 7303a1475008 ("sctp: identify chunks that need to be fragmented at IP level") made the chunk be fragmented at IP level in the next round if it's size exceed PMTU. But there still is another case, PMTU can be updated if transport's dst expires and transport's pmtu_pending is set in

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-10-23 Thread Stephen Hemminger
Overall, I am glad to see XDP support more widely available. Minor stuff in implementation. > > +/* this function is not called from the receive_buf path directly as > + * we want to use the page model for rx merge buffer and big buffers > + * and not use the fast path for driving skb's around

[PATCH net] doc: update docbook annotations for socket and skb

2016-10-23 Thread Stephen Hemminger
From: Stephen Hemminger The skbuff and sock structure both had missing parameter annotation values. Signed-off-by: Stephen Hemminger --- include/linux/skbuff.h | 1 + include/net/sock.h | 4 +++- 2 files changed, 4 insertions(+), 1

Re: [PATCH -next] net: dsa: mv88e6xxx: use setup_timer to simplify the code

2016-10-23 Thread Andrew Lunn
On Sat, Oct 22, 2016 at 02:28:00PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Use setup_timer function instead of initializing timer with the function > and data fields. > > Signed-off-by: Wei Yongjun Reviewed-by: Andrew Lunn

Re: [PATCH net-next 1/9] alx: refactor descriptor allocation

2016-10-23 Thread David Miller
From: Tobias Regnery Date: Fri, 21 Oct 2016 12:49:44 +0200 > + txq->tpd = alx->descmem.virt + offset; > + txq->tpd_dma = alx->descmem.dma + offset; If all the crazy casting isn't necessary here... > + rxq->rrd = (void *)((u8 *)alx->descmem.virt + offset);

[patch net-next] devlink: Prevent port_type_set() callback when it's not needed

2016-10-23 Thread Jiri Pirko
From: Elad Raz When a port_type_set() is been called and the new port type set is the same as the old one, just return success. Signed-off-by: Elad Raz Signed-off-by: Jiri Pirko --- net/core/devlink.c | 2 ++ 1 file changed, 2

[PATCH net 1/1] net sched filters: fix notification of filter delete with proper handle

2016-10-23 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Signed-off-by: Jamal Hadi Salim --- net/sched/cls_api.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 2ee29a3..2b2a797 100644 --- a/net/sched/cls_api.c +++

Fwd: send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit

2016-10-23 Thread Jamal Hadi Salim
Sorry - I didnt mean to remove the mailing lists. Please reply to this email instead. cheers, jamal Forwarded Message Subject: send/sendmsg ENOMEM errors WAS(Re: [PATCH net 6/6] sctp: not return ENOMEM err back in sctp_packet_transmit Date: Sun, 23 Oct 2016 11:03:36 -0400

Re: [PATCH net] sched, cls: don't dump kernel addr into tc monitors on delete event

2016-10-23 Thread Jamal Hadi Salim
On 16-10-18 07:14 PM, Cong Wang wrote: On Tue, Oct 18, 2016 at 2:21 PM, Jamal Hadi Salim wrote: I was sitting on this patch I was going to send ;-> Does this resolve it? Your patch makes more sense to me. Maybe we can remove the event != RTM_DELTFILTER special case too?

[PATCH net-next 2/2] firewire: net: set initial MTU = 1500 unconditionally, fix IPv6 on some CardBus cards

2016-10-23 Thread Stefan Richter
firewire-net, like the older eth1394 driver, reduced the initial MTU to less than 1500 octets if the local link layer controller's asynchronous packet reception limit was lower. This is bogus, since this reception limit does not have anything to do with the transmission limit. Neither did this

[PATCH net-next 1/2] firewire: net: fix maximum possible MTU

2016-10-23 Thread Stefan Richter
Commit b3e3893e1253 ("net: use core MTU range checking in misc drivers") mistakenly introduced an upper limit for firewire-net's MTU based on the local link layer controller's reception capability. Revert this. Neither RFC 2734 nor our implementation impose any particular upper limit. Actually,

Re: [RFC 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-10-23 Thread Rangankar, Manish
On 19/10/16 3:32 PM, "Johannes Thumshirn" wrote: >On Wed, Oct 19, 2016 at 01:01:10AM -0400, manish.rangan...@cavium.com >wrote: >> From: Manish Rangankar >> >> The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module >> for

Re: [PATCH v4 01/10] ethernet: add sun8i-emac driver

2016-10-23 Thread Rami Rosen
Hi Corentin, Trivial comment: rx_saf_fai and rx_daf_fail are not used. This implies that also rx_saf_error and rx_daf_error should be removed: > +static const char const estats_str[][ETH_GSTRING_LEN] = { ... > + "rx_header_error", > + "rx_overflow_error", > + "rx_saf_error", >

Re: [PATCH v4 01/10] ethernet: add sun8i-emac driver

2016-10-23 Thread LABBE Corentin
On Fri, Oct 07, 2016 at 08:02:39AM -0700, Joe Perches wrote: > On Fri, 2016-10-07 at 10:25 +0200, Corentin Labbe wrote: > > This patch add support for sun8i-emac ethernet MAC hardware. > > It could be found in Allwinner H3/A83T/A64 SoCs. > > trivial notes: > > > diff --git

Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"

2016-10-23 Thread Sven Eckelmann
On Samstag, 22. Oktober 2016 21:08:26 CEST Jarod Wilson wrote: [...] > You're going to > need more than just this revert though, since batman-adv calls > ether_setup, which will set min_mtu = 68, max_mtu = 1500, unless > batadv_hardif_min_mtu() always returns something 1500 or less. It does only

Re: [PATCH v7] net: ip, diag -- Add diag interface for raw sockets

2016-10-23 Thread Cyrill Gorcunov
On Sat, Oct 22, 2016 at 06:55:27PM -0400, David Miller wrote: > From: Cyrill Gorcunov > Date: Fri, 21 Oct 2016 13:03:44 +0300 > > > In criu we are actively using diag interface to collect sockets > > present in the system when dumping applications. And while for > > unix,