[PATCH 1/1] xen-netfront: do not cast grant table reference to signed short

2016-10-30 Thread Dongli Zhang
While grant reference is of type uint32_t, xen-netfront erroneously casts it to signed short in BUG_ON(). This would lead to the xen domU panic during boot-up or migration when it is attached with lots of paravirtual devices. Signed-off-by: Dongli Zhang ---

[PATCH net-next v2 3/7] qed*: Add support for WoL

2016-10-30 Thread Yuval Mintz
Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed.h | 11 - drivers/net/ethernet/qlogic/qed/qed_dev.c | 19 - drivers/net/ethernet/qlogic/qed/qed_hsi.h | 4 ++ drivers/net/ethernet/qlogic/qed/qed_main.c | 29

[PATCH net-next v2 6/7] qed: Use VF-queue feature

2016-10-30 Thread Yuval Mintz
Driver sets several restrictions about the number of supported VFs according to available HW/FW resources. This creates a problem as there are constellations which can't be supported [as limitation don't accurately describe the resources], as well as holes where enabling IOV would fail due to

[PATCH net-next v2 7/7] qed: Learn resources from management firmware

2016-10-30 Thread Yuval Mintz
From: Tomer Tayar Currently, each interfaces assumes it receives an equal portion of HW/FW resources, but this is wasteful - different partitions [and specifically, parititions exposing different protocol support] might require different resources. Implement a new

[PATCH net-next v2 4/7] qede: Decouple ethtool caps from qed

2016-10-30 Thread Yuval Mintz
While the qed_lm_maps is closely tied with the QED_LM_* defines, when iterating over the array use actual size instead of the qed define to prevent future possible issues. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 4 ++-- 1 file

[PATCH net-next v2 1/7] qed*: Management firmware - notifications and defaults

2016-10-30 Thread Yuval Mintz
From: Sudarsana Kalluru Management firmware is interested in various tidbits about the driver - including the driver state & several configuration related fields [MTU, primtary MAC, etc.]. This adds the necessray logic to update MFW with such configurations, some of

[PATCH net-next v2 5/7] qed: Learn of RDMA capabilities per-device

2016-10-30 Thread Yuval Mintz
Today, RDMA capabilities are learned from management firmware which provides a per-device indication for all interfaces. Newer management firmware is capable of providing a per-device indication [would later be extended to either RoCE/iWARP]. Try using this newer learning mechanism, but fallback

[PATCH net-next v2 2/7] qed: Add nvram selftest

2016-10-30 Thread Yuval Mintz
Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_hsi.h | 4 + drivers/net/ethernet/qlogic/qed/qed_main.c | 1 + drivers/net/ethernet/qlogic/qed/qed_mcp.c | 94 ++ drivers/net/ethernet/qlogic/qed/qed_mcp.h |

[PATCH net-next v2 0/7] qed*: Patch series

2016-10-30 Thread Yuval Mintz
This series does several things. The bigger changes: - Add new notification APIs [& Defaults] for various fields. The series then utilizes some of those qed <-> qede APIs to bass WoL support upon. - Change the resource allocation scheme to receive the values from management firmware, instead

Re: [bnx2] [Regression 4.8] Driver loading fails without firmware

2016-10-30 Thread Baoquan He
Hi Paul, On 10/30/16 at 12:05pm, Paul Menzel wrote: > Dear Baoquan, > > > Am Samstag, den 29.10.2016, 10:55 +0800 schrieb Baoquan He: > > On 10/27/16 at 03:21pm, Paul Menzel wrote: > > > > > > Baoquan, could you please fix this regression. My suggestion is, that > > > > > you > > > > > add

Re: [PATCH net] r8152: Fix broken RX checksums.

2016-10-30 Thread David Miller
From: Mark Lord Date: Sun, 30 Oct 2016 22:07:25 -0400 > On 16-10-30 08:57 PM, David Miller wrote: >> From: Mark Lord >> Date: Sun, 30 Oct 2016 19:28:27 -0400 >> >>> The r8152 driver has been broken since (approx) 3.16.xx >>> when support was added for hardware

Re: [PATCH net] r8152: Fix broken RX checksums.

2016-10-30 Thread Mark Lord
On 16-10-30 08:57 PM, David Miller wrote: > From: Mark Lord > Date: Sun, 30 Oct 2016 19:28:27 -0400 > >> The r8152 driver has been broken since (approx) 3.16.xx >> when support was added for hardware RX checksums >> on newer chip versions. Symptoms include random >> segfaults

Re: [PATCH net-next 3/4] bpf: BPF for lightweight tunnel encapsulation

2016-10-30 Thread Tom Herbert
On Sun, Oct 30, 2016 at 2:47 PM, Thomas Graf wrote: > On 10/30/16 at 01:34pm, Tom Herbert wrote: >> On Sun, Oct 30, 2016 at 4:58 AM, Thomas Graf wrote: >> > + if (unlikely(!dst->lwtstate->orig_output)) { >> > + WARN_ONCE(1, "orig_output not set

Re: [PATCH net] r8152: Fix broken RX checksums.

2016-10-30 Thread David Miller
From: Mark Lord Date: Sun, 30 Oct 2016 19:28:27 -0400 > The r8152 driver has been broken since (approx) 3.16.xx > when support was added for hardware RX checksums > on newer chip versions. Symptoms include random > segfaults and silent data corruption over NFS. > > The

Re: [PATCH] drivers/net/usb/r8152 fix broken rx checksums

2016-10-30 Thread Paul Bolle
On Sun, 2016-10-30 at 17:22 -0400, David Miller wrote: >         3) "Fix broken RX checksums."  Commit header lines and commit >    messages are proper English, therefore sentences should >    begin with a capitalized letter and end with a period. Commit messages should be proper

[PATCH net] r8152: Fix broken RX checksums.

2016-10-30 Thread Mark Lord
The r8152 driver has been broken since (approx) 3.16.xx when support was added for hardware RX checksums on newer chip versions. Symptoms include random segfaults and silent data corruption over NFS. The hardware checksum logig does not work on the VER_02 dongles I have here when used with a

Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme

2016-10-30 Thread Saeed Mahameed
On Mon, Oct 31, 2016 at 1:11 AM, Saeed Mahameed wrote: > On Mon, Oct 31, 2016 at 12:44 AM, Alexei Starovoitov > wrote: >> On Sun, Oct 30, 2016 at 06:03:06PM +0200, Tariq Toukan wrote: >>> >>> Note that the XDP TX rings are no longer shown

Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme

2016-10-30 Thread Saeed Mahameed
On Mon, Oct 31, 2016 at 12:44 AM, Alexei Starovoitov wrote: > On Sun, Oct 30, 2016 at 06:03:06PM +0200, Tariq Toukan wrote: >> >> Note that the XDP TX rings are no longer shown in ethtool -S. > > ouch. Can you make it to show them as some large TX numbers instead? >

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-10-30 Thread Jes Sorensen
John Heenan writes: > Thanks for your reply. > > The code was tested on a Cube i9 which has an internal rtl8723bu. > > No other devices were tested. > > I am happy to accept in an ideal context hard coding macpower is > undesirable, the comment is undesirable and it is wrong to

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-10-30 Thread Michael S. Tsirkin
On Fri, Oct 28, 2016 at 01:11:01PM -0400, David Miller wrote: > From: John Fastabend > Date: Fri, 28 Oct 2016 08:56:35 -0700 > > > On 16-10-27 07:10 PM, David Miller wrote: > >> From: Alexander Duyck > >> Date: Thu, 27 Oct 2016 18:43:59 -0700

Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme

2016-10-30 Thread Alexei Starovoitov
On Sun, Oct 30, 2016 at 06:03:06PM +0200, Tariq Toukan wrote: > > Note that the XDP TX rings are no longer shown in ethtool -S. ouch. Can you make it to show them as some large TX numbers instead? It would really sux to lose stats on them.

Re: Let's do P4

2016-10-30 Thread Alexei Starovoitov
On Sun, Oct 30, 2016 at 05:38:36PM +0100, Jiri Pirko wrote: > Sun, Oct 30, 2016 at 11:26:49AM CET, tg...@suug.ch wrote: > >On 10/30/16 at 08:44am, Jiri Pirko wrote: > >> Sat, Oct 29, 2016 at 06:46:21PM CEST, john.fastab...@gmail.com wrote: > >> >On 16-10-29 07:49 AM, Jakub Kicinski wrote: > >> >>

Re: [PATCH net-next 3/4] bpf: BPF for lightweight tunnel encapsulation

2016-10-30 Thread Thomas Graf
On 10/30/16 at 01:34pm, Tom Herbert wrote: > On Sun, Oct 30, 2016 at 4:58 AM, Thomas Graf wrote: > > + if (unlikely(!dst->lwtstate->orig_output)) { > > + WARN_ONCE(1, "orig_output not set on dst for prog %s\n", > > + bpf->out.name); > > +

Re: [PATCH for-next V2 00/15][PULL request] Mellanox mlx5 core driver updates 2016-10-25

2016-10-30 Thread David Miller
From: Saeed Mahameed Date: Sun, 30 Oct 2016 23:21:53 +0200 > This series contains some updates and fixes of mlx5 core and > IB drivers with the addition of two features that demand > new low level commands and infrastructure updates. > - SRIOV VF max rate limit support > -

[PATCH for-next V2 13/15] net/mlx5: Add multi dest support

2016-10-30 Thread Saeed Mahameed
From: Mark Bloch Currently when calling mlx5_add_flow_rule we accept only one flow destination, this commit allows to pass multiple destinations. This change forces us to change the return structure to a more flexible one. We introduce a flow handle (struct

[PATCH for-next V2 06/15] net/mlx5: Introduce TSAR manipulation firmware commands

2016-10-30 Thread Saeed Mahameed
From: Mohamad Haj Yahia TSAR (stands for Transmit Scheduling ARbiter) is a hardware component that is responsible for selecting the next entity to serve on the transmit path. The arbitration defines the QoS policy between the agents connected to the TSAR. The TSAR is a

[PATCH for-next V2 10/15] net/mlx5: Use fte status to decide on firmware command

2016-10-30 Thread Saeed Mahameed
From: Mark Bloch An fte status becomes FS_FTE_STATUS_EXISTING only after it was created in HW. We can use this in order to simplify the logic on what firmware command to use. If the status isn't FS_FTE_STATUS_EXISTING we need to create the fte, otherwise we need only to

[PATCH for-next V2 12/15] net/mlx5: Group similer rules under the same fte

2016-10-30 Thread Saeed Mahameed
From: Mark Bloch When adding a new rule, if we can match it with compare_match_value and flow tag we might be able to insert the rule to the same fte. In order to do that, there must be an overlap between the actions of the fte and the new rule. When updating the action of

[PATCH for-next V2 14/15] net/mlx5: Add option to add fwd rule with counter

2016-10-30 Thread Saeed Mahameed
From: Mark Bloch Currently the code supports only drop rules to possess counters, add that ability also for fwd rules. Signed-off-by: Mark Bloch Signed-off-by: Saeed Mahameed Signed-off-by: Leon Romanovsky ---

[PATCH for-next V2 01/15] IB/mlx5: Skip handling unknown events

2016-10-30 Thread Saeed Mahameed
Do not dispatch unknown mlx5 core events on mlx5_ib_event. Signed-off-by: Saeed Mahameed Signed-off-by: Eugenia Emantayev Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH for-next V2 00/15][PULL request] Mellanox mlx5 core driver updates 2016-10-25

2016-10-30 Thread Saeed Mahameed
Hi Dave and Doug, This series contains some updates and fixes of mlx5 core and IB drivers with the addition of two features that demand new low level commands and infrastructure updates. - SRIOV VF max rate limit support - mlx5e tc support for FWD rules with counter. Needed for both net and

Re: [PATCH net-next 0/7] qed*: Patch series

2016-10-30 Thread David Miller
From: Yuval Mintz Date: Sun, 30 Oct 2016 18:38:30 +0200 > Please consider applying this series to `net-next'. Even the first patch doesn't apply cleanly, please respin.

Re: [PATCH] drivers/net/usb/r8152 fix broken rx checksums

2016-10-30 Thread David Miller
From: Mark Lord Date: Wed, 26 Oct 2016 18:36:57 -0400 > Patch attached (to deal with buggy mailer) and also below for review. Please make your mailer work properly so that you can submit patches properly which work inline, just like every other developer does for the kernel.

[PATCH for-next V2 11/15] net/mlx5: Refactor find_flow_rule

2016-10-30 Thread Saeed Mahameed
From: Mark Bloch The way we compare between two dests will need to be used in other places in the future, so we factor out the comparison logic between two dests into a separate function. Signed-off-by: Mark Bloch Signed-off-by: Saeed Mahameed

[PATCH for-next V2 08/15] net/mlx5: Add SRIOV VF max rate configuration support

2016-10-30 Thread Saeed Mahameed
From: Mohamad Haj Yahia Implement the vf set rate ndo by modifying the TSAR vport rate limit. Signed-off-by: Mohamad Haj Yahia Signed-off-by: Saeed Mahameed Signed-off-by: Leon Romanovsky ---

[PATCH for-next V2 04/15] net/mlx5: Fix length of async_event_mask

2016-10-30 Thread Saeed Mahameed
From: Eugenia Emantayev According to PRM async_event_mask have to be 64 bits long. Signed-off-by: Eugenia Emantayev Signed-off-by: Saeed Mahameed Signed-off-by: Leon Romanovsky ---

[PATCH for-next V2 02/15] net/mlx5: Update struct mlx5_ifc_xrqc_bits

2016-10-30 Thread Saeed Mahameed
From: Artemy Kovalyov Update struct mlx5_ifc_xrqc_bits according to last specification Signed-off-by: Artemy Kovalyov Signed-off-by: Leon Romanovsky Signed-off-by: Saeed Mahameed ---

Re: [patch net-next 00/16] mlxsw: Add Infiniband support for Mellanox switches

2016-10-30 Thread Jiri Pirko
Sun, Oct 30, 2016 at 09:51:07PM CET, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Fri, 28 Oct 2016 21:17:34 +0200 > >> This patchset adds basic Infiniband support for SwitchX-2, Switch-IB >> and Switch-IB-2 ASIC drivers. > >This depended upon the bug fixes which were only

Re: [PATCH] net: bonding: use new api ethtool_{get|set}_link_ksettings

2016-10-30 Thread David Miller
From: Philippe Reynes Date: Tue, 25 Oct 2016 18:41:31 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied, thanks.

[PATCH for-next V2 05/15] net/mlx5: Add ConnectX-5 PCIe 4.0 VF device ID

2016-10-30 Thread Saeed Mahameed
For the mlx5 driver to support ConnectX-5 PCIe 4.0 VFs, we add the device ID "0x101a" to mlx5_core_pci_table. Signed-off-by: Saeed Mahameed Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 + 1 file changed, 1

[PATCH for-next V2 09/15] net/mlx5: Don't unlock fte while still using it

2016-10-30 Thread Saeed Mahameed
From: Mark Bloch When adding a new rule to an fte, we need to hold the fte lock until we add that rule to the fte and increase the fte ref count. Fixes: 0c56b97503fd ("net/mlx5_core: Introduce flow steering API") Signed-off-by: Mark Bloch Signed-off-by:

[PATCH for-next V2 03/15] net/mlx5: Ensure SRQ physical address structure endianness

2016-10-30 Thread Saeed Mahameed
From: Artemy Kovalyov SRQ physical address structure field should be in big-endian format. Signed-off-by: Artemy Kovalyov Signed-off-by: Leon Romanovsky Signed-off-by: Leon Romanovsky Signed-off-by: Saeed

[PATCH for-next V2 15/15] net/mlx5e: Add tc support for FWD rule with counter

2016-10-30 Thread Saeed Mahameed
From: Mark Bloch When creating a FWD rule using tc create also a HW counter for this rule. Signed-off-by: Mark Bloch Signed-off-by: Saeed Mahameed Signed-off-by: Leon Romanovsky ---

[PATCH for-next V2 07/15] net/mlx5: Introduce E-switch QoS management

2016-10-30 Thread Saeed Mahameed
From: Mohamad Haj Yahia Add TSAR to the eswitch which will act as the vports rate limiter. Create/Destroy TSAR on Enable/Dsiable SRIOV. Attach/Detach vport to eswitch TSAR on Enable/Disable vport. Signed-off-by: Mohamad Haj Yahia Signed-off-by: Saeed

Re: Let's do P4

2016-10-30 Thread John Fastabend
On 16-10-30 12:56 PM, Jiri Pirko wrote: > Sun, Oct 30, 2016 at 07:44:43PM CET, kubak...@wp.pl wrote: >> On Sun, 30 Oct 2016 19:01:03 +0100, Jiri Pirko wrote: >>> Sun, Oct 30, 2016 at 06:45:26PM CET, kubak...@wp.pl wrote: On Sun, 30 Oct 2016 17:38:36 +0100, Jiri Pirko wrote: > Sun, Oct

Re: Let's do P4

2016-10-30 Thread John Fastabend
[...] > > Yeah, I was also thinking about something similar to your Flow-API, > but we need something more generic I believe. I've heard this in a couple other forums as well but please elaborate exactly what needs to be more generic? That API is sufficient to both express the init time piece

Re: [patch net-next 00/16] mlxsw: Add Infiniband support for Mellanox switches

2016-10-30 Thread David Miller
From: Jiri Pirko Date: Fri, 28 Oct 2016 21:17:34 +0200 > This patchset adds basic Infiniband support for SwitchX-2, Switch-IB > and Switch-IB-2 ASIC drivers. This depended upon the bug fixes which were only in 'net' until a few hours ago. Please state this explicitly in the

Re: [RFC PATCH 01/13] pinctrl: meson: Add GXL pinctrl definitions

2016-10-30 Thread Rob Herring
On Fri, Oct 21, 2016 at 04:40:26PM +0200, Neil Armstrong wrote: > Add support for the Amlogic Meson GXL SoC, this is a partially complete > definition only based on the Amlogic Vendor tree. > > This definition differs a lot from the GXBB and needs a separate entry. > > Signed-off-by: Neil

Re: [PATCH] net: stmmac: Add OXNAS Glue Driver

2016-10-30 Thread Rob Herring
On Fri, Oct 21, 2016 at 10:44:45AM +0200, Neil Armstrong wrote: > Add Synopsys Designware MAC Glue layer for the Oxford Semiconductor OX820. > > Signed-off-by: Neil Armstrong > --- > .../devicetree/bindings/net/oxnas-dwmac.txt| 44 + It's preferred that

Re: [PATCH net-next 3/4] bpf: BPF for lightweight tunnel encapsulation

2016-10-30 Thread Tom Herbert
On Sun, Oct 30, 2016 at 4:58 AM, Thomas Graf wrote: > Register two new BPF prog types BPF_PROG_TYPE_LWT_IN and > BPF_PROG_TYPE_LWT_OUT which are invoked if a route contains a > LWT redirection of type LWTUNNEL_ENCAP_BPF. > > The separate program types are required because

[net-next PATCH 5/7] stmmac: dwmac-sti: move clk_prepare_enable out of init and add error handling

2016-10-30 Thread Joachim Eastwood
Add clock error handling to probe and in the process move clock enabling out of sti_dwmac_init() to make this easier. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 19 +++ 1 file changed, 15 insertions(+), 4

[net-next PATCH 7/7] stmmac: dwmac-sti: remove unused priv dev member

2016-10-30 Thread Joachim Eastwood
The dev member of struct sti_dwmac is not used anywhere in the driver so lets just remove it. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[net-next PATCH 4/7] stmmac: dwmac-sti: move st,gmac_en parsing to sti_dwmac_parse_data

2016-10-30 Thread Joachim Eastwood
The sti_dwmac_init() function is called both from probe and resume. Since DT properties doesn't change between suspend/resume cycles move parsing of this parameter into sti_dwmac_parse_data() where it belongs. Signed-off-by: Joachim Eastwood ---

[net-next PATCH 6/7] stmmac: dwmac-sti: clean up and rename sti_dwmac_init

2016-10-30 Thread Joachim Eastwood
Rename sti_dwmac_init to sti_dwmac_set_phy_mode which is a better description for what it really does. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

[net-next PATCH 3/7] stmmac: dwmac-sti: add PM ops and resume function

2016-10-30 Thread Joachim Eastwood
Implement PM callbacks and driver remove in the driver instead of relying on the init/exit hooks in stmmac_platform. This gives the driver more flexibility in how the code is organized. Eventually the init/exit callbacks will be deprecated in favor of the standard PM callbacks and driver remove

[net-next PATCH 2/7] stmmac: dwmac-sti: remove clk NULL checks

2016-10-30 Thread Joachim Eastwood
Since sti_dwmac_parse_data() sets dwmac->clk to NULL if not clock was provided in DT and NULL is a valid clock there is no need to check for NULL before using this clock. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 10 -- 1

[net-next PATCH 1/7] stmmac: dwmac-sti: remove useless of_node check

2016-10-30 Thread Joachim Eastwood
Since dwmac-sti is a DT only driver checking for OF node is not necessary. Signed-off-by: Joachim Eastwood --- drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c

[net-next PATCH 0/7] stmmac: dwmac-sti refactor+cleanup

2016-10-30 Thread Joachim Eastwood
This patch set aims to remove the init/exit callbacks from the dwmac-sti driver and instead use standard PM callbacks. Doing this will also allow us to cleanup the driver. Eventually the init/exit callbacks will be deprecated and removed from all drivers dwmac-* except for dwmac-generic. Drivers

Re: Let's do P4

2016-10-30 Thread Jiri Pirko
Sun, Oct 30, 2016 at 07:44:43PM CET, kubak...@wp.pl wrote: >On Sun, 30 Oct 2016 19:01:03 +0100, Jiri Pirko wrote: >> Sun, Oct 30, 2016 at 06:45:26PM CET, kubak...@wp.pl wrote: >> >On Sun, 30 Oct 2016 17:38:36 +0100, Jiri Pirko wrote: >> >> Sun, Oct 30, 2016 at 11:26:49AM CET, tg...@suug.ch

Re: Let's do P4

2016-10-30 Thread Jakub Kicinski
On Sun, 30 Oct 2016 19:01:03 +0100, Jiri Pirko wrote: > Sun, Oct 30, 2016 at 06:45:26PM CET, kubak...@wp.pl wrote: > >On Sun, 30 Oct 2016 17:38:36 +0100, Jiri Pirko wrote: > >> Sun, Oct 30, 2016 at 11:26:49AM CET, tg...@suug.ch wrote: > [...] > [...] > >> [...] > >> [...] > >>

Re: Let's do P4

2016-10-30 Thread Jiri Pirko
Sun, Oct 30, 2016 at 06:45:26PM CET, kubak...@wp.pl wrote: >On Sun, 30 Oct 2016 17:38:36 +0100, Jiri Pirko wrote: >> Sun, Oct 30, 2016 at 11:26:49AM CET, tg...@suug.ch wrote: >> >On 10/30/16 at 08:44am, Jiri Pirko wrote: >> >> Sat, Oct 29, 2016 at 06:46:21PM CEST, john.fastab...@gmail.com wrote:

Re: Let's do P4

2016-10-30 Thread Jakub Kicinski
On Sun, 30 Oct 2016 17:38:36 +0100, Jiri Pirko wrote: > Sun, Oct 30, 2016 at 11:26:49AM CET, tg...@suug.ch wrote: > >On 10/30/16 at 08:44am, Jiri Pirko wrote: > >> Sat, Oct 29, 2016 at 06:46:21PM CEST, john.fastab...@gmail.com wrote: > [...] > [...] > [...] > [...] > > > >My

Re: [PATCH net-next 0/2] mlx4 XDP TX refactor

2016-10-30 Thread David Miller
From: Tariq Toukan Date: Sun, 30 Oct 2016 18:21:26 +0200 > Hi Dave, > > This series makes Brenden's fix unneeded: > 958b3d396d7f ("net/mlx4_en: fixup xdp tx irq to match rx") > > The fix got into net, but yet to be in net-next. > > Should I wait with this series and

[PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup

2016-10-30 Thread Xin Long
Prior to this patch, it used a local variable to save the transport that is looked up by __sctp_lookup_association(), and didn't return it back. But in sctp_rcv, it is used to initialize chunk->transport. So when hitting this, even if it found the transport, it was still initializing

[PATCH net-next 2/7] qed: Add nvram selftest

2016-10-30 Thread Yuval Mintz
Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_hsi.h | 4 + drivers/net/ethernet/qlogic/qed/qed_main.c | 1 + drivers/net/ethernet/qlogic/qed/qed_mcp.c | 94 ++ drivers/net/ethernet/qlogic/qed/qed_mcp.h |

[PATCH net-next 4/7] qede: Decouple ethtool caps from qed

2016-10-30 Thread Yuval Mintz
While the qed_lm_maps is closely tied with the QED_LM_* defines, when iterating over the array use actual size instead of the qed define to prevent future possible issues. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 4 ++-- 1 file

[PATCH net-next 6/7] qed: Use VF-queue feature

2016-10-30 Thread Yuval Mintz
Driver sets several restrictions about the number of supported VFs according to available HW/FW resources. This creates a problem as there are constellations which can't be supported [as limitation don't accurately describe the resources], as well as holes where enabling IOV would fail due to

[PATCH net-next 3/7] qed*: Add support for WoL

2016-10-30 Thread Yuval Mintz
Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed.h | 11 - drivers/net/ethernet/qlogic/qed/qed_dev.c | 19 - drivers/net/ethernet/qlogic/qed/qed_hsi.h | 4 ++ drivers/net/ethernet/qlogic/qed/qed_main.c | 29

[PATCH net-next 5/7] qed: Learn of RDMA capabilities per-device

2016-10-30 Thread Yuval Mintz
Today, RDMA capabilities are learned from management firmware which provides a per-device indication for all interfaces. Newer management firmware is capable of providing a per-device indication [would later be extended to either RoCE/iWARP]. Try using this newer learning mechanism, but fallback

[PATCH net-next 7/7] qed: Learn resources from management firmware

2016-10-30 Thread Yuval Mintz
From: Tomer Tayar Currently, each interfaces assumes it receives an equal portion of HW/FW resources, but this is wasteful - different partitions [and specifically, parititions exposing different protocol support] might require different resources. Implement a new

[PATCH net-next 0/7] qed*: Patch series

2016-10-30 Thread Yuval Mintz
This series does several things. The bigger changes: - Add new notification APIs [& Defaults] for various fields. The series then utilizes some of those qed <-> qede APIs to bass WoL support upon. - Change the resource allocation scheme to receive the values from management firmware, instead

[PATCH net-next 1/7] qed*: Management firmware - notifications and defaults

2016-10-30 Thread Yuval Mintz
From: Sudarsana Kalluru Management firmware is interested in various tidbits about the driver - including the driver state & several configuration related fields [MTU, primtary MAC, etc.]. This adds the necessray logic to update MFW with such configurations, some of

Re: Let's do P4

2016-10-30 Thread Jiri Pirko
Sun, Oct 30, 2016 at 11:26:49AM CET, tg...@suug.ch wrote: >On 10/30/16 at 08:44am, Jiri Pirko wrote: >> Sat, Oct 29, 2016 at 06:46:21PM CEST, john.fastab...@gmail.com wrote: >> >On 16-10-29 07:49 AM, Jakub Kicinski wrote: >> >> On Sat, 29 Oct 2016 09:53:28 +0200, Jiri Pirko wrote: >> >>> Hi all.

Re: [PATCH net-next 0/2] mlx4 XDP TX refactor

2016-10-30 Thread Tariq Toukan
Hi Dave, This series makes Brenden's fix unneeded: 958b3d396d7f ("net/mlx4_en: fixup xdp tx irq to match rx") The fix got into net, but yet to be in net-next. Should I wait with this series and send a re-spin, with a revert of the fix, once it gets into net-next? Regards, Tariq On

Re: [PATCH net-next 2/2] net/mlx4_en: Refactor the XDP forwarding rings scheme

2016-10-30 Thread Tariq Toukan
On 28/10/2016 4:07 AM, Alexei Starovoitov wrote: On Thu, Oct 27, 2016 at 05:52:04PM +0300, Tariq Toukan wrote: Separately manage the two types of TX rings: regular ones, and XDP. Upon an XDP set, do not borrow regular TX rings and convert them into XDP ones, but allocate new ones, unless we

Re: [PATCH for-next 00/14][PULL request] Mellanox mlx5 core driver updates 2016-10-25

2016-10-30 Thread David Miller
From: Saeed Mahameed Date: Sun, 30 Oct 2016 11:59:57 +0200 > On Fri, Oct 28, 2016 at 7:53 PM, David Miller wrote: >> >> I really disalike pull requests of this form. >> >> You add lots of datastructures and helper functions but no actual >> users

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-10-30 Thread John Heenan
Thanks for your reply. The code was tested on a Cube i9 which has an internal rtl8723bu. No other devices were tested. I am happy to accept in an ideal context hard coding macpower is undesirable, the comment is undesirable and it is wrong to assume the issue is not unique to the rtl8723bu.

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

2016-10-30 Thread Eric Dumazet
On Sun, 2016-10-30 at 05:41 +0100, Andrey Konovalov wrote: > Sorry, the warning is still there. > > I'm not sure adding sched_annotate_sleep() does anything, since it's > defined as (in case CONFIG_DEBUG_ATOMIC_SLEEP is not set): > # define sched_annotate_sleep() do { } while (0) Thanks again

Re: [PATCH net-next 5/5] ipv6: Compute multipath hash for forwarded ICMP errors from offending packet

2016-10-30 Thread Jakub Sitnicki
On Fri, Oct 28, 2016 at 02:25 PM GMT, Tom Herbert wrote: > On Fri, Oct 28, 2016 at 1:32 AM, Jakub Sitnicki wrote: >> On Thu, Oct 27, 2016 at 10:35 PM GMT, Tom Herbert wrote: >>> On Mon, Oct 24, 2016 at 2:28 AM, Jakub Sitnicki wrote: Same as for the transmit

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-10-30 Thread Jes Sorensen
John Heenan writes: > Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to set > macpower, is never 0xea. It is only ever 0x01 (first time after modprobe) > using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These results > occurs with 'Fix for

[PATCH net-next 1/4] route: Set orig_output when redirecting to lwt on locally generated traffic

2016-10-30 Thread Thomas Graf
orig_output for IPv4 was only set for dsts which hit an input route. Set it consistently for locally generated traffic as well to allow lwt to continue the dst_output() path as configured by the nexthop. Fixes: 2536862311d ("lwt: Add support to redirect dst.input") Signed-off-by: Thomas Graf

[PATCH net-next 2/4] route: Set lwtstate for local traffic and cached input dsts

2016-10-30 Thread Thomas Graf
A route on the output path hitting a RTN_LOCAL route will keep the dst associated on its way through the loopback device. On the receive path, the dst_input() call will thus invoke the input handler of the route created in the output path. Thus, lwt redirection for input must be done for dsts

[PATCH net-next 4/4] bpf: Add samples for LWT-BPF

2016-10-30 Thread Thomas Graf
This adds a set of samples demonstrating the use of lwt-bpf combined with a shell script which allows running the samples in the form of a basic selftest. The samples include: - Allowing all packets - Dropping all packets - Printing context information - Access packet data - IPv4 daddr

[PATCH net-next 3/4] bpf: BPF for lightweight tunnel encapsulation

2016-10-30 Thread Thomas Graf
Register two new BPF prog types BPF_PROG_TYPE_LWT_IN and BPF_PROG_TYPE_LWT_OUT which are invoked if a route contains a LWT redirection of type LWTUNNEL_ENCAP_BPF. The separate program types are required because manipulation of packet data is only allowed on the output and transmit path as the

[PATCH net-next 0/4] BPF for lightweight tunnel encapsulation

2016-10-30 Thread Thomas Graf
This series implements BPF program invocation from dst entries via the lightweight tunnels infrastructure. The BPF program can be attached to lwtunnel_input(), lwtunnel_output() or lwtunnel_xmit() and sees an L3 skb as context. input is read-only, output can write, xmit can write, push headers,

RFC if==else in halbtc8723b1ant.c

2016-10-30 Thread Nicholas Mc Guire
Hi ! in your commit f5b586909581 ("rtlwifi: btcoexist: Modify driver to support BT coexistence in rtl8723be") you introduced a if/else where both branches are the same but the comment in the else branch suggests that this might be unintended. from code review only I can´t say what the

Re: [bnx2] [Regression 4.8] Driver loading fails without firmware

2016-10-30 Thread Paul Menzel
Dear Baoquan, Am Samstag, den 29.10.2016, 10:55 +0800 schrieb Baoquan He: > On 10/27/16 at 03:21pm, Paul Menzel wrote: > > > > Baoquan, could you please fix this regression. My suggestion is, that > > > > you > > > > add the old code back, but check if the firmware has been loaded. If it > > >

Re: Let's do P4

2016-10-30 Thread Thomas Graf
On 10/30/16 at 08:44am, Jiri Pirko wrote: > Sat, Oct 29, 2016 at 06:46:21PM CEST, john.fastab...@gmail.com wrote: > >On 16-10-29 07:49 AM, Jakub Kicinski wrote: > >> On Sat, 29 Oct 2016 09:53:28 +0200, Jiri Pirko wrote: > >>> Hi all. > >>> > >>> The network world is divided into 2 general types of

[PATCH 1/2] rtl8xxxu: Fix for authentication failure

2016-10-30 Thread John Heenan
This fix enables the same sequence of init behaviour as the alternative working driver for the wireless rtl8723bu IC at https://github.com/lwfinger/rtl8723bu For exampe rtl8xxxu_init_device is now called each time userspace wpa_supplicant is executed instead of just once when modprobe is

[PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-10-30 Thread John Heenan
Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to set macpower, is never 0xea. It is only ever 0x01 (first time after modprobe) using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These results occurs with 'Fix for authentication failure' [PATCH 1/2] in place.

[PATCH 0/2] rtl8xxxu: Fix allows wpa_supplicant to authenticate

2016-10-30 Thread John Heenan
With the current kernel release, wpa_supplicant results in authentication failure with a Cube i9 tablet (a Surface Pro like device): Successfully initialized wpa_supplicant wlp0s20f0u7i2: SME: Trying to authenticate with 10:fe:ed:62:7a:78 (SSID='localre' freq=2417 MHz) wlp0s20f0u7i2: SME:

Re: [PATCH for-next 00/14][PULL request] Mellanox mlx5 core driver updates 2016-10-25

2016-10-30 Thread Saeed Mahameed
On Fri, Oct 28, 2016 at 7:53 PM, David Miller wrote: > > I really disalike pull requests of this form. > > You add lots of datastructures and helper functions but no actual > users of these facilities to the driver. > > Do this instead: > > 1) Add TSAR infrastructure

pull-request: wireless-drivers-next 2016-10-30

2016-10-30 Thread Kalle Valo
Hi Dave, few fixes for 4.9. I tagged this on the plane over a slow mosh connection while travelling to Plumbers so I might have done something wrong, please check more carefully than usually. For example I had to redo the signed tag because of some whitespace damage. Please let me know if there

[patch net] mlxsw: spectrum: Fix incorrect reuse of MID entries

2016-10-30 Thread Jiri Pirko
From: Ido Schimmel In the device, a MID entry represents a group of local ports, which can later be bound to a MDB entry. The lookup of an existing MID entry is currently done using the provided MC MAC address and VID, from the Linux bridge. However, this can result in an

[PATCH net] qede: Fix statistics' strings for Tx/Rx queues

2016-10-30 Thread Yuval Mintz
When an interface is configured to use Tx/Rx-only queues, the length of the statistics would be shortened to accomodate only the statistics required per-each queue, and the values would be provided accordingly. However, the strings provided would still contain both Tx and Rx strings for each one

Re: Let's do P4

2016-10-30 Thread Jiri Pirko
Sat, Oct 29, 2016 at 06:46:21PM CEST, john.fastab...@gmail.com wrote: >On 16-10-29 07:49 AM, Jakub Kicinski wrote: >> On Sat, 29 Oct 2016 09:53:28 +0200, Jiri Pirko wrote: >>> Hi all. >>> >>> The network world is divided into 2 general types of hw: >>> 1) network ASICs - network specific silicon,