Re: pull-request: wireless-drivers-next 2016-10-30

2016-10-31 Thread Kalle Valo
David Miller writes: > From: Kalle Valo > Date: Sun, 30 Oct 2016 11:20:46 +0200 > >> few fixes for 4.9. I tagged this on the plane over a slow mosh >> connection while travelling to Plumbers so I might have done something >> wrong, please check more

Re: [PATCH net-next v2 5/5] lwtunnel: Limit number of recursions on output to 5

2016-10-31 Thread kbuild test robot
Hi Thomas, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Thomas-Graf/bpf-BPF-for-lightweight-tunnel-encapsulation/20161101-084038 config: arm64-allmodconfig (attached as .config) compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705

Re: [PATCH 1/1] xen-netfront: do not cast grant table reference to signed short

2016-10-31 Thread Dongli Zhang
Hi David and Jan, I did more testing on the code. Casting to either (long) or (unsigned long) would be fine. However, there is still an issue that ref is of type uint32_t and IS_ERR_VALUE((unsigned long)ref) would not return true when ref=-ENOSPC (or other error code). IS_ERR_VALUE((long)ref)

Re: [PATCH 00/12] xen: add common function for reading optional value

2016-10-31 Thread Juergen Gross
On 31/10/16 18:08, David Miller wrote: > From: Juergen Gross > Date: Mon, 31 Oct 2016 17:48:18 +0100 > >> There are multiple instances of code reading an optional unsigned >> parameter from Xenstore via xenbus_scanf(). Instead of repeating the >> same code over and over add a

Re: [PATCH] net: smsc911x: Synchronize the runtime PM status during system suspend

2016-10-31 Thread Rafael J. Wysocki
On Thursday, October 27, 2016 01:53:03 PM Ulf Hansson wrote: > On 27 October 2016 at 13:41, Geert Uytterhoeven wrote: > > Hi Ulf, > > > > On Thu, Oct 27, 2016 at 1:23 PM, Ulf Hansson wrote: > >> The smsc911c driver puts its device into low power

[PATCH net-next 09/11] net: dsa: mv88e6xxx: add port's RGMII delay setter

2016-10-31 Thread Vivien Didelot
Some chips such as 88E6352 and 88E6390 can be programmed to add delays to RXCLK for IND inputs or to GTXCLK for OUTD outputs when port is in RGMII mode. Add a port function to program such delays according to the provided PHY interface mode. Signed-off-by: Vivien Didelot

[PATCH net-next 11/11] net: dsa: mv88e6xxx: setup port's MAC

2016-10-31 Thread Vivien Didelot
Now that we have setters to configure the port's MAC, use them to refactor the port setup and adjust_link code. Note that port's MAC speed, duplex or RGMII delay must not be changed unless the port's link is forced down. So wrap all that in a mv88e6xxx_port_ctrl_mac function. Signed-off-by:

[PATCH net-next 03/11] net: dsa: mv88e6xxx: add port vlan map setter

2016-10-31 Thread Vivien Didelot
Add a port function to access the Port Based VLAN Map register. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 14 ++ drivers/net/dsa/mv88e6xxx/port.c | 25 + drivers/net/dsa/mv88e6xxx/port.h | 2 ++

[PATCH net-next 06/11] net: dsa: mv88e6xxx: add port 802.1Q mode setter

2016-10-31 Thread Vivien Didelot
Add port functions to set the port 802.1Q mode. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 33 ++--- drivers/net/dsa/mv88e6xxx/port.c | 32

[PATCH net-next 02/11] net: dsa: mv88e6xxx: add port state setter

2016-10-31 Thread Vivien Didelot
Add the port STP state setter to the port files. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 49 drivers/net/dsa/mv88e6xxx/port.c | 31 +

[PATCH net-next 04/11] net: dsa: mv88e6xxx: add port FID accessors

2016-10-31 Thread Vivien Didelot
Add functions to port files to access the ports default FID. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 77 +++- drivers/net/dsa/mv88e6xxx/port.c | 67 ++

[PATCH net-next 08/11] net: dsa: mv88e6xxx: add port duplex setter

2016-10-31 Thread Vivien Didelot
Similarly to port's link, add setter to force port's half duplex, full duplex or let normal duplex detection occurs. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 17 + drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 7

[PATCH net-next 07/11] net: dsa: mv88e6xxx: add port link setter

2016-10-31 Thread Vivien Didelot
Most of the chips will have a port register control bits to force the port's link up, down, or let normal link detection occurs. Implement such operation to use it later when setting duplex, etc. Signed-off-by: Vivien Didelot ---

[PATCH net-next 00/11] net: dsa: mv88e6xxx: refine port operations

2016-10-31 Thread Vivien Didelot
The Marvell chips have one internal SMI device per port, containing a set of registers used to configure a port's link, STP state, default VLAN or addresses database, etc. This patchset creates port files to implement the port operations as described in datasheets, and extend the chip ops

[PATCH net-next 01/11] net: dsa: mv88e6xxx: add port files

2016-10-31 Thread Vivien Didelot
The Marvell switches contains one internal SMI device per port, called "Port Registers". Depending on the model, the addresses of these devices start from 0x0, 0x8 or 0x10. Start moving Port Registers specific code to their own files. Signed-off-by: Vivien Didelot

[PATCH net-next 10/11] net: dsa: mv88e6xxx: add port's MAC speed setter

2016-10-31 Thread Vivien Didelot
While the two bits for link, duplex or RGMII delays are used the same way on chips supporting the said feature, the two bits for speed have different meaning for most of the chips out there. Speed value is stored in bits 1:0, 0x3 means unforce (normal detection). Some chips reuse values for

[PATCH net-next 05/11] net: dsa: mv88e6xxx: add port PVID accessors

2016-10-31 Thread Vivien Didelot
Add port functions to access the ports default VID. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 51 drivers/net/dsa/mv88e6xxx/port.c | 38 ++

Re: [PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

2016-10-31 Thread Joe Perches
On Tue, 2016-11-01 at 08:15 +1000, John Heenan wrote: > > On 1 November 2016 at 07:25, Jes Sorensen wrote: > > > > John Heenan writes: > > > The rtl8723bu wireless IC shows evidence of a more agressive approach to > > > power saving, powering down its RF

Re: [bnx2] [Regression 4.8] Driver loading fails without firmware

2016-10-31 Thread Baoquan He
On 10/31/16 at 11:43am, Paul Menzel wrote: > Dear Baoquan, > > > On 10/31/16 11:09, Baoquan He wrote: > > > On 10/26/16 at 12:31pm, Paul Menzel wrote: > > > Baoquan, could you please fix this regression. My suggestion is, that you > > > add the old code back, but check if the firmware has been

Re: [PATCH net-next v2 3/5] bpf: BPF for lightweight tunnel encapsulation

2016-10-31 Thread kbuild test robot
Hi Thomas, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Thomas-Graf/bpf-BPF-for-lightweight-tunnel-encapsulation/20161101-084038 config: x86_64-randconfig-s0-11010954 (attached as .config) compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7 reproduce:

Re: [PATCH net-next v2 3/5] bpf: BPF for lightweight tunnel encapsulation

2016-10-31 Thread kbuild test robot
Hi Thomas, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Thomas-Graf/bpf-BPF-for-lightweight-tunnel-encapsulation/20161101-084038 config: m68k-sun3_defconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 4.9.0 reproduce: wget

Re: pull-request: can 2016-10-31

2016-10-31 Thread David Miller
From: Marc Kleine-Budde Date: Mon, 31 Oct 2016 21:36:18 +0100 > this is a pull request of two patches for the upcoming v4.9 release. > > The first patch is by Lukas Resch for the sja1000 plx_pci driver that adds > support for Moxa CAN devices. The second patch is by Oliver

Re: [PATCH v2 net-next] net: set SK_MEM_QUANTUM to 4096

2016-10-31 Thread David Miller
From: Eric Dumazet Date: Mon, 31 Oct 2016 13:32:55 -0700 > From: Eric Dumazet > > Systems with large pages (64KB pages for example) do not always have > huge quantity of memory. > > A big SK_MEM_QUANTUM value leads to fewer interactions with the >

Re: [PATCH -next] net: cris: make eth_v10.c explicitly non-modular

2016-10-31 Thread David Miller
From: Paul Gortmaker Date: Mon, 31 Oct 2016 15:32:16 -0400 > The Makefile/Kconfig currently controlling compilation of this code is: > > drivers/net/cris/Makefile:obj-$(CONFIG_ETRAX_ARCH_V10) += eth_v10.o > > arch/cris/Kconfig:config ETRAX_ARCH_V10 >

Re: [PATCH] unix: escape all null bytes in abstract unix domain socket

2016-10-31 Thread Isaac Boukris
Hi David, thanks for looking at it. On Mon, Oct 31, 2016 at 9:31 PM, David Miller wrote: > From: Isaac Boukris > Date: Sat, 29 Oct 2016 22:20:20 +0300 > >> Abstract unix domain socket may embed null characters, >> these should be translated to '@' when

Re: [PATCH net] bgmac: stop clearing DMA receive control register right after it is set

2016-10-31 Thread David Miller
From: Andy Gospodarek Date: Mon, 31 Oct 2016 13:32:03 -0400 > Current bgmac code initializes some DMA settings in the receive control > register for some hardware and then immediately clears those settings. > Not clearing those settings results in ~420Mbps *improvement* in >

[PATCH v2] unix: escape all null bytes in abstract unix domain socket

2016-10-31 Thread Isaac Boukris
Abstract unix domain socket may embed null characters, these should be translated to '@' when printed out to proc the same way the null prefix is currently being translated. This helps for tools such as netstat, lsof and the proc based implementation in ss to show all the significant bytes of the

[PATCH net-next v2 4/5] bpf: Add samples for LWT-BPF

2016-10-31 Thread Thomas Graf
This adds a set of samples demonstrating the use of lwt-bpf combined with a shell script which allows running the samples in the form of a basic selftest. The samples include: - Allowing all packets - Dropping all packets - Printing context information - Access packet data - IPv4 daddr

[PATCH net-next v2 0/5] bpf: BPF for lightweight tunnel encapsulation

2016-10-31 Thread Thomas Graf
{Open question: Tom brought up the question on whether it is safe to modify the packet in artbirary ways before dst_output(). This is the equivalent to a raw socket injecting illegal headers. This v2 currently assumes that dst_output() is ready to accept invalid header values. This needs to be

[PATCH net-next v2 2/5] route: Set lwtstate for local traffic and cached input dsts

2016-10-31 Thread Thomas Graf
A route on the output path hitting a RTN_LOCAL route will keep the dst associated on its way through the loopback device. On the receive path, the dst_input() call will thus invoke the input handler of the route created in the output path. Thus, lwt redirection for input must be done for dsts

[PATCH net-next v2 5/5] lwtunnel: Limit number of recursions on output to 5

2016-10-31 Thread Thomas Graf
Signed-off-by: Thomas Graf --- net/core/lwtunnel.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c index 554d901..6363d0b 100644 --- a/net/core/lwtunnel.c +++ b/net/core/lwtunnel.c @@ -231,6 +231,10 @@

[PATCH net-next v2 3/5] bpf: BPF for lightweight tunnel encapsulation

2016-10-31 Thread Thomas Graf
Register two new BPF prog types BPF_PROG_TYPE_LWT_IN and BPF_PROG_TYPE_LWT_OUT which are invoked if a route contains a LWT redirection of type LWTUNNEL_ENCAP_BPF. The separate program types are required because manipulation of packet data is only allowed on the output and transmit path as the

[PATCH net-next v2 1/5] route: Set orig_output when redirecting to lwt on locally generated traffic

2016-10-31 Thread Thomas Graf
orig_output for IPv4 was only set for dsts which hit an input route. Set it consistently for locally generated traffic as well to allow lwt to continue the dst_output() path as configured by the nexthop. Fixes: 2536862311d ("lwt: Add support to redirect dst.input") Signed-off-by: Thomas Graf

[PULL] virtio: tests, cleanups and fixes

2016-10-31 Thread Michael S. Tsirkin
The following changes since commit a909d3e636995ba7c349e2ca5dbb528154d4ac30: Linux 4.9-rc3 (2016-10-29 13:52:02 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

[PATCH] net: qcom/emac: use correct value for SGMII_LN_UCDR_SO_GAIN_MODE0

2016-10-31 Thread Timur Tabi
The documentation says that SGMII_LN_UCDR_SO_GAIN_MODE0 should be set to 0, not 6, on the Qualcomm Technologies QDF2432. Signed-off-by: Timur Tabi --- drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next 0/2] drivers: net: xgene: Fix coalescing bugs

2016-10-31 Thread Iyappan Subramanian
This patch set fixes the following, 1. Since ethernet v1 hardware has a bug related to coalescing, disabling this feature 2. Fixing ethernet v2 hardware, interrupt trigger region id to 2, to kickoff coalescing Signed-off-by: Iyappan Subramanian

[PATCH net-next 2/2] drivers: net: xgene: fix: Coalescing values for v2 hardware

2016-10-31 Thread Iyappan Subramanian
Changing the interrupt trigger region id to 2 and the corresponding threshold set0/set1 values to 8/16. Signed-off-by: Iyappan Subramanian Signed-off-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.h| 2 ++

[PATCH net-next 1/2] drivers: net: xgene: fix: Disable coalescing on v1 hardware

2016-10-31 Thread Iyappan Subramanian
Since ethernet v1 hardware has a bug related to coalescing, disabling this feature. Signed-off-by: Iyappan Subramanian Signed-off-by: Toan Le --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 12

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-10-31 Thread Ido Schimmel
On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote: > On Mon, 2016-10-31 at 23:13 +0200, ido...@idosch.org wrote: > > From: Ido Schimmel > > > > When registering a FIB notifier block we should notify the caller of > > already existing FIB entries and rules, as it

[PATCH net-next] net: Enable support for VRF with ipv4 multicast

2016-10-31 Thread David Ahern
Enable support for IPv4 multicast: - similar to unicast the flow struct is updated to L3 master device if relevant prior to calling fib_rules_lookup. The table id is saved to the lookup arg so the rule action for ipmr can return the table associated with the device. - ip_mr_forward needs to

[net-next 01/22] i40e: Add missing \n to end of dev_err message

2016-10-31 Thread Jeff Kirsher
From: Colin Ian King Trival fix, dev_err message is missing a \n, so add it. Signed-off-by: Colin Ian King Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 03/22] i40e: make use of __dev_uc_sync and __dev_mc_sync

2016-10-31 Thread Jeff Kirsher
From: Jacob Keller The kernel provides __dev_uc_sync and __dev_mc_sync in order for drivers which need individual notification of add and delete for each filter. These functions allow us to vastly simplify our .set_rx_mode handler. We need to implement two functions for

[net-next 11/22] i40e: avoid looping to check whether we're in VLAN mode

2016-10-31 Thread Jeff Kirsher
From: Jacob Keller We determine that a VSI is in vlan_mode whenever it has any filters with a VLAN other than -1 (I40E_VLAN_ALL). The previous method of doing so was to perform a loop whenever we needed the check. However, we can notice that only place where filters are

[net-next 04/22] i40e: move i40e_put_mac_in_vlan and i40e_del_mac_all_vlan

2016-10-31 Thread Jeff Kirsher
From: Jacob Keller A future patch will be modifying these functions and making a call to a static function which currently is defined after these functions. Move them in a separate patch to ease review and ensure the moved code is correct. Change-ID:

[net-next 13/22] i40e: correct check for reading TSYNINDX from the receive descriptor

2016-10-31 Thread Jeff Kirsher
From: Jacob Keller When hardware has taken a timestamp for a received packet, it indicates which RXTIME register the timestamp was placed in by some bits in the receive descriptor. It uses 3 bits, one to indicate if the descriptor index is valid (ie: there was a

[net-next 18/22] i40e: Reorder logic for coalescing RS bits

2016-10-31 Thread Jeff Kirsher
From: Alexander Duyck This patch reorders the logic at the end of i40e_tx_map to address the fact that the logic was rather convoluted and much larger than it needed to be. In order to try and coalesce the code paths I have updated some of the comments and

[net-next 02/22] i40e: drop is_vf and is_netdev fields in struct i40e_mac_filter

2016-10-31 Thread Jeff Kirsher
From: Jacob Keller Originally the is_vf and is_netdev fields were added in order to distinguish between VF and netdev filters in a single VSI. However, it can be noted that we use separate VSI for SRIOV VFs and for netdev VSI. Thus, since a single VSI should only ever

[net-next 06/22] i40e: When searching all MAC/VLAN filters, ignore removed filters

2016-10-31 Thread Jeff Kirsher
From: Jacob Keller When adding new MAC address filters, the driver determines if it should behave in VLAN mode (where all MAC addresses get assigned to every existing VLAN) or in non-VLAN mode where MAC addresses get assigned the VLAN_ANY identifier. Under some

[net-next 08/22] i40e: store MAC/VLAN filters in a hash with the MAC Address as key

2016-10-31 Thread Jeff Kirsher
From: Jacob Keller Replace the mac_filter_list with a static size hash table of 8bits. The primary advantage of this is a decrease in latency of operations related to searching for specific MAC filters, including .set_rx_mode. Using a linked list resulted in several

[net-next 10/22] i40e: fix MAC filters when removing VLANs

2016-10-31 Thread Jeff Kirsher
From: Alan Brady Currently there exists a bug where adding at least one VLAN and then removing all VLANs leaves the mac filters for the VSI with an incorrect value for 'vid' which indicates the mac filter's VLAN status. The current implementation for handling the removal

[net-next 12/22] i40e: remove duplicate add/delete adminq command code for filters

2016-10-31 Thread Jeff Kirsher
From: Jacob Keller We duplicate some code around adding and deleting filters using the adminq interface. This is prone to errors in case there are bugs. Use functions which extract the logic to their own portion so that we don't duplicate it twice in code. Change-ID:

[net-next 00/22][pull request] 40GbE Intel Wired LAN Driver Updates 2016-10-31

2016-10-31 Thread Jeff Kirsher
This series contains updates to i40e and i40evf. Colin Ian King fixes a minor issue with dev_err message where a new line character was missing from the end of the message. Jake provides several most of the changes in the series, starting with dropping the is_vf and is_netdev fields in the

[net-next 19/22] i40e: clear mac filter count on reset

2016-10-31 Thread Jeff Kirsher
From: Mitch Williams When a VF is reset, it gets a new VSI, so all of its MAC filters go away. Correctly set the number of filters to 0 when freeing VF resources. This corrects a problem with failure to add filters when the VF driver is reloaded. Change-ID:

[net-next 17/22] i40e: Add common function for finding VSI by type

2016-10-31 Thread Jeff Kirsher
From: Alexander Duyck This patch adds a common method for finding a VSI by type. The main motivation for doing this is that the Flow Director path actually had two ways of handling this, one stopped on first match and one did not. This patch makes it so that all

[net-next 07/22] i40e: implement __i40e_del_filter and use where applicable

2016-10-31 Thread Jeff Kirsher
From: Jacob Keller When inside a loop where we call i40e_del_filter we use an O(n^2) pattern where i40e_del_filter calls i40e_find_filter for us. We can avoid this O(n^2) logic by factoring a function, __i40e_del_filter() out from the i40e_del_filter code. This allows

[net-next 05/22] i40e: refactor i40e_put_mac_in_vlan to avoid changing f->vlan

2016-10-31 Thread Jeff Kirsher
From: Jacob Keller When a PVID has been assigned to a VSI, the function i40e_put_mac_in_vlan arbitrarily modifies all filters to have the same VLAN. This is obviously incorrect because it could be modifying active filters without putting them into the NEW state. The

[net-next 16/22] i40evf: avoid an extra msleep while

2016-10-31 Thread Jeff Kirsher
From: Jacob Keller Remove the second call to msleep outside the loop, and move the msleep within the loop as the first step. This guarantees that a single loop will wait the minimum time first, and then after the reset finishes we no longer need an extra msleep.

[net-next 09/22] i40e: properly cleanup on allocation failure in i40e_sync_vsi_filters

2016-10-31 Thread Jeff Kirsher
From: Jacob Keller Currently, we fail to correctly restore filters on the temporary add list when we fail to allocate memory either for deletion or addition. Replace calls to "goto out;" with calls to a new location that correctly handles memory allocation failures.

[net-next 22/22] i40e: removed unreachable code

2016-10-31 Thread Jeff Kirsher
From: Filip Sadowski Removed some of unnecessary if statements and unreachable code found by static code analysis tool. The return value of i40e_vsi_control_rings(..., false) is always 0. So, test for non-zero will never be true. The function has been split into "int

[net-next 15/22] i40e: replace PTP Rx timestamp hang logic

2016-10-31 Thread Jeff Kirsher
From: Jacob Keller The current Rx timestamp hang logic is not very robust because it does not notice a register is hung until all four timestamps have been latched and we wait a full 5 seconds. Replace this logic with a newer Rx hang detection based on storing the

[net-next 21/22] i40e: Implementation of ERROR state for NVM update state machine

2016-10-31 Thread Jeff Kirsher
From: Maciej Sosin This patch adds I40E_NVMUPD_STATE_ERROR state for NVM update. Without this patch driver has no possibility to return NVM image write failure.This state is being set when ARQ rises error. arq_last_status is also updated every time when ARQ event comes,

[net-next 14/22] i40e: use a mutex instead of spinlock in PTP user entry points

2016-10-31 Thread Jeff Kirsher
From: Jacob Keller We need a locking mechanism to protect the hardware SYSTIME register which is split over 2 values, and has internal hardware latching. We can't allow multiple accesses at the same time. However The spinlock_t is overkill here, especially use of

[net-next 20/22] i40e: Fix for division by zero

2016-10-31 Thread Jeff Kirsher
From: Michal Kosiarz For some cases when reading from device are incorrect or image is incorrect, this part of code causes crash due to division by zero. Change-ID: I8961029a7a87b0a479995823ef8fcbf6471405e1 Signed-off-by: Michal Kosiarz

Re: [PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

2016-10-31 Thread Barry Day
On Mon, Oct 31, 2016 at 05:25:12PM -0400, Jes Sorensen wrote: > As mentioned previously, if this is to be changed here, it has to be > matched in the _stop section too. It also has to be investigated exactly > why this matters for 8723bu. It is possible this matters for other > devices, but we

Re: [PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

2016-10-31 Thread John Heenan
On 1 November 2016 at 07:25, Jes Sorensen wrote: > John Heenan writes: >> The rtl8723bu wireless IC shows evidence of a more agressive approach to >> power saving, powering down its RF side when there is no wireless >> interfacing but leaving USB

[PATCH v3 net-next] lan78xx: Use irq_domain for phy interrupt from USB Int. EP

2016-10-31 Thread Woojung.Huh
From: Woojung Huh To utilize phylib with interrupt fully than handling some of phy stuff in the MAC driver, create irq_domain for USB interrupt EP of phy interrupt and pass the irq number to phy_connect_direct() instead of PHY_IGNORE_INTERRUPT. Idea comes from

Re: [PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

2016-10-31 Thread Jes Sorensen
John Heenan writes: > The rtl8723bu wireless IC shows evidence of a more agressive approach to > power saving, powering down its RF side when there is no wireless > interfacing but leaving USB interfacing intact. This makes the wireless > IC more suitable for use in devices which

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-10-31 Thread Eric Dumazet
On Mon, 2016-10-31 at 23:13 +0200, ido...@idosch.org wrote: > From: Ido Schimmel > > When registering a FIB notifier block we should notify the caller of > already existing FIB entries and rules, as it would otherwise have an > incomplete view of the FIB tables. This is

Re: XDP question - how much can BPF change in xdp_buff?

2016-10-31 Thread Thomas Graf
On 10/31/16 at 12:22pm, John Fastabend wrote: > On 16-10-31 11:57 AM, David Miller wrote: > > My understanding is that the eBPF program would be responsible > > for updating the checksum if it mangles the packet in such a > > way that such a fixup would be required. > > > > For XDP we will

[PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-10-31 Thread idosch
From: Ido Schimmel When registering a FIB notifier block we should notify the caller of already existing FIB entries and rules, as it would otherwise have an incomplete view of the FIB tables. This is especially important for switchdev drivers that support FIB offloads.

Re: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames

2016-10-31 Thread Timur Tabi
Florian Fainelli wrote: pauseasym_pauseenable tx?enable rx? ------- 0 0 No No 0 1 YesNo 1 0 YesYes 1 1 No

RE: [PATCH v2 net-next]

2016-10-31 Thread Woojung.Huh
> -Original Message- > From: Woojung Huh - C21699 > Sent: Monday, October 31, 2016 5:04 PM > To: da...@davemloft.net; 'Florian Fainelli'; and...@lunn.ch; > netdev@vger.kernel.org > Cc: UNGLinuxDriver > Subject: [PATCH v2 net-next] > > From: Woojung Huh > > To

[PATCH v2 net-next]

2016-10-31 Thread Woojung.Huh
From: Woojung Huh To utilize phylib with interrupt fully than handling some of phy stuff in the MAC driver, create irq_domain for USB interrupt EP of phy interrupt and pass the irq number to phy_connect_direct() instead of PHY_IGNORE_INTERRUPT. Idea comes from

[PATCH net-next 02/14] nfp: remove support for nfp3200

2016-10-31 Thread Jakub Kicinski
Drop all code related to nfp3200. It was never widely deployed as a NIC. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h | 7 +- .../net/ethernet/netronome/nfp/nfp_net_common.c| 95 ++

[PATCH net-next 07/14] nfp: use alloc_frag() and build_skb()

2016-10-31 Thread Jakub Kicinski
Speed up RX processing by moving to the alloc_frag()/build_skb() paradigm. Since we're no longer mapping the entire buffer for DMA add helpers which take care of calculating offsets and lengths. Signed-off-by: Jakub Kicinski ---

[PATCH net-next 03/14] nfp: remove unnecessary call to ether_setup()

2016-10-31 Thread Jakub Kicinski
ether_setup() will be invoked by alloc_etherdev_mqs(), no need to call it again. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH net-next 05/14] nfp: centralize the buffer size calculation

2016-10-31 Thread Jakub Kicinski
Add a helper function to calculate the buffer size at run time. Buffer lengths will now depend on the FW prepend configuration instead of assuming the most space consuming configuration and defaulting to 2k buffers at initialization time. Signed-off-by: Jakub Kicinski

[PATCH net-next 11/14] nfp: use unsigned int for vector/ring counts

2016-10-31 Thread Jakub Kicinski
Use unsigned int consistently for vector/ring counts. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h| 17 + drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 5 +++-- 2 files changed, 12 insertions(+), 10

[PATCH net-next 13/14] nfp: replace num_irqs with max_r_vecs

2016-10-31 Thread Jakub Kicinski
num_irqs is not used anywhere, replace it with max_r_vecs which holds number of allocated RX/TX vectors and is going to be useful soon. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net.h| 4 ++--

[PATCH net-next 12/14] nfp: remove nfp_net_irqs_wanted()

2016-10-31 Thread Jakub Kicinski
nfp_net_irqs_wanted() doesn't really encapsulate much logic, remove it and inline the calculations. Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/nfp_net_common.c| 27 -- 1 file changed, 4 insertions(+), 23 deletions(-)

[PATCH net-next 10/14] nfp: create separate define for max number of vectors

2016-10-31 Thread Jakub Kicinski
We are currently using define for max TX rings to allocate IRQ vectors. It's OK since the max number of rings for TX and RX are currently the same, but lets make the code nicer by taking max of the two. Signed-off-by: Jakub Kicinski ---

[PATCH net-next 14/14] nfp: bring back support for different ring counts

2016-10-31 Thread Jakub Kicinski
We used to always allocate the same number of TX and RX rings so the support for having r_vectors without one of the rings was dropped. That makes us, however, unnecessarily limited to 8 TX rings (8 is the Linux RSS default) most of the time. Also we are about to add channel count configuration

[PATCH net-next 09/14] nfp: use AND instead of modulo to get ring indexes

2016-10-31 Thread Jakub Kicinski
We already force ring sizes to be power of 2 so replace modulo operations with AND (size - 1) in index calculations. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 14 +++--- 1 file changed, 7 insertions(+), 7

[PATCH net-next 06/14] nfp: add buffer drop/recycle helper for RX

2016-10-31 Thread Jakub Kicinski
nfp_net_rx() is quite long already and about to get longer. Move buffer drop/recycle to a helper. Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/nfp_net_common.c| 27 ++ 1 file changed, 17 insertions(+), 10 deletions(-)

[PATCH net-next 08/14] nfp: add separate buffer allocation function for napi

2016-10-31 Thread Jakub Kicinski
Introduce a separate buffer allocation function to be called from NAPI. We can make assumptions about the context and buffer size. Signed-off-by: Jakub Kicinski --- .../net/ethernet/netronome/nfp/nfp_net_common.c| 23 -- 1 file changed, 21

[PATCH net-next 04/14] nfp: remove inline attributes and dead code

2016-10-31 Thread Jakub Kicinski
Don't declare functions as static inline in .c files and remove dead code it was hiding. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git

[PATCH net-next 01/14] nfp: simplify nfp_net_poll()

2016-10-31 Thread Jakub Kicinski
There are few variables in nfp_net_poll() which are used only once or unused but set. Remove them. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git

[PATCH net-next 00/14] cleanups and RX path rewrite

2016-10-31 Thread Jakub Kicinski
Hi! This series lays groundwork for upcoming XDP support by updating the RX path not to pre-allocate sk_buffs. I start with few cleanups, removal of NFP3200-related code being the most significant. Patch 7 moves to alloc_frag() and build_skb() APIs. Again, a number of small cleanups follow.

[PATCH 1/2] can: sja1000: plx_pci: Add support for Moxa CAN devices

2016-10-31 Thread Marc Kleine-Budde
From: Lukas Resch This patch adds support for Moxa CAN devices. Signed-off-by: Lukas Resch Signed-off-by: Christoph Zehentner Signed-off-by: Marc Kleine-Budde --- drivers/net/can/sja1000/plx_pci.c

Re: [patch net] mlxsw: spectrum: Fix incorrect reuse of MID entries

2016-10-31 Thread Ido Schimmel
Hi, On Mon, Oct 31, 2016 at 03:36:06PM -0400, David Miller wrote: > From: Jiri Pirko > Date: Sun, 30 Oct 2016 10:09:22 +0100 > > > From: Ido Schimmel > > > > In the device, a MID entry represents a group of local ports, which can > > later be bound to a

pull-request: can 2016-10-31

2016-10-31 Thread Marc Kleine-Budde
-fixes-for-4.9-20161031 for you to fetch changes up to deb507f91f1adbf64317ad24ac46c56eeccfb754: can: bcm: fix warning in bcm_connect/proc_register (2016-10-31 20:48:19 +0100) linux-can-fixes-for-4.9-20161031

[PATCH 2/2] can: bcm: fix warning in bcm_connect/proc_register

2016-10-31 Thread Marc Kleine-Budde
From: Oliver Hartkopp Andrey Konovalov reported an issue with proc_register in bcm.c. As suggested by Cong Wang this patch adds a lock_sock() protection and a check for unsuccessful proc_create_data() in bcm_connect(). Reference:

[PATCH v2 net-next] net: set SK_MEM_QUANTUM to 4096

2016-10-31 Thread Eric Dumazet
From: Eric Dumazet Systems with large pages (64KB pages for example) do not always have huge quantity of memory. A big SK_MEM_QUANTUM value leads to fewer interactions with the global counters (like tcp_memory_allocated) but might trigger memory pressure much faster, giving

Re: XDP question - how much can BPF change in xdp_buff?

2016-10-31 Thread Tom Herbert
On Mon, Oct 31, 2016 at 11:31 AM, Mintz, Yuval wrote: > So I've [finally] started looking into implementing XDP > for qede, and there's one thing I feel like I'm missing in > regard to XDP_TX - what's the guarantee/requirement > that the bpf program isn't going to

Re: [PATCH net-next] genetlink: fix error return code in genl_register_family()

2016-10-31 Thread David Miller
From: Wei Yongjun Date: Mon, 31 Oct 2016 14:53:03 + > From: Wei Yongjun > > Fix to return error code -ENOMEM from the idr_alloc() error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 2ae0f17df1cd ("genetlink: use

Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup

2016-10-31 Thread David Miller
From: marcelo.leit...@gmail.com Date: Mon, 31 Oct 2016 18:13:02 -0200 > On Mon, Oct 31, 2016 at 03:53:48PM -0400, David Miller wrote: >> From: Xin Long >> Date: Mon, 31 Oct 2016 00:42:35 +0800 >> >> > Prior to this patch, it used a local variable to save the transport that

[PATCH net-next 0/2] qed*: Fixes to "Allow unicast filtering"

2016-10-31 Thread Yuval Mintz
Commit 7b7e70f979e3 ("qed*: Allow unicast filtering") introduced several issues in driver. This series is intended to address and fix those. Dave, These are fixes but I believe the original commit hasn't reached net yet. So please consider applying these to `net-next'. Thanks, Yuval Yuval

[PATCH net-next 1/2] qede: Don't override priv_flags

2016-10-31 Thread Yuval Mintz
Driver is now setting the ndev's priv_flags instead of adding to it, causing pktgen failure to utilize various features due to the loss of the IFF_TX_SKB_SHARING indication. Fixes: 7b7e70f979e3 ("qed*: Allow unicast filtering") Signed-off-by: Yuval Mintz ---

[PATCH net-next 2/2] qed: Correct VF mac number

2016-10-31 Thread Yuval Mintz
When relaxing the limitation on the number of unicast MAC filters an interface can configure, qed started passing the MAC quota to qede. However, the value is initialized only for PFs, causing VFs to always try and configure themselves as promiscuous [as they believe they lack the resources to

Re: [PATCH net-next 0/4] bridge: add support for PIM hello router ports

2016-10-31 Thread David Miller
From: Nikolay Aleksandrov Date: Mon, 31 Oct 2016 13:21:01 +0100 > The first 3 patches of this set do minor cleanups and add some helpers to > the PIM header file. Patch 4 adds a way to detect mcast router ports via > PIM hello messages, they're marked as temporary

  1   2   3   >