Re: Virtio_net support vxlan encapsulation package TSO offload discuss

2016-11-09 Thread Zhangming (James, Euler)
On 2016年11月09日 15:14, Jason Wang wrote: >On 2016年11月08日 19:58, Zhangming (James, Euler) wrote: >> On 2016年11月08日 19:17, Jason Wang wrote: >> >>> On 2016年11月08日 19:13, Jason Wang wrote: Cc Michael On 2016年11月08日 16:34, Zhangming (James, Euler) wrote: > In container scenario, OVS

Re: [Intel-wired-lan] [PATCH v2] e1000e: free IRQ regardless of __E1000_DOWN

2016-11-09 Thread Neftin, Sasha
On 11/9/2016 11:41 PM, Tyler Baicar wrote: > Move IRQ free code so that it will happen regardless of the > __E1000_DOWN bit. Currently the e1000e driver only releases its IRQ > if the __E1000_DOWN bit is cleared. This is not sufficient because > it is possible for __E1000_DOWN to be set without

Re: [v16, 0/7] Fix eSDHC host version register bug

2016-11-09 Thread Scott Wood
On Thu, 2016-11-10 at 04:11 +, Y.B. Lu wrote: > > > > -Original Message- > > From: Y.B. Lu > > Sent: Thursday, November 10, 2016 12:06 PM > > To: 'Scott Wood'; Ulf Hansson > > Cc: linux-mmc; Arnd Bergmann; linuxppc-...@lists.ozlabs.org; > > devicet...@vger.kernel.org;

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-09 Thread Kai-Heng Feng
Hi, On Wed, Nov 9, 2016 at 8:32 PM, Bjørn Mork wrote: > Oliver Neukum writes: > >> On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote: >> >>> These problems could very well be caused by running at SuperSpeed >>> (USB-3) instead of high speed (USB-2). Yes, it's

Re: [v16, 0/7] Fix eSDHC host version register bug

2016-11-09 Thread Scott Wood
On Wed, 2016-11-09 at 19:27 +0100, Ulf Hansson wrote: > - i2c-list > > On 9 November 2016 at 04:14, Yangbo Lu wrote: > > > > This patchset is used to fix a host version register bug in the T4240- > > R1.0-R2.0 > > eSDHC controller. To match the SoC version and revision, 15

Re: [PATCH net-next] tcp: remove unaligned accesses from tcp_get_info()

2016-11-09 Thread David Miller
From: Eric Dumazet Date: Wed, 09 Nov 2016 11:24:22 -0800 > From: Eric Dumazet > > After commit 6ed46d1247a5 ("sock_diag: align nlattr properly when > needed"), tcp_get_info() gets 64bit aligned memory, so we can avoid > the unaligned helpers. > >

[PATCH] r8152: Fix error path in open function

2016-11-09 Thread Guenter Roeck
If usb_submit_urb() called from the open function fails, the following crash may be observed. r8152 8-1:1.0 eth0: intr_urb submit failed: -19 ... r8152 8-1:1.0 eth0: v1.08.3 Unable to handle kernel paging request at virtual address 6b6b6b6b6b6b6b7b pgd = ffc0e7305000 [6b6b6b6b6b6b6b7b]

Re: [PATCH net-next v2 6/7] vxlan: simplify vxlan xmit

2016-11-09 Thread Pravin Shelar
On Wed, Nov 9, 2016 at 8:59 AM, Jiri Benc wrote: > On Sat, 5 Nov 2016 11:45:56 -0700, Pravin B Shelar wrote: >> @@ -2006,11 +2004,34 @@ static void vxlan_xmit_one(struct sk_buff *skb, >> struct net_device *dev, >> info = skb_tunnel_info(skb); >> >> if (rdst) { >> +

Re: [PATCH net-next v2 4/7] vxlan: improve vxlan route lookup checks.

2016-11-09 Thread Pravin Shelar
On Wed, Nov 9, 2016 at 8:41 AM, Jiri Benc wrote: > On Sat, 5 Nov 2016 11:45:54 -0700, Pravin B Shelar wrote: >> Move route sanity check to respective vxlan[4/6]_get_route functions. >> This allows us to perform all sanity checks before caching the dst so >> that we can avoid

Re: [PATCH net-next v2 5/7] vxlan: simplify RTF_LOCAL handling.

2016-11-09 Thread Pravin Shelar
On Wed, Nov 9, 2016 at 8:53 AM, Jiri Benc wrote: > On Sat, 5 Nov 2016 11:45:55 -0700, Pravin B Shelar wrote: >> +static int check_route_rtf_local(struct sk_buff *skb, struct net_device >> *dev, >> + struct vxlan_dev *vxlan, union vxlan_addr >>

Re: [PATCH net-next v2 3/7] vxlan: avoid checking socket multiple times.

2016-11-09 Thread Pravin Shelar
On Wed, Nov 9, 2016 at 8:34 AM, Jiri Benc wrote: > On Sat, 5 Nov 2016 11:45:53 -0700, Pravin B Shelar wrote: >> @@ -2070,11 +2072,9 @@ static void vxlan_xmit_one(struct sk_buff *skb, >> struct net_device *dev, >> struct dst_entry *ndst; >> u32

Re: [PATCH net-next v2 2/7] vxlan: simplify exception handling

2016-11-09 Thread Pravin Shelar
On Wed, Nov 9, 2016 at 8:10 AM, Jiri Benc wrote: > On Sat, 5 Nov 2016 11:45:52 -0700, Pravin B Shelar wrote: >> @@ -2058,7 +2059,7 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct >> net_device *dev, >> err = vxlan_build_skb(skb, >dst, sizeof(struct

Re: [PATCH] net: tcp response should set oif only if it is L3 master

2016-11-09 Thread David Miller
From: David Ahern Date: Wed, 9 Nov 2016 09:07:26 -0800 > Lorenzo noted an Android unit test failed due to e0d56fdd7342: > "The expectation in the test was that the RST replying to a SYN sent to a > closed port should be generated with oif=0. In other words it should

Re: [PATCH 00/17] pull request for net-next: batman-adv 2016-11-08 v2

2016-11-09 Thread David Miller
From: Simon Wunderlich Date: Wed, 9 Nov 2016 23:25:49 +0100 > this is an updated version from yesterdays pull request. Sven did changes > according to Eric Dumazets comments in Patch 13, everything else staid the > same. > > Please pull or let me know of any problem!

Re: [PATCH] net: ipv4: ip_send_unicast_reply should set oif only if it is L3 master

2016-11-09 Thread David Ahern
On 11/9/16 7:48 PM, David Miller wrote: > From: David Ahern > Date: Tue, 8 Nov 2016 14:50:31 -0800 > >> Lorenzo noted an Android unit test failed due to commit e0d56fdd7342: >> "The expectation in the test was that the RST replying to a SYN sent to a >> closed port

Re: [PATCH] net: ipv4: ip_send_unicast_reply should set oif only if it is L3 master

2016-11-09 Thread David Miller
From: David Ahern Date: Tue, 8 Nov 2016 14:50:31 -0800 > Lorenzo noted an Android unit test failed due to commit e0d56fdd7342: > "The expectation in the test was that the RST replying to a SYN sent to a > closed port should be generated with oif=0. In other words

Re: [PATCH v5] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

2016-11-09 Thread David Miller
From: Date: Tue, 8 Nov 2016 16:08:01 -0600 > From: Allan Chou > > Add support for Cypress GX3 SuperSpeed to Gigabit Ethernet > Bridge Controller (Vendor=04b4 ProdID=3610). > > Patch verified on x64 linux kernel 4.7.4, 4.8.6, 4.9-rc4 systems > with the

Re: [PATCH net-next 0/3] PHC frequency fine tuning

2016-11-09 Thread David Miller
From: Richard Cochran Date: Tue, 8 Nov 2016 22:49:15 +0100 > This series expands the PTP Hardware Clock subsystem by adding a > method that passes the frequency tuning word to the the drivers > without dropping the low order bits. Keeping those bits is useful for >

Re: [PATCH net-next 1/2] bnxt_en: do not call napi_hash_add()

2016-11-09 Thread David Miller
From: Eric Dumazet Date: Tue, 08 Nov 2016 11:06:53 -0800 > From: Eric Dumazet > > This is automatically done from netif_napi_add(), and we want to not > export napi_hash_add() anymore in the following patch. > > Signed-off-by: Eric Dumazet

Re: [PATCH net-next 2/2] net: napi_hash_add() is no longer exported

2016-11-09 Thread David Miller
From: Eric Dumazet Date: Tue, 08 Nov 2016 11:07:28 -0800 > From: Eric Dumazet > > There are no more users except from net/core/dev.c > napi_hash_add() can now be static. > > Signed-off-by: Eric Dumazet Applied.

Re: [PATCH] bpf: Remove unused but set variables

2016-11-09 Thread David Miller
From: Tobias Klauser Date: Tue, 8 Nov 2016 16:40:28 +0100 > Remove the unused but set variables min_set and max_set in > adjust_reg_min_max_vals to fix the following warning when building with > 'W=1': > > kernel/bpf/verifier.c:1483:7: warning: variable ‘min_set’ set but

Re: [PATCH net-next] tc_act: Remove tcf_act macro

2016-11-09 Thread David Miller
From: Yotam Gigi Date: Tue, 8 Nov 2016 17:24:03 +0200 > tc_act macro addressed a non existing field, and was not used in the > kernel source. > > Signed-off-by: Yotam Gigi > Reviewed-by: Jiri Pirko Applied.

Re: [PATCH net-next v5 0/9] net: add support for IPv6 Segment Routing

2016-11-09 Thread David Miller
Series applied, but I wonder if using a Kconfig knob for the INLINE thing is overkill.

Re: [PATCH] net: tcp response should set oif only if it is L3 master

2016-11-09 Thread Lorenzo Colitti
On Thu, Nov 10, 2016 at 2:07 AM, David Ahern wrote: > Revert the change to ip_send_unicast_reply and tcp_v6_send_response such > that the oif in the flow is set to the skb_iif only if skb_iif is an L3 > master. This fixes the IPv4 and IPv6 tests, thanks! Tested-by:

Re: [PATCH 00/14] Netfilter fixes for net

2016-11-09 Thread David Miller
From: Pablo Neira Ayuso Date: Thu, 10 Nov 2016 01:23:33 +0100 > The following patchset contains a larger than usual batch of Netfilter > fixes for your net tree. This series contains a mixture of old bugs and > recently introduced bugs, they are: ... >

Re: [net-next PATCH] amd-xgbe: use __maybe_unused to hide pm functions

2016-11-09 Thread David Miller
From: Arnd Bergmann Date: Tue, 8 Nov 2016 14:37:32 +0100 > The amd-xgbe ethernet driver hides its suspend/resume functions > in #ifdef CONFIG_PM, but uses SIMPLE_DEV_PM_OPS() to make the > reference conditional on CONFIG_PM_SLEEP, which results in a > warning when PM_SLEEP is not

Re: [Xen PATCH] xen-netback: fix error handling output

2016-11-09 Thread David Miller
From: Arnd Bergmann Date: Tue, 8 Nov 2016 14:34:34 +0100 > The connect function prints an unintialized error code after an > earlier initialization was removed: > > drivers/net/xen-netback/xenbus.c: In function 'connect': > drivers/net/xen-netback/xenbus.c:938:3: error: 'err'

Re: [PATCH] net: mii: report 0 for unknown lp_advertising

2016-11-09 Thread David Miller
From: Arnd Bergmann Date: Tue, 8 Nov 2016 14:31:38 +0100 > The newly introduced mii_ethtool_get_link_ksettings function sets > lp_advertising to an uninitialized value when BMCR_ANENABLE is not > set: > > drivers/net/mii.c: In function 'mii_ethtool_get_link_ksettings': >

Re: [PATCH v3] xen-netback: prefer xenbus_scanf() over xenbus_gather()

2016-11-09 Thread David Miller
From: "Jan Beulich" Date: Tue, 08 Nov 2016 00:45:53 -0700 > For single items being collected this should be preferred as being more > typesafe (as the compiler can check format string and to-be-written-to > variable match) and more efficient (requiring one less parameter to be

Re: [PATCH net-next] igmp: Document sysctl force_igmp_version

2016-11-09 Thread David Miller
From: Hangbin Liu Date: Mon, 7 Nov 2016 14:51:23 +0800 > There is some difference between force_igmp_version and force_mld_version. > Add document to make users aware of this. > > Signed-off-by: Hangbin Liu Applied, thank you.

Re: [Regression w/ patch] Restore network resistance to weird ICMP messages

2016-11-09 Thread David Miller
From: Vicente Jiménez Date: Mon, 7 Nov 2016 12:11:59 +0100 > From bfc9a00e6b78d8eb60e46dacd7d761669d29a573 Mon Sep 17 00:00:00 2001 > From: Vicente Jimenez Aguilar > Date: Mon, 31 Oct 2016 13:10:29 +0100 > Subject: [PATCH] ipv4: icmp: Fix pMTU handling for

Re: [PATCH net,v2] Fixes: 5943634fc559 ("ipv4: Maintain redirect and PMTU info in struct rtable again.")

2016-11-09 Thread David Miller
From: Stephen Suryaputra Lin Date: Mon, 7 Nov 2016 17:48:39 -0500 > ICMP redirects behavior is different after the commit above. An email > requesting the explanation on why the behavior needs to be different > was sent earlier to netdev

Re: [PATCH] rtnl: reset calcit fptr in rtnl_unregister()

2016-11-09 Thread David Miller
From: Mathias Krause Date: Mon, 7 Nov 2016 23:22:19 +0100 > To avoid having dangling function pointers left behind, reset calcit in > rtnl_unregister(), too. > > This is no issue so far, as only the rtnl core registers a netlink > handler with a calcit hook which won't

Re: linux-next: manual merge of the net-next tree with the netfilter tree

2016-11-09 Thread Pablo Neira Ayuso
Hi David, On Thu, Nov 10, 2016 at 10:56:33AM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > net/netfilter/ipvs/ip_vs_ctl.c > > between commit: > > 8fbfef7f505b ("ipvs: use IPVS_CMD_ATTR_MAX for family.maxattr") > > from

[PATCH 03/14] netfilter: nf_tables: fix race when create new element in dynset

2016-11-09 Thread Pablo Neira Ayuso
From: Liping Zhang Packets may race when create the new element in nft_hash_update: CPU0 CPU1 lookup_fast - fail lookup_fast - fail new - ok new - ok insert - ok insert - fail(EEXIST) So when race happened, we

[PATCH 02/14] netfilter: nf_tables: fix *leak* when expr clone fail

2016-11-09 Thread Pablo Neira Ayuso
From: Liping Zhang When nft_expr_clone failed, a series of problems will happen: 1. module refcnt will leak, we call __module_get at the beginning but we forget to put it back if ops->clone returns fail 2. memory will be leaked, if clone fail, we just return NULL and

[PATCH 01/14] netfilter: nft_dynset: fix panic if NFT_SET_HASH is not enabled

2016-11-09 Thread Pablo Neira Ayuso
From: Liping Zhang When CONFIG_NFT_SET_HASH is not enabled and I input the following rule: "nft add rule filter output flow table test {ip daddr counter }", kernel panic happened on my system: BUG: unable to handle kernel NULL pointer dereference at (null) IP: [<

[PATCH 04/14] netfilter: nf_conntrack_sip: extend request line validation

2016-11-09 Thread Pablo Neira Ayuso
From: Ulrich Weber on SIP requests, so a fragmented TCP SIP packet from an allow header starting with INVITE,NOTIFY,OPTIONS,REFER,REGISTER,UPDATE,SUBSCRIBE Content-Length: 0 will not bet interpreted as an INVITE request. Also Request-URI must start with an

[PATCH 11/14] netfilter: connmark: ignore skbs with magic untracked conntrack objects

2016-11-09 Thread Pablo Neira Ayuso
From: Florian Westphal The (percpu) untracked conntrack entries can end up with nonzero connmarks. The 'untracked' conntrack objects are merely a way to distinguish INVALID (i.e. protocol connection tracker says payload doesn't meet some requirements or packet was never seen by

[PATCH 00/14] Netfilter fixes for net

2016-11-09 Thread Pablo Neira Ayuso
Hi David, The following patchset contains a larger than usual batch of Netfilter fixes for your net tree. This series contains a mixture of old bugs and recently introduced bugs, they are: 1) Fix a crash when using nft_dynset with nft_set_rbtree, which doesn't support the set element updates

[PATCH 06/14] netfilter: conntrack: avoid excess memory allocation

2016-11-09 Thread Pablo Neira Ayuso
From: Florian Westphal This is now a fixed-size extension, so we don't need to pass a variable alloc size. This (harmless) error results in allocating 32 instead of the needed 16 bytes for this extension as the size gets passed twice. Fixes: 23014011ba420 ("netfilter:

[PATCH 10/14] ipvs: use IPVS_CMD_ATTR_MAX for family.maxattr

2016-11-09 Thread Pablo Neira Ayuso
From: WANG Cong family.maxattr is the max index for policy[], the size of ops[] is determined with ARRAY_SIZE(). Reported-by: Andrey Konovalov Tested-by: Andrey Konovalov Cc: Pablo Neira Ayuso

[PATCH 08/14] netfilter: nf_tables: destroy the set if fail to add transaction

2016-11-09 Thread Pablo Neira Ayuso
From: Liping Zhang When the memory is exhausted, then we will fail to add the NFT_MSG_NEWSET transaction. In such case, we should destroy the set before we free it. Fixes: 958bee14d071 ("netfilter: nf_tables: use new transaction infrastructure to handle sets")

[PATCH 05/14] netfilter: nf_tables: fix type mismatch with error return from nft_parse_u32_check

2016-11-09 Thread Pablo Neira Ayuso
From: "John W. Linville" Commit 36b701fae12ac ("netfilter: nf_tables: validate maximum value of u32 netlink attributes") introduced nft_parse_u32_check with a return value of "unsigned int", yet on error it returns "-ERANGE". This patch corrects the mismatch by changing

[PATCH 14/14] netfilter: nf_tables: fix oops when inserting an element into a verdict map

2016-11-09 Thread Pablo Neira Ayuso
From: Liping Zhang Dalegaard says: The following ruleset, when loaded with 'nft -f bad.txt' snip flush ruleset table ip inlinenat { map sourcemap { type ipv4_addr : verdict; } chain postrouting { ip saddr vmap @sourcemap accept } } add

[PATCH 13/14] netfilter: conntrack: refine gc worker heuristics

2016-11-09 Thread Pablo Neira Ayuso
From: Florian Westphal Nicolas Dichtel says: After commit b87a2f9199ea ("netfilter: conntrack: add gc worker to remove timed-out entries"), netlink conntrack deletion events may be sent with a huge delay. Nicolas further points at this line: goal =

[PATCH 09/14] netfilter: nft_dup: do not use sreg_dev if the user doesn't specify it

2016-11-09 Thread Pablo Neira Ayuso
From: Liping Zhang The NFTA_DUP_SREG_DEV attribute is not a must option, so we should use it in routing lookup only when the user specify it. Fixes: d877f07112f1 ("netfilter: nf_tables: add nft_dup expression") Signed-off-by: Liping Zhang

[PATCH 07/14] netfilter: ip_vs_sync: fix bogus maybe-uninitialized warning

2016-11-09 Thread Pablo Neira Ayuso
From: Arnd Bergmann Building the ip_vs_sync code with CONFIG_OPTIMIZE_INLINING on x86 confuses the compiler to the point where it produces a rather dubious warning message: net/netfilter/ipvs/ip_vs_sync.c:1073:33: error: ‘opt.init_seq’ may be used uninitialized in this function

[PATCH 12/14] netfilter: conntrack: fix CT target for UNSPEC helpers

2016-11-09 Thread Pablo Neira Ayuso
From: Florian Westphal Thomas reports its not possible to attach the H.245 helper: iptables -t raw -A PREROUTING -p udp -j CT --helper H.245 iptables: No chain/target/match by that name. xt_CT: No such helper "H.245" This is because H.245 registers as NFPROTO_UNSPEC, but the CT

[PATCH iproute2 -net-next] bpf: make tc's bpf loader generic and move into lib

2016-11-09 Thread Daniel Borkmann
This work moves the bpf loader into the iproute2 library and reworks the tc specific parts into generic code. It's useful as we can then more easily support new program types by just having the same ELF loader backend. Joint work with Thomas Graf. I hacked a rough start of a test suite to make

[PATCH net] net: __skb_flow_dissect() must cap its return value

2016-11-09 Thread Eric Dumazet
From: Eric Dumazet After Tom patch, thoff field could point past the end of the buffer, this could fool some callers. If an skb was provided, skb->len should be the upper limit. If not, hlen is supposed to be the upper limit. Fixes: a6e544b0a88b ("flow_dissector: Jump to

Re: [PATCH] vxlan: hide unused local variable

2016-11-09 Thread David Miller
From: Arnd Bergmann Date: Mon, 7 Nov 2016 22:09:07 +0100 > A bugfix introduced a harmless warning in v4.9-rc4: > > drivers/net/vxlan.c: In function 'vxlan_group_used': > drivers/net/vxlan.c:947:21: error: unused variable 'sock6' > [-Werror=unused-variable] > > This hides the

Re: [PATCH net-next v2 2/5] net: l2tp: only set L2TP_ATTR_UDP_CSUM if AF_INET

2016-11-09 Thread David Miller
From: Asbjoern Sloth Toennesen Date: Mon, 7 Nov 2016 20:39:25 + > Only set L2TP_ATTR_UDP_CSUM in l2tp_nl_tunnel_send() > when it's running over IPv4. > > This prepares the code to also have IPv6 specific attributes. > > Signed-off-by: Asbjoern Sloth Toennesen

linux-next: manual merge of the net-next tree with the netfilter tree

2016-11-09 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/netfilter/ipvs/ip_vs_ctl.c between commit: 8fbfef7f505b ("ipvs: use IPVS_CMD_ATTR_MAX for family.maxattr") from the netfilter tree and commit: 489111e5c25b ("genetlink: statically initialize families") from

Re: [PATCH net-next v2 1/5] net: l2tp: change L2TP_ATTR_UDP_ZERO_CSUM6_{RX,TX} attribute types

2016-11-09 Thread David Miller
From: Asbjoern Sloth Toennesen Date: Mon, 7 Nov 2016 20:39:24 + > The attributes L2TP_ATTR_UDP_ZERO_CSUM6_RX and > L2TP_ATTR_UDP_ZERO_CSUM6_TX are used as flags, > but is defined as a u8 in a comment. > > This patch redocuments them as flags. > > Adding nla_policy

Re: [PATCH net-next v2 4/5] net: l2tp: cleanup: remove redundant condition

2016-11-09 Thread David Miller
From: Asbjoern Sloth Toennesen Date: Mon, 7 Nov 2016 20:39:27 + > These assignments follow this pattern: > > unsigned int foo:1; > struct nlattr *nla = info->attrs[bar]; > > if (nla) > foo = nla_get_flag(nla); /* expands to: foo = !!nla

Re: [PATCH net-next v2 3/5] net: l2tp: netlink: l2tp_nl_tunnel_send: set UDP6 checksum flags

2016-11-09 Thread David Miller
From: Asbjoern Sloth Toennesen Date: Mon, 7 Nov 2016 20:39:26 + > This patch causes the proper attribute flags to be set, > in the case that IPv6 UDP checksums are disabled, so that > userspace ie. `ip l2tp show tunnel` knows about it. > > Signed-off-by: Asbjoern Sloth

Re: [PATCH] net: ethernet: ti: davinci_cpdma: fix fixed prio cpdma ctlr configuration

2016-11-09 Thread Ivan Khoronzhuk
On 09.11.16 23:09, Grygorii Strashko wrote: On 11/08/2016 07:10 AM, Ivan Khoronzhuk wrote: The dma ctlr is reseted to 0 while cpdma start, thus cpdma ctlr I assume this is because cpdma_ctlr_start() does soft reset. Is it correct? Probably not. I've seen this register doesn't hold any

Re: [PATCH net-next v2 5/5] net: l2tp: fix negative assignment to unsigned int

2016-11-09 Thread David Miller
From: Asbjoern Sloth Toennesen Date: Mon, 7 Nov 2016 20:39:28 + > recv_seq, send_seq and lns_mode mode are all defined as > unsigned int foo:1; > > Signed-off-by: Asbjoern Sloth Toennesen Applied.

Re: [PATCH net] ibmvnic: Start completion queue negotiation at server-provided optimum values

2016-11-09 Thread David Miller
From: John Allen Date: Mon, 7 Nov 2016 14:27:28 -0600 > Use the opt_* fields to determine the starting point for negotiating the > number of tx/rx completion queues with the vnic server. These contain the > number of queues that the vnic server estimates that it will

Re: [PATCH v2] net: icmp_route_lookup should use rt dev to determine L3 domain

2016-11-09 Thread David Miller
From: David Ahern Date: Mon, 7 Nov 2016 12:03:09 -0800 > icmp_send is called in response to some event. The skb may not have > the device set (skb->dev is NULL), but it is expected to have an rt. > Update icmp_route_lookup to use the rt on the skb to determine L3 >

linux-next: manual merge of the net-next tree with the net tree

2016-11-09 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c between commit: ee39fbc4447d ("net/mlx5: E-Switch, Set the actions for offloaded rules properly") from the net tree and commit: 66958ed906b8 ("net/mlx5:

Re: [PATCH net-next] net-gro: avoid reorders

2016-11-09 Thread David Miller
From: Eric Dumazet Date: Mon, 07 Nov 2016 11:12:27 -0800 > From: Eric Dumazet > > Receiving a GSO packet in dev_gro_receive() is not uncommon > in stacked devices, or devices partially implementing LRO/GRO > like bnx2x. GRO is implementing the

Re: [PATCH 0/2] net: qcom/emac: ensure that pause frames are enabled

2016-11-09 Thread David Miller
From: Timur Tabi Date: Mon, 7 Nov 2016 10:51:39 -0600 > The qcom emac driver experiences significant packet loss (through frame > check sequence errors) if flow control is not enabled and the phy is > not configured to allow pause frames to pass through it. Therefore, we

[PATCH net 1/2] bpf: Fix bpf_redirect to an ipip/ip6tnl dev

2016-11-09 Thread Martin KaFai Lau
If the bpf program calls bpf_redirect(dev, 0) and dev is an ipip/ip6tnl, it currently includes the mac header. e.g. If dev is ipip, the end result is IP-EthHdr-IP instead of IP-IP. The fix is to pull the mac header. At ingress, skb_postpull_rcsum() is not needed because the ethhdr should have

[PATCH net 0/2] bpf: Fix bpf_redirect to an ipip/ip6tnl dev

2016-11-09 Thread Martin KaFai Lau
Hi, This patch set fixes a bug in bpf_redirect(dev, flags) when dev is an ipip/ip6tnl. The current problem is IP-EthHdr-IP is sent out instead of IP-IP. Patch 1 adds a dev->type test similar to dev_is_mac_header_xmit() in act_mirred.c which is only available in net-next. We can consider to

[PATCH net 2/2] bpf: Add test for bpf_redirect to ipip/ip6tnl

2016-11-09 Thread Martin KaFai Lau
The test creates two netns, ns1 and ns2. The host (the default netns) has an ipip or ip6tnl dev configured for tunneling traffic to the ns2. ping VIPS from ns1 <> host <--tunnel--> ns2 (VIPs at loopback) The test is to have ns1 pinging VIPs configured at the loopback interface in ns2.

Re: [PATCH] mwifiex: fix memory leak in mwifiex_save_hidden_ssid_channels()

2016-11-09 Thread Brian Norris
On Wed, Nov 09, 2016 at 11:37:28AM +0800, Ricky Liang wrote: > kmemleak reports memory leak in mwifiex_save_hidden_ssid_channels(): > > unreferenced object 0xffc0a2914780 (size 192): > comm "ksdioirqd/mmc2", pid 2004, jiffies 4307182506 (age 820.684s) > hex dump (first 32 bytes): > 00

[PATCH net-next V5 6/9] liquidio CN23XX: device states

2016-11-09 Thread Raghu Vatsavayi
Cleaned up resource leaks during destroy resources by introducing more device states. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla

[PATCH net-next V5 9/9] liquidio CN23XX: fix for new check patch errors

2016-11-09 Thread Raghu Vatsavayi
New checkpatch script shows some errors with pre-existing driver. This patch provides fix for those errors. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla

[PATCH net-next V5 3/9] liquidio CN23XX: Mailbox support

2016-11-09 Thread Raghu Vatsavayi
Adds support for mailbox communication between PF and VF. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V5 8/9] liquidio CN23XX: copyrights changes and alignment

2016-11-09 Thread Raghu Vatsavayi
Updated copyrights comments and also changed some other comments alignments. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by:

[PATCH net-next V5 2/9] liquidio CN23XX: sysfs VF config support

2016-11-09 Thread Raghu Vatsavayi
Adds sysfs based support for enabling or disabling VFs. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V5 7/9] liquidio CN23XX: code cleanup

2016-11-09 Thread Raghu Vatsavayi
Cleaned up unnecessary comments and added some minor macros. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

Re: [PATCH 2/2] [nf-next] netfilter: fix NF_REPEAT handling

2016-11-09 Thread Pablo Neira Ayuso
On Tue, Nov 08, 2016 at 02:28:19PM +0100, Arnd Bergmann wrote: > gcc correctly identified a theoretical uninitialized variable use: > > net/netfilter/nf_conntrack_core.c: In function 'nf_conntrack_in': > net/netfilter/nf_conntrack_core.c:1125:14: error: 'l4proto' may be used > uninitialized in

[PATCH net-next V5 0/9] liquidio CN23XX VF support

2016-11-09 Thread Raghu Vatsavayi
Dave, Following is the V5 patch series for adding VF support on CN23XX devices. This version addressed: 1) Your concern for ordering of local variable declarations from longest to shortest line. 2) Removed module parameters max_vfs, num_queues_per_{p,v}f. 3) Minor changes for fixing new

[PATCH net-next V5 1/9] liquidio CN23XX: HW config for VF support

2016-11-09 Thread Raghu Vatsavayi
Adds support for configuring HW for creating VFs. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next V5 5/9] liquidio CN23XX: VF related operations

2016-11-09 Thread Raghu Vatsavayi
Adds support for VF related operations like mac address vlan and link changes. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by:

[PATCH net-next V5 4/9] liquidio CN23XX: mailbox interrupt processing

2016-11-09 Thread Raghu Vatsavayi
Adds support for mailbox interrupt processing of various commands. Signed-off-by: Raghu Vatsavayi Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

Re: [PATCH 1/2] [net-next] udp: provide udp{4,6}_lib_lookup for nf_socket_ipv{4,6}

2016-11-09 Thread Pablo Neira Ayuso
On Tue, Nov 08, 2016 at 02:28:18PM +0100, Arnd Bergmann wrote: > Since commit ca065d0cf80f ("udp: no longer use SLAB_DESTROY_BY_RCU") > the udp6_lib_lookup and udp4_lib_lookup functions are only > provided when it is actually possible to call them. > > However, moving the callers now caused a

Re: [bug report] genetlink: fix error return code in genl_register_family()

2016-11-09 Thread Cong Wang
Cc'ing netdev On Wed, Nov 9, 2016 at 1:56 AM, Dan Carpenter wrote: > Hello Wei Yongjun, > > The patch 22ca904ad70a: "genetlink: fix error return code in > genl_register_family()" from Nov 1, 2016, leads to the following > static checker warning: > >

[PATCH 01/17] batman-adv: Introduce missing headers for genetlink restructure

2016-11-09 Thread Simon Wunderlich
From: Sven Eckelmann Fixes: 56989f6d8568 ("genetlink: mark families as __ro_after_init") Fixes: 2ae0f17df1cd ("genetlink: use idr to track families") Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich ---

[PATCH 02/17] batman-adv: Mark batadv_netlink_ops as const

2016-11-09 Thread Simon Wunderlich
From: Sven Eckelmann The genl_ops don't need to be written by anyone and thus can be moved in a ro memory range. Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/netlink.c | 2 +- 1 file changed,

[PATCH 09/17] batman-adv: use consume_skb for non-dropped packets

2016-11-09 Thread Simon Wunderlich
From: Sven Eckelmann kfree_skb assumes that an skb is dropped after an failure and notes that. consume_skb should be used in non-failure situations. Such information is important for dropmonitor netlink which tells how many packets were dropped and where this drop happened.

[PATCH 08/17] batman-adv: Simple (re)broadcast avoidance

2016-11-09 Thread Simon Wunderlich
From: Linus Lüssing With this patch, (re)broadcasting on a specific interfaces is avoided: * No neighbor: There is no need to broadcast on an interface if there is no node behind it. * Single neighbor is source: If there is just one neighbor on an interface and if

[PATCH 10/17] batman-adv: Count all non-success TX packets as dropped

2016-11-09 Thread Simon Wunderlich
From: Sven Eckelmann A failure during the submission also causes dropped packets. batadv_interface_tx should therefore also increase the DROPPED counter for these returns. Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich

[PATCH 06/17] batman-adv: Remove unused skb_reset_mac_header()

2016-11-09 Thread Simon Wunderlich
From: Linus Lüssing During broadcast queueing, the skb_reset_mac_header() sets the skb to a place invalid for a MAC header, pointing right into the batman-adv broadcast packet. Luckily, no one seems to actually use eth_hdr(skb) afterwards until batadv_send_skb_packet()

[PATCH 05/17] batman-adv: Remove unnecessary lockdep in batadv_mcast_mla_list_free

2016-11-09 Thread Simon Wunderlich
From: Linus Lüssing batadv_mcast_mla_list_free() just frees some leftovers of a local feast in batadv_mcast_mla_update(). No lockdep needed as it has nothing to do with bat_priv->mcast.mla_list. Signed-off-by: Linus Lüssing Signed-off-by:

[PATCH 04/17] batman-adv: Add wrapper for ARP reply creation

2016-11-09 Thread Simon Wunderlich
From: Linus Lüssing Removing duplicate code. Signed-off-by: Linus Lüssing Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/distributed-arp-table.c | 67

[PATCH 12/17] batman-adv: Consume skb in batadv_send_skb_to_orig

2016-11-09 Thread Simon Wunderlich
From: Sven Eckelmann Sending functions in Linux consume the supplied skbuff. Doing the same in batadv_send_skb_to_orig avoids the hack of returning -1 (-EPERM) to signal the caller that he is responsible for cleaning up the skb. Signed-off-by: Sven Eckelmann

[PATCH 13/17] batman-adv: Consume skb in receive handlers

2016-11-09 Thread Simon Wunderlich
From: Sven Eckelmann Receiving functions in Linux consume the supplied skbuff. Doing the same in the batadv_rx_handler functions makes the behavior more similar to the rest of the Linux network code. Signed-off-by: Sven Eckelmann Signed-off-by: Simon

[PATCH 07/17] batman-adv: Use own timer for multicast TT and TVLV updates

2016-11-09 Thread Simon Wunderlich
From: Linus Lüssing Instead of latching onto the OGM period, this patch introduces a worker dedicated to multicast TT and TVLV updates. The reasoning is, that upon roaming especially the translation table should be updated timely to minimize connectivity issues. With

[PATCH 16/17] batman-adv: Disallow zero and mcast src address for mgmt frames

2016-11-09 Thread Simon Wunderlich
From: Sven Eckelmann The routing check for management frames is validating the source mac address in the outer ethernet header. It rejects every source mac address which is a broadcast address. But it also has to reject the zero-mac address and multicast mac addresses.

[PATCH 11/17] batman-adv: Consume skb in batadv_frag_send_packet

2016-11-09 Thread Simon Wunderlich
From: Sven Eckelmann Sending functions in Linux consume the supplied skbuff. Doing the same in batadv_frag_send_packet avoids the hack of returning -1 (-EPERM) to signal the caller that he is responsible for cleaning up the skb. Signed-off-by: Sven Eckelmann

[PATCH 03/17] batman-adv: Close two alignment holes in batadv_hard_iface

2016-11-09 Thread Simon Wunderlich
From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich --- net/batman-adv/types.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/batman-adv/types.h

[PATCH 14/17] batman-adv: Remove dev_queue_xmit return code exception

2016-11-09 Thread Simon Wunderlich
From: Sven Eckelmann No caller of batadv_send_skb_to_orig is expecting the results to be -1 (-EPERM) anymore when the skbuff was not consumed. They will instead expect that the skbuff is always consumed. Having such return code filter is therefore not needed anymore.

[PATCH 17/17] batman-adv: Reject unicast packet with zero/mcast dst address

2016-11-09 Thread Simon Wunderlich
From: Sven Eckelmann An unicast batman-adv packet cannot be transmitted to a multicast or zero mac address. So reject incoming packets which still have these classes of addresses as destination mac address in the outer ethernet header. Signed-off-by: Sven Eckelmann

[PATCH 15/17] batman-adv: Disallow mcast src address for data frames

2016-11-09 Thread Simon Wunderlich
From: Sven Eckelmann The routing checks are validating the source mac address of the outer ethernet header. They reject every source mac address which is a broadcast address. But they also have to reject any multicast mac addresses. Signed-off-by: Sven Eckelmann

[PATCH 00/17] pull request for net-next: batman-adv 2016-11-08 v2

2016-11-09 Thread Simon Wunderlich
Hi David, this is an updated version from yesterdays pull request. Sven did changes according to Eric Dumazets comments in Patch 13, everything else staid the same. Please pull or let me know of any problem! Thank you, Simon The following changes since commit

Re: [PATCH 1/6] dt-bindings: mdio-mux: Add documentation for mdio mux for NSP SoC

2016-11-09 Thread Scott Branden
One change On 16-11-09 01:33 AM, Yendapally Reddy Dhananjaya Reddy wrote: Add documentation for mdio mux available in Broadcom NSP SoC Signed-off-by: Yendapally Reddy Dhananjaya Reddy --- .../devicetree/bindings/net/brcm,mdio-mux-nsp.txt | 57

  1   2   3   >