PLEASE VIEW THE ATTACHED FILE AND CONTACT ME.

FROM FIRST NATIONAL BANK OF SOUTH AFRICA (F.N.B)..rtf Description: MS-Word document

Re: stmmac/RTL8211F/Meson GXBB: TX throughput problems

Hello Martin On 11/7/2016 6:37 PM, Martin Blumenstingl wrote: Hi Peppe, On Mon, Nov 7, 2016 at 11:59 AM, Giuseppe CAVALLARO wrote: In the meantime, I will read again the thread just to see if there is something I am missing. if you are re-reading this thread: please

Re: [PATCH net] net: stmmac: Fix lack of link transition for fixed PHYs

On 11/14/2016 2:50 AM, Florian Fainelli wrote: Commit 52f95bbfcf72 ("stmmac: fix adjust link call in case of a switch is attached") added some logic to avoid polling the fixed PHY and therefore invoking the adjust_link callback more than once, since this is a fixed PHY and link events won't be

RE: [PATCH net 2/2] r8152: rx descriptor check

Mark Lord [mailto:ml...@pobox.com] > Sent: Monday, November 14, 2016 4:34 AM [...] > Perhaps the driver > is somehow accessing the buffer space again after doing usb_submit_urb()? > That would certainly produce this kind of behaviour. I don't think so. First, the driver only read the received

RE: [PATCH net 2/2] r8152: rx descriptor check

David Miller [mailto:da...@davemloft.net] > Sent: Monday, November 14, 2016 1:40 AM [...] > If you add this patch now, there is a much smaller likelyhood that you > will work with a high priority to figure out _why_ this is happening. > > For all we know this could be a platform bug in the DMA

Re: Long delays creating a netns after deleting one (possibly RCU related)

On Fri, Nov 11, 2016 at 4:55 PM, Cong Wang wrote: > On Fri, Nov 11, 2016 at 4:23 PM, Paul E. McKenney > wrote: >> >> Ah! This net_mutex is different than RTNL. Should synchronize_net() be >> modified to check for net_mutex being held in

RE: [PATCH net 2/2] r8152: rx descriptor check

Francois Romieu [mailto:rom...@fr.zoreil.com] > Sent: Friday, November 11, 2016 8:13 PM [...] > Invalid packet size corrupted receive descriptors in Realtek's device > reminds of CVE-2009-4537. Do you mean that the driver would get a packet exceed the size which is set to RxMaxSize? I check it

Re: [PATCH] genetlink: fix unsigned int comparison with less than zero

On Sun, Nov 13, 2016 at 9:15 AM, David Miller wrote: > I've commited the following to net-next: > > > [PATCH] genetlink: Make family a signed integer. > > The idr_alloc(), idr_remove(), et al. routines all expect IDs to be > signed integers. Therefore

Re: [LKP] [net] 2ab9fb18c4: kernel BUG at include/linux/skbuff.h:1935!

On 11/14, Fengguang Wu wrote: >>>Hi guys. >>> >>>I took a look at the commit again and I do not see how this can happen. >>> >>>Are you sure patch was properly applied ? >>> >>>In particular, the following extract is obscure for me : >>> >>> https://github.com/0day-ci/linux

[PATCH net-next v3 2/7] vxlan: avoid checking socket multiple times.

Check the vxlan socket in vxlan6_getroute(). Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 756d826..9adeff9 100644 --- a/drivers/net/vxlan.c

[PATCH net-next v3 3/7] vxlan: simplify exception handling

vxlan egress path error handling has became complicated, it need to handle IPv4 and IPv6 tunnel cases. Earlier patch removes vlan handling from vxlan_build_skb(), so vxlan_build_skb does not need to free skb and we can simplify the xmit path by having single error handling for both type of

[PATCH net-next v3 1/7] vxlan: avoid vlan processing in vxlan device.

VxLan device does not have special handling for vlan taging on egress. Therefore it does not make sense to expose vlan offloading feature. This patch does not change vxlan functinality. Signed-off-by: Pravin B Shelar Acked-by: Jiri Benc ---

[PATCH net-next v3 7/7] vxlan: remove unsed vxlan_dev_dst_port()

Signed-off-by: Pravin B Shelar --- include/net/vxlan.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/include/net/vxlan.h b/include/net/vxlan.h index 308adc4..49a5920 100644 --- a/include/net/vxlan.h +++ b/include/net/vxlan.h @@ -281,16 +281,6 @@ struct vxlan_dev

[PATCH net-next v3 4/7] vxlan: improve vxlan route lookup checks.

Move route sanity check to respective vxlan[4/6]_get_route functions. This allows us to perform all sanity checks before caching the dst so that we can avoid these checks on subsequent packets. This give move accurate metadata information for packet from fill_metadata_dst(). Signed-off-by: Pravin

[PATCH net-next v3 5/7] vxlan: simplify RTF_LOCAL handling.

Avoid code duplicate code for handling RTF_LOCAL routes. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 85 - 1 file changed, 51 insertions(+), 34 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c

[PATCH net-next v3 0/7] vxlan: xmit improvements.

Following patch series improves vxlan fast path, removes duplicate code and simplifies vxlan xmit code path. v2-v3: Removed unrelated warning fix from patch 2. rearranged error handling from patch 3 Fixed stats updates in vxlan route lookup in patch 4 v1-v2: Fix compilation error when IPv6

[PATCH net-next v3 6/7] vxlan: simplify vxlan xmit

Existing vxlan xmit function handles two distinct cases. 1. vxlan net device 2. vxlan lwt device. By seperating initialization these two cases the egress path looks better. Signed-off-by: Pravin B Shelar Acked-by: Jiri Benc --- drivers/net/vxlan.c | 78

Re: [PATCH 00/39] Netfilter updates for net-next

From: Pablo Neira Ayuso Date: Sun, 13 Nov 2016 23:24:54 +0100 > The following patchset contains a second batch of Netfilter updates > for your net-next tree. This includes a rework of the core hook > infrastructure that improves Netfilter performance by ~15% according > to

Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

On 10/31/16 11:49 AM, Thomas Graf wrote: > On 10/31/16 at 06:16pm, Daniel Mack wrote: >> On 10/31/2016 06:05 PM, David Ahern wrote: >>> On 10/31/16 11:00 AM, Daniel Mack wrote: Yeah, I'm confused too. I changed that name in my v7 from BPF_PROG_TYPE_CGROUP_SOCK to

Re: [PATCH net-next] mdio: Demote print from info to debug in mdio_driver_register

On Sun, Nov 13, 2016 at 07:01:17PM -0800, Florian Fainelli wrote: > While it is useful to know which MDIO driver is being registered, demote > the pr_info() to a pr_debug(). > > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next 00/11] Start adding support for mv88e6390 family

From: Andrew Lunn Date: Sun, 13 Nov 2016 21:24:03 +0100 > What seems to be the issue is you said you have accepted: > > [PATCH net-next 0/2] Fixes for port refactoring > https://marc.info/?l=linux-netdev=147880114928996=1 > > Yet i don't see these in net-next. And i based this

Re: [LKP] [net] 2ab9fb18c4: kernel BUG at include/linux/skbuff.h:1935!

Hi guys. I took a look at the commit again and I do not see how this can happen. Are you sure patch was properly applied ? In particular, the following extract is obscure for me : https://github.com/0day-ci/linux Eric-Dumazet/net-__skb_flow_dissect-must-cap-its-return-value/20161110-080839

[PATCH net-next] mdio: Demote print from info to debug in mdio_driver_register

While it is useful to know which MDIO driver is being registered, demote the pr_info() to a pr_debug(). Signed-off-by: Florian Fainelli --- drivers/net/phy/mdio_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mdio_device.c

Re: [PATCH net 2/3] bpf, mlx5: fix various refcount/prog issues in mlx5e_xdp_set

On Mon, Nov 14, 2016 at 01:43:41AM +0100, Daniel Borkmann wrote: > There are multiple issues in mlx5e_xdp_set(): > > 1) prog can be NULL, so calling unconditionally into bpf_prog_add(prog, >priv->params.num_channels) can end badly. > > 2) The batched bpf_prog_add() should be done at an

Re: [PATCH net-next 05/11] net: dsa: mv88e6xxx: Add comment about family a device belongs to

On Mon, Nov 14, 2016 at 01:08:13PM +1100, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > Knowing the family of device belongs to helps with picking the ops > > implementation which is appropriate to the device. So add a comment to > > each structure of ops. >

Re: [PATCH net-next 08/11] net: dsa: mv88e6xxx: Add stats_get_sset_count to ops structure

Hi Andrew, Andrew Lunn writes: > Different families have different sets of statistics. Abstract this > using a stats_get_sset_count op. Each stat has a bitmap, and the ops > implementer uses a bit map mask to count the statistics which apply > for the family. > -static int

Re: [PATCH net-next v1] bpf: Use u64_to_user_ptr()

On Sun, Nov 13, 2016 at 07:44:03PM +0100, Mickaël Salaün wrote: > Replace the custom u64_to_ptr() function with the u64_to_user_ptr() > macro. > > Signed-off-by: Mickaël Salaün Thanks for following up on this one. Acked-by: Alexei Starovoitov

Re: [PATCH net-next 07/11] net: dsa: mv88e6xxx: Add mv88e6390 statistics unit init

Hi Andrew, Andrew Lunn writes: > The statistics unit on the mv88e6390 needs to the configured in a > different register to the others as to what histogram statistics is > should return. Can you re-phrase the above please? > +static int mv88e6390_stats_init(struct

Re: [PATCH net-next 03/11] net: dsa: mv88e6xxx: Add the mv88e6390 family

Hi Andrew, Andrew Lunn writes: > -- compatible : Should be one of "marvell,mv88e6085", > +- compatible: Should be one of "marvell,mv88e6085" or > + "marvell,mv88e6390" Just curious here, mv88e6085 was choosen because it was the smaller

Re: [net] 2ab9fb18c4: kernel BUG at include/linux/skbuff.h:1935!

On 11/13, Eric Dumazet wrote: >On Mon, 2016-11-14 at 07:49 +0800, kernel test robot wrote: >> FYI, we noticed the following commit: > > >> in testcase: kbuild >> with following parameters: >> >> runtime: 300s >> nr_task: 50% >> cpufreq_governor: performance >> >> >> >> >> on

Re: [PATCH net-next 05/11] net: dsa: mv88e6xxx: Add comment about family a device belongs to

Hi Andrew, Andrew Lunn writes: > Knowing the family of device belongs to helps with picking the ops > implementation which is appropriate to the device. So add a comment to > each structure of ops. This commit is not necessary. mv88e6xxx_ops structure must be per-chip, and the

[PATCH net] net: stmmac: Fix lack of link transition for fixed PHYs

Commit 52f95bbfcf72 ("stmmac: fix adjust link call in case of a switch is attached") added some logic to avoid polling the fixed PHY and therefore invoking the adjust_link callback more than once, since this is a fixed PHY and link events won't be generated. This works fine the first time,

Re: [net] 2ab9fb18c4: kernel BUG at include/linux/skbuff.h:1935!

On Mon, 2016-11-14 at 07:49 +0800, kernel test robot wrote: > FYI, we noticed the following commit: > in testcase: kbuild > with following parameters: > > runtime: 300s > nr_task: 50% > cpufreq_governor: performance > > > > > on test machine: 8 threads Intel(R) Atom(TM)

Re: [PATCH net-next 02/11] net: dsa: mv88e6xxx: Fix unused variable warning by using variable

Hi Andrew, Andrew Lunn writes: > _mv88e6xxx_stats_wait() did not check the return value from > mv88e6xxx_g1_read(), so the compiler complained about set but unused > err. > > Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot

Re: [PATCH net-next 01/11] net: dsa: mv88e6xxx: Take switch out of reset before probe

Hi Andrew, Andrew Lunn writes: > The switch needs to be taken out of reset before we can read its ID > register on the MDIO bus. > > Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot Thanks, Vivien

[PATCH net 0/3] Couple of BPF refcount fixes for mlx5

Various mlx5 bugs on eBPF program and refcount handling I found during review. Since these kind of bugs happened multiple times here, I'll add a __must_check to the bpf_prog_inc()/bpf_prog_add()/etc functions for net-next, so these things will let the compiler (and thus kbuild bot) bark early

[PATCH net 2/3] bpf, mlx5: fix various refcount/prog issues in mlx5e_xdp_set

There are multiple issues in mlx5e_xdp_set(): 1) prog can be NULL, so calling unconditionally into bpf_prog_add(prog, priv->params.num_channels) can end badly. 2) The batched bpf_prog_add() should be done at an earlier point in time. This makes sure that we cannot fail anymore at the time

[PATCH net 1/3] bpf, mlx5: fix mlx5e_create_rq taking reference on prog

In mlx5e_create_rq(), when creating a new queue, we call bpf_prog_add() but without checking the return value. bpf_prog_add() can fail, so we really must check it. Take the reference right when we assign it to the rq from priv->xdp_prog, and just drop the reference on error path. Destruction in

[PATCH net 3/3] bpf, mlx5: drop priv->xdp_prog reference on netdev cleanup

mlx5e_xdp_set() is currently the only place where we drop reference on the prog sitting in priv->xdp_prog when it's exchanged by a new one. We also need to make sure that we eventually release that reference, for example, in case the netdev is dismantled. Fixes: 86994156c736 ("net/mlx5e: XDP fast

[PATCH net-next 1/1] driver: macvlan: Replace integer number with bool value

From: Gao Feng The return value of function macvlan_addr_busy is used as bool value, so use bool value instead of integer number "1" and "0". Signed-off-by: Gao Feng --- drivers/net/macvlan.c | 10 +- 1 file changed, 5 insertions(+), 5

Re: [PATCH] Fixup packets with incorrect ethertype sent by ZTE MF821D

So here's another stab. The comments and the current implementation are not in sync: any non-multicast address starting with a null octet gets rewritten, while the comment specifically mentions 00:a0:c6:00:00:00. It is certainly not elegant but re-writing all unicast destinations with our address

Re: [PATCH net-next 04/11] net: dsa: mv88e6xxx: Abstract stats_snapshot into ops structure

Hi Andrew, Andrew Lunn writes: > +static int mv88e6320_stats_snapshot(struct mv88e6xxx_chip *chip, int port) > +{ > + port = (port + 1) << 5; > + > + return _mv88e6xxx_stats_snapshot(chip, port); > +} Please move the above helper in its internal SMI file (port, global1

Re: [PATCH net-next v1] bpf: Use u64_to_user_ptr()

On 11/13/2016 07:44 PM, Mickaël Salaün wrote: Replace the custom u64_to_ptr() function with the u64_to_user_ptr() macro. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnd Bergmann Cc: Daniel Borkmann Looks

[PATCH v3] ip6_output: ensure flow saddr actually belongs to device

This puts the IPv6 routing functions in parity with the IPv4 routing functions. Namely, we now check in v6 that if a flowi6 requests an saddr, the returned dst actually corresponds to a net device that has that saddr. This mirrors the v4 logic with __ip_dev_find in __ip_route_output_key_hash. In

[PATCH] net: bnx2: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/broadcom/bnx2.c | 74 +++--- 1 files changed, 41 insertions(+), 33 deletions(-)

[PATCH 13/39] netfilter: conntrack: simplify init/uninit of L4 protocol trackers

From: Davide Caratti modify registration and deregistration of layer-4 protocol trackers to facilitate inclusion of new elements into the current list of builtin protocols. Both builtin (TCP, UDP, ICMP) and non-builtin (DCCP, GRE, SCTP, UDPlite) layer-4 protocol trackers

[PATCH 06/39] netfilter: nf_tables: use hook state from xt_action_param structure

Don't copy relevant fields from hook state structure, instead use the one that is already available in struct xt_action_param. This patch also adds a set of new wrapper functions to fetch relevant hook state structure fields. Signed-off-by: Pablo Neira Ayuso ---

[PATCH 02/39] netfilter: remove comments that predate rcu days

We cannot block/sleep on nf_iterate because netfilter runs under rcu read lock these days, where blocking is well-known to be illegal. So let's remove these old comments. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/core.c | 7 --- 1 file changed, 7 deletions(-)

[PATCH 36/39] netfilter: ipset: use setup_timer() and mod_timer().

From: Jozsef Kadlecsik Use setup_timer() and instead of init_timer(), being the preferred way of setting up a timer. Also, quoting the mod_timer() function comment: -> mod_timer() is a more efficient way to update the expire field of an active timer (if the timer is

[PATCH 18/39] netfilter: ipset: Headers file cleanup

From: Jozsef Kadlecsik Group counter helper functions together. Ported from a patch proposed by Sergey Popovich . Suggested-by: Sergey Popovich Signed-off-by: Jozsef Kadlecsik ---

[PATCH 03/39] netfilter: kill NF_HOOK_THRESH() and state->tresh

Patch c5136b15ea36 ("netfilter: bridge: add and use br_nf_hook_thresh") introduced br_nf_hook_thresh(). Replace NF_HOOK_THRESH() by br_nf_hook_thresh from br_nf_forward_finish(), so we have no more callers for this macro. As a result, state->thresh and explicit thresh parameter in the hook state

[PATCH 22/39] netfilter: ipset: Separate memsize calculation code into dedicated function

From: Jozsef Kadlecsik Hash types already has it's memsize calculation code in separate functions. Clean up and do the same for *bitmap* and *list* sets. Ported from a patch proposed by Sergey Popovich . Suggested-by: Sergey Popovich

[PATCH 39/39] netfilter: x_tables: simplify IS_ERR_OR_NULL to NULL test

From: Julia Lawall Since commit 7926dbfa4bc1 ("netfilter: don't use mutex_lock_interruptible()"), the function xt_find_table_lock can only return NULL on an error. Simplify the call sites and update the comment before the function. The semantic patch that change the code

[PATCH 00/39] Netfilter updates for net-next

Hi David, The following patchset contains a second batch of Netfilter updates for your net-next tree. This includes a rework of the core hook infrastructure that improves Netfilter performance by ~15% according to synthetic benchmarks. Then, a large batch with ipset updates, including a new

[PATCH 09/39] netfilter: merge nf_iterate() into nf_hook_slow()

nf_iterate() has become rather simple, we can integrate this code into nf_hook_slow() to reduce the amount of LOC in the core path. However, we still need nf_iterate() around for nf_queue packet handling, so move this function there where we only need it. I think it should be possible to refactor

[PATCH 08/39] netfilter: remove hook_entries field from nf_hook_state

This field is only useful for nf_queue, so store it in the nf_queue_entry structure instead, away from the core path. Pass hook_head to nf_hook_slow(). Since we always have a valid entry on the first iteration in nf_iterate(), we can use 'do { ... } while (entry)' loop instead. Signed-off-by:

[PATCH 30/39] netfilter: ipset: Make sure element data size is a multiple of u32

From: Jozsef Kadlecsik Data for hashing required to be array of u32. Make sure that element data always multiple of u32. Ported from a patch proposed by Sergey Popovich . Signed-off-by: Jozsef Kadlecsik ---

[PATCH 33/39] netfilter: ipset: Collapse same condition body to a single one

From: Jozsef Kadlecsik The set full case (with net_ratelimit()-ed pr_warn()) is already handled, simply jump there. Signed-off-by: Jozsef Kadlecsik --- net/netfilter/ipset/ip_set_hash_gen.h | 8 +--- 1 file changed, 1 insertion(+), 7

[PATCH 26/39] netfilter: ipset: Count non-static extension memory for userspace

From: Jozsef Kadlecsik Non-static (i.e. comment) extension was not counted into the memory size. A new internal counter is introduced for this. In the case of the hash types the sizes of the arrays are counted there as well so that we can avoid to scan the whole set

[PATCH 23/39] netfilter: ipset: Regroup ip_set_put_extensions and add extern

From: Jozsef Kadlecsik Cleanup: group ip_set_put_extensions and ip_set_get_extensions together and add missing extern. Signed-off-by: Jozsef Kadlecsik --- include/linux/netfilter/ipset/ip_set.h | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH 38/39] netfilter: conntrack: remove unused netns_ct member

From: Florian Westphal since 23014011ba420 ('netfilter: conntrack: support a fixed size of 128 distinct labels') this isn't needed anymore. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- include/net/netns/conntrack.h

[PATCH 17/39] netfilter: ipset: Mark some helper args as const.

From: Jozsef Kadlecsik Mark some of the helpers arguments as const. Ported from a patch proposed by Sergey Popovich . Suggested-by: Sergey Popovich Signed-off-by: Jozsef Kadlecsik ---

[PATCH 14/39] udp: provide udp{4,6}_lib_lookup for nf_socket_ipv{4,6}

From: Arnd Bergmann Since commit ca065d0cf80f ("udp: no longer use SLAB_DESTROY_BY_RCU") the udp6_lib_lookup and udp4_lib_lookup functions are only provided when it is actually possible to call them. However, moving the callers now caused a link error: net/built-in.o: In

[PATCH 32/39] netfilter: ipset: Make struct htype per ipset family

From: Jozsef Kadlecsik Before this patch struct htype created at the first source of ip_set_hash_gen.h and it is common for both IPv4 and IPv6 set variants. Make struct htype per ipset family and use NLEN to make nets array fixed size to simplify struct htype

[PATCH 31/39] netfilter: ipset: Optimize hash creation routine

From: Jozsef Kadlecsik Exit as easly as possible on error and use RCU_INIT_POINTER() as set is not seen at creation time. Signed-off-by: Jozsef Kadlecsik --- net/netfilter/ipset/ip_set_hash_gen.h | 63 --- 1

[PATCH 35/39] netfilter: ipset: hash:ipmac type support added to ipset

From: Tomasz Chilinski Introduce the hash:ipmac type. Signed-off-by: Tomasz Chili??ski Signed-off-by: Jozsef Kadlecsik --- net/netfilter/ipset/Kconfig | 9 + net/netfilter/ipset/Makefile

[PATCH 12/39] netfilter: nf_tables: simplify the basic expressions' init routine

From: Liping Zhang Some basic expressions are built into nf_tables.ko, such as nft_cmp, nft_lookup, nft_range and so on. But these basic expressions' init routine is a little ugly, too many goto errX labels, and we forget to call nft_range_module_exit in the exit routine,

[PATCH 21/39] netfilter: ipset: Split extensions into separate files

From: Jozsef Kadlecsik Cleanup to separate all extensions into individual files. Ported from a patch proposed by Sergey Popovich . Suggested-by: Sergey Popovich Signed-off-by: Jozsef Kadlecsik

[PATCH 28/39] netfilter: ipset: Simplify mtype_expire() for hash types

From: Jozsef Kadlecsik Remove one leve of intendation by using continue while iterating over elements in bucket. Ported from a patch proposed by Sergey Popovich . Signed-off-by: Jozsef Kadlecsik ---

[PATCH 29/39] netfilter: ipset: Make NLEN compile time constant for hash types

From: Jozsef Kadlecsik Hash types define HOST_MASK before inclusion of ip_set_hash_gen.h and the only place where NLEN needed to be calculated at runtime is *_create() method. Ported from a patch proposed by Sergey Popovich . Signed-off-by:

[PATCH 05/39] netfilter: x_tables: move hook state into xt_action_param structure

Place pointer to hook state in xt_action_param structure instead of copying the fields that we need. After this change xt_action_param fits into one cacheline. This patch also adds a set of new wrapper functions to fetch relevant hook state structure fields. Signed-off-by: Pablo Neira Ayuso

[PATCH 16/39] netfilter: ipset: Remove extra whitespaces in ip_set.h

From: Jozsef Kadlecsik Remove unnecessary whitespaces. Ported from a patch proposed by Sergey Popovich . Suggested-by: Sergey Popovich Signed-off-by: Jozsef Kadlecsik ---

[PATCH 15/39] netfilter: conntrack: fix NF_REPEAT handling

From: Arnd Bergmann gcc correctly identified a theoretical uninitialized variable use: net/netfilter/nf_conntrack_core.c: In function 'nf_conntrack_in': net/netfilter/nf_conntrack_core.c:1125:14: error: 'l4proto' may be used uninitialized in this function

[PATCH 34/39] netfilter: ipset: Fix reported memory size for hash:* types

From: Jozsef Kadlecsik The calculation of the full allocated memory did not take into account the size of the base hash bucket structure at some places. Signed-off-by: Jozsef Kadlecsik --- net/netfilter/ipset/ip_set_hash_gen.h | 16

[PATCH 24/39] netfilter: ipset: Add element count to hash headers

From: Eric B Munson It would be useful for userspace to query the size of an ipset hash, however, this data is not exposed to userspace outside of counting the number of member entries. This patch uses the attribute IPSET_ATTR_ELEMENTS to indicate the size in the the header

[PATCH 25/39] netfilter: ipset: Add element count to all set types header

From: Jozsef Kadlecsik It is better to list the set elements for all set types, thus the header information is uniform. Element counts are therefore added to the bitmap and list types. Signed-off-by: Jozsef Kadlecsik ---

[PATCH 37/39] netfilter: ipset: hash: fix boolreturn.cocci warnings

From: kbuild test robot net/netfilter/ipset/ip_set_hash_ipmac.c:70:8-9: WARNING: return of 0/1 in function 'hash_ipmac4_data_list' with return type bool net/netfilter/ipset/ip_set_hash_ipmac.c:178:8-9: WARNING: return of 0/1 in function 'hash_ipmac6_data_list' with

[PATCH 11/39] netfilter: nft_hash: get random bytes if seed is not specified

If the user doesn't specify a seed, generate one at configuration time. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nft_hash.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nft_hash.c b/net/netfilter/nft_hash.c index

[PATCH 10/39] netfilter: handle NF_REPEAT from nf_conntrack_in()

NF_REPEAT is only needed from nf_conntrack_in() under a very specific case required by the TCP protocol tracker, we can handle this case without returning to the core hook path. Handling of NF_REPEAT from the nf_reinject() is left untouched. Signed-off-by: Pablo Neira Ayuso

[PATCH 27/39] netfilter: ipset: Remove redundant mtype_expire() arguments

From: Jozsef Kadlecsik Remove redundant parameters nets_length and dsize, because they can be get from other parameters. Ported from a patch proposed by Sergey Popovich . Signed-off-by: Jozsef Kadlecsik ---

[PATCH 19/39] netfilter: ipset: Improve skbinfo get/init helpers

From: Jozsef Kadlecsik Use struct ip_set_skbinfo in struct ip_set_ext instead of open coded fields and assign structure members in get/init helpers instead of copying members one by one. Explicitly note that struct ip_set_skbinfo must be padded to prevent non-aligned

[PATCH 20/39] netfilter: ipset: Use kmalloc() in comment extension helper

From: Jozsef Kadlecsik Allocate memory with kmalloc() rather than kzalloc(): the string is immediately initialized so it is unnecessary to zero out the allocated memory area. Ported from a patch proposed by Sergey Popovich . Suggested-by:

[PATCH 04/39] netfilter: deprecate NF_STOP

NF_STOP is only used by br_netfilter these days, and it can be emulated with a combination of NF_STOLEN plus explicit call to the ->okfn() function as Florian suggests. To retain binary compatibility with userspace nf_queue application, we have to keep NF_STOP around, so libnetfilter_queue

[PATCH 07/39] netfilter: use switch() to handle verdict cases from nf_hook_slow()

Use switch() for verdict handling and add explicit handling for NF_STOLEN and other non-conventional verdicts. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/core.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git

[PATCH 01/39] netfilter: get rid of useless debugging from core

This patch remove compile time code to catch inconventional verdicts. We have better ways to handle this case these days, eg. pr_debug() but even though I don't think this is useful at all, so let's remove this. Signed-off-by: Pablo Neira Ayuso --- net/netfilter/core.c | 9

Re: [PATCH] net: stmmac: Add support for ethtool::nway_reset

Hi Florian, [auto build test WARNING on net-next/master] [also build test WARNING on next-2016] [cannot apply to v4.9-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] net: stmmac: Add support for ethtool::nway_reset

Le 13/11/2016 à 13:24, Florian Fainelli a écrit : > If we have a PHY device, just invoke genphy_restart_aneg() to restart > auto-negotiation. > > Signed-off-by: Florian Fainelli David, please drop this patch for now, since I have another one pending which is going to touch

Re: [PATCH] netfilter: x_tables: simplify IS_ERR_OR_NULL to NULL test

On Fri, Nov 11, 2016 at 01:32:38PM +0100, Julia Lawall wrote: > Since commit 7926dbfa4bc1 ("netfilter: don't use > mutex_lock_interruptible()"), the function xt_find_table_lock can only > return NULL on an error. Simplify the call sites and update the > comment before the function. Applied,

[PATCH] net: stmmac: Add support for ethtool::nway_reset

If we have a PHY device, just invoke genphy_restart_aneg() to restart auto-negotiation. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

Re: [PATCH v2] ip6_output: ensure flow saddr actually belongs to device

On 11/13/16 12:02 PM, Jason A. Donenfeld wrote: > This puts the IPv6 routing functions in parity with the IPv4 routing > functions. Namely, we now check in v6 that if a flowi6 requests an > saddr, the returned dst actually corresponds to a net device that has > that saddr. This mirrors the v4

Re: [PATCH] ip6_output: ensure flow saddr actually belongs to device

On 11/13/16 1:19 PM, Jason A. Donenfeld wrote: > I gave v2 my best shot. Hopefully it's adequate, but I have a feeling > it might be best for you to just code up what you have in mind. nah, you are doing fine. one more comment on v2.

Re: [PATCH net 2/2] r8152: rx descriptor check

On 16-11-13 03:34 PM, Mark Lord wrote: > > The system I use it with is a 32-bit ppc476, with non-coherent RAM, > and using 16KB page sizes. > > The dongle instantly becomes a lot more reliable when r8152.c is updated > to use usb_alloc_coherent() for URB buffers, rather than kmalloc(). > > Not

Re: [PATCH net 2/2] r8152: rx descriptor check

On 16-11-13 12:39 PM, David Miller wrote: > From: Hayes Wang > Date: Fri, 11 Nov 2016 15:15:41 +0800 > >> For some platforms, the data in memory is not the same with the one >> from the device. That is, the data of memory is unbelievable. The >> check is used to find out

Re: [PATCH net-next 00/11] Start adding support for mv88e6390 family

On Sun, Nov 13, 2016 at 12:48:59AM -0500, David Miller wrote: > From: Andrew Lunn > Date: Fri, 11 Nov 2016 03:53:32 +0100 > > > This is the first patchset implementing support for the mv88e6390 > > family. This is a new generation of switch devices and has numerous > >

Re: [PATCH] ip6_output: ensure flow saddr actually belongs to device

Hi David, On Sun, Nov 13, 2016 at 5:30 PM, David Ahern wrote: > You can't require the address to be on the dst device. e.g., it can be an > address from the loopback/vrf device. > > This block needs to be done at function entry, and pass dev as NULL to mean > is the

Re: [patch net v2 0/2] mlxsw: Couple of fixes

Sun, Nov 13, 2016 at 06:51:33PM CET, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Fri, 11 Nov 2016 16:34:24 +0100 > >> From: Jiri Pirko >> >> Please, queue-up both for stable. Thanks! > >Just to be clear I did make sure to take v2 rather than >v1.

Re: [PATCH net-next v2] ipv6: sr: fix IPv6 initialization failure without lwtunnels

On 11/13/2016 06:23 AM, David Miller wrote: > This seems like such a huge mess, quite frankly. > > IPV6-SR has so many strange dependencies, a weird Kconfig option that is > simply controlling what a responsible sysadmin should be allow to do if > he chooses anyways. > > Every distribution is

Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

> +static const char slic_stats_strings[][ETH_GSTRING_LEN] = { > + "rx_packets ", > + "rx_bytes ", > + "rx_multicasts ", > + "rx_errors ", > + "rx_buff_miss ", > + "rx_tp_csum ", > + "rx_tp_oflow", > + "rx_tp_hlen ", > + "rx_ip_csum

Re: Debugging Ethernet issues

Le 13/11/2016 à 11:51, Mason a écrit : > On 13/11/2016 04:09, Andrew Lunn wrote: > >> Mason wrote: >> >>> When connected to a Gigabit switch >>> 3.4 negotiates a LAN DHCP setup instantly >>> 4.7 requires over 5 seconds to do so >> >> When you run tcpdump on the DHCP server, are you noticing the

Re: Debugging Ethernet issues

On 13/11/2016 04:09, Andrew Lunn wrote: > Mason wrote: > >> When connected to a Gigabit switch >> 3.4 negotiates a LAN DHCP setup instantly >> 4.7 requires over 5 seconds to do so > > When you run tcpdump on the DHCP server, are you noticing the first > request is missing? > > What can happen

  1   2   >